omap_hsmmc: SDIO IRQ on AM335x family

2012-11-30 Thread Andreas Fenkart
Hi, I submitted following patches a while back, http://www.spinics.net/lists/linux-mmc/msg17624.html. Since there was no feedback I'm taking a step back, documenting: 1. why is it needed, missing swakeup line 2. transition, enable workaround by default 3. device tree configuration [why is it

[PATCH] gpio/omap: implement irq_enable/disable using mask/unmask.

2012-12-17 Thread Andreas Fenkart
Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com --- drivers/gpio/gpio-omap.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index d335af1..c1951ec 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c

Re: omap_hsmmc: SDIO IRQ on AM335x family

2012-12-20 Thread Andreas Fenkart
Hi, On Fri, Nov 30, 2012 at 07:57:35PM +0100, Daniel Mack wrote: On 30.11.2012 18:40, Tony Lindgren wrote: * Andreas Fenkart andreas.fenk...@streamunlimited.com [121130 03:21]: The alternative was to configure dat1 line as a GPIO, while waiting for an IRQ. Then configuring it back

[PATCH] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2012-12-20 Thread Andreas Fenkart
Without functional clock the omap_hsmmc module can't forward SDIO IRQs to the system. This patch reconfigures dat1 line as a gpio while the fclk is off. And uses SDIO IRQ detection of the module, while fclk is present. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com

Re: [PATCH] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-02-18 Thread Andreas Fenkart
Hi, On Mon, Feb 18, 2013 at 11:26:38AM +0100, Daniel Mack wrote: On 10.01.2013 21:22, Tony Lindgren wrote: * Andreas Fenkart andreas.fenk...@streamunlimited.com [121220 14:15]: Without functional clock the omap_hsmmc module can't forward SDIO IRQs to the system. This patch reconfigures

[PATCH] ARM: OMAP2+: am33xx: preserve JTAG clock aka debugss_ick.

2013-03-07 Thread Andreas Fenkart
This fixes JTAG support on am33xx. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com --- arch/arm/Kconfig.debug|6 ++ arch/arm/mach-omap2/cclock33xx_data.c | 11 --- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/arch/arm

Re: [PATCH] gpio/omap: implement irq_enable/disable using mask/unmask.

2013-03-25 Thread Andreas Fenkart
Hi, On Thu, Dec 20, 2012 at 10:16:56AM -0600, Jon Hunter wrote: On 12/19/2012 11:59 PM, Santosh Shilimkar wrote: On Monday 17 December 2012 02:57 PM, Andreas Fenkart wrote: Please add some changelog here too. :: In pm suspend the omap_hsmmc driver can't detect SDIO IRQs

gpio/omap v2: map irq_enable/disable to mask/unmask.

2013-04-11 Thread Andreas Fenkart
Hi Santosh, I submitted the following patch a while back. https://patchwork.kernel.org/patch/1886421/ As already said, the patch is straight forward, but without it, we probably will not see decent SDIO performance on am335x chips. [why it is needed] The omap_hsmmc module is suspended whenever

[PATCH v2] gpio/omap: implement irq_enable/disable using mask/unmask.

2013-04-12 Thread Andreas Fenkart
This is a resend. The single change is the added changelog https://patchwork.kernel.org/patch/1886421/ Andreas Fenkart (1): gpio/omap: implement irq_enable/disable using mask/unmask. drivers/gpio/gpio-omap.c |2 ++ 1 file changed, 2 insertions(+) -- 1.7.10.4 -- To unsubscribe from

[PATCH] gpio/omap: implement irq_enable/disable using mask/unmask.

2013-04-12 Thread Andreas Fenkart
to the interrupt status register so when unmasked later there is an interrupt straight away. However, if the interrupt is disabled then gpio events occurring will not be latched/stored. Hence proposed patch is incomplete for edge type interrupts. Signed-off-by: Andreas Fenkart andreas.fenk

[PATCH v2 0/3] omap_hsmmc: SDIO IRQ on AM335x family

2013-04-12 Thread Andreas Fenkart
want to enable it, you also need to implement enable_irq/disable_irq for omap chips. https://patchwork.kernel.org/patch/1886421/ http://permalink.gmane.org/gmane.linux.ports.arm.omap/97093 /Andi Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode. mmc: omap_hsmmc

[PATCH v2 1/3] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-04-12 Thread Andreas Fenkart
-by: Andreas Fenkart andreas.fenk...@streamunlimited.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index ed271fc..5a3df37 100644 --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt +++ b/Documentation/devicetree

[PATCH v2 2/3] mmc: omap_hsmmc: debugfs entries for GPIO mode.

2013-04-12 Thread Andreas Fenkart
Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index c52a0d1..0f9eb54 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -212,6 +212,7 @@ struct omap_hsmmc_host

[PATCH v2 3/3] mmc: omap_hsmmc: add PSTATE to debugfs regs_show.

2013-04-12 Thread Andreas Fenkart
PSTATE shows current state of data lines. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 0f9eb54..f292d1d 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -54,6

[PATCH v2] gpio/omap: implement irq mask/disable with proper semantic.

2013-04-19 Thread Andreas Fenkart
When a gpio interrupt is masked, the gpio event will still be latched in the interrupt status register so when you unmask it later you may get an interrupt straight away. However, if the interrupt is disabled then gpio events occurring will not be latched/stored. Signed-off-by: Andreas Fenkart

Re: [PATCH] gpio/omap: implement irq_enable/disable using mask/unmask.

2013-04-19 Thread Andreas Fenkart
Hi Felipe, On Fri, Apr 12, 2013 at 02:07:01PM +0300, Felipe Balbi wrote: [snip] Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com --- Patch is incomplete and still confusing ;-) if some one reads the patch without the thread. I think you have already ask the question

[PATCH v3] gpio/omap: implement irq mask/disable with proper

2013-04-22 Thread Andreas Fenkart
Added kernel doc for mask/unmask, disable/enable functions. Andreas Fenkart (1): gpio/omap: implement irq mask/disable with proper semantic. drivers/gpio/gpio-omap.c | 69 -- 1 file changed, 60 insertions(+), 9 deletions(-) -- 1.7.10.4

[PATCH v3] gpio/omap: implement irq mask/disable with proper semantic.

2013-04-22 Thread Andreas Fenkart
When a gpio interrupt is masked, the gpio event will still be latched in the interrupt status register so when you unmask it later you may get an interrupt straight away. However, if the interrupt is disabled then gpio events occurring will not be latched/stored. Signed-off-by: Andreas Fenkart

[PATCH v3 1/3] gpio/omap: replace open coded read-modify-write with _gpio_rmw function.

2013-05-14 Thread Andreas Fenkart
By also making it return the modified value, we save the readl needed to update the context. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com --- drivers/gpio/gpio-omap.c | 162 ++ 1 file changed, 50 insertions(+), 112 deletions

[PATCH v3 2/3] gpio/omap: modify wake-up register with interrupt enable.

2013-05-14 Thread Andreas Fenkart
, since the AM335x lacks a IRQWAKEN register. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com --- drivers/gpio/gpio-omap.c | 68 ++ 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio

[PATCH v3 3/3] gpio/omap: split irq_mask callback fucntion into irq_disable/irq_mask.

2013-05-14 Thread Andreas Fenkart
or disable the IRQ used was hardcoded at compile time. Wakeup functionality is completely untested, since the AM335x lacks a IRQWAKEN register. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com --- drivers/gpio/gpio-omap.c | 71 -- 1

[RESEND PATCH v2 0/3] omap_hsmmc: SDIO IRQ on AM335x family

2013-05-15 Thread Andreas Fenkart
(desc-irq_data); irq_state_set_masked(desc); } } The 4+ weeks testing mentionned in the 1st patch, was done with a dedicated irq_disable hook in gpio-omap. I'm positive that it is not needed at all, still the test was repeated for 1 day without that hook. Andreas Fenkart (3

[RESEND PATCH v2 1/3] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-05-15 Thread Andreas Fenkart
a different band. One of module was running iperf as server the other as client connecting to the server in a while true loop. Test was running for 4+ weeks. There were about 60 Mio. suspend/resume transitions. Test was shut down regularly. Signed-off-by: Andreas Fenkart andreas.fenk

[RESEND PATCH v2 2/3] mmc: omap_hsmmc: debugfs entries for GPIO mode.

2013-05-15 Thread Andreas Fenkart
Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 4db8de5..2b2ec09 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -224,6 +224,7 @@ struct omap_hsmmc_host

[RESEND PATCH v2 3/3] mmc: omap_hsmmc: add PSTATE to debugfs regs_show.

2013-05-15 Thread Andreas Fenkart
PSTATE shows current state of data lines. Signed-off-by: Andreas Fenkart andreas.fenk...@streamunlimited.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 2b2ec09..61c0254 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -53,6

Re: [RESEND PATCH v2 1/3] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-05-31 Thread Andreas Fenkart
Hi, this email adress will soon expire, my alternate email adress is afenkart at gmail.com On Mon, May 20, 2013 at 01:58:16PM -0700, Tony Lindgren wrote: * Andreas Fenkart andreas.fenk...@streamunlimited.com [130515 01:51]: Without functional clock the omap_hsmmc module can't forward SDIO

Re: [PATCH v3 1/3] gpio/omap: replace open coded read-modify-write with _gpio_rmw function.

2013-05-31 Thread Andreas Fenkart
FYI, this email adress will soon expire, this is my alternate adress: afenkart at gmail.com On Tue, May 14, 2013 at 10:54:25PM +0200, Andreas Fenkart wrote: By also making it return the modified value, we save the readl needed to update the context. Signed-off-by: Andreas Fenkart

Re: [PATCH 2/2] mmc: omap_hsmmc: Enable SDIO interrupt

2013-09-26 Thread Andreas Fenkart
are needed. Based on earlier patches [1][2] by David Vrabel david.vra...@csr.com, Steve Sakoman st...@sakoman.com and Andreas Fenkart andreas.fenk...@streamunlimited.com with the SDIO IRQ handing improved following how sdhci.c is doing it. [1] http://www.sakoman.com/cgi-bin/gitweb.cgi?p

Re: [PATCH 2/2] mmc: omap_hsmmc: Enable SDIO interrupt

2013-09-27 Thread Andreas Fenkart
2013/9/26 Tony Lindgren t...@atomide.com: Hi, * Andreas Fenkart afenk...@gmail.com [130926 01:34]: 2013/9/26 Tony Lindgren t...@atomide.com: @@ -463,27 +469,34 @@ static void omap_hsmmc_stop_clock(struct omap_hsmmc_host *host) static void omap_hsmmc_enable_irq(struct omap_hsmmc_host

[PATCH v3 0/4] mmc: omap_hsmmc: SDIO irq

2013-10-05 Thread Andreas Fenkart
Changes: - split the subject patch into normal handling and workaround for am335x - rebase Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ. mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x mmc: omap_hsmmc: debugfs for SDIO IRQ and GPIO remux Tony Lindgren (1): mmc

[PATCH v3 1/4] mmc: omap_hsmmc: Fix context save and restore for DT

2013-10-05 Thread Andreas Fenkart
From: Tony Lindgren t...@atomide.com We want to get rid of the omap specific platform init code callbacks as they don't play nice with device tree. Let's convert the context loss check to be based on a register state detection instead. Cc: Andreas Fenkart afenk...@gmail.com Cc: Balaji T K balaj

[PATCH v3 4/4] mmc: omap_hsmmc: debugfs entries for SDIO IRQ detection and GPIO remuxing.

2013-10-05 Thread Andreas Fenkart
Update the debugfs related code for the SDIO IRQ support. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index a8894ee..f7fe06f 100644

[PATCH v3 2/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-10-05 Thread Andreas Fenkart
fallback to polling, by setting 'ti,quirk-swakup-missing' in the device tree. Otherwise pending SDIO IRQ are not detected while in suspend. This affects am33xx processors. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b

[PATCH v3 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x

2013-10-05 Thread Andreas Fenkart
The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts are detected with the GPIO, while in runtime suspend, standard detection of the module block otherwise. Signed-off-by: Andreas Fenkart afenk...@gmail.com

Re: [PATCH v3 2/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-10-29 Thread Andreas Fenkart
Hi 2013/10/8 Felipe Balbi ba...@ti.com: Hi, On Sat, Oct 05, 2013 at 01:17:08PM +0200, Andreas Fenkart wrote: For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code

[PATCH 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-11-02 Thread Andreas Fenkart
From: Andreas Fenkart andreas.fenk...@dev.digitalstrom.org Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 22 +- 1 file

[PATCH 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-02 Thread Andreas Fenkart
From: Andreas Fenkart andreas.fenk...@dev.digitalstrom.org The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts are detected with the GPIO, the GPIO will only wake the module from suspend, SDIO irq detection

[PATCH 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-02 Thread Andreas Fenkart
From: Andreas Fenkart andreas.fenk...@dev.digitalstrom.org For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting

Re: [PATCH 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-11-11 Thread Andreas Fenkart
Hi, 2013/11/11 Michael Trimarchi mich...@amarulasolutions.com: Hi On Mon, Nov 11, 2013 at 7:52 PM, afenk...@gmail.com wrote: From: Andreas Fenkart afenk...@gmail.com Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed

[PATCH 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-11 Thread Andreas Fenkart
This a resend: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ. mmc: omap_hsmmc: Pin remux workaround

[PATCH 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-11 Thread Andreas Fenkart
-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 18 drivers/mmc/host/omap_hsmmc.c | 86 ++-- 2 files changed, 95 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/ti-omap

[PATCH 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-11 Thread Andreas Fenkart
the pins by Tony Lindgren as well as the implementation of omap_hsmmc_pin_init. Signed-off-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 28 ++- drivers/mmc/host/omap_hsmmc.c | 189 ++-- include/linux

[PATCH 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-11-11 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-14 Thread Andreas Fenkart
2013/11/12 Balaji T K balaj...@ti.com: On Tuesday 12 November 2013 01:36 AM, Andreas Fenkart wrote: For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any

[PATCH v3 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-17 Thread Andreas Fenkart
This a resend: - no spin_lock during register access in pm_runtime suspend/resume - reworked GPIO enable / disable logic, also suspend/resume Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ. mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x. mmc: omap_hsmmc

[PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-17 Thread Andreas Fenkart
the pins by Tony Lindgren as well as the implementation of omap_hsmmc_pin_init. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index 1136e6b..146f3ad 100644

[PATCH v3 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-17 Thread Andreas Fenkart
-by: Andreas Fenkart afenk...@gmail.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index ed271fc..1136e6b 100644 --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt +++ b/Documentation/devicetree/bindings

[PATCH v3 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-11-17 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index b94ab08..d90b4a1 100644 --- a/drivers/mmc/host

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-18 Thread Andreas Fenkart
2013/11/18 Michael Trimarchi mich...@amarulasolutions.com: Hi Andreas On Mon, Nov 18, 2013 at 8:53 AM, Andreas Fenkart afenk...@gmail.com wrote: The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-19 Thread Andreas Fenkart
Hi Ulf, 2013/11/19 Ulf Hansson ulf.hans...@linaro.org: On 18 November 2013 08:53, Andreas Fenkart afenk...@gmail.com wrote: +static irqreturn_t omap_hsmmc_cirq(int irq, void *dev_id) +{ + struct omap_hsmmc_host *host = dev_id; + unsigned long flags

Re: [PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-21 Thread Andreas Fenkart
2013/11/19 Tony Lindgren t...@atomide.com: * Balaji T K balaj...@ti.com [131119 08:00]: On Tuesday 19 November 2013 09:19 PM, Tony Lindgren wrote: * Balaji T K balaj...@ti.com [131118 08:23]: few params were passed via platform data in non-DT case and never cached in internal data

[PATCH v3 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-11-25 Thread Andreas Fenkart
the pins by Tony Lindgren as well as the implementation of omap_hsmmc_pin_init. Signed-off-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 28 ++- drivers/mmc/host/omap_hsmmc.c | 202 ++-- include/linux

[PATCH v3 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-11-25 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-25 Thread Andreas Fenkart
-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 18 drivers/mmc/host/omap_hsmmc.c | 86 ++-- 2 files changed, 95 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/ti-omap

[PATCH v3 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-11-25 Thread Andreas Fenkart
v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ. mmc

[PATCH v4 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways. Signed-off-by: Andreas Fenkart afenk...@gmail.com

[PATCH v4 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-12-02 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/mmc

[PATCH v4 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-12-02 Thread Andreas Fenkart
the pins by Tony Lindgren as well as the implementation of omap_hsmmc_pin_init. Signed-off-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 50 ++ drivers/mmc/host/omap_hsmmc.c | 180 ++-- 2 files changed, 219

Re: [PATCH v4 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
Ignore this set, I busted it. 2013/12/2 Andreas Fenkart afenk...@gmail.com: v4: - switch to interrupts-extended format - drop ti,swakeup-missing flag convert to comaptible section v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified

[PATCH v4 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ. mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x. mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux. .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 50

[PATCH v5 0/3] mmc: omap_hsmmc: enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO IRQ. mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x. mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux

[PATCH v5 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-02 Thread Andreas Fenkart
For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways. Signed-off-by: Andreas Fenkart afenk...@gmail.com

[PATCH v5 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-12-02 Thread Andreas Fenkart
the pins by Tony Lindgren as well as the implementation of omap_hsmmc_pin_init. Signed-off-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 50 ++ drivers/mmc/host/omap_hsmmc.c | 186 ++-- 2 files changed, 224

[PATCH v5 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-12-02 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/mmc

[PATCH v6 1/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2013-12-16 Thread Andreas Fenkart
For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways. Signed-off-by: Andreas Fenkart afenk...@gmail.com

[PATCH v6 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2013-12-16 Thread Andreas Fenkart
the pins by Tony Lindgren as well as the implementation of omap_hsmmc_pin_init. Signed-off-by: Andreas Fenkart afenk...@gmail.com --- .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 50 ++ drivers/mmc/host/omap_hsmmc.c | 184 ++-- 2 files changed, 222

[PATCH v6 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2013-12-16 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v7 0/4] mmc: omap_hsmmc: SDIO IRQ.

2014-02-25 Thread Andreas Fenkart
irq itself Andreas Fenkart (4): mmc: omap_hsmmc: Enable SDIO IRQ. mmc: omap_hsmmc: Remux SDIO pins within driver. mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x. mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux. .../devicetree/bindings/mmc

[PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-02-25 Thread Andreas Fenkart
For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init code callbacks any longer as we are moving to DT based booting anyways. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff

[PATCH v7 2/4] mmc: omap_hsmmc: Remux SDIO pins within driver.

2014-02-25 Thread Andreas Fenkart
. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index bd3bb0c..5e60925 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -220,6 +220,8 @@ struct omap_hsmmc_host { #define

[PATCH v7 3/4] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x.

2014-02-25 Thread Andreas Fenkart
the pins by Tony Lindgren, all bugs are mine. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index 8c8908a..8e1195e 100644 --- a/Documentation/devicetree/bindings/mmc/ti

[PATCH v7 4/4] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2014-02-25 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 452c05a..cf03481 100644 --- a/drivers/mmc/host

Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-05 Thread Andreas Fenkart
Hi, 2014-02-27 22:33 GMT+01:00 Tony Lindgren t...@atomide.com: Thanks for updating this, I finally got around to spend some time with it again. I've folded in your fixes and quirk support into my earlier patch from [0] as that had a better changelog describing the earlier work. thanks,

Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-05 Thread Andreas Fenkart
Hi, 2014-02-28 18:04 GMT+01:00 Balaji T K balaj...@ti.com: On Tuesday 25 February 2014 06:07 PM, Andreas Fenkart wrote: For now, only support SDIO interrupt if we are booted with DT. This is because some platforms need special quirks. And we don't want to add new legacy mux platform init

[PATCH v8 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-03-05 Thread Andreas Fenkart
the pins and some minor changes by Tony Lindgren. Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index 8c8908a..8e1195e

[PATCH v8 1/3] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-05 Thread Andreas Fenkart
Vrabel david.vra...@csr.com, Steve Sakoman st...@sakoman.com and Andreas Fenkart afenk...@gmail.com with the SDIO IRQ handing improved following how sdhci.c is doing it. For now, only support SDIO interrupt if we are booted with a separate wake-irq configued via device tree. This is because omaps need

[PATCH v8 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-05 Thread Andreas Fenkart
v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO interrupt mmc

[PATCH v8 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux.

2014-03-05 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-11 Thread Andreas Fenkart
Hi, 2014-03-05 17:33 GMT+01:00 Tony Lindgren t...@atomide.com: * Andreas Fenkart afenk...@gmail.com [140305 00:30]: Hi, 2014-02-27 22:33 GMT+01:00 Tony Lindgren t...@atomide.com: The wake-irq is needed for omaps with wake-up path and also when doing GPIO remuxing. So the wake-up

[PATCH v9 1/3] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-11 Thread Andreas Fenkart
Vrabel david.vra...@csr.com, Steve Sakoman st...@sakoman.com and Andreas Fenkart afenk...@gmail.com with the SDIO IRQ handing improved following how sdhci.c is doing it. For now, only support SDIO interrupt if we are booted with a separate wake-irq configued via device tree. This is because omaps need

[PATCH v9 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-11 Thread Andreas Fenkart
gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO interrupt mmc: omap_hsmmc: Pin

[PATCH v9 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-03-11 Thread Andreas Fenkart
the pins and some minor changes by Tony Lindgren. Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index 8c8908a..8e1195e

[PATCH v9 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux

2014-03-11 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH v9 resend 2/3] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-03-21 Thread Andreas Fenkart
the pins and some minor changes by Tony Lindgren. Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt index 8c8908a..8e1195e

[PATCH v9 resend 0/3] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-03-21 Thread Andreas Fenkart
gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (3): mmc: omap_hsmmc: Enable SDIO interrupt mmc: omap_hsmmc: Pin

[PATCH v9 resend 3/3] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux

2014-03-21 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH v9 resend 1/3] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-21 Thread Andreas Fenkart
Vrabel david.vra...@csr.com, Steve Sakoman st...@sakoman.com and Andreas Fenkart afenk...@gmail.com with the SDIO IRQ handing improved following how sdhci.c is doing it. For now, only support SDIO interrupt if we are booted with a separate wake-irq configued via device tree. This is because omaps need

Re: [PATCH 6/9] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-24 Thread Andreas Fenkart
2014-03-24 17:02 GMT+01:00 Ulf Hansson ulf.hans...@linaro.org: On 24 March 2014 15:59, Andreas Fenkart afenk...@gmail.com wrote: Hi, 2014-03-24 13:43 GMT+01:00 Ulf Hansson ulf.hans...@linaro.org: On 21 March 2014 17:17, Balaji T K balaj...@ti.com wrote: From: Andreas Fenkart afenk

Re: [PATCH 6/9] mmc: omap_hsmmc: Enable SDIO interrupt

2014-03-30 Thread Andreas Fenkart
Sorry missed your previous mail 2014-03-25 16:19 GMT+01:00 Balaji T K balaj...@ti.com: This seems wrong to me. What if the host is suspended (runtime PM wise) and you want to disable SDIO irq. Won't SDIO irq be kept enabled in this case? First of all, In runtime suspended state is a

[PATCH 0/5] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-04-28 Thread Andreas Fenkart
- drop ti,swakeup-missing flag convert to comaptible section v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart

[PATCH v10 2/5] mmc: omap_hsmmc: bug: abort runtime suspend if pending sdio irq detected

2014-04-28 Thread Andreas Fenkart
on the first register access. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 700fb91..e675042 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -56,6 +56,7 @@ #define OMAP_HSMMC_RSP54

[PATCH v10 1/5] mmc: omap_hsmmc: Enable SDIO interrupt

2014-04-28 Thread Andreas Fenkart
://comments.gmane.org/gmane.linux.kernel.mmc/20446 Cc: Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 272e0ee..700fb91 100644 --- a/drivers

[PATCH v10 5/5] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x

2014-04-28 Thread Andreas Fenkart
the pins by Tony Lindgren. Code contributions from Tony Lindgren and Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc

[PATCH v10 3/5] mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state

2014-04-28 Thread Andreas Fenkart
Add SDIO IRQ entries to debugfs entry. Note that PSTATE shows current state of data lines, incl. SDIO IRQ pending Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index

[PATCH v10 4/5] mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks

2014-04-28 Thread Andreas Fenkart
state needs to be set before writing to the irq registers or an IRQ might get lost. Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 76fe3bd..9cc0d21 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host

[PATCH v10 0/5] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-04-28 Thread Andreas Fenkart
ti,swakeup-missing flag convert to comaptible section v3: - removed gpio_irq from platform_data v2: - incorparated changes as suggested by reviewers - simplified workaround for am335x, gpio will now only wake the module from runtime suspend, not handle the sdio irq itself Andreas Fenkart (5

Re: [PATCH v10 1/5] mmc: omap_hsmmc: Enable SDIO interrupt

2014-04-30 Thread Andreas Fenkart
Hi Andreas, 2014-04-30 14:23 GMT+02:00 Andreas Müller schnitzelt...@googlemail.com: On Mon, Apr 28, 2014 at 9:40 AM, Andreas Fenkart afenk...@gmail.com wrote: @@ -2201,11 +2346,16 @@ static int omap_hsmmc_suspend(struct device *dev) pm_runtime_get_sync(host-dev); if (!(host

[PATCH v11 0/7] mmc: omap_hsmmc: Enable SDIO IRQ.

2014-05-08 Thread Andreas Fenkart
, not handle the sdio irq itself Andreas Fenkart (6): mmc: omap_hsmmc: compile fix for !CONFIG_OF build mmc: omap_hsmmc: Enable SDIO interrupt mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected mmc: omap_hsmmc

[PATCH v11 2/7] mmc: omap_hsmmc: Enable SDIO interrupt

2014-05-08 Thread Andreas Fenkart
://comments.gmane.org/gmane.linux.kernel.mmc/20446 Cc: Balaji T K balaj...@ti.com Signed-off-by: Andreas Fenkart afenk...@gmail.com Signed-off-by: Tony Lindgren t...@atomide.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 5042a15..f43a69e 100644 --- a/drivers

[PATCH v11 1/7] mmc: omap_hsmmc: compile fix for !CONFIG_OF build

2014-05-08 Thread Andreas Fenkart
Signed-off-by: Andreas Fenkart afenk...@gmail.com diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 8d07e2b..5042a15 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1864,6 +1864,7 @@ static inline struct omap_mmc_platform_data

  1   2   >