RE: [PM-OPP][PATCH] OMAP: Modifying the frequency comparison logic.

2010-08-24 Thread Menon, Nishanth
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 24, 2010 2:04 PM thara gopinath th...@ti.com writes: From: Thara Gopinath th...@ti.com In the current opp layer the frequency matching API's tries to match the exact

RE: [PM-OPP][PATCH] OMAP: Modifying the frequency comparison logic.

2010-08-24 Thread Menon, Nishanth
From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 24, 2010 4:14 PM Menon, Nishanth n...@ti.com writes: thara gopinath th...@ti.com writes: From: Thara Gopinath th...@ti.com [...] The above is not correct as we expect the framework to return

RE: [PM-OPP][PATCH] OMAP: Modifying the frequency comparison logic.

2010-08-25 Thread Menon, Nishanth
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, August 25, 2010 5:41 PM To: Menon, Nishanth Cc: Gopinath, Thara; linux-omap@vger.kernel.org Subject: Re: [PM-OPP][PATCH] OMAP: Modifying the frequency comparison logic. Menon, Nishanth n

RE: [PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-09-16 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gopinath, Thara [...] diff --git a/arch/arm/plat-omap/include/plat/opp.h b/arch/arm/plat- omap/include/plat/opp.h new file mode 100644 index 000..997b56e ---

RE: [PATCH 14/14] omap4: Fix bootup crash observed with higher CPU clocks

2010-09-17 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Shilimkar, Santosh Sent: Friday, September 17, 2010 4:48 AM To: linux-omap@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org; Shilimkar, Santosh; Nayak, Rajendra

RE: [PATCH 05/14] omap4: control: Add accessor api's for pad control module

2010-09-17 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Santosh Shilimkar Sent: Friday, September 17, 2010 4:48 AM On OMAP4 control pad are not addressable from control core base. So the common omap_ctrl_read/write APIs

RE: [PATCH 11/14] omap4: Fix silicon version detection for early samples

2010-09-17 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Shilimkar, Santosh Sent: Friday, September 17, 2010 4:48 AM [..] diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c index ae70ae9..0412233 100644 ---

RE: [PATCH 14/14] omap4: Fix bootup crash observed with higher CPU clocks

2010-09-17 Thread Menon, Nishanth
-Original Message- From: Shilimkar, Santosh Sent: Friday, September 17, 2010 5:17 AM [..] -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Shilimkar, Santosh Sent: Friday, September 17, 2010 4:48 AM

RE: [PATCH v2 09/10] OMAP2/3: Convert write/read functions to raw read/write

2010-10-07 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of G, Manjunath Kondaiah Sent: Tuesday, September 21, 2010 5:01 AM To: linux-omap@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org; linux-...@lists.infradead.org

RE: [PATCH] power: introduce library for device-specific OPPs

2010-10-07 Thread Menon, Nishanth
-Original Message- From: Rafael J. Wysocki [mailto:r...@sisk.pl] Sent: Thursday, October 07, 2010 4:55 PM Hi, On Wednesday, October 06, 2010, Nishanth Menon wrote: SoCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per

RE: [PATCH] power: introduce library for device-specific OPPs

2010-10-07 Thread Menon, Nishanth
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, October 07, 2010 5:14 PM To: Menon, Nishanth Cc: Rafael J. Wysocki; linux-pm; lkml; l-o; l-a; Paul Subject: Re: [PATCH] power: introduce library for device-specific OPPs [...] +static int

RE: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

2010-10-18 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Benoit Cousson Sent: Friday, September 24, 2010 4:16 AM To: linux-omap@vger.kernel.org Cc: Cousson, Benoit Subject: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

RE: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

2010-10-18 Thread Menon, Nishanth
-Original Message- From: Cousson, Benoit Sent: Monday, October 18, 2010 3:52 PM On 10/18/2010 8:09 PM, Menon, Nishanth wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Benoit Cousson Ping? Is there a possibility for a v2

RE: [RFC 0/5] OMAP4: mux: Add the OMAP4430 ES1 support

2010-10-18 Thread Menon, Nishanth
-Original Message- From: Cousson, Benoit Sent: Monday, October 18, 2010 3:57 PM From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Benoit Cousson Ping? Is there a possibility for a v2 non-rfc ES2 support? And what about a RFC v2?

RE: [RFC] [PATCH 6/7] usb: ehci: Introduce CONFIG_USB_EHCI_HCD_OMAP3

2010-10-20 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Felipe Balbi Sent: Friday, August 20, 2010 4:14 AM To: Gadiyar, Anand Cc: Balbi Felipe (Nokia-MS/Helsinki); Munegowda, Keshava; linux-...@vger.kernel.org;

RE: [PATCH v3 01/13] OMAP: DMA: Replace read/write macros with functions

2010-10-27 Thread Menon, Nishanth
-Original Message- From: G, Manjunath Kondaiah Sent: Tuesday, October 26, 2010 10:55 PM [..] [...] diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c index f5c5b8d..77241e2 100644 --- a/arch/arm/plat-omap/dma.c +++ b/arch/arm/plat-omap/dma.c @@ -40,6

Re: [PATCH 2/3 v2] omap4: opp: add OPP table data

2010-11-04 Thread Menon, Nishanth
On Thu, Nov 4, 2010 at 19:13, Tony Lindgren t...@atomide.com wrote: * Nishanth Menon n...@ti.com [101019 17:53]: @@ -86,7 +87,10 @@ int __init omap_init_opp_table(void)       omap_table_init = 1;       /* Select the OPP table we'd like to enable based on cpu we are on */ -     if

Re: [PATCH v5 0/3] OMAP: Add opp data

2010-12-08 Thread Menon, Nishanth
Hi, On Wed, Nov 24, 2010 at 10:54, Nishanth Menon n...@ti.com wrote: Major changes in V5:        rebased to k.org 2.6.37-rc3        introduced omap_opp_data.h        couple of whitespace and offline license suggestion cleanups V4: http://marc.info/?l=linux-omapm=128993367112637w=2 V3:

Re: [PATCH] OMAP4: Pandaboard: Fixing MMC card detect gpio line

2010-12-17 Thread Menon, Nishanth
On Wed, Dec 8, 2010 at 10:49, David Anders x0132...@ti.com wrote: On 12/07/2010 06:13 AM, Murthy, Raghuveer wrote: The .gpio_cd member of omap2_hsmmc_info is not initialized. This will default to zero. On Pandaboard this interferes with gpio line assigned for powering TFP410 DVI chip. This

Re: [PATCH v2] OMAP4: Pandaboard: Add omap_reserve functionality

2010-12-17 Thread Menon, Nishanth
Tony, 2010/12/8 Marek Vasut marek.va...@gmail.com: On Wednesday 08 December 2010 08:10:47 Raghuveer Murthy wrote: This patch adds omap_reserve functionality to board-omap4panda.c. Helps in the reserving boot time memory in SDRAM, used here for framebuffer allocation. This patch is in

Re: [PATCH 6/6] omap3: beagle: get rid of unused omap2/omap4 specific code/data

2010-12-21 Thread Menon, Nishanth
On Tue, Dec 21, 2010 at 12:20, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: From: Thomas Petazzoni tpetazz...@ti.com Using the new condsections infrastructure, get rid of the unused code/data for OMAP2 and OMAP4 when booting on BeagleBoard OMAP3. Signed-off-by: Thomas

Re: [PATCH v5 4/5] OMAP4: hwmod: Add inital data for smartreflex modules.

2010-12-23 Thread Menon, Nishanth
On Thu, Dec 23, 2010 at 06:07, Cousson, Benoit b-cous...@ti.com wrote: Please note the following log when enabling SR in Class 3 on an OMAP4430/sdp: [    2.362182] omap2_set_init_voltage: unable to find boot up OPP for vdd_mpu [    2.369384] omap2_set_init_voltage: Unable to put vdd_mpu to

Re: [query] smartreflex: No PMIC hook to init smartreflex

2011-01-27 Thread Menon, Nishanth
Sanjeev, On Tue, Jan 25, 2011 at 20:55, Premi, Sanjeev pr...@ti.com wrote: While building the kernel at 2.6.37, i see this warning for omap3evm - with omap3630: Power Management for TI OMAP3. sr_init: No PMIC hook to init smartreflex -- THIS IS THE WARNING. smartreflex smartreflex.0:

Re: [PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files

2011-02-06 Thread Menon, Nishanth
On Sat, Feb 5, 2011 at 04:24, Kevin Hilman khil...@ti.com wrote: Vasiliy Kulikov seg...@openwall.com writes: Don't allow everybody to change voltage settings. Signed-off-by: Vasiliy Kulikov seg...@openwall.com ---  Cannot compile the driver, so it is not tested at all. Acked-by: Kevin

RE: [PM-WIP-OPP][PATCH] OPP: Introduces enum for addressing different OPP types

2010-01-12 Thread Menon, Nishanth
Apologies on the spam - try two with outlook instead of thunderbird to prevent horrible linewraps :( /me learns never to post back into a reply on thunderbird from gedit.. Dasgupta, Romit had written, on 01/12/2010 06:39 AM, the following: Introduces enum for identifying OPP types. This helps in

Re: [PATCH] DSPBRIDGE: Get rid of driver_minor global variable

2010-02-01 Thread Menon, Nishanth
Ameya Palande said the following on 02/01/2010 08:18 PM: Since there is only 1 device there is no need of driver_minor global variable. i am a little skeptical about this change - mainly coz, it might be a good idea for a userspace option to be able to define what the minor id could be - maybe

Re: [PATCH] DSPBRIDGE: MEM_VFree() cleanup

2010-02-01 Thread Menon, Nishanth
Ameya Palande said the following on 02/01/2010 07:56 PM: Since vfree() checks for null pointer, there is no need to check is again in MEM_VFree(). This patch also reorganizes the function to make it more readable. Signed-off-by: Ameya Palande ameya.pala...@nokia.com ---

Re: [PATCH] DSPBRIDGE: Get rid of driver_minor global variable

2010-02-02 Thread Menon, Nishanth
Ameya Palande said the following on 02/02/2010 12:03 PM: Hi Nishanth, On Mon, 2010-02-01 at 20:48 +0100, ext Menon, Nishanth wrote: Ameya Palande said the following on 02/01/2010 08:18 PM: Since there is only 1 device there is no need of driver_minor global variable. i am a little skeptical

RE: [PATCH 1/2 v2] DSPBRIDGE: remove dependency of mpu freq

2010-02-02 Thread Menon, Nishanth
From: Felipe Contreras [mailto:felipe.contre...@nokia.com] Sent: Tuesday, February 02, 2010 3:01 PM On Tue, Feb 02, 2010 at 08:17:25AM +0100, Nishanth Menon wrote: Current DSPBridge uses hardcoded logic which is not scalable across OMAP3 silicons. introduce a structure based

RE: [PATCH] DSPBRIDGE: Check pointers before they are dereferenced

2010-02-08 Thread Menon, Nishanth
-Original Message- From: Gomez Castellanos, Ivan Sent: Monday, February 08, 2010 11:42 PM To: linux-omap@vger.kernel.org Cc: ameya.pala...@nokia.com; hiroshi.d...@nokia.com; felipe.contre...@nokia.com; Menon, Nishanth Subject: [PATCH] DSPBRIDGE: Check pointers before

RE: Ubuntu installation on omap

2010-02-09 Thread Menon, Nishanth
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Niamathullah sharief Sent: Wednesday, February 10, 2010 7:30 AM On Tue, Feb 9, 2010 at 8:37 PM, Robert Nelson robertcnel...@gmail.com wrote: On Tue, Feb 9, 2010 at 3:41 AM, Niamathullah sharief

RE: [PATCHv1] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-10 Thread Menon, Nishanth
From: Chitriki Rudramuni, Deepak Sent: Thursday, February 11, 2010 2:30 AM Removed NTFY_Notify() in WMD_MSG_Get() to avoid locking contention as NTFY_Notify() is already invoked in InputMsg(). Cc: Ameya Palande ameya.pala...@nokia.com Cc: Omar Ramirez Luna omar.rami...@ti.com Cc:

RE: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-17 Thread Menon, Nishanth
Hi, From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Friday, February 12, 2010 12:21 AM To: Chitriki Rudramuni, Deepak Cc: linux-omap; Ramirez Luna, Omar; Menon, Nishanth Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking On Thu, 2010-02-11 at 22:54 +0100

Re: [PATCH] PM-WIP-OPP: Fixing wrong target level being passed during Core DVFS.

2010-02-18 Thread Menon, Nishanth
Gopinath, Thara said the following on 02/18/2010 10:31 AM: As per the current implementaion (u8*)target_level is being passed to freq_to_opp in set_opp. This would result in updating just the first 8 bits of a u32 variable. Later target_level is passed to resource_set_opp_level as a u32

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Hebbar, Shivananda Sent: Thursday, February 18, 2010 9:24 PM To: linux-omap Subject: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup These patches remove excessive u32

RE: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup

2010-02-18 Thread Menon, Nishanth
-Original Message- From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] Sent: Thursday, February 18, 2010 10:18 PM To: Hebbar, Shivananda Cc: Menon, Nishanth; linux-omap Subject: Re: Patch[0/2]:DSPBRIDGE: Excessive u32 Cleanup On Thu, Feb 18, 2010 at 10:10 PM, Hebbar

RE: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

2010-02-18 Thread Menon, Nishanth
-Original Message- From: Ramirez Luna, Omar Sent: Thursday, February 18, 2010 8:27 PM To: Menon, Nishanth Cc: Ameya Palande; Chitriki Rudramuni, Deepak; linux-omap; Guzman Lugo, Fernando Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking On 2/17/2010 10

RE: [PATCH] PM-WIP-OPP: Fixing wrong target level being passed during Core DVFS.

2010-02-22 Thread Menon, Nishanth
From: Aguirre, Sergio Sent: Tuesday, February 23, 2010 7:28 AM To: Menon, Nishanth; Gopinath, Thara [...] Signed-off-by: Thara Gopinath th...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2/resource34xx.c |4 +++- 1 files changed, 3

RE: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0

2009-10-26 Thread Menon, Nishanth
-Original Message- From: G, Manjunath Kondaiah Sent: Monday, October 26, 2009 3:40 AM To: Menon, Nishanth; linux-omap@vger.kernel.org Cc: Imberton Guilhem; Mike Chan; Nayak, Rajendra; Roger Quadros; Kalle Jokiniemi; Reddy, Teerth; Kevin Hilman; Paul Walmsley; Hogander Jouni Subject

RE: [PATCH] [OMAP] GPIO Module is reset during initialization

2009-10-26 Thread Menon, Nishanth
From: Varadarajan, Charu Latha Sent: Monday, October 26, 2009 4:26 AM To: Menon, Nishanth; m...@felipebalbi.com Felipe Balbi had written, on 10/23/2009 05:56 PM, the following: On Fri, Oct 23, 2009 at 09:25:29PM +0530, ch...@ti.com wrote: From: Charulatha V ch...@ti.com During

RE: [PATCH] [OMAP] GPIO Module disable if all pins inactive

2009-10-26 Thread Menon, Nishanth
From: Varadarajan, Charu Latha Sent: Monday, October 26, 2009 4:07 AM #endif + if (cpu_is_omap24xx() || cpu_is_omap34xx() || cpu_is_omap44xx()) { + if (!bank-gpio_status) { + ctrl = __raw_readl(bank-base + OMAP24XX_GPIO_CTRL); +

RE: [PATCH 2/2] Accomodate the board file change in Kconfig

2009-10-26 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Pais, Allen Sent: Monday, October 26, 2009 2:43 AM To: linux-omap@vger.kernel.org Subject: [PATCH 2/2] Accomodate the board file change in Kconfig From

RE: [PATCH 1/2] Added board-3630.c file.

2009-10-26 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Pais, Allen Sent: Monday, October 26, 2009 2:43 AM To: linux-omap@vger.kernel.org Subject: [PATCH 1/2] Added board-3630.c file. From

Re: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0

2009-10-26 Thread Menon, Nishanth
like to convert and send a patch for fix pls. Regards, Nishanth Menon - Original Message - From: G, Manjunath Kondaiah To: Menon, Nishanth; linux-omap@vger.kernel.org linux-omap@vger.kernel.org Cc: Imberton Guilhem guilhem.imber...@motorola.com; Mike Chan mikec...@google.com; Nayak

RE: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0

2009-10-27 Thread Menon, Nishanth
ow...@vger.kernel.org] On Behalf Of Kalle Jokiniemi Sent: Tuesday, October 27, 2009 5:14 PM Hi Nishanth, Found some dead code, see below: [...] +/* T2 SMART REFLEX */ +#define R_SRI2C_SLAVE_ADDR 0x12 +#define R_VDD1_SR_CONTROL 0x00 +#define

RE: [PATCH 2/2 v3] OMAP3: PM: SR: SmartReflex Refactor Rev4.0

2009-10-27 Thread Menon, Nishanth
-Original Message- ow...@vger.kernel.org] On Behalf Of Paul Walmsley Sent: Wednesday, October 28, 2009 1:37 AM [..] a comment on cpu_relax() and udelay(). On Mon, 26 Oct 2009, Menon, Nishanth wrote: -Original Message- From: G, Manjunath Kondaiah As per your

RE: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM (Rev = E)

2009-10-28 Thread Menon, Nishanth
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar Sent: Wednesday, October 28, 2009 5:13 PM [...] diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb- musb.c index a80441d..529e2b1 100644 ---

RE: [PATCH 1/3] omap3evm: ehci: Add EHCI padconfig for board Rev = E

2009-10-28 Thread Menon, Nishanth
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar Sent: Wednesday, October 28, 2009 5:13 PM [...] Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- arch/arm/mach-omap2/mux.c |7 +++

RE: [PATCH 1/2] Added board-3630.c file.

2009-10-28 Thread Menon, Nishanth
-Original Message- From: Pandita, Vikram Sent: Wednesday, October 28, 2009 7:14 PM To: Pais, Allen; Menon, Nishanth; linux-omap@vger.kernel.org Subject: RE: [PATCH 1/2] Added board-3630.c file. -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux

RE: [PATCH 1/2] Added board-3630.c file.

2009-10-28 Thread Menon, Nishanth
From: Pandita, Vikram Sent: Wednesday, October 28, 2009 11:39 PM [...] I was making that list already. Good to see you thinking on same lines. However your list does not match with mine and I tried to confirm the changes looking at h/w. Thanks for correcting my list.. it was mostly off the

RE: [PATCH 3/3] omap3evm: musb: Update power capability for OMAP3EVM (Rev = E)

2009-10-28 Thread Menon, Nishanth
From: Gupta, Ajay Kumar Sent: Thursday, October 29, 2009 7:10 AM From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar Sent: Wednesday, October 28, 2009 5:13 PM [...] diff --git a/arch/arm/mach-omap2/usb-musb.c

Re: [PATCH 8/9 v2] omap3: pm: introduce dynamic OPP

2009-11-15 Thread Menon, Nishanth
Kevin Hilman said the following on 11/13/2009 07:31 PM: [...] +void __init omap3_pm_init_opp_table(void) +{ +/* Populate the base CPU rate tables here */ +omap3_mpu_rate_table = kmalloc(sizeof(omap34xx_mpu_rate_table), +GFP_KERNEL); +omap3_dsp_rate_table =

Re: [PATCH 2/9 v2] omap3: pm: introduce opp accessor functions

2009-11-15 Thread Menon, Nishanth
Kevin, Firstly, thanks for your detailed comments. This series looked at the problem as 2 objectives: a) Introduce OPP accessor functions - this series shows it is possible b) Improve the implementation with discussions. I am all for it. I know spending 7-14 hrs like what I did on this, is not

RE: CPU driver

2009-11-15 Thread Menon, Nishanth
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of tarek attia Sent: Sunday, November 15, 2009 6:33 AM I have downloaded uImage on the beagleboard with the pm branch,and enabled all the CPU power management ,and after booting I found all the

Re: [PATCH 1/3] omap3: pm: removes hardcoded VDD1/2 OPP values and make threshold generic

2009-11-19 Thread Menon, Nishanth
G.N, Vijayakumar said the following on 11/19/2009 05:24 AM: From e5e225fc19410178ad378acc74183a1bf1f0251a Mon Sep 17 00:00:00 2001 From: Vijay Kumar vijaykumar...@ti.com Date: Thu, 19 Nov 2009 14:39:59 +0530 Subject: [PATCH 1/3] omap3: pm: Adding facility to support OPP dynamically introduce

Re: [PATCH 3/3] omap3: pm: removes hardcoded VDD1/2 OPP values and make threshold generic

2009-11-19 Thread Menon, Nishanth
G.N, Vijayakumar said the following on 11/19/2009 05:26 AM: From 202416dbdf3fce31bfd76f1e74dda89b382a78c3 Mon Sep 17 00:00:00 2001 From: Vijay Kumar vijaykumar...@ti.com Date: Thu, 19 Nov 2009 15:07:38 +0530 Subject: [PATCH 3/3] OMAP 3630: Update VDD2 values The OMAP3630 VDD2 minimum value

RE: VDD1 voltage after resume from idle

2009-11-20 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev Sent: Friday, November 20, 2009 9:47 AM To: linux-omap@vger.kernel.org Subject: VDD1 voltage after resume from idle Hi, I am facing a strange problem

RE: VDD1 voltage after resume from idle

2009-11-20 Thread Menon, Nishanth
From: Premi, Sanjeev Sent: Friday, November 20, 2009 9:54 AM Hi, I am facing a strange problem on OMAP3EVM after resuming from idle. When using OPP5, the VDD1 voltage ramps to 1.35V. However, when i go thru the idle/wakeup cycle, the voltage never ramps back to 1.35V but

Re: [PATCH 2/9 v2] omap3: pm: introduce opp accessor functions

2009-11-21 Thread Menon, Nishanth
Hi Benoit, Thanks for your detailed review comments. few views follows Cousson, Benoit said the following on 11/21/2009 10:07 AM: [...] /** * struct omap_opp_def - OMAP OPP Definition * @enabled: True/false - is this OPP enabled/disabled by default * @freq:Frequency in hertz

Re: [PATCH 2/9 v2] omap3: pm: introduce opp accessor functions

2009-11-21 Thread Menon, Nishanth
Cousson, Benoit said the following on 11/21/2009 04:22 PM: From: Nishanth Menon [mailto:menon.nisha...@gmail.com] Hi Benoit, Thanks for your detailed review comments. few views follows Cousson, Benoit said the following on 11/21/2009 10:07 AM: [...] /** * struct omap_opp_def -

RE: [PATCH 02/10 V3] omap3: pm: introduce opp accessor functions

2009-11-25 Thread Menon, Nishanth
Kevin Hilman had written, on 11/25/2009 05:46 PM, the following: [...] something like this instead: /** * opp_find_freq() * @oppl:OPP list * @freq:Frequency to look for in OPP table * * Look for an enabled OPP with a frequency value matching @freq. * * Returns

RE: [PATCH v2 09/20] DSPBRIDGE: checkpatch - printk() should include KERN_ facility level

2009-11-30 Thread Menon, Nishanth
From: Ramirez Luna, Omar Sent: Monday, November 30, 2009 11:55 PM To: linux-omap Cc: Ramirez Luna, Omar; Menon, Nishanth Subject: [PATCH v2 09/20] DSPBRIDGE: checkpatch - printk() should include KERN_ facility level WARNING: printk() should include KERN_ facility level Any reason why we

Re: FEATURES - is it good enough

2009-12-01 Thread Menon, Nishanth
Alexander Shishkin said the following on 12/01/2009 05:42 PM: On Fri, Nov 20, 2009 at 02:09:01 -0600, Nishanth Menon wrote: Aguirre, Sergio had written, on 11/20/2009 01:43 PM, the following: -Original Message- From: Menon, Nishanth Sent: Friday, November 20, 2009 1:24 PM

Re: [PATCH] OMAP3: SDRC: Comment out SDRC AC timing and MR changes in CORE DVFS SRAM code

2009-12-01 Thread Menon, Nishanth
Paul Walmsley said the following on 12/02/2009 03:33 AM: The code that reprograms the SDRC memory controller during CORE DVFS, mach-omap2/sram34xx.S:omap3_sram_configure_core_dpll(), does not ensure that all L3 initiators are prevented from accessing the SDRAM before modifying the SDRC AC

Re: [PATCH 09/10 V3] omap3: pm: introduce 3630 opps

2009-12-08 Thread Menon, Nishanth
Hi, thanks for your comments. few thoughts below. Eduardo Valentin said the following on 12/08/2009 01:49 AM: Hello Nishanth, Few comments bellow. On Wed, Nov 25, 2009 at 05:09:18AM +0100, ext Nishanth Menon wrote: Introduce the OMAP3630 OPPs including the defined OPP tuples. Further

Re: [PATCH 02/10 V3] omap3: pm: introduce opp accessor functions

2009-12-08 Thread Menon, Nishanth
Eduardo Valentin said the following on 12/08/2009 02:23 AM: Hello Nishanth and Kevin, On Thu, Nov 26, 2009 at 01:22:49AM +0100, ext Nishanth Menon wrote: Kevin Hilman had written, on 11/25/2009 05:46 PM, the following: [...] something like this instead: /** * opp_find_freq()

Re: [PATCH 07/10 V3] omap3: clk: use pm accessor functions for cpufreq table

2009-12-08 Thread Menon, Nishanth
tero.kri...@nokia.com said the following on 12/07/2009 10:54 AM: Hi, One comment below. -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of ext Nishanth Menon Sent: 25 November, 2009 06:09 To: linux-omap Cc:

Re: [PATCH 04/10 V3] omap3: pm: srf: use opp accessor functions

2009-12-08 Thread Menon, Nishanth
tero.kri...@nokia.com said the following on 12/07/2009 10:59 AM: Hi, Couple of comments below. -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of ext Nishanth Menon Sent: 25 November, 2009 06:09 To: linux-omap Cc:

Re: [PATCH 03/10 V3] omap3: pm: use opp accessor functions for omap34xx

2009-12-08 Thread Menon, Nishanth
tero.kri...@nokia.com said the following on 12/07/2009 11:02 AM: One additional comment to this patch, compilation of board-rx51.c fails unless #include pm.h is added to it. This might be true for other boards also seeing it has been added to zoom2 at least. Huh.. Weird, I did build and

Re: [PATCH 09/10 V3] omap3: pm: introduce 3630 opps

2009-12-08 Thread Menon, Nishanth
Eduardo Valentin said the following on 12/08/2009 05:18 AM: On Tue, Dec 08, 2009 at 11:59:49AM +0100, ext Nishanth Menon wrote: Hi, thanks for your comments. few thoughts below. Eduardo Valentin said the following on 12/08/2009 01:49 AM: Hello Nishanth, Few comments bellow. On

RE: [PATCH 03/10 V4] omap3: pm: use opp accessor functions for omap34xx

2009-12-11 Thread Menon, Nishanth
From: Eduardo Valentin [mailto:eduardo.valen...@nokia.com] Sent: Friday, December 11, 2009 4:29 AM Hello Nishanth, You might have missed last tero's comment. But I'm adding those again here. On Wed, Dec 09, 2009 at 07:17:08AM +0100, ext Nishanth Menon wrote: Move the definitions from

RE: [PATCH 09/10 V4] omap3: pm: introduce 3630 opps

2009-12-11 Thread Menon, Nishanth
From: Eduardo Valentin [mailto:eduardo.valen...@nokia.com] Sent: Friday, December 11, 2009 4:12 AM Hello Nishanth, On Wed, Dec 09, 2009 at 07:17:14AM +0100, ext Nishanth Menon wrote: Introduce the OMAP3630 OPPs including the defined OPP tuples. Further information on OMAP3630 can be

RE: [PATCH 02/10 V4] omap3: pm: introduce opp accessor functions

2009-12-11 Thread Menon, Nishanth
Eduardo, From: Eduardo Valentin [mailto:eduardo.valen...@nokia.com] Sent: Friday, December 11, 2009 3:19 AM On Fri, Dec 11, 2009 at 01:41:46AM +0100, ext Nishanth Menon wrote: Kevin Hilman had written, on 12/10/2009 05:25 PM, the following: Thanks for the acks.. Nishanth Menon

RE: [PATCH] OMAP3: PM: Dynamic calculation of SDRC clock stabilization delay

2009-12-11 Thread Menon, Nishanth
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Reddy, Teerth Sent: Friday, December 11, 2009 6:06 AM To: linux-omap@vger.kernel.org Subject: [PATCH] OMAP3: PM: Dynamic calculation of SDRC clock stabilization delay Reposting the patch with

RE: [PATCH 02/10 V4] omap3: pm: introduce opp accessor functions

2009-12-11 Thread Menon, Nishanth
From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, December 11, 2009 9:48 AM Thanks for your comments. My views follow [...] + * This structure stores the OPP information for a given domain. + * Due to legacy reasons, this structure is currently exposed and + * will

Re: [PATCH 1/2] omap i2c: make errata 1.153 workaround a separate function

2009-12-16 Thread Menon, Nishanth
Alexander Shishkin said the following on 12/16/2009 07:32 PM: This is to avoid insanely long lines and levels of indentation. Signed-off-by: Alexander Shishkin virtu...@slind.org CC: linux-...@vger.kernel.org CC: linux-omap@vger.kernel.org --- drivers/i2c/busses/i2c-omap.c | 43

Re: [PATCH 2/2] omap i2c: add a timeout to the busy waiting

2009-12-16 Thread Menon, Nishanth
Alexander Shishkin said the following on 12/16/2009 07:32 PM: The errata 1.153 workaround is busy waiting on XUDF bit in interrupt context, which may lead to kernel hangs. The problem can be reproduced by running the bus with wrong (too high) speed. Signed-off-by: Alexander Shishkin

Re: [PATCH 00/10 V5] omap3: pm: introduce support for 3630 OPPs

2009-12-16 Thread Menon, Nishanth
Kevin Hilman said the following on 12/17/2009 04:07 AM: Kevin Hilman khil...@deeprootsystems.com writes: Nishanth Menon n...@ti.com writes: Hi, Thanks for all the comments. Here are the *changed* patches since V5 What changed in V5: * review comment incorporated * vsel is deprecated

Re: [PATCH 1/2] omap i2c: make errata 1.153 workaround a separate function

2009-12-17 Thread Menon, Nishanth
Alexander Shishkin said the following on 12/17/2009 06:18 PM: On Thu, Dec 17, 2009 at 08:36:30 +0530, Menon, Nishanth wrote: Alexander Shishkin said the following on 12/16/2009 07:32 PM: This is to avoid insanely long lines and levels of indentation. Signed-off-by: Alexander Shishkin

Re: [PATCH 5/9] omap3: pm: sr: replace get_opp with freq_to_opp

2009-12-19 Thread Menon, Nishanth
Kevin Hilman said the following on 12/19/2009 04:42 AM: Nishanth Menon n...@ti.com writes: SmartReflex implements a get_opp to search through the opp table, replace it with the accessor function as it is a duplicate of freq_to_opp SmartReflex is not quite working with this version

Re: [PATCH v2 1/4] OMAP OPP: Add accessor function for getting OPP ID.

2009-12-19 Thread Menon, Nishanth
Kevin Hilman said the following on 12/19/2009 04:35 AM: Add new function opp_get_opp_id() for finding the OPP ID of a given OPP. This allows us to further hide OPP layer details. NOTE: OPP IDs are deprecated, and this function will eventually be removed after all users of OPP IDs are

Re: [PATCH v2 2/4] OMAP SRF: adjust OPP array access

2009-12-19 Thread Menon, Nishanth
Kevin Hilman said the following on 12/19/2009 04:35 AM: With the initial terminators removed from the OPP struct arrarys, the direct indexing of the array needs to be adjusted by one. Signed-off-by: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2/resource34xx.c |4 ++-- 1

Re: [PATCH v2 3/4] OMAP SR/SRF: use OPP API for OPP ID, remove direct access

2009-12-19 Thread Menon, Nishanth
Kevin Hilman said the following on 12/19/2009 04:35 AM: SR and SRF currenly direclty access OPP struct internals. Use new accessor function to get OPP ID. Also SRF was doing doing direct access of the OPP struct array using a convoluted conversion from a 'level' to an OPP ID, when they're

Re: [PATCH v2 4/4] OMAP OPP: hide struct omap_opp internals in OPP layer implementation

2009-12-19 Thread Menon, Nishanth
Kevin Hilman said the following on 12/19/2009 04:35 AM: Now that we have accessor/helper functions for all the OPP layer details, move 'struct omap_opp' into the OPP layer so no direct accesses to OPP internals can be done. Signed-off-by: Kevin Hilman khil...@deeprootsystems.com ---

Re: [PATCH 03/12] OMAP OPP: only traverse opp_find_freq_floor() once

2009-12-19 Thread Menon, Nishanth
Paul Walmsley said the following on 12/18/2009 06:17 AM: There's no point traversing the OPP list twice in opp_find_freq_floor(). --- arch/arm/plat-omap/opp.c | 30 +- 1 files changed, 13 insertions(+), 17 deletions(-) diff --git a/arch/arm/plat-omap/opp.c

Re: [PATCH 04/12] OMAP TWL/TPS OPP: move TWL/TPS-specific code to its own file

2009-12-19 Thread Menon, Nishanth
Paul Walmsley said the following on 12/18/2009 06:17 AM: The OPP layer code should be independent of the PMIC, so move the TWL/TPS-specific code out to its own file. --- arch/arm/plat-omap/Makefile |4 ++- arch/arm/plat-omap/include/plat/opp_twl_tps.h | 21 ++

Re: [PATCH 05/12] OMAP TWL/TPS OPP: vsel rounding belongs in opp_twl_tps.c

2009-12-19 Thread Menon, Nishanth
Instruments Incorporated. - * Nishanth Menon + * Nishanth Menon + * Copyright (C) 2009 Nokia Corporation + * Paul Walmsley * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -34,5 +36,14 @@ unsigned long

Re: [PATCH 12/12] OMAP3 OPP: move CPUFreq table init code to OPP layer

2009-12-19 Thread Menon, Nishanth
Paul Walmsley said the following on 12/18/2009 06:17 AM: Move omap2_clk_init_cpufreq_table() to opp_init_cpufreq_table() in opp.c where it now belongs. OMAP2 still needs to be converted to use the OPP layer, so it is using the old code. Neat.. thanks.. helps Omap4 too I can see.. Acked-by:

RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Eero Nurkkala Sent: Thursday, March 05, 2009 10:46 AM To: ext Paul Walmsley Cc: linux-omap@vger.kernel.org; Woodruff, Richard Subject: Re: [RFC] OMAP: I2C: Use correct

RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY

2009-03-05 Thread Menon, Nishanth
-Original Message- From: Eero Nurkkala [mailto:ext-eero.nurkk...@nokia.com] Sent: Thursday, March 05, 2009 2:33 PM To: Menon, Nishanth Cc: ext Paul Walmsley; linux-omap@vger.kernel.org; Woodruff, Richard Subject: RE: [RFC] OMAP: I2C: Use correct bit for CLOCKACTIVITY Thank you

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Menon, Nishanth
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Felipe Contreras Sent: Thursday, March 05, 2009 3:42 PM To: Kanigeri, Hari Cc: Ameya Palande; Guzman Lugo, Fernando; Hiroshi DOYU; linux- o...@vger.kernel.org Subject:

RE: [PATCH 0/5] DSPBRIDGE: patches.

2009-03-05 Thread Menon, Nishanth
Hi Hari, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Kanigeri, Hari Sent: Thursday, March 05, 2009 3:52 PM To: Felipe Contreras Cc: Ameya Palande; Guzman Lugo, Fernando; Hiroshi DOYU; linux- o...@vger.kernel.org

RE: [PATCH 3/5] OV3640: Add driver

2009-03-09 Thread Menon, Nishanth
, Vaibhav; Lakhani, Amish; Menon, Nishanth Subject: RE: [PATCH 3/5] OV3640: Add driver + /* FIXME: QXGA framerate setting forced to 15 FPS */ + if (isize == QXGA) { lots of i2c reg writes snip 4)); + err = ov3640_write_reg(client, OV3640_ISP_YOUT_L

RE: [PATCH 3/5] OV3640: Add driver

2009-03-10 Thread Menon, Nishanth
-Original Message- From: Tuukka.O Toivonen [mailto:tuukka.o.toivo...@nokia.com] Sent: Tuesday, March 10, 2009 9:30 AM To: Menon, Nishanth Cc: Aguirre Rodriguez, Sergio Alberto; Alexey Klimov; linux- me...@vger.kernel.org; linux-omap@vger.kernel.org; Sakari Ailus; Doyu Hiroshi (Nokia

DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload

2009-03-11 Thread Menon, Nishanth
Hi Folks, With the latest linux-omap pm + gitorious bridge changes on SDP3430, enabling BRIDGE_DVFS and SRF seems to cause an issue with clock notifier.. I am not entirely of the cause of the issue(don't have a debugger handy at the moment :( ): The condition is reproducible on exactly the

RE: DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload

2009-03-11 Thread Menon, Nishanth
Richard, -Original Message- From: Woodruff, Richard Sent: Wednesday, March 11, 2009 5:28 PM To: Menon, Nishanth; linux-omap@vger.kernel.org Cc: ext Paul Walmsley; Nayak, Rajendra; Gupta, Ramesh Subject: RE: DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload driver as explained

RE: DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload

2009-03-11 Thread Menon, Nishanth
-Original Message- From: Woodruff, Richard Sent: Wednesday, March 11, 2009 6:40 PM To: Menon, Nishanth; linux-omap@vger.kernel.org Cc: ext Paul Walmsley; Nayak, Rajendra; Gupta, Ramesh Subject: RE: DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload It does not make sense for clock

RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload

2009-03-11 Thread Menon, Nishanth
Ramesh, -Original Message- From: Gupta, Ramesh Sent: Thursday, March 12, 2009 7:32 AM To: linux-omap@vger.kernel.org Cc: Menon, Nishanth; Kanigeri, Hari; Guzman Lugo, Fernando Subject: [PATCH 1/1] DSPBRIDGE Fix for image autoload From fbbf5c9c308c2e1e90e70c57a48798c5d05a6b1d Mon

RE: [PATCH] OMAP:clock: missing list_del for clk_notifier_unregister

2009-03-12 Thread Menon, Nishanth
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, March 12, 2009 9:31 AM To: Menon, Nishanth Cc: linux-omap@vger.kernel.org; Woodruff, Richard; Nayak, Rajendra; Gupta, Ramesh; Palande Ameya Subject: Re: [PATCH] OMAP:clock: missing list_del

RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload

2009-03-12 Thread Menon, Nishanth
-Original Message- From: Gupta, Ramesh Sent: Thursday, March 12, 2009 8:01 AM To: Menon, Nishanth; linux-omap@vger.kernel.org Cc: Kanigeri, Hari; Guzman Lugo, Fernando Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload I have tried this on linux-omap pm branch . This can

  1   2   3   4   >