OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-24 Thread NeilBrown
On Sat, 21 Jan 2012 17:07:18 -0700 (MST) Paul Walmsley wrote: > On Wed, 18 Jan 2012, NeilBrown wrote: > > > Oh - another thing. > > Sometimes during early boot I get: > > > > [0.158447] omap_hwmod: usbtll_fck: missing clockdomain for usbtll_fck. >

Re: DSS2/PM on 3.2 broken?

2012-01-24 Thread NeilBrown
On Mon, 23 Jan 2012 14:11:16 -0800 Kevin Hilman wrote: > NeilBrown writes: > > > On Thu, 19 Jan 2012 16:22:37 -0800 Kevin Hilman wrote: > > > >> NeilBrown writes: > >> > >> > On Thu, 19 Jan 2012 11:37:39 -0800 Kevin Hilm

Re: [PATCH] omap2430 musb: Make musb_otg_notification non-blocking

2012-01-24 Thread NeilBrown
On Tue, 24 Jan 2012 10:56:12 +0200 Felipe Balbi wrote: > On Fri, Dec 30, 2011 at 12:36:28PM +1100, NeilBrown wrote: > > > > > > This callback is on an 'atomic notificaitons' queue but is written > > as a blocking notifier. > > > > Convert t

Re: OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-27 Thread NeilBrown
On Thu, 26 Jan 2012 07:19:19 -0700 (MST) Paul Walmsley wrote: > On Tue, 24 Jan 2012, NeilBrown wrote: > > > On Sat, 21 Jan 2012 17:07:18 -0700 (MST) Paul Walmsley > > wrote: > > > > > On Wed, 18 Jan 2012, NeilBrown wrote: > > > > > > > O

Re: OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-27 Thread NeilBrown
On Fri, 27 Jan 2012 15:58:40 -0700 (MST) Paul Walmsley wrote: > On Sat, 28 Jan 2012, NeilBrown wrote: > > > Here's a theory: perhaps the MPU powerdomain is hitting a low-power state > > > while waiting for an HDQ interrupt. When the MPU powerdomain is in a low &g

Re: [PATCH/RFC] ARM: OMAP: MUSB: disable omap_device auto-suspend

2012-01-30 Thread NeilBrown
#x27;t know which ones might be important. 2/ If you see i2c register access abort, I think that is because the iclk is being turned off. Timeouts are because the interrupt is disabled or ignored. good luck, NeilBrown > > > On Wed, Dec 7, 2011 at 9:37 PM, Kevin Hilman wrote:

Re: GPIO debounce problems on 3.2

2012-01-31 Thread NeilBrown
tate. My TRM says - in section 12.3.1.3 Power Management The MPU subsystem INTC belongs to the CORE power domain. This is: AM/DM37x Multimedia Device Silicon Revision 1.x Version N Is it wrong, are you wrong, or am I confused? Thanks, NeilBrown So > neither the MPU

Re: OMAP HDQ: was Re: DSS2/PM on 3.2 broken?

2012-01-31 Thread NeilBrown
xisting > code. Could you please try the patch enclosed at the bottom of this > E-mail and see if it helps? Yes, that patch fixes my problem too - the HDQ keeps working. (it's a bit smoke-and-mirrors though .. I want fclk to stay on, so let's make sure iclk doesn't autoidle, because we *know* they have the same source :-) Thanks, NeilBrown signature.asc Description: PGP signature

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-02 Thread NeilBrown
n a lot. (the periods in each state are only repeatable to a precision of 20%-50%). I understand that PER won't go OFF without runtime PM, but I would expect it to at least go to INA as the UART is in smart-idle mode The net result is that with runtime_pm enabled I'm seeing an extra 7mA

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Thu, 2 Feb 2012 22:45:53 -0700 (MST) Paul Walmsley wrote: > Hello Neil. > > On Fri, 3 Feb 2012, NeilBrown wrote: > > > Can I comment??... They are good but > > > > I've tried two approaches to getting serial behaviour that I am happy with. >

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 12:26:14 +0530 Govindraj wrote: > On Fri, Feb 3, 2012 at 9:37 AM, NeilBrown wrote: > > On Thu, 2 Feb 2012 13:03:01 -0700 (MST) Paul Walmsley > > wrote: > > > >> Hi Greg, > >> > >> On Thu, 26 Jan 2012, Paul Walmsley wrote

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 13:42:13 +0200 Grazvydas Ignotas wrote: > On Fri, Feb 3, 2012 at 11:54 AM, NeilBrown wrote: > > On Thu, 2 Feb 2012 22:45:53 -0700 (MST) Paul Walmsley > > wrote: > >> On Fri, 3 Feb 2012, NeilBrown wrote: > >> > >> > then CPUIDLE

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 12:42:22 -0700 (MST) Paul Walmsley wrote: > On Fri, 3 Feb 2012, Grazvydas Ignotas wrote: > > > On Fri, Feb 3, 2012 at 11:54 AM, NeilBrown wrote: > > > On Thu, 2 Feb 2012 22:45:53 -0700 (MST) Paul Walmsley > > > wrote: > > &g

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 13:10:28 -0700 (MST) Paul Walmsley wrote: > One other comment.. > > On Fri, 3 Feb 2012, NeilBrown wrote: > > > On Thu, 2 Feb 2012 22:45:53 -0700 (MST) Paul Walmsley > > wrote: > > > > > On Fri, 3 Feb 2012, NeilBrown wrote: >

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 14:42:09 -0700 (MST) Paul Walmsley wrote: > One correction on this part... > > On Fri, 3 Feb 2012, Paul Walmsley wrote: > > > On Fri, 3 Feb 2012, NeilBrown wrote: > > > > > My theory is that there is a delay between the falling RX line wa

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 16:02:42 -0700 (MST) Paul Walmsley wrote: > On Sat, 4 Feb 2012, NeilBrown wrote: > > > On Fri, 3 Feb 2012 13:10:28 -0700 (MST) Paul Walmsley > > wrote: > > > > > Considering your theory that the UART clocks are being cut while there

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Sat, 4 Feb 2012 00:23:09 + "Woodruff, Richard" wrote: > > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > ow...@vger.kernel.org] On Behalf Of NeilBrown > > > > Not sure if it's the same problem but with 3530 on 3.2 with > &g

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 19:06:19 -0700 (MST) Paul Walmsley wrote: > Hi Neil > > On Sat, 4 Feb 2012, NeilBrown wrote: > > > Guess what happens if I set autosuspend_delay_ms to 0? > > Massive transmit problems. Driver can hardly get anything out before the > > U

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 20:16:08 -0700 (MST) Paul Walmsley wrote: > On Sat, 4 Feb 2012, NeilBrown wrote: > > > On Fri, 3 Feb 2012 19:06:19 -0700 (MST) Paul Walmsley > > wrote: > > > > > > Here's a patch that helps. It seems to work down to an > > &

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-03 Thread NeilBrown
On Fri, 3 Feb 2012 20:56:07 -0700 (MST) Paul Walmsley wrote: > On Sat, 4 Feb 2012, NeilBrown wrote: > > > I have to set autosuspend_delay_ms for omap_uart.3 as well before the > > behaviour is significant. > > But then I see no output corruption. Lots of input corrupti

Re: patch "tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA" added to tty tree

2012-02-06 Thread NeilBrown
t queue or fifo The only case that wouldn't support is when a device will wake up the SOC by sending a non-break character which it is OK to receive corrupted. The tty would have to be in !CREAD for that to happen, and then there would be no way for the app to know that a non-break character was received. Would it be reasonable to treat any input while CREAD is clear as a break? NeilBrown signature.asc Description: PGP signature

[PATCH] OMAP: add pwm driver using dmtimers.

2012-12-12 Thread NeilBrown
This patch is based on an earlier patch by Grant Erickson which provided pwm devices using the 'legacy' interface. This driver instead uses the new framework interface. Cc: Grant Erickson Signed-off-by: NeilBrown diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig index ed8172

Re: [PATCH] OMAP: add pwm driver using dmtimers.

2012-12-12 Thread NeilBrown
On Wed, 12 Dec 2012 12:31:45 +0100 Thierry Reding wrote: > On Wed, Dec 12, 2012 at 07:24:30PM +1100, NeilBrown wrote: > > > > > > This patch is based on an earlier patch by Grant Erickson > > which provided pwm devices using the 'legacy' interface. >

Re: [PATCH] OMAP: add pwm driver using dmtimers.

2012-12-12 Thread NeilBrown
On Wed, 12 Dec 2012 10:20:34 -0600 Jon Hunter wrote: > > On 12/12/2012 05:31 AM, Thierry Reding wrote: > > On Wed, Dec 12, 2012 at 07:24:30PM +1100, NeilBrown wrote: > > [snip] > > >> +static int omap_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) &g

Re: [PATCH] OMAP: add pwm driver using dmtimers.

2012-12-12 Thread NeilBrown
[Thierry: question for you near the end - thanks] On Wed, 12 Dec 2012 10:08:28 -0600 Jon Hunter wrote: > Hi Neil, > > On 12/12/2012 02:24 AM, NeilBrown wrote: > > > > > > This patch is based on an earlier patch by Grant Erickson > > which provided pwm dev

Re: [PATCH] OMAP: add pwm driver using dmtimers.

2012-12-12 Thread NeilBrown
On Thu, 13 Dec 2012 14:06:35 +1100 NeilBrown wrote: > > > + omap_dm_timer_enable(omap->dm_timer); > > > > Do you need to call omap_dm_timer_enable here? _set_load and _set_match > > will enable the timer. So this should not be necessary. > > True. That

Re: [PATCH v3 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x

2013-10-17 Thread NeilBrown
8+5 */ }; to my dts file but it doesn't make any apparent difference. Any idea what I might be doing wrong? (the base kernel I am applying patches to is from 8th Oct, commit 0e7a3ed04f0cd4311096d691888f88569310ee6c) BTW, - with the default polling, I get about 1Mb/sec with iperf - with sd-irq enabled and FCLK kept on the whole time, I get 4Mb/sec - with sd-irq enable, FCLK kept on, and the 5ms polling also running, I get over 5Mb/sec! Still much less than the 40Mb/sec that I would like to get... Thanks, NeilBrown signature.asc Description: PGP signature

Re: [PATCH v3 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x

2013-10-18 Thread NeilBrown
On Fri, 18 Oct 2013 12:59:56 +0530 Balaji T K wrote: > On Friday 18 October 2013 11:50 AM, NeilBrown wrote: > > On Sat, 5 Oct 2013 13:17:09 +0200 Andreas Fenkart > > wrote: > > > >> The am335x can't detect pending cirq in PM runtime suspend. > >> T

Re: [PATCH v3 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x

2013-10-18 Thread NeilBrown
On Fri, 18 Oct 2013 12:12:48 +0200 Javier Martinez Canillas wrote: > On Fri, Oct 18, 2013 at 8:20 AM, NeilBrown wrote: > > On Sat, 5 Oct 2013 13:17:09 +0200 Andreas Fenkart > > wrote: > > > >> The am335x can't detect pending cirq in PM runtime suspend. >

[PATCH] twl4030_charger: add devicetree support.

2013-10-23 Thread NeilBrown
[my first device-tree related patch. Please let me know what I got wrong so I wont repeat the mistake in all the others I have queued] This allows the charger to be enabled with devicetree, and allows the parameters for charging the backup battery to be set. Signed-off-by: NeilBrown diff

[PATCH/RFC] pwm: omap: Add PWM support using dual-mode timers

2013-10-23 Thread NeilBrown
a/ can we change omap_dm_timer_write_counter to work when the timer isn't running? b/ can we have omap_dm_timer_set_load also set the counter? For anyone else generous enough to read my code: is this otherwise acceptable? Thanks, NeilBrown - T

[PATCH 0/2] ARM: OMAP: dmtimers improvements.

2013-10-24 Thread NeilBrown
. 1/ allow the counter to be set even when the timer isn't counting. 2/ move the include file to a more useful location Any help you can provide in getting these fixes upstream would be appreciated. Thanks, NeilBrown --- NeilBrown (2): ARM: OMAP2+: dmtimer: allow counter to be set a

[PATCH 1/2] ARM: OMAP2+: dmtimer: allow counter to be set at any time.

2013-10-24 Thread NeilBrown
It is perfectly appropriate to set the counter register when the timer isn't running. The value set will be where the counter starts counting from. Signed-off-by: NeilBrown --- arch/arm/plat-omap/dmtimer.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arc

[PATCH 2/2] ARM: OMAP: move dmtimer.h from plat-omap/include/plat to include/linux

2013-10-24 Thread NeilBrown
This is no need for dmtimer.h to be in the 'plat' include directory, and it makes it hard to write drivers which use it (such as a PWM driver). So move it to linux/omap-dmtimer.h. Signed-off-by: NeilBrown --- arch/arm/mach-omap1/pm.c |2 arch/arm/

Re: [PATCH] twl4030_charger: add devicetree support.

2013-10-24 Thread NeilBrown
On Thu, 24 Oct 2013 11:06:52 +0100 Grant Likely wrote: > On Thu, 24 Oct 2013 04:44:03 -0500, Kumar Gala wrote: > > > > On Oct 24, 2013, at 12:50 AM, NeilBrown wrote: > > > > > > > > [my first device-tree related patch. Please let me know what I got

[PATCH] twl4030_charger: add devicetree support.

2013-10-30 Thread NeilBrown
This allows the charger to be enabled with devicetree, and allows the parameters for charging the backup battery to be set. Signed-off-by: NeilBrown Acked-by: Kumar Gala Acked-by: Grant Likely -- This version with correct property names and some Acked-by's. - NB diff --git a/Document

omap2430 regression due to "usb: musb: fix incorrect usage of resource pointer"

2013-07-26 Thread NeilBrown
s to copy Can we go back to just leaving it to platform_device_add_resources to do the copying it have I missed something? (I can't see where the new old code would mark something as 'busy' that the new code won't mark as busy...) Thanks, NeilBrown signature.asc Description: PGP signature

Re: omap2430 regression due to "usb: musb: fix incorrect usage of resource pointer"

2013-07-26 Thread NeilBrown
On Fri, 26 Jul 2013 13:20:08 +0300 Felipe Balbi wrote: > On Fri, Jul 26, 2013 at 07:14:45PM +1000, NeilBrown wrote: > > > > Hi, > > the commit: > > > > commit 09fc7d22b024692b2fe8a943b246de1af307132b > > Author: Felipe Balbi > > Date: Wed Apr

Re: omap2430 regression due to "usb: musb: fix incorrect usage of resource pointer"

2013-07-26 Thread NeilBrown
On Fri, 26 Jul 2013 16:51:08 +0300 Felipe Balbi wrote: > On Fri, Jul 26, 2013 at 10:24:58PM +1000, NeilBrown wrote: > > On Fri, 26 Jul 2013 13:20:08 +0300 Felipe Balbi wrote: > > > > > On Fri, Jul 26, 2013 at 07:14:45PM +1000, NeilBrown wrote: > > > &

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
code one day and even get those drivers upstream. So I would really prefer this code to remain if it isn't causing any actual problems. Of course, I can always re-submit it when I need it again, but that it just extra work all around. Sorry that I have pushed those drivers already

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 18:01:21 -0500 Felipe Balbi wrote: > Hi, > > On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: > > On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon wrote: > > > > > On 04/23/2014 09:58 AM, Felipe Balbi wrote: > > > > n

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
to the UART is open. The device is a > > bluetooth transceiver. > > considering this is a BTUART device, why didn't you do this at the ldisc > level ? hci_uart_open() sounds like a good choice from a quick thinking. > I'll have a look into that, thanks. NeilBrown signature.asc Description: PGP signature

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 20:43:34 -0500 Felipe Balbi wrote: > so, Ack for $subject or not ? > Just at the moment I'm finding it hard to care. So Acked-by: NeilBrown Whatever NeilBrown signature.asc Description: PGP signature

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread NeilBrown
om the uart and do the required magic. Having serial-core know about gpios and regulators and random other stuff seems wrong. I would really like to see the "runtime interpreted power sequences" become a real thing. Then serial-core could activate a "RIPS", and that would hav

Re: Latest build results - errors/warnings - lots of them

2013-05-05 Thread NeilBrown
ute warn_unused_result > > Neil, care to provide a fix for this? It's from your commit ab37813 > (twl4030_charger: Allow charger to control the regulator that feeds it). > > This the sort of thing that might be appropriate? NeilBrown From: NeilBrown Date: Mon, 6 May 2013 12:

Strange OMAP3 LCD display regression - bisected.

2013-06-01 Thread NeilBrown
3.10-rc yet - haven't look into why as yet. Any help anyone could provide here would be greatly appreciated. I'm happy to run any test patches you would like to suggest. Thanks, NeilBrown diff --git a/drivers/video/omap2/dss/dpi.c b/drivers/video/omap2/dss/dpi.c index 757b57f..4

Re: Strange OMAP3 LCD display regression - bisected.

2013-06-03 Thread NeilBrown
On Mon, 3 Jun 2013 10:24:18 +0300 Tomi Valkeinen wrote: > Hi, > > On 02/06/13 09:50, NeilBrown wrote: > > > The details: > > I'm currently trying to move from a 3.7 kernel on my GTA04 to a 3.10-rc > > kernel (hopefully to have 3.10 fully working by the t

Re: Strange OMAP3 LCD display regression - bisected.

2013-06-03 Thread NeilBrown
On Mon, 3 Jun 2013 10:13:18 +0200 jean-philippe francois wrote: > 2013/6/2 NeilBrown : > > > > Hi Tomi, Rajendra and other, > > I have run into a rather strange regression with the LCD panel display on > > my > > GTA04 (OMAP3630 based phone) that you might be

[PATCH] w1: omap-hdq: support device probing with device-tree.

2014-11-07 Thread NeilBrown
This driver has no 'compatible' string and so is not found when using device-tree. Add one with value to match hdqw1w: 1w@480b2000 { device in omap3.dtsi. Signed-off-by: NeilBrown diff --git a/Documentation/devicetree/bindings/w1/omap-hdq.txt b/Documentation/

[PATCH] ARM: OMAP: serial: remove last vestige of DTR_gpio support.

2014-11-07 Thread NeilBrown
the rest. Signed-off-by: NeilBrown diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c index a388f8c1bcb3..57dee0c7cd2b 100644 --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c @@ -263,9 +263,6 @@ void __init omap_serial_init_port(struct omap_board_data

[PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

2014-11-07 Thread NeilBrown
y preference would be for this series to be applied (if there are no other issues) and if there are opinions about effecting '1' or '2', they can be done with subsequent patches. Thanks, NeilBrown --- NeilBrown (3): mmc: omap_hsmmc: remove prepare/complete system suspe

[PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

2014-11-07 Thread NeilBrown
-by: NeilBrown --- drivers/mmc/core/slot-gpio.c | 21 +++- drivers/mmc/host/omap_hsmmc.c | 73 ++--- include/linux/mmc/slot-gpio.h |2 + 3 files changed, 39 insertions(+), 57 deletions(-) diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc

[PATCH 3/3] mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration.

2014-11-07 Thread NeilBrown
This ensures that all standard options are available to hsmmc, In particular, I need cap-power-off-card. Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/mmc/host

[PATCH 1/3] mmc: omap_hsmmc: remove prepare/complete system suspend support.

2014-11-07 Thread NeilBrown
common suspend processing. So this disabling of the interrupt is unnecessary, and interferes with a transition to using common code for card-detect management. Cc: Felipe Balbi Cc: Venkatraman S Cc: Chris Ball Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 52

Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled

2014-11-18 Thread NeilBrown
. It would be nice if the driver could check if a charger was plugged in and act accordingly. The charger I have for my openmoko is identified by a 47K resistor between ID and ground. The twl4030 can detect that easily enough, but it isn't very standard. The standard is of course to have

Re: [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

2014-11-19 Thread NeilBrown
On Wed, 19 Nov 2014 11:14:24 +0100 Ulf Hansson wrote: > On 8 November 2014 00:52, NeilBrown wrote: > > omap_hsmmc currently duplicates some work that can be done for > > it by common code, and consequently does not benefit from extra > > functionality in that common code.

[PATCH v2 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

2014-12-11 Thread NeilBrown
x27; and '2' would be a better choice but I know none of the history or justification for those differences. My preference would be for this series to be applied (if there are no other issues) and if there are opinions about effecting '1' or '2', they can be done wit

[PATCH 3/3] mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration.

2014-12-11 Thread NeilBrown
This ensures that all standard options are available to hsmmc, In particular, I need cap-power-off-card. Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/mmc/host

[PATCH 1/3] mmc: omap_hsmmc: remove prepare/complete system suspend support.

2014-12-11 Thread NeilBrown
common suspend processing. So this disabling of the interrupt is unnecessary, and interferes with a transition to using common code for card-detect management. Cc: Felipe Balbi Cc: Venkatraman S Cc: Chris Ball Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 50

[PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

2014-12-11 Thread NeilBrown
-by: NeilBrown --- drivers/mmc/core/slot-gpio.c | 24 ++- drivers/mmc/host/omap_hsmmc.c | 67 + include/linux/mmc/slot-gpio.h |2 + 3 files changed, 39 insertions(+), 54 deletions(-) diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc

[PATCH 2b/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

2014-12-19 Thread NeilBrown
Using the common code removes some code duplication, and makes it easier to switch to using mmc_of_parse() which will remove more duplication. This uses the new mmc_gpio_request_cd_isr to provide a non-standard interrupt service routine for card-detect interrupts. Signed-off-by: NeilBrown

[PATCH 2a/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2014-12-19 Thread NeilBrown
hich provide an alternate isr to be register by the slot-gpio code. Signed-off-by: NeilBrown --- drivers/mmc/core/slot-gpio.c | 24 +++- include/linux/mmc/slot-gpio.h |2 ++ 2 files changed, 25 insertions(+), 1 deletion(-) This and following are the result of splitting th

Re: [PATCH 2a/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2014-12-23 Thread NeilBrown
On Mon, 22 Dec 2014 16:35:40 +0100 Ulf Hansson wrote: > On 20 December 2014 at 00:07, NeilBrown wrote: > > One of the reasons omap_hsmmc doesn't use the slot-gpio library > > is that it has some non-standard functionality in the card-detect > > interrupt service r

[PATCH 3/3] mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration.

2014-12-24 Thread NeilBrown
This ensures that all standard options are available to hsmmc, In particular, I need cap-power-off-card. Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/mmc/host

[PATCH 0/3] Convert omap_hsmmc to use common devicetree parsing code.

2014-12-24 Thread NeilBrown
This is a resend against latest git://git.linaro.org/people/ulf.hansson/mmc next with requested changes. My goal is to get omap_hsmmc to use the common code for parsing of, particularly so that I can set "cap-power-off-card", which omap_hsmmc doesn't explicitly report. Th

[PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

2014-12-24 Thread NeilBrown
Using the common code removes some code duplication, and makes it easier to switch to using mmc_of_parse() which will remove more duplication. This uses the new mmc_gpio_set_cd_isr to provide a non-standard interrupt service routine for card-detect interrupts. Signed-off-by: NeilBrown

[PATCH 1/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2014-12-24 Thread NeilBrown
ich provides an alternate isr to be registered by the slot-gpio code. Signed-off-by: NeilBrown --- drivers/mmc/core/slot-gpio.c | 20 +++- include/linux/mmc/slot-gpio.h |2 ++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/c

Re: [PATCH] OMAP GPIO - don't wake from suspend unless requested.

2012-12-13 Thread NeilBrown
that looks right. But then I don't remember what we ended up with - it was 3 months ago!!! This is the last thing I can find in my email history - it still seems to apply and still seems to work. NeilBrown From: NeilBrown Date: Mon, 10 Sep 2012 14:09:06 +1000 Subject: [PATCH] OMAP GPIO

twl4030_charger seems to be broken by switch from 'notifier' to 'mailbox'.

2012-12-14 Thread NeilBrown
other way it should work? Thanks, NeilBrown signature.asc Description: PGP signature

Re: [PATCH] OMAP: add pwm driver using dmtimers.

2012-12-14 Thread NeilBrown
On Thu, 13 Dec 2012 11:42:18 -0600 Jon Hunter wrote: > > On 12/12/2012 10:33 PM, NeilBrown wrote: > > On Thu, 13 Dec 2012 14:06:35 +1100 NeilBrown wrote: > > > >>>> +omap_dm_timer_enable(omap->dm_timer); > >>> > >>>

Re: twl4030_charger seems to be broken by switch from 'notifier' to 'mailbox'.

2012-12-14 Thread NeilBrown
On Fri, 14 Dec 2012 11:36:59 +0200 Felipe Balbi wrote: > Hi, > > On Fri, Dec 14, 2012 at 08:04:27PM +1100, NeilBrown wrote: > > this commit: > > > > commit c9721438c009adf8e81d376839ed037c53b9b8d9 > > Author: Kishon Vijay Abraham I > > Date: Fri Jun

[PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list

2012-12-15 Thread NeilBrown
(cpu_is_omap34xx()) is now disabled as dss_has_feature(FEAT_DPI_USES_VDDS_DSI) fails. So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list. Cc: Chandrabhanu Mahapatra Cc: Tomi Valkeinen Signed-off-by: NeilBrown diff --git a/drivers/video/omap2/dss/dss_features.c b/drivers/video/omap2/dss

Re: [PATCH] OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list

2012-12-17 Thread NeilBrown
On Mon, 17 Dec 2012 13:58:59 +0200 Tomi Valkeinen wrote: > On 2012-12-15 23:08, NeilBrown wrote: > > > > commit 195e672a76056478cc79f5c48343164c9237852e > >OMAPDSS: DPI: Remove cpu_is_ checks > > > > made the mistake of assuming that cpu_is_omap34xx()

Re: [PATCH] OMAP: add pwm driver using dmtimers.

2013-01-06 Thread NeilBrown
On Thu, 13 Dec 2012 11:07:25 -0600 Jon Hunter wrote: > > On 12/12/2012 09:06 PM, NeilBrown wrote: > > > >>> + > >>> +#if CONFIG_PM > >>> +static int omap_pwm_suspend(struct platform_device *pdev, pm_message_t > >>> state) > &g

Help wanted with USB and OMAP3 off_mode

2013-01-08 Thread NeilBrown
r domain out of off_mode, the GSM module doesn't disappear. So it seems that some context in the usbhost domain is not being save and restored. This is as far as I can get. Can someone suggest where I should look to find out what is not being saved/restored properly, and how to go about saving

Re: Help wanted with USB and OMAP3 off_mode

2013-01-09 Thread NeilBrown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 09 Jan 2013 12:00:05 +0200 Igor Grinberg wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Neil, > > On 01/09/13 00:29, NeilBrown wrote: > > > > Hi, > > I'm trying to get off_mode

Re: Help wanted with USB and OMAP3 off_mode

2013-01-09 Thread NeilBrown
On Wed, 09 Jan 2013 11:24:09 +0100 Michael Trimarchi wrote: > Hi Neil > > On 01/09/2013 11:19 AM, NeilBrown wrote: > > On Wed, 09 Jan 2013 12:00:05 +0200 Igor Grinberg > > wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 &

Re: Help wanted with USB and OMAP3 off_mode

2013-01-15 Thread NeilBrown
On Wed, 09 Jan 2013 14:54:00 +0200 Igor Grinberg wrote: > On 01/09/13 14:08, Michael Trimarchi wrote: > > Hi Neil > > > > I forget to answer to your questions > > > > On 01/09/2013 12:34 PM, NeilBrown wrote: > >> On Wed, 09 Jan 2013 11:24:09 +0100 Mi

Re: Help wanted with USB and OMAP3 off_mode

2013-01-15 Thread NeilBrown
On Wed, 09 Jan 2013 12:42:43 +0100 Michael Trimarchi wrote: > On 01/09/2013 12:34 PM, NeilBrown wrote: > > On Wed, 09 Jan 2013 11:24:09 +0100 Michael Trimarchi > > wrote: > > > >> Hi Neil > >> > >> On 01/09/2013 11:19 AM, NeilBrown wrote: > &

Re: Help wanted with USB and OMAP3 off_mode

2013-01-16 Thread NeilBrown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 16 Jan 2013 11:28:02 +0200 Igor Grinberg wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/16/13 09:26, NeilBrown wrote: > > On Wed, 09 Jan 2013 14:54:00 +0200 Igor Grinberg > > wrote: > > &

Re: Help wanted with USB and OMAP3 off_mode

2013-01-16 Thread NeilBrown
On Wed, 16 Jan 2013 12:00:48 +0200 Roger Quadros wrote: > On 01/09/2013 12:29 AM, NeilBrown wrote: > > > > Hi, > > I'm trying to get off_mode working reliably on my gta04 mobile phone. > > > > My current stumbling block is USB. The "Option"

Re: Help wanted with USB and OMAP3 off_mode

2013-01-16 Thread NeilBrown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 16 Jan 2013 13:11:26 +0200 Igor Grinberg wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/16/13 12:19, NeilBrown wrote: > > On Wed, 16 Jan 2013 11:28:02 +0200 Igor Grinberg > > wrote: > &g

Re: Help wanted with USB and OMAP3 off_mode

2013-01-17 Thread NeilBrown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 17 Jan 2013 11:22:55 +1100 NeilBrown wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Wed, 16 Jan 2013 13:11:26 +0200 Igor Grinberg > wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: S

Re: Help wanted with USB and OMAP3 off_mode

2013-01-17 Thread NeilBrown
On Wed, 16 Jan 2013 12:57:08 +0200 Roger Quadros wrote: > On 01/16/2013 12:27 PM, NeilBrown wrote: > > On Wed, 16 Jan 2013 12:00:48 +0200 Roger Quadros wrote: > > > >> On 01/09/2013 12:29 AM, NeilBrown wrote: > >>> > >>> Hi, > >>> I&

Re: Help wanted with USB and OMAP3 off_mode

2013-01-17 Thread NeilBrown
On Thu, 17 Jan 2013 13:29:07 +0200 Roger Quadros wrote: > On 01/17/2013 01:01 PM, NeilBrown wrote: > > On Wed, 16 Jan 2013 12:57:08 +0200 Roger Quadros wrote: > > > >> On 01/16/2013 12:27 PM, NeilBrown wrote: > >>> On Wed, 16 Jan 2013 12:00:48 +0200 Roger Q

[PATCH] usb: musb: fix context save over suspend.

2013-01-21 Thread NeilBrown
MAP3 system with off_mode enabled will find the musb port non-functional after suspend/resume. With the patch it works perfectly. Signed-off-by: NeilBrown diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index fd34867..b6ccc02 100644 --- a/drivers/usb/musb/musb_core

Re: [PATCH] usb: musb: fix context save over suspend.

2013-01-21 Thread NeilBrown
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 21 Jan 2013 13:38:59 +0200 Igor Grinberg wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Neil, > > On 01/21/13 11:28, NeilBrown wrote: > > > > > > The standard suspend sequence involves

Re: [PATCH] usb: musb: fix context save over suspend.

2013-02-12 Thread NeilBrown
On Tue, 12 Feb 2013 13:03:36 -0800 Kevin Hilman wrote: > NeilBrown writes: > > > On Mon, 21 Jan 2013 13:38:59 +0200 Igor Grinberg > > wrote: > > > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >

[PATCH 3/3] mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration.

2015-01-12 Thread NeilBrown
This ensures that all standard options are available to hsmmc, In particular, I need cap-power-off-card. Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 33 - 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/mmc/host

[PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

2015-01-12 Thread NeilBrown
Using the common code removes some code duplication, and makes it easier to switch to using mmc_of_parse() which will remove more duplication. This uses the new mmc_gpio_request_cd_isr to provide a non-standard interrupt service routine for card-detect interrupts. Signed-off-by: NeilBrown

[PATCH 1/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2015-01-12 Thread NeilBrown
hich provide an alternate isr to be register by the slot-gpio code. Signed-off-by: NeilBrown --- drivers/mmc/core/slot-gpio.c | 18 +- include/linux/mmc/slot-gpio.h |2 ++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/slot-gpio.c b/drivers/mmc/c

[PATCH 0/3] Convert omap_hsmmc to use common devicetree parsing code.

2015-01-12 Thread NeilBrown
", which omap_hsmmc doesn't explicitly report. Thanks, NeilBrown P.S. Sorry for delay - I've been travelling. --- NeilBrown (3): mmc: core: Allow host driver to provide isr for card-detect interrupts. mmc: omap_hsmmc: use slot-gpio library for gpio support. mmc: omap_hsm

Re: [PATCH 12/13] ARM: dts: omap3-gta04: uart4 is not connected, so mark it "disabled"

2015-01-23 Thread NeilBrown
On Thu, 22 Jan 2015 13:40:53 -0800 Tony Lindgren wrote: > * Marek Belisko [150122 12:42]: > > From: NeilBrown > > > > Signed-off-by: NeilBrown > > --- > > arch/arm/boot/dts/omap3-gta04.dtsi | 4 > > 1 file changed, 4 insertions(+) > > &

How to manage SDIO interrupts with a runtime power managed host.

2015-01-27 Thread NeilBrown
abort if it is still in 4-bit mode. Would that be a good idea? Would it make sense to get mmc_gate_clock to switch bus width (if it is an SDIO card with interrupts enabled) rather than having a separate timeout thing? Thoughts? Thanks, NeilBrown pgpR90So0Pia5.pgp Description: OpenPGP digital signature

[PATCH-RFC 0/3] mmc: switch to 1-bit mode which stopping clocks.

2015-01-27 Thread NeilBrown
chip to work much better. This is an RFC. The code seems to work, but I feel it could be structured better (so that other drivers can share more of it), and I need to convince myself there is no room for races. Thanks, NeilBrown --- NeilBrown (3): mmc: core: allow non-blocking form of

[PATCH 1/3] mmc: core: allow non-blocking form of mmc_claim_host

2015-01-27 Thread NeilBrown
to handle 'abort' being set just as the host is claimed. This allows extra functionality. If __mmc_claim_host() is called with an 'abort' point which is initialized to '1', it will effect a non-blocking 'claim'. Signed-off-by: NeilBrown --- drivers/mmc/co

[PATCH 2/3] mmc: core: export functions for setting bus width.

2015-01-27 Thread NeilBrown
It is not safe for a host to turn off clocks while expecting an SD card interrupt unless it first places the bus in 1-bit mode. To allow hosts to do this, export functions necessary for changing bus width. Signed-off-by: NeilBrown --- drivers/mmc/core/core.c |1 + drivers/mmc/core/sdio.c

[PATCH 3/3] mmc: omap_hsmmc: switch to 1-bit before turning off clocks if interrupts expected.

2015-01-27 Thread NeilBrown
s wifi with a 4-bit bus, with interrupts and runtime power-management enabled, and get around 14Mb/sec throughput (which is the best I've seen). Signed-off-by: NeilBrown --- drivers/mmc/host/omap_hsmmc.c | 55 - 1 file changed, 53 insertions(+), 2 deletions

Re: [PATCH 3/3] mmc: omap_hsmmc: switch to 1-bit before turning off clocks if interrupts expected.

2015-01-28 Thread NeilBrown
On Wed, 28 Jan 2015 21:18:40 +0100 Ulf Hansson wrote: > On 28 January 2015 at 00:35, NeilBrown wrote: > > According to section 7.1.2 of > > > > http://www.sandisk.com/media/File/OEM/Manuals/SD_SDIO_specsv1.pdf > > > > In the case where the interrupt mechani

[PATCH-v2 0/4] mmc: switch to 1-bit mode which stopping clocks.

2015-01-30 Thread NeilBrown
t. If you think calling host->enable/disable around mmc_set_ios() calls does make sense, I can post my other patch for review. Thanks, NeilBrown --- NeilBrown (4): mmc: core: fold mmc_set_bus_width calls into sdio_enable_4bit_bus. mmc: core: allow non-blocking form of mmc_claim_h

<    1   2   3   4   >