Re: [PATCH v3 07/17] OMAP2,3: DSS2: Build omap_device for each DSS HWIP

2011-01-04 Thread Semwal, Sumit
Hi Tony, On Tue, Jan 4, 2011 at 7:26 AM, Tony Lindgren t...@atomide.com wrote: * Guruswamy Senthilvadivu svad...@ti.com [110103 04:51]: +     char *omap2_oh_name[] = { dss_dss, dss_dispc, dss_rfbi, +                             dss_venc }; +     char *omap3_oh_name[] = { dss_dss, dss_dispc,

Re: [PATCH v3 08/17] OMAP2,3: DSS2: Create platform_driver for each DSS HW IP

2011-01-04 Thread Semwal, Sumit
Hi Kevin, On Wed, Jan 5, 2011 at 5:37 AM, Kevin Hilman khil...@ti.com wrote: Guruswamy Senthilvadivu svad...@ti.com writes: From: Senthilvadivu Guruswamy svad...@ti.com Hwmod adaptation design requires each of the DSS HW IP to be a platform driver. Platform driver of dsshw has to be

Re: [PATCH v3 06/17] OMAP2,3 DSS2 Move DSS driver register from board file to devices.c

2011-01-05 Thread Semwal, Sumit
Hi Tomi, On Wed, Jan 5, 2011 at 4:21 PM, Tomi Valkeinen tomi.valkei...@nokia.com wrote: Hi, On Mon, 2011-01-03 at 18:20 +0530, ext Guruswamy Senthilvadivu wrote: From: Senthilvadivu Guruswamy svad...@ti.com omap_display_init function is introduced in devices.c to do the DSS driver

Re: [PATCH v3 08/17] OMAP2,3: DSS2: Create platform_driver for each DSS HW IP

2011-01-05 Thread Semwal, Sumit
Hi Tomi, On Wed, Jan 5, 2011 at 4:57 PM, Tomi Valkeinen tomi.valkei...@nokia.com wrote: Hi, On Mon, 2011-01-03 at 18:21 +0530, ext Guruswamy Senthilvadivu wrote: From: Senthilvadivu Guruswamy svad...@ti.com Hwmod adaptation design requires each of the DSS HW IP to be a platform driver.

Re: [PATCH v5 06/17] OMAP2,3: DSS2: Create new file display.c for central dss driver registration.

2011-01-08 Thread Semwal, Sumit
Tomi, On Fri, Jan 7, 2011 at 7:33 PM, Tomi Valkeinen tomi.valkei...@nokia.com wrote: Hi, On Fri, 2011-01-07 at 16:55 +0530, ext Sumit Semwal wrote: A new file display.c is introduced for display driver init, which adds a function omap_display_init to do the DSS driver registration. This is

Re: [PATCH v5 06/17] OMAP2,3: DSS2: Create new file display.c for central dss driver registration.

2011-01-08 Thread Semwal, Sumit
Hi Kevin, On Sat, Jan 8, 2011 at 2:56 AM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: A new file display.c is introduced for display driver init, which adds a function omap_display_init to do the DSS driver registration. This is the first step in moving

Re: [PATCH v5 06/17] OMAP2,3: DSS2: Create new file display.c for central dss driver registration.

2011-01-08 Thread Semwal, Sumit
On Sun, Jan 9, 2011 at 12:29 PM, Semwal, Sumit sumit.sem...@ti.com wrote: Tomi, On Fri, Jan 7, 2011 at 7:33 PM, Tomi Valkeinen tomi.valkei...@nokia.com wrote: Hi, On Fri, 2011-01-07 at 16:55 +0530, ext Sumit Semwal wrote: A new file display.c is introduced for display driver init, which

Re: [PATCH v5 08/17] OMAP2,3: DSS2: Build omap_device for each DSS HWIP

2011-01-09 Thread Semwal, Sumit
Hi Kevin, On Sat, Jan 8, 2011 at 5:04 AM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: From: Senthilvadivu Guruswamy svad...@ti.com Looks up the hwmod database for each of the given DSS HW IP and builds omap_device which inturn does the platform device

Re: [PATCH v5 09/17] OMAP2,3: DSS2: DSS: create platform_driver, move init,exit to driver

2011-01-09 Thread Semwal, Sumit
Hi Kevin, On Sat, Jan 8, 2011 at 5:13 AM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: From: Senthilvadivu Guruswamy svad...@ti.com Hwmod adaptation design requires each of the DSS HW IP to be a platform driver. So a platform_driver of DSS is created and

Re: [PATCH 0/3] OMAP4: DSS OMAP4 hwmod support

2011-01-09 Thread Semwal, Sumit
Hi Kevin, On Sat, Jan 8, 2011 at 4:32 AM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: This patch series enables support for OMAP4 DSS, and adds hwmod support for dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods. This series is confusing as the 3 patches

Re: [PATCH 0/3] OMAP4: DSS OMAP4 hwmod support

2011-01-10 Thread Semwal, Sumit
Hi Kevin, On Tue, Jan 11, 2011 at 7:06 AM, Kevin Hilman khil...@ti.com wrote: Hi Sumit, Semwal, Sumit sumit.sem...@ti.com writes: On Sat, Jan 8, 2011 at 4:32 AM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: This patch series enables support for OMAP4 DSS

Re: [PATCH v5 10/17] OMAP2,3: DSS2: Move clocks from core driver to dss driver

2011-01-10 Thread Semwal, Sumit
Hi Paul, On Tue, Jan 11, 2011 at 5:29 AM, Paul Walmsley p...@pwsan.com wrote: On Fri, 7 Jan 2011, Sumit Semwal wrote: From: Senthilvadivu Guruswamy svad...@ti.com All clock management is moved to dss platform driver. clk_get/put APIs use dss device instead of core platform device. Hwmod

Re: [PATCH v7 00/18] OMAP2,3: hwmod DSS Adaptation

2011-01-21 Thread Semwal, Sumit
Hi Kevin, On Fri, Jan 21, 2011 at 10:36 AM, Kevin Hilman khil...@ti.com wrote: Hi Sumit, Sumit Semwal sumit.sem...@ti.com writes: [...] Testing: - The patches are tested on 2420-n800, 2430sdp, 3630zoom, 3430sdp. Complete bootup with penguins on panel is done on 3430sdp. For the

Re: [PATCH v8 00/18] OMAP2,3: hwmod DSS Adaptation

2011-01-21 Thread Semwal, Sumit
Hi Kevin, On Fri, Jan 21, 2011 at 10:05 PM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: v8 of the DSS hwmod patch series fixes some issues based on findings of Kevin Hilman on beagle. Thanks.  I re-tested on beagle and it looks good. I also briefly tested

Re: [PATCH v9 18/18] OMAP2,3: DSS2: Get DSS IRQ from platform device

2011-01-23 Thread Semwal, Sumit
On Sun, Jan 23, 2011 at 6:22 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Sun, Jan 23, 2011 at 03:39:23PM +0300, Sergei Shtylyov wrote: diff --git a/drivers/video/omap2/dss/dss.c b/drivers/video/omap2/dss/dss.c index 4d7a816..22690e9 100644 --- a/drivers/video/omap2/dss/dss.c

Re: [PATCH-V2] OMAP3EVM: Made backlight GPIO default state to off

2011-01-24 Thread Semwal, Sumit
Vaibhav, On Tue, Jan 25, 2011 at 12:52 AM, Vaibhav Hiremath hvaib...@ti.com wrote: If you choose default output to DVI, the LCD backlight used to stay on, since panel-disable function never gets called. So, during init put backlight GPIO to off state and the driver code will decide which

Re: [PATCH v10 18/18] OMAP2, 3: DSS2: Get DSS IRQ from platform device

2011-01-27 Thread Semwal, Sumit
Raghuveer, On Thu, Jan 27, 2011 at 6:34 PM, Raghuveer Murthy x0075...@ti.com wrote: On Thursday 27 January 2011 06:29 PM, Russell King - ARM Linux wrote: On Thu, Jan 27, 2011 at 06:19:21PM +0530, Raghuveer Murthy wrote: +       r = request_irq(dss_irq, +               cpu_is_omap24xx() +  

Re: [PATCH v2 4/4] OMAP4: DSS2: clocks: Add ick as dummy clock

2011-01-27 Thread Semwal, Sumit
On Thu, Jan 27, 2011 at 11:16 PM, Kevin Hilman khil...@ti.com wrote: Sumit Semwal sumit.sem...@ti.com writes: DSS code uses ick as one of the clocks in clk_get/clk_put. OMAP4 clock database doesn't have ick for DSS, so adding ick as dummy clock. Once pm_runtime* APIs get introduced in DSS,

Re: [PATCH 3/5] [media]: OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-26 Thread Semwal, Sumit
Hi Vaibhav, On Mon, Sep 26, 2011 at 3:49 PM, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: Taneja, Archit Sent: Thursday, September 22, 2011 11:46 AM To: Hiremath, Vaibhav Cc: Valkeinen, Tomi; linux-omap@vger.kernel.org; Semwal, Sumit; linux- me

Re: [PATCH 3/5] [media]: OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-27 Thread Semwal, Sumit
Hi Vaibhav, On Tue, Sep 27, 2011 at 12:09 PM, Hiremath, Vaibhav hvaib...@ti.com wrote: -Original Message- From: Semwal, Sumit Sent: Tuesday, September 27, 2011 11:12 AM To: Hiremath, Vaibhav Cc: Taneja, Archit; Valkeinen, Tomi; linux-omap@vger.kernel.org; linux- me

Re: [PATCH v4 3/5] OMAP_VOUT: Fix VSYNC IRQ handling in omap_vout_isr

2011-09-28 Thread Semwal, Sumit
On Wed, Sep 28, 2011 at 8:19 PM, Archit Taneja arc...@ti.com wrote: Currently, in omap_vout_isr(), if the panel type is DPI, and if we get either VSYNC or VSYNC2 interrupts, we proceed ahead to set the current buffers state to VIDEOBUF_DONE and prepare to display the next frame in the queue.

Re: [PATCH v4 2/5] OMAP_VOUT: CLEANUP: Remove redundant code from omap_vout_isr

2011-09-29 Thread Semwal, Sumit
On Wed, Sep 28, 2011 at 8:19 PM, Archit Taneja arc...@ti.com wrote: Currently, there is a lot of redundant code is between DPI and VENC panels, this can be made common by moving out field/interlace specific code to a separate function called omapvid_handle_interlace_display(). There is no

Re: [PATCH] staging: drm/omap: remove reclaim_buffers callback

2012-08-01 Thread Semwal, Sumit
On Wed, Aug 1, 2012 at 3:02 PM, Chandrabhanu Mahapatra cmahapa...@ti.com wrote: The reclaim_buffers callback has already been removed by Daniel Vetter daniel.vet...@ffwll.ch with his patch drm: kill reclaim_buffers callback for which the kernel compilation fails with omapdrm support. So, the

Re: [RFC 0/3] solving omapdrm/omapdss layering issues

2012-08-03 Thread Semwal, Sumit
Hi Rob, Tomi, On Thu, Aug 2, 2012 at 7:46 PM, Rob Clark rob.cl...@linaro.org wrote: On Thu, Aug 2, 2012 at 8:15 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Thu, 2012-08-02 at 07:45 -0500, Rob Clark wrote: On Thu, Aug 2, 2012 at 2:13 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On

Re: [PATCH] staging: omapdrm: Fix DMM sparse warnings

2012-08-10 Thread Semwal, Sumit
On Thu, Aug 9, 2012 at 10:26 PM, Rob Clark rob.cl...@linaro.org wrote: On Thu, Aug 9, 2012 at 12:14 AM, Andy Gross andy.gr...@ti.com wrote: Fix the following sparse warnings: drivers/staging/omapdrm/omap_dmm_tiler.c:123:13: warning: symbol 'omap_dmm_irq_handler' was not declared.

Re: [PATCH] drm/omap: update for interlaced

2012-09-05 Thread Semwal, Sumit
Hi Rob, On Thu, Sep 6, 2012 at 3:18 AM, Rob Clark rob.cl...@linaro.org wrote: From: Rob Clark r...@ti.com 'struct omap_video_timings' was updated w/ a 'bool interlaced'. Without a matching update in omap_connector, this field could have undefined values from the stack, which isn't quite

Re: [PATCH 5/5] OMAP4: DSS2: VIDEO3 pipeline support

2011-08-05 Thread Semwal, Sumit
On Fri, Aug 5, 2011 at 8:42 AM, Archit Taneja arc...@ti.com wrote: Add support for VIDEO3 pipeline on OMAP4: - Add VIDEO3 pipeline information in dss_features and omapdss.h - Add VIDEO3 pipeline register coefficients in dispc.h - Create a new overlay structure corresponding to VIDEO3.

Re: [PATCH v3 09/10] OMAP4: DSS2: HDMI: Function pointer approach to call

2011-09-04 Thread Semwal, Sumit
On Fri, Sep 2, 2011 at 4:17 PM, mythr...@ti.com wrote: From: Mythri P K mythr...@ti.com snip +       hdmi.hdmi_data.ops-video_enable(hdmi.hdmi_data, 0); Still too much of 'hdmi' in this line - maybe you can just replace hdmi_data w/ data (like you did for hdmi_ops w/ ops)? snip -- To

Re: [PATCH] omap_vout: Set DSS overlay_info only if paddr is non zero

2012-06-28 Thread Semwal, Sumit
On Mon, Mar 19, 2012 at 5:16 PM, Archit Taneja a0393...@ti.com wrote: On Monday 19 March 2012 02:15 PM, Hiremath, Vaibhav wrote: On Fri, Mar 16, 2012 at 16:41:27, Taneja, Archit wrote: Hi, On Friday 16 March 2012 03:46 PM, Archit Taneja wrote: On Monday 12 March 2012 03:34 PM, Hiremath,

Re: [PATCH v10 18/18] OMAP2,3: DSS2: Get DSS IRQ from platform device

2011-02-14 Thread Semwal, Sumit
Hi, On Mon, Feb 14, 2011 at 7:39 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Mon, 2011-01-24 at 11:52 +0530, ext Sumit Semwal wrote: From: Senthilvadivu Guruswamy svad...@ti.com DSS IRQ number can be obtained from platform_get_irq().  This API in turn picks the right IRQ number

Re: [PATCH v3 2/3] OMAP4: hwmod data: add DSS DISPC DSI1,2 RFBI HDMI VENC

2011-02-14 Thread Semwal, Sumit
are purely cosmetic. On 1/27/2011 12:17 PM, Semwal, Sumit wrote: From: Benoit Coussonb-cous...@ti.com Add dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods. In OMAP4 there are severals IPs that can be reached by differents interconnect paths depending of the access initiator (MPU vs. SDMA

Re: OMAP: DSS2: Common IRQ handler for all OMAPs

2011-02-15 Thread Semwal, Sumit
Hi Benoit, On Tue, Feb 15, 2011 at 3:53 PM, Cousson, Benoit b-cous...@ti.com wrote: Hi Archit, On 2/15/2011 10:25 AM, Taneja, Archit wrote: Copying Benoit, On Tuesday 15 February 2011 02:07 PM, Valkeinen, Tomi wrote: On Tue, 2011-02-15 at 02:30 -0600, Taneja, Archit wrote: Hi, On

Re: [v3,1/3] OMAP2PLUS: DSS2: Add OMAP4 Kconfig support

2011-02-15 Thread Semwal, Sumit
Hi Tomi, Sent an updated one; apologies for double posting, as I posted the first one with your earlier email Id. Best regards, ~Sumit. On Fri, Feb 11, 2011 at 5:36 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Thu, 2011-01-27 at 11:17 +, Sumit Semwal wrote: From: Mayuresh

Re: [PATCH 4/8] OMAP4: hwmod data: Add DSS, DISPC, DSI12, RFBI, HDMI and VENC

2011-02-17 Thread Semwal, Sumit
Hi Benoit, One minor comment; On Thu, Feb 17, 2011 at 3:54 PM, Benoit Cousson b-cous...@ti.com wrote: Add dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods. In OMAP4 there are severals IPs that can be reached by differents interconnect paths depending of the access initiator (MPU vs. SDMA).

Re: [PATCH 4/8] OMAP4: hwmod data: Add DSS, DISPC, DSI12, RFBI, HDMI and VENC

2011-02-17 Thread Semwal, Sumit
On Thu, Feb 17, 2011 at 8:32 PM, Semwal, Sumit sumit.sem...@ti.com wrote: Hi Benoit, One minor comment; On Thu, Feb 17, 2011 at 3:54 PM, Benoit Cousson b-cous...@ti.com wrote: Add dss, dispc, dsi1, dsi2, hdmi, rfbi and venc hwmods. In OMAP4 there are severals IPs that can be reached

Re: omapfb: no driver for display

2011-02-20 Thread Semwal, Sumit
Hi, On Sat, Feb 19, 2011 at 6:10 PM, Ming Lei tom.leim...@gmail.com wrote: Hi, 2011/2/19 archit taneja arc...@ti.com: Hi, Which board are you on? For all the display devices you add in the board file, you should have the corresponding drivers in the menuconfig set also. Pandaboard. DVI

Re: [PATCH v10 05/18] OMAP2,3 DSS2 Change driver name to omap_display

2011-02-28 Thread Semwal, Sumit
Hi, On Mon, Feb 28, 2011 at 12:57 PM, archit taneja arc...@ti.com wrote: Hi, On Monday 28 February 2011 12:49 PM, Valkeinen, Tomi wrote: On Mon, 2011-02-28 at 01:09 -0600, Taneja, Archit wrote: Hi, On Monday 28 February 2011 12:23 PM, Valkeinen, Tomi wrote: snip I just realized that

Re: [Patch 1/2] OMAP2PLUS: DSS2: Add dss_opt_clk_roles in pdata

2011-02-28 Thread Semwal, Sumit
Hi Tomi, On Mon, Feb 28, 2011 at 2:40 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: snip +     oc = oh-opt_clks; +     oc_count = oh-opt_clks_cnt; + +     /* copy roles of opt_clocks available from hwmod into pdata */ +     pdata.dss_opt_clk_roles = kzalloc(sizeof(char *) * oc_count, +    

Re: [Patch v2 0/2] OMAP2PLUS:DSS2: use opt-clocks information from hwmod.

2011-02-28 Thread Semwal, Sumit
Minor correction: On Mon, Feb 28, 2011 at 8:32 PM, Sumit Semwal sumit.sem...@ti.com wrote: snip Based on top of: http://gitorious.org/linux-omap-dss2/linux/commits/master commit: ad1c76c: OMAP: Overo Palo43 LCD support The correct base is:

Re: [Patch v2 1/2] OMAP2PLUS:DSS2: add opt_clock_available in pdata

2011-02-28 Thread Semwal, Sumit
On Mon, Feb 28, 2011 at 9:33 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2011-02-28 at 09:02 -0600, Semwal, Sumit wrote: Provide a function in pdata to allow dss submodules to check if a given clock is available on a platform as an optional clock. Signed-off-by: Senthilvadivu

Re: [Patch v2 1/2] OMAP2PLUS:DSS2: add opt_clock_available in pdata

2011-02-28 Thread Semwal, Sumit
On Tue, Mar 1, 2011 at 11:49 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2011-02-28 at 23:42 -0600, Semwal, Sumit wrote: On Mon, Feb 28, 2011 at 9:33 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2011-02-28 at 09:02 -0600, Semwal, Sumit wrote: Provide a function

Re: [Patch v2 1/2] OMAP2PLUS:DSS2: add opt_clock_available in pdata

2011-02-28 Thread Semwal, Sumit
On Tue, Mar 1, 2011 at 12:07 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2011-03-01 at 00:27 -0600, Semwal, Sumit wrote: On Tue, Mar 1, 2011 at 11:49 AM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2011-02-28 at 23:42 -0600, Semwal, Sumit wrote: On Mon, Feb 28, 2011