Re: [PATCH] mfd: omap-usb-host: AM3715 OHCI needs 120m functional clock

2015-10-13 Thread Ben Dooks
On 12/10/15 20:19, Tony Lindgren wrote: > * Ben Dooks <ben.do...@codethink.co.uk> [151012 11:22]: >> On 12/10/15 18:45, Tony Lindgren wrote: >>> * Ben Dooks <ben.do...@codethink.co.uk> [151012 10:38]: >>>> The AM3715 OHCI controller will not function wi

Re: [PATCH] mfd: omap-usb-host: AM3715 OHCI needs 120m functional clock

2015-10-13 Thread Ben Dooks
On 13/10/15 09:45, Roger Quadros wrote: > Ben, > > On 13/10/15 11:23, Ben Dooks wrote: >> On 12/10/15 20:19, Tony Lindgren wrote: >>> * Ben Dooks <ben.do...@codethink.co.uk> [151012 11:22]: >>>> On 12/10/15 18:45, Tony Lindgren wrote: >>>>&

[PATCH] mfd: omap-usb-host: AM3715 OHCI needs 120m functional clock

2015-10-12 Thread Ben Dooks
that if no EHCI ports are signalled then the 120m_fclk should be enabled. We have found no information about why this is necessary, but it is suspected the EHCI controller does not complete the initial reset sequence and therefore does not hand control of the USB port back. Signed-off-by: Ben

Re: [PATCH] mfd: omap-usb-host: AM3715 OHCI needs 120m functional clock

2015-10-12 Thread Ben Dooks
On 12/10/15 18:45, Tony Lindgren wrote: > * Ben Dooks <ben.do...@codethink.co.uk> [151012 10:38]: >> The AM3715 OHCI controller will not function without the EHCI >> unit's 120m fclk being enabled. If all the ports in the system >> are set to OHCI then the 120

Re: [PATCH v2] clk: ti: fix dual-registration of uart4_ick

2015-10-02 Thread Ben Dooks
On 02/10/15 07:07, Tero Kristo wrote: > On 10/02/2015 03:15 AM, Stephen Boyd wrote: >> On 09/29, Ben Dooks wrote: >>> On the OMAP AM3517 platform the uart4_ick gets registered >>> twice, causing any power managment to /dev/ttyO3 to fail >>> when trying to wak

[PATCH v2] clk: ti: fix dual-registration of uart4_ick

2015-09-29 Thread Ben Dooks
[] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c Cc: sta...@vger.kernel.org Cc: mturque...@baylibre.com Cc: sb...@codeaurora.org Cc: linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org Cc: t-kri...@ti.com Cc: linux-ker...@lists.codethink.co.uk Signed-off-by: Ben Dooks <ben

Re: [PATCH] clk: ti: fix dual-registration of uart4_ick

2015-09-29 Thread Ben Dooks
On 25/09/15 06:42, Tero Kristo wrote: > On 09/23/2015 08:30 PM, Tony Lindgren wrote: >> * Ben Dooks <ben.do...@codethink.co.uk> [150923 07:53]: >>> On the OMAP AM3517 platform the uart4_ick gets registered >>> twice, causing any power managment to /dev/ttyO

Re: AM3517 usb host issue

2015-09-24 Thread Ben Dooks
On 22/05/15 14:50, Felipe Balbi wrote: > Hi, > > On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote: >> I am trying to get the full-speed USB host working on an custom >> AM3517 device with the 3.18.12 kernel. The hardware works (a >> 2.6.37 kernel has been use

[PATCH] clk: ti: fix dual-registration of uart4_ick

2015-09-23 Thread Ben Dooks
[] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk> --- drivers/clk/ti/clk-3xxx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index 5e12f32..2e7ef1f 100644 --- a/drivers/clk/ti/clk-

Re: [PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

2015-07-27 Thread Ben Dooks
/proc-v7-2level.S -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: AM3517 usb host issue

2015-05-26 Thread Ben Dooks
On 22/05/15 23:13, Ben Dooks wrote: On 22/05/15 16:50, Felipe Balbi wrote: Hi, On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote: I am trying to get the full-speed USB host working on an custom AM3517 device with the 3.18.12 kernel. The hardware works (a 2.6.37 kernel has been used

AM3517 usb host issue

2015-05-22 Thread Ben Dooks
[ 77.849913] usb usb1: SerialNumber: 48064400.ohci -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: AM3517 usb host issue

2015-05-22 Thread Ben Dooks
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 22/05/15 16:50, Felipe Balbi wrote: Hi, On Fri, May 22, 2015 at 11:04:33AM +0300, Ben Dooks wrote: I am trying to get the full-speed USB host working on an custom AM3517 device with the 3.18.12 kernel. The hardware works (a 2.6.37 kernel

Re: [PATCH/RFC 3/4] of/clk: Register clocks suitable for Runtime PM with the PM core

2014-04-30 Thread Ben Dooks
-in to the support. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver'

2014-04-10 Thread Ben Dooks
controller that select between multiply PHY. No, it's not the case. There is an interesting case, the USB3 shares a PHY with a SATA and the PCIE and SATA also share a PHY on the R8A7790. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

Re: [PATCH 1/2] usb: rename 'phy' field of 'struct usb_hcd' to 'transceiver'

2014-04-10 Thread Ben Dooks
On 10/04/14 12:14, David Laight wrote: From: Ben Dooks On 10/04/14 11:49, Sergei Shtylyov wrote: On 10-04-2014 13:20, David Laight wrote: It doesn't do any pin muxing. It switches SoC internal USB signals between USB controllers. The pins remain the same. Doesn't something like

Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1

2013-10-08 Thread Ben Dooks
service ID I think you should save r12 in the call. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 3.3 v2] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-13 Thread Ben Dooks
On Wed, Feb 08, 2012 at 01:18:21PM +0200, Luciano Coelho wrote: Since commit 6145197 (i2c: OMAP: Add DT support for i2c controller), building i2c_omap.c breaks if CONFIG_OF is not set: drivers/i2c/busses/i2c-omap.c: In function 'omap_i2c_probe': drivers/i2c/busses/i2c-omap.c:1021: error:

Re: [PATCH] MAINTAINERS: List i2c-omap and i2c-davinci drivers

2012-01-17 Thread Ben Dooks
On Tue, Jan 10, 2012 at 03:36:40PM +0100, Jean Delvare wrote: This will ensure that the right people and lists are notified when these drivers are modified. sounds like a good idea. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Tony Lindgren t...@atomide.com Cc: Sekhar Nori

Re: [PATCH] OMAP: I2C: add devexit to the remove code

2012-01-06 Thread Ben Dooks
-- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada

Re: [GIT PULL] I2C: OMAP: misc. updates for v3.3

2012-01-06 Thread Ben Dooks
/i2c/omap-i2c.txt -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large

Re: [GIT PULL] I2C: OMAP: misc. cleanup for v3.2

2011-10-04 Thread Ben Dooks
On Mon, Sep 26, 2011 at 03:30:50PM -0700, Kevin Hilman wrote: ping On 09/06/2011 03:31 PM, Kevin Hilman wrote: Hi Ben, On 08/23/2011 05:10 PM, Kevin Hilman wrote: Ben, Here's one more I2C cleanup series for v3.2. It applies on top of my for_3.2/i2c-fixes branch just submitted.

Re: [GIT PULL] I2C: OMAP: major cleanup for v3.2 (was for v3.1)

2011-08-24 Thread Ben Dooks
deletions(-) -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

2011-07-13 Thread Ben Dooks
On Tue, Jul 05, 2011 at 05:01:01PM -0700, Kevin Hilman wrote: Shubhrajyoti D shubhrajy...@ti.com writes: Currently the fifo depth is set to zero for OMAP4 which disables the FIFO usage. This patch enables the FIFO usage for I2C transactions on OMAP4 also. Tested on omap4430 and 3430.

Re: [PATCH][RFC] OMAP4: I2C : I2C context save

2011-07-13 Thread Ben Dooks
On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote: Currently the OMAP4 doesnot hit device off still the driver may have support for it.Adding support for the same. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com I guess since the previous set has been taken by Kevin then

Re: [PATCH v4 00/18] I2C: OMAP: I2C fixes, removal of cpu_is... from driver

2011-07-07 Thread Ben Dooks
via the OMAP tree if at all possible so we can properly handle the conflicts. Do you mind dropping it from your next-i2c so we can merge it via linux-omap (with your Ack.) Yes, and if you could indicate all the other omap i2c patches and I'll add my ack to yours. Acked-by: Ben Dooks ben-li

Re: [PATCH v4 00/18] I2C: OMAP: I2C fixes, removal of cpu_is... from driver

2011-06-15 Thread Ben Dooks
-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v4 00/18] I2C: OMAP: I2C fixes, removal of cpu_is... from driver

2011-06-07 Thread Ben Dooks
://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] OMAP4: clockdomain: Follow recommended enable sequence

2011-03-10 Thread Ben Dooks
majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup

2011-03-04 Thread Ben Dooks
the couple of fixes I've got and send them to Linus at the end of the weekend. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH] i2c-omap: Double clear of ARDY status in IRQ handler

2011-02-15 Thread Ben Dooks
://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] i2c: OMAP: fix static suspend vs. runtime suspend

2011-02-05 Thread Ben Dooks
of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap - omap_i2c

2010-12-09 Thread Ben Dooks
...@deeprootsystems.com Cc: Rajendra Nayak rna...@ti.com Cc: Ben Dooks ben-...@fluff.org --- arch/arm/mach-omap1/clock_data.c |6 +++--- arch/arm/mach-omap2/clock2420_data.c |8 arch/arm/mach-omap2/clock2430_data.c |8 arch/arm/mach-omap2/clock3xxx_data.c | 12

Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap - omap_i2c

2010-12-09 Thread Ben Dooks
. Signed-off-by: Benoit Cousson b-cous...@ti.com c: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Rajendra Nayak rna...@ti.com Cc: Ben Dooks ben-...@fluff.org Acked-by: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-omap1/clock_data.c |6

Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap - omap_i2c

2010-12-09 Thread Ben Dooks
On Thu, Dec 09, 2010 at 10:18:48PM +, aaro.koski...@nokia.com wrote: Hi, Kevin Hilman [khil...@deeprootsystems.com]: Ben Dooks ben-...@fluff.org writes: Renaming stuff like this is going to have an impact on the userspace as anyone looking through /sys's driver heirarchy is going

Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap - omap_i2c

2010-12-09 Thread Ben Dooks
On Thu, Dec 09, 2010 at 10:18:48PM +, aaro.koski...@nokia.com wrote: Hi, Kevin Hilman [khil...@deeprootsystems.com]: Ben Dooks ben-...@fluff.org writes: Renaming stuff like this is going to have an impact on the userspace as anyone looking through /sys's driver heirarchy is going

Re: [PATCH] i2c-omap: Set latency requirements only once for several messages

2010-12-02 Thread Ben Dooks
On Thu, Nov 18, 2010 at 12:04:20PM +0200, Samu Onkalo wrote: Ordinary I2C read consist of two messages. First a write operation to tell register address and then read operation to get data. CPU wake up latency is set and removed twice in read case. Set latency requirement before the message

Re: [PATCH v3 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-10-27 Thread Ben Dooks
On Thu, Oct 07, 2010 at 10:37:03AM -0700, Kevin Hilman wrote: Ben Dooks ben-...@fluff.org writes: [...] As such, I should really go and read up all about this new runtime-pm and hwmod stuff before further commentign on the changes. ping From the drivers perspective, you don't neet

Re: [PATCH v3 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-09-28 Thread Ben Dooks
On Tue, Sep 28, 2010 at 12:29:01PM +0530, Nayak, Rajendra wrote: snip... static int omap_i2c_init(struct omap_i2c_dev *dev) @@ -356,6 +333,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) unsigned long fclk_rate = 1200; unsigned long timeout;

Re: [PATCH v3 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-09-27 Thread Ben Dooks
On Tue, Sep 21, 2010 at 07:37:16PM +0530, Rajendra Nayak wrote: This patch converts the i2c driver to use PM runtime apis Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Paul Walmsley p...@pwsan.com --- drivers/i2c/busses/i2c-omap.c | 67

Re: [PATCH] i2c-omap: Make sure i2c bus is free before setting it to idle

2010-09-21 Thread Ben Dooks
access ready) statuses set during the tranfer of the last message the bus was put to idle while still busy. This caused bus to timeout. Signed-off-by: Mathias Nyman mathias.ny...@nokia.com adding linux-i2c and Ben Dooks to Cc list. Ben, can you please take

Re: Cpufreq for s3c2440 FriendlyArm

2010-09-07 Thread Ben Dooks
On 06/09/10 04:40, Marek Vasut wrote: Dne Ne 5. září 2010 22:30:00 tarek attia napsal(a): Hi all, Did anyone try the cpufreq on the mini2440 ? and did anyone get it working on the board ? Each time I do the configuration in the kernel I found nothing on the board ,however after the

Re: [PATCH 2/4 v2] ks8851: Low level functions for read/write to companion eeprom

2010-05-10 Thread Ben Dooks
On Wed, May 05, 2010 at 08:45:53PM +0200, Sebastien Jan wrote: Low-level functions provide 16bits words read and write capability to ks8851 companion eeprom. Please use the eeprom interface that was added already Signed-off-by: Sebastien Jan s-...@ti.com --- drivers/net/ks8851.c | 228

Re: [PATCH 2/4 v2] ks8851: Low level functions for read/write to companion eeprom

2010-05-10 Thread Ben Dooks
On Thu, May 06, 2010 at 12:20:12AM -0700, David Miller wrote: From: Sebastien Jan s-...@ti.com Date: Wed, 5 May 2010 20:45:53 +0200 Low-level functions provide 16bits words read and write capability to ks8851 companion eeprom. Signed-off-by: Sebastien Jan s-...@ti.com Applied. So

Re: [PATCH v3] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt

2010-04-19 Thread Ben Dooks
On Thu, Apr 15, 2010 at 03:08:16PM +0300, Aaro Koskinen wrote: Hi, Manjunatha GK wrote: Under certain rare conditions, I2C_STAT[13].RDR bit may be set and the corresponding interrupt fire, even there is no data in the receive FIFO, or the I2C data transfer is still ongoing. These

Re: [PATCH v4] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt

2010-04-19 Thread Ben Dooks
On Mon, Apr 19, 2010 at 12:44:22PM +0530, Manjunatha GK wrote: Under certain rare conditions, I2C_STAT[13].RDR bit may be set and the corresponding interrupt fire, even there is no data in the receive FIFO, or the I2C data transfer is still ongoing. These spurious RDR events must be ignored by

Re: [PATCH] OMAP3: I2C: Errata i207: Clear wrong RDR interrupt

2010-04-05 Thread Ben Dooks
On Thu, Apr 01, 2010 at 08:53:04AM -0500, Nishanth Menon wrote: G, Manjunath Kondaiah had written, on 04/01/2010 07:20 AM, the following: Under certain rare conditions, I2C_STAT[13].RDR bit may be set and the corresponding interrupt fire, even there is no data in the receive FIFO, or the I2C

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-08 Thread Ben Dooks
On Sun, Mar 07, 2010 at 10:59:01PM +, Ben Dooks wrote: On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote: From: Marek Belisko marek.beli...@open-nandra.com The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses

Re: [PATCH] omap: i2c: Add i2c support on omap4 platform

2010-03-07 Thread Ben Dooks
-off-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Kevin Hilman khil...@deeprootsystems.com Reviewed-by: Paul Walmsley p...@pwsan.com Reviewed-by: Tony Lindgren t...@atomide.com Cc: Ben Dooks ben-li...@fluff.org Cc: Cory Maccarrone darkstar6...@gmail.com --- drivers/i2c/busses/i2c

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-07 Thread Ben Dooks
On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote: From: Marek Belisko marek.beli...@open-nandra.com The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses in the mmc-omap driver. To resolve this, a bit shift is

Re: [PATCH RE-SEND-2] ARM: MM: Add ARM_L1_CACHE_SHIFT_6 for handle inside each ARCH Kconfig

2010-01-28 Thread Ben Dooks
On Thu, Jan 28, 2010 at 10:15:32AM +0900, Kukjin Kim wrote: This patch adds ARM_L1_CACHE_SHIFT_6 into arch/arm/Kconfig. Basically, ARM L1 cache line size is 32Bytes. Therefore, whenever new ARCH which has 64Bytes L1 cache line size is added, have to set ARM_L1_CACHE_SHIFT to 6. That is, have

Re: [PATCH 0/5] Arm Gic Changes

2010-01-27 Thread Ben Dooks
On Wed, Jan 27, 2010 at 11:32:24AM -0800, adhar...@codeaurora.org wrote: From: Abhijeet Dharmapurikar adhar...@quicinc.com Few fixes and improvements to arch/arm/common/gic.c file. both ARM and GIC in the title should be all in capitals, they are abbreviations of something longer. I think it

Re:

2010-01-21 Thread Ben Dooks
Ben Gamari wrote: Bcc: Subject: GPIO chip select support in omap2_mcspi driver Hey, Recently I have been looking to use a BeagleBoard to drive several serial ADCs and DACs in a data acquisition and analysis setup. Unfortunately, the BeagleBoard is severely limited by the number of SPI

Re: [PATCH] [I2C-OMAP] Add support for 16-bit registers

2009-12-08 Thread Ben Dooks
On Sat, Dec 05, 2009 at 11:14:08PM -0800, Cory Maccarrone wrote: The current i2c-omap driver is set up for 32-bit registers, which corresponds to most OMAP devices. However, OMAP730/850 based devices use a 16-bit register size. This change modifies the driver to perform a runtime CPU type

Re:

2009-08-26 Thread Ben Dooks
Syed Rafiuddin wrote: From: Syed Rafiuddin rafiuddin.s...@ti.com This patch Adds Keypad support on OMAP4.And adds OMAP4 register addresses and configures them for OMAP4. [SNIP] Subjects are considered useful, please supply at-least semi meaningful subject next time! -- To unsubscribe from

Re: [RESUBMIT][PATCH-v2][RFC] OMAP4: I2C Support for OMAP4430

2009-08-20 Thread Ben Dooks
On Tue, Aug 18, 2009 at 03:35:31PM +0530, Syed Rafiuddin wrote: Ben, On Fri, Jul 24, 2009 at 04:40:02PM +0530, Syed Rafiuddin wrote: Hi Ben, This patch adds OMAP4 support to the I2C driver. All I2C register addresses are different between OMAP1/2/3 and OMAP4. In order to not

Re: [PATCH 0/3] i2c-omap: I2C clean-up patch

2009-08-20 Thread Ben Dooks
On Thu, Aug 20, 2009 at 11:21:13AM -0500, Moiz Sonasath wrote: This patch includes the following fixes: -Fix I2C status ACK -ACK pending [R/X]DR and [R/X]RDY interrupts in the error/completeion path -Enable workaround for Errata 1.153 based on I2C IP block ok, will add these to my fixes tree.

Re: [PATCH] I2C: OMAP3: PM: (re)init for every transfer to support off-mode

2009-07-29 Thread Ben Dooks
On Tue, Jul 21, 2009 at 04:09:03PM -0700, Kevin Hilman wrote: From: Rajendra Nayak rna...@ti.com Because of OMAP off-mode, powerdomain can go off when I2C is idle. Save enough state, and do a re-init for each transfer. Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor

Re: [PATCH 0/3] [OMAP:I2C] Small bug fixes and errata 1.153

2009-07-29 Thread Ben Dooks
On Tue, Jul 21, 2009 at 10:13:20AM -0500, Sonasath, Moiz wrote: This patch includes the following: - Bug in reading the RXSTAT/TXSTAT values from I2C_BUFFSTAT - In case of a NACK|ARDY|AL interrupts return from the ISR - OMAP3430 silicon errata 1.153 hi, in future it would be better to

Re: [RESUBMIT][PATCH-v2][RFC] OMAP4: I2C Support for OMAP4430

2009-07-29 Thread Ben Dooks
On Fri, Jul 24, 2009 at 04:40:02PM +0530, Syed Rafiuddin wrote: Hi Ben, This patch adds OMAP4 support to the I2C driver. All I2C register addresses are different between OMAP1/2/3 and OMAP4. In order to not have #ifdef's at various places in code, as well as to support multi-OMAP

Re: [PATCH 1/3] [OMAP:I2C]Bug in reading the RXSTAT/TXSTAT values from the I2C_BUFFSTAT register

2009-07-29 Thread Ben Dooks
On Tue, Jul 21, 2009 at 10:14:06AM -0500, Sonasath, Moiz wrote: Fix bug in reading the I2C_BUFFSTAT register for getting byte count on RX/TX interrupt. On Interrupt: I2C_STAT[RDR], read 'RXSTAT' from I2C_BUFFSTAT[8-13] On Interrupt: I2C_STAT[XDR] read 'TXSTAT' from

Re: [PATCH 0/44] includecheck: fix multiple includes

2009-07-09 Thread Ben Dooks
-by: Russell King rmk+ker...@arm.linux.org.uk The remainder look sane to me, but you'll have to seek acks from the individual platform maintainer(s). Ack for plat-s3c64xx/pm.c: Acked-by: Ben Dooks ben-li...@fluff.org -- Ben Dooks, Software Engineer, Simtec Electronics http://www.simtec.co.uk

Re: RFC: Reclaim address space on omaps, Tony on vacation in July

2009-06-26 Thread Ben Dooks
On Fri, Jun 26, 2009 at 09:25:40AM +0300, Tony Lindgren wrote: Hi all, Last week I posted some more omap io.h clean-up patches to the linux-omap list [1], and started looking at what it would take to reclaim lost address space on top of the io.h clean-up patches. Looks like we should be

Re: [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED

2009-03-09 Thread Ben Dooks
On Fri, Mar 06, 2009 at 03:34:54PM +0200, Ari Kauppi wrote: I have observed some Spurious IRQ's for I2C1 when all kernel hacking options (and thus LOCKDEP) are disabled. Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help but IRQF_DISABLED is needed for proper

Re: [PATCH] I2C: OMAP: Add missing wakeup events

2009-02-02 Thread Ben Dooks
...@vger.kernel.org] On Behalf Of Pakaravoor, Jagadeesh Sent: Friday, January 23, 2009 2:19 PM To: linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org; Ben Dooks Subject: [PATCH] I2C: OMAP: Add missing wakeup events From: Jagadeesh Bhaskar Pakaravoor j-pakarav...@ti.com Include wake up events

Re: [PATCH 10/12] i2c-omap: convert 'rev1' flag to generic 'rev' u8

2008-12-16 Thread Ben Dooks
On Fri, Nov 28, 2008 at 05:34:57PM -0800, Tony Lindgren wrote: From: Paul Walmsley p...@pwsan.com i2c-omap discriminates only between revision 1 or greater than revision 1. A following patch introduces code that must also discriminate between rev2.x, rev3.6, and rev3.12 controllers.

Re: [PATCH 10/12] i2c-omap: convert 'rev1' flag to generic 'rev' u8

2008-12-16 Thread Ben Dooks
On Tue, Dec 16, 2008 at 09:59:59PM +, Ben Dooks wrote: On Fri, Nov 28, 2008 at 05:34:57PM -0800, Tony Lindgren wrote: From: Paul Walmsley p...@pwsan.com i2c-omap discriminates only between revision 1 or greater than revision 1. A following patch introduces code that must also

Re: [PATCH] i2c: omap: highspeed only over 1000mhz

2008-10-17 Thread Ben Dooks
On Sat, Oct 18, 2008 at 12:09:55AM +0300, Felipe Balbi wrote: up to 1000mhz it's Fast Mode+, not highspeed. mill-hz? 1MHz or 1000kHz. Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/i2c/busses/i2c-omap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [i2c] [PATCH 1/8] i2c-omap: Do not use interruptible wait call in omap_i2c_xfer_msg

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:47AM +0300, Tony Lindgren wrote: From: Jarkko Nikula [EMAIL PROTECTED] If there is a signal pending and wait_for_completion_interruptible_timeout terminates with -ERESTARTSYS, we return and disable the i2c clocks in omap_i2c_xfer. If we terminate before

Re: [i2c] [PATCH 2/8] i2c-omap: Close suspected race between omap_i2c_idle() and omap_i2c_isr()

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:48AM +0300, Tony Lindgren wrote: From: Paul Walmsley [EMAIL PROTECTED] omap_i2c_idle() sets an internal flag, dev-idle, instructing its ISR to decline interrupts. It sets this flag before it actually masks the interrupts on the I2C controller. This is

Re: [i2c] [PATCH 3/8] i2c-omap: Add high-speed support to omap-i2c

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:49AM +0300, Tony Lindgren wrote: From: Syed Mohammed Khasim [EMAIL PROTECTED] Omap2430 has additional support for high-speed I2C. This patch moves I2C speed parameter (from module) to platform data. Also added basic High Speed support based on I2C bus speed.

Re: [i2c] [PATCH 4/8] i2c-omap: FIFO handling support and broken hw workaround for i2c-omap

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:50AM +0300, Tony Lindgren wrote: From: Nishanth Menon [EMAIL PROTECTED] Based on an earlier patch from Nishant Menon: - Transfers can use FIFO on FIFO capable devices - Prevents errors for HSI2C if FIFO is not used - Implemented errenous handling of STT-STP

Re: [i2c] [PATCH 5/8] i2c-omap: Add support on 34xx

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:51AM +0300, Tony Lindgren wrote: From: Chandra shekhar [EMAIL PROTECTED] Not very informative description in here. At lease you could have copied the subject? Signed-off-by: chandra shekhar [EMAIL PROTECTED] Signed-off-by: Tony Lindgren [EMAIL PROTECTED] ---

Re: [i2c] [PATCH 7/8] i2c-omap: Don't compile in OMAP15xx I2C ISR for non-OMAP15xx builds

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:53AM +0300, Tony Lindgren wrote: From: Paul Walmsley [EMAIL PROTECTED] Skip compiling OMAP15xx I2C ISR for non-OMAP15xx builds. Saves 400 bytes of text for most OMAP builds. you've sneaked in __devinit/__devexit changes into this patch, I'm going to put my foot

Re: [i2c] [PATCH 8/8] i2c-omap: Clean-up i2c-omap

2008-09-29 Thread Ben Dooks
On Thu, Sep 25, 2008 at 10:53:54AM +0300, Tony Lindgren wrote: Minor checkpatch and formatting clean-up. Also update copyrights. looks ok, assuming it doesn't get broken by any changes from the review comments i've made earlier in the series. Signed-off-by: Tony Lindgren [EMAIL PROTECTED]

Re: [PATCH] ARM MMU: add strongly-ordered memory type

2008-08-05 Thread Ben Dooks
On Mon, Aug 04, 2008 at 05:40:57PM -0600, Paul Walmsley wrote: Add the MT_MEMORY_STRONGLY_ORDERED memory type for ARM strongly ordered memory. This is used on OMAP3 for on-board SRAM. On OMAP, SRAM is used for code that changes the SDRAM controller's clock, temporarily blocking access to

Re: [i2c] N800 problems with MMC, LM8323 on current linux-omap git head

2008-07-22 Thread Ben Dooks
On Tue, Jul 22, 2008 at 04:37:42PM +0300, Riku Voipio wrote: On Tue, Jul 22, 2008 at 07:52:44AM -0500, Felipe Balbi wrote: On Tue, 22 Jul 2008 15:47:43 +0300, Riku Voipio [EMAIL PROTECTED] wrote: Hmm. I think it would be better to avoid calling the probe in first place. git diff made