Hi
On Wed, Jul 25, 2012 at 05:37:22PM +0530, Ajay Kumar Gupta wrote:
diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
index 01203eb..eb6220f 100644
--- a/drivers/usb/musb/am35x.c
+++ b/drivers/usb/musb/am35x.c
@@ -364,7 +364,7 @@ static int am35x_musb_init(struct musb
Hi,
On Wed, Jul 25, 2012 at 05:37:21PM +0530, Ajay Kumar Gupta wrote:
AM335x and TI81xx platform has dual musb controller so updating the
musb_dspc.c to support the same.
Changes:
- Moved otg_workaround timer to glue structure
- Moved static local variable last_timer to glue
Hi,
On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote:
@@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb *musb)
struct dentry *root;
struct dentry *file;
int ret;
+ charname[10];
Hi,
On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote:
@@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb)
data-set_phy_power(0);
usb_put_phy(musb-xceiv);
- usb_nop_xceiv_unregister
Hi,
On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote:
@@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb
*musb)
struct dentry *root;
struct dentry *file;
int ret;
+ char
Hi,
On Thu, Jul 26, 2012 at 08:29:06AM +, Gupta, Ajay Kumar wrote:
Hi,
On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote:
@@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb)
data-set_phy_power(0);
usb_put_phy(musb
Hi,
On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote:
@@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb
*musb)
struct dentry *root;
struct dentry *file;
int ret;
+ char
Hi
On Thu, Jul 26, 2012 at 12:46:43PM +, Gupta, Ajay Kumar wrote:
Hi,
On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote:
@@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct
musb
*musb)
struct dentry *root;
struct
Hi,
On Thu, Jul 19, 2012 at 05:15:57PM +0530, Ajay Kumar Gupta wrote:
diff --git a/drivers/usb/musb/musb_core.c
b/drivers/usb/musb/musb_core.c index 89d1871..3e09984 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -99,6 +99,7 @@
#include
Hi,
On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote:
Moved global variable musb_debugfs_root and static variable
old_state to 'struct musb' to help support multi instance of musb
controller as present on AM335x platform.
Also removed the global variable orig_dma_mask
Hi,
On Wed, Jul 25, 2012 at 10:34:49AM +, Gupta, Ajay Kumar wrote:
Hi,
On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote:
Moved global variable musb_debugfs_root and static variable
old_state to 'struct musb' to help support multi instance of
musb controller
Hi,
On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote:
diff --git a/drivers/usb/musb/musb_core.c
b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
snip
@@ -1889,6 +1921,7 @@
Hi,
On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote:
Hi,
On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote:
diff --git a/drivers/usb/musb/musb_core.c
b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644
--- a/drivers/usb/musb
Hi,
On Wed, Jul 25, 2012 at 12:30:12PM +, Gupta, Ajay Kumar wrote:
Hi,
On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote:
Hi,
On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote:
diff --git a/drivers/usb/musb/musb_core.c
b/drivers
Hi,
Added device tree support for nop transceiver driver and updated the
Documentation with device tree binding information for am33xx platform.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
.../devicetree/bindings/usb/am33xx-usb.txt |3 +++
Hi,
Currently we have one single nop transceiver support as same is
defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c.
This need to be changed to support multiple otg controller each
using nop transceiver on a platform such as am335x.
Signed-off-by: Ajay Kumar Gupta
Hi,
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
Documentation/devicetree/bindings/usb/omap-usb.txt | 34 -
drivers/usb/musb/omap2430.c| 55
2 files changed, 88 insertions(+), 1 deletions(-)
diff --git
Hi,
On 17-07-2012 13:13, Ajay Kumar Gupta wrote:
Added device tree support for nop transceiver driver and updated the
Documentation with device tree binding information for am33xx
platform.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Hi,
AM33xx has two musb controller and they have one NOP PHY each.
Added the device tree data for NOP PHY.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
arch/arm/boot/dts/am33xx.dtsi |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git
Hi,
On 17-07-2012 13:13, Ajay Kumar Gupta wrote:
Added device tree data for usbss on am33xx. There are two musb
controllers
on am33xx platform so have port0_mode and port1_mode additional data.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
arch/arm/boot/dts/am33xx.dtsi |
Hi
On 17-07-2012 13:13, Ajay Kumar Gupta wrote:
Added device tree data for usbss on am33xx. There are two musb
controllers
on am33xx platform so have port0_mode and port1_mode additional
data.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Hi,
On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri
x0132...@ti.com
[...]
Avoid getting resource by name.. With dt, you wont be able to do
those..
When we are completely on DT then this would anyways go and we
can
get these resource data for each usb port from DT APIs.
Hi,
On Wed, Jul 11, 2012 at 3:59 PM, Damodar Santhapuri x0132...@ti.com
wrote:
From: Ajay Kumar Gupta ajay.gu...@ti.com
AM335x uses NOP transceiver driver and need to enable builtin PHY
by writing into usb_ctrl register available in system control
module register space. This is being
Hi,
On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri x0132...@ti.com
wrote:
From: Ajay Kumar Gupta ajay.gu...@ti.com
AM335x uses NOP transceiver driver and need to enable builtin PHY
by writing into usb_ctrl register available in system control
module register space. This is being
Hi,
On Tue, Jul 10, 2012 at 11:35 AM, Gupta, Ajay Kumar ajay.gu...@ti.com
wrote:
Hi,
On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri x0132...@ti.com
wrote:
From: Ajay Kumar Gupta ajay.gu...@ti.com
AM335x uses NOP transceiver driver and need to enable builtin PHY
by writing
Hi,
Documentation/devicetree/bindings/usb/omap-usb.txt | 34
-
drivers/usb/musb/omap2430.c| 52
[...]
+ of_property_read_u32(np, mode, (u32 *)pdata-mode);
+ of_property_read_u32(np, interface_type,
+
Hi,
On Thu, Jun 28, 2012 at 10:28 AM, Eduardo Valentin
eduardo.valen...@ti.com wrote:
Hello,
On Wed, Jun 27, 2012 at 10:05:00PM +0400, Konstantin Baydarov wrote:
Created a new platform driver for the platform device created by the
control module mfd core, wrt usb. This driver has API's
Hi Tony,
* Ajay Kumar Gupta ajay.gu...@ti.com [120207 23:10]:
Switch on the phy for am335x.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
arch/arm/mach-omap2/omap_phy_internal.c | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
diff --git
Hi,
On Mon, Feb 13, 2012 at 04:26:19AM +, Gupta, Ajay Kumar wrote:
Hi,
* Ajay Kumar Gupta ajay.gu...@ti.com [120207 19:55]:
Switch on the phy for am335x.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
arch/arm/mach-omap2/omap_phy_internal.c | 21
Hi,
* Ajay Kumar Gupta ajay.gu...@ti.com [120207 19:55]:
Switch on the phy for am335x.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
arch/arm/mach-omap2/omap_phy_internal.c | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
diff --git
Hi,
On Wed, Feb 08, 2012 at 11:46:00AM +0530, Shubhrajyoti wrote:
On Wednesday 08 February 2012 09:56 AM, Ajay Kumar Gupta wrote:
+static int dsps_musb_init(struct musb *musb) {
+ struct device *dev = musb-controller;
+ struct musb_hdrc_platform_data *plat =
Hi,
On Wed, Feb 08, 2012 at 11:46:00AM +0530, Shubhrajyoti wrote:
On Wednesday 08 February 2012 09:56 AM, Ajay Kumar Gupta wrote:
+static int dsps_musb_init(struct musb *musb) {
+ struct device *dev = musb-controller;
+ struct musb_hdrc_platform_data *plat = dev-platform_data;
+
Hi,
On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote:
To: linux-omap@vger.kernel.org
Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com;
B, Ravi; Cousson, Benoit; Gupta, Ajay
Hi,
On Tue, Oct 11, 2011 at 02:13:07PM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar
wrote:
To: linux-omap@vger.kernel.org
Cc: linux
Hi,
On Tue, Oct 11, 2011 at 02:13:07PM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Mon, Oct 10, 2011 at 10:40:55AM +0530, Gupta, Ajay Kumar
wrote:
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar
wrote:
To: linux-omap@vger.kernel.org
Cc
Hi Igor,
On 10/11/11 13:26, Ajay Kumar Gupta wrote:
From: Ravi Babu ravib...@ti.com
Adding musb support in ti814 EVM board file.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
Signed-off-by: Ravi Babu ravib...@ti.com
Acked-by: Felipe Balbi ba...@ti.com
---
Hi,
On 10/11/11 13:26, Ajay Kumar Gupta wrote:
From: Ravi Babu ravib...@ti.com
Adding musb support in ti816 EVM board file.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
Signed-off-by: Ravi Babu ravib...@ti.com
Acked-by: Felipe Balbi ba...@ti.com
This patch can result in a
Hi,
Adding musb support in ti816 EVM board file.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
Signed-off-by: Ravi Babu ravib...@ti.com
Acked-by: Felipe Balbi ba...@ti.com
This patch can result in a merge conflict, therefore I think
this one should be taken through Tony's
Hi,
On Mon, Sep 26, 2011 at 02:47:11PM +0400, Sergei Shtylyov wrote:
Hello.
On 26-09-2011 14:03, Ajay Kumar Gupta wrote:
Enabled the flag so that musb_dsps glue file can be used for am335x
Signed-off-by: Ajay Kumar Guptaajay.gu...@ti.com
---
drivers/usb/musb/Kconfig |6
Hi,
On Mon, Sep 26, 2011 at 03:21:07PM +0530, Gupta, Ajay Kumar wrote:
To: linux-omap@vger.kernel.org
Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B,
Ravi; Cousson, Benoit; Gupta, Ajay Kumar
Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Felipe
Hi,
To: linux-omap@vger.kernel.org
Cc: linux-...@vger.kernel.org; Balbi, Felipe; t...@atomide.com; B, Ravi;
Cousson, Benoit; Gupta, Ajay Kumar
Subject: [PATCH 1/6 v3] omap: musb: Adding hwmod data for ti81xx
Felipe,
I am planning to send patch 1/6 along with next revision of ti81xx
hwmod
Hi,
On 07-09-2011 21:02, Ajay Kumar Gupta wrote:
Adding ti81xx_musb_phy_power() which will be used by musb driver
through
its function pointer in board_data.
Signed-off-by: Ajay Kumar Guptaajay.gu...@ti.com
Signed-off-by: Ravi Baburavib...@ti.com
---
Hi,
ajay.gu...@ti.com wrote:
[...]
--
1.6.2.4
looks good to me.
how about you reply with your Acked-by then ?
--
balbi
yes balbi,
here it is
Acked-By: Keshava Munegowda keshava_mgo...@ti.com
Tony and Benoit,
Please review this patch and provide your input on
Hi,
+static int __devinit dsps_probe(struct platform_device *pdev) {
+ const struct platform_device_id *id =
platform_get_device_id(pdev);
+ const struct dsps_musb_wrapper *wrp =
+ (struct dsps_musb_wrapper *)id-driver_data;
+ struct dsps_glue *glue;
+
Hi,
diff --git a/drivers/usb/musb/musb_core.c
b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1014,7 +1014,9 @@ static void musb_shutdown(struct
platform_device *pdev)
||
Hi,
If you compare am35x and da8x then you would find that they are
mostly
same and so should be merged. They both have one musb instances.
Ti81xx has two musb interface and huge differences in register map as
listed Above so ti81xx should be in a separate file.
Apart from this,
Hi,
we really need to find a better way to handle this :-(
How about passing the mode info from musb_config (musb-config-
fifo_mode),
same way as musb-config-fifo_cfg
not sure... Ideally we wouldn't really need those fifo tables,
Yes, if all the board files provide their own
Hi,
On Fri, Aug 26, 2011 at 04:41:48PM +0530, Ajay Kumar Gupta wrote:
@@ -57,6 +58,10 @@ config USB_MUSB_AM35X
tristate AM35x
depends on ARCH_OMAP
+config USB_MUSB_TI81XX
+ bool TI81XX
+ depends on SOC_OMAPTI81XX
this *must* be tristate. I can't emphasize enough how
Hi,
On 26-08-2011 15:11, Ajay Kumar Gupta wrote:
From: Ravi B ravib...@ti.com
Adding musb support in ti816 EVM board file.
Signed-off-by: Ajay Kumar Guptaajay.gu...@ti.com
Signed-off-by: Ravi Bravib...@ti.com
As far as I know, full name is required in signoff.
Ok.
---
Hi,
Set the VAUX2 regulator supply to 1.8V for the HSUSB host interface.
Gpio 2 of the TPS65950 has to be set to zero in order to enable the
HSUBS2 clock.
TPS65950 GPIO2 is not to enable HSUSB2 clock but to enable chip u131
On omap3evm (rev-G) which latches USB, camera and audio lines.
Hi,
TPS65950 GPIO2 is to choose through u131 if we drive the lines to the
evm mother board or to the expansion connector p18. Should not it be
default to the mother board?
It's not enabled by default and that’s why we need to enable it through
Tps65950 GPIO2.
Your patch looks fine but the
Hi,
For the comment what about:
Set the VAUX2 regulator supply to 1.8V for the HSUSB host interface.
Tps65950 GPIO2 has to be set to zero in order to enable the EHCI select
line.
Looks fine.
I see this patch as a fix for the EHCI support, what would you suggest
for the patch name?
This
Hi,
[...]
arch/arm/mach-omap2/board-omap3evm.c | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
omap2/board-omap3evm.c
index c452b3f..13a2b71 100644
---
Hi,
Add support for Texas Instuments Communication Port Programming
Interface 4.1
(CPPI 4.1) used on OMAP-L1x/DA8xx and AM35x.
At this moment, only the DMA controller and queue manager are supported.
Support for the buffer manager is lacking but these chips don't have it
anyway.
Hi,
Add support for Texas Instuments Communication Port Programming
Interface 4.1
(CPPI 4.1) used on OMAP-L1x/DA8xx and AM35x.
At this moment, only the DMA controller and queue manager are
supported.
Support for the buffer manager is lacking but these chips don't have
it anyway.
Hi,
Is AM35x that different ? Can't you just write to MUSB_INTRRX
MUSB_INTRTX and MUSB_INTRUSB ??
Writing to MUSB_INTRRX/TX/USB wouldn't help. We have to clear interrupt
Bit in control register INTR_LVL_CLR.
I see, thanks for the info :-)
Felipe,
I have recreated this patch (attached)
On Fri, Dec 03, 2010 at 07:08:53PM +0530, Gupta, Ajay Kumar wrote:
We already have generic APIs so I think we can pass function pointers
to
musb driver via struct omap_musb_board_data,
struct omap_musb_board_data {
+ void(*phy_on) (void)
+ void(*phy_off) (void)
+ void
Hi,
As the control.h have been moved to new location and it's
uses are not allowed to drivers directly so moving the phy
control, interrupt clear and reset functionality to board
files.
I'm not fond of the whole approach. I'm not sure why accesses to the
control registers are such
As the control.h have been moved to new location and it's
uses are not allowed to drivers directly so moving the phy
control, interrupt clear and reset functionality to board
files.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Patch created against today's linus tree.
I
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-
musb.c
index 7260558..1f32fdb 100644
--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -33,6 +33,82 @@
#ifdef CONFIG_USB_MUSB_SOC
+static void am35x_musb_phy_power(u8 on)
+{
+
We already have generic APIs so I think we can pass function pointers to
musb driver via struct omap_musb_board_data,
struct omap_musb_board_data {
+void(*phy_on) (void)
+void(*phy_off) (void)
+void (*intr_clr) (void)
}
Reset part can be done in board file itself
why don't you add a proper otg_transceiver driver for am35x ?
Is it like omap4's internal phy ? A separate block ?
AM35x PHY is built inside the ip and we need to configure it through
PHY control register.
Additionally we also need to access IPSS reset and Intr clear register
as well
Tony ? Do you ack the usage of that header ?
NAK. Drivers should not mess with the control registers directly.
Instead, the following should be done in the platform init code:
$ grep -r omap_ctrl_read drivers/usb
drivers/usb/musb/am35x.c: devconf2 =
We would need control register apis for accessing USB PHY control
, IPSS reset and interrupt clear register. This would require to
add three different function pointer and that would mostly be
custom to AM35x. Will that be acceptable from musb perspective ?
why don't you add a proper
Hi,
On Thu, Sep 30, 2010 at 12:19:07AM -0500, Gupta, Ajay Kumar wrote:
AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine.
It has USB phy built inside the IP itself.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
besides the one small question below:
Acked-by: Felipe
Hi,
On Thu, Sep 30, 2010 at 12:19:08AM -0500, Gupta, Ajay Kumar wrote:
AM35x has musb interface and uses CPPI4.1 DMA engine.
Current patch supports only PIO mode. DMA support can be
added later once basic CPPI4.1 DMA patch is accepted.
Also added USB_MUSB_AM35X which is required
Hi,
[...]
I couldn't fetch your gitorious tree so I just applied 14 patch set
Manually on my branch.
Anyways I will look into it and send the refreshed patch shortly.
gitorious must be trying to make me look bad :-p
Works like a charm here. Will try on a different laptop
fine on
Hi,
+config USB_MUSB_AM35X
+ boolean AM35X MUSB support
+ depends on USB_MUSB_HDRC MACH_OMAP3517EVM
As I've already said, depending on the board type won't scale... :-(
..and to scale it up we need to add select USB_MUSB_AM35X in
arch/arm/mach-omap2/Kconfig for all the boards
Hi,
On Thu, Jun 24, 2010 at 01:17:54PM +0200, ext Gupta, Ajay Kumar wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Signed
Hi,
If a Kconfig option is needed for optionally compiling in the
support
for am35x musb, it should be called USB_MUSB_AM35X or similar that
gets selected if the boards using it are selected.
Do you mean that we should have this option in
drivers/usb/musb/Kconfig?
Yeah, it
Hi,
+{
+ unsigned long timeout = jiffies + msecs_to_jiffies(100);
+ u32 devconf2;
+
+ /*
+ * Start the on-chip PHY and its PLL.
+ */
+ devconf2 = omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2);
+
+ devconf2 = ~(CONF2_RESET | CONF2_PHYPWRDN | CONF2_OTGPWRDN |
+
I think Ajay has explained why it's needed. The option is
necessary in one or another form.
It's not needed for omaps, we can already build in support for
omap2, omap3 and omap4 into the same kernel binary.
Not with AM35x USB support merged -- at least you won't be able
to
+#define USB_SOFT_RESET_MASK1
Need a empty line here.
Hmm, ok.
+#define A_WAIT_BCON_TIMEOUT1100/* in ms */
I think this #define should be dropped -- see below...
+{
+ unsigned long timeout = jiffies + msecs_to_jiffies(100);
+ u32
+#ifdef CONFIG_USB_MUSB_HDRC_HCD
+void __iomem*mbase = musb-mregs;
+#endif
then you add another ifdef to this file, which is already insane. I'd
rather see you either keep the local variables and just fix what needs
to be fixed,
or use musb-mregs directly.
This one seems to be a
then you add another ifdef to this file, which is already insane. I'd
rather see you either keep the local variables and just fix what needs
to be fixed,
or use musb-mregs directly.
This one seems to be a much better one. Copying the v-3 with this fix
below.
I don't see how
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Also removed definition of 'mbase' from multiple places to only
at function top.
AFAIR, it was intentionally removed from the function top and
declared
in the multiple plcase instead by the former Felipe's patch [1] to fix
exactly the same issue, if I don't mistake. So, it hasn't worked out?
Yes, it was removed by Felipe's below patch but it introduced
These are reviewed and non-controversial musb bugfix patches. Sanity
have
been tested on OMAP3EVM for Host-MSC, HID, audio, video class and
device-CDC class.
Sorry, I need Felipe to send these to me, or at the very least, give me
an ack for them, before I will apply them.
Felipe, Can
Hi,
[..]
+* We have to override VBUS/ID signals when MUSB is configured into
the
+* host-only mode -- ID pin will float if no cable is connected, so
the
+* controller won't be able to drive VBUS thinking that it's a B-
device.
+* Otherwise, we want to use the OTG mode
AM35x has musb interface (version 1.8) and uses CPPI41
DMA engine.
It has USB phy built inside the IP itself.
So it's more like DaVinci (earlier CPPI as well as
integrated PHY) than OMAP3...
Yes. Actually they removed original musb controller from OMAP3
and replaced it with DaVinci
Hi,
On Mon, May 24, 2010 at 09:07:37AM +0200, ext Gupta, Ajay Kumar wrote:
Attempting to remove usb_nop_xceiv_register() completely will require
someone
with more knowledge of davinci and blackfin archs to comment on what
boards
need the platform_device defined.
NAK
ps: you really think that adding more and more ifdefs is better than
Amit's patch ??
We can avoid using #ifdefs by introducing '.neednop' flag to board_data.
Here is the patch for this which can be used on top of my earlier patch.
--- cut here ---
diff --git
Hi,
Here is a compile-tested patch since I haven't seen this fixed in mainline
yet. It applies to the tip of Linus' tree.
Attempting to remove usb_nop_xceiv_register() completely will require
someone
with more knowledge of davinci and blackfin archs to comment on what
boards
need the
Hi,
It would not scale very well - we already have multi-omap builds
that select support for multiple boards. If the AM35x boards are
part of such builds, then mutually exclusive config options won't
work - already n8x0 MUSB is exclusive with 243x/omap3.
If it is possible to detect the
Hi,
On Fri, May 21, 2010 at 07:15:37AM +0200, ext Gupta, Ajay Kumar wrote:
Hi,
+#ifdef CONFIG_USB_MUSB_OTG
+ .mode
= MUSB_OTG,
+#elif defined(CONFIG_USB_MUSB_HDRC_HCD)
+ .mode
= MUSB_HOST,
+#elif defined(CONFIG_USB_GADGET_MUSB_HDRC)
.mode
Hi,
We are designing a custom OMAP board that
will have a 500mA supply on
the OTG port. It looks like the power
is set with:
struct omap_musb_board_data {
u8
interface_type;
u8
mode;
u8
power;
};
However, with a u8,
Hi,
AM35x supports only 32bit read operations so we need to have
workaround for 8bit and 16bit read operations.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Patch created against linus'tree + all musb patches in Greg's queue
Changes from v1:
- removed unnecessary parens.
Hi,
Gupta, Ajay Kumar wrote:
AM35x supports only 32bit read operations so we need to have
workaround for 8bit and 16bit read operations.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
[...]
+#if !defined(CONFIG_MACH_OMAP3517EVM)
Fixes/workaround based
Hi,
Fixes/workaround based on CONFIG_MACH_OMAP3517EVM will be good only for
OMAP3517EVM and would not scale well to other boards based on AM35x.
(As commented earlier by Sergei)
I just got to know of another board LIZARD based on AM35x so we really
need to find a solution for this.
Hi,
Subject: [PATCH] ARM: OMAP: Fix board data to support device only, host only
and OTG roles.
Fix board data to support device only, host only and OTG roles.
The board data hardcodes the mode to OTG or Peripheral.
This fix will allow to use Peripheral, Host and OTG
roles independently.
Hi,
Ajay Kumar Gupta wrote:
AM35x supports only 32bit read operations so we need to have
workaround for 8bit and 16bit read operations.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Patch created against linus'tree + all musb patches in Greg's queue
Changes from v2:
Hi,
Ajay Kumar Gupta wrote:
Use optimal values of transfer element based on buffer address in system
DMA programming. This would improve the performance.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
drivers/usb/musb/musbhsdma.c | 29 ++---
1
Hi,
Ajay Kumar Gupta wrote:
AM35x supports only 32bit read operations so we need to have
workaround for 8bit and 16bit read operations.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Patch created against linus'tree + all musb patches in Greg's queue
Changes from v2:
Hi
AM35x supports only 32bit read operations so we need to have
workaround for 8bit and 16bit read operations.
But don't we need to override musb_readb() and musb_readw() then?
Yes, Correct. I do have another patch on that which I will cleanup and submit
later.
Anyways with currebt three
Hi,
-Original Message-
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
ow...@vger.kernel.org] On Behalf Of Gupta, Ajay Kumar
Sent: Thursday, May 13, 2010 5:15 PM
To: Kevin Hilman
Cc: linux-omap@vger.kernel.org
Subject: RE: [PATCH] OMAP3: PM: fix AM35x musb issue
Hi,
-Original Message-
From: Felipe Balbi [mailto:felipe.ba...@nokia.com]
Sent: Friday, May 14, 2010 4:37 PM
To: Gupta, Ajay Kumar
Cc: m...@felipebalbi.com; linux-...@vger.kernel.org; linux-
o...@vger.kernel.org
Subject: Re: [PATCH 4/5] musb: use system DMA for unaligned buffers
Hi,
Ajay Kumar Gupta ajay.gu...@ti.com wrote:
AM35x is based on OMAP35x but has an updated musb interface which
uses CPPI4.1 DMA engine.
Current patch supports only PIO mode transfers.
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
---
Changes from v1: (Based on Sergei's
Hi,
Another approach to use PIO mode in opposite direction would
increase
the
cpu loading and thus using system DMA is preferred workaround.
Signed-off-by: Anand Gadiyar gadi...@ti.com
Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com
I think falling back to pio is
Hi,
On Thu, May 13, 2010 at 09:44:11AM +0530, Gupta, Ajay Kumar wrote:
Hi,
-Original Message-
From: Felipe Balbi [mailto:m...@felipebalbi.com]
Sent: Wednesday, May 12, 2010 11:26 PM
To: Sergei Shtylyov
Cc: Gupta, Ajay Kumar; linux-...@vger.kernel.org; linux-
o
Hi,
On Wed, May 12, 2010 at 05:19:38PM +0530, Ajay Kumar Gupta wrote:
MUSB RTL version 1.8 onward (OMAP3630, AM/DM37x, OMAP4) DMA requires
the buffers to be aligned on a four byte boundary. This affects USB
CDC/RNDIS class application where buffers are always unaligned.
Use system DMA
1 - 100 of 208 matches
Mail list logo
