Re: [PATCH V3 2/3] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-28 Thread Mahapatra, Chandrabhanu
On Fri, Sep 28, 2012 at 4:52 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: The printk in DSSDBG function definition is replaced with dynamic debug enabled pr_debug(). The use of dynamic debugging provides more flexibility as

Re: [PATCH V3 0/3] OMAPDSS: Enable dynamic debug printing

2012-09-28 Thread Mahapatra, Chandrabhanu
On Fri, Sep 28, 2012 at 5:04 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-09-28 at 15:53 +0530, Chandrabhanu Mahapatra wrote: Hi everyone, this patch series aims at cleaning up of DSS of printk()'s enabled with dss_debug and replace them with generic dynamic debug printing.

Re: [PATCH V2 0/2] OMAPDSS: Enable dynamic debug printing

2012-09-27 Thread Mahapatra, Chandrabhanu
On Wed, Sep 26, 2012 at 7:59 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: This doesn't work quite correctly. The problem is in dss.h, where we define DEBUG if CONFIG_OMAP2_DSS_DEBUG_SUPPORT is set. The thing is, DEBUG should be defined before including the kernel headers where the pr_debug

Re: [PATCH] OMAPDSS: Cleanup DSSDBG with dynamic pr_debug function

2012-09-25 Thread Mahapatra, Chandrabhanu
diff --git a/drivers/video/omap2/dss/apply.c b/drivers/video/omap2/dss/apply.c index 6354bb8..cb86d94 100644 --- a/drivers/video/omap2/dss/apply.c +++ b/drivers/video/omap2/dss/apply.c @@ -559,7 +559,7 @@ static void dss_ovl_write_regs(struct omap_overlay *ovl) struct mgr_priv_data

Re: [PATCH V5 3/6] OMAPDSS: DSS: Cleanup cpu_is_xxxx checks

2012-08-21 Thread Mahapatra, Chandrabhanu
On Tue, Aug 21, 2012 at 4:05 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 18:53 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dss_init_features function providing a much more generic and cleaner interface. The OMAP version and revision

Re: [PATCH V5 5/6] ARM: OMAP: Disable venc for OMAP4

2012-08-21 Thread Mahapatra, Chandrabhanu
On Tue, Aug 21, 2012 at 4:02 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 18:54 +0530, Chandrabhanu Mahapatra wrote: This is a alternative to HACK: OMAP: DSS2: VENC: disable VENC on OMAP4 to prevent crash (ba02fa37de) by Tomi Valkeinen tomi.valkei...@ti.com to prevent

Re: [PATCH V5 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-21 Thread Mahapatra, Chandrabhanu
On Tue, Aug 21, 2012 at 4:01 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-20 at 18:52 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and

Re: [PATCH V4 3/6] OMAPDSS: DSS: Cleanup cpu_is_xxxx checks

2012-08-20 Thread Mahapatra, Chandrabhanu
On Mon, Aug 20, 2012 at 2:12 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-08-17 at 16:54 +0300, Tomi Valkeinen wrote: On Thu, 2012-08-16 at 16:48 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dss_init_features function providing a much more

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-14 Thread Mahapatra, Chandrabhanu
+static const struct __initdata dispc_features omap2_dispc_features = { + .hp_max = 256, + .vp_max = 255, + .sw_max = 64, + .sw_start = 5, + .fp_start = 15,

Re: [PATCH 3/6] OMAPDSS: DSS: Cleanup cpu_is_xxxx checks

2012-08-14 Thread Mahapatra, Chandrabhanu
On Tue, Aug 14, 2012 at 3:18 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-08-13 at 17:29 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dss_init_features function providing a much more generic and cleaner interface. The OMAP version and revision

Re: [PATCH 3/6] OMAPDSS: DSS: Cleanup cpu_is_xxxx checks

2012-08-09 Thread Mahapatra, Chandrabhanu
On Wed, Aug 8, 2012 at 6:46 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-08 at 17:08 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dss_init_features function providing a much more generic and cleaner interface. The OMAP version and revision

Re: [PATCH 1/6] OMAPDSS: DISPC: cleanup cpu_is_xxxx checks

2012-08-08 Thread Mahapatra, Chandrabhanu
On Wed, Aug 8, 2012 at 6:06 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-08-08 at 17:07 +0530, Chandrabhanu Mahapatra wrote: All the cpu_is checks have been moved to dispc_init_features function providing a much more generic and cleaner interface. The OMAP version and revision

Re: [RFC PATCH 22/29] OMAPDSS: DISPC: Setup writeback go, enable and channel_in functions

2012-08-02 Thread Mahapatra, Chandrabhanu
On Tue, Dec 27, 2011 at 6:07 PM, Archit Taneja arc...@ti.com wrote: Fill up dispc_wb_go(), dispc_wb_go_busy(), dispc_wb_enable() and dispc_wb_get_channel_in()/set_channel_in() with writeback register writes. Make a minor modification in dss_wb_write_regs_extra() to pass the plane_id instead

Re: [PATCH V3 3/3] OMAPDSS: DISPC: Correct DISPC functional clock usage

2012-04-22 Thread Mahapatra, Chandrabhanu
On Fri, Apr 20, 2012 at 7:59 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-04-20 at 19:01 +0530, Chandrabhanu Mahapatra wrote: DISPC_FCLK is incorrectly used as functional clock of DISPC in scaling calculations. So, DISPC_CORE_CLK replaces as functional clock of DISPC.

Re: [PATCH V3 3/3] OMAPDSS: DISPC: Correct DISPC functional clock usage

2012-04-20 Thread Mahapatra, Chandrabhanu
On Thu, Apr 19, 2012 at 6:41 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2012-04-02 at 20:43 +0530, Chandrabhanu Mahapatra wrote: DISPC_FCLK is incorrectly used as functional clock of DISPC in scaling calculations. So, DISPC_CORE_CLK replaces as functional clock of DISPC.

Re: [PATCH V2 2/3] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-27 Thread Mahapatra, Chandrabhanu
On Tue, Mar 27, 2012 at 4:13 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2012-03-21 at 15:21 +0530, Chandrabhanu Mahapatra wrote: In OMAP3 DISPC video overlays suffer from some undocumented horizontal position and timing related limitations leading to SYNCLOST errors.

Re: [PATCH V2 2/3] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-27 Thread Mahapatra, Chandrabhanu
On Tue, Mar 27, 2012 at 4:27 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-03-21 at 15:21 +0530, Chandrabhanu Mahapatra wrote: In OMAP3 DISPC video overlays suffer from some undocumented horizontal position and timing related limitations leading to SYNCLOST errors. Whenever the

Re: [PATCH V2 3/3] OMAPDSS: DISPC: Correct DISPC functional clock usage

2012-03-27 Thread Mahapatra, Chandrabhanu
On Tue, Mar 27, 2012 at 4:33 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-03-21 at 15:22 +0530, Chandrabhanu Mahapatra wrote: DISPC_FCLK is incorrectly used as functional clock of DISPC in scaling calculations. So, DISPC_CORE_CLK replaces as functional clock of DISPC.

Re: [PATCH V2 2/3] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-27 Thread Mahapatra, Chandrabhanu
On Tue, Mar 27, 2012 at 4:40 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-03-27 at 16:31 +0530, Mahapatra, Chandrabhanu wrote: On Tue, Mar 27, 2012 at 4:13 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, On Wed, 2012-03-21 at 15:21 +0530, Chandrabhanu Mahapatra wrote

Re: [PATCH V2 2/3] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-27 Thread Mahapatra, Chandrabhanu
On Tue, Mar 27, 2012 at 4:47 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Tue, 2012-03-27 at 16:37 +0530, Mahapatra, Chandrabhanu wrote: On Tue, Mar 27, 2012 at 4:27 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2012-03-21 at 15:21 +0530, Chandrabhanu Mahapatra wrote

Re: [PATCH 1/2] OMAPDSS: DISPC: Enable predecimation

2012-03-16 Thread Mahapatra, Chandrabhanu
On Fri, Mar 16, 2012 at 3:58 AM, Ville Syrjälä syrj...@sci.fi wrote: On Thu, Mar 15, 2012 at 05:18:28PM +0530, Chandrabhanu Mahapatra wrote: In OMAP3 and OMAP4, the DISPC Scaler can downscale an image up to 4 times, and up to 2 times in OMAP2. However, with predecimation, the image can be

Re: [PATCH 2/2] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-16 Thread Mahapatra, Chandrabhanu
On Fri, Mar 16, 2012 at 4:34 AM, Ville Syrjälä syrj...@sci.fi wrote: On Thu, Mar 15, 2012 at 05:18:52PM +0530, Chandrabhanu Mahapatra wrote: In OMAP3 DISPC video overlays suffer from some undocumented horizontal position and timing related limitations leading to SYNCLOST errors. Whenever the

Re: [PATCH 2/2] OMAPDSS: DISPC: Handle synclost errors in OMAP3

2012-03-16 Thread Mahapatra, Chandrabhanu
2012/3/16 Tomi Valkeinen tomi.valkei...@ti.com: On Fri, 2012-03-16 at 01:04 +0200, Ville Syrjälä wrote: On Thu, Mar 15, 2012 at 05:18:52PM +0530, Chandrabhanu Mahapatra wrote: In OMAP3 DISPC video overlays suffer from some undocumented horizontal position and timing related limitations

Re: [PATCH V2 0/2] OMAPDSS: DISPC: Peformance improvement of DISPC Scaling

2011-12-20 Thread Mahapatra, Chandrabhanu
On Tue, Dec 20, 2011 at 2:06 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Mon, 2011-12-19 at 14:03 +0530, Chandrabhanu Mahapatra wrote: Hi everyone, the following patch set directs to improve the scaling performance of DISPC module which consists of two pacthes. The first patch is

Re: [PATCH 1/2] OMAPDSS: DISPC: Update Fir Coefficients

2011-12-16 Thread Mahapatra, Chandrabhanu
On Fri, Dec 16, 2011 at 1:45 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2011-12-16 at 10:26 +0530, Mahapatra, Chandrabhanu wrote: On Thu, Dec 15, 2011 at 2:25 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2011-12-14 at 10:21 +0530, Chandrabhanu Mahapatra wrote

Re: [PATCH 1/2] OMAPDSS: DISPC: Update Fir Coefficients

2011-12-15 Thread Mahapatra, Chandrabhanu
On Thu, Dec 15, 2011 at 2:25 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Wed, 2011-12-14 at 10:21 +0530, Chandrabhanu Mahapatra wrote: +const struct dispc_coef *dispc_ovl_get_scale_coef(int inc, int five_taps) +{ +     int i; +     static const struct { +             int Mmin; +