the regulator-name properties from db8500.dts. Adding to my TODO.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
-name property is used to populate constrains-name. Are
you sure you still want them all removed?
Kind regards,
Lee
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line
On Tue, Aug 28, 2012 at 10:21:33AM -0700, Mark Brown wrote:
On Tue, Aug 28, 2012 at 12:26:07PM +0100, Lee Jones wrote:
arch/arm/boot/dts/db8500.dtsi
I'm not actually seeing anything terribly problematic here, though the
regulator-name properties should really be removed as they're
is
cleanly solved by the overlay being contained in the V4L device node and
applied just before
the device is probed.
In the meantime it would be better to wait until we have some ack from the
maintainers
of the core subsystems about what they think.
Regards
-- Pantelis
--
Lee Jones
On Tue, 08 Jan 2013, Pantelis Antoniou wrote:
Hi Lee,
On Jan 8, 2013, at 12:00 PM, Lee Jones wrote:
At the end of the line, some kind of hardware glue is going to be
needed.
I just feel that drawing from a sample size of 1 (maybe 2 if I get to
throw
in the beagleboard
On Tue, 08 Jan 2013, Arnd Bergmann wrote:
On Tuesday 08 January 2013, Pantelis Antoniou wrote:
On Jan 8, 2013, at 2:12 PM, Arnd Bergmann wrote:
On Tuesday 08 January 2013, Lee Jones wrote:
If there is not, there is no way to automatically load the overlays;
you can always
use
platforms which include
them. Anything that is only relevant to a sub-set of boards should be
in a higher ranking .dtsi file and finally, any settings which are
board specific should be in the board's .dts file.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM
= 325;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
};
i2c5 {
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
-microvolt = 325;
+ regulator-max-microvolt = 325;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ };
+ };
};
i2c5 {
--
Lee Jones
Linaro ST-Ericsson Landing Team
I believe the whole thing should go via the MFD tree. It touches also
input iio subsystem. I collected ACKs where I got some in the meantime.
I added Lee Jones because I hear no sign of life from Samuel.
Unfortunately I can't be of any added help here, as I also send my
pull-requests though
the 'how
much is significant' to your own good judgement.
If you're just making a few fixups, then just add your SOB in the
normal way. That should be enough reward for a mere few patch fixes.
Adding little 'I-did-this' notes to the commit log should mostly be
avoided IMO.
--
Lee Jones
Linaro ST
are recorded. But to
make some progress I rewrite the commit log to resolve this and don't
add anything to the sign-off area.
If you are submitting the patch, you still have to add your own SOB.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow
register for omap3) and pull strength
configuration (in control_mmc1 for omap4)
Signed-off-by: Balaji T K balaj...@ti.com
You *need* Lee Jones and Mark Brown to review this.
Maybe Laurent has something to add too.
Ux500 had the very same thing, and there this was solved using
a GPIO
On Thu, 13 Jun 2013, Balaji T K wrote:
On Thursday 13 June 2013 04:17 PM, Lee Jones wrote:
On Thu, 13 Jun 2013, Linus Walleij wrote:
On Thu, Jun 6, 2013 at 9:14 PM, Balaji T K balaj...@ti.com wrote:
PBIAS register configuration is based on the regulator voltage
which supplies these pbias
--
1 files changed, 0 insertions(+), 106 deletions(-)
If that's the case, applied with all Acks, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line
with this
as long as Mark and the other maintainers are.
For the MFD parts:
Acked-by: Lee Jones lee.jo...@linaro.org
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send
On Wed, 19 Jun 2013, Lee Jones wrote:
On Mon, 17 Jun 2013, J Keerthy wrote:
Remove code which is not necessary for a device tree boot.
So we're exclusively DT now right?
Boot tested on OMAP5-UEVM board.
Signed-off-by: J Keerthy j-keer...@ti.com
---
drivers/mfd/palmas.c
On Wed, 19 Jun 2013, Samuel Ortiz wrote:
Hi Lee,
On Wed, Jun 19, 2013 at 09:26:33AM +0100, Lee Jones wrote:
On Mon, 17 Jun 2013, J Keerthy wrote:
Remove code which is not necessary for a device tree boot.
So we're exclusively DT now right?
Boot tested on OMAP5-UEVM board
Sam didn't take it?
I'd be happy to, if it wasn't stepping on anyone's toes.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
-controller : palmas has its own internal IRQs
Applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
, 6 insertions(+), 0 deletions(-)
Applied with Stephen and Mark's RB.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
On Thu, 11 Jul 2013, Lee Jones wrote:
On Wed, 19 Jun 2013, Keerthy wrote:
From: J Keerthy j-keer...@ti.com
Check if irq value obtained is valid. If it is not valid
then skip the irq request step and go ahead with the probe.
Signed-off-by: J Keerthy j-keer...@ti.com
twl6030_gpadc_result *res);
+
+#endif
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More
Thank you for the review. There is v3 of this patch. My bad I didn't put
it in reply to v1.
I'll address you comments in v4. Would you care to review v3, please.
I'd rather go straight on to review v4 with my comments addressed, if
it's all the same to you?
--
Lee Jones
Linaro ST-Ericsson
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap5.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3-igep0020.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep0020
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/omap2420-h4.dts
b
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3-igep0030.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep0030
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3430-sdp.dts | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/omap2420-h4.dts
b
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3-igep0020.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep0020
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3430-sdp.dts | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap5.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3-igep0030.dts | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/omap3-igep0030
);
+
If request_threaded_irq() fails, isn't there a chance that
twl6030_irq_base will be allocated, but twl_irq will still be
undefined?
return 0;
}
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
);
+ free_irq(twl_irq, NULL);
}
Ah yes, that's better.
-
- free_irq(twl_irq, NULL);
-
return 0;
}
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send
= TWL6030_NR_IRQS;
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
(dev, could not claim irq %d: %d\n, irq_num, status);
goto fail_irq;
}
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux
be better if you still fixed up this patch to
be correct though. Even if you break it out and add it as [PATCH 1/x].
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line
Tony, Benoit,
Poke
On Mon, 22 Jul 2013, Lee Jones wrote:
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3430-sdp.dts | 22 +++---
1 file changed
Tony, Benoit,
Poke
On Mon, 22 Jul 2013, Lee Jones wrote:
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1
Tony, Benoit,
Poke
On Mon, 22 Jul 2013, Lee Jones wrote:
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3.dtsi | 2 +-
1 file changed, 1 insertion(+), 1
Tony, Benoit,
Poke
On Mon, 22 Jul 2013, Lee Jones wrote:
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3-igep0030.dts | 8
1 file changed, 4
Tony, Benoit,
Poke
On Mon, 22 Jul 2013, Lee Jones wrote:
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap3-igep0020.dts | 8
1 file changed, 4
Tony, Benoit,
Poke
On Mon, 22 Jul 2013, Lee Jones wrote:
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap2420-h4.dts | 6 +++---
1 file changed, 3 insertions
Tony, Benoit,
Poke
Cc: Benoît Cousson b-cous...@ti.com
Cc: Tony Lindgren t...@atomide.com
Cc: linux-omap@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/omap5.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot
: Remove '0x's from OMAP2420 H4 DTS file
Nope, looks good. Thanks Benoit.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body
binding.
Samuel or Lee: Could you take this patch?
This is the first time this patch has been sent to me.
I need Dmitry's input (no pun intended) on how he's like to deal with
this. At a bare minimum I'd like his Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source
On Tue, 05 Nov 2013, Jan Lübbe wrote:
On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote:
This is the first time this patch has been sent to me.
I need Dmitry's input (no pun intended) on how he's like to deal with
this. At a bare minimum I'd like his Ack.
Is there anything I can do
On Tue, 05 Nov 2013, Jan Lübbe wrote:
On Tue, 2013-11-05 at 17:15 +, Lee Jones wrote:
On Tue, 05 Nov 2013, Jan Lübbe wrote:
On Tue, 2013-10-22 at 10:05 +0100, Lee Jones wrote:
This is the first time this patch has been sent to me.
I need Dmitry's input (no pun intended
.
Cc: Samuel Ortiz sa...@linux.intel.com
Cc: Lee Jones lee.jo...@linaro.org
Signed-off-by: Tony Lindgren t...@atomide.com
---
Samuel Lee, I'd like to merge this fix via arm-soc tree if this looks
OK to you as I have other patches that depend on this.
---
drivers/mfd/twl-core.c | 15
victor.kamen...@linaro.org
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
drivers/mfd/omap-usb-tll.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM
victor.kamen...@linaro.org
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
drivers/mfd/omap-usb-host.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software
. The latter issue is less likely to be resolved. :)
Are you Acking this patch by the way?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux
sort it out.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo
On Mon, 18 Nov 2013, Tony Lindgren wrote:
* Lee Jones lee.jo...@linaro.org [131118 11:10]:
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes
branch this week with your acks if that works for you. That way I can base
On Mon, 18 Nov 2013, Tony Lindgren wrote:
* Lee Jones lee.jo...@linaro.org [131118 11:10]:
Are you Acking this patch by the way?
If this looks acceptable to you guys, I'd like to merge this via my fixes
branch this week with your acks if that works for you. That way I can base
Lindgren (1):
mfd: twl-core: Fix passing of platform data in the device tree case
drivers/mfd/twl-core.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
))
- return PTR_ERR(child);
-
- }
-
if (IS_ENABLED(CONFIG_CHARGER_TWL4030) pdata-bci
!(features (TPS_SUBSET | TWL5031))) {
child = add_child(TWL_MODULE_MAIN_CHARGE, twl4030_bci,
--
Lee Jones
Linaro STMicroelectronics Landing
Awesome, should I add your tested-by ? I also added a few extra patches
on top which I'll send soon.
When you next submit, can you capitalise the first character of the
subject line after the final ':' also please, it will save me the
trouble.
--
Lee Jones
Linaro STMicroelectronics Landing
platform, so
I would like a second opinion on this.
Tony would you be kind enough to oblige?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe
is no longer being used. It might be worth checking if
we do have bindings in place for all of that, or if some of it may
still be needed to be passed as auxdata while we wait for the bindings.
Ruslan, do you know the answer to these concerns?
--
Lee Jones
Linaro STMicroelectronics Landing Team
with yours and Tony's responses.
Patch applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message
a different structure to of_tps65218_match_table, please
ensure they're the same. I prefer spaces after '{' and before '}'.
snip
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from
in bindings/regulator/regulator.txt
+
+Example:
+ xyz: regulator@0 {
Genuine question: Is the @0 meaningful?
+ compatible = ti,tps65218-dcdc1;
+ regulator-min-microvolt = 100;
+ regulator-max-microvolt = 300;
+ };
--
Lee Jones
Linaro
The code looks mostly fine, but the implementation of the commit logs
seems lazy. Please submit a v3 using coherent sentences with full
explanations and correct punctuation.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
certainly not 40
chars however.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
-compatible'?
I referred tps65217.txt the predecessors and used the compatible.
I also referred twl-regulator.txt.
That doesn't mean that they are correct/better. ;)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook
'{' and before '}'.
Ok. I will add a space after '{' and before '}'. Sorry I did not
follow tps65218_id_table being different than of_tps65218_match_table.
One is of the type of_device_id and the other i2c_device_id.
Shouldn't matter, it's just a formatting thing.
--
Lee Jones
Linaro
-
Please use the full 72 char (or there abouts) width of the buffer.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe
insinuated
that you failed to meet all of the criteria, but they definitely fell
short of the mark.
But fair enough, I'll fix those up and add Aaro's Tested-by
Thank you.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook
++---
1 file changed, 142 insertions(+), 123 deletions(-)
How is this different from patch 6?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line
++
1 file changed, 30 insertions(+), 27 deletions(-)
Same here. I think this should be done in one fell swoop.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list
+++---
1 file changed, 27 insertions(+), 23 deletions(-)
I see a theme forming.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux
Koskinen aaro.koski...@iki.fi
Signed-off-by: Felipe Balbi ba...@ti.com
---
drivers/mfd/menelaus.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
Same.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow
this process either (usually *_irq_unmap())
snip
- mutex_init(m-lock);
-
This doesn't belong in this patch.
It should have been removed with the final use of the lock was.
snip
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
,
+ NULL, menelaus_irq, IRQF_ONESHOT, DRIVER_NAME, m);
No need for a separate patch here. Convert straight from request_irq()
to devm_request_threaded_irq() in patch 3.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
-irq, NULL, menelaus_irq,
+ IRQF_ONESHOT, DRIVER_NAME, menelaus);
devm_* managed resources please.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from
On Tue, 10 Dec 2013, Felipe Balbi wrote:
On Tue, Dec 10, 2013 at 09:30:42AM +, Lee Jones wrote:
On Mon, 09 Dec 2013, Felipe Balbi wrote:
By using devm_request_threaded_irq() we can drop a few extra lines of
code and rely on device managed resources layer to free our IRQ for us
on ARM platforms. Is that true?
it was made *only* for Nokia to use on their ARM-only internet tablets.
If the IP is genuinely not reusable, them I'm fine with it.
I see that the Kconfig is setup in the correct way too, so we're good.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
On Tue, 10 Dec 2013, Felipe Balbi wrote:
On Tue, Dec 10, 2013 at 09:00:21AM +, Lee Jones wrote:
On Mon, 09 Dec 2013, Felipe Balbi wrote:
Those functions are static and can receive a menelaus_chip pointer very
easily.
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed
On Tue, 10 Dec 2013, Tony Lindgren wrote:
* Lee Jones lee.jo...@linaro.org [131210 10:39]:
Introduce an irq_chip and irq_domain for menelaus driver. Following
patches will convert uses to traditional request_threaded_irq().
While at that, some better error handling had
On Tue, 10 Dec 2013, Felipe Balbi wrote:
On Tue, Dec 10, 2013 at 08:57:01AM +, Lee Jones wrote:
Pass a menelaus_chip pointer as argument to most functions so we can
minimize the usage of the global the_menelaus pointer.
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off
Are you planning on re-submitting this patch-set anytime soon?
I thought Tony said it was important?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line
removed in patch 6?
return 0;
}
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord
Now that we have our own irq_chip, all children can use traditional
request_threaded_irq().
Is it possible to convert these to managed resources (*_devm)?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter
);
return 0;
}
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info
-by: Roger Quadros rog...@ti.com
Tested-by: Tomi Valkeinen tomi.valkei...@ti.com
Cc: sta...@vger.kernel.org # 3.9+
---
drivers/mfd/omap-usb-tll.c | 36
1 file changed, 12 insertions(+), 24 deletions(-)
Patch looks good to me now.
Applied, thanks.
--
Lee
On Thu, 09 Jan 2014, Roger Quadros wrote:
The omap-usb-host driver expects certained named clocks.
Add this information to the DT binding document.
Use clock names as per function for reference clocks.
CC: Lee Jones lee.jo...@linaro.org
CC: Samuel Ortiz sa...@linux.intel.com
Signed-off
Use devm_clk_get() instead of clk_get().
CC: Lee Jones lee.jo...@linaro.org
CC: Samuel Ortiz sa...@linux.intel.com
Signed-off-by: Roger Quadros rog...@ti.com
---
drivers/mfd/omap-usb-host.c | 81
+
1 file changed, 16 insertions(+), 65
Not all revisions have all the clocks so get the necessary clocks
based on hardware revision.
This should avoid un-necessary clk_get failure messages that were
observed earlier.
Be more strict and always fail on clk_get() error.
CC: Lee Jones lee.jo...@linaro.org
CC: Samuel Ortiz sa
On Fri, 10 Jan 2014, Arnd Bergmann wrote:
On Friday 10 January 2014, Lee Jones wrote:
- need_logic_fck = false;
+ /* Set all clocks as invalid to begin with */
+ omap-ehci_logic_fck = omap-init_60m_fclk = ERR_PTR(-EINVAL);
+ omap-utmi_p1_gfclk = omap
This patchset brings up USB Host ports and Ethernet port on
the OMAP5 uEVM board.
I'd keep hold of this and send it out again when the merge-window is
closed.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook
/tps65912-spi.c
drivers/mfd/tps80031.c
Perhaps some consolidating might be in order?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-omap
/tps65218.h | 284
++
4 files changed, 581 insertions(+)
create mode 100644 drivers/mfd/tps65218.c
create mode 100644 include/linux/mfd/tps65218.h
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software
Use devm_clk_get() instead of clk_get().
CC: Lee Jones lee.jo...@linaro.org
CC: Samuel Ortiz sa...@linux.intel.com
Signed-off-by: Roger Quadros rog...@ti.com
Acked-by: Lee Jones lee.jo...@linaro.org
---
drivers/mfd/omap-usb-host.c | 81
+
1
1 - 100 of 238 matches
Mail list logo
