RE: [RFC PATCH 1/1] i2c: rcar: handle RXDMA HW bug on Gen3

2018-06-06 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Yoshihiro Shimoda, Sent: Thursday, May 31, 2018 6:12 PM > > Hi Geert-san, Wolfram-san, > > > From: Geert Uytterhoeven, Sent: Thursday, May 31, 2018 5:45 PM > > > > Hi Shimoda-san, > > > > On Wed, May 30, 2018 at 10:35 AM, Yoshihiro Shimoda > > wrote: > > >> From: Wolfram

RE: [PATCH] soc: renesas: rcar-sysc: Make PM domain initialization more robust

2018-06-06 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Behalf Of Geert Uytterhoeven, Sent: Wednesday, June 6, 2018 5:58 PM > > Hi Simon, > > On Wed, Jun 6, 2018 at 10:52 AM, Simon Horman wrote: > > On Tue, Jun 05, 2018 at 05:05:15PM +0200, Geert Uytterhoeven wrote: > > This looks fine to me but I will wait to see if there

[PATCH 3/3] mmc: tmio: Fix reset operation

2018-06-06 Thread Niklas Söderlund
From: Masaharu Hayakawa SD / MMC did not operate properly when suspend transition failed. Because the SCC was not reset at resume, issue of the command failed. Changed tmio_mmc_reset() to tmio_mmc_hw_reset() in order to add reset of SCC to tmio_mmc_host_runtime_resume(). On runtime power

[PATCH 2/3] mmc: tmio: move tmio_mmc_hw_reset()

2018-06-06 Thread Niklas Söderlund
Avoid having to use forward declaration when in a later patch fixing the reset operation by moving tmio_mmc_hw_reset() earlier in the source file. No functional change in this change. Signed-off-by: Niklas Söderlund --- drivers/mmc/host/tmio_mmc_core.c | 16 1 file changed, 8

[PATCH 1/3] mmc: tmio: Add initial setting of interrupt mask register

2018-06-06 Thread Niklas Söderlund
From: Masaharu Hayakawa The initial value of the interrupt mask register may be different from the H/W manual at the startup of the kernel by setting of initial program. Since the error interrupts may be unmasked, the driver sets initial value. Signed-off-by: Masaharu Hayakawa Signed-off-by:

[PATCH 0/3] mmc: tmio: Fix reset operation

2018-06-06 Thread Niklas Söderlund
Hi, While looking at the Renesas BSP kernel I found patches which improves the state of the hardware at probe and after runtime resume. This is tested on R-Car H3 ES2. Patch 1/3 ensures the IRQ mask have the default value according the datasheet (Rev 0.15) in case the bootloader have changed

[PATCH 4/4] mmc: renesas_sdhi: Fix SCC error detection

2018-06-06 Thread Niklas Söderlund
From: Masaharu Hayakawa SDR104 and HS200 need to check SCC error. If SCC error is detected, retuning is necessary. In addition SCC error checking during retuning is unnecessary. Signed-off-by: Masaharu Hayakawa [Niklas: fix small style issue] Signed-off-by: Niklas Söderlund ---

[PATCH 3/4] mmc: renesas_sdhi: Fix sampling clock position selecting

2018-06-06 Thread Niklas Söderlund
From: Masaharu Hayakawa When the result of tuning was different between the first set and the second set, there was a case where the wrong sampling clock position was selected. As a countermeasure, make the two results the same. Signed-off-by: Masaharu Hayakawa [Niklas: update commit message]

[PATCH 2/4] mmc: tmio: Fix SCC error detection

2018-06-06 Thread Niklas Söderlund
From: Masaharu Hayakawa SDR104 and HS200 need to check for SCC error. If SCC error is detected, retuning is necessary. Signed-off-by: Masaharu Hayakawa [Niklas: update commit message] Signed-off-by: Niklas Söderlund --- drivers/mmc/host/tmio_mmc_core.c | 4 ++-- 1 file changed, 2

[PATCH 1/4] mmc: tmio: Fix tuning flow

2018-06-06 Thread Niklas Söderlund
From: Masaharu Hayakawa If the return value of mmc_send_tuning() is error other than -EILSEQ, the tuning fails and process goes out of for_loop. The correct processing is to judge their TAP as not good (NG) and continue. Signed-off-by: Masaharu Hayakawa [Niklas: update commit message]

[PATCH 0/4] mmc: {tmio,renesas_sdhi}: fix tuning behavior

2018-06-06 Thread Niklas Söderlund
Hi, Tuning failed on my R-Car H3 ES2.0 board using latest mmc/next while the Renesas BSP kernel worked. After some digging I found patches in the BSP which remedied this and whit these applied tuning now works for me. I have done small fixes, updated commit messages and rebased on latest

[PATCH 4/5] arm64: dts: renesas: r8a77980: add LVDS support

2018-06-06 Thread Sergei Shtylyov
Define the generic R8A77980 part of the LVDS device node. Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 29 + 1 file changed, 29 insertions(+) Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi

[PATCH 3/5] arm64: dts: renesas: r8a77980: add DU support

2018-06-06 Thread Sergei Shtylyov
Define the generic R8A77980 part of the DU device node. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 30 ++ 1 file changed, 30

[PATCH 2/5] arm64: dts: renesas: r8a77980: add VSPD support

2018-06-06 Thread Sergei Shtylyov
Describe VSPD0 in the R8A77980 device tree; it will be used by DU in the next patch... Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi | 10 ++ 1 file changed,

[PATCH 1/5] arm64: dts: renesas: r8a77980: add FCPVD support

2018-06-06 Thread Sergei Shtylyov
Describe FCPVD0 in the R8A77980 device tree; it will be used by VSPD0 in the next patch... Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei Shtylyov --- arch/arm64/boot/dts/renesas/r8a77980.dtsi |8 1 file

[PATCH 0/5] Add R8A77980/Condor LVDS/HDMI support

2018-06-06 Thread Sergei Shtylyov
Hello! Reposting with the correct subject... Sorry! :-] Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17-rc7' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to

[PATCH 0/5] Add R8A77970/V3MSK LVDS/HDMI support

2018-06-06 Thread Sergei Shtylyov
Hello! Here's the set of 5 patches against Simon Horman's 'renesas.git' repo's 'renesas-devel-20180604-v4.17-rc7' tag. We're adding the R8A77980 FCPVD/VSPD/ DU/LVDS device nodes and then describing the LVDS decoder and HDMI encoder connected to the LVDS output. These patches depend on the Thine

Re: dt-bindings: watchdog: renesas-wdt: Add support for the R8A77990 wdt

2018-06-06 Thread Geert Uytterhoeven
SoC. >> >> No driver update is needed. >> >> Signed-off-by: Masaharu Hayakawa >> Signed-off-by: Geert Uytterhoeven > > This refuses to apply for me. What tree is it based on ? Yesterday's next. Still applies fine against next-20180606, which includes watchdog next

Re: dt-bindings: watchdog: renesas-wdt: Add support for the R8A77990 wdt

2018-06-06 Thread Guenter Roeck
On Tue, Jun 05, 2018 at 07:18:33PM +0200, Geert Uytterhoeven wrote: > From: Masaharu Hayakawa > > Document support for the Watchdog Timer (WDT) Controller in the Renesas > R-Car E3 (R8A77990) SoC. > > No driver update is needed. > > Signed-off-by: Masaharu Hayakawa > Signed-off-by: Geert

Re: dt-bindings: watchdog: renesas-wdt: Add support for the R8A77990 wdt

2018-06-06 Thread Guenter Roeck
On Tue, Jun 05, 2018 at 07:18:33PM +0200, Geert Uytterhoeven wrote: > From: Masaharu Hayakawa > > Document support for the Watchdog Timer (WDT) Controller in the Renesas > R-Car E3 (R8A77990) SoC. > > No driver update is needed. > > Signed-off-by: Masaharu Hayakawa > Signed-off-by: Geert

Re: [PATCH v2] arm64: dts: salvator-x(s): Update I2C ch4 clock to 400kHz

2018-06-06 Thread Wolfram Sang
> All other (non-VC5/6) devices on i2c4 currently described in DT are > described in salvator-common.dtsi. Yes, exactly, non-VC5/6. Now imagine we need to reduce the freq because of a HW bug in only one of them... But all fine with me. You can send a fixup patch if you want and add my ack.

Re: [PATCH v2] arm64: dts: salvator-x(s): Update I2C ch4 clock to 400kHz

2018-06-06 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Jun 6, 2018 at 3:41 PM, Wolfram Sang wrote: >> > arch/arm64/boot/dts/renesas/salvator-x.dtsi | 2 ++ >> > arch/arm64/boot/dts/renesas/salvator-xs.dtsi | 2 ++ >> >> Any reason this cannot be added to salvator-common.dtsi instead? > > It could be. For clarity, I wanted to

Re: [PATCH v2] arm64: dts: salvator-x(s): Update I2C ch4 clock to 400kHz

2018-06-06 Thread Wolfram Sang
> > arch/arm64/boot/dts/renesas/salvator-x.dtsi | 2 ++ > > arch/arm64/boot/dts/renesas/salvator-xs.dtsi | 2 ++ > > Any reason this cannot be added to salvator-common.dtsi instead? It could be. For clarity, I wanted to place this attribute to the highest level and not somewhere inbetween.

Re: [PATCH 2/2] dmaengine: rcar-dmac: Document R8A77990 bindings

2018-06-06 Thread Geert Uytterhoeven
On Wed, May 16, 2018 at 3:06 PM, Ulrich Hecht wrote: > From: Hiroyuki Yokoyama > > Renesas R-Car E3 (R8A77990) SoC also has the R-Car gen2/3 compatible DMA > controllers, so document the SoC specific binding. > > Signed-off-by: Hiroyuki Yokoyama > Signed-off-by: Ulrich Hecht Reviewed-by:

Re: [PATCH v2] arm64: dts: salvator-x(s): Update I2C ch4 clock to 400kHz

2018-06-06 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, May 28, 2018 at 9:29 PM, Wolfram Sang wrote: > From: Takeshi Kihara > > Any of the following devices connected to I2C ch4 of the Salvator-X(S) > boards will operate at 400 kHz: > > PCA9654, 9FGV0841, ADV7482WBBCZ, MAX9611, 5P49V5923, 5P49V6901A > > This patch updates the

[PATCH v2] arm64: dts: renesas: r8a77990: Enable USB2.0 Host for Ebisu board

2018-06-06 Thread Yoshihiro Shimoda
This patch adds USB2.0 PHY and Host(EHCI/OHCI) nodes and enables them for R-Car E3 Ebisu board. Signed-off-by: Yoshihiro Shimoda --- This patch set is based on renesas-drivers.git / renesas-drivers-2018-06-05-v4.17 tag. Changes from v1: - Squash 4 patches into a single patch.

RE: [PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

2018-06-06 Thread Yoshihiro Shimoda
Hi Simon-san, > From: Simon Horman, Sent: Wednesday, June 6, 2018 6:16 PM > > On Wed, Jun 06, 2018 at 03:56:07PM +0900, Yoshihiro Shimoda wrote: > > This patch set is based on renesas-drivers.git / > > renesas-drivers-2018-06-05-v4.17 tag. > > > > About dt-bindings of

Re: [PATCH] ARM: Build secure_cntvoff.S unconditionally to fix shmobile !SMP build

2018-06-06 Thread Geert Uytterhoeven
Hi Russell, On Wed, Jun 6, 2018 at 11:27 AM, Russell King - ARM Linux wrote: > On Wed, Jun 06, 2018 at 11:22:41AM +0200, Geert Uytterhoeven wrote: >> On Wed, Jun 6, 2018 at 11:09 AM, Russell King - ARM Linux >> wrote: >> >> Fixes: cad160ed0a94927e ("ARM: shmobile: Convert file to use cntvoff")

Re: [PATCH] ARM: Build secure_cntvoff.S unconditionally to fix shmobile !SMP build

2018-06-06 Thread Russell King - ARM Linux
On Wed, Jun 06, 2018 at 11:22:41AM +0200, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Jun 6, 2018 at 11:09 AM, Russell King - ARM Linux > wrote: > >> Fixes: cad160ed0a94927e ("ARM: shmobile: Convert file to use cntvoff") > >> Signed-off-by: Geert Uytterhoeven > > > > This doesn't look

[PATCH v2] ARM: Always build secure_cntvoff.S on ARM V7 to fix shmobile !SMP build

2018-06-06 Thread Geert Uytterhoeven
If CONFIG_SMP=n, building a kernel for R-Car Gen2 fails with: arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init': setup-rcar-gen2.c:(.init.text+0x30): undefined reference to `secure_cntvoff_init' Indeed, on R-Car Gen2 SoCs, secure_cntvoff_init() is not only

Re: [PATCH] ARM: Build secure_cntvoff.S unconditionally to fix shmobile !SMP build

2018-06-06 Thread Geert Uytterhoeven
Hi Russell, On Wed, Jun 6, 2018 at 11:09 AM, Russell King - ARM Linux wrote: > On Wed, Jun 06, 2018 at 10:52:34AM +0200, Geert Uytterhoeven wrote: >> If CONFIG_SMP=n, building a kernel for R-Car Gen2 fails with: >> >> arch/arm/mach-shmobile/setup-rcar-gen2.o: In function >>

Re: [PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

2018-06-06 Thread Simon Horman
On Wed, Jun 06, 2018 at 03:56:07PM +0900, Yoshihiro Shimoda wrote: > This patch set is based on renesas-drivers.git / > renesas-drivers-2018-06-05-v4.17 tag. > > About dt-bindings of "renesas,usb2-phy-r8a77990", I submitted a patch: > https://patchwork.kernel.org/patch/10449723/ > > But, the

Re: [PATCH] ARM: Build secure_cntvoff.S unconditionally to fix shmobile !SMP build

2018-06-06 Thread Russell King - ARM Linux
On Wed, Jun 06, 2018 at 10:52:34AM +0200, Geert Uytterhoeven wrote: > If CONFIG_SMP=n, building a kernel for R-Car Gen2 fails with: > > arch/arm/mach-shmobile/setup-rcar-gen2.o: In function > `rcar_gen2_timer_init': > setup-rcar-gen2.c:(.init.text+0x30): undefined reference to >

Re: [PATCH 1/3] arm64: dts: renesas: r8a77980: add GPIO support

2018-06-06 Thread Geert Uytterhoeven
On Fri, Jun 1, 2018 at 10:44 PM, Sergei Shtylyov wrote: > Describe all 6 GPIO controllers in the R8A77980 device tree. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven

Re: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Enable watchdog timer

2018-06-06 Thread Simon Horman
On Tue, Jun 05, 2018 at 07:20:34PM +0200, Geert Uytterhoeven wrote: > From: Takeshi Kihara > > Add a device node for the Watchdog Timer (WDT) controller on the > R8A77990 SoC, and enable the watchdog on the Ebisu board. > > Signed-off-by: Takeshi Kihara > [geert: Squashed 2 commits] >

Re: [PATCH] ARM: Build secure_cntvoff.S unconditionally to fix shmobile !SMP build

2018-06-06 Thread Maxime Ripard
On Wed, Jun 06, 2018 at 10:52:34AM +0200, Geert Uytterhoeven wrote: > If CONFIG_SMP=n, building a kernel for R-Car Gen2 fails with: > > arch/arm/mach-shmobile/setup-rcar-gen2.o: In function > `rcar_gen2_timer_init': > setup-rcar-gen2.c:(.init.text+0x30): undefined reference to >

Re: [PATCH] soc: renesas: rcar-sysc: Make PM domain initialization more robust

2018-06-06 Thread Geert Uytterhoeven
Hi Simon, On Wed, Jun 6, 2018 at 10:52 AM, Simon Horman wrote: > On Tue, Jun 05, 2018 at 05:05:15PM +0200, Geert Uytterhoeven wrote: >> The quirk for R-Car E3 ES1.0 added in commit 086b399965a7ee7e ("soc: >> renesas: r8a77990-sysc: Add workaround for 3DG-{A,B}") makes the 3DG-A >> PM domain a

[PATCH] ARM: Build secure_cntvoff.S unconditionally to fix shmobile !SMP build

2018-06-06 Thread Geert Uytterhoeven
If CONFIG_SMP=n, building a kernel for R-Car Gen2 fails with: arch/arm/mach-shmobile/setup-rcar-gen2.o: In function `rcar_gen2_timer_init': setup-rcar-gen2.c:(.init.text+0x30): undefined reference to `secure_cntvoff_init' Indeed, on R-Car Gen2 SoCs, secure_cntvoff_init() is not only

Re: [PATCH] soc: renesas: rcar-sysc: Make PM domain initialization more robust

2018-06-06 Thread Simon Horman
On Tue, Jun 05, 2018 at 05:05:15PM +0200, Geert Uytterhoeven wrote: > The quirk for R-Car E3 ES1.0 added in commit 086b399965a7ee7e ("soc: > renesas: r8a77990-sysc: Add workaround for 3DG-{A,B}") makes the 3DG-A > PM domain a subdomain of the 3DG-B PM domain. However, registering > 3DG-A with its

Re: [PATCH v5 0/2] R-Car DU: Convert DT to new DU and LVDS bindings

2018-06-06 Thread Simon Horman
On Tue, Jun 05, 2018 at 12:51:04PM +0300, Laurent Pinchart wrote: > Hello, > > This small patch series contains the last two remaining patches from > "[PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver". Apart from > the individual SoC patches being squashed together as requested by

Re: [PATCH 3/3] arm64: dts: renesas: v3hsk: specify GEther PHY IRQ

2018-06-06 Thread Geert Uytterhoeven
On Fri, Jun 1, 2018 at 10:47 PM, Sergei Shtylyov wrote: > Specify GEther PHY IRQ in the V3H Starter Kit board's device tree, now > that we have the GPIO support (previously phylib had to resort to polling). > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by:

Re: [PATCH 2/2] arm64: dts: renesas: initial V3HSK board device tree

2018-06-06 Thread Geert Uytterhoeven
On Thu, May 10, 2018 at 8:12 PM, Sergei Shtylyov wrote: > Add the initial device tree for the V3H Starter Kit board. > The board has 1 debug serial port (SCIF0); include support for it, > so that the serial console can work. > > Based on the original (and large) patch by Vladimir Barinov. > >

Re: [PATCH 2/2] arm64: dts: renesas: condor: add I2C0 support

2018-06-06 Thread Geert Uytterhoeven
Hi Sergei, On Mon, May 28, 2018 at 10:14 PM, Sergei Shtylyov wrote: > Define the Condor board dependent part of the I2C0 device node. > > The I2C0 bus is populated by 2 ON Semiconductor PCA9654 I/O expanders > and Analog Devices ADV7511W HDMI transmitter (but we're only describing > the former

[PATCH 3/4] arm64: dts: renesas: r8a77990: ebisu: enable usb2_phy0

2018-06-06 Thread Yoshihiro Shimoda
This patch enables usb2_phy0 for r8a77990 Ebisu board. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts

[PATCH 4/4] arm64: dts: renesas: r8a77990: ebisu: enable USB2.0 host

2018-06-06 Thread Yoshihiro Shimoda
This patch enables USB2.0 host (EHCI/OHCI) for r8a77990 Ebisu board. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts

[PATCH 1/4] arm64: dts: renesas: r8a77990: add usb2_phy device node

2018-06-06 Thread Yoshihiro Shimoda
This patch adds USB2.0 phy device node for r8a77990. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index

[PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

2018-06-06 Thread Yoshihiro Shimoda
This patch set is based on renesas-drivers.git / renesas-drivers-2018-06-05-v4.17 tag. About dt-bindings of "renesas,usb2-phy-r8a77990", I submitted a patch: https://patchwork.kernel.org/patch/10449723/ But, the phy-rcar-gen3-usb2 driver works on the board without the bindings because

[PATCH 0/2] pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and funcrions

2018-06-06 Thread Yoshihiro Shimoda
This patch set is based on renesas-drivers.git / renesas-drivers-2018-06-05-v4.17 tag. Takeshi Kihara (1): pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions Yoshihiro Shimoda (1): pinctrl: sh-pfc: r8a77990: Revise USB ID pin name drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 42

[PATCH 1/2] pinctrl: sh-pfc: r8a77990: Revise USB ID pin name

2018-06-06 Thread Yoshihiro Shimoda
Since the datasheet Rev.1.00 has an error about the USB ID pin name, this patch revises it. Signed-off-by: Yoshihiro Shimoda --- drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77990.c

[PATCH 2/2] pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions

2018-06-06 Thread Yoshihiro Shimoda
From: Takeshi Kihara This patch adds USB0_{PWEN,OVC}_{A,B} and USB0_ID pins, groups and functions to the R8A77990 SoC. Signed-off-by: Takeshi Kihara Signed-off-by: Yoshihiro Shimoda --- drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 38 +++ 1 file changed, 38

[PATCH] dt-bindings: rcar-gen3-phy-usb2: Add bindings for r8a77990

2018-06-06 Thread Yoshihiro Shimoda
This patch adds suuport for r8a77990 (R-Car E3). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt