Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-11-01 Thread Wolfram Sang
Hi Chris, On Mon, Sep 12, 2016 at 10:15:06AM -0400, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because 16-bits accesses

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-24 Thread Chris Brandt
> > > This SWAP register exists on R-Car as well. Out of curiosity, what > > > is the register value of 0xE804E0E4? > > > > 0xE804E0E4 = 0x0001 > > > > So...something is there! > > I am quite convinced there is this BUSWIDTH register. If you are > interested, try setting this to 0 and see if it

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-24 Thread Geert Uytterhoeven
Hi Wolfram, On Fri, Oct 21, 2016 at 11:56 PM, Wolfram Sang wrote: >> For the VERSION register, the low byte is the version of the IP, but >> the upper byte is a number that the design group that made the part > > I know. It is just that I haven't seen this one "in the wild"

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-21 Thread Wolfram Sang
> For the VERSION register, the low byte is the version of the IP, but > the upper byte is a number that the design group that made the part I know. It is just that I haven't seen this one "in the wild" so far. > > This SWAP register exists on R-Car as well. Out of curiosity, what is the > >

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-21 Thread Chris Brandt
> > > * Does it have a version register (CTL_VERSION)? If so, what does it > > > say? > > > > 0x820B > > Okay, this is a version I have not seen before. The SDHI IP came from the SH7269 (SH-2A device). For the VERSION register, the low byte is the version of the IP, but the upper byte is a

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
> However, for version 3.0 that will be posted shortly, it will start to > include the SDHI section. Nice. Could you ping me when this comes out? > > * Does it have a version register (CTL_VERSION)? If so, what does it > > say? > > 0x820B Okay, this is a version I have not seen before. >

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Chris Brandt
Hello Wolfram, > > > + /* if count was multiple of 4 */ > > > + if (!(count & 0x3)) > > > + return; > > > + buf8 = (u8 *)(buf + (count >> 2)); > > > + count %= 4; > > > > To skip the same operation done on 'count' twice, maybe? > > > >

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Chris Brandt
On 10/20/2016, Wolfram Sang wrote: > Sadly, I don't have SDHI documentation for this SoC. In the current hardware manual on renesas.com, the SHDI section is not included. However, for version 3.0 that will be posted shortly, it will start to include the SDHI section. > * Does it have a version

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-20 Thread Wolfram Sang
On Mon, Sep 12, 2016 at 10:15:06AM -0400, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because 16-bits accesses are > not

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-17 Thread Ulf Hansson
ntembedded.com>; Geert Uytterhoeven <geert@linux- >> m68k.org>; Simon Horman <horms+rene...@verge.net.au>; linux-mmc > m...@vger.kernel.org>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; >> Lee Jones <l...@kernel.org> >> Subject: Re: [PATCH

RE: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-10-14 Thread Chris Brandt
rms+rene...@verge.net.au>; linux-mmc m...@vger.kernel.org>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; > Lee Jones <l...@kernel.org> > Subject: Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port > > + Lee > > On 12 September 2016 at 16:15

Re: [PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-22 Thread Ulf Hansson
+ Lee On 12 September 2016 at 16:15, Chris Brandt wrote: > For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. > Therefore a new flag has been created that will allow 32-bit reads/writes > to the DATA_PORT register instead of 16-bit (because

[PATCH v3 2/3] mmc: tmio-mmc: add support for 32bit data port

2016-09-12 Thread Chris Brandt
For the r7s72100 SOC, the DATA_PORT register was changed to 32-bits wide. Therefore a new flag has been created that will allow 32-bit reads/writes to the DATA_PORT register instead of 16-bit (because 16-bits accesses are not supported). Signed-off-by: Chris Brandt ---