Re: [PATCH 5/5] drm: Don't pass clip to drm_atomic_helper_check_plane_state()

On 23/01/2018 18:08, Ville Syrjala wrote: > From: Ville Syrjälä > > Move the plane clip rectangle handling into > drm_atomic_helper_check_plane_state(). Drivers no longer > have to worry about such mundane details. > > v2: Convert armada, rcar, and sun4i as well >

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

On 01/25/18 15:53, Tyrel Datwyler wrote: > On 01/25/2018 01:49 PM, Frank Rowand wrote: >> Hi Wolfram, >> >> On 01/25/18 03:03, Steven Rostedt wrote: >>> On Wed, 24 Jan 2018 22:55:13 -0800 >>> Frank Rowand wrote: >>> Hi Steve, >>> Off the top of your head,

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

On 01/25/18 15:14, Wolfram Sang wrote: > >> This means that ftrace can not be used for the of_node_get(), >> of_node_put(), and of_node_release() debug info, because >> these functions are called before early_initcall(). > > For the record: You can still unbind/bind devices. This is how I >

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

On 01/25/18 15:12, Wolfram Sang wrote: > Frank, > > here seems to be a misunderstanding going on. I don't want to push this > patch upstream against all odds. I merely wanted to find out what the > status of this patch is. Because one possibility was that it had just > been forgotten... > >>>

Re: [PATCH v12 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

Hi again, On 2018-01-26 01:23:58 +0100, Niklas Söderlund wrote: [snip] > > > > Furthermore, as explained in a comment I made when reviewing the VIN patch > > series, I wonder whether we shouldn't identify the CSI-2 receiver instances > > by > > ID the same way we do with the VIN instances

Re: [PATCH v12 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

Hi Laurent, Thanks for your comments. On 2017-12-11 20:00:21 +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Wednesday, 29 November 2017 21:32:34 EET Niklas Söderlund wrote: > > Documentation for Renesas R-Car MIPI CSI-2 receiver. The CSI-2 receivers > > are

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

On 01/25/2018 01:49 PM, Frank Rowand wrote: > Hi Wolfram, > > On 01/25/18 03:03, Steven Rostedt wrote: >> On Wed, 24 Jan 2018 22:55:13 -0800 >> Frank Rowand wrote: >> >>> Hi Steve, >> >>> >>> Off the top of your head, can you tell me know early in the boot >>> process a

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

On 01/25/18 14:40, Tyrel Datwyler wrote: > On 01/24/2018 10:48 PM, Frank Rowand wrote: >> On 01/21/18 06:31, Wolfram Sang wrote: >>> From: Tyrel Datwyler >>> >>> This patch introduces event tracepoints for tracking a device_nodes >>> reference cycle as well as reconfig

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

> This means that ftrace can not be used for the of_node_get(), > of_node_put(), and of_node_release() debug info, because > these functions are called before early_initcall(). For the record: You can still unbind/bind devices. This is how I debugged an issue. signature.asc Description: PGP

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

Frank, here seems to be a misunderstanding going on. I don't want to push this patch upstream against all odds. I merely wanted to find out what the status of this patch is. Because one possibility was that it had just been forgotten... > > So, I thought reposting would be a good way of finding

Re: DRM: double free in rcar_du_vsp.c

Hi Volodymyr, My apologies for the silence on this thread, but it has not been ignored. I believe Laurent has investigated this issue, and prepared a patch locally on his tree. However, he is currently out-of-office with travel and may not find time to reply to this thread this week or next. I

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

Hi Wolfram, On 01/25/18 03:03, Steven Rostedt wrote: > On Wed, 24 Jan 2018 22:55:13 -0800 > Frank Rowand wrote: > >> Hi Steve, > >> >> Off the top of your head, can you tell me know early in the boot >> process a trace_event can be called and successfully provide the >>

Re: [PATCH v2] v4l: async: Protect against double notifier registrations

Hi Geert, Thanks for the review On 17/01/18 08:00, Geert Uytterhoeven wrote: > Hi Kieran, > > On Wed, Jan 17, 2018 at 12:47 AM, Kieran Bingham > wrote: >> From: Kieran Bingham >> >> It can be easy to attempt to register

[RFC 36/37] ARM: dts: iwg20m: Add watchdog support to SoM dtsi

This patch enables the watchdog from within the iwg20m SoM dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7743-iwg20m.dtsi | 5 + 1 file changed, 5 insertions(+)

[RFC 35/37] ARM: dts: r8a7794: Add watchdog support to SoC dtsi

This commit adds watchdog support to the r8a7794 dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7794.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

[RFC 37/37] ARM: dts: iwg22m: Add watchdog support to SoM dtsi

This patch enables the watchdog from within the iwg20m SoM dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7745-iwg22m.dtsi | 5 + 1 file changed, 5 insertions(+)

[RFC 34/37] ARM: dts: r8a7791: Add watchdog support to SoC dtsi

This commit adds watchdog support to the r8a7791 dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7791.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

[RFC 31/37] ARM: dts: r8a7743: Add watchdog support to SoC dtsi

This patch adds watchdog support to the r8a7743 SoC dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7743.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff

[RFC 33/37] ARM: dts: r8a7790: Add watchdog support to SoC dtsi

This commit adds watchdog support to the r8a7790 dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7790.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

[RFC 32/37] ARM: dts: r8a7745: Add watchdog support to SoC dtsi

This patch adds watchdog support to the r8a7745 SoC dtsi. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7745.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff

[RFC 30/37] clk: renesas: r8a7794: Add rwdt clock

Add "rwdt" clock to r8a7794_mod_clks. Also, since we may need to access the watchdog registers at any time, declare the clock as critical. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 29/37] clk: renesas: r8a7791/r8a7793: Add rwdt clock

Add "rwdt" clock to r8a7791_mod_clks. Also, since we may need to access the watchdog registers at any time, declare the clock as critical. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 26/37] clk: renesas: r8a7743: Add rwdt clock

Add "rwdt" clock to r8a7743_mod_clks. Also, since we may need to access the watchdog registers at any time, declare the clock as critical. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 24/37] watchdog: renesas_wdt_gen2: Add Gen2 specific driver

R-Car Gen2 (and RZ/G1) platforms need some tweaking for SMP and watchdog to coexist nicely. This new driver is based on top of Wolfram Sang's driver (drivers/watchdog/renesas_wdt.c), and it contains the quirks necessary for R-Car Gen2 and RZ/G1 to work properly and in harmony with the rest of the

[RFC 25/37] ARM: shmobile: defconfig: Enable RENESAS_WDT_GEN2

R-Car Gen2 and RZ/G1 platforms come with a watchdog IP, therefore enable its driver by default. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/configs/shmobile_defconfig | 1 + 1 file

[RFC 28/37] clk: renesas: r8a7790: Add rwdt clock

Add "rwdt" clock to r8a7790_mod_clks. Also, since we may need to access the watchdog registers at any time, declare the clock as critical. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 27/37] clk: renesas: r8a7745: Add rwdt clock

Add "rwdt" clock to r8a7745_mod_clks. Also, since we may need to access the watchdog registers at any time, declare the clock as critical. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 23/37] ARM: shmobile: rcar-gen2: Export shmobile_set_wdt_clock_status function

This patch exposes a function to set the value of variable "shmobile_wdt_clock_status" so that the watchdog driver may communicate critical information to the SMP bring up assembly routine. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram

[RFC 17/37] arm64: dts: renesas: r8a7795: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1

[RFC 10/37] soc: renesas: rcar-rst: Enable watchdog as reset trigger for Gen2

This patch allows for platform specific quirks as some of the SoC need further customization for the watchdog to work properly, like for R-Car Gen2 and for RZ/G. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram

[RFC 16/37] ARM: dts: r8a7794: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7794.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[RFC 21/37] dt-bindings: watchdog: renesas-wdt: Add R-Car Gen2 support

This commit documents the compatibility with R-Car Gen2 and RZ/G devices by defining the generifc compatible string "renesas,rcar-gen2-wdt". Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 19/37] arm64: dts: renesas: r8a77970: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm64/boot/dts/renesas/r8a77970.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1

[RFC 18/37] arm64: dts: renesas: r8a7796: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1

[RFC 22/37] watchdog: renesas_wdt: Add restart support

This commit extends the driver to add restart support by implementing the restart callback to trigger the watchdog as quickly as possible. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 20/37] arm64: dts: renesas: r8a77995: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1

[RFC 14/37] ARM: dts: r8a7790: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7790.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[RFC 15/37] ARM: dts: r8a7791: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7791.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[RFC 13/37] ARM: dts: r8a7745: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7745.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[RFC 07/37] ARM: dts: r8a7793: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 12/37] ARM: dts: r8a7743: Use fallback rst compatible string

Add the generic fallback compatible string for the rst node. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram --- arch/arm/boot/dts/r8a7743.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[RFC 06/37] ARM: dts: r8a7792: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 05/37] ARM: dts: r8a7791: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 08/37] ARM: dts: r8a7794: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 11/37] soc: renesas: rcar-rst: Document generic compatible strings

>From now on, devices compatible with the generic compatible strings documented by this commit don't need to modify the corresponding driver anymore. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 09/37] soc: renesas: rcar-rst: Add generic compatible strings

This commit introduces generic compatible strings to use as fallback, so that devices compatible with the generic implementation may avoid changing the driver. Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram

[RFC 03/37] ARM: dts: r8a7745: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 04/37] ARM: dts: r8a7790: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 01/37] ARM: shmobile: Add watchdog support

On R-Car Gen2 and RZ/G1 platforms, we use the SBAR registers to make non boot CPUs run a routine designed to bring up SMP and deal with hot plug. The value contained in the SBAR registers is not initialized by a WDT triggered reset, which means that after a WDT triggered reset we jump to the SMP

[RFC 02/37] ARM: dts: r8a7743: Adjust SMP routine size

This patch adjusts the definition of the SMP routine size according to the latest changes made by commit: "ARM: shmobile: Add watchdog support" Signed-off-by: Fabrizio Castro Signed-off-by: Ramesh Shanmugasundaram ---

[RFC 00/37] Fix watchdog on Renesas R-Car Gen2 and RZ/G1

Dear All, while trying to add watchdog support to RZ/G1M and RZ/G1E I discovered that it couldn't work out of the box. R-Car Gen2 and RZ/G1 are very similar from a design perspective, and therefore the same problem is observable on R-Car Gen2 too. To deal with SMP on R-Car Gen2 and RZ/G1, we

Re: [PATCH] sh: clk: Relax clk rate match test

Hi Jacopo, On Thu, Jan 25, 2018 at 3:14 PM, jacopo mondi wrote: > On Thu, Jan 25, 2018 at 02:53:41PM +0100, Geert Uytterhoeven wrote: >> CC linux-clk (yes I know this is about the legacy SH clock framework, but >> the public API is/should be the same) >> >> On Thu, Jan 25,

Re: [PATCH] sh: clk: Relax clk rate match test

Hi Geert, On Thu, Jan 25, 2018 at 02:53:41PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > CC linux-clk (yes I know this is about the legacy SH clock framework, but > the public API is/should be the same) > > On Thu, Jan 25, 2018 at 12:24 PM, Jacopo Mondi > wrote:

Re: [PATCH] sh: clk: Relax clk rate match test

Hi Jacopo, CC linux-clk (yes I know this is about the legacy SH clock framework, but the public API is/should be the same) On Thu, Jan 25, 2018 at 12:24 PM, Jacopo Mondi wrote: > When asking for a clk rate to be set, the sh core clock matches only > exact rate values

Re: [PATCH v2] v4l2-dev.h: fix symbol collision in media_entity_to_video_device()

On Thu, Jan 25, 2018 at 02:08:52PM +0100, Niklas Söderlund wrote: > A recent change to the media_entity_to_video_device() macro breaks some > use-cases for the macro due to a symbol collision. Before the change > this worked: > > vdev = media_entity_to_video_device(link->sink->entity); > >

[PATCH v2] v4l2-dev.h: fix symbol collision in media_entity_to_video_device()

A recent change to the media_entity_to_video_device() macro breaks some use-cases for the macro due to a symbol collision. Before the change this worked: vdev = media_entity_to_video_device(link->sink->entity); While after the change it results in a compiler error "error: 'struct

[PATCH] sh: clk: Relax clk rate match test

When asking for a clk rate to be set, the sh core clock matches only exact rate values against the calculated frequency table entries. If the rate does not match exactly the test fails, and the whole frequency table is walked, resulting in selection of the last entry, corresponding to the lowest

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

On Wed, 24 Jan 2018 22:55:13 -0800 Frank Rowand wrote: > Hi Steve, > > Off the top of your head, can you tell me know early in the boot > process a trace_event can be called and successfully provide the > data to someone trying to debug early boot issues? The trace

Re: [PATCH/RFC 4/4] drm: rcar-du: Add support for color keying on Gen3

Hi, On Sun, Dec 17, 2017 at 02:17:24AM +0200, Laurent Pinchart wrote: > +static const struct drm_prop_enum_list colorkey_modes[] = { > + { 0, "disabled" }, > + { 1, "source" }, > +}; > + > int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np, >unsigned

Re: [PATCH/RFC 1/4] drm: Add colorkey properties

On Sun, Dec 17, 2017 at 02:17:21AM +0200, Laurent Pinchart wrote: > Color keying is the action of replacing pixels matching a given color > (or range of colors) with transparent pixels in an overlay when > performing blitting. Depending on the hardware capabilities, the > matching pixel can either

RE: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

Thank you Marc. Cheers, Fabrizio > -Original Message- > From: Marc Kleine-Budde [mailto:m...@pengutronix.de] > Sent: 25 January 2018 08:53 > To: Fabrizio Castro > Cc: Simon Horman ; Geert Uytterhoeven > ;

Re: [PATCH] v4l2-dev.h: fix symbol collision in media_entity_to_video_device()

Hi Niklas, Em Thu, 25 Jan 2018 01:34:30 +0100 Niklas Söderlund escreveu: > A recent change to the media_entity_to_video_device() macro breaks some > use-cases for the macro due to a symbol collision. Before the change > this worked: > > vdev =

Re: [PATCH 1/8] dt-bindings: can: rcar_can: document r8a774[35] can support

On 01/24/2018 06:22 PM, Fabrizio Castro wrote: > thank you for Acking the patch, just wondering if this patch has any > chance to end up in v4.16? I can take this via the linux-can tree, if no one else takes it. Marc -- Pengutronix e.K. | Marc Kleine-Budde |

Re: [PATCH v2 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support

On 25/01/2018 09:21, Geert Uytterhoeven wrote: > Hi Daniel, > > On Thu, Jan 25, 2018 at 9:09 AM, Daniel Lezcano > wrote: >> On 24/01/2018 17:49, Fabrizio Castro wrote: >>> I am sorry to bother you, just wondering if you think there are any chances >>> for this patch

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

On 01/21/18 06:31, Wolfram Sang wrote: > From: Tyrel Datwyler > > This patch introduces event tracepoints for tracking a device_nodes > reference cycle as well as reconfig notifications generated in response > to node/property manipulations. > > With the recent

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

On 01/25/18 00:01, Geert Uytterhoeven wrote: > Hi Frank, > > On Thu, Jan 25, 2018 at 7:48 AM, Frank Rowand wrote: >>> create mode 100644 include/trace/events/of.h >> >> mode looks incorrect. Existing files in include/trace/events/ are -rw-rw > > Not in my git clone

Re: [PATCH v2 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support

On 24/01/2018 17:49, Fabrizio Castro wrote: > Hello Daniel, > > I am sorry to bother you, just wondering if you think there are any chances > for this patch to applied on top of v4.16? You can take it through the renesas tree. Acked-by: Daniel Lezcano >> Subject:

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

Hi Frank, On Thu, Jan 25, 2018 at 7:48 AM, Frank Rowand wrote: >> create mode 100644 include/trace/events/of.h > > mode looks incorrect. Existing files in include/trace/events/ are -rw-rw Not in my git clone ;-) 644 should be fine. Gr{oetje,eeting}s,

Re: [PATCH] v4l2-dev.h: fix symbol collision in media_entity_to_video_device()

Hi Niklas, On Thu, Jan 25, 2018 at 1:34 AM, Niklas Söderlund wrote: > A recent change to the media_entity_to_video_device() macro breaks some > use-cases for the macro due to a symbol collision. Before the change > this worked: > > vdev =