Re: [PATCH 1/3] mmc: sdhci-s3c: Enable only required bus clock

2012-09-19 Thread Chris Ball
Hi, On Fri, Sep 14 2012, Chander Kashyap wrote: In case of multiple bus clock sources, all the clock sources were getting enabled. As only one clock source is needed at the time hence enable only the required bus clock. This patch does as follows: 1.In sdhci_s3c_probe enable only

Re: [PATCH 2/3] mmc: sdhci-s3c: Fix crash on module insertion for second time

2012-09-19 Thread Chris Ball
Hi, On Fri, Sep 14 2012, Chander Kashyap wrote: If sdhci-s3c driver is built as module, it gives following error if inserted again after removing. This was happening as pm_runtime_use_autosuspend() is called in sdhci_s3c_probe() function but in sdhci_s3c_remove() its complementry

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-19 Thread Chris Ball
Hi Jaehoon, Girish, On Fri, Sep 14 2012, Chander Kashyap wrote: Perform clock disable/enable in runtime suspend/resume. Signed-off-by: Chander Kashyap chander.kash...@linaro.org --- drivers/mmc/host/sdhci-s3c.c | 25 +++-- 1 file changed, 23 insertions(+), 2

Re: [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-09-19 Thread Chris Ball
Hi Thomas, On Wed, Sep 19 2012, Thomas Abraham wrote: Hi Jaehoon, Seungwon, All the changes you have suggested for this patch series has been completed. If you could ack this series, it would be great. Thanks, Thomas. Hi Chris, I have addressed all the comments received for the v5 of

Re: [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-09-19 Thread Thomas Abraham
On 19 September 2012 12:35, Chris Ball c...@laptop.org wrote: Hi Thomas, On Wed, Sep 19 2012, Thomas Abraham wrote: Hi Jaehoon, Seungwon, All the changes you have suggested for this patch series has been completed. If you could ack this series, it would be great. Thanks, Thomas. Hi

Re: [PATCH 3/3] mmc: sdhci-s3c: Add clk_(enable/disable) in runtime suspend/resume

2012-09-19 Thread Chris Ball
Hi, On Wed, Sep 19 2012, Jaehoon Chung wrote: Looks good to me. Acked-by: Jaehoon Chung jh80.ch...@samsung.com Thanks, pushed to mmc-next for 3.7. (The patch didn't merge cleanly so I applied it by hand; let me know if anything looks wrong.) - Chris. -- Chris Ball c...@laptop.org

Re: [PATCH] video: drm: Add match table for drm platform device

2012-09-19 Thread Paul Menzel
Dear Leela, thank you for your patch. Am Mittwoch, den 19.09.2012, 00:05 +0530 schrieb Leela Krishna Amudala: This patch adds match table for drm platform device. Please drop that line as it is the same as in the subject line. It would be better, 1. if you explain for what this will be

Re: [PATCH v3] ARM: EXYNOS: Add MFC device tree support

2012-09-19 Thread Karol Lewandowski
On 09/14/2012 05:38 PM, Arun Kumar K wrote: This patch adds device tree entry for MFC v6 in the Exynos5 SoC. Makes the required changes in the clock files and adds MFC to the DT device list. Hi! Thanks for working on this patch. Please allow me to add few comments. diff --git

Re: [PATCH 4/5] ARM: EXYNOS: Add support for Exynos secure firmware

2012-09-19 Thread Tomasz Figa
Hi Olof, On Saturday 15 of September 2012 17:44:55 Olof Johansson wrote: On Thu, Sep 13, 2012 at 10:13:37AM +0200, Tomasz Figa wrote: +static void __iomem *exynos_cpu_boot_reg(int cpu) +{ + return S5P_VA_SYSRAM_NS + 0x1c + 4*cpu; +} This communication area in sysram should probably

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Tomasz Figa
Hi Chris, On Wednesday 19 of September 2012 01:42:01 Chris Ball wrote: On Tue, Sep 04 2012, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate correctly. Is there a reason we

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Chris Ball
Hi Tomasz, On Wed, Sep 19 2012, Tomasz Figa wrote: Hi Chris, On Wednesday 19 of September 2012 01:42:01 Chris Ball wrote: On Tue, Sep 04 2012, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Chris Ball
Hi, On Wed, Sep 19 2012, Tomasz Figa wrote: We could just check if the regulator provides the capability to change the voltage. I don't see any direct way of querying the regulator for provided capabilities (correct me if I'm just blind), but calling regulator_count_voltages() on the

[GIT PULL 2/7] Samsung gpio for v3.7

2012-09-19 Thread Kukjin Kim
Hi Arnd, Olof This is for supporting DT gpio for Samsung S3C24XX. Since there are many changes for gpio-samsung in my tree, this has been included in my tree with Linus' agreement. If any problems, please kindly let me know. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com,

[GIT PULL 3/7] Samsung pinctrl for v3.7

2012-09-19 Thread Kukjin Kim
Hi Arnd, Olof This branch is for supporting pinctrl for Samsung EXYNOS. Now this can support EXYNOS4210 and other EXYNOS SoCs such as EXYNOS4X12 will be supported next time. If any problems, please kindly let me know. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior

[GIT PULL 6/7] Samsung cleanup fimd header for v3.7

2012-09-19 Thread Kukjin Kim
Hi Arnd, Olof. This is for moving header file is related to fimd from platform to include/video. Since this touches many Samsung stuff, it is included in samsung tree and I requested to pull into Florian's tree and he already agreed. So its name is 'v3.7-for-florian'. If any problems, please

[GIT PULL 7/7] Samsung for v3.7

2012-09-19 Thread Kukjin Kim
Hi Arnd, Olof This is for updating s3c6400_defconfig to build every s3c64xx stuff. This helps to know at least building error before merging them. Note that I'm still sorting out some Samsung stuff for v3.7 and it will be sent to you soon. Thanks. Best regards, Kgene. -- Kukjin Kim

RE: [PATCH V5] ARM: EXYNOS5: Add bus clock for FIMD

2012-09-19 Thread Kukjin Kim
Leela Krishna Amudala wrote: This patch adds the bus clock for FIMD and changes the device name for lcd clock Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/mach-exynos/clock-exynos5.c | 32 ++ -- 1 files changed, 22 insertions(+),

RE: [PATCH 2/2] ARM: SAMSUNG: Add check for NULL in clock interface

2012-09-19 Thread Kukjin Kim
Thomas Abraham wrote: On 6 September 2012 19:55, Chander Kashyap chander.kash...@linaro.org wrote: The clock instance parameter in Samsung clock interface is not being checked for NULL pointers. Add checks for NULL pointers. Signed-off-by: Chander Kashyap chander.kash...@linaro.org

RE: [PATCH 1/2] ARM: Exynos4: Put PCM, Slimbus, Spdif clocks to off state

2012-09-19 Thread Kukjin Kim
Thomas Abraham wrote: On 6 September 2012 19:46, Chander Kashyap chander.kash...@linaro.org wrote: The clocks for PCM, Slimbus, Spdif added to off list in order to turn them off at boot time. Signed-off-by: Chander Kashyap chander.kash...@linaro.org ---

RE: [PATCH v3] ARM: S3C24XX: Add WIZnet W5300E01-ARM board support

2012-09-19 Thread Kukjin Kim
Taehun Kim wrote: - The gpio routines are changed to use the gpio_request() functions from comments of Vasily and Sylwester. - The mistake of adding a character by my email client automatically is fixed. Please review this patch and apply it if do not have any problems. Taehun,

RE: [PATCH 1/2] ARM: Exynos4: Put PCM, Slimbus, Spdif clocks to off state

2012-09-19 Thread Sangbeom Kim
Hi! On Thursday, Sep 20, 2012 at 08:24 AM, Kukjin Kim wrote: The clocks for PCM, Slimbus, Spdif added to off list in order to turn them off at boot time. Signed-off-by: Chander Kashyap chander.kash...@linaro.org Acked-by: Thomas Abraham thomas.abra...@linaro.org Acked-by: Sangbeom

RE: [PATCH 1/2] ARM: Exynos4: Put PCM, Slimbus, Spdif clocks to off state

2012-09-19 Thread Kukjin Kim
Sangbeom Kim wrote: Hi! On Thursday, Sep 20, 2012 at 08:24 AM, Kukjin Kim wrote: The clocks for PCM, Slimbus, Spdif added to off list in order to turn them off at boot time. Signed-off-by: Chander Kashyap chander.kash...@linaro.org Acked-by: Thomas Abraham

RE: [PATCH] ARM: EXYNOS: no duplicate mask/unmask in eint0_15

2012-09-19 Thread Kukjin Kim
Doug Anderson wrote: On Thu, Sep 6, 2012 at 8:21 AM, Daniel Kurtz djku...@chromium.org wrote: chained_irq_enter/exit() already maskack/unmask the chained interrupt. There is no need to also explicitly do it in the handler. Signed-off-by: Daniel Kurtz djku...@chromium.org ---

Re: [PATCH V4] ARM: EXYNOS5: Add bus clock and set parent clock for FIMD

2012-09-19 Thread Jingoo Han
On Monday, September 17, 2012 7:37 PM Kukjin Kim wrote Jingoo Han wrote: On Monday, September 17, 2012 11:43 PM Leela Krishna Amudala wrote This patch adds the bus clock for FIMD and changes the device name for lcd clock also sets mout_mpll_user as parent clock to fimd

Re: [PATCH V5] ARM: EXYNOS5: Add bus clock for FIMD

2012-09-19 Thread Jingoo Han
On Tuesday, September 18, 2012 11:25 PM Leela Krishna Amudala wrote This patch adds the bus clock for FIMD and changes the device name for lcd clock Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com ---

Re: [PATCH v6 6/9] mmc: dw_mmc: add device tree support

2012-09-19 Thread Thomas Abraham
On 19 September 2012 19:09, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: +#ifdef CONFIG_OF +/* given a slot id, find out the device node representing that slot */ +static struct device_node

Re: [PATCH v6 8/9] mmc: dw_mmc: add support for implementation specific callbacks

2012-09-19 Thread Thomas Abraham
On 19 September 2012 19:10, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: -int dw_mci_pltfm_register(struct platform_device *pdev) +int dw_mci_pltfm_register(struct platform_device *pdev, +

Re: [PATCH v6 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

2012-09-19 Thread Thomas Abraham
On 19 September 2012 19:12, Seungwon Jeon tgih@samsung.com wrote: On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org wrote: +int dw_mci_exynos_probe(struct platform_device *pdev) +{ + struct dw_mci_drv_data *drv_data; + const struct of_device_id *match; +

Re: [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation

2012-09-19 Thread Thomas Abraham
On 19 September 2012 19:09, Seungwon Jeon tgih@samsung.com wrote: Hi Thomas, On Wed, Sep 19 2012, Thomas Abraham wrote: Hi Jaehoon, Seungwon, All the changes you have suggested for this patch series has been completed. If you could ack this series, it would be great. Thanks,

Re: [PATCH] ARM: dts: use uart2 for console on smdkv310 and smdk5250

2012-09-19 Thread Thomas Abraham
On 20 September 2012 04:48, Kukjin Kim kg...@kernel.org wrote: Thomas Abraham wrote: On 17 September 2012 17:16, Kukjin Kim kgene@samsung.com wrote: Cc: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Kukjin Kim kgene@samsung.com ---

Re: [PATCH 2/3] ARM: EXYNOS: add device tree based discovery support for FIMD

2012-09-19 Thread Jingoo Han
On Wednesday, September 19, 2012 3:22 AM Leela Krishna Amudala wrote This patch adds support for device tree based discovery for Samsung's display controller. Adds DRM-Fimd plat data for smdk5250 evt1 to the corresponding dts file Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com

Re: [PATCH 2/3] ARM: EXYNOS: add device tree based discovery support for FIMD

2012-09-19 Thread Leela Krishna Amudala
Hi Jingoo Han, On Thu, Sep 20, 2012 at 10:32 AM, Jingoo Han jg1@samsung.com wrote: On Wednesday, September 19, 2012 3:22 AM Leela Krishna Amudala wrote This patch adds support for device tree based discovery for Samsung's display controller. Adds DRM-Fimd plat data for smdk5250 evt1 to

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Jaehoon Chung
On 09/19/2012 11:39 PM, Chris Ball wrote: Hi, On Wed, Sep 19 2012, Jaehoon Chung wrote: On Wed, Sep 19 2012, Tomasz Figa wrote: We could just check if the regulator provides the capability to change the voltage. I don't see any direct way of querying the regulator for provided