Hi Chris Ulf,
I hope you find this patch for next.
Thanks,
Seungwon Jeon
On Wed, May 21, 2014, Seungwon Jeon wrote:
On Wed, May 21, 2014, Doug Anderson wrote:
If we happened to get a data error at just the wrong time the dw_mmc
driver could get into a state where it would never complete
-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
v2: Add Generic DMA support
per the documentation, move interrupt clear before wait
make the test for DMA host-use_dma rather than host-using_dma
add proper return values (although it appears no caller checks)
v3
On Fri, July 11, 2014, Sonny Rao wrote:
On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon tgih@samsung.com wrote:
Hi Sonny,
I have missed this patch.
You finally choose to take extra interrupt handling.
If it is not harm, it's fine.
Hi, thanks for coming back to it. Based on my
+++
arch/arm/boot/dts/socfpga_vt.dts |9 +++
drivers/mmc/host/dw_mmc.c | 12 -
21 files changed, 84 insertions(+), 204 deletions(-)
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
--
To unsubscribe from
taking whole patch?
And I hope that it is applied for 3.16-rcX fix.
(Also, 3rd patch is close to fix patch.)
Kukjin,
Is it fine to be taken in Ulf's?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord
)) {
+ if (!dw_mci_reset(host)) {
Do you have any reason to use dw_mci_reset() unlike doing on probing?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Thu, July 10, 2014, Ulf Hansson wrote:
On 10 July 2014 13:53, Seungwon Jeon tgih@samsung.com wrote:
On Thu, July 10, 2014, Ulf Hansson wrote:
On 10 July 2014 11:40, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi, Ulf.
On 07/10/2014 06:15 PM, Ulf Hansson wrote:
On 10 July
On Tue, July 08, 2014,Yuvaraj Kumar wrote:
On Mon, Jul 7, 2014 at 10:53 AM, Seungwon Jeon tgih@samsung.com wrote:
On Fri, July 04, 2014, Seungwon Jeon wrote:
On Tue, July 01, 2014. Yuvaraj Kumar wrote:
On Fri, Jun 27, 2014 at 4:48 PM, Seungwon Jeon tgih@samsung.com
wrote
{
- reg = 0;
- bus-width = 4;
- };
+ bus-width = 8;
4 is correct?
+ cap-mmc-highspeed;
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message
DW_MCI_SLOT_QUIRK_NO_WRITE_PROTECT)
It would be better to use host-quirks instead of brd-quirks
It's finally updated with host-pdata-quirks on probing.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More
On Fri, July 04, 2014, Seungwon Jeon wrote:
On Tue, July 01, 2014. Yuvaraj Kumar wrote:
On Fri, Jun 27, 2014 at 4:48 PM, Seungwon Jeon tgih@samsung.com wrote:
Hi Yuvaraj,
On Fri, June 27, 2014, Yuvaraj Kumar wrote:
On Thu, Jun 26, 2014 at 10:20 PM, Doug Anderson diand
On Tue, July 01, 2014. Yuvaraj Kumar wrote:
On Fri, Jun 27, 2014 at 4:48 PM, Seungwon Jeon tgih@samsung.com wrote:
Hi Yuvaraj,
On Fri, June 27, 2014, Yuvaraj Kumar wrote:
On Thu, Jun 26, 2014 at 10:20 PM, Doug Anderson diand...@chromium.org
wrote:
Seungwon,
On Thu, Jun 26
Hi Yuvaraj,
On Fri, June 27, 2014, Yuvaraj Kumar wrote:
On Thu, Jun 26, 2014 at 10:20 PM, Doug Anderson diand...@chromium.org wrote:
Seungwon,
On Thu, Jun 26, 2014 at 3:41 AM, Seungwon Jeon tgih@samsung.com wrote:
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed
On Fri, June 27, 2014, Doug Anderson wrote:
Seungwon,
On Thu, Jun 26, 2014 at 3:30 AM, Seungwon Jeon tgih@samsung.com wrote:
Hi Doug,
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com
wrote
Hi Doug,
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com wrote:
+ case MMC_POWER_ON:
+ if (!IS_ERR(mmc-supply.vqmmc)
+ !test_bit(DW_MMC_IO_POWERED,
slot
On Thu, June 26, 2014, Doug Anderson wrote:
Seungwon,
On Wed, Jun 25, 2014 at 6:08 AM, Seungwon Jeon tgih@samsung.com wrote:
On Mon, June 23, 2014, Yuvaraj Kumar C D wrote:
Subject: [PATCH 3/3] mmc: dw_mmc: Support voltage changes
From: Doug Anderson diand...@chromium.org
-vmmc);
-
Just to check: have you tested suspend/resume with the various
combinations of keep-power-in-suspend and non-removable with your
patch. I remember some of the logic being a bit complicated...
Please check it and give some updates/result in next version.
Thanks,
Seungwon Jeon
= ~SDMMC_INT_VOLT_SWITCH;
+ dw_mci_cmd_interrupt(host,
+ pending | SDMMC_INT_CMD_DONE);
Artificially adding SDMMC_INT_CMD_DONE to pending is needed to complete cmd
handling?
Is there any reason?
Thanks,
Seungwon Jeon
mmc bindings instead of driver-specific,
host driver shall not need old one.
I think we can remove it.
Thanks,
Seungwon Jeon
If i'm wrong, let me know, plz.
Thank you for sharing the information.
Best Regards,
Jaehoon Chung
Kind regards
Ulf Hansson
--
To unsubscribe from
On Wed, May 28, 2014, Jaehoon Chung wrote:
dw-mmc controller has the multiple slot.
Then it needs to parse the property for each slot.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changelog V3:
- Fix
On Wed, May 28, 2014, Jaehoon Chung wrote:
Removed the parser for supports-highspeed.
It can be parsed with cap-mmc-highsped or cap-sd-highspeed at
mmc_of_parse().
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Tahnks,
Seungwon Jeon
be replaced to cap-sd/mmc-highspeed.
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Looks good to me.
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changelog V3:
- Merge [PATCH 2/5] mmc: dw_mmc: rmove the supports-highspeed
property
Changelog V2
instead of the
device node.
Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com
Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changelog V2:
- Fix the typo.
drivers/mmc/core/host.c | 13
].quirk, NULL))
- pdata-quirks |= of_quirks[idx].id;
-
Same as above.
Thanks,
Seungwon Jeon
if (of_property_read_u32(np, fifo-depth, pdata-fifo_depth))
dev_info(dev, fifo-depth property not found, using
value of FIFOTH
Can this be merged with your another patch, [PATCH 2/5] mmc: dw_mmc: remove
the supports-highspeed property.?
On Mon, May 26, 2014, Jaehoon Chung wrote:
dw-mmc controller can be support the multiple slot.
can support, it would be better to correct the above message.
Thanks,
Seungwon Jeon
So
On Wed, May 21, 2014, Doug Anderson wrote:
Seungwon,
On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon tgih@samsung.com wrote:
+ } else {
+ /*
+* If we don't have a command
complete now
procedure
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changes in v2:
- Removed TODO
- Set cmd to NULL before calling dw_mci_request_end()
drivers/mmc/host/dw_mmc.c | 46 ++
1 file changed, 46 insertions(+)
diff --git
On Sat, May 17, 2014, Doug Anderson wrote:
Seungwon,
On Thu, May 15, 2014 at 6:46 PM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, May 14, 2014, Doug Anderson wrote:
Seungwon,
On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon tgih@samsung.com
wrote:
Hi Doug,
On Tue
On Sat, May 17, 2014, Sonny Rao wrote:
On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon tgih@samsung.com wrote:
On Tuesday, May 13, Sonny Rao wrote:
On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com
wrote:
As I mentioned in previous version, you put all reset stuff
On Tue, May 13, 2014, Seungwon Jeon wrote:
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
Seungwon,
On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon tgih@samsung.com wrote:
On Fri, May 09, 2014, Sonny Rao wrote:
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar yuvaraj
On Wed, May 14, 2014, Doug Anderson wrote:
Seungwon,
On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon tgih@samsung.com wrote:
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
Seungwon,
On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon tgih@samsung.com
wrote:
On Fri, May
On Tuesday, May 13, Sonny Rao wrote:
On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon tgih@samsung.com wrote:
As I mentioned in previous version, you put all reset stuff in existing
fifo_reset function.
Although databook mentions ciu_reset case for SBE error, it's not obvious
when
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
Seungwon,
On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon tgih@samsung.com wrote:
On Fri, May 09, 2014, Sonny Rao wrote:
On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote:
Any comments on this patch
is needed?
Thanks,
Seungwon Jeon
+ return false;
+ }
+
+#ifdef CONFIG_MMC_DW_IDMAC
+ /* It is also recommended that we reset and reprogram idmac */
+ dw_mci_idmac_reset(host);
+#endif
+
+ /* After a CTRL reset we need to have CIU set clock registers
Hi Sonny,
Can you separate procedure?
Reset all are handled in fifo-reset.
And ciu reset is always needed for error handling?
Thanks,
Seungwon Jeon
On Sat, May 10, 2014, Sonny Rao wrote:
On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
Hi, Sonny.
You can
)) {
+ dw_mci_request_end(host, mrq);
+ goto unlock;
+ }
Can you explain what happens above?
What is it for?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
On Tue, April 22, 2014, Tushar Behera wrote:
On 22 April 2014 07:48, Kukjin Kim kgene@samsung.com wrote:
Seungwon Jeon wrote:
+ Javi Merino and Tushar Behera
This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
for arndale-octa board). If MDMA1 region
anymore.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
Note: This patch comes from [PATCH] ARM: dts: disable MDMA1 node for smdk5420
board
arch/arm/boot/dts/exynos5420-arndale-octa.dts | 12
arch/arm/boot/dts/exynos5420.dtsi |7 +++
2 files changed, 7
This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
for arndale-octa board). If MDMA1 region is configured with secure mode,
it makes the boot failure with the following.
Unhandled fault: imprecise external abort (0x1406) at 0x
Signed-off-by: Seungwon Jeon tgih
Hi Jaehoon,
On Mon, April 14, 2014, Jaehoon Chung wrote:
Hi, Seungwon.
On 03/26/2014 08:31 PM, Seungwon Jeon wrote:
ciu_div may not be common value for all speed mode.
So, it needs to be attached to CLKSEL timing.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc
Add checking whether the clock is valid.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index a67e784
that the performance
is improved with the increased the max_blk_count.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 3a6721e..aeb38f9 100644
Move some parts related to definition to header file.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 46 ---
drivers/mmc/host/dw_mmc-exynos.h | 55 ++
2 files changed, 61 insertions
As dw-mshc-ciu-div is strongly close to timing property,
it is merged with each timing property.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 12 +---
arch/arm/boot/dts/exynos4412-odroidx.dts |5 ++---
arch/arm
HS400 timing value set is added for SMDK5420.
And GPIO line for RCLK should be pull-down state.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |6 ++
arch/arm/boot/dts/exynos5420-pinctrl.dtsi |7 +++
arch/arm/boot
On Mon, March 24, 2014, Jaehoon Chung wrote:
Hi, Seungwon.
On 03/21/2014 11:03 PM, Seungwon Jeon wrote:
Adds checking whether the clock is valid.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 14 +++---
1 files changed, 11
On Mon, March 24, 2014, Jaehoon Chung wrote:
Hi, Seungwon.
On 03/21/2014 11:03 PM, Seungwon Jeon wrote:
Moves some parts related to definition to header file
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 46
This patch-set includes several driver's updates.
Specially, HS400 mode is enabled for eMMC5.0 spec.
Seungwon Jeon (7):
mmc: dw_mmc: fix the max_blk_count in IDMAC
mmc: dw_mmc: exynos: don't use if clock isn't available
mmc: dw_mmc: exynos: move definitions to header file
mmc: dw_mmc
that the performance
is improved with the increased the max_blk_count.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 3a6721e..aeb38f9 100644
Adds checking whether the clock is valid.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index
HS400 timing value set is added for SMDK5420.
And GPIO line for RCLK should be pull-down state.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |6 ++
arch/arm/boot/dts/exynos5420-pinctrl.dtsi |7 +++
arch/arm/boot
Implements HS400 support for Exynos's host driver.
And this patch includes some updates as new mode is added.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 140 +++---
drivers/mmc/host/dw_mmc-exynos.h | 14
As dw-mshc-ciu-div is strongly close to timing property,
it is merged with each timing property.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 12 +---
arch/arm/boot/dts/exynos4412-odroidx.dts |5 ++---
arch/arm
ciu_div may not be common value for all speed mode.
So, it needs to be attached to CLKSEL timing.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/host/dw_mmc-exynos.c | 75 ++
drivers/mmc/host/dw_mmc-exynos.h |1 +
2 files changed, 53
Clock lookup information is required as driver can manipulate
clock rate properly.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
arch/arm/boot/dts/exynos4412.dtsi |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi
b/arch/arm/boot
-name = biu, ciu;
Thanks,
Seungwon Jeon
于 2013年11月26日 12:32, Jaehoon Chung 写道:
Hi, Randy,
It seems a problem that controller didn't find the clock source.
Also you can see the below message. Did you check the clock
source?
[1.125000] s3c-sdhci 1255.sdhci: failed to get io
On Mon, November 25, 2013, Olof Johansson wrote:
Hi,
On Sun, Nov 24, 2013 at 4:07 AM, randy lxr1...@hotmail.com wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
After pull the merge of 3.13-rc1, the dw_mmc-exynos will make the boot
stock.In 3.13, it is just stocked udev in 3.13
, this series looks good to me.
But direct access for SMU concerning (4/4, exynos: configure SMU in
exynos5420')
will be removed in driver before long.
I will sort your patches with the pending others.
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
Best Regards.
Jaehoon
|
+ DWMCI_MPSCTRL_NON_SECURE_WRITE_BIT);
Yuvaraj,
Just one thing to check.
ch#0 and #1 of three hosts are only valid for SMU control.
Did you consider #2 host?
It seems not.
Thanks,
Seungwon Jeon
+ }
+
return 0;
}
@@ -107,6 +135,7 @@ static int dw_mci_exynos_resume(struct device *dev
On Thu, August 29, 2013, Alim Akhtar wrote:
Hi Seungwon,
On Thu, Aug 29, 2013 at 1:53 PM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, August 28, 2013, Yuvaraj Kumar C D wrote:
Exynos5420 Mobile Storage Host controller has Security Management Unit
(SMU) for channel 0 and channel 1
Yuvaraj Kumar wrote:
On Thu, Aug 29, 2013 at 3:14 PM, Seungwon Jeon tgih@samsung.com wrote:
On Thu, August 29, 2013, Alim Akhtar wrote:
Hi Seungwon,
On Thu, Aug 29, 2013 at 1:53 PM, Seungwon Jeon tgih@samsung.com
wrote:
On Wed, August 28, 2013, Yuvaraj Kumar C D wrote
code to dw_mci_socfpga_parse_dt.
We can use the dw_mci_socfpga_priv_init to do some actual platform
specific initialisation.
This patch is compile tested only.
CC'ed Dinh Nguyen
Thanks,
Seungwon Jeon
changes since V2: none
Signed-off-by: Yuvaraj Kumar C D yuvaraj...@samsung.com
On Thu, August 29, 2013, Tomasz Figa wrote:
Hi Seungwon,
On Thursday 29 of August 2013 19:36:28 Seungwon Jeon wrote:
Yuvaraj Kumar wrote:
On Thu, Aug 29, 2013 at 3:14 PM, Seungwon Jeon tgih@samsung.com
wrote:
On Thu, August 29, 2013, Alim Akhtar wrote:
Hi Seungwon
Hi Doug,
Do you have any update for this series?
Please let me know.
Thanks,
Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote:
This series of patches addresses some suspend/resume problems with
dw_mmc on exynos platforms, espeically exynos5420. Since
suspend/resume is not fully
is not clear.
Thanks,
Seungwon Jeon
+ */
+static int dw_mci_exynos_suspend(struct device *dev)
+{
+ struct dw_mci *host = dev_get_drvdata(dev);
+
+ return dw_mci_suspend(host);
+}
+
+static int dw_mci_exynos_resume(struct device *dev)
+{
+ struct dw_mci *host = dev_get_drvdata
with dw_mci_pltfm* just now.
But specific code for exynos would be added soon.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
(At least this is the way I see it, though)
As Exynos's host does so, other hosts which are introduced in Linux seems use
one card per host.
If it's really not found now, I could agree on this topic.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
On Thu, July 11, 2013, Doug Anderson wrote:
Seungwon,
On Wed, Jul 10, 2013 at 7:54 AM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, July 10, 2013, Doug Anderson wrote:
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up
looping around forever. This has been seen
off
+ * constantly.
+ */
As I know this bit is auto-cleared.
Did you find the cause of this problem?
How about your GPIO setting in sleep?
Currently, we don't know why the problem is happened.
At least, we should make it clear.
Thanks,
Seungwon Jeon
+
+static int dw_mci_exynos_resume_noirq
on mmc_alloc_host.
mmc_alloc_host is called prior to regulator_enable.
So, if regulator_enable is failed, call of mmc_free_host makes sense.
Thanks,
Seungwon Jeon
-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-mmc in
the body of a message to majord...@vger.kernel.org
More
On Friday, April 05, 2013, Thomas Abraham wrote:
With device core now able to setup the default pin configuration,
the pin configuration code based on the deprecated Samsung specific
gpio bindings is removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Seungwon Jeon
: dw_mmc: Add MSHC compatible for Exynos4412
...just to avoid the simple merge conflict when applying?
Otherwise everything here looks great...
-Doug
Thomas,
It's a conflict to merge. Please do rebase the patch.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe
the purpose, it would be good to remove.
And, could you change commit prefix for consistency?
dwmmc - dw_mmc
Thanks,
Seungwon Jeon
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
drivers/mmc/host/dw_mmc-exynos.c | 38
--
1 files changed, 0
Doug, Thanks to work.
Looks good to me with other patches.
Acked-by: Seungwon Jeon tgih@samsung.com
On Friday, November 30, 2012, Doug Anderson wrote:
The disable-wp property is used to specify that a given SD card slot
doesn't have a concept of write protect. This eliminates the need
.
Thanks,
Seungwon Jeon
--
1.7.7.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Doug,
On Thursday, November 29, 2012, Doug Anderson wrote:
Seungwon,
Thanks for the review. See below for comments. If you'd like me to
respin then please let me know. Otherwise I look forward to your ack.
On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon tgih@samsung.com wrote
/mach-exynos/include/mach/dwmci.h
Hi Thomas,
The following parts are remained. Also, no used code.
Could you check it?
./plat-samsung/include/plat/devs.h:126:extern struct platform_device
exynos4_device_dwmci;
./Kconfig:111:config EXYNOS4_DEV_DWMCI
Thanks,
Seungwon Jeon
diff --git a/arch/arm
Hi,
wp-gpios has been implemented in dw_mmc-exynos.c
It can be reused for EXYNOS platform? We need to modify some though.
Thanks,
Seungwon Jeon
On Thursday, November 22, 2012, Doug Anderson diand...@chromium.org wrote:
On some SoCs (like exynos5250) you need to use an external GPIO for
write
On Thursday, November 22, 2012, Doug Anderson diand...@chromium.org wrote:
On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon tgih@samsung.com wrote:
Hi,
wp-gpios has been implemented in dw_mmc-exynos.c
It can be reused for EXYNOS platform? We need to modify some though.
Yup, I've seen
.
As there also could be other Samsung platforms affected that use the ext-gpio
code, it's probably right to revert it for now. Or you see a easy fix :-) .
Hi,
I think clock is disabled during bus transaction.
I'll send a patch. Could you test it?
Thanks.
Seungwon Jeon
Heiko
Best
patch would be good, please.
(I'd normally take an updated patch but Stephen Rothwell's asked for
people to hold off rebasing now that -rc7 is out, which is reasonable.)
Thomas,
Is there any work for fix?
Thanks,
Seungwon Jeon
Thanks,
- Chris.
--
Chris Ball c...@laptop.org http
On Thursday, September 20, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
On 19 September 2012 19:12, Seungwon Jeon tgih@samsung.com wrote:
On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
+int dw_mci_exynos_probe(struct platform_device *pdev
On Thursday, September 20, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
On 19 September 2012 19:09, Seungwon Jeon tgih@samsung.com wrote:
On Tuesday, September 18, 2012, Thomas Abraham thomas.abra...@linaro.org
wrote:
+#ifdef CONFIG_OF
+/* given a slot id, find out
On Friday, September 07, 2012, Thomas Abraham thomas.abra...@linaro.org wrote:
Hi Seungwon,
Thanks for reviewing the patch.
On 5 September 2012 16:13, Seungwon Jeon tgih@samsung.com wrote:
On Wednesday, September 05, 2012, Thomas Abraham
thomas.abra...@linaro.org wrote:
Version 6
)
+{
+ struct dw_mci_exynos_priv_data *priv = host-priv;
+ struct device_node *np = host-dev-of_node;
+ u32 timing[3];
u32 timing[2] is enough.
Thanks,
Seungwon Jeon
+ u32 div = 0;
+ int ret;
+
+ of_property_read_u32(np, samsung,dw-mshc-ciu-div, div);
+ priv-ciu_div
;
As adding dw-mshc-ciu-div, third field of dw-mshc-ddr-timing can be removed.
Thanks,
Seungwon Jeon
+
+ slot@0 {
+ reg = 0;
+ bus-width = 8;
+ gpios = gpc0 0 2 0 3, gpc0 1 2 0 3,
+ gpc1 0 2 3 3, gpc1
are board-specific timing
values.
So, these values can't be used commonly. It has been already discussed.
If this property is empty, returning error with message will be fine.
Currently just 0 is always returned.
Thanks,
Seungwon Jeon
+}
+
+static int dw_mci_exynos_setup_bus(struct dw_mci *host
: dw_mmc: lookup for optional biu and
ciu clocks
Could I get your opinion?
Thanks,
Seungwon Jeon
+
+ if (!host-bus_hz) {
dev_err(host-dev,
Platform data must supply bus speed\n);
- return -ENODEV;
+ ret = -ENODEV;
+ goto
On Tuesday, August 28, 2012 Thomas Abraham thomas.abra...@linaro.org wrote:
Hi Seungwon,
On 28 August 2012 12:36, Seungwon Jeon tgih@samsung.com wrote:
Hi Thomas,
Thank you for your effort.
Some reviews seems like to be omitted. Please check more.
On Sunday, August 26, 2012
July 23, 2012, Thomas Abraham thomas.abra...@linaro.org wrote:
On 20 July 2012 16:08, Seungwon Jeon tgih@samsung.com wrote:
July 20, 2012, Thomas Abraham thomas.abra...@linaro.org wrote:
On 19 July 2012 09:21, Seungwon Jeon tgih@samsung.com wrote:
[...]
+static unsigned long
input rate for cclk_in of mshc.
Host of samsung soc doesn't use input clock from system directly.
As you have introduced CLKSEL in your another patch, input clock can be changed
prior to cclk_in.
For non-samsung host, we don't need to consider this with generic way?
Thanks,
Seungwon Jeon
SDMMC_CLKSEL_GET_DIVRATIO(x) x) 24) 0x7) + 1)
+#define SDMMC_CLKSEL_GET_SELCLK_DRV(x) (((x) 16) 0x7)
+
Is this patch considered only for exynos5250?
In case of exynos4210, the number of bits is different.
If upper macros is backward-compatible, it would be better.
Best regards,
Seungwon Jeon
Hi Thomas Abraham,
How about separating the variant for Samsung Exynos.
Like dw_mmc-exynos.c
Thanks,
Seungwon Jeon.
Thomas Abraham wrote:
The instantiation of the Synopsis Designware controller on Exynos5250
include extension for SDR and DDR specific tx/rx phase shift timing
and CIU internal
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 02/29/2012 03:33 PM, Seungwon Jeon wrote:
Hi Jaehoon,
Thank you for the patch.
Could you check comments below?
Jaehoon Chung jh80.ch...@samsung.com wrote:
This patch is change to use the sdhci-pltfm.c
Signed-off-by: Jaehoon Chung
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 03/02/2012 11:15 AM, Seungwon Jeon wrote:
Jaehoon Chung jh80.ch...@samsung.com wrote:
On 02/29/2012 03:33 PM, Seungwon Jeon wrote:
Hi Jaehoon,
Thank you for the patch.
Could you check comments below?
Jaehoon Chung jh80.ch
to
SDHCI_QUIRK_NONSTANDARD_CLOCK.
mmc: sdhci-s3c: Support controllers with no internal clock
divider(253e0a7c3dc4b)
mmc: sdhci-s3c: Remove usage of clk_type member in platform
data(b77d777eeb0a086)
Thanks,
Seungwon Jeon.
+ sc-cur_clk = ptr;
clk_enable(clk);
@@ -627,63
This patch-set fixed the cache control for eMMC4.5
Changes in v2:
- clear the cache_ctrl flag for a failure(enabling cache)
Seungwon Jeon (2):
mmc: core: Separate the timeout value for cache-ctrl
mmc: core: Add claiming a host during mmc_cache_ctrl
drivers/mmc/core/core.c
Turning the cache off implies flushing cache which doesn't define
maximum timeout unlike cache-on. This patch will apply the generic
CMD6 timeout only for cache-on. Additionally the kernel message is
added for checking failure case of cache-on.
Signed-off-by: Seungwon Jeon tgih@samsung.com
While calling mmc_cache_ctrl() a host is not claimed. This patch
adds the mmc_try_claim_host() for quick response in suspend.
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/core/core.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc
Maya Erez wrote:
Maya Erez wrote:
On Wed, Nov 2, 2011 at 1:33 PM, Seungwon Jeon
tgih@samsung.com
wrote:
@@ -980,12 +988,67 @@ static int mmc_blk_err_check(struct
mmc_card
*card,
if (!brq-data.bytes_xfered)
return MMC_BLK_RETRY
1 - 100 of 154 matches
Mail list logo
