Re: [PATCH v4 7/8] ARM: Exynos: switch to using generic cpufreq-cpu0 driver

2014-07-07 Thread Viresh Kumar
Hi Arnd/Rob/Mike et al, We didn't conclude anything out of this thread and so kicking it again as we need to close bindings to support cpufreq-cpu0 better for platforms not sharing clock lines across all CPUs. https://lkml.org/lkml/2014/7/1/358 On 14 May 2014 20:03, Arnd Bergmann a...@arndb.de

Re: [PATCH v6 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-06-18 Thread Viresh Kumar
driver for these platforms. This series also enabled cpufreq support for Exynos5420 using arm_big_little cpufreq driver. cpuf...@vger.kernel.org list is deprecated now: dec102a, use linux-pm instead. For patch 5 and 6: Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from

Re: [PATCH 0/4] cpufreq: Use cpufreq-cpu0 driver for Exynos3250

2014-06-13 Thread Viresh Kumar
cpuf...@vger.kernel.org is dead now. Anyway you should be using linux-pm instead. On 13 June 2014 11:38, Chanwoo Choi cw00.c...@samsung.com wrote: This patchset use cpufreq-cpu0 driver to support Exynos3250 cpufreq. So, this patchset is based on following patchset[1] by Thomas Abraham. [1]

Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP

2014-06-08 Thread Viresh Kumar
-omap2/Kconfig| 1 - arch/arm/mach-shmobile/Kconfig | 2 -- arch/arm/mach-vexpress/Kconfig | 1 - arch/arm/mach-zynq/Kconfig | 1 - drivers/devfreq/Kconfig| 1 - kernel/power/Kconfig | 3 --- 10 files changed, 15 deletions(-) Reviewed-by: Viresh Kumar viresh.ku

Re: [PATCH v4 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency

2014-05-26 Thread Viresh Kumar
= cpu; + compatible = arm,cortex-a9; + reg = 1; + }; + }; Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v5 1/7] cpufreq: cpufreq-cpu0: allow use of optional boost mode frequencies

2014-05-26 Thread Viresh Kumar
On 23 May 2014 19:57, Thomas Abraham thomas...@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Lookup for the optional boost-frequency property in cpu0 node and if available, enable support for boost mode frequencies. The frequencies usable in boost mode are determined while

Re: [PATCH v5 6/7] ARM: Exynos: switch to using generic cpufreq-cpu0 driver

2014-05-26 Thread Viresh Kumar
--- arch/arm/mach-exynos/exynos.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v5 7/7] cpufreq: exynos: remove all exynos specific cpufreq driver support

2014-05-26 Thread Viresh Kumar
100644 drivers/cpufreq/exynos-cpufreq.c delete mode 100644 drivers/cpufreq/exynos-cpufreq.h delete mode 100644 drivers/cpufreq/exynos4210-cpufreq.c delete mode 100644 drivers/cpufreq/exynos4x12-cpufreq.c delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c Acked-by: Viresh Kumar

[BUG] Compile error with THUMB2

2014-05-26 Thread Viresh Kumar
Hi Guys, I didn't had time to put in an effort on this but here is a problem reported by Santosh. See if somebody can get this fixed.. arch/arm/mach-exynos/sleep.S: Assembler messages: arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address calculation (value = 0x0004) Its

Re: [PATCH v2] cpufreq: exynos: Fix driver compilation with ARCH_MULTIPLATFORM

2014-05-25 Thread Viresh Kumar
+++- drivers/cpufreq/exynos4x12-cpufreq.c | 40 - drivers/cpufreq/exynos5250-cpufreq.c | 43 +--- 6 files changed, 119 insertions(+), 41 deletions(-) Looks fine.. Acked-by: Viresh Kumar viresh.ku...@linaro.org

Re: [PATCH v2] cpufreq: exynos: Fix driver compilation with ARCH_MULTIPLATFORM

2014-05-25 Thread Viresh Kumar
On 26 May 2014 03:11, Kukjin Kim kgene@samsung.com wrote: I'm not sure Thomas' v5 cpufreq-cpu0 driver can be upstreamed for 3.16 because of dependency with others, some of them got ack though... * PM / OPP: move cpufreq specific helpers out of OPP layer -

Re: [PATCH v4 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree

2014-05-25 Thread Viresh Kumar
On 23 May 2014 19:07, Thomas Abraham thomas...@samsung.com wrote: From: Thomas Abraham thomas...@samsung.com Commit 6f19efc0 (cpufreq: Add boost frequency support in core) adds support for CPU boost mode. This patch adds support for finding available boost frequencies from device tree and

Re: [PATCH] cpufreq: exynos: Fix driver compilation with ARCH_MULTIPLATFORM

2014-05-21 Thread Viresh Kumar
On 21 May 2014 16:47, Tomasz Figa t.f...@samsung.com wrote: Mostly nitpicks .. diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm config ARM_EXYNOS4X12_CPUFREQ bool SAMSUNG EXYNOS4x12 - depends on (SOC_EXYNOS4212 || SOC_EXYNOS4412) !ARCH_MULTIPLATFORM +

Re: [PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Viresh Kumar
On 16 May 2014 13:20, Jonghwan Choi jhbird.c...@samsung.com wrote: Commit 7da83a80 (ARM: EXYNOS: Migrate Exynos specific macros from plat to mach) Why do you have a line break here ? which lands in samsung tree causes build breakage for cpufreq-exynos like following: Enter a blank line

Re: [PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Viresh Kumar
And please use Rafael's email id from Maintainers.. On 16 May 2014 13:25, Viresh Kumar viresh.ku...@linaro.org wrote: On 16 May 2014 13:20, Jonghwan Choi jhbird.c...@samsung.com wrote: Commit 7da83a80 (ARM: EXYNOS: Migrate Exynos specific macros from plat to mach) Why do you have a line

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Viresh Kumar
On 16 May 2014 15:48, Jonghwan Choi jhbird.c...@samsung.com wrote: Commit 7da83a80 (ARM: EXYNOS: Migrate Exynos specific macros from plat to mach) which lands in samsung tree causes build breakage for cpufreq-exynos like following: drivers/cpufreq/exynos-cpufreq.c: In function

Re: [PATCH v4 1/8] cpufreq: cpufreq-cpu0: allow use of optional boost mode frequencies

2014-05-14 Thread Viresh Kumar
On 14 May 2014 11:47, Lukasz Majewski l.majew...@samsung.com wrote: I think that you can rely solely on the CPU_FREQ_BOOST_SW flag if the original author of cpufreq-cpu0.c don't mind. We don't have to. struct cpufreq_driver: boost_supported is always available. Just update it without any ugly

Re: [PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree

2014-05-14 Thread Viresh Kumar
On 14 May 2014 11:39, Lukasz Majewski l.majew...@samsung.com wrote: I agree with Nishanth here, that point 1 (as described by Viresh at [*]) is a more scalable approach. The only reason why I wanted all that to be done at OPP level was to ensure if somebody else also needs it apart from

Re: [PATCH v4 7/8] ARM: Exynos: switch to using generic cpufreq-cpu0 driver

2014-05-14 Thread Viresh Kumar
On 14 May 2014 18:20, Arnd Bergmann a...@arndb.de wrote: Could we please come up with a way to probe this from DT in the cpufreq-cpu0 driver itself, so we don't have to add a device in every platform using it? Its followed that way because DT Maintainers had strong objections to creating

Re: [PATCH v4 0/8] cpufreq: use cpufreq-cpu0 driver for exynos based platforms

2014-05-14 Thread Viresh Kumar
On 14 May 2014 18:21, Arnd Bergmann a...@arndb.de wrote: Thanks a lot for your continued effort. Looks great overall, but I have one comment about the general way the cpu0 cpufreq driver works, not specific to the exynos implementation. See my reply to patch 4. I hope you meant 7 here instead

Re: [PATCH v4 7/8] ARM: Exynos: switch to using generic cpufreq-cpu0 driver

2014-05-14 Thread Viresh Kumar
On 14 May 2014 18:41, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 14. Mai 2014, 18:35:29 schrieb Viresh Kumar: On 14 May 2014 18:20, Arnd Bergmann a...@arndb.de wrote: Could we please come up with a way to probe this from DT in the cpufreq-cpu0 driver itself, so we don't have to add

Re: [PATCH v4 1/8] cpufreq: cpufreq-cpu0: allow use of optional boost mode frequencies

2014-05-14 Thread Viresh Kumar
On 14 May 2014 19:13, Thomas Abraham ta.oma...@gmail.com wrote: Okay, so you are suggesting that Kconfig entry used to select cpufreq-cpu0 should also enable CPU_FREQ_BOOST_SW config as well. I never said that... That should be enabled by your defconfig instead. What I said was, don't put code

Re: [PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree

2014-05-14 Thread Viresh Kumar
On 14 May 2014 19:16, Thomas Abraham ta.oma...@gmail.com wrote: On Wed, May 14, 2014 at 9:10 AM, Viresh Kumar viresh.ku...@linaro.org wrote: Why is this present outside of above if {} ? as boost_freqs is guaranteed to be NULL without that. Just to reduce indentation by one tab. No technical

Re: [PATCH v4 1/8] cpufreq: cpufreq-cpu0: allow use of optional boost mode frequencies

2014-05-14 Thread Viresh Kumar
On 14 May 2014 19:48, Thomas Abraham ta.oma...@gmail.com wrote: Okay, I get the point about #ifdef in cpufreq-cpu0. What about your earlier comment about the new Kconfig entry (Get rid of this.. just not required.)? The new Kconfig entry would be needed in that case. The only place you used

Re: [PATCH v3 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree

2014-05-13 Thread Viresh Kumar
On 14 May 2014 06:32, Thomas Abraham ta.oma...@gmail.com wrote: From: Thomas Abraham thomas...@samsung.com Commit 6f19efc0 (cpufreq: Add boost frequency support in core) adds support for CPU boost mode. This patch adds support for finding available boost frequencies from device tree and

Re: [PATCH v4 1/8] cpufreq: cpufreq-cpu0: allow use of optional boost mode frequencies

2014-05-13 Thread Viresh Kumar
On 14 May 2014 06:41, Thomas Abraham ta.oma...@gmail.com wrote: From: Thomas Abraham thomas...@samsung.com Lookup for the optional boost-frequency property in cpu0 node and if available, enable support for boost mode frequencies. The frequencies usable in boost mode are determined while

Re: [PATCH v4 2/8] clk: samsung: change scope of samsung clock lock to global

2014-05-13 Thread Viresh Kumar
On 14 May 2014 06:41, Thomas Abraham ta.oma...@gmail.com wrote: From: Thomas Abraham thomas...@samsung.com Access to samsung clock lock is required to support newer samsung specific clock types. So change the scope of the samsung clock lock to global. And Maybe bit more detail on why exactly

Re: [PATCH v4 8/8] cpufreq: exynos: remove all exynos specific cpufreq driver support

2014-05-13 Thread Viresh Kumar
On 14 May 2014 06:41, Thomas Abraham ta.oma...@gmail.com wrote: From: Thomas Abraham thomas...@samsung.com Exynos4210, Exynos4x12 and Exynos5250 based platforms have switched over to use cpufreq-cpu0 driver for cpufreq functionality. So the Exynos specific cpufreq drivers for these platforms

Re: [PATCH 1/2] PM / OPP: Remove cpufreq wrapper dependency on internal data organization

2014-05-05 Thread Viresh Kumar
On 5 May 2014 19:03, Nishanth Menon n...@ti.com wrote: diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c int dev_pm_opp_init_cpufreq_table(struct device *dev, struct cpufreq_frequency_table **table) { - struct device_opp *dev_opp;

Re: [PATCH 2/2] PM / OPP: Move cpufreq specific OPP functions out of generic OPP library

2014-05-05 Thread Viresh Kumar
as needed isolated to just CPUFreq framework alone. Here, we just move relevant code and documentation to make this part of CPUFreq infrastructure. Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Kevin Hilman khil...@deeprootsystems.com Cc: cpuf

Re: [PATCH 1/2] PM / OPP: Remove cpufreq wrapper dependency on internal data organization

2014-05-05 Thread Viresh Kumar
On 5 May 2014 19:55, Nishanth Menon n...@ti.com wrote: On Mon, May 5, 2014 at 9:23 AM, Viresh Kumar viresh.ku...@linaro.org wrote: What if opp is being added for some reason at the same time? I hope we can surely see some awkward results, maybe some NULL pointers invocations as well.. we

Re: [RFC PATCH] PM / OPP: move cpufreq specific OPP functions out of generic OPP library

2014-05-01 Thread Viresh Kumar
On 2 May 2014 06:36, Nishanth Menon n...@ti.com wrote: diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index 1fbe11f..281ccfb 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -17,6 +17,11 @@ config CPU_FREQ if CPU_FREQ +config CPU_FREQ_PM_OPP +

Re: [RFC PATCH] PM / OPP: move cpufreq specific OPP functions out of generic OPP library

2014-05-01 Thread Viresh Kumar
On 2 May 2014 10:48, Nishanth Menon n...@ti.com wrote: On Thu, May 1, 2014 at 11:30 PM, Viresh Kumar viresh.ku...@linaro.org wrote: diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c new file mode 100644 index 000..2602ff8 --- /dev/null +++ b/drivers/cpufreq

Re: [PATCH 2/2] cpufreq: Remove exynos_sort_descend_freq_table in exynos5440-cpufreq.c

2014-04-29 Thread Viresh Kumar
On 29 April 2014 11:44, Amit Kachhap amit.kach...@gmail.com wrote: In the frequency table dts file, the frequencies are arranged in descending order which maps 1 to 1 with other frequency parameter to be calculated and programmed in some registers. But the OPP library works by generating the

Re: [PATCH 1/2] cpufreq: exynos: Use dev_err/info function instead of pr_err/info

2014-04-21 Thread Viresh Kumar
--- drivers/cpufreq/exynos-cpufreq.c | 21 - drivers/cpufreq/exynos-cpufreq.h | 1 + 2 files changed, 13 insertions(+), 9 deletions(-) This still looks fine even if we don't take the new driver ? Acked-by: Viresh Kumar viresh.ku...@linaro.org diff --git a/drivers/cpufreq/exynos

Re: [PATCH 07/20] cpufreq: exynos: Use cpufreq_for_each_entry macro for iteration

2014-04-14 Thread Viresh Kumar
On 15 April 2014 02:39, Stratos Karafotis strat...@semaphore.gr wrote: The cpufreq core supports the cpufreq_for_each_entry macro helper for iteration over the cpufreq_frequency_table, so use it. It should have no functional changes. Signed-off-by: Stratos Karafotis strat...@semaphore.gr

Re: [PATCH 08/20] cpufreq: exynos5440: Use cpufreq_for_each_entry macro for iteration

2014-04-14 Thread Viresh Kumar
On 15 April 2014 02:39, Stratos Karafotis strat...@semaphore.gr wrote: diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c static void exynos_enable_dvfs(unsigned int cur_frequency) { - unsigned int tmp, i, cpu; + unsigned int tmp, cpu;

Re: [PATCH 01/17] ARM: exynos: cpuidle: Prevent forward declaration

2014-04-04 Thread Viresh Kumar
) { int cpu_id, ret; Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/17] ARM: exynos: cpuidle: use cpuidle_register

2014-04-04 Thread Viresh Kumar
++ 1 file changed, 2 insertions(+), 16 deletions(-) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 04/17] ARM: exynos: cpuidle: encapsulate register access inside a function

2014-04-04 Thread Viresh Kumar
- 1 file changed, 41 insertions(+), 24 deletions(-) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 05/17] ARM: exynos: cpuidle: Move some code inside the idle_finisher

2014-04-04 Thread Viresh Kumar
= __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION); tmp = ~S5P_CENTRAL_LOWPWR_CFG; __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION); cpu_pm_enter(); Probably mention that in log too, that it doesn't have any side effects? Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send

Re: [PATCH 06/17] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call

2014-04-04 Thread Viresh Kumar
*/ + __raw_writel(0x0, S5P_WAKEUP_STAT); } - /* Clear wakeup state register */ - __raw_writel(0x0, S5P_WAKEUP_STAT); - return index; } Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 08/17] ARM: exynos: cpuidle: Move scu_enable in the cpu_pm notifier

2014-04-04 Thread Viresh Kumar
On 4 April 2014 13:17, Daniel Lezcano daniel.lezc...@linaro.org wrote: We make the cpuidle code less arch dependent. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-exynos/cpuidle.c |6 -- arch/arm/mach-exynos/pm.c |3 +++ 2 files changed, 3

Re: [PATCH 09/17] ARM: exynos: cpuidle: Remove ifdef for scu_enable

2014-04-04 Thread Viresh Kumar
scu_enable(S5P_VA_SCU); -#endif Ahh you are removing them here :) exynos_cpu_restore_register(); break; } Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 10/17] ARM: exynos: cpuidle: Move exynos_set_wakeupmask in the cpu_pm notifier

2014-04-04 Thread Viresh Kumar
(); + exynos_set_wakeupmask(); break; case CPU_PM_EXIT: Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 12/17] ARM: exynos: cpuidle: Move S5P_CHECK_AFTR in a header

2014-04-04 Thread Viresh Kumar
changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/17] ARM: exynos: cpuidle: Move clock setup to pm.c

2014-04-04 Thread Viresh Kumar
--- arch/arm/mach-exynos/pm.c | 55 +++- 2 files changed, 54 insertions(+), 55 deletions(-) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 14/17] ARM: exynos: cpuidle: Move the boot vector in pm.c

2014-04-04 Thread Viresh Kumar
| 22 -- arch/arm/mach-exynos/pm.c | 15 +++ 2 files changed, 15 insertions(+), 22 deletions(-) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 16/17] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory

2014-04-04 Thread Viresh Kumar
|7 +++ drivers/cpuidle/Makefile |1 + .../cpuidle.c = drivers/cpuidle/cpuidle-exynos.c |0 4 files changed, 8 insertions(+), 1 deletion(-) rename arch/arm/mach-exynos/cpuidle.c = drivers/cpuidle/cpuidle-exynos.c (100%) Reviewed-by: Viresh Kumar

Re: [PATCH 15/17] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data

2014-04-04 Thread Viresh Kumar
+++-- arch/arm/mach-exynos/common.h |1 + arch/arm/mach-exynos/cpuidle.c |8 arch/arm/mach-exynos/pmu.c |6 ++ 4 files changed, 14 insertions(+), 6 deletions(-) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line

Re: [PATCH 17/17] ARM: exynos: config: Enable cpuidle

2014-04-04 Thread Viresh Kumar
/exynos_defconfig |1 + 1 file changed, 1 insertion(+) Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFC v3 0/5] cpufreq:LAB: Support for LAB governor.

2014-03-24 Thread Viresh Kumar
On 24 March 2014 12:17, Lukasz Majewski l.majew...@samsung.com wrote: Viresh, will you find time for reviewing this RFC in a near future? Yes. I have been trying hard last week but couldn't find some time for it. Will try this week for sure.. Sorry to keep you waiting :( @Rafael: Please see if

Re: [RFC v3 0/5] cpufreq:LAB: Support for LAB governor.

2014-03-24 Thread Viresh Kumar
On 4 March 2014 15:57, Lukasz Majewski l.majew...@samsung.com wrote: Despite this patch set is working and applicable on top of 3.14-rc5, please regard it solely as a pure RFC. Okay, I am trying to do a review here and because you have mentioned how different it is from the earlier versions, I

Re: [RFC v3 0/5] cpufreq:LAB: Support for LAB governor.

2014-03-24 Thread Viresh Kumar
[Adding Linaro lists in cc as there are few people here working on power/thermal stuff.] On 24 March 2014 15:30, Lukasz Majewski l.majew...@samsung.com wrote: On 4 March 2014 15:57, Lukasz Majewski l.majew...@samsung.com wrote: I think, that LAB name is with us for some time, so it would be a

Re: [RFC v3 0/5] cpufreq:LAB: Support for LAB governor.

2014-03-18 Thread Viresh Kumar
On 17 March 2014 21:08, Lukasz Majewski l.majew...@samsung.com wrote: Despite this patch set is working and applicable on top of 3.14-rc5, please regard it solely as a pure RFC. This patch provides support for LAB governor build on top of ondemand. Previous version of LAB can be found here:

Re: [PATCH RESEND] cpufreq: exynos: Fix build error of no type of module_init

2014-01-22 Thread Viresh Kumar
On 22 January 2014 19:51, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add missing include to fix build error: drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default] drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults

Re: [PATCH 3/3] cpufreq: exynos: Add exynos5420 cpufreq driver

2013-12-17 Thread Viresh Kumar
On 17 December 2013 13:30, Lukasz Majewski l.majew...@samsung.com wrote: When I first looked into the patch - it was almost identical to the exynos4210-cpufreq.c or exynos4x12-cpufreq.c files. Also I didn't spot the code characteristic to IKS. It seems like the code in this file is not aware

Re: [PATCH 3/3] cpufreq: exynos: Add exynos5420 cpufreq driver

2013-12-16 Thread Viresh Kumar
On 6 December 2013 15:18, Arun Kumar K arun...@samsung.com wrote: From: Arjun.K.V arjun...@samsung.com The patch adds cpufreq driver for exynos5420. Signed-off-by: Arjun.K.V arjun...@samsung.com Signed-off-by: Andrew Bresticker abres...@chromium.org Signed-off-by: Arun Kumar K

[PATCH V4 0/6] cpufreq: suspend early/resume late: dpm_{suspend|resume}()

2013-12-01 Thread Viresh Kumar
5a87182aa21d6d5d306840feab9321818dd3e2a3 Author: Viresh Kumar viresh.ku...@linaro.org Date: Wed Nov 27 09:09:42 2013 +0530 cpufreq: suspend governors on system suspend/hibernate This is already tested by few people and so incorporating their Tested-by as well. For: v3.14. Viresh Kumar (6): cpufreq: suspend

[PATCH V4 5/6] cpufreq: s5pv210: Use cpufreq_generic_suspend()

2013-12-01 Thread Viresh Kumar
Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/s5pv210-cpufreq.c | 49

[PATCH V4 3/6] cpufreq: Implement cpufreq_generic_suspend()

2013-12-01 Thread Viresh Kumar
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 25 + include/linux/cpufreq.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 443c053..ae4923e 100644 --- a/drivers

[PATCH V4 6/6] cpufreq: Tegra: Use cpufreq_generic_suspend()

2013-12-01 Thread Viresh Kumar
Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Acked-and-tested-by: Stephen Warren swar...@nvidia.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers

[PATCH V4 4/6] cpufreq: exynos: Use cpufreq_generic_suspend()

2013-12-01 Thread Viresh Kumar
Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/exynos-cpufreq.c | 96

[PATCH V4 1/6] cpufreq: suspend governors from dpm_{suspend|resume}()

2013-12-01 Thread Viresh Kumar
Tested-by: Stephen Warren swar...@nvidia.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/base/power/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index e3219df..c9fbb9d 100644 --- a/drivers

[PATCH V4 2/6] cpufreq: call driver's suspend/resume for each policy

2013-12-01 Thread Viresh Kumar
Tianyu tianyu@intel.com Tested-by: Nishanth Menon n...@ti.com Tested-by: Stephen Warren swar...@nvidia.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 112 +- 1 file changed, 32 insertions(+), 80 deletions

Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate

2013-11-28 Thread Viresh Kumar
On 28 November 2013 19:53, Rafael J. Wysocki r...@rjwysocki.net wrote: I don't think that the Nishanth's issue is fixed by this particular version of the patch, so I modified the changelog and removed a the comment above cpufreq_suspend() No, it does fix his issue as we are just stopping the

Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate

2013-11-28 Thread Viresh Kumar
On 29 November 2013 01:59, Rafael J. Wysocki r...@rjwysocki.net wrote: So I'm reading this as the version of the patch in bleeding-edge is OK. I hope that really is the case. :-) Yeah, that's correct. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of

Re: [PATCH V3 4/6] cpufreq: exynos: Use cpufreq_generic_suspend()

2013-11-26 Thread Viresh Kumar
On 25 November 2013 19:41, Viresh Kumar viresh.ku...@linaro.org wrote: Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Signed-off-by: Viresh Kumar viresh.ku

Re: [PATCH V3 1/6] cpufreq: suspend governors on system suspend/hibernate

2013-11-26 Thread Viresh Kumar
On 27 November 2013 07:12, Rafael J. Wysocki r...@rjwysocki.net wrote: Anyway, if you did what I asked you to do and put the cpufreq suspend/resume into dpm_suspend/resume_noirq(), I'd probably take this for 3.13. However, since you've decided to put those things somewhere else thus making the

Re: [PATCH V3 1/6] cpufreq: suspend governors on system suspend/hibernate

2013-11-26 Thread Viresh Kumar
On 27 November 2013 01:53, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, November 26, 2013 07:56:19 AM Viresh Kumar wrote: On 26 November 2013 04:59, Rafael J. Wysocki r...@rjwysocki.net wrote: This appears to be racy. Is it really racy, or just seemingly? Why does it look racy

[PATCH V4] cpufreq: suspend governors on system suspend/hibernate

2013-11-26 Thread Viresh Kumar
-and-tested-by: Nishanth Menon n...@ti.com Reported-by: Jinhyuk Choi jinc...@broadcom.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- This is almost same as 1/6 of V3 version of this patchset: https://lkml.org/lkml/2013/11/25/838 This is done to get some initial fixes for 3.13

[PATCH V3 1/6] cpufreq: suspend governors on system suspend/hibernate

2013-11-25 Thread Viresh Kumar
now. Reported-by: Lan Tianyu tianyu@intel.com Reported-by: Nishanth Menon n...@ti.com Reported-by: Jinhyuk Choi jinc...@broadcom.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/base/power/main.c | 5 + drivers/cpufreq/cpufreq.c | 50

[PATCH V3 3/6] cpufreq: Implement cpufreq_generic_suspend()

2013-11-25 Thread Viresh Kumar
Multiple platforms need to set CPU to a particular frequency before suspending system. And so they need a common infrastructure which is provided by this patch. Those platforms just need to initialize their -suspend() pointers with the generic routine. Signed-off-by: Viresh Kumar viresh.ku

[PATCH V3 6/6] cpufreq: Tegra: Use cpufreq_generic_suspend()

2013-11-25 Thread Viresh Kumar
Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/tegra-cpufreq.c | 54

[PATCH V3 4/6] cpufreq: exynos: Use cpufreq_generic_suspend()

2013-11-25 Thread Viresh Kumar
Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/exynos-cpufreq.c | 97

[PATCH V3 2/6] cpufreq: call driver's suspend/resume for each policy

2013-11-25 Thread Viresh Kumar
-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 98 +-- 1 file changed, 18 insertions(+), 80 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index b6c7821..026efe4a 100644 --- a/drivers/cpufreq

[PATCH V3 5/6] cpufreq: s5pv210: Use cpufreq_generic_suspend()

2013-11-25 Thread Viresh Kumar
Currently we have implemented PM notifiers to disable/enable -target() routines functionality during suspend/resume. Now we have support present in cpufreq core, lets use it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/s5pv210-cpufreq.c | 49

[PATCH V3 0/6] cpufreq: suspend early/resume late

2013-11-25 Thread Viresh Kumar
. @Nishanth: Can you please test V2 as well and confirm that suspend_noirq() doesn't work for you. I am sure it will not, but would be better if you confirm that. Viresh Kumar (6): cpufreq: suspend governors on system suspend/hibernate cpufreq: call driver's suspend/resume for each policy cpufreq

Re: [PATCH V3 1/6] cpufreq: suspend governors on system suspend/hibernate

2013-11-25 Thread Viresh Kumar
On 26 November 2013 04:59, Rafael J. Wysocki r...@rjwysocki.net wrote: @@ -1259,6 +1262,8 @@ int dpm_suspend(pm_message_t state) might_sleep(); + cpufreq_suspend(); + mutex_lock(dpm_list_mtx); pm_transition = state; async_error = 0; Shouldn't it do

Re: [PATCH V3 1/6] cpufreq: suspend governors on system suspend/hibernate

2013-11-25 Thread viresh kumar
On Monday 25 November 2013 07:41 PM, Viresh Kumar wrote: diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index dc196bb..6d93f91 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -255,6 +255,9 @@ struct cpufreq_driver { int cpufreq_register_driver(struct

Re: [PATCH 1/1] cpufreq: exynos5250: Set APLL rate using CCF API

2013-11-20 Thread Viresh Kumar
-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] cpufreq: exynos: Consider hibernation in pm notifier

2013-11-19 Thread Viresh Kumar
On 19 November 2013 18:59, Jonghwan Choi jhbird.c...@gmail.com wrote: Frequency lock should be considered in suspend/hibernation. These could turn out to be important logs for future. Please write with more effort.. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com ---

Re: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*

2013-09-20 Thread Viresh Kumar
(*new_opp),+} GFP_KERNEL); It is almost impossible to catch these with naked eyes for such long patches.. I took help of --word-diff though :) If no one else sees these as problems then feel free to add my: Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send

Re: [PATCH 1/3] PM / OPP: rename functions to dev_pm_opp*

2013-09-20 Thread Viresh Kumar
On 20 September 2013 18:08, Nishanth Menon n...@ti.com wrote: I am open to suggestions if any one feels we can improve this better. I didn't really had one.. I thought of pm_opp** instead of dev_pm_opp** though.. I believe that change was from Patch #2[1] Yeah.. I just replied on a single

Re: [PATCH v4 02/10] ARM: dts: list the CPU nodes for Exynos5250

2013-09-10 Thread Viresh Kumar
On 2 September 2013 12:07, Chander Kashyap chander.kash...@linaro.org wrote: I tested on 3.11-rc7. Both the cpu's are booting. I didnet see any issue. Oops!! I copied dtb to wrong location.. stupid mistake.. sorry. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v4 02/10] ARM: dts: list the CPU nodes for Exynos5250

2013-09-02 Thread Viresh Kumar
On 2 September 2013 12:07, Chander Kashyap chander.kash...@linaro.org wrote: I tested on 3.11-rc7. Both the cpu's are booting. I didnet see any issue. Strange.. I am sure about the problem I reported.. Please share your .config and I will give it a try.. -- To unsubscribe from this list: send

Re: [PATCH v4 02/10] ARM: dts: list the CPU nodes for Exynos5250

2013-08-29 Thread Viresh Kumar
On Tue, Jun 18, 2013 at 11:59 AM, Chander Kashyap chander.kash...@linaro.org wrote: Instead of having to specify the number for CPUs in Exynos5250 in platsmp.c file, let the number of CPUs be determined by having this information listed in Exynos5250 device tree file. Signed-off-by: Chander

Re: [PATCH] cpufreq: fix EXYNOS drivers selection

2013-08-11 Thread Viresh Kumar
On 9 August 2013 21:20, Tomasz Figa t.f...@samsung.com wrote: On Friday 09 of August 2013 14:04:55 Bartlomiej Zolnierkiewicz wrote: * remove superfluous pr_debug() call from exynos_cpufreq_init() (init errors are always logged anyway) * add dummy per-SoC type init functions to

Re: [PATCH] cpufreq: exynos5440: Fix to skip when new frequency same as current

2013-08-07 Thread Viresh Kumar
as the percentage of average frequency. This check is present in most of the cpufreq driver. Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Rafael J. Wysocki r...@sisk.pl Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- drivers/cpufreq

Re: [PATCH] cpufreq: exynos5440: Fix to skip when new frequency same as current

2013-08-07 Thread Viresh Kumar
On 7 August 2013 17:00, Sudeep KarkadaNagesha sudeep.karkadanage...@arm.com wrote: Any particular reason we need this check in all drivers after your commit: 5a1c0228 cpufreq: Avoid calling cpufreq driver's target() routine if target_freq == policy-cur I think it can removed from all drivers,

Re: [PATCH] cpufreq: exynos5440: Fix to skip when new frequency same as current

2013-08-07 Thread Viresh Kumar
On 8 August 2013 04:55, Rafael J. Wysocki r...@sisk.pl wrote: It looks like it would require us to redefine .target() to take next_state instead of target_freq (at least in the acpi-cpufreq case), wouldn't it? If we don't do it, then atleast for few drivers, like acpi-cpufreq, which use index

Re: [PATCH] cpufreq: s3c24xx: fix typo ARM_S3C24XX

2013-07-15 Thread Viresh Kumar
for changing the PLL frequency from the S3C24XX series CPUfreq driver. The PLL takes time to settle Acked-by: Viresh Kumar viresh.ku...@linaro.org @Rafael: I saw you taking other s3c patch directly. Mind taking this one too? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v2 31/38] cpufreq: exynos4x12: Remove check for SOC_EXYNOS4412

2013-06-17 Thread Viresh Kumar
On 17 June 2013 22:04, Tomasz Figa t.f...@samsung.com wrote: Since SOC_EXYNOS4412 Kconfig symbol has been removed, it is enough to check for SOC_EXYNOS4212 for both SoCs from Exynos4x12 series. Cc: linux...@vger.kernel.org Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Tomasz Figa

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-05-19 Thread Viresh Kumar
On 14 May 2013 18:30, Rafael J. Wysocki r...@sisk.pl wrote: On Tuesday, May 14, 2013 09:36:42 PM Kukjin Kim wrote: Viresh Kumar wrote: On 13 May 2013 16:21, Rafael J. Wysocki r...@sisk.pl wrote: That doesn't matter I suppose. I can take it, but please rebase it on top of current

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-05-13 Thread Viresh Kumar
On 23 April 2013 20:55, Kukjin Kim kgene@samsung.com wrote: On 04/05/13 20:36, Rafael J. Wysocki wrote: On Friday, April 05, 2013 12:36:34 PM Viresh Kumar wrote: On 5 April 2013 12:18, Kukjin Kimkgene@samsung.com wrote: Basically, this moving looks good to me, but should be re

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-05-13 Thread Viresh Kumar
On 13 May 2013 16:21, Rafael J. Wysocki r...@sisk.pl wrote: That doesn't matter I suppose. I can take it, but please rebase it on top of current linux-next. I have already done that (attached). But i wasn't sure what Kukjin wants as he may report conflicts again and i will ask the same

Re: [PATCH v2] ARM: S5pv210: compiling issue, ARM_S5PV210_CPUFREQ need CONFIG_CPU_FREQ_TABLE=y

2013-04-24 Thread Viresh Kumar
on CPU_S5PV210 + select CPU_FREQ_TABLE Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Viresh Kumar
On 22 April 2013 15:26, Tomasz Figa t.f...@samsung.com wrote: Can you assure that in future SoCs, on which this driver will be used, this assumption will still hold true or even that in current Exynos driver this behavior won't be changed? Probably yes.. Registers for enabling/disabling these

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Viresh Kumar
On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote: 3) after those two changes, all that remains is to fix compliance with Common Clock Framework, in other words: s/clk_enable/clk_prepare_enable/ and s/clk_disable/clk_disable_unprepare/ We don't have to call

Re: [PATCH V6 1/4] cpufreq: exynos: Add cpufreq driver for exynos5440

2013-04-08 Thread Viresh Kumar
On 8 April 2013 13:47, Amit Daniel Kachhap amit.dan...@samsung.com wrote: diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index f3f3b14..bce2195 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -42,6 +42,15 @@ config ARM_EXYNOS5250_CPUFREQ

<    1   2   3   >