This matches current best practice as one can have runtime PM enabled
without system sleep and CONFIG_PM is defined for both.
Signed-off-by: Mark Brown
---
drivers/mmc/host/sdhci-s3c.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-s3c.c
Since most of the work is already done by the core we just need to add
runtime suspend methods and tell the PM core that runtime PM is enabled
for this device.
Signed-off-by: Mark Brown
---
drivers/mmc/host/sdhci-s3c.c | 28
1 files changed, 28 insertions(+), 0
On Sat, Mar 03, 2012 at 09:20:05PM +0530, Thomas Abraham wrote:
> This patchset rearranges the elements in the platform data of the s3c-fb
> driver with the intent of adding device tree support to the driver in
> subsequent patches.
It seems somewhat surprising that none of these updates touch any
On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote:
> This movement is needed because the hwmon entries and corresponding
> sysfs interface is a duplicate of utilities already provided by
> driver/thermal/thermal_sys.c. The goal is to place it in mfd folder
> and add necessary call
On Sat, Mar 03, 2012 at 10:15:32PM +0530, Thomas Abraham wrote:
> The third patch in this series includes platform data updates for the
> Exynos4210 based Origen board. If the first two patches in this series
> are acceptable, I will submit another version of this patchset which
> would include up
On Mon, Mar 05, 2012 at 07:48:42PM +0900, Jaehoon Chung wrote:
> On 03/03/2012 09:46 AM, Mark Brown wrote:
> > + pm_runtime_set_autosuspend_delay(&pdev->dev, 50);
> Could you explain why use 50ms?
It's essentially a random number, some other devices use the same o
On Tue, Mar 06, 2012 at 03:17:20PM +0900, Jaehoon Chung wrote:
> This patchset is the purpose for using sdhci-pltfm.c and
> removing the arch dependency.
> The sdhci-s3c has too heavy arch dependency.
> For example, if work for sdhci-s3c.c at mmc-tree, sometime need to change
> sdhci.h for Samsun
On Tue, Mar 06, 2012 at 11:40:08PM +0900, Jae hoon Chung wrote:
> 2012/3/6 Heiko Stübner :
> > Am Dienstag, 6. März 2012, 14:00:54 schrieb Mark Brown:
> >> This series will break S3C64xx, you've not touched it at all in the
> >> update but it uses the same SDHCI co
On Wed, Mar 07, 2012 at 12:03:31PM +0900, Jaehoon Chung wrote:
> On 03/07/2012 01:30 AM, Mark Brown wrote:
> > The same IP is present and used with the same driver on other Samsung
> > SoCs.
> I know that used with the same driver on other
> Samsung-SoCs(S3C64XX/S3C24XX..et
On Thu, Mar 08, 2012 at 02:35:53PM +0900, Jaehoon Chung wrote:
> So i think no problem that removed "#include ". is it
> wrong?
> Just touching the setup-gpio- files is problem?
It should be fine, like I say I didn't really read the patches in enough
detail as the diffstat set off alarm bells.
On Fri, Mar 09, 2012 at 10:53:26AM +0900, Jaehoon Chung wrote:
> On 03/08/2012 08:01 PM, Mark Brown wrote:
> > It should be fine, like I say I didn't really read the patches in enough
> > detail as the diffstat set off alarm bells.
> If you have any opinions, let me know.
On Fri, Mar 09, 2012 at 12:08:58AM -0500, Chris Ball wrote:
> The reworked patch is below, please let me know if it looks incorrect:
That looks about right, I'll find out soon enough if it doesn't work in
-next as my main development system has the rootfs on this device :)
signature.asc
Descrip
On Sun, Mar 11, 2012 at 06:16:05PM +0530, Thomas Abraham wrote:
> The platform specific callback to setup the sdhci pin mux and pin config
> is removed and the pinctrl subsystem interface is used to setup the
> mux and config.
You've only added pinctrl support for Exynos but this driver is also
us
On Mon, Mar 12, 2012 at 08:01:34PM +0530, Thomas Abraham wrote:
> Yes, I agree with your comment. I did refer to manuals of s3c24xx to
> Exynos to ensure that the samsung pinctrl driver is generic and
> reusable on all samsung soc's. I hope I have not missed out something
> important that would re
Commit 054ebc (spi: Compatibility with direction which is used in samsung
DMA operation) does not build as one hunk adds a brace to the first branch
of an if statement without adding at least the correspoding close. Remove
the unwanted brace.
Signed-off-by: Mark Brown
---
drivers/spi/spi
On Tue, Mar 13, 2012 at 05:54:38PM +0100, Karol Lewandowski wrote:
> - replace s3c24xx_i2c_type enum with plain unsigned int that can
>hold not only device type but also hw revision-specific quirks
Would it not be clearer to just have explicit flags for the quirks (eg,
as a set of bitfield f
On Thu, Mar 15, 2012 at 11:04:56AM +0100, Karol Lewandowski wrote:
> Introducing separate type (TYPE_S3C2440_HDMIPHY) has been our original
> attempt to solve this issue. However, this required adding explicit
> checks to driver code all over the place (if (type == S3C2400 ||
> type == S3c2440_HD
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:
> If you consider code to be inherently less readable because of this
> approach I'll rework it. If it's not a such big deal for you I would
> prefer to keep it as is.
The thing that was causing me to think the code was funny was
On Wed, Mar 21, 2012 at 11:33:58AM +0100, Karol Lewandowski wrote:
> What do you think about following changes, then?
That looks reasonable.
signature.asc
Description: Digital signature
24xx_i2c_type enum with unsigned int that holds
>bitmask with revision-specific quirks
Reviewed-by: Mark Brown
signature.asc
Description: Digital signature
On Tue, Mar 27, 2012 at 11:50:24AM -0400, Chris Ball wrote:
> On Tue, Feb 21 2012, Chris Ball wrote:
> > On Tue, Feb 21 2012, Kukjin Kim wrote:
> >> I created topic branch for this we talked. You can pull that following:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
On Tue, Mar 27, 2012 at 03:46:43PM +0530, Thomas Abraham wrote:
> For s3c64xx and exynos platforms, make the selection of PM_GENERIC_DOMAINS
> depend on the CONFIG_PM.
What's the underlying issue here? This seems like something the PM core
should be dealing with gracefully...
signature.asc
Desc
On Wed, Mar 28, 2012 at 04:51:32PM +0530, Thomas Abraham wrote:
> On 28 March 2012 16:21, Mark Brown
> wrote:
> > What's the underlying issue here? This seems like something the PM core
> > should be dealing with gracefully...
> The PM_GENERIC_DOMAINS config option h
On Wed, Mar 28, 2012 at 05:07:03PM +0530, Thomas Abraham wrote:
> On 28 March 2012 17:04, Mark Brown
> wrote:
> > Right, this does seem like something which it'd be better to handle
> > more gracefully in the PM core.
> Ok. Selecting PM_GENERIC_DOMAINS without che
On Fri, Mar 30, 2012 at 10:32:54AM +0200, Heiko Stübner wrote:
> Am Donnerstag, 22. Dezember 2011, 19:13:59 schrieb Mark Brown:
> > My plan there for the s3c64xx was to use pm_domain to figure out if the
> > system is idle enough to drop down, I've been adding some pm_ru
On Fri, Mar 30, 2012 at 06:45:07PM +, Arnd Bergmann wrote:
> On Friday 30 March 2012, Stephen Warren wrote:
> > > +- cd-inverted: when present, polarity on the wp gpio line is inverted
> > > +- wp-inverted: when present, polarity on the wp gpio line is inverted
> > I'm not sure about those tw
The regulator API now allows supplies used by regulators to be specified
as normal supplies - provide the hookup for that mechanism on Cragganmore.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-crag6410.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions
On Mon, Apr 02, 2012 at 12:05:53PM -0700, Kukjin Kim wrote:
> Mark, is this needed for v3.4?
No.
signature.asc
Description: Digital signature
On Sat, Mar 24, 2012 at 03:19:49PM +0530, Thomas Abraham wrote:
> Add irq domain support for max8997 interrupts. The reverse mapping method
> used is linear mapping since the sub-drivers of max8997 such as regulator
> and charger drivers can use the max8997 irq_domain to get the linux irq
> number
On Sat, Mar 24, 2012 at 03:19:49PM +0530, Thomas Abraham wrote:
> Add irq domain support for max8997 interrupts. The reverse mapping method
> used is linear mapping since the sub-drivers of max8997 such as regulator
> and charger drivers can use the max8997 irq_domain to get the linux irq
> number
On Sat, Mar 24, 2012 at 03:19:50PM +0530, Thomas Abraham wrote:
> Add device tree based discovery support for max8997.
I tried to apply this but it's collided with some other changes in the
driver which have arrived in the meantime and the rejects were too large
to fix up. I suspect it's mostly j
On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
> On 28 March 2012 22:33, Karol Lewandowski wrote:
> >> + For BUCK's:
No 's here, BTW.
> > - EN32KHz_AP
> > - EN32KHz_CP
> > - ENVICHG
> > - ESAFEOUT1
> > - ESAFEOUT2
> > - CHARGER
> > - CHARGER_CV
> > - CHARGER_TOPOFF
On Wed, Apr 18, 2012 at 03:01:02PM +0530, Thomas Abraham wrote:
> struct max8997_platform_data {
> /* IRQ */
> - int irq_base;
> int ono;
> int wakeup;
This will *still* break the build.
signature.asc
Description: Digital signature
On Wed, Apr 25, 2012 at 09:42:36AM +0530, Tushar Behera wrote:
> CC: Mark Brown
> CC: Ben Dooks
> CC: Kukjin Kim
> Signed-off-by: Tushar Behera
Acked-by: Mark Brown
signature.asc
Description: Digital signature
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote:
> With the addition of platform specific driver data in the spi-s3c64xx
> driver, the device name of spi controllers are changed. Accordingly,
> update the device name of spi clocks instances.
This should've been squashed into the pat
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote:
> + s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1);
Shouldn't we just set the name in the struct platform_device rather than
requiring the machine to pass it through by hand?
--
To unsubscribe from this list: send the line
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
> +- gpios: The gpio specifier for clock, mosi and miso interface lines (in no
> + particular order). The format of the gpio specifier depends on the gpio
> + controller.
This seems odd... This isn't a bitbanging controller, and s
On Wed, May 09, 2012 at 11:10:14AM +0200, Heiko Stübner wrote:
> Similar to the adc and rtc driver, all Samsung platforms reuse a common
> platform-device definition for the s3c64xx-spi and simply will set the
> correct
> name when the machine type is determined during boot.
Right, that doesn'
On Wed, May 09, 2012 at 09:40:26PM +0800, Thomas Abraham wrote:
> On 9 May 2012 16:52, Mark Brown wrote:
> > This should've been squashed into the patch that updated to use driver
> > data in order to avoid breaking bisection.
> This patch updates clock devname in th
On Wed, May 09, 2012 at 10:13:28PM +0800, Thomas Abraham wrote:
> On 9 May 2012 17:07, Mark Brown wrote:
> > On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
> >> +- gpios: The gpio specifier for clock, mosi and miso interface lines (in
> >> no
>
On Wed, May 09, 2012 at 10:22:26PM +0800, Thomas Abraham wrote:
> On 9 May 2012 18:55, Mark Brown wrote:
> > Yes, that's the normal way of handling this and is actually what the
> > code was originally doing - there's a bunch of ifdefed devices in
> > plat-samsung/
On Thu, May 10, 2012 at 12:39:29AM +0800, Thomas Abraham wrote:
> On 9 May 2012 22:32, Mark Brown wrote:
> > Yeah, I know. I'm saying we should try to come up with a binding for
> > this that can be used by new SPI contollers going forward so things are
> > consist
On Wed, May 09, 2012 at 09:54:53PM +0530, Yadwinder Singh wrote:
> This patch series adds support for max77686 which is a multifunction device
> which
> includes regulator (pmic), rtc and charger sub-blocks within it. The support
> for
> mfd driver and regulator driver are added by this patch ser
On Wed, May 09, 2012 at 09:54:54PM +0530, Yadwinder Singh wrote:
> +int max77686_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
> +{
> + int ret;
> +
> + ret = i2c_smbus_read_byte_data(i2c, reg);
> + if (ret < 0)
It would really be better if this used the regmap API - the regulato
On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:
> +/* Voltage maps in mV */
> +static const struct voltage_map_desc ldo_voltage_map_desc = {
> + .min = 800, .max = 3950,.step = 50, .n_bits = 6,
> +}; /* LDO3 ~ 5, 9 ~ 14, 16 ~ 26 */
Hrm, f
On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote:
> On Thu, May 10, 2012 at 12:17 AM, Mark Brown
> > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:
> >> + [MAX77686_EN32KHZ_AP] = NULL,
> >> + [MAX77686_EN32KHZ_CP] = NULL
On Thu, May 10, 2012 at 01:17:32AM +0800, Thomas Abraham wrote:
> On 9 May 2012 22:28, Mark Brown wrote:
> > This means that bisection will be broken - anything with only one tree
> > won't be able to load the SPI driver successfully until it's merged
> > with the
On Mon, May 14, 2012 at 10:52:46AM +0200, Heiko St??bner wrote:
> Am Montag, 14. Mai 2012, 01:51:00 schrieb Daniel Lezcano:
> > On 05/09/2012 04:08 PM, Daniel Lezcano wrote:
> > Are these patches ok for inclusion ?
> you might want to include the maintainer
> Kukjin Kim
> and the samsung
The Bells module now has a number assigned to it. Also hook up the WM9081
which is soldered down onto the board.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-s3c64xx/mach
We now have an additional classs of modules which are enumerated at I2C
address 0x22. Add hookup for these modules.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-crag6410.c |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c
b/arch/arm/mach
On Tue, May 15, 2012 at 05:58:12PM +0900, Kukjin Kim wrote:
> Looks good to me, but there is no '{ I2C_BOARD_INFO("wlf-gf-module", 0x20)
> },' in my tree.
> Just adding address 0x22 stuff is enough now?
Yes, it is - sorry, context diff for another project.
signature.asc
Description: Digital s
On Tue, May 15, 2012 at 07:17:11PM +0530, Yadwinder Singh Brar wrote:
> On Thu, May 10, 2012 at 12:17 AM, Mark Brown
> > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:
> >> + if (iodev->dev->of_node) {
> >> + ret = max77686
On Mon, May 14, 2012 at 04:06:16PM +0200, Daniel Lezcano wrote:
> The states are now part of the cpuidle_driver structure, so we can
> declare the states in this structure directly. That saves us an extra
> variable declaration and a memcpy.
Tested-by: Mark Brown
signature.asc
De
On Mon, May 14, 2012 at 04:06:17PM +0200, Daniel Lezcano wrote:
> The timekeeping is computed from the cpuidle core if we set
> the .en_core_tk_irqen flag. Let's use it and remove the duplicated
> code.
Tested-by: Mark Brown
signature.asc
Description: Digital signature
On Fri, May 18, 2012 at 03:03:31PM +0530, Thomas Abraham wrote:
> - s3c64xx_spi0_set_platdata(&s3c64xx_spi0_pdata, 0, 1);
> + s3c64xx_spi0_set_platdata("s3c6410-spi", NULL, 0, 1);
...
> + pd.src_clk_nr = src_clk_nr;
> + pd.cfg_gpio = (cfg_gpio) ? cfg_gpio : s3c64xx_spi0_cfg_gpio;
s primary I2C
> bus.It also includes IRQ and device tree support for MAX77686 chip.
Reviwed-by: Mark Brown
signature.asc
Description: Digital signature
On Thu, May 17, 2012 at 07:09:27PM +0530, Yadwinder Singh Brar wrote:
Looks mostly good. A couple of fairly small things:
> +static int max77686_get_voltage_sel(struct regulator_dev *rdev)
> +{
This looks like it should be regulator_get_voltage_sel_regmap().
> +static int max77686_set_voltage_
On Tue, May 22, 2012 at 03:53:11PM +0900, Kyungmin Park wrote:
> BTW, do you know that you're reviewing the same device driver patch
> from different person?
> One from Mr. Lee and another from Yadwinder.
> I wonder how to handle it finally. which one is choose?
Yes, I realise there's two differ
On Wed, May 23, 2012 at 02:33:28PM +0900, jonghwa3@samsung.com wrote:
> I inform you my mfd driver has been confirmed by Samuel Oritz and there
> is no mfd private API. This situation looks unusual that we registers
> mfd driver and regulator driver separately. But how should we do? For
> corp
On Wed, May 30, 2012 at 12:28:55AM -0700, Olof Johansson wrote:
> On Sun, May 20, 2012 at 2:21 AM, Mark Brown
> > This dev_name also isn't equivalent to dev_name() which makes matters
> > more confusing than they need to be.
> Looks like they use the name as t
On Wed, May 30, 2012 at 06:05:31PM +0800, Thomas Abraham wrote:
> On 30 May 2012 17:34, Mark Brown wrote:
> > Right, and there's no problem at all with using the name. The thing is
> > that there's no need to set the name at runtime since the struct device
> > b
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
index dbd5771..985e255 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410
No platform data yet as driver is not yet merged.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c
b/arch/arm/mach-s3c64xx/mach-crag6410-module.c
index 985e255
On Thu, May 31, 2012 at 10:05:42AM +0800, Thomas Abraham wrote:
> On 30 May 2012 18:13, Mark Brown wrote:
> > No there isn't. You've got things like s3c64xx_device_spi0 in
> > arch/arm/plat-samsung/devs.c (which you'd expect since the resources
> > that are p
On Fri, Jun 01, 2012 at 10:47:44AM +0800, Thomas Abraham wrote:
> 1. There is one instance of 'struct platform_device' for each of the
> spi controller instances (0/1/2) named "s3c64xx-spi" (in
> arch/arm/plat-samsung/devs.c).
Right, which looks rather like it is specific to s3c64xx at least give
Use the new irqdomain support in the WM8994 driver to dynamically allocate
the interrupt range for the WM8994 rather than doing it explicitly. This
is more idiomatic for modern interrupt usage.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/include/mach/crag6410.h |1 -
arch/arm/mach
Now that the WM831x driver uses irq_domain we can happily allow it to
assign its own IRQs.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/include/mach/crag6410.h |3 +--
arch/arm/mach-s3c64xx/mach-crag6410.c |1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git
On Sun, Jun 03, 2012 at 03:29:55PM +0200, Heiko St??bner wrote:
> request_threaded_irq(sc->ext_cd_irq, NULL,
>sdhci_s3c_gpio_card_detect_thread,
> - IRQF_TRIGGER_RISING |
> IRQF_TRIGGER_FALLING,
> +
On Tue, Jun 05, 2012 at 04:20:10PM +0900, Boojin Kim wrote:
> This patch uses config() function to configure DMA transmit options.
Acked-by: Mark Brown
It'd be good if we could get all the older Samsung platforms moved over
to dmaengine...
signature.asc
Description: Digital signature
On Mon, Jun 11, 2012 at 05:41:08PM +0530, Yadwinder Singh Brar wrote:
> For some hardwares ramp_delay for BUCKs is a configurable parameter which can
> be configured through DT or board file.This patch adds ramp_delay to regulator
> constraints and allow user to configure it for regulators which su
A small code saving and less error handling to worry about.
Signed-off-by: Mark Brown
---
drivers/i2c/busses/i2c-s3c2410.c | 35 +++
1 file changed, 7 insertions(+), 28 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410
There's no point in using _sync() as we don't really care if the suspend
has completed immediately.
Signed-off-by: Mark Brown
---
drivers/i2c/busses/i2c-s3c2410.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index f4e2341..b7aeb5d 100644
--- a
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c | 12 -
On Thu, Jun 28, 2012 at 08:51:44PM +0200, Linus Walleij wrote:
> I'm starting to wonder if it would not be possible to mass-convert these
> using coccinelle.
Probably, yes. I'm not actually going through these particularly,
really what I'm doing is looking to find drivers I run on my systems
tha
With the greater use of deferred probes we need to be more sure that
initdata is actually used only at system init rather than being used
by devices when they probe (which could happen after the main kernel
init has completed and is much more likely to now).
Signed-off-by: Mark Brown
---
arch
On Tue, Jul 03, 2012 at 02:04:04PM +0530, Sachin Kamat wrote:
> Current method for machine driver to register with the ASoC core is to use
> snd_soc_register_card() instead of creating a "soc-audio" platform device.
Applied, thanks (it's not a generic Samsung patch, it's just for the one
board BTW
flag day to convert the entire family of devices over.
Signed-off-by: Mark Brown
---
arch/arm/plat-samsung/Kconfig |4
arch/arm/plat-samsung/Makefile |4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drive
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index
On Thu, Jul 05, 2012 at 10:41:04AM +0200, Sylwester Nawrocki wrote:
> It doesn't seem right. Why is is the check for valid sdd->regs removed ?
> This should have rather been:
Mostly just because the structure of the code is a bit error prone when
making quick updates with the if statement afterwa
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index f4e2341
On Mon, Jul 09, 2012 at 03:52:29PM +0200, Wolfram Sang wrote:
> On Thu, Jun 28, 2012 at 01:55:38PM +0100, Mark Brown wrote:
> > A small code saving and less error handling to worry about.
> > Signed-off-by: Mark Brown
> What about devm for the clocks, too?
The devm_ versions
None of the GPIO IRQs are connected so there is no reason to specify a
base.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-smdk6410.c |1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c
b/arch/arm/mach-s3c64xx/mach-smdk6410.c
index df3103d
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote:
> The set_level callback in the controller data, which is used to configure
> the slave select line, cannot be supported when migrating the driver to
> device tree based discovery. Since all the platforms currently use gpio
> as the sl
On Tue, Jul 10, 2012 at 10:22:31PM +0530, Thomas Abraham wrote:
> In non-dt case, the platform code supplying the gpio number (slave
> select line) is responsible for requesting the gpio during the
> machine_init call. So the gpio request is not called in the driver for
> that gpio. In dt case, th
On Wed, Jul 11, 2012 at 04:45:59PM +0530, Thomas Abraham wrote:
> The set_level callback in the controller data, which is used to configure
> the slave select line, cannot be supported when migrating the driver to
> device tree based discovery. Since all the platforms currently use gpio
> as the sl
On Wed, Jul 11, 2012 at 05:51:13PM +0530, Thomas Abraham wrote:
> Based on your comments to add the gpio request, only two patches 5/6
> and 6/6 in this series have changed since. I have cc'ed you in the
> other 4 patches as well. If you do not have those patches, please let
> me know, I will repo
On Wed, Jul 11, 2012 at 09:10:59PM +0530, Thomas Abraham wrote:
> Changes since v4:
> - Includes the missing gpio request for slave select line gpio as suggested
> by Mark Brown.
These looked OK (and have had quite a bit of review already so we're
probably at the stage where inc
On Thu, Jul 12, 2012 at 06:11:05PM +0900, Kukjin Kim wrote:
> And Mark, this touches various samsung stuff in arch/arm/ so if you're ok,
> I'd like to pick this up in samsung tree. We don't want to see conflicts...
Well, simple conflicts aren't that big a deal... However, Thomas
mentioned that i
On Thu, Jul 12, 2012 at 07:13:37PM +0530, Thomas Abraham wrote:
> On 12 July 2012 18:32, Mark Brown wrote:
> > Well, simple conflicts aren't that big a deal... However, Thomas
> > mentioned that in order to test this he merged the SPI tree into your
> > tree
On Thu, Jul 12, 2012 at 03:56:36PM +0200, Sylwester Nawrocki wrote:
> These are the only two patches (out of 15) that are now needed to remove
> some obsolete s3c2410_gpio_* API. 1/2 was tested on Micro2440 board
> and 2/2 is an identical change which wasn't tested on a real H/W since
> I don't h
On Fri, Jul 13, 2012 at 10:37:12AM +0200, Wolfram Sang wrote:
> On Mon, Jul 09, 2012 at 02:58:10PM +0100, Mark Brown wrote:
> > The devm_ versions of the API aren't exported there yet and there's a
> > bug fix pending too but Russell and Mike have ignored the patches th
On Thu, Jul 12, 2012 at 08:09:09PM +0200, Sylwester Nawrocki wrote:
> Thanks, would that be Takashi Iwai and Jaroslav Kysela then ? I just
> want to get it right this time...
> Or perhaps could you take care of them ?
As with everything else look in MAINTAINERS, so me for ASoC.
signature.asc
De
On Tue, Jul 17, 2012 at 08:52:20AM +0900, Kukjin Kim wrote:
> So may I take then send this series via samsung tree? Because for samsung
> spi dt, the file has been touched in samsung tree so it helps to avoid bad
> conflicts.
May as well, yes.
signature.asc
Description: Digital signature
Commit 1c20c2 (spi: s3c64xx: Remove the 'set_level' callback from
controller data) didn't update all the users, breaking the build. Fix
that.
Signed-off-by: Mark Brown
---
arch/arm/mach-s3c64xx/mach-crag6410-module.c |1 -
1 file changed, 1 deletion(-)
diff --git a/arch/a
ten with -EBUSY
depriving the caller of information and breaking automatic probe deferral
pushing back from the GPIO level. Also reformat the non-DT log message
so it's not word wrapped and we can grep for it.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c |9 +
1 file c
want to configure them.
Without this fix Cragganmore systems can't talk to their SPI devices.
Signed-off-by: Mark Brown
---
drivers/spi/spi-s3c64xx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 7258b1
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown
Reviewed-by: Sylwester Nawrocki
Acked-by: Linus Walleij
---
drivers/spi/spi-s3c64xx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown
Acked-by: Linus Walleij
---
drive
401 - 500 of 1261 matches
Mail list logo
