Hi Chris & Ulf,
I hope you find this patch for next.
Thanks,
Seungwon Jeon
On Wed, May 21, 2014, Seungwon Jeon wrote:
> On Wed, May 21, 2014, Doug Anderson wrote:
> > If we happened to get a data error at just the wrong time the dw_mmc
> > driver could get into a state w
On Tue, July 15, 2014, Sonny Rao wrote:
> This patch changes the fifo reset code to follow the reset procedure
> outlined in the documentation of Synopsys Mobile storage host databook.
>
> Signed-off-by: Sonny Rao
> Signed-off-by: Yuvaraj Kumar C D
Acked-by: Seungwon Jeon
T
On Fri, July 11, 2014, Sonny Rao wrote:
> On Thu, Jul 10, 2014 at 5:28 AM, Seungwon Jeon wrote:
> > Hi Sonny,
> >
> > I have missed this patch.
> >
> > You finally choose to take extra interrupt handling.
> > If it is not harm, it's fine.
>
&
On Thu, July 10, 2014, Ulf Hansson wrote:
> On 10 July 2014 13:53, Seungwon Jeon wrote:
> > On Thu, July 10, 2014, Ulf Hansson wrote:
> >> On 10 July 2014 11:40, Jaehoon Chung wrote:
> >> > Hi, Ulf.
> >> >
> >> > On 07/10/2014 06:15 PM, Ulf
nd reprogram idmac */
> + dw_mci_idmac_reset(host);
> +
> + ret = true;
> +
> +ciu_out:
> + /* After a CTRL reset we need to have CIU set clock registers */
> + mci_send_cmd(host->cur_slot, SDMMC_CMD_UPD_CLK, 0);
> +
> + return ret;
> }
mc: dw_mmc: replace "disable-wp" from slot's quirk to host's
quirk
2nd and 4th are closely related 5th.
I think it shall be picked together. How about taking whole patch?
And I hope that it is applied for 3.16-rcX fix.
(Also, 3rd patch is close to fix patch.)
Kukjin,
Is it fine
ch/arm/boot/dts/exynos5800-peach-pi.dts | 16 +++-
> arch/arm/boot/dts/rk3066a-bqcurie2.dts | 16 +++-
> arch/arm/boot/dts/socfpga_arria5.dtsi |9 +++
> arch/arm/boot/dts/socfpga_cyclone5.dtsi|9 +++
> arch/arm/bo
On Tue, July 08, 2014,Yuvaraj Kumar wrote:
> On Mon, Jul 7, 2014 at 10:53 AM, Seungwon Jeon wrote:
> > On Fri, July 04, 2014, Seungwon Jeon wrote:
> >> On Tue, July 01, 2014. Yuvaraj Kumar wrote:
> >> > On Fri, Jun 27, 2014 at 4:48 PM, Seungwon Jeon
>
platform get_ro function, else try on board write protect */
> - if (slot->quirks & DW_MCI_SLOT_QUIRK_NO_WRITE_PROTECT)
It would be better to use host->quirks instead of brd->quirks
It's finally updated with host->pdata->quirks on probing.
Thanks,
Seungwon Jeon
--
To unsubscribe fr
gt;;
> samsung,dw-mshc-ciu-div = <3>;
> samsung,dw-mshc-sdr-timing = <2 3>;
> @@ -75,11 +70,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
>
On Fri, July 04, 2014, Seungwon Jeon wrote:
> On Tue, July 01, 2014. Yuvaraj Kumar wrote:
> > On Fri, Jun 27, 2014 at 4:48 PM, Seungwon Jeon wrote:
> > > Hi Yuvaraj,
> > >
> > > On Fri, June 27, 2014, Yuvaraj Kumar wrote:
> > >> On Thu, Jun 26
On Tue, July 01, 2014. Yuvaraj Kumar wrote:
> On Fri, Jun 27, 2014 at 4:48 PM, Seungwon Jeon wrote:
> > Hi Yuvaraj,
> >
> > On Fri, June 27, 2014, Yuvaraj Kumar wrote:
> >> On Thu, Jun 26, 2014 at 10:20 PM, Doug Anderson
> >> wrote:
> >> > Seun
On Fri, June 27, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Thu, Jun 26, 2014 at 3:30 AM, Seungwon Jeon wrote:
> > Hi Doug,
> >
> > On Thu, June 26, 2014, Doug Anderson wrote:
> >> Seungwon,
> >>
> >> On Wed, Jun 25, 2014 at 4:18 A
Hi Yuvaraj,
On Fri, June 27, 2014, Yuvaraj Kumar wrote:
> On Thu, Jun 26, 2014 at 10:20 PM, Doug Anderson wrote:
> > Seungwon,
> >
> > On Thu, Jun 26, 2014 at 3:41 AM, Seungwon Jeon wrote:
> >> On Thu, June 26, 2014, Doug Anderson wrote:
> >>> Seungwon
On Thu, June 26, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Jun 25, 2014 at 6:08 AM, Seungwon Jeon wrote:
> > On Mon, June 23, 2014, Yuvaraj Kumar C D wrote:
> >> Subject: [PATCH 3/3] mmc: dw_mmc: Support voltage changes
> >>
> >> From: Doug And
Hi Doug,
On Thu, June 26, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon wrote:
> >> >> + case MMC_POWER_ON:
> >> >> + if (!IS_ERR(mmc->supply.vqmmc) &&
> >> >
else
> + host->state = STATE_IDLE;
> }
>
> spin_unlock(&host->lock);
> @@ -1314,8 +1428,10 @@ static void dw_mci_tasklet_func(unsigned long priv)
>
> switch (state) {
> case STATE_IDLE:
> + case STATE_WAITING_CMD11_DONE:
&
> - } else {
> >> - ret = regulator_enable(host->vmmc);
> >> - if (ret) {
> >> - if (ret != -EPROBE_DEFER)
> >> - dev_err(host->dev,
> >> -
operty can be replaced to "cap-sd/mmc-highspeed".
>
> Signed-off-by: Jaehoon Chung
Looks good to me.
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> Changelog V3:
> - Merge "[PATCH 2/5] mmc: dw_mmc: rmove the "supports-highspeed"
> prop
On Wed, May 28, 2014, Jaehoon Chung wrote:
> Removed the parser for "supports-highspeed".
> It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at
> mmc_of_parse().
>
> Signed-off-by: Jaehoon Chung
Acked-by: Seungwon Jeon
Tahnks,
Seun
On Wed, May 28, 2014, Jaehoon Chung wrote:
> dw-mmc controller has the multiple slot.
> Then it needs to parse the property for each slot.
>
> Signed-off-by: Jaehoon Chung
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> Changelog V3:
> - Fix typo.
>
to move the DTs to use common mmc bindings. And
> > you could mark the documentation of the above binding as deprecated.
> I added the comment for deprecated into dw-mmc dt-binding doc file.
> "[PATCHv3,4/4] ARM: dts: replace the slot property into slot sub-node for
> dwmmc."
&
Can this be merged with your another patch, " [PATCH 2/5] mmc: dw_mmc: remove
the "supports-highspeed" property."?
On Mon, May 26, 2014, Jaehoon Chung wrote:
> dw-mmc controller can be support the multiple slot.
can support, it would be better to correct the above message.
- int idx, ret;
> + int ret;
> u32 clock_frequency;
>
> pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> @@ -2264,11 +2256,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct
> dw_mci *host)
> pdata->num_sl
instead of the
> device node.
>
> Signed-off-by: Ludovic Desroches
> Signed-off-by: Jaehoon Chung
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> Changelog V2:
> - Fix the typo.
>
> drivers/mmc/core/host.c | 13 +
> include/linux/mmc/ho
after "mmc: dw_mmc: change to use recommended reset
procedure"
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> Changes in v2:
> - Removed TODO
> - Set cmd to NULL before calling dw_mci_request_end()
>
> drivers/mmc/host/dw_mmc.c | 46 +++
On Wed, May 21, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon wrote:
> >> > >> >> + } else {
> >> > >> >> + /*
> >> >
On Tue, May 13, 2014, Seungwon Jeon wrote:
> Hi Doug,
>
> On Tue, May 13, 2014, Doug Anderson wrote:
> > Seungwon,
> >
> > On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon wrote:
> > > On Fri, May 09, 2014, Sonny Rao wrote:
> > >> On Thu, May
On Sat, May 17, 2014, Sonny Rao wrote:
> On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon wrote:
> > On Tuesday, May 13, Sonny Rao wrote:
> >> On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon
> >> wrote:
> >> > As I mentioned in previous versi
On Sat, May 17, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Thu, May 15, 2014 at 6:46 PM, Seungwon Jeon wrote:
> > On Wed, May 14, 2014, Doug Anderson wrote:
> >> Seungwon,
> >>
> >> On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon
> >> wrote:
On Wed, May 14, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon wrote:
> > Hi Doug,
> >
> > On Tue, May 13, 2014, Doug Anderson wrote:
> >> Seungwon,
> >>
> >> On Sat, May 10, 2014 at 7:11 AM, S
On Tuesday, May 13, Sonny Rao wrote:
> On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon wrote:
> > As I mentioned in previous version, you put all reset stuff in existing
> > fifo_reset function.
> > Although databook mentions ciu_reset case for SBE error, it's not obvi
}
> +
> + /* when using DMA next we reset the fifo again */
> + dw_mci_ctrl_reset(host, SDMMC_CTRL_FIFO_RESET);
> + }
> + } else {
> + dev_err(host->dev, "%s: Reset bits didn't clear", __fu
Hi Doug,
On Tue, May 13, 2014, Doug Anderson wrote:
> Seungwon,
>
> On Sat, May 10, 2014 at 7:11 AM, Seungwon Jeon wrote:
> > On Fri, May 09, 2014, Sonny Rao wrote:
> >> On Thu, May 8, 2014 at 2:42 AM, Yuvaraj Kumar wrote:
> >> > Any comments on this patch?
> +* If we don't have a command complete now
> >> we'll
> >> +* never get one since we just reset
> >> everything;
> >> +* better end the request.
> >> +
Hi Sonny,
Can you separate procedure?
Reset all are handled in fifo-reset.
And ciu reset is always needed for error handling?
Thanks,
Seungwon Jeon
On Sat, May 10, 2014, Sonny Rao wrote:
> On Fri, May 9, 2014 at 12:32 AM, Jaehoon Chung wrote:
> > Hi, Sonny.
> >
> > Y
...and they think something is wrong with their hardware.
>
> Remove the printouts. We'll leave it up to a higher level to report
> about errors.
Yes, your saying makes sense.
But in normal I/O, actual error information such as status below is useful,
isn't it?
Thanks,
Seungwon Je
the same thing anymore.
Signed-off-by: Seungwon Jeon
---
Note: This patch comes from "[PATCH] ARM: dts: disable MDMA1 node for smdk5420
board"
arch/arm/boot/dts/exynos5420-arndale-octa.dts | 12
arch/arm/boot/dts/exynos5420.dtsi |7 +++
2 files cha
On Tue, April 22, 2014, Tushar Behera wrote:
> On 22 April 2014 07:48, Kukjin Kim wrote:
> > Seungwon Jeon wrote:
> >>
> >
> > + Javi Merino and Tushar Behera
> >
> >> This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
> >>
This change is similar to commit 3da355c(ARM: dts: Disable MDMA1 node
for arndale-octa board). If MDMA1 region is configured with secure mode,
it makes the boot failure with the following.
Unhandled fault: imprecise external abort (0x1406) at 0x
Signed-off-by: Seungwon Jeon
---
arch
Hi Jaehoon,
On Mon, April 14, 2014, Jaehoon Chung wrote:
> Hi, Seungwon.
>
> On 03/26/2014 08:31 PM, Seungwon Jeon wrote:
> > ciu_div may not be common value for all speed mode.
> > So, it needs to be attached to CLKSEL timing.
> >
> > Signed-off-by: Seungwon Je
HS400 timing value set is added for SMDK5420.
And GPIO line for RCLK should be pull-down state.
Signed-off-by: Seungwon Jeon
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |6 ++
arch/arm/boot/dts/exynos5420-pinctrl.dtsi |7 +++
arch/arm/boot/dts/exynos5420
As dw-mshc-ciu-div is strongly close to timing property,
it is merged with each timing property.
Signed-off-by: Seungwon Jeon
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 12 +---
arch/arm/boot/dts/exynos4412-odroidx.dts |5 ++---
arch/arm/boot/dts/exynos4412
Implements HS400 support for exynos host driver.
And this patch includes some updates as new mode is added.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 140 +++---
drivers/mmc/host/dw_mmc-exynos.h | 14
drivers/mmc/host/dw_mmc.c
ciu_div may not be common value for all speed mode.
So, it needs to be attached to CLKSEL timing.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 75 ++
drivers/mmc/host/dw_mmc-exynos.h |1 +
2 files changed, 53 insertions(+), 23
Move some parts related to definition to header file.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 46 ---
drivers/mmc/host/dw_mmc-exynos.h | 55 ++
2 files changed, 61 insertions(+), 40 deletions
performance
is improved with the increased the max_blk_count.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 3a6721e..aeb38f9 100644
--- a/drivers/mmc/host
This patch-set includes several driver's updates.
Specially, HS400 mode is enabled for eMMC5.0 spec.
And it goes with "[PATCH v4 5/5] mmc: add support for HS400 mode of eMMC5.0"
Changes in v2:
(2/7) Reuse bus_hz for clock rate.
(3/7) Fix typo.
Seungwon Jeon (7)
Add checking whether the clock is valid.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index a67e784..a2d06c5 100644
--- a
On Mon, March 24, 2014, Jaehoon Chung wrote:
> Hi, Seungwon.
>
> On 03/21/2014 11:03 PM, Seungwon Jeon wrote:
> > Moves some parts related to definition to header file
> >
> > Signed-off-by: Seungwon Jeon
> > ---
> >
On Mon, March 24, 2014, Jaehoon Chung wrote:
> Hi, Seungwon.
>
> On 03/21/2014 11:03 PM, Seungwon Jeon wrote:
> > Adds checking whether the clock is valid.
> >
> > Signed-off-by: Seungwon Jeon
> > ---
> > drivers/mmc/host/dw_mmc-exynos.c | 14 +++
ciu_div may not be common value for all speed mode.
So, it needs to be attached to CLKSEL timing.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 75 ++
drivers/mmc/host/dw_mmc-exynos.h |1 +
2 files changed, 53 insertions(+), 23
HS400 timing value set is added for SMDK5420.
And GPIO line for RCLK should be pull-down state.
Signed-off-by: Seungwon Jeon
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt |6 ++
arch/arm/boot/dts/exynos5420-pinctrl.dtsi |7 +++
arch/arm/boot/dts/exynos5420
As dw-mshc-ciu-div is strongly close to timing property,
it is merged with each timing property.
Signed-off-by: Seungwon Jeon
---
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 12 +---
arch/arm/boot/dts/exynos4412-odroidx.dts |5 ++---
arch/arm/boot/dts/exynos4412
Implements HS400 support for Exynos's host driver.
And this patch includes some updates as new mode is added.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 140 +++---
drivers/mmc/host/dw_mmc-exynos.h | 14
drivers/mmc/host/dw_
Moves some parts related to definition to header file
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 46 ---
drivers/mmc/host/dw_mmc-exynos.h | 55 ++
2 files changed, 61 insertions(+), 40 deletions
Adds checking whether the clock is valid.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc-exynos.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index a67e784..89aa019 100644
performance
is improved with the increased the max_blk_count.
Signed-off-by: Seungwon Jeon
---
drivers/mmc/host/dw_mmc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 3a6721e..aeb38f9 100644
--- a/drivers/mmc/host
This patch-set includes several driver's updates.
Specially, HS400 mode is enabled for eMMC5.0 spec.
Seungwon Jeon (7):
mmc: dw_mmc: fix the max_blk_count in IDMAC
mmc: dw_mmc: exynos: don't use if clock isn't available
mmc: dw_mmc: exynos: move definitions to header fil
Clock lookup information is required as driver can manipulate
clock rate properly.
Signed-off-by: Seungwon Jeon
---
arch/arm/boot/dts/exynos4412.dtsi |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi
b/arch/arm/boot/dts/exynos4412.dtsi
clocks = <&clock 301>, <&clock 149>;
+ clock-name = "biu", "ciu";
Thanks,
Seungwon Jeon
>
> 于 2013年11月26日 12:32, Jaehoon Chung 写道:
> > Hi, Randy,
> >
> > It seems a problem that controller didn't find the clock s
On Mon, November 25, 2013, Olof Johansson wrote:
> Hi,
>
> On Sun, Nov 24, 2013 at 4:07 AM, randy wrote:
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA1
> >
> > After pull the merge of 3.13-rc1, the dw_mmc-exynos will make the boot
> > stock.In 3.13, it is just stocked udev in 3.13 and maks
On Thu, August 29, 2013, Tomasz Figa wrote:
> Hi Seungwon,
>
> On Thursday 29 of August 2013 19:36:28 Seungwon Jeon wrote:
> > Yuvaraj Kumar wrote:
> > > On Thu, Aug 29, 2013 at 3:14 PM, Seungwon Jeon
> wrote:
> > > > On Thu, August 29, 2013,
gt; move the dw_mci_socfpga_priv_init code to dw_mci_socfpga_parse_dt.
> We can use the dw_mci_socfpga_priv_init to do some actual platform
> specific initialisation.
>
> This patch is compile tested only.
CC'ed Dinh Nguyen
Thanks,
Seungwon Jeon
>
> changes since V2: none
>
> Signed-of
Yuvaraj Kumar wrote:
> On Thu, Aug 29, 2013 at 3:14 PM, Seungwon Jeon wrote:
> > On Thu, August 29, 2013, Alim Akhtar wrote:
> >> Hi Seungwon,
> >>
> >> On Thu, Aug 29, 2013 at 1:53 PM, Seungwon Jeon
> >> wrote:
> >> > On Wed, August 28,
On Thu, August 29, 2013, Alim Akhtar wrote:
> Hi Seungwon,
>
> On Thu, Aug 29, 2013 at 1:53 PM, Seungwon Jeon wrote:
> > On Wed, August 28, 2013, Yuvaraj Kumar C D wrote:
> >> Exynos5420 Mobile Storage Host controller has Security Management Unit
> >> (SMU) fo
OCK_NUM);
> + mci_writel(host, MPSCTRL0, DWMCI_MPSCTRL_SECURE_WRITE_BIT |
> + DWMCI_MPSCTRL_NON_SECURE_READ_BIT |
> + DWMCI_MPSCTRL_VALID |
> + DWMCI_MPSCTRL_NON_SECURE_WRITE_BIT);
Yuvaraj,
Just one thing to check.
ch#0 and #1 of
on Chung
Just now, this series looks good to me.
But direct access for SMU concerning (4/4, exynos: configure SMU in
exynos5420')
will be removed in driver before long.
I will sort your patches with the pending others.
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
>
> Best Regard
Hi Doug,
Do you have any update for this series?
Please let me know.
Thanks,
Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote:
> This series of patches addresses some suspend/resume problems with
> dw_mmc on exynos platforms, espeically exynos5420. Since
> suspend/resume is
t; +/*
> + * TODO: we should probably disable the clock to the card in the suspend
> path.
In suspend, clock is gated, isn't it?
Rather, no comment looks better, if intention is not clear.
Thanks,
Seungwon Jeon
> + */
> +static int dw_mci_exynos_suspend(struct de
q);
> + dw_mci_exynos_pmops.resume_noirq = dw_mci_exynos_resume_noirq;
> + dw_mci_exynos_pmops.thaw_noirq = dw_mci_exynos_resume_noirq;
> + dw_mci_exynos_pmops.restore_noirq = dw_mci_exynos_resume_noirq;
If CONFIG_PM_SLEEP is not defined, we don't need to add it.
ike there is no actual use case for that though origin Synopsys IP
supports.
Multi-slot might be not useful in terms of performance because shared bus
should be allowed.
(At least this is the way I see it, though)
As Exynos's host does so, other hosts which are introduced in Linux seems u
On Thu, July 11, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Jul 10, 2013 at 7:54 AM, Seungwon Jeon wrote:
> > On Wed, July 10, 2013, Doug Anderson wrote:
> >> If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up
> >> looping around
erted. This bit is 1 to indicate that it fired and we can
> + * clear it by writing a 1 back. Clear it to prevent interrupts from going
> off
> + * constantly.
> + */
As I know this bit is auto-cleared.
Did you find the cause of this problem?
How about your GPIO setting in sleep?
Cur
c_host corresponds to mmc_free_host. And mmc_add_host matches
with mmc_remove_host. Let's focus on mmc_alloc_host.
mmc_alloc_host is called prior to regulator_enable.
So, if regulator_enable is failed, call of mmc_free_host makes sense.
Thanks,
Seungwon Jeon
>
> -Doug
> --
> T
On Friday, April 05, 2013, Thomas Abraham wrote:
> With device core now able to setup the default pin configuration,
> the pin configuration code based on the deprecated Samsung specific
> gpio bindings is removed.
>
> Signed-off-by: Thomas Abraham
Acked-by: Seungwon Jeon
I
this atop:
>
> 0f6e73d mmc: dw_mmc: Add MSHC compatible for Exynos4412
>
> ...just to avoid the simple merge conflict when applying?
>
> Otherwise everything here looks great...
>
> -Doug
Thomas,
It's a conflict to merge. Please do rebase the patch.
Thanks,
Seungwon
in dw_mci_drv_data?
Considering the purpose, it would be good to remove.
And, could you change commit prefix for consistency?
dwmmc -> dw_mmc
Thanks,
Seungwon Jeon
>
> Signed-off-by: Thomas Abraham
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 38
> --
Doug, Thanks to work.
Looks good to me with other patches.
Acked-by: Seungwon Jeon
On Friday, November 30, 2012, Doug Anderson wrote:
> The "disable-wp" property is used to specify that a given SD card slot
> doesn't have a concept of write protect. This eliminates the ne
Hi Doug,
On Thursday, November 29, 2012, Doug Anderson wrote:
> Seungwon,
>
> Thanks for the review. See below for comments. If you'd like me to
> respin then please let me know. Otherwise I look forward to your ack.
>
> On Wed, Nov 28, 2012 at 1:29 AM, Seungwon Jeon
io property is empty?
I think wp-pin is valid for SD card, not eMMC/SDIO.
Of course, I know origin code did it.
How about removing whole checking routine?
Instead, new definition for this quirk can be added into
'dw_mci_of_quirks'(dw_mmc.c) and dts file.
Thanks,
Seungwon Jeon
> --
> 1.7.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
rm/mach-exynos/include/mach/dwmci.h
Hi Thomas,
The following parts are remained. Also, no used code.
Could you check it?
./plat-samsung/include/plat/devs.h:126:extern struct platform_device
exynos4_device_dwmci;
./Kconfig:111:config EXYNOS4_DEV_DWMCI
Thanks,
Seungwon Jeon
>
> diff --git a/
On Thursday, November 22, 2012, Doug Anderson wrote:
> On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon wrote:
> > Hi,
> >
> > wp-gpios has been implemented in dw_mmc-exynos.c
> > It can be reused for EXYNOS platform? We need to modify some though.
>
> Yup,
Hi,
wp-gpios has been implemented in dw_mmc-exynos.c
It can be reused for EXYNOS platform? We need to modify some though.
Thanks,
Seungwon Jeon
On Thursday, November 22, 2012, Doug Anderson wrote:
> On some SoCs (like exynos5250) you need to use an external GPIO for
> write protect
s from tasklet_card) already has a runtime_pm_put call, which would be
> unpaired in this code path.
>
> As there also could be other Samsung platforms affected that use the ext-gpio
> code, it's probably right to revert it for now. Or you see a easy fix :-) .
>
Hi,
I
a
> > separate fix patch.
>
> A separate fix patch would be good, please.
>
> (I'd normally take an updated patch but Stephen Rothwell's asked for
> people to hold off rebasing now that -rc7 is out, which is reasonable.)
Thomas,
Is there any work for fix?
Th
On Thursday, September 20, 2012, Thomas Abraham
wrote:
> On 19 September 2012 19:09, Seungwon Jeon wrote:
> > On Tuesday, September 18, 2012, Thomas Abraham
> > wrote:
> >> +#ifdef CONFIG_OF
> >> +/* given a slot id, find out the device node representing
On Thursday, September 20, 2012, Thomas Abraham
wrote:
> On 19 September 2012 19:12, Seungwon Jeon wrote:
> > On Tuesday, September 18, 2012, Thomas Abraham
> > wrote:
> >> +int dw_mci_exynos_probe(struct platform_device *pdev)
> >> +{
> >&
de);
> + drv_data = match->data;
In non-dt case, match has NULL.
Needed to check "pdev->dev.of_node"
Thanks,
Seungwon Jeon
> + return dw_mci_pltfm_register(pdev, drv_data);
> +}
> +
> +static struct platform_driver dw_mci_exynos_pltfm_driver = {
> +
s = 0;
> host->pdata = pdev->dev.platform_data;
> @@ -48,6 +50,12 @@ int dw_mci_pltfm_register(struct platform_device *pdev)
> if (!host->regs)
> return -ENOMEM;
>
> + if (host->drv_data->init) {
In non-Exynos platform,
idx = 0; idx < ARRAY_SIZE(of_quirks); idx++)
> + if (of_get_property(np, of_quirks[idx].quirk, NULL))
> + pdata->quirks |= of_quirks[idx].id;
> +
> + if (of_property_read_u32(np, "fifo-depth", &pdata->fifo_depth))
> + dev_i
looks good; pushed to mmc-next for 3.7. Jaehoon and Seungwon,
> if you reply soon with your ACK then I'll add it to this patchset.
Also, looks good to me.
But please check several patches before merging.
Sorry for late review.
Thanks,
Seungwon Jeon
>
> Thanks,
>
> - Chri
On Friday, September 07, 2012, Thomas Abraham wrote:
> Hi Seungwon,
>
> Thanks for reviewing the patch.
>
> On 5 September 2012 16:13, Seungwon Jeon wrote:
> > On Wednesday, September 05, 2012, Thomas Abraham
> > wrote:
> > Version 6 is right?
> >
>
;
> + card-detect-delay = <200>;
> + samsung,dw-mshc-ciu-div = <3>;
> + samsung,dw-mshc-sdr-timing = <2 3 3>;
> + samsung,dw-mshc-ddr-timing = <1 2 3>;
As adding dw-mshc-ciu-div, third field of dw-
_CLK_DIV;
> +
> + return 0;
Here, returning is any meaning?
There seems to be no error case.
> +}
> +
> +static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr)
> +{
> + /*
> + * Exynos4412 and Exynos5250 extends the use of CMD register wi
On Tuesday, August 28, 2012 Thomas Abraham wrote:
> Hi Seungwon,
>
> On 28 August 2012 12:36, Seungwon Jeon wrote:
> > Hi Thomas,
> >
> > Thank you for your effort.
> > Some reviews seems like to be omitted. Please check more.
> >
> > On
+ host->bus_hz = host->pdata->bus_hz;
> + else
> + host->bus_hz = clk_get_rate(host->ciu_clk);
I have remained comment in [PATCH 3/9] mmc: dw_mmc: lookup for optional biu and
ciu clocks
Could I get your opinion?
Thanks,
Seungwon
z = clk_get_rate(host->ciu_clk);
> + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS5250)
> + host->bus_hz /= SDMMC_CLKSEL_GET_DIVRATIO(
> + mci_readl(host, CLKSEL));
bus_hz should be recalculated for exynoxs4 as well.
Could you check t
way.
For example, to_platform_device macro is useful to get pointer of
platform_device.
Best regards,
Seungwon Jeon
> -updated driver data for all 4 mmc controllers of exynos5 SoC.
> -added non device-tree support for ctrl_id access.
>
> Signed-off-by: Girish K S
July 23, 2012, Thomas Abraham wrote:
> On 20 July 2012 16:08, Seungwon Jeon wrote:
> > July 20, 2012, Thomas Abraham wrote:
> >> On 19 July 2012 09:21, Seungwon Jeon wrote:
>
> [...]
>
> >> >> +static unsigned long exynos5250_dwmmc_c
1 - 100 of 185 matches
Mail list logo
