Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
n 02/05/2013 04:42 PM, Sean Paul wrote: > Use the compatible string in the device tree to determine which > registers/functions to use in the HDMI driver. Also changes the > references from v13 to 4210 and v14 to 4212 to reflect the IP > block version instead of the HDMI version. > diff --git a/Do

Re: [PATCH v4 4/7] ARM: Exynos: allow dt based discovery of mct controller using clocksource_of_init

2013-01-30 Thread Stephen Warren
On 01/28/2013 01:57 PM, Stephen Warren wrote: > On 01/21/2013 03:02 AM, Thomas Abraham wrote: >> Add entries to __clksrc_of_table so that Exynos MCT controller is >> discoverable >> using call to clocksource_of_init. With this change, it would be appropriate >>

Re: [PATCH v4 3/7] ARM: Exynos: add device tree support for MCT controller driver

2013-01-28 Thread Stephen Warren
later in this series, fairly quickly, Reviewed-by: Stephen Warren Sorry for the slow review. I'm not 100% sure if I like Mark's #global-interrupts suggestion or not, but I'd be fine with the binding either way, so choose as you see fit. -- To unsubscribe from this list: send the

Re: [PATCH v4 4/7] ARM: Exynos: allow dt based discovery of mct controller using clocksource_of_init

2013-01-28 Thread Stephen Warren
On 01/21/2013 03:02 AM, Thomas Abraham wrote: > Add entries to __clksrc_of_table so that Exynos MCT controller is discoverable > using call to clocksource_of_init. With this change, it would be appropriate > to > rename the function 'exynos4_timer_init' as 'mct_init' since it aptly > describes >

Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Stephen Warren
On 01/17/2013 01:34 AM, Linus Walleij wrote: > On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote: > >> From: Thomas Abraham >> >> Fix the incorrect compatible property value of pin-controller module >> EXYNOS5440 SoC. >> > (...) >> >> pinctrl { >> - compatible = "samsung,pin

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-14 Thread Stephen Warren
On 12/13/2012 10:50 PM, Naveen Krishna Chatradhi wrote: > The arbitrator is a general purpose function which uses two GPIOs to > communicate with another device to claim/release a bus. > diff --git a/Documentation/devicetree/bindings/i2c/arbitrator-i2c.txt > b/Documentation/devicetree/bindings/i2

Re: [RFC PATCH 1/4] ARM: S3C24XX: move s3c24xx-irq to drivers/irqchip

2012-11-12 Thread Stephen Warren
On 11/12/2012 06:47 AM, Heiko Stübner wrote: > Removes another part from plat-s3c24xx and also enables further > improvements happening in the correct location. > > Signed-off-by: Heiko Stuebner > --- > arch/arm/Kconfig |1 + > arch/arm/plat-s3c24xx/Makefile

Re: [PATCH 01/16] ARM: dts: exynos4210: Replace legacy GPIO bank nodes with pinctrl bank nodes

2012-10-10 Thread Stephen Warren
On 10/10/2012 01:26 AM, Linus Walleij wrote: > On Mon, Oct 8, 2012 at 10:39 AM, Tomasz Figa wrote: > >> Seuqential patches from this series introduce SoC-specific data parsing >> from device tree. >> >> This patch removes legacy GPIO bank nodes from exynos4210.dtsi and >> replaces them with nodes

Re: [RFC PATCH 16/16] Documentation: Update samsung-pinctrl device tree bindings documentation

2012-10-04 Thread Stephen Warren
On 09/28/2012 08:28 AM, Tomasz Figa wrote: > Signed-off-by: Tomasz Figa I think this binding looks reasonable now. I'm not sure if this series works with "git bisect" though? For example, perhaps you want to move patch 15 to the start so the new properties are present before the code attempts to

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-10-03 Thread Stephen Warren
On 10/02/2012 10:06 PM, Leela Krishna Amudala wrote: > On Mon, Oct 1, 2012 at 9:50 PM, Stephen Warren wrote: >> On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote: >>> Hello Stephen Warren, >>> >>> The binding names that I use in my dts file should match w

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-10-01 Thread Stephen Warren
On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote: > Hello Stephen Warren, > > The binding names that I use in my dts file should match with the > names given in > http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html > right? I don't think so; the bind

Re: [PATCH V2] ASoC: SAMSUNG: Add DT support for i2s

2012-09-27 Thread Stephen Warren
On 09/27/2012 04:25 AM, Padmavathi Venna wrote: > Add support for device based discovery. > +++ b/Documentation/devicetree/bindings/sound/samsung-i2s.txt > +i2s@0383 { > + compatible = "samsung,samsung-i2s"; > + reg = <0x0383 0x100>; > + tx-dma-channel-secondary = <&pdma0 8>;

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 12:35 PM, Tomasz Figa wrote: > On Tuesday 25 of September 2012 12:22:03 Stephen Warren wrote: ... >> BTW, how does the driver know what register addresses to use; I can see >> the base for each pin controller bank is in samsung,pctl-offset, but >> what describe

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 11:41 AM, Tomasz Figa wrote: > On Tuesday 25 of September 2012 10:49:11 Stephen Warren wrote: >> On 09/25/2012 03:37 AM, Tomasz Figa wrote: >>> Hi Stephen, >>> >>> On Monday 24 of September 2012 17:14:38 Stephen Warren wrote: >>>> On

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-25 Thread Stephen Warren
On 09/25/2012 03:37 AM, Tomasz Figa wrote: > Hi Stephen, > > On Monday 24 of September 2012 17:14:38 Stephen Warren wrote: >> On 09/24/2012 03:31 PM, Tomasz Figa wrote: >>> On Monday 24 of September 2012 11:42:15 Stephen Warren wrote: >>>> On 09/21/2012 0

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-24 Thread Stephen Warren
On 09/24/2012 03:31 PM, Tomasz Figa wrote: > On Monday 24 of September 2012 11:42:15 Stephen Warren wrote: >> On 09/21/2012 01:54 PM, Tomasz Figa wrote: >>> On Friday 21 of September 2012 12:56:41 Stephen Warren wrote: >>>> On 09/20/2012 02:53 AM, Tomasz Figa w

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-24 Thread Stephen Warren
On 09/21/2012 01:54 PM, Tomasz Figa wrote: > On Friday 21 of September 2012 12:56:41 Stephen Warren wrote: >> On 09/20/2012 02:53 AM, Tomasz Figa wrote: >>> The patch "pinctrl: samsung: Parse pin banks from DT" introduced >>> platform-specific data parsing

Re: [RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-24 Thread Stephen Warren
On 09/21/2012 01:31 PM, Tomasz Figa wrote: > On Friday 21 of September 2012 12:40:35 Stephen Warren wrote: >> On 09/20/2012 02:53 AM, Tomasz Figa wrote: >>> This RFC series is a work on replacing static platform-specific data in >>> pinctrl-samsung driver with data dyn

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-21 Thread Stephen Warren
On 09/20/2012 02:53 AM, Tomasz Figa wrote: > The patch "pinctrl: samsung: Parse pin banks from DT" introduced > platform-specific data parsing from DT. > > This patch adds all necessary nodes and properties to exynos4210 device > tree sources. > +++ b/arch/arm/boot/dts/exynos4210-pinctrl-banks.dt

Re: [RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-21 Thread Stephen Warren
On 09/20/2012 02:53 AM, Tomasz Figa wrote: > This RFC series is a work on replacing static platform-specific data in > pinctrl-samsung driver with data dynamically parsed from device tree. Hmm. I tend to think this is exactly the opposite of the correct direction; you end up wasting a whole ton of

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-21 Thread Stephen Warren
On 09/21/2012 01:22 AM, Inki Dae wrote: > 2012/9/21 Stephen Warren : >> On 09/21/2012 05:22 AM, Leela Krishna Amudala wrote: >>> This patch adds device tree based discovery support for exynos DRM-FIMD >>> driver which includes driver modification to handle platform data

Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-09-20 Thread Stephen Warren
On 09/21/2012 05:22 AM, Leela Krishna Amudala wrote: > This patch adds device tree based discovery support for exynos DRM-FIMD > driver which includes driver modification to handle platform data in > both the cases with DT and non-DT, Also adds the documentation for bindings. > diff --git a/Docume

Re: [PATCH 2/2] ARM: dts: exynos4: allow i2c0 bus to be configured using pinctrl interface

2012-09-10 Thread Stephen Warren
On 09/06/2012 05:14 AM, Thomas Abraham wrote: > On 6 September 2012 15:43, Tomasz Figa wrote: >> Hi Thomas, >> >> On Thursday 06 of September 2012 14:53:01 Thomas Abraham wrote: >>> compatible = "samsung,s3c2440-i2c"; >>> reg = <0x1386 0x100>; >>> inte

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-10 Thread Stephen Warren
On 09/06/2012 05:06 AM, Thomas Abraham wrote: > On 6 September 2012 15:04, Tomasz Figa wrote: >> Hi, >> >> This patch shows the problem of the need to explicitly migrate all drivers >> to pinctrl. >> >> Maybe we should consider extending the pinctrl subsystem to set the default >> state automatica

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-06 Thread Stephen Warren
> subsystem and gpiolib interface registers gpio chips with the gpiolib > subsystem. The information about the pins, pin groups, pin functions and > gpio chips, which are SoC specific, are parsed from device tree node. > > Cc: Linus Walleij > Cc: Kukjin Kim > Signed-of

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-23 Thread Stephen Warren
ies writing the client nodes, since all the related settings can be grouped together by whoever writes the pinctrl node, rather than every client author having to work out all the entries to include in the list. That all said, the way you've defined the binding is perfectly legitimate, and

Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding

2012-08-22 Thread Stephen Warren
On 08/22/2012 04:17 AM, Chris Ball wrote: > Hi, > > On Wed, Aug 22 2012, Shawn Guo wrote: >> The following is what I have on my mind. >> >> broken-cdcd-gpiosimplication >> --- >> no no SDHCI CD >> no yes

Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-21 Thread Stephen Warren
On 08/21/2012 05:25 AM, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Add a new device tree enabled pinctrl and gpiolib driver for Samsung >> SoC's. ... >> + The child node can also optionally specify one or more of the pin >> + configuration that should b

Re: [PATCH v3 6/6] mmc: sdhci-s3c: Add device tree support

2012-03-30 Thread Stephen Warren
On 03/30/2012 05:36 AM, Arnd Bergmann wrote: > On Friday 30 March 2012, Viresh Kumar wrote: >> On 3/27/2012 9:49 PM, Arnd Bergmann wrote: >>> These bindings came up in a discussion IRC today. I think it's rather bad >>> that >>> we can't agree on a common way to name the properties for mmc. We hav

Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface

2012-03-19 Thread Stephen Warren
On 03/11/2012 06:46 AM, Thomas Abraham wrote: > The platform specific callback to setup the sdhci pin mux and pin config > is removed and the pinctrl subsystem interface is used to setup the > mux and config. > @@ -643,8 +649,13 @@ static int __devinit sdhci_s3c_probe(struct > platform_device *pd

Re: [PATCH 1/5] pinctrl: add samsung pinctrl and gpiolib driver

2012-03-19 Thread Stephen Warren
On 03/11/2012 06:46 AM, Thomas Abraham wrote: > Add a new pinctrl and gpiolib driver for Samsung SoC's. This driver provides a > common framework for all Samsung SoC's to interface with the pinctrl and > gpiolib subsystems. > > This driver is split into two parts: the pinctrl interface and the gpi

RE: [PATCH] ARM: move CP15 definitions to separate header file

2012-01-20 Thread Stephen Warren
Russell King wrote at Friday, January 20, 2012 3:04 AM: > Avoid namespace conflicts with drivers over the CP15 definitions by > moving CP15 related prototypes and definitions to a private header > file. > > Signed-off-by: Russell King For Tegra, Acked-by: Stephen Warren Tes

RE: [RFC 1/3] pinctrl: add a driver for the OMAP pinmux

2011-11-22 Thread Stephen Warren
Tony Lindgren wrote at Tuesday, November 22, 2011 10:54 AM: > * Linus Walleij [22 03:30]: > > On Tue, Nov 22, 2011 at 12:09 PM, Thomas Abraham > > wrote: > > > On 17 November 2011 19:27, Linus Walleij wrote: > > >> > > >> Maybe I'm mistaken about the device tree ambitions, but > > >> I was s

RE: [PATCH] ARM: SAMSUNG: Save/restore GPIO drive strength across suspend/resume

2011-11-15 Thread Stephen Warren
Thomas Abraham wrote at Monday, November 14, 2011 12:37 PM: ... > I am not sure how this works, but with dynamic transitioning, will it > be possible to program the pinmux registers dynamically when a > driver/controller decides to idle for sometime and come back up again > (not a system wide suspe

RE: [PATCH] ARM: SAMSUNG: Save/restore GPIO drive strength across suspend/resume

2011-11-14 Thread Stephen Warren
Thomas Abraham wrote at Monday, November 14, 2011 6:57 AM: > On 12 November 2011 16:30, Linus Walleij wrote: > > On Sat, Nov 12, 2011 at 6:01 AM, Inderpal Singh > > wrote: > > > >> GPIO driver strength settings are not preserved across suspend/resume > >> for s5pc100, s5pv210 and Exynos platforms

RE: [PATCH 2/3] mmc: Add OF bindings support for mmc host controller capabilities

2011-10-11 Thread Stephen Warren
Thomas Abraham wrote at Sunday, October 09, 2011 12:58 AM: > On 5 October 2011 21:25, Stephen Warren wrote: > > Thomas Abraham wrote at Wednesday, October 05, 2011 8:28 AM: > >> On 5 October 2011 18:59, Rob Herring wrote: > >> > On 10/05/2011 05:13 AM, Thomas Abrah

RE: [PATCH 2/3] mmc: Add OF bindings support for mmc host controller capabilities

2011-10-05 Thread Stephen Warren
Thomas Abraham wrote at Wednesday, October 05, 2011 8:28 AM: > On 5 October 2011 18:59, Rob Herring wrote: > > On 10/05/2011 05:13 AM, Thomas Abraham wrote: > >> Device nodes representing sd/mmc controllers in a device tree would include > >> mmc host controller capabilities. Add support for parsi

<    1   2