Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Simon Glass
Hi Olof, On 25 February 2015 at 17:59, Olof Johansson o...@lixom.net wrote: On Tue, Feb 17, 2015 at 07:26:50PM -0700, Simon Glass wrote: Hi, On 16 February 2015 at 01:19, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-17 Thread Simon Glass
Hi, On 16 February 2015 at 01:19, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: Hello, The mainline ChromeOS Embedded Controller (EC) driver is still missing some features that are present in the

Re: [PATCH v2 05/10] mfd: cros_ec: Use struct cros_ec_command to communicate with the EC

2014-06-19 Thread Simon Glass
-by: Bill Richardson wfric...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Lee Jones lee.jo...@linaro.org Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH v2 08/10] mfd: cros_ec: Check result code from EC messages

2014-06-19 Thread Simon Glass
itself. This change lets the EC report its errors separately. [dianders: Added common function to cros_ec.c] Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org This is better. Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from

Re: [PATCH v2 10/10] mfd: cros_ec: move EC interrupt to cros_ec_keyb

2014-06-19 Thread Simon Glass
. Signed-off-by: Andrew Bresticker abres...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s...@chromium.org We never needed an EC-level interrupt, and have shipped at least three products now that use this code, so I think it is safe enough to declare

Re: [PATCH 02/10] mfd: cros_ec: IRQs for cros_ec should be optional

2014-06-17 Thread Simon Glass
...@chromium.org Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/10] mfd: cros_ec: Allow static din/dout buffers with cros_ec_register()

2014-06-17 Thread Simon Glass
devm allocation), but it's good to document it. [dianders: Resolved conflicts; documented that no code changes needed on mainline] Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s...@chromium.org

Re: [PATCH 04/10] mfd: cros_ec: Tweak struct cros_ec_device for clarity

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org The members of struct cros_ec_device were improperly commented, and intermixed the private and public sections. This is just cleanup to make it more obvious what goes with

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass
field. Except that it no longer prints I2C/SPI - i.e. the transport that is used. Is that not considered important? Anyway: Reviewed-by: Simon Glass s...@chromium.org Regards, Simon -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org Remove the three wrapper functions that talk to the EC without passing all the desired arguments and just use the underlying communication function that passes everything in

Re: [PATCH 09/10] mfd: cros_ec: Check result code from EC messages

2014-06-17 Thread Simon Glass
Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org Just because the host was able to talk to the EC doesn't mean that the EC was happy with what it was told. Errors in communincation are not the same as error messages from

Re: [PATCH 10/10] mfd: cros_ec: ec_dev-cmd_xfer() returns number of bytes received from EC

2014-06-17 Thread Simon Glass
Hi, On 16 June 2014 14:40, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org When communicating with the EC, the cmd_xfer() function should return the number of bytes it received from the EC, or negative on error. This is just for the I2C tunnel feature,

Re: [PATCH 07/10] mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:22, Doug Anderson diand...@chromium.org wrote: Simon, On Tue, Jun 17, 2014 at 8:39 PM, Simon Glass s...@chromium.org wrote: Hi Doug, On 16 June 2014 14:39, Doug Anderson diand...@chromium.org wrote: From: Bill Richardson wfric...@chromium.org struct

Re: [PATCH 08/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

2014-06-17 Thread Simon Glass
Hi Doug, On 17 June 2014 21:27, Doug Anderson diand...@chromium.org wrote: Simon, On Tue, Jun 17, 2014 at 8:42 PM, Simon Glass s...@chromium.org wrote: diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 4083796..dc37b6b 100644 --- a/drivers

Re: [PATCH 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable

2014-04-18 Thread Simon Glass
a timeout after a single loop. Let's be paranoid and make sure we do one last transfer after the timeout expires. Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly

2014-04-18 Thread Simon Glass
miscalculation causes the delay period to be far too short. Most noticably this impacts commands with a long turnaround time such as EC firmware reads and writes. Signed-off-by: David Hendricks dhend...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s

Re: [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-04-18 Thread Simon Glass
Hi Doug, On 17 April 2014 11:59, Doug Anderson diand...@chromium.org wrote: The main transfer function for cros_ec_spi can be called by more than one client at a time. Make sure that those clients don't stomp on each other by locking the bus for the duration of the transfer function. Is

Re: [PATCH 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources

2014-04-18 Thread Simon Glass
/chromiumos/platform/ec [dianders: took today's ToT version from the Chromium OS EC; deleted references to cros_ec_dev and cros_ec_lpc since those aren't upstream yet] Signed-off-by: Bill Richardson wfric...@chromium.org Signed-off-by: Doug Anderson diand...@chromium.org Reviewed-by: Simon Glass s

Re: [PATCH 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms

2014-04-18 Thread Simon Glass
believe the EC protocol should be changed on future platforms to poll for completion of I2C, but in the meantime this patch prevents failure. Reviewed-by: Simon Glass s...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-04-18 Thread Simon Glass
Hi Doug, On 18 April 2014 15:15, Doug Anderson diand...@chromium.org wrote: Simon, On Fri, Apr 18, 2014 at 10:28 AM, Simon Glass s...@chromium.org wrote: Hi Doug, On 17 April 2014 11:59, Doug Anderson diand...@chromium.org wrote: The main transfer function for cros_ec_spi can

Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

2014-04-16 Thread Simon Glass
Anderson diand...@chromium.org Signed-off-by: Simon Glass s...@chromium.org Signed-off-by: Michael Spang sp...@chromium.org Signed-off-by: Sean Paul seanp...@chromium.org --- Changes in v2: - Separated the overcurrent and retries changes into two patches. - No longer open code fet_is_enabled

Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

2014-04-16 Thread Simon Glass
Hi Doug, On 16 April 2014 15:25, Doug Anderson diand...@chromium.org wrote: Simon, On Wed, Apr 16, 2014 at 1:50 PM, Simon Glass s...@chromium.org wrote: +#define MAX_CTRL_READ_TRIES5 +#define MAX_FET_ENABLE_TRIES 1000 Gosh that is a lot of tries - should we maybe give up sooner

Re: [RFC] i2c: Providing hooks for i2c multimaster bus arbitration.

2013-02-11 Thread Simon Glass
On Mon, Feb 11, 2013 at 3:53 PM, Doug Anderson diand...@chromium.org wrote: Wolfram, On Sun, Feb 10, 2013 at 10:17 AM, Wolfram Sang w.s...@pengutronix.de wrote: On Mon, Feb 04, 2013 at 02:33:15PM +0530, Yuvaraj Kumar C D wrote: This RFC patch is w.r.t multimaster bus arbitration which is

Re: [RFC] i2c: Providing hooks for i2c multimaster bus arbitration.

2013-02-05 Thread Simon Glass
Hi, On Tue, Feb 5, 2013 at 9:33 PM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: On Wed, Feb 6, 2013 at 10:58 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: On Wed, Feb 6, 2013 at 5:48 AM, Doug Anderson diand...@chromium.org wrote: Yavaraj, On Mon, Feb 4, 2013 at 1:03 AM, Yuvaraj Kumar C D

Re: [PATCH 1/2] i2c-core: Add gpio based bus arbitration implementation

2012-12-19 Thread Simon Glass
On Wed, Dec 19, 2012 at 9:14 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Dec 19, 2012 at 12:32:01PM +, Grant Likely wrote: I'm not convinced on the design of this protocol. It won't scale beyond 2 bus masters and it seems very specific to the design of a specific

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Simon Glass
+Olof On Thu, Nov 29, 2012 at 8:34 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: The arbitrator is a general purpose function which uses two GPIOs to communicate with another device to claim/release a bus.