Re: [PATCH 1/3] dmaengine: pl330: Set residue in tx_status callback.

2013-09-17 Thread Vinod Koul
On Wed, Sep 11, 2013 at 11:38:03AM +0530, Padmavathi Venna wrote: From: Dylan Reid dgr...@chromium.org Fill txstate.residue with the amount of bytes remaining in the current transfer if the transfer is not complete. This will be of particular use to i2s DMA transfers, providing more

Re: [PATCH v3 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-09-17 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the comments. On Mon, Sep 16, 2013 at 3:58 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Shaik, Thanks for addressing my comments, it really looks much better now. I have few more comments, mostly minor issues. [...] + +const struct scaler_fmt

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread Tomasz Figa
Hi José, Please see my comments below. On Wednesday 11 of September 2013 11:08:27 José Miguel Gonçalves wrote: The Samsung serial driver currently does not support setting the RTS pin with an ioctl(TIOCMSET) call. This patch adds this support. Signed-off-by: José Miguel Gonçalves

[PATCH 4/4] ARM: dts: exynos: add PMU registers addresses and mask bit to watchdog node

2013-09-17 Thread Leela Krishna Amudala
This patch adds support for specifying the pmu registers and masking bit for watchdog to enable/disable and mask/unmask the watchdog reset request. Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/boot/dts/exynos5.dtsi|

[PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-17 Thread Leela Krishna Amudala
This patch parses the watchdog node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe and s2r scenarios. Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com ---

[PATCH 0/4] Add watchdog DT nodes and parse it to read PMU registers addresses

2013-09-17 Thread Leela Krishna Amudala
This patchset does the following things - Fixes the watchdog DT node name to follow convention - Adds watchdog DT node to Exynos5420 SoC - parse the watchdog device node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe

[PATCH 1/4] ARM: dts: Fix the watchdog DT node name for Exynos5

2013-09-17 Thread Leela Krishna Amudala
Fixes the watchdog DT node name for Exynos5 as per the DT node naming convention also update status property for Exynos5250 SoC. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- arch/arm/boot/dts/exynos5.dtsi|2 +- arch/arm/boot/dts/exynos5250.dtsi |3 ++- 2 files

Re: [PATCH] MAINTAINERS: Add DTS files to patterns for Samsung platform

2013-09-17 Thread Tomasz Figa
Hi Mark, On Thursday 12 of September 2013 11:57:29 Mark Brown wrote: From: Mark Brown broo...@linaro.org Help ensure that updates to the Samsung device trees get sent to the Samsung maintainers for review by adding file patterns to MAINTAINERS. Signed-off-by: Mark Brown broo...@linaro.org

Re: [PATCH] ARM: EXYNOS: remove CONFIG_MACH_EXYNOS[4,5]_DT config options

2013-09-17 Thread Tomasz Figa
Hi Bart, On Friday 13 of September 2013 11:28:31 Bartlomiej Zolnierkiewicz wrote: EXYNOS is now Device Tree (DT) only platform so it makes no sense to have config options responsible for enabling platform specific DT support. Moreover the kernel image won't even link if neither

Re: [PATCH] MAINTAINERS: Add DTS files to patterns for Samsung platform

2013-09-17 Thread Mark Brown
On Tue, Sep 17, 2013 at 12:31:20PM +0200, Tomasz Figa wrote: +F: arch/arm/boot/s3c* +F: arch/arm/boot/exynos* I believe it should be arch/arm/boot/dts/. Bah, so it should. I wonder why I did actually start seeing the appropriate things turning up after I did this patch then?

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Tomasz Figa
Hi Manish, Thanks for the patch. I have few comments inline, though. On Sunday 15 of September 2013 01:22:23 Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644

Re: [PATCH v7 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-09-17 Thread Arun Kumar K
Hi Sylwester, I'd like to propose a little re-design of this binding. The reason is that I've noticed issues related to the power domain and FIMC-LITE, FIMC-IS clocks handling sequences. This lead to a failure to disable the ISP power domain and to complete the system suspend/resume cycle.

Re: [PATCH v3 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-09-17 Thread Shaik Ameer Basha
Hi sylwester, Isn't scaler_hw_set_csc_coef() function configuring the colorspace ? Actually speaking this function should do the color space setting part. What the SCALER ip supports is CSC offset value for Y YCbCr to RGB : Zero offset of -16 offset for input RGB to YCbCr : Zero offset

Re: [PATCH] irqchip: exynos-combiner: remove hard-coded irq_base value

2013-09-17 Thread Tomasz Figa
Hi Chander, On Monday 16 of September 2013 11:01:22 Chander Kashyap wrote: Pass '0' in place of hardcoded irq_base value as first_irq parameter to irq_domain_add_simple in order to use linear irq domain. Signed-off-by: Chander Kashyap chander.kash...@linaro.org ---

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread José Miguel Gonçalves
Hi Tomasz, On 17-09-2013 11:18, Tomasz Figa wrote: Hi José, Please see my comments below. On Wednesday 11 of September 2013 11:08:27 José Miguel Gonçalves wrote: The Samsung serial driver currently does not support setting the RTS pin with an ioctl(TIOCMSET) call. This patch adds this

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-17 Thread Tomasz Figa
Hi Leela, Please see my comments below. On Tuesday 17 of September 2013 16:13:42 Leela Krishna Amudala wrote: This patch parses the watchdog node to read pmu wdt sys registers addresses and do mask/unmask enable/disable of WDT in probe and s2r scenarios. Reviewed-by: Doug Anderson

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Felipe Balbi
Hi, On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: *Ping!* Are there still unanswered concerns left with this patch? I hope my prior mails could clear up why I think that the PMU register description in the device tree for a specific PHY is represents the hardware more

Re: [PATCH v11 0/8] PHY framework

2013-09-17 Thread Felipe Balbi
On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Wednesday 28 August 2013 12:50 AM, Felipe Balbi wrote: Hi, On Mon, Aug

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Tomasz Figa
Hi Felipe, On Tuesday 17 of September 2013 10:36:16 Felipe Balbi wrote: Hi, On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: *Ping!* Are there still unanswered concerns left with this patch? I hope my prior mails could clear up why I think that the PMU register

Re: [PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-09-17 Thread Felipe Balbi
On Tue, Sep 17, 2013 at 05:53:31PM +0200, Tomasz Figa wrote: Hi Felipe, On Tuesday 17 of September 2013 10:36:16 Felipe Balbi wrote: Hi, On Tue, Aug 27, 2013 at 01:27:48PM -0700, Julius Werner wrote: *Ping!* Are there still unanswered concerns left with this patch? I hope my

[PATCH] i2c: s3c2410: fix clk_disable/clk_unprepare warnings

2013-09-17 Thread Kim Phillips
commit d16933b33914a6dff38a4ecbe8edce44a17898e8 i2c: s3c2410: Move location of clk_prepare_enable() call in probe function refactored clk_enable and clk_disable calls yet neglected to remove the clk_disable_unprepare call in the module's remove(). It helps remove warnings on an arndale during

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Manish Badarkhe
Hi Tomasz On Tue, Sep 17, 2013 at 4:49 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Manish, Thanks for the patch. I have few comments inline, though. On Sunday 15 of September 2013 01:22:23 Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources.

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Dmitry Torokhov
Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. And the benefit of this would be...? There are still resources that are managed in traditional way and I really dislike mixing the 2

Re: [PATCH] Input: gpio-keys - update to devm_* API

2013-09-17 Thread Manish Badarkhe
Hi Dmitry, On Wed, Sep 18, 2013 at 12:22 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Manish, On Sun, Sep 15, 2013 at 01:22:23AM +0530, Manish Badarkhe wrote: Update the code to use devm_* API so that driver core will manage resources. And the benefit of this would be...?

Re: [PATCH] serial: samsung: add support for manual RTS setting

2013-09-17 Thread José Miguel Gonçalves
On 17-09-2013 16:21, Tomasz Figa wrote: I had the following scenario in mind: 1) enable CRTSCTS, 2) set RTS status using the IOCTL, 3) disable CRTSCTS, 4) do something, 5) enable CRTSCTS again. I would expect that the value set in point 2 would be still valid after point 5, while it will be

Re: [PATCH v7 01/13] [media] exynos5-is: Adding media device driver for exynos5

2013-09-17 Thread Sylwester Nawrocki
Hi Arun, On 09/17/2013 01:29 PM, Arun Kumar K wrote: Wont this make fimc-is to be enabled to use fimc-lite? Hmm, it would be runtime PM active, yes. But it doesn't mean the Cortex-A5's firmware would need to be running. As such there is no dependency like that in hardware and we can use

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-17 Thread Doug Anderson
Tomasz, On Tue, Sep 17, 2013 at 6:30 AM, Tomasz Figa t.f...@samsung.com wrote: --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt @@ -7,8 +7,20 @@ occurred. Required properties: - compatible : should be