are not even tried to be registered. Otherwise there would a problem with
configs where CONFIG_S3C24XX_GPIO_EXTRA is set to a non zero value.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
arch/arm/mach-s3c2410/include/mach/gpio.h | 25 -
arch/arm/plat-s3c24xx/gpiolib.c
or S3C_GPIO_PULL_DOWN.
Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull fields
in the s3c2442 cpu init function to the new pulldown helper functions.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
arch/arm/mach-s3c2440/Kconfig |1 +
arch/arm/mach-s3c2440
Ben Dooks wrote:
On 24/09/10 19:24, Lars-Peter Clausen wrote:
The gta02 header file still uses the old S3C2410_GPJx defines instead of the
S3C2410_GPJ(x) macro. Since the S3C2410_GPJx defines have already been
removed
this causes a build failure.
This patches fixes the issue by doing a
s
Hi,
On 01/21/2013 02:37 PM, Naveen Krishna Chatradhi wrote:
This patch add an ADC IP found on EXYNOS5 series socs from Samsung.
Also adds the Documentation for device tree bindings.
[...]
diff --git a/drivers/iio/adc/exynos5_adc.c b/drivers/iio/adc/exynos5_adc.c
new file mode 100644
index
On 01/24/2013 01:42 AM, Doug Anderson wrote:
Lars,
On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote:
Few doubts regarding the mappings and child device handling.
Kindly, suggest me better methods.
The patch looks mostly good now. As for the mappings, the problem
On 01/24/2013 03:20 PM, Naveen Krishna Ch wrote:
On 24 January 2013 15:24, Lars-Peter Clausen l...@metafoo.de wrote:
On 01/24/2013 01:42 AM, Doug Anderson wrote:
Lars,
On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote:
Few doubts regarding the mappings and child
On 01/24/2013 05:12 PM, Doug Anderson wrote:
Lars,
Thank you for your comments / thoughts...
Hi,
On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de wrote:
adc: adc@12D1 {
#io-channel-cells = 1;
io-channel-output-names = adc1, adc2
On 01/24/2013 08:15 PM, Tomasz Figa wrote:
Hi,
On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote:
On 01/24/2013 05:12 PM, Doug Anderson wrote:
Lars,
Thank you for your comments / thoughts...
Hi,
On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen l...@metafoo.de
wrote
On 02/13/2013 02:16 PM, Naveen Krishna Ch wrote:
Please ignore the unfinished previous mail.
On 13 February 2013 08:18, Naveen Krishna Ch naveenkrishna...@gmail.com
wrote:
On 13 February 2013 02:37, Guenter Roeck li...@roeck-us.net wrote:
On Wed, Jan 23, 2013 at 04:58:06AM -,
On 02/13/2013 02:53 PM, Naveen Krishna Ch wrote:
[...]
ADC driver will use of_platform_populate() to populate the child nodes
(ntc thermistors in my case)
I've modified the NTC driver to support DT. in probe
chan = iio_channel_get(pdev-dev, adcX);
and using id field to use respective ADC
-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Looks good.
Reviewed-by: Lars-Peter Clausen l...@metafoo.de
One minor thing though, there are a couple of places where you break a line
into multiple lines, even though the line fits easily inside the 80 chars
per line limit. In my opinion
On 02/15/2013 02:17 PM, Naveen Krishna Ch wrote:
On 15 February 2013 18:43, Lars-Peter Clausen l...@metafoo.de wrote:
On 02/15/2013 07:56 AM, Naveen Krishna Chatradhi wrote:
This patch adds New driver to support:
1. Supports ADC IF found on EXYNOS4412/EXYNOS5250
and future SoCs from
On 03/06/2013 05:11 AM, Naveen Krishna Chatradhi wrote:
From: Naveen Krishna Ch ch.nav...@samsung.com
Fixes the compilation warnings and potential NULL pointer
dereferencing pointed out by Dan Carpenter.
I'd say that's a rather un-potential NULL pointer dereferencing, but if it
makes the
On 03/13/2013 07:01 PM, Doug Anderson wrote:
Naveen,
On Tue, Mar 12, 2013 at 9:48 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
Doug, There was a comment from Lars regarding the match not
being NULL, if driver depends on CONFIG_OF. So, i've removed
the NULL check in v2 of this
On 03/13/2013 07:23 PM, Doug Anderson wrote:
Lars,
On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen l...@metafoo.de wrote:
Agreed. Adding the dependency on OF in Kconfig should be all that is needed.
I think changing the timeout from 'unsigned long' to 'long' is also
legit (to match
On 03/13/2013 07:35 PM, Lars-Peter Clausen wrote:
On 03/13/2013 07:23 PM, Doug Anderson wrote:
Lars,
On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen l...@metafoo.de wrote:
Agreed. Adding the dependency on OF in Kconfig should be all that is needed.
I think changing the timeout from
Anderson diand...@chromium.org
Cc: Lars-Peter Clausen l...@metafoo.de
---
Discussion thread for this patch can be found at
http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last
I've not seen any reference to spin lock usage in IIO.
Kindly, suggest me if there is a better way
On 03/16/2013 01:37 AM, Doug Anderson wrote:
On Fri, Mar 15, 2013 at 2:53 PM, Lars-Peter Clausen l...@metafoo.de wrote:
What exactly is the spinlock protecting against here? Concurrent runs of
exynos_adc_isr? This is probably not issue in the first place.
What you want to protect against
On 04/03/2013 07:06 PM, Doug Anderson wrote:
Lars,
On Sat, Mar 16, 2013 at 7:41 AM, Lars-Peter Clausen l...@metafoo.de wrote:
I think you still need the mutex for serialization, otherwise the requests
would just cancel each other out. Btw. what happens if you start a conversion
while
On 04/05/2013 04:56 PM, Doug Anderson wrote:
Lars,
On Fri, Apr 5, 2013 at 1:53 AM, Lars-Peter Clausen l...@metafoo.de wrote:
Since we sleep inside the protected section we need to use a mutex.
Ah, good point.
It's not the timeout case I'm worried about, but the case where the transfer
On 04/11/2013 07:19 PM, Mark Brown wrote:
On Thu, Apr 11, 2013 at 07:08:42PM +0200, Arnd Bergmann wrote:
On Thursday 11 April 2013, Mark Brown wrote:
This doesn't apply to my topic/samsung branch, can you please regenerate
it against that or let me know what to apply it against?
This one
be used instead of open
coding this. Lars-Peter Clausen and Lee Jones have been working on
making this a totally generic driver, right now it's a library.
Ok, I see. I'll drop this patch from my series then and will let someone
else handle this driver in 3.11. We can probably live without
On 05/20/2014 09:16 PM, Tomasz Figa wrote:
Hi Rickard,
On 20.05.2014 21:12, Rickard Strandqvist wrote:
Hi Tomasz
What I based my patch on is really because of this line:
if (substream)
snd_pcm_period_elapsed(substream);
Boojin Kim thought that this was needed, if this is true
On 06/05/2014 03:20 PM, Arnd Bergmann wrote:
The s3c24xx sound support keeps giving randconfig build errors, this
is a new attempt to solve it by moving the driver over to use dmaengine
exclusively.
The removal of the legacy DMA support and the addition of the
s3c24xx_dma_filter pointer are
On 01/03/2012 12:54 PM, Thomas Abraham wrote:
Hi Lars,
On 3 January 2012 14:36, Lars-Peter Clausen l...@metafoo.de wrote:
On 01/02/2012 06:54 AM, Thomas Abraham wrote:
The platform-lcd driver depends on platform-specific callbacks to setup the
lcd panel. These callbacks are supplied using
On 01/03/2012 06:07 PM, Thomas Abraham wrote:
On 3 January 2012 17:56, Lars-Peter Clausen l...@metafoo.de wrote:
On 01/03/2012 12:54 PM, Thomas Abraham wrote:
Hi Lars,
On 3 January 2012 14:36, Lars-Peter Clausen l...@metafoo.de wrote:
On 01/02/2012 06:54 AM, Thomas Abraham wrote
[...]
diff --git a/Documentation/devicetree/bindings/lcd/lcd-pwrctrl.txt
b/Documentation/devicetree/bindings/lcd/lcd-pwrctrl.txt
new file mode 100644
index 000..941e2ff
--- /dev/null
+++ b/Documentation/devicetree/bindings/lcd/lcd-pwrctrl.txt
@@ -0,0 +1,39 @@
+* Power controller
On 01/07/2012 07:23 PM, Russell King - ARM Linux wrote:
On Thu, Jan 05, 2012 at 09:12:26PM +0530, Thomas Abraham wrote:
Add a lcd panel driver for simple raster-type lcd's which uses a gpio
controlled panel reset. The driver controls the nRESET line of the panel
using a gpio connected from the
-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Cc: Doug Anderson diand...@chromium.org
Cc: Lars-Peter Clausen l...@metafoo.de
---
Changes since v1:
As per discussion at
http://marc.info/?l=linux-kernelm=136517637228869w=3
This patch does the following
1. use wait_for_completion_timeout instead
On 10/19/2013 06:43 PM, Mark Brown wrote:
From: Mark Brown broo...@linaro.org
Some devices have more than just simple TX and RX DMA channels, for example
modern Samsung I2S IPs support a secondary transmit DMA stream which is
mixed into the primary stream during playback. Allow such devices
On 10/23/2013 01:30 PM, Mark Brown wrote:
On Tue, Oct 22, 2013 at 01:45:17PM +0200, Lars-Peter Clausen wrote:
On 10/19/2013 06:43 PM, Mark Brown wrote:
Some devices have more than just simple TX and RX DMA channels, for example
modern Samsung I2S IPs support a secondary transmit DMA stream
either S3C_GPIO_PULL_UP or S3C_GPIO_PULL_DOWN.
Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull
fields
in the s3c2442 cpu init function to the new pulldown helper functions.
Based on patch from Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Vasily Khoruzhick anars
On 11/30/2010 01:01 PM, Vasily Khoruzhick wrote:
On Tuesday 30 November 2010 13:53:43 Lars-Peter Clausen wrote:
Hmm...how about s3c_gpio_setpull_1updown(...)?
And actually, not used 3rd argument, pull now.
I prefer follwoing.
You need the 4th arguemnt, because the s3c2440 only supports
On 11/30/2010 03:33 PM, Vasily Khoruzhick wrote:
On Tuesday 30 November 2010 15:12:37 Lars-Peter Clausen wrote:
Hi
While this might work for setting the pullup, what to you want to return in
get_pull?
Some custom value like S3C_GPIO_PULL_ENABLED?
Well, or we could use a custom setter
this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull
fields
in the s3c244{0,2}_map_io function to the new pulldown helper functions.
Based on patch from Lars-Peter Clausen l...@metafoo.de
Signed-off-by: Vasily Khoruzhick anars...@gmail.com
---
v2: adapt patch for 2.6.37-rc1
v3: restore
On 07/04/2014 01:04 PM, Sylwester Nawrocki wrote:
On 22/05/14 20:53, Mark Brown wrote:
+ ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S
+ | SND_SOC_DAIFMT_NB_NF
+ | SND_SOC_DAIFMT_CBM_CFM);
+ if
On 07/04/2014 01:24 PM, Sylwester Nawrocki wrote:
On 04/07/14 13:10, Lars-Peter Clausen wrote:
On 07/04/2014 01:04 PM, Sylwester Nawrocki wrote:
On 22/05/14 20:53, Mark Brown wrote:
+ ret = snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S
On 12/02/2014 06:38 AM, Padma Venkat wrote:
Hi Vinod/Lars,
On 11/26/14, Padmavathi Venna padm...@samsung.com wrote:
Fill txstate.residue with the amount of bytes remaining in the current
transfer if the transfer is not complete. This will be of particular
use to i2s DMA transfers, providing
On 12/03/2014 05:47 AM, Padma Venkat wrote:
Hi Lars,
[snip]
+
+ ret = dma_cookie_status(chan, cookie, txstate);
+ if (ret == DMA_COMPLETE || !txstate)
+ return ret;
+
+ used = txstate-used;
+
+ spin_lock_irqsave(pch-lock, flags);
+ sar = readl(regs +
Hi,
A few small comments inline.
On 01/05/2015 12:25 PM, Inha Song wrote:
--- /dev/null
+++ b/sound/soc/samsung/trats2_wm1811.c
@@ -0,0 +1,216 @@
[...]
+#include linux/of.h
+#include linux/module.h
+#include linux/clk.h
+#include sound/soc.h
+#include sound/pcm_params.h
+#include i2s.h
On 04/16/2015 12:33 PM, Sylwester Nawrocki wrote:
On 16/04/15 12:10, Charles Keepax wrote:
Commit 523c5b89640e (i2c: Remove support for legacy PM) removed the PM
ops from the bus type, which causes the pm operations on the s3c2410
adapter device to fail (-ENOSUPP in rpm_callback). The adapter
41 matches
Mail list logo
