Re: [PATCH V2 1/7] ARM: SAMSUNG: add additional registers and SFR definitions for writeback

2012-07-19 Thread Tomasz Figa
Hi Leela, On Thursday 19 of July 2012 18:30:44 Leela Krishna Amudala wrote: Hi Tomasz, On Wed, Jul 18, 2012 at 4:35 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi, On Wednesday 18 of July 2012 11:27:27 Leela Krishna Amudala wrote: This patch updates the register address offsets

Re: [PATCH 1/3] Move FIMD register headers to include/video/

2012-07-31 Thread Tomasz Figa
, possibly even more, as opposed to a single load from a variant struct). I would stay with the way used in s3c-fb driver, using variant structs describing FIMD revisions. Best regards, Tomasz Figa Best regards, Jingoo Han CC'ed Marek. To Leela Krishna Amudala, Don't add

Re: [PATCH 0/1] S3C244X/S3C64XX SoC camera host interface driver

2012-08-11 Thread Tomasz Figa
of S3C64xx and any needed stream duplication and rescaling is done in later processing, so it might be wise to migrate to yours. Best regards, Tomasz Figa The patch to follow only adds the CAMIF driver, the other two required for the camera on Mini2440 board to work (OV9650 sensor driver

Re: [PATCH 0/1] S3C244X/S3C64XX SoC camera host interface driver

2012-08-11 Thread Tomasz Figa
On Saturday 11 of August 2012 21:32:15 Sylwester Nawrocki wrote: On 08/11/2012 08:39 PM, Tomasz Figa wrote: Hi, On Saturday 11 of August 2012 20:06:13 Sylwester Nawrocki wrote: Hi all, This patch adds a driver for Samsung S3C244X/S3C64XX SoC series camera host interface. My

[PATCH 1/3] ARM: EXYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx

2012-08-28 Thread Tomasz Figa
-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/include/mach/gpio.h | 32 +++--- arch/arm/mach-exynos/mach-nuri.c | 16 +++ arch/arm/mach-exynos/mach-origen.c | 6 +++--- arch/arm/mach-exynos/mach-trats.c | 4 ++-- arch/arm

[PATCH 2/3] gpio: samsung: Add support for Exynos4x12 SoCs

2012-08-28 Thread Tomasz Figa
0x24 GPM10x280 0x28 GPM20x2A0 0x2C GPM30x2C0 0x30 GPM40x2E0 0x34 GPX00xC00 x GPX10xC20 x GPX20xC40 x GPX30xC60 x Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach

[PATCH 3/3] ARM: EXYNOS: Add support for FIMC cam port B GPIO setup on Exynos4x12

2012-08-28 Thread Tomasz Figa
Exynos4x12 SoCs use different GPIO pins for FIMC cam port B and this patch modifies the setup code to take it into account. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/setup-fimc.c | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/mach

[PATCH] ARM: EXYNOS: Use non-secure MDMA1

2012-08-28 Thread Tomasz Figa
Using secure MDMA1 on TrustZone-enabled boards causes early boot crash, so use non-secure instead. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/dma.c | 2 +- arch/arm/mach-exynos/include/mach/map.h | 3

[PATCH] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-08-28 Thread Tomasz Figa
Exynos4412 uses different information register for each core. This patch adjusts the bring-up code to take that into account. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 25 - 1

Re: [PATCH] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-08-28 Thread Tomasz Figa
Hi, Thanks for reviewing the patch. On Tuesday 28 of August 2012 09:21:40 Stephen Boyd wrote: On 8/28/2012 4:13 AM, Tomasz Figa wrote: diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 36c3984..1114ced 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b

Re: [PATCH 1/3] ARM: EXYNOS: Use EXYNOS4210_GPEx instead of EXYNOS4_GPEx

2012-08-29 Thread Tomasz Figa
mentioned. OK, I will drop this patchset for the time being. Let's get the pinctrl driver merged first and then investigate Exynos4x12 support in it. Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

[PATCH v2] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-08-29 Thread Tomasz Figa
Exynos4412 uses different information register for each core. This patch adjusts the bring-up code to take that into account. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 27

[PATCH 1/6] ARM: dts: Move parts common to Exynos4 from Exynos4210.dtsi to Exynos4.dtsi

2012-08-30 Thread Tomasz Figa
Most definitions from Exynos4210.dtsi can be applied for other SoCs from Exynos4 line as well, so move the common part into separate file that can be included by dtsi files of other Exynos4 SoCs (as well as current Exynos4210.dtsi). Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off

[PATCH RESEND 0/6] ARM: EXYNOS: Add support for Trats board using device tree

2012-08-30 Thread Tomasz Figa
/msg1328117.html This is a resend, because previous messages somehow did not get to the mailing lists. Tomasz Figa (6): ARM: dts: Move parts common to Exynos4 from Exynos4210.dtsi to Exynos4.dtsi ARM: EXYNOS: exynos4-dt: Use exynos4 prefix instead of exynos4210 ARM: Exynos4: dts: Specify

[PATCH 3/6] ARM: Exynos4: dts: Specify address and size cells for i2c controllers

2012-08-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 5e99503..5935588

[PATCH 2/6] ARM: EXYNOS: exynos4-dt: Use exynos4 prefix instead of exynos4210

2012-08-30 Thread Tomasz Figa
Since mach-exynos4-dt.c is also going to be used for other SoCs from Exynos4 line, rename internal structures and functions to use exynos4_ prefix, instead of exynos4210_. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach

[PATCH 4/6] ARM: Exynos4: Add OF compatibility lookups for Exynos4 i2c adapters

2012-08-30 Thread Tomasz Figa
Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-exynos4-dt.c | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c

[PATCH 6/6] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-08-30 Thread Tomasz Figa
This commit adds basic device tree for Exynos4210-based Trats board. Currently it provides support for eMMC over sdhci and MAX8997 PMIC. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 287

[PATCH 5/6] ARM: EXYNOS: Increase maximum possible memory bank size to 512MiB

2012-08-30 Thread Tomasz Figa
Some boards have larger memory banks than 256MiB. This patch increses maximum bank size for Exynos-based boards to 512MiB. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/include/mach/memory.h | 4 ++-- 1 file changed

Re: [PATCH 1/6] ARM: dts: Move parts common to Exynos4 from Exynos4210.dtsi to Exynos4.dtsi

2012-09-03 Thread Tomasz Figa
.dtsi as disabled. The board dts files will have to explicitly enable those nodes which it uses. Definitely. Actually I was going to submit patches for it a bit later. I have them ready now and I'm going to send them today, along with corrected version of this patch. Best regards, -- Tomasz Figa

Re: [PATCH 4/6] ARM: Exynos4: Add OF compatibility lookups for Exynos4 i2c adapters

2012-09-03 Thread Tomasz Figa
should not be included in this patch. Right, I must have overlooked it. Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 6/6] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-03 Thread Tomasz Figa
as disabled then we can avoid these here. OK. Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/3] ARM: dts: Exynos4 dts reorganization

2012-09-03 Thread Tomasz Figa
This patch series prepares existing Exynos4210 DT infrastructure to be further extended for new SoCs from Exynos4 line and new boards. Tomasz Figa (3): ARM: dts: Move parts common to Exynos4 from Exynos4210.dtsi to Exynos4.dtsi ARM: EXYNOS: exynos4-dt: Use exynos4 prefix instead

[PATCH 1/3] ARM: dts: Move parts common to Exynos4 from Exynos4210.dtsi to Exynos4.dtsi

2012-09-03 Thread Tomasz Figa
Most definitions from Exynos4210.dtsi can be applied for other SoCs from Exynos4 line as well, so move the common part into separate file that can be included by dtsi files of other Exynos4 SoCs (as well as current Exynos4210.dtsi). Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off

[PATCH 3/3] ARM: dts: exynos4: Assume status of all optional nodes as disabled

2012-09-03 Thread Tomasz Figa
from boards dts. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi| 22 arch/arm/boot/dts/exynos4210-origen.dts | 58 ++- arch/arm/boot/dts/exynos4210

[PATCH 2/3] ARM: EXYNOS: exynos4-dt: Use exynos4 prefix instead of exynos4210

2012-09-03 Thread Tomasz Figa
Since mach-exynos4-dt.c is also going to be used for other SoCs from Exynos4 line, rename internal structures and functions to use exynos4_ prefix, instead of exynos4210_. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-09-03 Thread Tomasz Figa
This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts | 16 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 2 files

[PATCH v2 0/5] ARM: EXYNOS: Add support for Trats board using device tree

2012-09-04 Thread Tomasz Figa
-samsung-soc/msg12056.html - [PATCH v5 2/2] regulator: add device tree support for max8997 http://www.spinics.net/lists/kernel/msg1328117.html - [PATCH 0/3] ARM: dts: Exynos4 dts reorganization http://www.spinics.net/lists/arm-kernel/msg192237.html Tomasz Figa (5): mmc: host: sdhci-s3c: Add broken

[PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-04 Thread Tomasz Figa
Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate correctly. Cc: Ben Dooks ben-li...@fluff.org Cc: Chris Ball c...@laptop.org CC: linux-...@vger.kernel.org Signed-off-by: Tomasz Figa t.f...@samsung.com

[PATCH v2 2/5] ARM: Exynos4: dts: Specify address and size cells for i2c controllers

2012-09-04 Thread Tomasz Figa
Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 9b71b61..718e3d2

[PATCH v2 3/5] ARM: Exynos4: Add OF compatibility lookups for Exynos4 i2c adapters

2012-09-04 Thread Tomasz Figa
Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-exynos4-dt.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c

[PATCH v2 4/5] ARM: EXYNOS: Increase maximum possible memory bank size to 512MiB

2012-09-04 Thread Tomasz Figa
Some boards have larger memory banks than 256MiB. This patch increses maximum bank size for Exynos-based boards to 512MiB. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/include/mach/memory.h | 4 ++-- 1 file changed

[PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-04 Thread Tomasz Figa
This commit adds basic device tree for Exynos4210-based Trats board. Currently it provides support for eMMC over sdhci and MAX8997 PMIC. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts | 237

Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-04 Thread Tomasz Figa
). + max8997_pmic@66 { + compatible = maxim,max8997-pmic; + + reg = 0x66; Probably, the interrupts can be listed when we have pinctrl driver merged in Samsung tree. Right. -- Best regards, Tomasz Figa -- To unsubscribe from this list: send the line

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-05 Thread Tomasz Figa
the gpio property and regulator-fixed driver uses of_get_named_gpio to get the pin number from device tree. Is this kind of setup also valid when using your pinctrl driver? Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-06 Thread Tomasz Figa
to what is done currently with samsung-gpio bindings - the pin is being configured by custom xlate callback based on additional cells in GPIO specifier, when the driver retrieves the pin using of_get{_named,}_gpio without the need of setting it up in the driver. Best regards, -- Tomasz Figa Samsung

[PATCH 0/3] ARM: EXYNOS: Power domain DT support extension

2012-09-06 Thread Tomasz Figa
This patch series fixes two issues with existing DT support for Exynos power domains and extends it with the ability of binding devices to domains, basically making it possible to use power domains when using DT. Tomasz Figa (3): ARM: EXYNOS: pm_domain: Detect domain state on registration from

[PATCH 1/3] ARM: EXYNOS: pm_domain: Detect domain state on registration from DT

2012-09-06 Thread Tomasz Figa
Initial state of power domains might vary on different boards and with different bootloaders. This patch adds detection of initial state of power domains when being registered from DT. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 2/3] ARM: EXYNOS: pm_domain: Fix power domain name initialization

2012-09-06 Thread Tomasz Figa
This patch adds initialization of name field in generic power domain struct. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/pm_domains.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm

[PATCH 3/3] ARM: EXYNOS: pm_domain: Bind devices to power domains using DT

2012-09-06 Thread Tomasz Figa
after unbinding a driver from it. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../bindings/arm/exynos/power_domain.txt | 13 +++- arch/arm/mach-exynos/pm_domains.c | 82 ++ 2 files changed, 94

Re: [PATCH 2/2] ARM: dts: exynos4: allow i2c0 bus to be configured using pinctrl interface

2012-09-06 Thread Tomasz Figa
property is omitted then the state index is used as a name (e.g. pinctrl-0 would be named 0). Maybe it would be better to use this approach (with respective adjustment in first patch)? What do you think? Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send

Re: [PATCH 1/2] i2c: s3c2410: add optional pin configuration using pinctrl interface

2012-09-06 Thread Tomasz Figa
SoC's. I agree. Although not modifying the drivers at all would be nicer. Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-09-08 Thread Tomasz Figa
Hi Kgene, On Saturday 08 of September 2012 11:36:30 Kukjin Kim wrote: Tomasz Figa wrote: This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board. Well...I'm not sure about the status of Origen serial, but all of the serials are enabled

Re: [PATCH v2 4/5] ARM: EXYNOS: Increase maximum possible memory bank size to 512MiB

2012-09-08 Thread Tomasz Figa
Hi Kgene, On Saturday 08 of September 2012 11:41:31 Kukjin Kim wrote: Tomasz Figa wrote: Some boards have larger memory banks than 256MiB. This patch increses maximum bank size for Exynos-based boards to 512MiB. Well...the meaning of SECTION_SIZE_BITS is a little bit different you know

Re: [PATCH v2 5/5] ARM: Exynos: Add basic dts file for Samsung Trats board

2012-09-08 Thread Tomasz Figa
merged in Samsung tree. Right. Note, you can do it on top of samsung tree :-) OK. -- Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 2/3] ARM: EXYNOS: pm_domain: Fix power domain name initialization

2012-09-08 Thread Tomasz Figa
of copying it to a new place? The problem is that np-name is const, while pd-pd.name is not. -- Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 3/3] ARM: EXYNOS: pm_domain: Bind devices to power domains using DT

2012-09-08 Thread Tomasz Figa
-by: Thomas Abraham thomas.abra...@linaro.org Thanks ;) -- Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-09-12 Thread Tomasz Figa
-dev.of_node) Is this check needed at all? In case of CONFIG_OF disabled, of_node should always be NULL and there is a dummy macro provided for of_match_node, so it should compile and work just fine. -- Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH 0/5] ARM: EXYNOS: Add secure firmware support

2012-09-13 Thread Tomasz Figa
: SMC instruction (aka firmware) support http://thread.gmane.org/gmane.linux.ports.arm.kernel/183608/focus=184109 Tomasz Figa (5): ARM: EXYNOS: Add IO mapping for non-secure SYSRAM. ARM: Add interface for registering and calling firmware-specific operations ARM: EXYNOS: Add support

[PATCH 1/5] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM.

2012-09-13 Thread Tomasz Figa
On TrustZone-enabled boards the non-secure SYSRAM is used for secondary CPU bring-up, so add a mapping for it. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/common.c| 34 arch/arm/mach-exynos/include/mach/map.h | 3

[PATCH 2/5] ARM: Add interface for registering and calling firmware-specific operations

2012-09-13 Thread Tomasz Figa
) { register_firmware_ops(platformX_firmware_ops); } Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/common/Makefile| 2 ++ arch/arm/common/firmware.c | 18 ++ arch/arm/include/asm/firmware.h | 30

[PATCH 3/5] ARM: EXYNOS: Add support for secure monitor calls

2012-09-13 Thread Tomasz Figa
://thread.gmane.org/gmane.linux.ports.arm.kernel/183608/focus=184109 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/Makefile | 5 + arch/arm/mach-exynos/exynos-smc.S | 22 ++ arch/arm/mach

[PATCH 4/5] ARM: EXYNOS: Add support for Exynos secure firmware

2012-09-13 Thread Tomasz Figa
-off-by: Tomasz Figa t.f...@samsung.com --- .../devicetree/bindings/arm/samsung-boards.txt | 8 arch/arm/mach-exynos/Makefile | 1 + arch/arm/mach-exynos/common.h | 2 + arch/arm/mach-exynos/firmware.c| 52

[PATCH 5/5] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up

2012-09-13 Thread Tomasz Figa
=184109 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 816a27d..9d65b1b 100644

Re: [PATCH 2/5] ARM: Add interface for registering and calling firmware-specific operations

2012-09-13 Thread Tomasz Figa
On Thursday 13 of September 2012 10:13:35 Tomasz Figa wrote: In code using firmware ops: __raw_writel(virt_to_phys(exynos4_secondary_startup), CPU1_BOOT_REG); /* Call Exynos specific smc call */ do_firmware_op(cpu_boot, cpu); Typo, s/do_/call_/ . Best

Re: [PATCH 4/5] ARM: EXYNOS: Add support for Exynos secure firmware

2012-09-19 Thread Tomasz Figa
Hi Olof, On Saturday 15 of September 2012 17:44:55 Olof Johansson wrote: On Thu, Sep 13, 2012 at 10:13:37AM +0200, Tomasz Figa wrote: +static void __iomem *exynos_cpu_boot_reg(int cpu) +{ + return S5P_VA_SYSRAM_NS + 0x1c + 4*cpu; +} This communication area in sysram should probably

Re: [PATCH v2 1/5] mmc: host: sdhci-s3c: Add broken-voltage DT property for broken voltage quirk

2012-09-19 Thread Tomasz Figa
Hi Chris, On Wednesday 19 of September 2012 01:42:01 Chris Ball wrote: On Tue, Sep 04 2012, Tomasz Figa wrote: Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate correctly. Is there a reason we

[PATCH 0/6] pinctrl: samsung: Various fixes

2012-09-20 Thread Tomasz Figa
This patch series contains various fixes of problems and nitpicks spotted when working on adding support for Exynos4x12. See each patch for more detailed information. TODO: - setting WEINT pins to EINT function in exynos_wkup_irq_set_type Tomasz Figa (6): pinctrl: exynos: Set pin function

[PATCH 1/6] pinctrl: exynos: Set pin function to EINT in irq_set_type of GPIO EINTa

2012-09-20 Thread Tomasz Figa
Pins used as GPIO interrupts need to be configured as EINTs. This patch adds the required configuration code to exynos_gpio_irq_set_type, to set the pin as EINT when its interrupt trigger is configured. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 2/6] pinctrl: exynos: Fix typos in gpio/wkup _irq_mask

2012-09-20 Thread Tomasz Figa
To mask GPIO/wakeup IRQ, the corresponding bit in mask register has to be set. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 3/6] pinctrl: exynos: Handle only unmasked wakeup interrupts

2012-09-20 Thread Tomasz Figa
A bit in EINTxx_PEND register is set regardless of interrupt mask, which causes spurious interrupts. To avoid them, the read value of pending register must be masked with current interrupt mask manually. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 4/6] pinctrl: exynos: Mark exynos_irq_demux_eint as inline

2012-09-20 Thread Tomasz Figa
The exynos_irq_demux_eint utility function is used in chained IRQ handler for EINT16-31 to handle multiplexed interrupts. Inlining it should improve the performance a bit. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/pinctrl

[PATCH 5/6] pinctrl: exynos: Correct the detection of wakeup-eint node

2012-09-20 Thread Tomasz Figa
Current way of finding the wakeup-eint node scans the whole device tree not only children of the pinctrl node, so it might detect a wakeup-eint node of another pinctrl device. This patch limits the scope of looking for nodes only to subnodes of the pinctrl node. Signed-off-by: Tomasz Figa t.f

[PATCH 6/6] pinctrl: samsung: Uninline samsung_pinctrl_get_soc_data

2012-09-20 Thread Tomasz Figa
Although the function is used only a single time, it is not performance critical and it is pretty heavy, so let the compiler decide whether to inline it instead. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/pinctrl/pinctrl

[RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-20 Thread Tomasz Figa
; interrupt-parent = gpa1; interrupts = 4 0; Any comments are welcome. TODO: - bindings documentation - per-bank GPIO and GEINT specification Tomasz Figa (6): pinctrl: exynos: Parse wakeup-eint parameters from DT pinctrl: samsung: Parse pin banks from DT pinctrl: exynos: Remove static

[RFC 1/6] pinctrl: exynos: Parse wakeup-eint parameters from DT

2012-09-20 Thread Tomasz Figa
This patch converts the pinctrl-exynos driver to parse wakeup interrupt count and register offsets from device tree. It reduces the amount of static platform-specific data and facilitates adding further SoC variants to pinctrl-samsung driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed

[RFC 2/6] pinctrl: samsung: Parse pin banks from DT

2012-09-20 Thread Tomasz Figa
to remove the static data structures and facilitate adding of further SoC variants to the pinctrl-samsung driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 5 ++ drivers/pinctrl/pinctrl-samsung.c | 148

[RFC 3/6] pinctrl: exynos: Remove static platform-specific data

2012-09-20 Thread Tomasz Figa
-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 96 --- drivers/pinctrl/pinctrl-exynos.h | 157 -- drivers/pinctrl/pinctrl-samsung.h | 1 - 3 files changed

[RFC 4/6] pinctrl: samsung: Parse bank-specific eint offset from DT

2012-09-20 Thread Tomasz Figa
from bank index. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 5 ++--- drivers/pinctrl/pinctrl-samsung.c | 5 + drivers/pinctrl/pinctrl-samsung.h | 1 + 3 files changed, 8 insertions(+), 3 deletions

[RFC 5/6] ARM: dts: exynos4210: Remove legacy gpio nodes

2012-09-20 Thread Tomasz Figa
This patch removes the legacy gpio nodes as the gpio driver is going to be replaced with the new pinctrl driver. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4210.dtsi | 229

[PATCH 7/6] pinctrl: exynos: Fix wakeup IRQ domain registration check

2012-09-20 Thread Tomasz Figa
Because of a typo, incorrect field of a structure was being checked. This patch fixes the check to use correct field. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl

Re: [PATCH 0/6] pinctrl: samsung: Various fixes

2012-09-20 Thread Tomasz Figa
it with this series? Best regards, -- Tomasz Figa Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC PATCH 0/6] pinctrl: samsung: Convert the driver to use per-bank GPIO and interrupt specifiers

2012-09-21 Thread Tomasz Figa
interrupt specifiers for wake-up interrupts - Configuration of pins used as wake-up interrupts to EINT function Tomasz Figa (6): pinctrl: samsung: Hold OF node of pin bank in bank struct pinctrl: samsung: Hold pointer to driver data in bank struct pinctrl: exynos: Use one IRQ domain per pin

[RFC PATCH 3/6] pinctrl: exynos: Use one IRQ domain per pin bank

2012-09-21 Thread Tomasz Figa
be now specified per banks. Example: device { /* ... */ interrupt-parent = gpa1; interrupts = 3 0; /* ... */ }; Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 118

[RFC PATCH 5/6] pinctrl: samsung: Use one GPIO chip per pin bank

2012-09-21 Thread Tomasz Figa
: device { /* ... */ gpios = gpk0 4 0; /* ... */ }; Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 118 +++--- drivers/pinctrl/pinctrl-samsung.h | 8 ++- 2 files

[RFC PATCH 6/6] ARM: dts: exynos4210: Update pin bank nodes to reflect per-bank GPIO chips and IRQ domains

2012-09-21 Thread Tomasz Figa
This patch modifies device tree sources of Exynos4210 to match the changes done to pinctrl-samsung driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4210-pinctrl-banks.dtsi | 72 + arch/arm/boot/dts/exynos4210.dtsi | 4 -- 2

[RFC PATCH 1/6] pinctrl: samsung: Hold OF node of pin bank in bank struct

2012-09-21 Thread Tomasz Figa
The node pointer will be used in extensions added by patches that will follow. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 2 ++ drivers/pinctrl/pinctrl-samsung.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/drivers/pinctrl/pinctrl-samsung.c

Re: [RFC 0/6] pinctrl: samsung: Remove static platform-specific data

2012-09-21 Thread Tomasz Figa
Hi Stephen, Thanks for your comments. On Friday 21 of September 2012 12:40:35 Stephen Warren wrote: On 09/20/2012 02:53 AM, Tomasz Figa wrote: This RFC series is a work on replacing static platform-specific data in pinctrl-samsung driver with data dynamically parsed from device tree. Hmm

Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers

2012-09-21 Thread Tomasz Figa
Hi Stephen, Thanks for your comments. On Friday 21 of September 2012 12:56:41 Stephen Warren wrote: On 09/20/2012 02:53 AM, Tomasz Figa wrote: The patch pinctrl: samsung: Parse pin banks from DT introduced platform-specific data parsing from DT. This patch adds all necessary nodes

[PATCH v2 0/6] ARM: EXYNOS: Add secure firmware support

2012-09-24 Thread Tomasz Figa
not implemented or appropriate error code on error Tomasz Figa (6): ARM: Add interface for registering and calling firmware-specific operations ARM: EXYNOS: Add support for secure monitor calls ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412 ARM: EXYNOS: Add IO

[PATCH 4/6] ARM: EXYNOS: Add IO mapping for non-secure SYSRAM.

2012-09-24 Thread Tomasz Figa
On TrustZone-enabled boards the non-secure SYSRAM is used for secondary CPU bring-up, so add a mapping for it. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/common.c| 34 arch/arm/mach-exynos/include/mach/map.h | 3

[PATCH 6/6] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up

2012-09-24 Thread Tomasz Figa
Boards using secure firmware must use different CPU boot registers and call secure firmware to boot the CPU. Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH 3/6] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-09-24 Thread Tomasz Figa
Exynos4412 uses different information register for each core. This patch adjusts the bring-up code to take that into account. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions

[PATCH 1/6] ARM: Add interface for registering and calling firmware-specific operations

2012-09-24 Thread Tomasz Figa
-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/common/Makefile| 2 ++ arch/arm/common/firmware.c | 18 ++ arch/arm/include/asm/firmware.h | 31 +++ 3 files changed, 51 insertions

Re: [RFC PATCH 0/6] pinctrl: samsung: Convert the driver to use per-bank GPIO and interrupt specifiers

2012-09-24 Thread Tomasz Figa
Hi Linus, On Monday 24 of September 2012 12:43:23 Linus Walleij wrote: On Fri, Sep 21, 2012 at 4:22 PM, Tomasz Figa t.f...@samsung.com wrote: This is a continuation of work focused on improving the pinctrl-samsung driver. All look good to me, I guess these will go through the Samsung tree

Re: [PATCH v4] ARM: EXYNOS: Add MFC device tree support

2012-09-26 Thread Tomasz Figa
; + samsung,mfc-l-size = 8388608; It would look like this: samsung-mfc-r = 0x4300 0x80; samsung-mfc-l = 0x5100 0x80; Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver

2012-09-28 Thread Tomasz Figa
,dp_phy ? Do you mean this ? It is not working. + dp_phy = samsung,dp_phy; I believe he meant: -+ dp_phy =dptx_phy; ++ samsung,dp_phy =dptx_phy; to mark that this is a Samsung-specific property. Best regards, Tomasz Figa -- To unsubscribe from this list

Re: [PATCH V2 3/3] ARM: EXYNOS: Add drm-device node to the dtsi file

2012-09-28 Thread Tomasz Figa
regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RFC PATCH 00/16] pinctrl: samsung: Usability and extensibiltiy improvements

2012-09-28 Thread Tomasz Figa
they are handled (direct or multiplexed/chained). See particular patches for more detailed descriptions and the last patch for updated device tree bindings. Any comments are welcome. Tomasz Figa (16): pinctrl: exynos: Parse wakeup-eint parameters from DT pinctrl: samsung: Detect and handle

[RFC PATCH 01/16] pinctrl: exynos: Parse wakeup-eint parameters from DT

2012-09-28 Thread Tomasz Figa
This patch converts the pinctrl-exynos driver to parse wakeup interrupt count and register offsets from device tree. It reduces the amount of static platform-specific data and facilitates adding further SoC variants to pinctrl-samsung driver. Signed-off-by: Tomasz Figa t.f...@samsung.com

[RFC PATCH 02/16] pinctrl: samsung: Detect and handle unsupported configuration types

2012-09-28 Thread Tomasz Figa
Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c index dd108a9..c660fa5 100644 --- a/drivers/pinctrl/pinctrl-samsung.c +++ b/drivers

[RFC PATCH 03/16] pinctrl: samsung: Parse pin banks from DT

2012-09-28 Thread Tomasz Figa
to remove the static data structures and facilitate adding of further SoC variants to the pinctrl-samsung driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 5 ++ drivers/pinctrl/pinctrl-samsung.c | 169 +- drivers/pinctrl

[RFC PATCH 04/16] pinctrl: exynos: Remove static platform-specific data

2012-09-28 Thread Tomasz Figa
-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 96 --- drivers/pinctrl/pinctrl-exynos.h | 157 -- drivers/pinctrl/pinctrl-samsung.h | 1 - 3 files changed, 254 deletions(-) diff --git a/drivers/pinctrl/pinctrl

[RFC PATCH 05/16] pinctrl: samsung: Parse bank-specific eint offset from DT

2012-09-28 Thread Tomasz Figa
from bank index. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 5 ++--- drivers/pinctrl/pinctrl-samsung.c | 5 + drivers/pinctrl/pinctrl-samsung.h | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-exynos.c b

[RFC PATCH 06/16] pinctrl: samsung: Hold OF node of pin bank in bank struct

2012-09-28 Thread Tomasz Figa
The node pointer will be used in extensions added by patches that will follow. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 1 + drivers/pinctrl/pinctrl-samsung.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/pinctrl/pinctrl-samsung.c b

[RFC PATCH 07/16] pinctrl: samsung: Hold pointer to driver data in bank struct

2012-09-28 Thread Tomasz Figa
The pointer will be used by further extensions added to the driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 20 +++- drivers/pinctrl/pinctrl-samsung.h | 2 ++ 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers

[RFC PATCH 09/16] pinctrl: samsung: Do not pass gpio_chip to pin_to_reg_bank

2012-09-28 Thread Tomasz Figa
The pointer to gpio_chip passed to pin_to_reg_bank utility function is used only to retrieve a pointer to samsung_pinctrl_drv_data structure. This patch modifies the function and its users to pass a pointer to samsung_pinctrl_drv_data directly. Signed-off-by: Tomasz Figa t.f...@samsung.com

[RFC PATCH 11/16] pinctrl: samsung: Use per-bank IRQ domain for wake-up interrupts

2012-09-28 Thread Tomasz Figa
of interrupts is not hardcoded in the driver anymore - bank and pin of each wake-up interrupt can be easily identified, to allow operations, such as setting the pin to EINT function, from irq_set_type() callback Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl

[RFC PATCH 10/16] pinctrl: samsung: Use one GPIO chip per pin bank

2012-09-28 Thread Tomasz Figa
: device { /* ... */ gpios = gpk0 4 0; /* ... */ }; Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 118 +++--- drivers/pinctrl/pinctrl-samsung.h | 12 ++-- 2 files

[RFC PATCH 13/16] pinctrl: samsung: Parse offsets of particular registers from DT

2012-09-28 Thread Tomasz Figa
The order and availability of pin control registers vary with SoC. This patch modifies the driver to parse register offsets from device tree as a part of bank type definition. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 12 ++--- drivers/pinctrl/pinctrl

  1   2   3   4   5   6   7   8   9   10   >