Re: [PATCH 0/2] target: make location of /var/target configurable

On Mon, 2016-04-04 at 18:15 -0700, Lee Duncan wrote: > On 04/02/2016 08:36 PM, Nicholas A. Bellinger wrote: > > On Thu, 2016-03-31 at 11:05 -0700, Lee Duncan wrote: > >> These patches make the location of "/var/target" configurable, > >> though it still defauls to "/var/target". > >> > >> This

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

> "Shaun" == Shaun Tancheff writes: Shaun> Oh, okay. It became an issue in the next patch where some Shaun> internal cmd_flags temporaries where stored in 32 bit values. Shaun> I will fix patch/subject. There's a pending patch set from Mike Christie that cleans

Re: [PATCH 2/8] snic: LUN goes offline due to scsi cmd timeouts

> "Narsimhulu" == Narsimhulu Musini writes: Narsimhulu> - LUN goes offline, if there are atleast two scsi command Narsimhulu> timeouts Completing the IO with scsi_done() fixes the issue. Narsimhulu> Signed-off-by: Narsimhulu Musini Narsimhulu>

Re: [PATCH 0/9] lpfc: Update to revision 11.1.0.0

> "James" == James Smart writes: James> This patch set updates the lpfc driver to revision 11.1.0.00 Applied to 4.7/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the

Re: [PATCH 0/2] target: make location of /var/target configurable

On 04/02/2016 08:36 PM, Nicholas A. Bellinger wrote: > On Thu, 2016-03-31 at 11:05 -0700, Lee Duncan wrote: >> These patches make the location of "/var/target" configurable, >> though it still defauls to "/var/target". >> >> This configuration is accomplished via the configfs >> top-level target

Re: [PATCH 2/2] target: use new "dbroot" target attribute

On 04/01/2016 11:18 AM, Andy Grover wrote: > On 04/01/2016 11:01 AM, Lee Duncan wrote: >> On 04/01/2016 12:58 AM, Johannes Thumshirn wrote: >>> On 2016-03-31 20:05, Lee Duncan wrote: This commit updates the target core ALUA and PR modules to use the new "dbroot" attribute instead of

Re: QoS for iSCSI target?

On Mon, 2016-04-04 at 17:01 -0600, Chris Friesen wrote: > On 04/04/2016 04:29 PM, Nicholas A. Bellinger wrote: > > On Mon, 2016-04-04 at 09:20 -0600, Chris Friesen wrote: > >> On 04/02/2016 07:15 PM, Nicholas A. Bellinger wrote: > >>> On Fri, 2016-04-01 at 12:35 -0600, Chris Friesen wrote: > >> >

Re: [PATCH v13 0/9] add support for DWC UFS Controller

> "Joao" == Joao Pinto writes: Joao, Joao> The work consisted of: - Fixed typo in ufshcd-pltfrm.c - Tweak Joao> ufshcd.c for UFS 2.0 support - Implement ufshcd-dwc which contains Joao> all DWC HW specific code - Unipro attributes were added and new Joao> registers

Re: [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code

> "Bart" == Bart Van Assche writes: Bart> These five patches are what I came up with after analyzing the Bart> output of "make M=drivers/scsi W=1 C=2" for the iSCSI initiator Bart> kernel code. Please consider these patches for inclusion in kernel Bart> v4.7. The

Re: QoS for iSCSI target?

On 04/04/2016 04:29 PM, Nicholas A. Bellinger wrote: On Mon, 2016-04-04 at 09:20 -0600, Chris Friesen wrote: On 04/02/2016 07:15 PM, Nicholas A. Bellinger wrote: On Fri, 2016-04-01 at 12:35 -0600, Chris Friesen wrote: On a slightly different note, is there any way to throttle or limit the

Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

Hello Nicholas Its fixed now. Many Thanks. $ scripts/checkpatch.pl 0001-tcm_qla2xxx-Add-SCSI-command-jammer-discard-capabili.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: new file mode 100644 total: 0 errors, 1 warnings, 91 lines checked

Re: QoS for iSCSI target?

On Mon, 2016-04-04 at 09:20 -0600, Chris Friesen wrote: > On 04/02/2016 07:15 PM, Nicholas A. Bellinger wrote: > > On Fri, 2016-04-01 at 12:35 -0600, Chris Friesen wrote: > > On a slightly different note, is there any way to throttle or limit the > overall > bandwidth consumed by

[PATCH v3 1/5] scsi: replace "scsi_data_buffer" with "sg_table" in SG functions

From: Ming Lin Replace parameter "struct scsi_data_buffer" with "struct sg_table" in SG alloc/free functions to make them generic. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lin --- drivers/scsi/scsi_lib.c | 41

[PATCH v3 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

From: Ming Lin Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount we fit into a single scatterlist chunk. Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS. Will move these 2 generic definitions to scatterlist.h later. Reviewed-by: Christoph

[PATCH v3 2/5] scsi: replace "mq" with "first_chunk" in SG functions

From: Ming Lin Parameter "bool mq" is block driver specific. Change it to "first_chunk" to make it more generic. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lin --- drivers/scsi/scsi_lib.c | 20 ++-- 1 file

[PATCH v3 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c

From: Ming Lin Now it's ready to move the mempool based SG chained allocator code from SCSI driver to lib/sg_pool.c, which will be compiled only based on a Kconfig symbol CONFIG_SG_POOL. SCSI selects CONFIG_SG_POOL. Reviewed-by: Christoph Hellwig

[PATCH v3 3/5] scsi: rename SG related struct and functions

From: Ming Lin Rename SCSI specific struct and functions to more genenic names. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lin --- drivers/scsi/scsi_lib.c | 52 - 1 file

[PATCH v3 0/5] mempool based chained scatterlist alloc/free api

From: Ming Lin The fist 4 patches make the SG related definitions/structs/functions in SCSI code generic and the last patch move it to lib/sg_pool.c. v3: - Resend for Tejun to review. No code change since v2. - Add review/ack tags v2: - do modification in scsi

Re: [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

On Mon, Apr 04, 2016 at 01:24:52PM -0700, Ming Lin wrote: > Could you help to review/ack this ATA part? > Thanks. Can you please resend me the patches? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

[PATCH fix for v4.6] scsi: ufs: make ufshcd_query_descriptor_retry static

This function was intended to be exported into the ufshcd API but after all it is not used outside ufshcd.c Make it static and drop EXPORT_SYMBOL; this can be restored when needed. Fixes warning: no previous prototype for ‘ufshcd_query_descriptor_retry’ Introduced by commit a70e91b8bbaa ("scsi:

Re: [PATCH] tcm_qla2xxx Add SCSI command jammer/discard capability to the tcm_qla2xxx module

On Sun, 2016-04-03 at 09:57 -0400, Laurence Oberman wrote: > Hi Nicholas > > Apologies for the top posting, that was in my haste to correct the prior > patch that had the typo. > When I investigated the attributes it looked like I would have had to create > a store and a check function and call

Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c

On Mon, Apr 4, 2016 at 1:17 PM, Christoph Hellwig wrote: > On Mon, Apr 04, 2016 at 01:15:45PM -0700, Ming Lin wrote: >> cleanup_sdb: >> for (i = 0; i < SG_MEMPOOL_NR; i++) { >> struct sg_pool *sgp = sg_pools + i; >> if (sgp->pool) >>

Re: [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

On Tue, Mar 22, 2016 at 3:03 PM, Ming Lin wrote: > From: Ming Lin > > Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount > we fit into a single scatterlist chunk. > > Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS. > > Will move

Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c

On Mon, Apr 04, 2016 at 01:15:45PM -0700, Ming Lin wrote: > cleanup_sdb: > for (i = 0; i < SG_MEMPOOL_NR; i++) { > struct sg_pool *sgp = sg_pools + i; > if (sgp->pool) > mempool_destroy(sgp->pool); > if (sgp->slab) >

Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c

On Tue, Mar 22, 2016 at 7:38 PM, kbuild test robot wrote: > Hi Ming, > > [auto build test WARNING on scsi/for-next] > [also build test WARNING on v4.5 next-20160322] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url:

Subject: [PATCH v2] ibft: Expose iBFT acpi header via sysfs

Some ethernet adapter vendors are supplying products which support optional (payed license) features. On some adapters this includes a hardware iscsi initiator. The same adapters in a normal (no extra licenses) mode of operation can be used as a software iscsi initiator. In addition, software

Re: [PATCH 00/14] libata: SATL update

On 04/04/2016 05:46 PM, Tejun Heo wrote: > Hello, Hannes. > > Applied the series to libata/for-4.7-zac with cosmetic updates > ((s64)-1 -> UINT64_MAX, kbuild warning fixes and other formatting > updates). > Tejun, you are my hero :-) Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

On 04/04/2016 07:22 PM, Tejun Heo wrote: + } else { + /* Could not decode error */ + ata_dev_warn(dev, "could not decode error status 0x%x err_mask 0x%x\n", "%#x" is equivalent and takes up less space. Oops, gmail for some reason put Sergei's messages

Re: [PATCH] ibft: Expose iBFT acpi header via sysfs

On Fri, 2016-04-01 at 20:53 -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 23, 2016 at 09:49:26PM -0400, David Bond wrote: > > > > Some ethernet adapter vendors are supplying products which support optional > > (payed license) features. On some adapters this includes a hardware iscsi > >

Re: [PATCH 1/4] libata: implement ZBC IN translation

On Mon, Apr 4, 2016 at 4:47 PM, Hannes Reinecke wrote: > ZAC drives implement 'zac management in' command template, > which maps onto the ZBC IN command. > > Signed-off-by: Hannes Reinecke > --- > drivers/ata/libata-eh.c | 1 + > drivers/ata/libata-scsi.c

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

On Mon, Apr 04, 2016 at 02:26:51PM +0300, Sergei Shtylyov wrote: > >+} else { > >+/* Could not decode error */ > >+ata_dev_warn(dev, "could not decode error status 0x%x err_mask > >0x%x\n", > >"%#x" is equivalent and takes up less space. Oops, gmail for some

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

On Mon, Apr 4, 2016 at 10:56 PM, Jeff Moyer wrote: > Shaun Tancheff writes: > >> In a few places a temporary value smaller than a cmd_flags >> is used to test for bits and or build up a new cmd_flags. >> >> Change to use explicit u64 values where

Re: [PATCH 03/12] BUG: Losing bits on request.cmd_flags

Shaun Tancheff writes: > In a few places a temporary value smaller than a cmd_flags > is used to test for bits and or build up a new cmd_flags. > > Change to use explicit u64 values where appropriate. This is not a bug fix, so please fix your subject. I'm not against

Re: [PATCH 1/4] libata: implement ZBC IN translation

On Mon, Apr 04, 2016 at 11:47:48AM +0200, Hannes Reinecke wrote: > +/* /** > + * ata_scsi_report_zones_complete > + * > + * Convert T-13 little-endian field representation into > + * T-10 big-endian field representation. > + */ > +static void ata_scsi_report_zones_complete(struct ata_queued_cmd

Re: [PATCH 0/4] libata: ZAC support

Hello, Hannes. Except for the minor nits, looks good to me. Will wait for refresh and apply to libata/for-4.7-zac. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 00/14] libata: SATL update

Hello, Hannes. Applied the series to libata/for-4.7-zac with cosmetic updates ((s64)-1 -> UINT64_MAX, kbuild warning fixes and other formatting updates). Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

Re: QoS for iSCSI target?

On 04/02/2016 07:15 PM, Nicholas A. Bellinger wrote: On Fri, 2016-04-01 at 12:35 -0600, Chris Friesen wrote: On a slightly different note, is there any way to throttle or limit the overall bandwidth consumed by the iSCSI target in the kernel? I'd like to ensure that the iSCSI traffic doesn't

Re: [PATCH 14/14] libata-scsi: Set information sense field for invalid parameter

Hi Hannes, [auto build test WARNING on tj-libata/for-next] [also build test WARNING on v4.6-rc2 next-20160404] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-SATL

Re: [PATCH 1/5] bnx2fc: Add driver tunables.

On Fri, 1 Apr 2016, James Bottomley wrote: On Fri, 2016-04-01 at 10:06 -0400, Chad Dupuis wrote: On Fri, 1 Apr 2016, Johannes Thumshirn wrote: On 2016-04-01 15:10, Chad Dupuis wrote: From: Joe Carnuccio Per customer request, add the following driver tunables: o

Re: [PATCH v2 4/5] scsi: rename SCSI_MAX_{SG, SG_CHAIN}_SEGMENTS

On 03/22/16 15:03, Ming Lin wrote: From: Ming Lin Rename SCSI_MAX_SG_SEGMENTS to SG_CHUNK_SIZE, which means the amount we fit into a single scatterlist chunk. Rename SCSI_MAX_SG_CHAIN_SEGMENTS to SG_MAX_SEGMENTS. Will move these 2 generic definitions to scatterlist.h

Re: [PATCH 3/4] libata: support device-managed ZAC devices

On 04/04/2016 01:13 PM, Sergei Shtylyov wrote: > Hello. > > On 4/4/2016 12:47 PM, Hannes Reinecke wrote: > >> Device-managed ZAC devices just set the zoned capabilities field >> in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' >> field in the block device characteristics VPD page.

Re: [PATCH v2 0/5] mempool based chained scatterlist alloc/free api

On Sun, 2016-04-03 at 23:07 -0700, Ming Lin wrote: > On Mon, Mar 28, 2016 at 7:48 AM, Ming Lin wrote: > > On Thu, Mar 24, 2016 at 8:46 AM, James Bottomley > > wrote: > > > On Thu, 2016-03-24 at 08:09 -0700, Ming Lin wrote: > > > > On Wed,

Re: [PATCH 2/4] libata: Implement ZBC OUT translation

On 04/04/2016 03:08 PM, Shaun Tancheff wrote: > On Mon, Apr 4, 2016 at 4:47 PM, Hannes Reinecke wrote: >> ZAC drives implement a 'zac management out' command template, >> which maps onto the ZBC OUT command. >> >> Signed-off-by: Hannes Reinecke >> --- >>

Re: [PATCH 2/4] libata: Implement ZBC OUT translation

On Mon, Apr 4, 2016 at 4:47 PM, Hannes Reinecke wrote: > ZAC drives implement a 'zac management out' command template, > which maps onto the ZBC OUT command. > > Signed-off-by: Hannes Reinecke > --- > drivers/ata/libata-eh.c | 1 + > drivers/ata/libata-scsi.c

Re: [PATCH 10/14] libata: Implement control mode page to select sense format

Hi Hannes, [auto build test WARNING on tj-libata/for-next] [also build test WARNING on v4.6-rc2 next-20160404] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-SATL

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

On 4/4/2016 12:43 PM, Hannes Reinecke wrote: ata_to_sense_error() is called conditionally, so we should be generating a default sense if the condition is not met. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 6 ++ 1 file changed, 6 insertions(+) diff

Re: [PATCH 08/14] libata: evaluate SCSI sense code

On 4/4/2016 12:44 PM, Hannes Reinecke wrote: Whenever a sense code is set it would need to be evaluated to update the error mask. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 28 +++- drivers/scsi/scsi_error.c | 3 ++-

[PATCH v2 2/8] char: rpmb: add sysfs-class ABI documentation

Signed-off-by: Tomas Winkler --- V2: resend Documentation/ABI/testing/sysfs-class-rpmb | 15 +++ MAINTAINERS| 1 + 2 files changed, 16 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-rpmb diff --git

[PATCH v2 1/8] rpmb: add Replay Protected Memory Block (RPMB) subsystem

Few storage technology such is EMMC, UFS, and NVMe support RPMB hardware partition with common protocol and frame layout. The RPMB partition cannot be accessed via standard block layer, but by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and PROGRAM_KEY. Such a partition provides

[PATCH v2 3/8] char: rpmb: add device attributes

Add attribute type that displays underlay storage type technology EMMC, UFS, and attribute id, that displays underlay storage device id. For EMMC this would be content of CID and for UFS serial number from the device descriptor Signed-off-by: Tomas Winkler --- V2: resend

[PATCH v2 4/8] char: rpmb: provide user space interface

The user space API is achieved via single synchronous IOCTL. The request is submitted in_frames_ptr pointer and received in out_frames_ptr. Signed-off-by: Tomas Winkler --- V2: use memdup_user Documentation/ioctl/ioctl-number.txt | 1 + MAINTAINERS

[PATCH v2 7/8] mmc: block: register rpmb partition with the RPMB subsystem

Register eMMC rpmb partition with the rpmb subsystem and provide implementation for the RPMB access operations abstracting actual multi step process. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- V2: resend

[PATCH v2 6/8] tools rpmb: add RPBM access tool

Add simple RPMB host testing tool. It can be used to program key, write and read data block, and retrieve write counter. Signed-off-by: Tomas Winkler --- V2: resend MAINTAINERS | 1 + tools/Makefile| 16 +- tools/rpmb/.gitignore | 2 +

[PATCH v2 5/8] char: rpmb: add RPMB simulation device

This is simple platform device for used for testing rpmb subystem. The module currently suppot two configuration options 1.max_wr_blks: for specifying max blocks that can be written in a single command and. 2. daunits: used to set storage capacity in 128K units. Signed-off-by: Tomas Winkler

[PATCH v2 8/8] scsi: ufs: connect to RPMB subsystem

Register UFS RPMB LUN with the RPMB subsystem and provide implementation for the RPMB access operations. RPMB partition is accessed via a sequence of security protocol in and security protocol out commands with UFS specific parameters. This multi step process is abstracted into 4 basic RPMB

Re: [PATCH 3/4] libata: support device-managed ZAC devices

Hello. On 4/4/2016 12:47 PM, Hannes Reinecke wrote: Device-managed ZAC devices just set the zoned capabilities field in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' field in the block device characteristics VPD page. As this is only defined in SPC-5/SBC-4 we also need to update

[PATCH 0/8 V2] Replay Protected Memory Block (RPMB) subsystem

Few storage technology such is EMMC, UFS, and NVMe support RPMB hardware partition with common protocol and frame layout. The RPMB partition cannot be accessed via standard block layer, but by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and PROGRAM_KEY. Such a partition provides

Re: [PATCH v12 8/9] add TC G210 platform driver

Hi Rob, On 4/4/2016 6:15 AM, Rob Herring wrote: > On Thu, Mar 31, 2016 at 07:57:21PM +0100, Joao Pinto wrote: >> This patch adds a glue platform driver for the Synopsys G210 Test Chip. >> >> Signed-off-by: Joao Pinto >> --- [snip] >> + >> +Required properties: >> +-

RE: [PATCH 8/8] scsi: ufs: connect to RPMB subsystem

> I saw some kbuild robot issues regarding the patchset, so I would suggest you make a v2 of the patch set and I can run some tests with the DW UFS Host design. Yes the second round is on the way but there are (for) quite minor issues. Tomas -- To unsubscribe from this list: send the line

Re: [PATCH 8/8] scsi: ufs: connect to RPMB subsystem

Hi! On 4/3/2016 10:42 AM, Tomas Winkler wrote: > Register UFS RPMB LUN with the RPMB subsystem and provide > implementation for the RPMB access operations. RPMB partition is > accessed via a sequence of security protocol in and security protocol > out commands with UFS specific parameters. This

[PATCH 9/9] sd: Implement support for ZBC devices

Implement ZBC support functions to read in the zone information and setup the zone tree. Signed-off-by: Hannes Reinecke --- drivers/scsi/Kconfig | 8 + drivers/scsi/Makefile | 1 + drivers/scsi/sd.c | 120 +-- drivers/scsi/sd.h | 41 +

[PATCH 4/9] sd: Implement new RESET_WP provisioning mode

We can map the RESET WRITE POINTER command onto a 'discard' request. Signed-off-by: Hannes Reinecke --- drivers/scsi/sd.c | 52 +++- drivers/scsi/sd.h | 1 + 2 files changed, 44 insertions(+), 9 deletions(-) diff --git

[PATCH 8/9] block: Add 'BLK_MQ_RQ_QUEUE_DONE' return value

Add a return value BLK_MQ_RQ_QUEUE_DONE to terminate a request without error. Signed-off-by: Hannes Reinecke --- block/blk-mq.c | 1 + drivers/scsi/scsi_lib.c | 3 +++ include/linux/blk-mq.h | 1 + 3 files changed, 5 insertions(+) diff --git a/block/blk-mq.c

[PATCH 5/9] block: Implement support for zoned block devices

Implement a RB-Tree holding the zone information and add support functions for maintaining the RB-Tree. Signed-off-by: Hannes Reinecke --- block/Kconfig | 9 +++ block/Makefile | 1 + block/blk-core.c | 5 block/blk-zoned.c | 70

[PATCH 3/9] sd: configure ZBC devices

For ZBC devices I/O must not cross zone boundaries, so setup the 'chunk_sectors' block queue setting to the zone size. This is only valid for REPORT ZONES SAME type 2 or 3; for other types the zone sizes might be different for individual zones. So issue a warning if the type is found to be

[PATCH 1/9] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

The queue limits already have a 'chunk_sectors' setting, so we should be presenting it via sysfs. Signed-off-by: Hannes Reinecke --- block/blk-sysfs.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index

[PATCH 2/9] block: update chunk_sectors in blk_stack_limits()

Signed-off-by: Hannes Reinecke --- block/blk-settings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/blk-settings.c b/block/blk-settings.c index c7bb666..29fa900 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -630,6 +630,9 @@ int

[PATCH 0/9] block/scsi: Implement SMR drive support

Hi all, here's a patchset implementing SMR (shingled magnetic recording) device support for the block and SCSI layer. There are two main parts to it: - mapping the 'RESET WRITE POINTER' command to the 'discard' functionality. The 'RESET WRITE POINTER' operation is pretty close to the existing

[PATCH 7/9] block: Introduce BLKPREP_DONE

Add a new blkprep return code BLKPREP_DONE to signal completion without I/O error. Signed-off-by: Hannes Reinecke --- block/blk-core.c| 6 +- drivers/scsi/scsi_lib.c | 1 + include/linux/blkdev.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 6/9] block: Add 'zoned' sysfs queue attribute

Add a sysfs queue attribute 'zoned' to display the zone layout for zoned devices. Signed-off-by: Hannes Reinecke --- block/blk-sysfs.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c index

[PATCH 4/4] libata: support host-aware and host-managed ZAC devices

Byte 69 bits 0:1 in the IDENTIFY DEVICE data indicate a host-aware ZAC device. Host-managed ZAC devices have their own individual signature, and to not set the bits in the IDENTIFY DEVICE data. And whenever we detect a ZAC-compatible device we should be displaying the zoned block characteristics

[PATCH 3/4] libata: support device-managed ZAC devices

Device-managed ZAC devices just set the zoned capabilities field in INQUIRY byte 69 (cf ACS-4). This corresponds to the 'zoned' field in the block device characteristics VPD page. As this is only defined in SPC-5/SBC-4 we also need to update the supported SCSI version descriptor. Signed-off-by:

[PATCH 0/4] libata: ZAC support

Hi all, here's a patchset implementing ZAC support for libata. This is the second part of a larger patchset for ZAC/ZBC support; it requires the scsi trace fixes queued for in mkp/4.7/scsi-queue and the patchset 'libata: SATL update' I've posted earlier. The full patchset can be found at:

[PATCH 2/4] libata: Implement ZBC OUT translation

ZAC drives implement a 'zac management out' command template, which maps onto the ZBC OUT command. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 1 + drivers/ata/libata-scsi.c | 73 +++ include/linux/ata.h

[PATCH 1/4] libata: implement ZBC IN translation

ZAC drives implement 'zac management in' command template, which maps onto the ZBC IN command. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 1 + drivers/ata/libata-scsi.c | 144 ++ include/linux/ata.h |

[PATCH 05/14] libata-scsi: use scsi_set_sense_information()

Use scsi_set_sense_information() instead of hand-crafted function. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index

[PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

ata_to_sense_error() is called conditionally, so we should be generating a default sense if the condition is not met. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/ata/libata-scsi.c

[PATCH 04/14] libata: sanitize ata_tf_read_block()

Return (u64)-1 if ata_tf_read_block() could not decode the LBA address, and do not set the information sense descriptor in ata_gen_ata_sense() in these cases. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-core.c | 4 ++-- drivers/ata/libata-scsi.c | 2 ++

[PATCH 11/14] scsi: add scsi_set_sense_field_pointer()

Add a function to set the field pointer for SCSI sense codes. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_common.c | 53 ++ include/scsi/scsi_common.h | 1 + 2 files changed, 54 insertions(+) diff --git

[PATCH 02/14] libata: Implement support for sense data reporting

ACS-4 defines a sense data reporting feature set. This patch implements support for it. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-core.c | 20 +- drivers/ata/libata-eh.c | 67 --- include/linux/ata.h | 16

[PATCH 12/14] libata-scsi: Set field pointer in sense code

If the sense code is 'Invalid field in CDB' we should be setting the field pointer to the offending byte. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 155 -- 1 file changed, 108 insertions(+), 47 deletions(-) diff

[PATCH 07/14] libata-scsi: use ata_scsi_set_sense()

Use ata_scsi_set_sense() throughout to ensure the sense code format is consistent. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/ata/libata-scsi.c

[PATCH 13/14] libata-scsi: set bit pointer for sense code information

When generating a sense code of 'Invalid field in CDB' we should be setting the bit pointer where appropriate. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git

[PATCH 01/14] libata: Implement NCQ autosense

Some newer devices support NCQ autosense (cf ACS-4), so we should be using it to retrieve the sense code and speed up recovery. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 12 drivers/ata/libata-scsi.c | 7 ++- drivers/ata/libata.h | 1 +

[PATCH 10/14] libata: Implement control mode page to select sense format

Implement MODE SELECT for the control mode page to allow the OS to switch to descriptor sense. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 4 +- drivers/ata/libata-scsi.c | 119 +- drivers/ata/libata.h | 3 +-

[PATCH 00/14] libata: SATL update

Hi all, here's a patchset to update the SCSI-to-ATA translation layer. It is a resubmission of an earlier patchset for ATA autosense handling, which got reverted as Tejun pointed out some issues with libata EH. This patchset now implements proper autosense handling, where the retrieved sense

[PATCH 08/14] libata: evaluate SCSI sense code

Whenever a sense code is set it would need to be evaluated to update the error mask. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 28 +++- drivers/scsi/scsi_error.c | 3 ++- include/scsi/scsi_eh.h| 1 + 3 files changed, 22

[PATCH 06/14] libata-eh: Set 'information' field for autosense

If NCQ autosense or the sense data reporting feature is enabled the LBA of the offending command should be stored in the sense data 'information' field. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-eh.c | 2 ++ drivers/ata/libata-scsi.c | 17 +

[PATCH 14/14] libata-scsi: Set information sense field for invalid parameter

Whenever the sense key is set to 'invalid parameter' we should be filling out the sense-key specific information field in the sense buffer. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 79 +++ 1 file changed, 59

[PATCH 09/14] libata-scsi: generate correct ATA pass-through sense

Generate ATA pass-through sense for both fixed and descriptor format sense. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 93 ++- 1 file changed, 59 insertions(+), 34 deletions(-) diff --git a/drivers/ata/libata-scsi.c

Re: [PATCH v3 1/2] scsi: Add intermediate STARGET_REMOVE state to scsi_target_state

On 2016-04-02 18:36, James Bottomley wrote: On Thu, 2016-03-31 at 14:53 +0200, Johannes Thumshirn wrote: Add intermediate STARGET_REMOVE state to scsi_target_state to avoid running into the BUG_ON() in scsi_target_reap(). This intermediate state is only valid in the path from