Re: [PATCH 01/10] staging: fnic2 add initialization

2018-04-06 Thread Greg Kroah-Hartman
On Fri, Apr 06, 2018 at 03:00:11PM -0700, Oliver Smith-Denny wrote: > On Fri, Apr 06, 2018 at 07:07:52AM +0200, Greg Kroah-Hartman wrote: > > Why is this a drivers/staging/ driver at all? What is keeping you from > > getting this merged into the "proper" place in the kernel? > > > > If you have a

Re: 4.15.14 crash with iscsi target and dvd

2018-04-06 Thread Bart Van Assche
On Fri, 2018-04-06 at 21:03 -0400, Wakko Warner wrote: > Bart Van Assche wrote: > > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is > > > null. > > > I added a dev_printk in scsi_print_command where the 2 if stateme

Re: 4.15.14 crash with iscsi target and dvd

2018-04-06 Thread Wakko Warner
Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

Re: [PATCH v6] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-06 Thread Finn Thain
On Sat, 7 Apr 2018, Michael Schmitz wrote: > Changes since v5: > > Christoph Hellwig: > > - fix comment style > - drop initialization to zero in driver data init > - fix alignment in struct declarations > - drop braces around asm macros > - change board_base type to void __iomem * > - drop unnee

Re: 4.15.14 crash with iscsi target and dvd

2018-04-06 Thread Wakko Warner
Bart Van Assche wrote: > On Thu, 2018-04-05 at 22:06 -0400, Wakko Warner wrote: > > I know now why scsi_print_command isn't doing anything. cmd->cmnd is null. > > I added a dev_printk in scsi_print_command where the 2 if statements return. > > Logs: > > [ 29.866415] sr 3:0:0:0: cmd->cmnd is NULL

[PATCH v6] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-06 Thread Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for m68k Amiga. Code largely based on board specific parts of the old drivers (blz1230.c, blz2060.c, cyberstorm.c, cyberstormII.c, fastlane.c which were removed after the 2.6 kernel series for lack of maintenance) with contributions by T

[PATCH] scsi: scsi_dh: replace too broad "TP9" string with the exact models

2018-04-06 Thread Xose Vazquez Perez
SGI/TP9100 is not a RDAC array: ^^^ https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=blob;f=libmultipath/hwtable.c;h=88b4700beb1d8940008020fbe4c3cd97d62f4a56;hb=HEAD#l235 This reverts partially the 35204772ea034b380bc9d8942699dc03898e5c13 commit Cc: NetApp RDAC team Cc: Hannes Rei

[PATCH resend] scsi: devinfo: delete duplicate "Generic"/"USB Storage-SMC" device

2018-04-06 Thread Xose Vazquez Perez
Revision is irrelevant, it's unused by the scsi infrastructure. $ egrep "Generic.*Storage-SMC" /proc/scsi/device_info 'Generic' 'USB Storage-SMC' 0x402 'Generic' 'USB Storage-SMC' 0x402 Cc: Hannes Reinecke Cc: Martin K. Petersen Cc: James E.J. Bottomley Cc: SCSI ML Signed-off-by: Xose Vazquez

【全球最大轨道高铁展】关于参加9月“2018德国柏林国际轨道交通技术展”(InnoTrans 2018)的通知 ds <上P3-C50>

2018-04-06 Thread keywb2n
关于参加“2018德国柏林国际轨道交通技术展览会”(InnoTrans 2018)的通知    ds 各轨道交通与高速铁路有关单位:      为推动我国轨道交通行业与德国及欧洲地区商界的技术交流,促进我国轨道交通企业与世界各国轨道交通生产商和采购商的合作与发展,进一步开拓、巩固欧洲国际市场,我会将组织相关企业参加2018年9月在德国柏林举办的国际轨道交通技术展览会,现将有关事项通知如下:   一、展会简介      “德国柏林国际轨道交通技术展览会(InnoTrans)”创办于1996年,每两年一届,2018年度为第十二届,十余年来发展迅速,目前是“全世界轨道交通行业规模最大,发展最快,专

Re: [PATCH] target: prefer dbroot of /etc/target over /var/target

2018-04-06 Thread kbuild test robot
Hi Lee, I love your patch! Yet something to improve: [auto build test ERROR on target/for-next] [also build test ERROR on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCHv2] target: prefer dbroot of /etc/target over /var/target

2018-04-06 Thread Lee Duncan
The target database root directory, dbroot, has defaulted to /var/target for a while, but its main client, targetcli-fb, has been moving it to /etc/target for quite some time. With the plethora of target drivers now appearing, it has become more difficult to initialize this attribute before use by

Re: [PATCH] target: prefer dbroot of /etc/target over /var/target

2018-04-06 Thread Lee Duncan
I will be re-sending this, as this version somehow missed a change to an include file. On 04/06/2018 08:37 AM, Lee Duncan wrote: > The target database root directory, dbroot, has > defaulted to /var/target for a while, but its > main client, targetcli-fb, has been moving it > to /etc/target for qu

Re: Multi-Actuator SAS HDD First Look

2018-04-06 Thread Douglas Gilbert
On 2018-04-06 02:42 AM, Christoph Hellwig wrote: On Fri, Apr 06, 2018 at 08:24:18AM +0200, Hannes Reinecke wrote: Ah. Far better. What about delegating FORMAT UNIT to the control LUN, and not implementing it for the individual disk LUNs? That would make an even stronger case for having a control

Re: [PATCH] target: prefer dbroot of /etc/target over /var/target

2018-04-06 Thread kbuild test robot
Hi Lee, I love your patch! Yet something to improve: [auto build test ERROR on target/for-next] [also build test ERROR on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH] target: prefer dbroot of /etc/target over /var/target

2018-04-06 Thread Lee Duncan
The target database root directory, dbroot, has defaulted to /var/target for a while, but its main client, targetcli-fb, has been moving it to /etc/target for quite some time. With the plethora of target drivers now appearing, it has become more difficult to initialize this attribute before use by

Re: [PATCH] qla2xxx: correctly shift host byte

2018-04-06 Thread Bart Van Assche
On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote: > The host byte has to be shifted by 16 not 6. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/driv

Re: [PATCH v1 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-06 Thread Bart Van Assche
On Thu, 2018-04-05 at 11:46 -0400, Chaitra P B wrote: > Check scsi tracker 'st' for NULL and st->smid for zero (as driver uses smid > starting from one) before accessing it. > These checks are added as there are possibilities for getting valid > scsi_cmd when driver calls scsi_host_find_tag() API w

Re: [PATCH] qla2xxx: correctly shift host byte

2018-04-06 Thread Bart Van Assche
On Fri, 2018-04-06 at 09:52 +0200, Johannes Thumshirn wrote: > The host byte has to be shifted by 16 not 6. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/driv

Re: [PATCH v3 0/3] Report all request failures again to user space

2018-04-06 Thread Bart Van Assche
On Fri, 2018-04-06 at 09:45 +0200, Johannes Thumshirn wrote: > On 05/04/18 19:49, Martin K. Petersen wrote: > > Longer term I'd really like to see the command result integer > > host/driver/msg/status stuff cleaned up. It's super arcane and the > > associated naming schemes make it a very error-pro

Re: [PATCH 1/1] target:separate tx/rx cmd_puds

2018-04-06 Thread David Disseldorp
On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote: > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds); > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds); > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds); > > I don't think the in_cmds metric should be deleted here. It could b

[Bug 101201] hpsa hang when creating ext4 FS

2018-04-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101201 Hebe (skycitylove1...@gmail.com) changed: What|Removed |Added CC||skycitylove1...@gmail.c

[PATCH 2/3] megaraid_sas: Increase timeout by 1 sec for non-RAID fastpath IOs

2018-04-06 Thread Shivasharan S
Problem description: Hardware could timeout Fastpath IOs one second earlier than the timeout provided by the host. For non-RAID devices, driver provides timeout value based on OS provided timeout value. Under certain scenarios, if the OS provides a timeout value of 1 second, due to above behavior

[PATCH 1/3] megaraid_sas: Use zeroing memory allocator than allocator/memset

2018-04-06 Thread Shivasharan S
From: Himanshu Jha Use pci_zalloc_consistent for allocating zeroed memory and remove unnecessary memset function. Done using Coccinelle. Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Suggested-by: Luis R. Rodriguez Signed-off-by: Himanshu Jha Signed-off-by: Shivasharan S --

[PATCH 3/3] megaraid_sas: driver version upgrade

2018-04-06 Thread Shivasharan S
Signed-off-by: Shivasharan S --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index ba6503f37756..cb792bbfbf8b 100644 --- a/drivers/scsi/megaraid/megaraid_s

[PATCH 0/2] megaraid_sas: driver fixes and updates

2018-04-06 Thread Shivasharan S
Himanshu Jha (1): megaraid_sas: Use zeroing memory allocator than allocator/memset Shivasharan S (2): megaraid_sas: Increase timeout by 1 sec for non-RAID fastpath IOs megaraid_sas: driver version upgrade drivers/scsi/megaraid/megaraid_sas.h| 4 ++-- drivers/scsi/megaraid/megaraid

Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk

2018-04-06 Thread Petr Mladek
On Fri 2018-04-06 10:30:16, Petr Mladek wrote: > On Tue 2018-04-03 14:19:43, wen.yan...@zte.com.cn wrote: > > On the other hand,queue_lock is big, looping doing something under spinlock > > > > may locked many things and taking a long time, may cause some problems. > > > > So This code needs to

Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk

2018-04-06 Thread Petr Mladek
On Tue 2018-04-03 14:19:43, wen.yan...@zte.com.cn wrote: > On the other hand,queue_lock is big, looping doing something under spinlock > > may locked many things and taking a long time, may cause some problems. > > So This code needs to be optimized later: > > scsi_request_fn() > { > for

[PATCH] qla2xxx: correctly shift host byte

2018-04-06 Thread Johannes Thumshirn
The host byte has to be shifted by 16 not 6. Signed-off-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 89f93ebd819d..49d67e1d571f 100644 --- a/driv

Re: [PATCH v3] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk

2018-04-06 Thread Petr Mladek
On Tue 2018-04-03 14:04:40, Wen Yang wrote: > There would be so many same lines printed by frequent printk if one > disk went wrong, like, > [ 546.185242] sd 0:1:0:0: rejecting I/O to offline device > [ 546.185258] sd 0:1:0:0: rejecting I/O to offline device > [ 546.185280] sd 0:1:0:0: rejecting

Re: [PATCH v3 0/3] Report all request failures again to user space

2018-04-06 Thread Johannes Thumshirn
On 05/04/18 19:49, Martin K. Petersen wrote: > > Bart, > >> A recent change in the SCSI core caused certain request failures no >> longer to be reported to user space. Damien noticed this by sending a >> write request that is not aligned to the write pointer to an SMR drive >> from user space. Su

Re: [PATCH] target: change default dbroot to /etc/target

2018-04-06 Thread Christoph Hellwig
On Thu, Apr 05, 2018 at 01:54:25PM -0700, Lee Duncan wrote: > How about if the code looks for /etc/target, then uses /var/target if > /etc/target is not present? Then users can use the current sysfs logic > to set the path to any other directory, if neither of these paths are to > their liking? >