arm-scsi core is not sg-chain ready, so maximum scatterlist supported
is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers
use it for the sg_tablesize in host templates.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/arm/acornscsi.c |2 +-
drivers/scsi
wd33c93 core is not sg-chain ready, so maximum scatterlist supported
is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers
use it for the sg_tablesize in host templates.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/a2091.c |2 +-
drivers/scsi/a3000.c
NCR5380 core is not sg-chain ready, so maximum scatterlist supported
is SCSI_MAX_SG_SEGMENTS. Define it so, in core, and let all drivers
use it for the sg_tablesize in host templates.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/NCR5380.h |3 +++
drivers/scsi
/qla_os.c
drivers/scsi/qla4xxx/ql4_def.h
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/atari_scsi.c|8
drivers/scsi/atari_scsi.h|4 ++--
drivers/scsi/eata_pio.c |5 -
drivers/scsi/ibmvscsi/ibmvscsi.c |8
:
drivers/firewire/fw-sbp2.c
drivers/ieee1394/sbp2.[ch]
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/firewire/fw-sbp2.c |6 --
drivers/ieee1394/sbp2.c|2 +-
drivers/ieee1394/sbp2.h|4 +++-
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git
I have scanned through the scsi tree and checked all places that used
SG_ALL. Those drivers that where not ready for SG_ALL to mean any size
where changed to what ever is appropriate for this driver.
Mainly 3 groups.
Those that meant SG_ALL == 255:
[PATCH 1/8] firewire: ieee1394: Move away
drivers/scsi/in2000.h
drivers/scsi/pcmcia/nsp_cs.c
drivers/scsi/ppa.c
drivers/scsi/tmscsim.c
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/aha152x.c |5 -
drivers/scsi/esp_scsi.c |2 +-
drivers/scsi/esp_scsi.h |3 +++
drivers/scsi
On Thu, Jan 17 2008 at 19:47 +0200, Andrew Vasquez [EMAIL PROTECTED] wrote:
On Thu, 17 Jan 2008, Boaz Harrosh wrote:
below list of drivers have used SG_ALL as a size to
preallocate maximum possible command's sg-count.
This is no longer possible since the maximum is not
set
/nsp32.h
drivers/scsi/qla1280.c
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/atari_scsi.c|8
drivers/scsi/atari_scsi.h|4 ++--
drivers/scsi/eata_pio.c |5 -
drivers/scsi/ibmvscsi/ibmvscsi.c |8 +---
drivers/scsi
On Tue, Jan 15 2008 at 19:35 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Tue, Jan 15 2008 at 18:49 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-01-15 at 18:09 +0200, Boaz Harrosh wrote:
On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
I thought
On Wed, Jan 16 2008 at 17:09 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-01-16 at 16:01 +0200, Boaz Harrosh wrote:
On Tue, Jan 15 2008 at 19:35 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Tue, Jan 15 2008 at 18:49 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
On Tue
On Wed, Jan 16 2008 at 18:11 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Wed, Jan 16 2008 at 17:09 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Wed, 2008-01-16 at 16:01 +0200, Boaz Harrosh wrote:
On Tue, Jan 15 2008 at 19:35 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Tue, Jan 15
On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
This is the second version of
http://marc.info/?l=linux-scsim=119933628210006w=2
I gave up once, but I found that the performance loss is negligible
(within 1%) by using kmem_cache_alloc instead of mempool.
I
On Tue, Jan 15 2008 at 17:08 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Tue, 15 Jan 2008 15:56:56 +0200
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Tue, Jan 15 2008 at 11:23 +0200, FUJITA Tomonori [EMAIL PROTECTED]
wrote:
This is the second version of
http://marc.info/?l=linux-scsim
On Tue, Jan 15 2008 at 17:20 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-01-15 at 18:23 +0900, FUJITA Tomonori wrote:
This is the second version of
http://marc.info/?l=linux-scsim=119933628210006w=2
I gave up once, but I found that the performance loss is negligible
(within
On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley [EMAIL PROTECTED] wrote:
I thought, now we had this new shiny code to increase the scatterlist
table size I'd try it out. It turns out there's a pretty vast block
conspiracy that prevents us going over 128 entries in a scatterlist.
The
On Tue, Jan 15 2008 at 18:49 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2008-01-15 at 18:09 +0200, Boaz Harrosh wrote:
On Tue, Jan 15 2008 at 17:52 +0200, James Bottomley [EMAIL PROTECTED]
wrote:
I thought, now we had this new shiny code to increase the scatterlist
table size
- Original Message -
*From:* Hans de Goede [EMAIL PROTECTED]
*To:* USB Storage list [EMAIL PROTECTED]
*CC:* [EMAIL PROTECTED], USB development list
[EMAIL PROTECTED], David Brown
[EMAIL PROTECTED], Guillaume Bedot [EMAIL PROTECTED],
linux-scsi@vger.kernel.org, [EMAIL PROTECTED]
*Sent:*
On Thu, Jan 10 2008 at 12:52 +0200, Hans de Goede [EMAIL PROTECTED] wrote:
Boaz Harrosh wrote:
- Original Message -
*From:* Hans de Goede [EMAIL PROTECTED]
*To:* USB Storage list [EMAIL PROTECTED]
*CC:* [EMAIL PROTECTED], USB development list
[EMAIL PROTECTED], David Brown
[EMAIL
On Thu, Jan 10 2008 at 14:33 +0200, Oliver Neukum [EMAIL PROTECTED] wrote:
Hi,
could you explain to me why this code can get away with allocating the
sense buffer on the stack?
static int sg_io(struct file *file, struct request_queue *q,
struct gendisk *bd_disk, struct
On Thu, Jan 10 2008 at 15:06 +0200, Jens Axboe [EMAIL PROTECTED] wrote:
On Thu, Jan 10 2008, Boaz Harrosh wrote:
On Thu, Jan 10 2008 at 14:33 +0200, Oliver Neukum [EMAIL PROTECTED] wrote:
Hi,
could you explain to me why this code can get away with allocating the
sense buffer on the stack
On Thu, Jan 10 2008 at 21:45 +0200, Andre Noll [EMAIL PROTECTED] wrote:
On 20:29, Andi Kleen wrote:
Sure, I can do that if James likes the idea. Since not all case
statements need the BKL, we could add it only to those for which it
isn't clear that it is unnecessary.
And this would
On Mon, Jan 07 2008 at 8:53 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Sun, 23 Dec 2007 13:09:05 +0200
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt [EMAIL
PROTECTED] wrote:
The sense buffer ins scsi_cmnd can nowadays be DMA'ed
On Sat, Jan 05 2008 at 1:02 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Thu, 2007-12-13 at 13:44 +0200, Boaz Harrosh wrote:
- If we export scsi_init_io()/scsi_release_buffers() instead of
scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
much more insulated from
On Thu, Jan 03 2008 at 10:50 +0200, Rusty Russell [EMAIL PROTECTED] wrote:
This patch simply converts direct uses of -use_sg and -request_buffer to
use the wrapper macros. This removes the assumption that the sg list is
overloaded on request_buffer, and that there's an explicit use_sg field.
On Thu, Jan 03 2008 at 9:00 +0200, Rusty Russell [EMAIL PROTECTED] wrote:
OK, after wading through many scsi drivers, I decided to change tack and try
to provide a transition path. This is in two stages:
1) These two patches. sg_ring used underneath, but if any driver asks for
On Thu, Jan 03 2008 at 6:56 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
To remove sense_buffer array in scsi_cmnd structure, this replaces
sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in several LLDs.
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/ata/libata-scsi.c
James
Could you at least put the following patch in scsi-pending
so it can attract some acknowledgment, and retract futile
attempts from people at coding these drivers.
(And also git is better than me in maintaining it synced)
Christoph Hellwig!
I need your Recommended-by: on this. I had my
On Sat, Dec 29 2007 at 3:50 +0200, thanatos [EMAIL PROTECTED] wrote:
I got a sata controller ignitio
00:11.0 SATA controller: Initio Corporation INI-1623 PCI SATA-II
Controller (rev 02) (prog-if 00 [Vendor specific])
Subsystem: Initio Corporation INI-1623 PCI SATA-II Controller
On Sat, Dec 22 2007 at 22:15 +0200, Pete Wyckoff [EMAIL PROTECTED] wrote:
I spent the last couple of days rebasing my working set of kernel
patches from 2.6.22-rc5 to 2.6.24-rc6. I want to use the BSG
interface from userspace to submit variable-length bidirectional
SCSI commands to targets
On Fri, Dec 21 2007 at 4:30 +0200, Benjamin Herrenschmidt [EMAIL PROTECTED]
wrote:
The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly
by some low level drivers (that typically happens with USB mass
storage).
This is a problem on non cache coherent architectures such as
On Thu, Dec 20 2007 at 9:58 +0200, Jens Axboe [EMAIL PROTECTED] wrote:
On Thu, Dec 20 2007, Rusty Russell wrote:
On Thursday 20 December 2007 18:07:41 FUJITA Tomonori wrote:
On Thu, 20 Dec 2007 16:45:18 +1100
Rusty Russell [EMAIL PROTECTED] wrote:
OK, some fixes since last time, as I wade
From: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Jens Axboe [EMAIL PROTECTED]
---
drivers/scsi/libsrp.c|2 +-
drivers/scsi/scsi_error.c|4 +-
drivers/scsi/scsi_lib.c | 150 +-
drivers/usb/storage/isd200.c |4 +-
A small comment in body
On Thu, Dec 20 2007 at 16:00 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
Manually doing chained sg lists is not trivial, so add some helpers
to make sure that drivers get it right.
Signed-off-by: Jens Axboe [EMAIL PROTECTED]
---
include/linux/scatterlist.h | 125
On Thu, Dec 20 2007 at 16:03 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
From: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Jens Axboe [EMAIL PROTECTED]
---
drivers/scsi/libsrp.c|2 +-
drivers/scsi/scsi_error.c|4 +-
drivers/scsi/scsi_lib.c | 150
On Tue, Dec 18 2007 at 15:33 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
Submitted is a patchset for adding support for variable-length, extended, and
vendor specific CDBs. It should now cover the entire range of the
SCSI standard.
snip
ping James.
I understand that this is the last thing
On Wed, Dec 19 2007 at 10:48 +0200, Filippos Papadopoulos [EMAIL PROTECTED]
wrote:
On Dec 17, 2007 2:18 PM, Boaz Harrosh [EMAIL PROTECTED] wrote:
I have found one problem. Please try patch [2] below and report.
If it still fails try to enable debugging by setting with patch [1]
these values
On Thu, Dec 20 2007 at 9:22 +0200, Rusty Russell [EMAIL PROTECTED] wrote:
Hi Alan,
Was looking through initio.c to convert it to sg_ring, and noticed this
code:
initio_build_scb() around 2616:
sg = cblk-sglist[0];
scsi_for_each_sg(cmnd, sglist,
Submitted is a patchset for adding support for variable-length, extended, and
vendor specific CDBs. It should now cover the entire range of the
SCSI standard.
They are based on scsi-misc + the submitted bidi patches.
Difference from last time, is at struct request. I did a smallish
hack to save
infrastructure used for VARLEN CDB's.
So in effect MAX_COMMAND_SIZE means the maximum size command
scsi-ml supports without specifying a cmd_len by ULD's
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/firewire/fw-sbp2.c |2 +-
drivers/s390/scsi/zfcp_dbf.c |2 +-
drivers
varlen_cdb's.
- Note that this patch does not add any size to struct request
since the unsigned cmd_len is split here to 2 ushorts, which
is more then enough.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
block/ll_rw_blk.c |2 ++
include/linux/blkdev.h | 27
).
- clean-up some code paths that did not expect commands to be
larger than 16, and change cmd_len members' type to short as
char is not enough.
- Add support for varlen_cdb in scsi_execute.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Signed-off-by: Benny Halevy [EMAIL PROTECTED
On Mon, Dec 17 2007 at 13:41 +0200, Filippos Papadopoulos [EMAIL PROTECTED]
wrote:
On Dec 17, 2007 1:18 PM, Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 17 Dec 2007 11:39:47 +0200 Filippos Papadopoulos [EMAIL
PROTECTED] wrote:
Hi,
I have got an INITIO 9100 UW SCSI Controller with an IBM
On Mon, Dec 17 2007 at 14:18 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Mon, Dec 17 2007 at 13:41 +0200, Filippos Papadopoulos [EMAIL
PROTECTED] wrote:
On Dec 17, 2007 1:18 PM, Andrew Morton [EMAIL PROTECTED] wrote:
On Mon, 17 Dec 2007 11:39:47 +0200 Filippos Papadopoulos [EMAIL
On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox [EMAIL PROTECTED] wrote:
initio doesn't seem to have a maintainer...
Are you able to identify any earlier kernel which worked OK?
Maybe it's a new device? If you can get the `lspci -vvxx' output
for that device we can take a look.
If I
On Mon, Dec 17 2007 at 17:03 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-12-17 at 14:36 +, Alan Cox wrote:
On Mon, 17 Dec 2007 16:40:53 +0200
Boaz Harrosh [EMAIL PROTECTED] wrote:
On Mon, Dec 17 2007 at 15:05 +0200, Alan Cox [EMAIL PROTECTED] wrote:
initio doesn't seem
On Mon, Dec 17 2007 at 18:20 +0200, Olivier Galibert [EMAIL PROTECTED] wrote:
On Mon, Dec 17, 2007 at 06:08:59PM +0200, Boaz Harrosh wrote:
Below fixes a deadly typo. Might as well be included in 2.6.24
You're sure ? scsi_for_each_sg includes a (sg)++ already
On Thu, Dec 13 2007 at 20:43 +0200, [EMAIL PROTECTED] wrote:
From: Mike Christie [EMAIL PROTECTED]
The previous patches converted iscsi_tcp to support sg chaining.
This patch sets the proper flags and sets sg_table size to
4096. This allows fs io to be capped at max_sectors, but passthrough
On Sat, Dec 15 2007 at 2:27 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Tue, 2007-09-18 at 17:04 +0200, Boaz Harrosh wrote:
On Wed, Sep 12 2007 at 10:42 +0300, Russell King [EMAIL PROTECTED] wrote:
On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote:
- if (SCpnt
James hi.
Bidi patches just broke again, by a patch that fixes
some to-be-dead code. (scsi: BUG_ON() impossible condition)
Could it not just be accepted into the tree now.
It sat in -mm tree with no reports of breakage or
complains. What are we waiting for? the way I
see it there is nothing
- If we export scsi_init_io()/scsi_release_buffers() instead of
scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
much more insulated from scsi_lib changes. As a bonus it will
also gain bidi capability when it comes.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Acked
scsi_for_each_sg
* Use data accessors where appropriate.
- tgt: convert libsrp to use scsi_data_buffer
- isd200: This driver still bangs on scsi_cmnd IO members,
so need changing
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi
.
- In scsi_error.c at scsi_eh_prep/restore_cmnd() make sure bidi-lld is not
confused by a get-sense command that looks like bidi. This is done
by puting NULL at request-next_rq, and restoring.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/scsi_error.c |3 +
drivers/scsi/scsi_lib.c
if (rq_data_dir() == WRITE) else if() else chain had an extra
else since the if() is on a value of 1 bit.
Also with a bidi request rq_data_dir() == WRITE
and blk_bidi_rq() == true.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/sd.c |5 +
drivers/scsi/sr.c
Kiyoshi Ueda wrote:
This patch converts xsysace to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
xsysace is a little bit different from normal drivers.
xsysace driver has a state machine in it.
It calls end_that_request_first() and
On Tue, Dec 11 2007 at 18:33 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Mon, 2007-11-26 at 22:15 -0800, Andrew Morton wrote:
OK, thanks. I'll assume that James and Hannes have this in hand (or will
have, by mid-week) and I won't do anything here.
Just to confirm what I think I'm
On Wed, Dec 12 2007 at 17:18 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Wed, Dec 12, 2007 at 01:03:10PM +0200, Boaz Harrosh wrote:
- BIO flags bio-bi_rw and REQ flags req-cmd_flags no longer match.
Remove comments and do a proper translation between the 2 systems.
I'd rather see
On Wed, Dec 12 2007 at 19:06 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
Hi,
On Wed, 12 Dec 2007 11:09:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
Index: 2.6.24-rc4/drivers/block/xsysace.c
===
--- 2.6.24-rc4.orig/drivers
On Thu, Dec 06 2007 at 21:44 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
Hi Boaz, Jens,
On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c
snip
No I don't like it. The only client left for blk_end_request_callback
On Thu, Dec 06 2007 at 2:26 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
Hi Boaz,
On Tue, 04 Dec 2007 15:39:12 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
This patch converts bidi of scsi mid-layer to use
On Tue, Dec 04 2007 at 20:03 +0200, Alan Stern [EMAIL PROTECTED] wrote:
On Tue, 4 Dec 2007, Boaz Harrosh wrote:
perhaps below hunk should be added to your patch.
It looks like a good idea.
Was it decided when this data corruption bugfix is
merged.
I don't know -- I haven't heard
On Sat, Dec 01 2007 at 1:24 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
This patch adds 2 new interfaces for request completion:
o blk_end_request() : called without queue lock
o __blk_end_request() : called with queue lock held
Some device drivers call some generic functions below
On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
This patch converts bidi of scsi mid-layer to use blk_end_request().
rq-next_rq represents a pair of bidi requests.
(There are no other use of 'next_rq' of struct request.)
For both requests in the pair,
On Tue, Dec 04 2007 at 14:16 +0200, Jens Axboe [EMAIL PROTECTED] wrote:
On Fri, Nov 30 2007, Kiyoshi Ueda wrote:
Hello Jens,
The following is the updated patch-set for blk_end_request().
Changes since the last version are only minor updates to catch up
with the base kernel changes.
Do you
On Mon, Nov 26 2007 at 17:35 +0200, Alan Stern [EMAIL PROTECTED] wrote:
Not all devices correctly report the error-causing LBA in the
Information field of their sense data -- even when they set the Valid
bit. This patch (as1019) makes sd much more cautious about accepting
the reported LBA.
On Thu, Nov 29 2007 at 1:36 +0200, Andrew Morton [EMAIL PROTECTED] wrote:
On Wed, 28 Nov 2007 16:14:21 -0700
Matthew Wilcox [EMAIL PROTECTED] wrote:
On Wed, Nov 28, 2007 at 01:40:36PM -0800, Andrew Morton wrote:
On Wed, 28 Nov 2007 23:01:31 +0300
Alexey Dobriyan [EMAIL PROTECTED] wrote:
On Mon, Nov 26 2007 at 17:35 +0200, Alan Stern [EMAIL PROTECTED] wrote:
Not all devices correctly report the error-causing LBA in the
Information field of their sense data -- even when they set the Valid
bit. This patch (as1019) makes sd much more cautious about accepting
the reported LBA.
From: Randy Dunlap [EMAIL PROTECTED]
Fix scsi_tgt_lib build when dprintk is defined:
drivers/scsi/scsi_tgt_lib.c: In function 'scsi_tgt_cmd_destroy':
drivers/scsi/scsi_tgt_lib.c:183: warning: format '%lu' expects type 'long
unsigned int', but argument 6 has type 'unsigned int'
-by: Randy Dunlap [EMAIL PROTECTED]
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/scsi_tgt_lib.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c
index 5fd5fca..746f1a1 100644
--- a/drivers
On Tue, Nov 13 2007 at 8:40 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Mon, 12 Nov 2007 22:06:52 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
On Thu, 08 Nov 2007 18:59:30 +0200 Boaz Harrosh [EMAIL PROTECTED] wrote:
In preparation for bidi we abstract all IO members of scsi_cmnd
On Thu, Nov 08 2007 at 15:03 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Thu, 08 Nov 2007 11:24:36 +0200
Boaz Harrosh [EMAIL PROTECTED] wrote:
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 18343a6..28cf6fe 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -448,9
On Thu, Nov 08 2007 at 15:04 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Thu, 08 Nov 2007 10:32:56 +0200
Benny Halevy [EMAIL PROTECTED] wrote:
On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori [EMAIL PROTECTED] wrote:
On Tue, 06 Nov 2007 20:16:19 +0200
Boaz Harrosh [EMAIL PROTECTED
On Thu, Nov 08 2007 at 15:54 +0200, Jens Axboe [EMAIL PROTECTED] wrote:
On Thu, Nov 08 2007, Boaz Harrosh wrote:
James, Jens please note the question below
It is something that bothers me about sr.c
On Tue, Nov 06 2007 at 20:19 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
In preparation
.
- In scsi_error.c at scsi_eh_prep/restore_cmnd() make sure bidi-lld is not
confused by a get-sense command that looks like bidi. This is done
by puting NULL at request-next_rq, and restoring.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/scsi_error.c |3 +
drivers/scsi/scsi_lib.c
On Tue, Nov 06 2007 at 20:04 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
[1]
I propose a small change to scsi_tgt_lib.c that will make
tgt completely neutral to the scsi_data_buffer patch. And will
make it all that more ready for bidi, too. TOMO is this OK?
(Can you do without
- If we export scsi_init_io()/scsi_release_buffers() instead of
scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
much more insulated from scsi_lib changes. As a bonus it will
also gain bidi capability when it comes.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Acked
if (rq_data_dir() == WRITE) else if() else chain had an extra
else since the if() is on a value of 1 bit.
Also with a bidi request, rq_data_dir() == WRITE
and blk_bidi_rq() == true.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/sd.c |5 +
drivers/scsi/sr.c
scsi_for_each_sg
* Use data accessors where appropriate.
- tgt: convert libsrp to use scsi_data_buffer
- isd200: This driver still bangs on scsi_cmnd IO members,
so need changing
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED]
---
drivers/scsi
On Wed, Nov 07 2007 at 20:06 +0200, Tony Battersby [EMAIL PROTECTED] wrote:
Currently, the iSCSI driver returns the data transfer residual for
data-in commands (e.g. read) but not data-out commands (e.g. write).
This patch makes it return the data transfer residual for both types of
commands.
happy this time
Boaz Harrosh
-
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
- If we export scsi_init_io()/scsi_release_buffers() instead of
scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is
much more insulated from scsi_lib changes. As a bonus it will
also gain bidi capability when it comes.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED
scsi_for_each_sg
* Use data accessors where appropriate.
* Remove dead code (req_data_dir() != READ != WRITE)
- tgt: convert libsrp to use scsi_data_buffer
- isd200: This driver still bangs on scsi_cmnd IO members,
so need changing
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
Signed-off
.
- In scsi_error.c at scsi_eh_prep/restore_cmnd() make sure bidi-lld is not
confused by a get-sense command that looks like bidi. This is done
by puting NULL at request-next_rq, and restoring.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/scsi_error.c |3 +
drivers/scsi/scsi_lib.c
On Sat, Nov 03 2007 at 21:41 +0200, James Bottomley [EMAIL PROTECTED] wrote:
This one has a clear merge bug:
index 2597209..bc63349 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
snip
So could you fix it up correctly, please (and just email the patch, I
think it's the
On Fri, Nov 02 2007 at 13:17 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Fri, Nov 02, 2007 at 08:32:12AM +0200, Benny Halevy wrote:
I agree this is probably the cleanest implementation but when Boaz and I
initially discussed this approach he convinced me that LL block devices
assume
- code used to set sg_tablesize to zero for board revision
less than 6. This is no longer supported, therefore I
use sg_tablesize=1 and open code the sg handling for that case.
- Get rid of use of SG_NONE which will be removed soon.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED
- This patch depends on:
NCR5380: Use scsi_eh API for REQUEST_SENSE invocation
- convert to accessors and !use_sg cleanup
- FIXME: Not sg-chain ready look for ++cmd-SCp.buffer
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
drivers/scsi/NCR5380.c | 14
On Mon, Nov 05 2007 at 11:21 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote:
- code used to set sg_tablesize to zero for board revision
less than 6. This is no longer supported, therefore I
use sg_tablesize=1 and open code the sg handling for that case.
- Get rid of use of SG_NONE
On Tue, Nov 06 2007 at 8:54 +0200, [EMAIL PROTECTED] wrote:
gdth driver is modified NOT to use scp-eh_timeout. Now, it has
eh_timed_out (gdth_timed_out) to handle command timeouts for locked
I/O's. Have not tested as I don't have needed hardware! Patch is
against 2.6.23-mm1.
Thank you
- Use new scsi_eh_prep/restor_cmnd() for synchronous
REQUEST_SENSE invocation.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
drivers/scsi/aha152x.c | 38 --
1 files changed, 8 insertions(+), 30 deletions(-)
diff --git a/drivers/scsi/aha152x.c b
On Fri, Oct 26 2007 at 11:40 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
Neither gdth_get_status() nor __gdth_interrupt() need their 'irq'
argument, so remove it.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/gdth.c | 21 +
1 files changed, 9
On Sun, Oct 28 2007 at 17:51 +0200, Adrian Bunk [EMAIL PROTECTED] wrote:
This patch removes obviously dead code.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/scsi/seagate.c |2 --
1 file changed, 2 deletions(-)
Actually I have sent a patch to completely remove this
On Wed, Oct 24 2007 at 11:59 +0200, Jean Delvare [EMAIL PROTECTED] wrote:
In 2.6.24-rc1 I see the following warning:
drivers/scsi/sym53c8xx_2/sym_glue.c: In function sym_eh_handler:
drivers/scsi/sym53c8xx_2/sym_glue.c:612: warning: io_reset may be used
uninitialized in this function
On Thu, Oct 25 2007 at 15:03 +0200, Alexander Sabourenkov [EMAIL PROTECTED]
wrote:
Hello.
Background:
Promise TX4 SATA300 with sata_promise driver generates lots of errors,
both read and write.
I'm now trying to port Promise-written driver, which works ok with
2.6.11, to
On Thu, Oct 25 2007 at 7:09 +0200, Jeff Garzik [EMAIL PROTECTED] wrote:
Andrew Morton wrote:
On Wed, 24 Oct 2007 19:48:26 -0400 (EDT) Jeff Garzik [EMAIL PROTECTED]
wrote:
drivers/scsi/ips.c | 178
this driver seems a bit of a basket
Matthew Wilcox wrote:
On Thu, Oct 25, 2007 at 05:04:38PM +0200, Boaz Harrosh wrote:
I found that lint, even with the command line options recommended by
Do you mean Lindent / indent?
Yes indent. I found that there are better switches to indent than
what's in Lindent. But both are crap
On Tue, Oct 23 2007 at 19:48 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Tue, Oct 23, 2007 at 06:49:17PM +0200, Boaz Harrosh wrote:
You know Matthew when you first talked about this, I envisioned
something else.
Right, so did I. Christoph felt that alloc_cmnd/destroy_cmnd a la
On Tue, Oct 23 2007 at 21:15 +0200, Matthew Wilcox [EMAIL PROTECTED] wrote:
On Tue, Oct 23, 2007 at 08:46:52PM +0200, Boaz Harrosh wrote:
We could also add an alloc_bidi_cmnd/destroy_bidi_cmnd to the shost
template. Presumably most commands won't be bidi for any given host,
so it'd be a waste
On Sun, Oct 21 2007 at 18:19 +0200, James Bottomley [EMAIL PROTECTED] wrote:
On Fri, 2007-10-19 at 10:32 +0200, Hannes Reinecke wrote:
The patch enables support for 16-bit CDBs in aic7xxx and aic79xx.
aic7xxx can actually support up to 32-bit CDBs, should they ever see
the light of day.
.
Signed-off-by: Boaz Harrosh [EMAIL PROTECTED]
---
include/scsi/scsi_cmnd.h | 16 +---
1 files changed, 1 insertions(+), 15 deletions(-)
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
index 047ffe6..8b8759c 100644
--- a/include/scsi/scsi_cmnd.h
+++ b/include/scsi
201 - 300 of 561 matches
Mail list logo
