David C Somayajulu wrote:
This patch OBSOLETES previous patches 0/5 thru 5/5 titled qla4xxx: Add IPv6
support and misc. It incorporates the feedback received from Mike Christie
and others, and encapsulates everything into a single patch.
The patch contains the following:
1. clean
. This patch is fine as a
work-around until that gets merged, though.
Actually, I think the new scsi request infrastructure should be doing
the bouncing (rather than have it done in each problem path we
discover).
Mike Christie tells me we're missing bouncing by accident in the
scsi_execute path
Qi, Yanling wrote:
Hi All,
This panic is related to the interactions between scsi/sg.c, iscsi
initiator and tcp on the RHEL 2.6.9-42 kernel. But we may also have the
similar problem with open-iscsi initiator. I will explain why we see the
Yeah, this problem should occur in the upstream
that this seems to be a rather
wide-spread problem. Here's a patch to address this.
I did not see this in scsi-misc so I am not sure if it matters or you
need a ack or signed off for iscsi, but the iscsi and iser parts look ok
Signed-off-by: Mike Christie [EMAIL PROTECTED]
Index: linux-2.6/drivers
David C Somayajulu wrote:
Signed-off-by: David Somayajulu [EMAIL PROTECTED]
---
drivers/scsi/qla4xxx/ql4_mbx.c | 190 ++--
diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c
index 7f28657..0ef777a 100644
--- a/drivers/scsi/qla4xxx/ql4_mbx.c
+++
David C Somayajulu wrote:
Signed-off-by: David Somayajulu [EMAIL PROTECTED]
---
drivers/scsi/qla4xxx/ql4_def.h | 84 ---
drivers/scsi/qla4xxx/ql4_fw.h | 426
+++-
diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h
Olaf Kirch wrote:
Hi,
I tried to use the iSCSI initiator with iscsitarget on 2.6.21-rc6 today,
with rather mixed results.
I could log in okay, and a device would appear. Trying to mount
that device would hang though:
kernel: iscsi: ctask enq [read cid 0 sc df57e500 cdb 0x28 itt 0x1c
Olaf Kirch wrote:
On Wednesday 18 April 2007 17:38, Mike Christie wrote:
Could you send the trace? It is weird that we would get a storm of data
out commands for a IO that was only 4096 bytes (assuming part of the log
did not get cut off and the above line is the last one).
It turns out
Jens Axboe wrote:
On Tue, Apr 03 2007, FUJITA Tomonori wrote:
From: James Bottomley [EMAIL PROTECTED]
Subject: Re: SMP pass through interface via bsg
Date: Mon, 02 Apr 2007 12:01:41 -0500
On Tue, 2007-04-03 at 01:43 +0900, FUJITA Tomonori wrote:
OK. I found another bug in smp_test tool
Andreas Steinmetz wrote:
As posted to lkml and linux-scsi on 2007-03-15 without reply, see
http://marc.info/?l=linux-kernelm=117395128412313w=2 for original post:
It is not so nice when one can write backup tapes but the tapes cannot
be read. I don't know if memory management or the st
Pete Wyckoff wrote:
[EMAIL PROTECTED] wrote on Wed, 14 Mar 2007 12:18 -0400:
After reviewing this post by Pete Wyckoff:
http://marc.theaimsgroup.com/?l=linux-scsim=117278879816029w=2
I decided to update my sg v4 interface document originally
posted 20061106 which I will now call release 1.1
James Smart wrote:
@@ -1768,7 +1781,8 @@ static void iscsi_start_session_recovery
* flush queues.
*/
spin_lock_bh(session-lock);
-fail_all_commands(conn);
+fail_all_commands(conn,
+STOP_CONN_RECOVER ? DID_BUS_BUSY : DID_ERROR);
James Smart wrote:
Background:
The states, in the transport are:
event state
n/arunning
lose connectivityblocked
fastfail timeout still blocked, but with fastfail indicator
My patch changed this
[EMAIL PROTECTED] wrote:
The following patches attempt unify what upper layers will see drivers
like multipath can make a good guess. This relies on drivers being
Oops, I mean to say with the patches upper layers like multipath will
see common behavior from LLDs hooked into transport classes.
[EMAIL PROTECTED] wrote:
When using multipath and the fast_io_fail_tmo fires then the class
can fail commands with DID_TRANSPORT_FAILFAST or drivers can use
Bah, that is going to be wrong or ugly for tape commands.
We would want to add another new value, DID_TRANSPORT_ABORTED which
would check
-off-by: Mike Christie [EMAIL PROTECTED]
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 5f95570..30ae831 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -301,7 +301,7 @@ static int scsi_req_map_sg(struct reques
{
struct request_queue *q = rq-q;
int
Olaf Kirch wrote:
Make SG_SET_FORCE_LOW_DMA behave as advertised
I came across this by accident. I have serious doubts whether ISA DMA
is really relevant these days :-) but what the heck. Feel free to disregard
if this code is headed for the recycler anyway.
The SCSI-HOWTO says this about
Aravind Parchuri wrote:
[EMAIL PROTECTED] wrote:
Aravind Parchuri wrote:
My log messages were getting all mixed up, so I cleaned up my little
test to send just one command at a time. It actually looks like the mid
layer passes the command through to open-iscsi with the right size the
Aravind Parchuri wrote:
My log messages were getting all mixed up, so I cleaned up my little
test to send just one command at a time. It actually looks like the mid
layer passes the command through to open-iscsi with the right size the
first time, but then it sends a second command with
Aravind Parchuri wrote:
The patch has some problem. While ioctls with dxfer_len 32k still make
it through properly, the problematic ones now show up in open-iscsi's
queuecommand with request_bufflen = 0. I'm not sure what the problem is
now.
Could you send the sg and iscsi log output with
-by: Mike Christie [EMAIL PROTECTED]
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 9f7482d..dfe3ccd 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -301,7 +301,7 @@ static int scsi_req_map_sg(struct reques
{
struct request_queue *q = rq-q;
int
James Bottomley wrote:
On Sun, 2007-03-04 at 10:21 -0600, Mike Christie wrote:
I think they get around this and other request settings that need
resetting by using scsi_execute_async. They will take the command, data
direction and buffer fields from the original scsi_cmnd, then pass those
Mike Christie wrote:
James Bottomley wrote:
On Sun, 2007-03-04 at 10:21 -0600, Mike Christie wrote:
I think they get around this and other request settings that need
resetting by using scsi_execute_async. They will take the command, data
direction and buffer fields from the original scsi_cmnd
Douglas Gilbert wrote:
Mike,
I see you are removing the scatter_elem_sz parameter.
What decides the scatter gather element size? Can it
be greater than PAGE_SIZE?
Oh yeah, sorry I should have documented that.
I just made the code try to allocate as large a element as possible.
So the code
[EMAIL PROTECTED] wrote:
+ if (!access_ok(read ?
+VERIFY_WRITE : VERIFY_READ,
+p, iov_len))
+ return -EFAULT;
}
Dachepalli, Sudhir wrote:
scsi_req_map_sg::i=2,len=1024,data_len=3072,off=2048,PAGE_SIZE=4096,byte
s=1024,nr_vecs=0, nr_pages=0
if (bio_add_pc_page(q, bio, page, bytes, off) !=
bytes) {
Mike Christie wrote:
Dachepalli, Sudhir wrote:
scsi_req_map_sg::i=2,len=1024,data_len=3072,off=2048,PAGE_SIZE=4096,byte
s=1024,nr_vecs=0, nr_pages=0
if (bio_add_pc_page(q, bio, page, bytes, off) !=
bytes
Pete Wyckoff wrote:
Add a slave_configure function to iSCSI TCP to remove any DMA
alignment restriction. This permits the use of direct IO from
arbitrary addresses.
Signed-off-by: Pete Wyckoff [EMAIL PROTECTED]
---
drivers/scsi/iscsi_tcp.c | 11 +++
1 files changed, 11
also not sure if
the reserved buffer code should be living in bio.c
Signed-off-by: Mike Christie [EMAIL PROTECTED]
block/bsg.c |5
block/ll_rw_blk.c | 457 +---
block/scsi_ioctl.c |4
drivers/cdrom/cdrom.c
if the reserved buffer
allocation failed sg.c would just allocated what it could. In
this code we either allocate what was requested or we get nothing.
I will change this for the final patches since some apps may be
relying on that behavior.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
sg.c | 1007
On Sat, 2007-02-24 at 05:51 -0500, Mike Christie wrote:
v4.
mv sg.c features to the block layer helper code, so that tape, scsi_tgt,
and maybe bsg or block/scsi_ioctl.c can use them.
This patches moves the sg features and converts blk_rq_map_user and
bio_map_user callers to the new API
Mike Christie wrote:
The problem is that we assume we will get nice large segments. When
using sg it will try to allocate multiple pages and make large segments.
We could hit a bad case where we cannot allocate enough large segments,
so a worst case would result in a max_segment_size
Alan Stern wrote:
On Tue, 20 Feb 2007, Mike Christie wrote:
I think you actually want max_hw_sectors. Well, you might and you might
not :)
I think we do not. We don't care about the maximum transfer length the
driver can theoretically support; we care about the maximum transfer
length
Mike Christie wrote:
Yeah you are right getting memory is not a problem I replied about that
in the other mail. You do not have to use it, but the min of the
reserved buffer and max_sectors or max_hw_sectors could still be off for
drivers that do not support clustering or if there is a weird
sg duplicates a lot of block layer dio and copying code. The block layer
is missing some things like mmap helpers and a way to support sg and
st's reserve buffer. The next two patches move move functionality from
sg to the block layer so later st and osst can use it, and then coverts
sg to use the
did not test cdrom, tgt or bsg.
If you guys want me to try and break up the patches to make it easier to
review I will. Then I can resend them in a git bisect friendly way.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
diff --git a/block/bsg.c b/block/bsg.c
index e97e3ec..0bc819d 100644
want. I found one bug (in this patch and the old
sg.c) where interupting a command or closing a device while a command
was doing DIO can result in sleeping from invalid errors (sg_cmd_done
runs from a softirq, but dio unmapping needs process context).
Signed-off-by: Mike Christie [EMAIL PROTECTED
Douglas Gilbert wrote:
Mike Christie wrote:
sg duplicates a lot of block layer dio and copying code. The block layer
is missing some things like mmap helpers and a way to support sg and
st's reserve buffer. The next two patches move move functionality from
sg to the block layer so later st
Mike Christie wrote:
any missing functionality. I am still testing the patch. I have not
tested some of the older sg interfaces
I am pretty sure (100% :)), that I messed up the old interface handling.
-
-static int
-sg_write_xfer(Sg_request * srp)
-{
- sg_io_hdr_t *hp = srp-header
Mike Christie wrote:
Mike Christie wrote:
any missing functionality. I am still testing the patch. I have not
tested some of the older sg interfaces
I am pretty sure (100% :)), that I messed up the old interface handling.
-
-static int
-sg_write_xfer(Sg_request * srp
Mike Christie wrote:
Mike Christie wrote:
Mike Christie wrote:
any missing functionality. I am still testing the patch. I have not
tested some of the older sg interfaces
I am pretty sure (100% :)), that I messed up the old interface handling.
-
-static int
-sg_write_xfer(Sg_request * srp
Edward Goggin wrote:
Looks like a simple oversight, but does anyone know why there a
cmd_flags parameter for scsi_execute but not for scsi_execute_async?
Seems like this is lost functionality when scsi_execute_async replaced
scsi_do_req. Previously, the caller of scsi_do_req could set the
Kristian Høgsberg wrote:
On 1/14/07, Stefan Richter [EMAIL PROTECTED] wrote:
On 14 Jan, James Bottomley wrote:
The block layer currently provides sector (512) byte alignment
guarantees. However, there has been talk in SCSI of reducing that to
word (4) since that's what most intelligent
john clyne wrote:
Can anyone give me some guidance on where in the IO stack I might be running
into a 512KB limit on IO transfer sizes to an external FC device? I've
checked IO scheduler parameter
(/sys/block/dev/queue/{max_sectors_kb,max_hw_sectors_kb}. Both are set to
32767. I'm using
These are bug fixes for LSI support, big endian fix for sense len
calculation, digest porting errors, and printing output. There have been
several iscsi patches floating around from Andrew and other users and
this incorporates those patches.
The patches were made over scsi-misc, but apply to
FUJITA Tomonori wrote:
This patch fixes bio leaks in SG_IO.
http://marc.theaimsgroup.com/?l=linux-kernelm=116570666807983w=2
Tomo, when you ported and converted the patches there was another user
of blk_rq_map_user in the ide code. Did you get that path?
-
To unsubscribe from this list:
Mike Christie wrote:
FUJITA Tomonori wrote:
This patch fixes bio leaks in SG_IO.
http://marc.theaimsgroup.com/?l=linux-kernelm=116570666807983w=2
Tomo, when you ported and converted the patches there was another user
of blk_rq_map_user in the ide code. Did you get that path?
Ignore
Douglas Gilbert wrote:
James Bottomley wrote:
On Wed, 2006-12-06 at 00:14 +0100, Joerg Schilling wrote:
Well, accept the patch if it works.
It's not about work/not work: it's about correctness.
And in case that you don't like it, make sure that the _parameter_ is
moved to where it belongs:
Mike Christie wrote:
Douglas Gilbert wrote:
James Bottomley wrote:
On Wed, 2006-12-06 at 00:14 +0100, Joerg Schilling wrote:
Well, accept the patch if it works.
It's not about work/not work: it's about correctness.
And in case that you don't like it, make sure that the _parameter_
Mike Christie wrote:
Jeremy Linton wrote:
On Wednesday 06 December 2006 17:42, Jeremy Linton wrote:
On Wednesday 06 December 2006 16:50, Mike Christie wrote:
For iscsi, we could negotiate a value like MaxBurstLength which says
don't send commands with a payload larger than that size. I would
[EMAIL PROTECTED] wrote:
From: Akinobu Mita [EMAIL PROTECTED]
The return value of crypto_alloc_hash() should be checked by
IS_ERR().
Looks good to me.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
Either James can merge it or Andrew can forward it or if when I send my
update
Meelis Roos wrote:
This patch against 2.6.19 cures two runtogether printk messages in iSCSI
driver.
diff --git a/drivers/scsi/scsi_transport_iscsi.c
b/drivers/scsi/scsi_transport_iscsi.c
index 9b25124..2648dbd 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++
Boaz Harrosh wrote:
Mike Christie wrote:
Boaz Harrosh wrote:
Playing with some tests which I admit are not 100% orthodox I have
stumbled upon a bug that raises a serious question:
In the call to scsi_execute_async() in the use_sg case, must the
scatterlist* (pointed to by buffer) map
Boaz Harrosh wrote:
Playing with some tests which I admit are not 100% orthodox I have
stumbled upon a bug that raises a serious question:
In the call to scsi_execute_async() in the use_sg case, must the
scatterlist* (pointed to by buffer) map a buffer that's contiguous in
virtual memory or
Mike Christie wrote:
Boaz Harrosh wrote:
Playing with some tests which I admit are not 100% orthodox I have
stumbled upon a bug that raises a serious question:
In the call to scsi_execute_async() in the use_sg case, must the
scatterlist* (pointed to by buffer) map a buffer that's contiguous
James Smart wrote:
One question
Does this assume that an hba is both initiator and target ? target only ?
Do we have any issues if a scsi_host is a target only ?
I do not think that is fully worked out yet. The only target that is
done is the vscsi one which is a little different from
one
LLDD to SCSI Target messaging ?
-- james
Mike Christie wrote:
James Smart wrote:
One question
Does this assume that an hba is both initiator and target ? target
only ?
Do we have any issues if a scsi_host is a target only ?
I do not think that is fully worked out yet
Mike Christie wrote:
James Bottomley wrote:
On Thu, 2005-09-08 at 14:23 -0500, Mike Christie wrote:
I think the reason it was a dependency was becuase the transport
class manages does the lifetime management/refcounting for the
initiators/iscsi_tcp.c session struct. scsi_transport_iscsi
James Bottomley wrote:
netlink_kernel_create now has two new arguments; the module (which is
easy) and the number of groups, which I arbitrarily set to one.
Thanks. Are you going to apply this to scsi-misc? We are building a
patchset for fixes to send this weekend hopefully so we can take
James Bottomley wrote:
Now it looks like we'll have multiple users of the iscsi transport
class, the iscsi initiator shouldn't really be a dependency of it. This
patch moves iscsi to being an initiator in its own right which selects
the transport attributes.
I think the reason it was a
Dave C Boutcher wrote:
On Wed, Sep 07, 2005 at 12:49:32PM +0200, Christoph Hellwig wrote:
On Tue, Sep 06, 2005 at 04:28:01PM -0500, Dave C Boutcher wrote:
This device driver provides the SCSI target side of the virtual
SCSI on IBM Power5 systems. The initiator side has been in mainline
for
FUJITA Tomonori wrote:
month. We discussed it with Christoph and decided that it would be
better to start from scratch because of the design differences.
Some of the things we are trying to improve upon are things that are
better supported in 2.6. Some differences:
- We will support
Vladislav Bolkhovitin wrote:
Dave C Boutcher wrote:
On Wed, Sep 07, 2005 at 12:49:32PM +0200, Christoph Hellwig wrote:
On Tue, Sep 06, 2005 at 04:28:01PM -0500, Dave C Boutcher wrote:
This device driver provides the SCSI target side of the virtual
SCSI on IBM Power5 systems. The initiator
similarly to
FC and now SAS? Mike Christie had submitted patches:
[PATCH] add block/unblock to iscsi class
http://marc.theaimsgroup.com/?l=linux-scsim=111201856631844w=2
some time back. Why were the patches dropped?
The class we have today in mainline and that patch
Jeff Garzik wrote:
In general, I'm a bit worried about these changes, for two overall reasons:
1) I didn't see any analysis of the ultimate end users of block layer
error values: the filesystems.
The filesystems or helpers they use normally did not even check the
-Exyz error they were
Patrick Mansfield wrote:
On Wed, Aug 24, 2005 at 04:03:58AM -0500, Mike Christie wrote:
-#define end_io_error(uptodate) (unlikely((uptodate) = 0))
+enum {
+ BLK_SUCCESS = 0,/* Must be zero for compat with old usage */
+ BLKERR_IO, /* Generic I/O error
James Bottomley wrote:
On Wed, 2005-08-24 at 12:21 -0700, Patrick Mansfield wrote:
On Wed, Aug 24, 2005 at 04:03:58AM -0500, Mike Christie wrote:
-#define end_io_error(uptodate) (unlikely((uptodate) = 0))
+enum {
+ BLK_SUCCESS = 0,/* Must be zero for compat with old usage
;a=summary
The missing (and frankly really nasty) pieces are pulling all the sg
handling out of sg and st, but fortunately Mike Christie is working on
that.
James,
I haven't looked at what would be involved with the sg
driver but it is good to hear Mike C. is working on it.
I sent a patch
Douglas Gilbert wrote:
sg_io_hdr::info could be used to indicate whether DIO
was done or not (as is the present case in sg).
But if you are changing things, why not follow the
user supplied O_DIRECT open() flag?
It was only becuase the block layer functions that the
SG_IO code used to map a
at sg_write time, so we
can set everything up at blk_rq_map_user time.
Also export some functions and add some wrappers for
struct request handling.
I am still working on these patches and I thought
I saw Jens was going on vacation so I left him off the
cc.
Signed-off-by: Mike Christie [EMAIL
. In this patch sg.c just accesses the bio
and request directly :(
Signed-off-by: Mike Christie [EMAIL PROTECTED]
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -71,9 +71,6 @@ static void sg_proc_cleanup(void);
#include linux/version.h
#endif
Guennadi Liakhovetski wrote:
On Sun, 7 Aug 2005, Mike Christie wrote:
Guennadi Liakhovetski wrote:
Now, it would be best, I think, if somebody could review the patches to
dc395x and tmscsim. In case the 2 functions are correct, they could be
included in a central file (scsi_lib?) for all
Jens Axboe wrote:
On Fri, Jul 29 2005, Mike Christie wrote:
Hey Jens and James,
The inlined patch moves the bounce buffer handling to blk_execute_rq_nowait
so the scsi, sg io and cdrom code does not have to handle it. To accomplish
this I moved the bio_uncopy_user to a bi_end_io function
Dmitry Yusupov wrote:
On Sat, 2005-07-30 at 15:23 -0500, James Bottomley wrote:
On Sat, 2005-07-30 at 12:53 -0700, David S. Miller wrote:
From: James Bottomley [EMAIL PROTECTED]
Date: Sat, 30 Jul 2005 12:32:42 -0500
FIB has taken your netlink number, so I changed it to 32
MAX_LINKS is 32,
?
Patch was made against James scsi-block-2.6 tree.
Signed-off-by: Mike Christie [EMAIL PROTECTED]
diff --git a/drivers/block/ll_rw_blk.c b/drivers/block/ll_rw_blk.c
--- a/drivers/block/ll_rw_blk.c
+++ b/drivers/block/ll_rw_blk.c
@@ -2193,31 +2193,6 @@ int blk_rq_map_user_iov(request_queue_t
This is just a resend with Andries Brouwer ccd to make sure
I did not mess up any of the disk geometry stuff up.
On 32 bit archs with LBD set, setsize can cast a capacity so
that we result in heads==0 (capacity is sector_t which would
be a 64 bit value with LBD but it gets cast to a unsigned
The attached patch adds session block and unblock functions
similar to the rport block and unblock code.
The patch was built against scsi misc (but also pathces
against scsi rc fixes) and this patch
http://marc.theaimsgroup.com/?l=linux-scsim=81778109783w=2
which adds a scsi_flush_work
According to this article http://lwn.net/Articles/125930/, When
cancel_delayed_work() returns zero, it means that the delayed
work request was fired off before the call; it might, in fact,
be running on another CPU when the cancel attempt is made.
If it is successful, it returns a nonzero value.
Is FC_SCSI_SCAN_DELAY used by a FC driver that is
not yet in mainline? This patch just deletes it
if not since no one else is.
Signed-off-by: Mike Chrisite [EMAIL PROTECTED]
--- scsi-misc-2.6.orig/include/scsi/scsi_transport_fc.h 2005-03-25 21:35:06.0 -0800
+++
Jens Axboe wrote:
On Wed, Mar 16 2005, Christoph Hellwig wrote:
On Wed, Mar 16, 2005 at 05:53:39PM +0100, Jens Axboe wrote:
The list doesn't really need dma mapping at that point, the problem here
is that the driver needs to punt to pio mode because of foo. So calling
pci/dma_map_* is pointless,
Alex Aizman wrote:
This is to announce Open-iSCSI project: High-Performance iSCSI Initiator for
Linux.
MOTIVATION
==
Our initial motivations for the project were: (1) implement the right
user/kernel split, and (2) design iSCSI data path for performance. Recently
we added (3): get accepted
Matthew Zito wrote:
Hi,
The iscsi_sfnet module I compiled against my 2.6.10-xen0 tree loads
fine, but when the iscsid process goes to discover the luns, it sees the
luns but dumps error strings similar to the following:
Attached scsi disk sdb at scsi0, channel 0, id 0,
The attached patch copies the code from the fc transport
class which allows a LLD to block and unblock a device.
The block/unblock code is used by the iscsi-sfnet
driver in replacement of a internal timer doing the
same thing.
I understand that the target code is under construction
and our group
Andrew Vasquez wrote:
On Wed, 23 Feb 2005, Mike Christie wrote:
The attached patch copies the code from the fc transport
class which allows a LLD to block and unblock a device.
The block/unblock code is used by the iscsi-sfnet
driver in replacement of a internal timer doing the
same thing.
I
Mike Christie wrote:
Andrew Vasquez wrote:
On Wed, 23 Feb 2005, Mike Christie wrote:
Andrew Vasquez wrote:
Speaking of which, are there any major objections to the patches
proposed here:
Add scsi_target_[un]block() and scsi_target_remove() generics
http://marc.theaimsgroup.com/?l=linux-scsim
The attach patch converts scsi_debug to use the virtual scsi bus.
It was built against scsi-rc-fixes-2.6.
The interface has changed a little. Here is an
example of adding and removing a single host:
cd /sys/bus/scsi_host/drivers/scsi_debug
[EMAIL PROTECTED] scsi_debug]# ls
add_host dev_size_mb
+static void
+fc_rport_terminate(struct fc_rport *rport)
+{
+ struct Scsi_Host *shost = rport_to_shost(rport);
+ struct device *dev = rport-dev;
+ unsigned long flags;
+
+ if (rport-starget) {
+ scsi_forget_target(rport-starget);
+
James,
It appears there is a missing class_device_del.
The comments for transport_remove_device indicate
that transport_remove_classdev should call it
(which the attached patch does), but the comment in
attribute_container_remove_device:
If you want a
* two phase release: remove from visibility
The attached patch built against scsi-misc-2.6 moves the
target iSCSI attributes to a new structure representing
a iSCSI session. The reason for doing this is to
create a interface that allows the Sourceforge iSCSI driver
to create and setup a session through sysfs (no more
IOCTL at all in our
501 - 589 of 589 matches
Mail list logo
