On Tue, Nov 25, 2014 at 09:16:42AM -0500, Laurence Oberman wrote:
When we have an rport disconnect we race during rport deletion and
re-connection resulting in a panic.
When we do this, we call fc_remote_port_del() just before we do the calls to
re-establish the session with
the FC
On Thu, Nov 27, 2014 at 05:46:23AM +, Anil Gurumurthy wrote:
Patch looks good.
Thanks!
Acked-by: Anil Gurumurthy anil.gurumur...@qlogic.com
Thanks. Can someone give me a second review?
-Original Message-
From: Christoph Hellwig [mailto:h...@lst.de]
Sent: 24 November 2014
On Wed, Dec 03, 2014 at 02:32:04PM +0100, Hannes Reinecke wrote:
Why not setting the attribute to S_IRUGO always and drop the 'store'
method altogether?
For now I'm printing a warning if someone writes to it. I the long
run we can simply mark it r/o.
--
To unsubscribe from this list: send the
On Wed, Dec 03, 2014 at 04:34:48PM +0100, Ondrej Zary wrote:
I have an ASB-3940UA (bought around 2000) and use it for scanner so I can
test
patches.
The driver was working fine so I never had to look at the code. Now I see
that
it's 12K lines long :( Converting that to something simple
On Wed, Dec 03, 2014 at 03:42:19PM +, James Bottomley wrote:
That's the problem: The driver as-is works in all of the use cases, so
no-one has any motivation to fix it. Plus the complexity is pretty
daunting. It's not even the worst driver we have (that prize goes to
atp870u which still
-#define AdvAbortQueue(asc_dvc, scsiq) \
+#define AdvAbortQueue(asc_dvc, srb_tag) \
AdvSendIdleCmd((asc_dvc), (ushort) IDLE_CMD_ABORT, \
- (ADV_DCNT) (scsiq))
+ (ADV_DCNT) (srb_tag))
This change looks unrelated.
@@ -11250,7 +11250,7 @@
/* FIXME:
*
- * 1. Although all of the necessary command mapping places have the
- * appropriate dma_map.. APIs, the driver still processes its internal
- * queue using bus_to_virt() and virt_to_bus() which are illegal under
- * the API. The entire queue processing structure
On 12/04/2014 10:17 AM, Christoph Hellwig wrote:
-#define AdvAbortQueue(asc_dvc, scsiq) \
+#define AdvAbortQueue(asc_dvc, srb_tag) \
AdvSendIdleCmd((asc_dvc), (ushort) IDLE_CMD_ABORT, \
- (ADV_DCNT) (scsiq))
+ (ADV_DCNT) (srb_tag))
This
On 12/04/2014 10:20 AM, Christoph Hellwig wrote:
typedef struct asc_scsiq_2 {
-ASC_VADDR srb_ptr;
+__le32 srb_tag;
Given that the tag has no meaning for the hardware why do you
want to endian switch it? Keeping the ASC_VADDR for now makes
it easier to verify the hardware
Thanks,
I've applied both patches.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
applied.
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/04/2014 10:23 AM, Christoph Hellwig wrote:
/* FIXME:
*
- * 1. Although all of the necessary command mapping places have the
- * appropriate dma_map.. APIs, the driver still processes its internal
- * queue using bus_to_virt() and virt_to_bus() which are illegal under
- *
On Thu, Dec 04, 2014 at 10:25:41AM +0100, Hannes Reinecke wrote:
Given that the tag has no meaning for the hardware why do you
want to endian switch it? Keeping the ASC_VADDR for now makes
it easier to verify the hardware structures don't change.
Mhm. See the patch I've just sent to
The issue_reset variable can be used uninitialized. It should be set
to false at the start.
Also I cleaned up the types by using bool.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: style fix
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c
b/drivers/scsi/mpt2sas/mpt2sas_base.c
The issue_reset can be used uninitialized. It should be set to false
at the start.
Also I cleaned up the types a little by using bool.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: style fix. use true/false instead of 1/0.
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c
On Thu, Nov 27, 2014 at 05:59:58PM +0200, Yaniv Gardi wrote:
In this change we add support to the generic PHY framework.
Two UFS phys are implemented:
qmp-20nm and qmp-28nm.
Also, the files in this change implement the UFS HW (controller PHY)
specific behavior in Qualcomm chips.
On 1 December 2014 at 12:24, Andrew Brooks a...@sat.dundee.ac.uk wrote:
I'm having trouble writing to an LTO-5 tape drive connected via Adaptec 1405
Writing aborts with this in syslog:
st0: Sense Key : Aborted Command [current]
st0: Add. Sense: Tagged overlapped commands (task tag 0)
If I
On 12/04/2014 03:25 AM, Christoph Hellwig wrote:
Do you want me to apply this patch ASAP while waiting for the kexec ACK?
Both patches 1 and 4 can be pulled in while we wait for Eric's ack.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
To unsubscribe from this
On Mon, 2014-12-01 at 12:24 +, Andrew Brooks wrote:
Hi
I'm having trouble writing to an LTO-5 tape drive connected via Adaptec 1405
Writing aborts with this in syslog:
st0: Sense Key : Aborted Command [current]
st0: Add. Sense: Tagged overlapped commands (task tag 0)
Both the drive
On Dec 3, 11:38pm, Duane Grigsby wrote:
} Subject: Re: [Scst-devel] New qla2x00tgt Driver Question
Hi Greg,
Hi Duane, hope your day is starting out well.
I looked at your logs and also reviewed the PLOGI handling in
Trunk-SCST.15. We found a issue with PLOGI/PRLI cleanup handling that I'm
REPORT_LUN_SCAN does not report any outstanding unit attention
condition as per SAM. However, there are some target implementations
which might not be fully initialized by the time we're starting
the report lun scan.
For these targets we end up getting a default entry
(or even a partially filled
On Wed, 2014-11-26 at 12:45 -0500, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Wed, 26 Nov 2014 12:33:48 -0500
Subject: [PATCH] scsi_debug fix compare and write errors
Kernel build tools pointed out a memory leak so that has been
fixed and its error paths
On Wed, 2014-11-26 at 14:55 -0500, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Wed, 26 Nov 2014 14:41:55 -0500
Subject: [PATCH] scsi_debug improve driver description in Kconfig
Try to give a more accurate driver description and some extra
useful information in
On Mon, 2014-11-24 at 23:05 -0500, Douglas Gilbert wrote:
From: Douglas Gilbert dgilb...@interlog.com
Date: Mon, 24 Nov 2014 20:27:51 -0500
Subject: [PATCH 3/5] add Capacity Changed Unit Attention
Via sysfs the virtual_gb scsi_debug parameter can be changed while
LUs are in use. If that
From: Ewan D. Milne emi...@redhat.com
This patch series fixes a couple of problems in the code to generate UAs
when virtual_gb is changed, and adds the generation of a UA when max_luns
is changed. It also adds the generation of a UA when a WRITE BUFFER
command is issued.
Patches were generated
From: Ewan D. Milne emi...@redhat.com
Generate a REPORTED LUNS DATA HAS CHANGED Unit Attention if
sysfs max_luns is used to change the number of scsi_debug LUNs.
This is only done if scsi_debug_scsi_level is SPC-3 or above.
Additionally, implement SPC-4 behavior which only generates
this Unit
From: Ewan D. Milne emi...@redhat.com
All other traversals of the sdebug_host_list take the lock.
Signed-off-by: Ewan D. Milne emi...@redhat.com
---
drivers/scsi/scsi_debug.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index
From: Ewan D. Milne emi...@redhat.com
Accept the WRITE BUFFER command and do nothing other than
set the appropriate microcode has been changed UA on the LU.
From an earlier patch by Doug Gilbert.
Signed-off-by: Ewan D. Milne emi...@redhat.com
---
drivers/scsi/scsi_debug.c | 74
From: Ewan D. Milne emi...@redhat.com
This eliminates a superfluous log message when the capacity is changed:
check_readiness: unexpected unit attention code=3
Signed-off-by: Ewan D. Milne emi...@redhat.com
---
drivers/scsi/scsi_debug.c | 1 +
1 file changed, 1 insertion(+)
diff --git
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
Sent: Thursday, 04 December, 2014 10:39 AM
...
/**
+ * scsi_test_lun - waiting for a LUN to become ready
+ * @sdev:scsi_device to test
+ *
+ *
Yes, we¹ll copy you.
duane
On 12/4/14, 8:21 AM, Dr. Greg Wettstein g...@wind.enjellic.com wrote:
On Dec 3, 11:38pm, Duane Grigsby wrote:
} Subject: Re: [Scst-devel] New qla2x00tgt Driver Question
Hi Greg,
Hi Duane, hope your day is starting out well.
I looked at your logs and also reviewed
On Thu, 4 Dec 2014, Christoph Hellwig wrote:
On Tue, Nov 25, 2014 at 09:16:42AM -0500, Laurence Oberman wrote:
When we have an rport disconnect we race during rport deletion and
re-connection resulting in a panic.
When we do this, we call fc_remote_port_del() just before we do the calls to
On Thu, 2014-12-04 at 17:39 +0100, Hannes Reinecke wrote:
[...]
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 0af7133..ca39e32 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -119,6 +119,13 @@ MODULE_PARM_DESC(inq_timeout,
On 12/3/14, 8:18 PM, Martin K. Petersen wrote:
The Microsoft iSCSI target does not support REPORT SUPPORTED OPERATION
CODES. Blacklist these devices so we don't attempt to send the command.
Signed-off-by: Martin K. Petersen martin.peter...@oracle.com
Reported-by: j...@deti74.ru
Cc: Mike
Mike == Mike Christie micha...@cs.wisc.edu writes:
Mike In case other people test this patch, I wanted to warn people that
Mike the MS iSCSI target does the same sequence (sends reject PDU then
Mike drops the connection on us) for any command it does not
Mike support. We end up seeing the same
Dr. Greg Wettstein wrote on 12/03/2014 11:42 PM:
On Dec 3, 8:59pm, Vladislav Bolkhovitin wrote:
} Subject: Re: [Scst-devel] New qla2x00tgt Driver Question
Dr. Greg Wettstein wrote on 12/03/2014 12:46 PM:
Secondly, Vlad, we have been running additional testing for the last
two days and we
On 12/04/2014 09:00 PM, Elliott, Robert (Server Storage) wrote:
-Original Message-
From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
Sent: Thursday, 04 December, 2014 10:39 AM
...
/**
+ * scsi_test_lun - waiting for a
37 matches
Mail list logo
