Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

On 11/29/2016 04:45 PM, John Garry wrote: From: Xiaofei Tan This patch addresses 4 problems in the module probe/remove: - When hisi_sas_shost_alloc() fails after we alloc shost memory, we should free shost memory before the function returns. - When hisi_sas_probe()

Re: SG does not ignore dxferp (direct io + mmap)

On 12/02/2016 02:29 PM, Ewan D. Milne wrote: On Fri, 2016-12-02 at 04:21 -0800, Christoph Hellwig wrote: On Thu, Dec 01, 2016 at 08:40:31AM -0500, Martin K. Petersen wrote: Specifically, the problem appears to be caused by the removal of the setting of bio->bi_bdev, which would previously be

[PATCH] mpt3sas: switch to pci_alloc_irq_vectors

Cleanup the MSI-X handling allowing us to use the PCI-layer provided vector allocation. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 167 +++ drivers/scsi/mpt3sas/mpt3sas_base.h | 6 --

Re: SG does not ignore dxferp (direct io + mmap)

On Fri, 2016-12-02 at 04:21 -0800, Christoph Hellwig wrote: > On Thu, Dec 01, 2016 at 08:40:31AM -0500, Martin K. Petersen wrote: > > Specifically, the problem appears to be caused by the removal of > > the setting of bio->bi_bdev, which would previously be set to NULL. > > If I add: > > Very

[PATCH 02/11] megaraid_sas: 128 MSIX Support

SAS3.5 Generic Megaraid based Controllers will have the support for 128 MSI-X vectors, resulting in the need to support 128 reply queues This patch is depending on patch 1 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 1 +

[PATCH 01/11] megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers

This patch contains new pci device ids for SAS3.5 Generic Megaraid Controllers Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 11 ++- drivers/scsi/megaraid/megaraid_sas_base.c | 20 +++-

[PATCH] megaraid_sas: switch to pci_alloc_irq_vectors

Signed-off-by: Hannes Reinecke --- drivers/scsi/megaraid/megaraid_sas.h | 1 - drivers/scsi/megaraid/megaraid_sas_base.c | 78 +++ 2 files changed, 38 insertions(+), 41 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing

Detect sequential IO streams and pass those IOs directly to FW. This patch is depending on patch 3 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 1 + drivers/scsi/megaraid/megaraid_sas_base.c | 40 +++-

[PATCH 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

SAS3.5 Generic Megaraid Controllers FW will support new dynamic RaidMap to have different sizes for different number of supported VDs. This patch is depending on patch 5 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 7 +

[PATCH 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

Large SEQ IO workload should sent as non fast path commands This patch is depending on patch 7 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 8 + drivers/scsi/megaraid/megaraid_sas_base.c | 49

[PATCH 03/11] megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers

An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written with valid tag fields, the MPI SCSI IO requests

[PATCH 09/11] megaraid_sas: ldio_outstanding variable is not decremented in completion path

ldio outstanding variable needs to be decremented in io completion path for iMR dual queue depth This patch is depending on patch 8 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 07/11] megaraid_sas: Add the Support for SAS3.5 Generic Megaraid Controllers Capabilities

The Megaraid driver has to support the SAS3.5 Generic Megaraid Controllers Firmware functionality. This patch is depending on patch 6 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas_base.c | 53 ++---

Re: SG does not ignore dxferp (direct io + mmap)

- Original Message - > From: "Hannes Reinecke" > To: emi...@redhat.com, "Christoph Hellwig" > Cc: "Martin K. Petersen" , "Johannes Thumshirn" > , "Laurence Oberman" > , "Eyal Ben

Re: [PATCH] hpsa: expose enclosures

On Fri, Dec 02, 2016 at 11:36:33AM +0100, Hannes Reinecke wrote: > Some servers have a built-in enclosure which will show up on the > same bus as the internal physical devices. As the driver doesn't > differentiate here they'll be hidden from the OS. > This patch add a module parameter

Re: SG does not ignore dxferp (direct io + mmap)

On Thu, Dec 01, 2016 at 08:40:31AM -0500, Martin K. Petersen wrote: > Specifically, the problem appears to be caused by the removal of > the setting of bio->bi_bdev, which would previously be set to NULL. > If I add: Very odd. For one I would expect it to be NULL anyway, second I don't see why

Re: [PATCH] hpsa: expose enclosures

On 12/02/2016 12:39 PM, Christoph Hellwig wrote: On Fri, Dec 02, 2016 at 11:36:33AM +0100, Hannes Reinecke wrote: Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. As the driver doesn't differentiate here they'll be hidden from the OS.

Re: [PATCH] scsi_dh_alua: Fix RCU annotations

On Thu, Dec 01, 2016 at 11:30:50AM -0800, Bart Van Assche wrote: > This patch avoids that sparse complains about RCU pointer dereferences. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

[PATCH 05/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Fast Path for RAID 1/10 Writes

To improve RAID 1/10 Write performance, OS drivers need to issue the required Write IOs as Fast Path IOs (after the appropriate checks allowing Fast Path to be used) to the appropriate physical drives (translated from the OS logical IO) and wait for all Write IOs to complete. If any of the

[PATCH 00/11] Updates for scsi-next

Sasikumar Chandrasekaran (11): megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid Controllers megaraid_sas: 128 MSIX Support megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid Controllers megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream

[PATCH 10/11] megaraid_sas: Implement the PD Map support for SAS3.5 Generic Megaraid Controllers

Update Linux driver to use new pdTargetId field for JBOD target ID This patch is depending on patch 9 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h| 106 +--- drivers/scsi/megaraid/megaraid_sas_base.c

[PATCH 11/11] megaraid_sas: driver version upgrade

Upgrade driver version. This patch is depending on patch 10 Signed-off-by: Sasikumar Chandrasekaran --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

From: Michael Hernandez Replaces the old pci_enable_msi[x]* and pci_disable_msi[x] calls. Signed-off-by: Michael Hernandez Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 +

Re: [PATCH 2/3] hpsa: fallback to use legacy REPORT PHYS command

On 12/01/2016 10:50 PM, Don Brace wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, November 18, 2016 1:33 AM To: Martin K. Petersen Cc: Christoph Hellwig; James Bottomley; Don Brace; Martin Wilck; linux- s...@vger.kernel.org; Hannes Reinecke; Hannes

Re: [PATCH] hpsa: fallback to use legacy REPORT PHYS command

On 12/02/2016 11:32 AM, Hannes Reinecke wrote: Older SmartArray controllers (eg SmartArray 64xx) do not support the extended REPORT PHYS command, so fallback to use the legacy version here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 30

Re: [PATCH 0/2] hpsa: fix rmmod issues

On Thu, 2016-12-01 at 23:22 +, Don Brace wrote: > > -Original Message- > > From: Martin Wilck [mailto:mwi...@suse.de] > > Sent: Monday, November 21, 2016 8:04 AM > > To: Don Brace > > Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; > > linux- > > s...@vger.kernel.org;

[PATCH] hpsa: fallback to use legacy REPORT PHYS command

Older SmartArray controllers (eg SmartArray 64xx) do not support the extended REPORT PHYS command, so fallback to use the legacy version here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 30 +++--- 1 file changed, 27 insertions(+), 3

[PATCHv3] hpsa: fallback to use legacy REPORT PHYS command

Older SmartArray controllers (eg SmartArray 64xx) do not support the extended REPORT PHYS command, so fallback to use the legacy version here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 28 ++-- 1 file changed, 26 insertions(+), 2

[PATCH] hpsa: expose enclosures

Some servers have a built-in enclosure which will show up on the same bus as the internal physical devices. As the driver doesn't differentiate here they'll be hidden from the OS. This patch add a module parameter 'hpsa_expose_enclosure' which will expose these enclosures. Signed-off-by: Hannes

RE: [PATCHv3] hpsa: fallback to use legacy REPORT PHYS command

> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, December 02, 2016 4:36 AM > To: Martin K. Petersen > Cc: Christoph Hellwig; James Bottomley; Don Brace; linux- > s...@vger.kernel.org; Hannes Reinecke; Hannes Reinecke > Subject: [PATCHv3] hpsa: fallback to

Re: [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default

Hi Ondrej, On Wed, 2 Nov 2016, I wrote: > > I think this patch is incomplete and you should add these changes: > > diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c > index 7299ad9..0bf0322 100644 > --- a/drivers/scsi/g_NCR5380.c > +++ b/drivers/scsi/g_NCR5380.c > @@ -44,7

Re: [PATCH] mpt3sas: switch to pci_alloc_irq_vectors

Hi Hannes, [auto build test ERROR on scsi/for-next] [also build test ERROR on next-20161202] [cannot apply to v4.9-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/mpt3sas

RE: [PATCH 0/2] hpsa: fix rmmod issues

From: Martin Wilck [mwi...@suse.de] Sent: Friday, December 02, 2016 12:58 AM To: Don Brace Cc: dl-esc-Team ESD Storage Dev Support; iss_storage...@hp.com; linux-scsi@vger.kernel.org; James Bottomley; h...@lst.de; h...@suse.de; jthumsh...@suse.com Subject:

Re: scsi: use-after-free in bio_copy_from_iter

On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: > Hello, > > The following program triggers use-after-free in bio_copy_from_iter: > https://gist.githubusercontent.com/dvyukov/80cd94b4e4c288f16ee4c787d404118b/raw/10536069562444da51b758bb39655b514ff93b45/gistfile1.txt > >

Re: [PATCH 00/11] Updates for scsi-next

On 2.12.2016 15:07, Sasikumar Chandrasekaran wrote: > Sasikumar Chandrasekaran (11): > megaraid_sas: Add new pci device Ids for SAS3.5 Generic Megaraid > Controllers > megaraid_sas: 128 MSIX Support > megaraid_sas: EEDP Escape Mode Support for SAS3.5 Generic Megaraid > Controllers >

Re: [PATCH] mpt3sas: switch to pci_alloc_irq_vectors

On 12/02/2016 03:30 PM, Christoph Hellwig wrote: +static inline u16 _base_get_msix_index(struct MPT3SAS_ADAPTER *ioc) { + return pci_irq_get_affinity_vector(ioc->pdev, raw_smp_processor_id()); } This looks extremely sketchy. Are we guaranteed to always have enough MSI-X vectors that

Re: [PATCH] mpt3sas: switch to pci_alloc_irq_vectors

> +static inline u16 > _base_get_msix_index(struct MPT3SAS_ADAPTER *ioc) > { > + return pci_irq_get_affinity_vector(ioc->pdev, raw_smp_processor_id()); > } This looks extremely sketchy. Are we guaranteed to always have enough MSI-X vectors that each CPU has it's own? I'd much prefer to

Re: [PATCH v3 0/3] Add QLogic FastLinQ iSCSI (qedi) driver.

From: "Rangankar, Manish" Date: Fri, 2 Dec 2016 07:00:39 + > Please consider applying the qed patches 1 & 2 to net-next. Ok, done. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 3/5] qla2xxx: Add multiple queue pair functionality.

Hi Hannes, On 12/1/16, 12:39 AM, "Hannes Reinecke" wrote: >On 11/30/2016 09:24 PM, Himanshu Madhani wrote: >> From: Michael Hernandez >> >> Replaced existing multiple queue functionality with framework >> that allows for the creation of pairs of

Re: [PATCH v2 4/5] qla2xxx: Add Block Multi Queue functionality.

On 12/1/16, 2:25 AM, "Christoph Hellwig" wrote: >> -pci_disable_msix(ha->pdev); >> +pci_free_irq_vectors(ha->pdev); > >Please make the switch to pci_alloc_irq_vectors / pci_free_irq_vectors >a se[arate patch. Ack. We’ll split up patch. > >> +ret =

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

https://bugzilla.kernel.org/show_bug.cgi?id=176951 mus@gmail.com changed: What|Removed |Added CC||mus@gmail.com --- Comment #6

Re: SG does not ignore dxferp (direct io + mmap)

On Thu, 2016-12-01 at 08:40 -0500, Martin K. Petersen wrote: > > "Ewan" == Ewan D Milne writes: ... > Specifically, the problem appears to be caused by the removal of > the setting of bio->bi_bdev, which would previously be set to NULL. > If I add: > > diff --git

Re: SG does not ignore dxferp (direct io + mmap)

On Fri, 2016-12-02 at 15:10 +0100, Hannes Reinecke wrote: > On 12/02/2016 02:29 PM, Ewan D. Milne wrote: > > On Fri, 2016-12-02 at 04:21 -0800, Christoph Hellwig wrote: > >> On Thu, Dec 01, 2016 at 08:40:31AM -0500, Martin K. Petersen wrote: > >>> Specifically, the problem appears to be caused by

[PATCH] block: improve handling of the magic discard payload

Instead of allocating a single unused biovec for discard requests, send them down without any payload. Instead we allow the driver to add a "special" payload using a biovec embedded into struct request (unioned over other fields never used while in the driver), and overloading the number of

[PATCH] block: improve handling of the magic discard payload

Instead of allocating a single unused biovec for discard requests, send them down without any payload. Instead we allow the driver to add a "special" payload using a biovec embedded into struct request (unioned over other fields never used while in the driver), and overloading the number of

[PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

From: Michael Hernandez Replaced existing multiple queue functionality with framework that allows for the creation of pairs of request and response queues, either at start of day or dynamically. Signed-off-by: Sawan Chandak Signed-off-by:

[PATCH v3 5/6] qla2xxx: Add Block Multi Queue functionality.

From: Michael Hernandez Tell the SCSI layer how many hardware queues we have based on the number of max queue pairs created. The number of max queue pairs created will depend on number of MSI-X vector count. This feature can be turned on via CONFIG_SCSI_MQ_DEFAULT

[PATCH v3 6/6] qla2xxx: Fix Target mode handling with Multiqueue changes.

From: Quinn Tran - Fix race condition between dpc_thread accessing Multiqueue resources and qla2x00_remove_one thread trying to free resource. - Fix out of order free for Multiqueue resources. Also, Multiqueue interrupts needs a workqueue. Interrupt needed to stop

[PATCH v3 0/6] qla2xxx: Feture updates for driver.

Hi Martin, Please consider this revised series for scsi-misc inclusion at your earliest convenience. Changes from v2 --> v3 o Added patch to utilize pci_{alloc|free}_irq_vectors call as per Christoph's suggestion. o Clean up IRQ affinity and drop num_online_cpu() usage in driver as per

[PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation

From: Samy This patch helps resolve some of the mailbox timeout issue discovered during large SAN emulation testing where 1000+ initiators are trying to log into target mode personality. Since current mailbox interface handles submission and processing of commands in a

[PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET.

Reviewed-by: Hannes Reinecke Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_mbx.c | 52 ++ 1 file changed, 52 insertions(+) diff