Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330()

2014-07-27 Thread Vladimir Davydov
On Sat, Jul 26, 2014 at 06:21:02PM +0200, Christoph Hellwig wrote: Here's a formal one. James, can I get your signoff for it? Vladimir, can I get a reviewed-by from you (or anyone else)? --- From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 From: James Bottomley

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-07-27 Thread Boaz Harrosh
On 06/25/2014 04:17 AM, Vladislav Bolkhovitin wrote: Martin K. Petersen, on 06/23/2014 06:58 PM wrote: Mike == Mike Christie micha...@cs.wisc.edu writes: + unsigned int xfer_len = blk_rq_bytes(scmd-request); Mike Can you do bidi and dif/dix? Nope. Correction: at the moment. There is a

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-07-27 Thread Boaz Harrosh
On 06/25/2014 01:32 PM, Sagi Grimberg wrote: On 6/25/2014 11:48 AM, Sagi Grimberg wrote: SNIP I made the patch below which should fix both bidi support in iscsi and also WRITE_SAME (and similar commands) support. I'm a bit confused, for all commands (bidi or not) the iscsi header

Re: [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information

2014-07-27 Thread Boaz Harrosh
On 06/11/2014 12:09 PM, Sagi Grimberg wrote: In case protection information exists over the wire iscsi header data length is required to include it. Use protection information aware scsi helpers to set the correct transfer length. In order to avoid breakage, remove iser transfer length

Re: [PATCH v2 RESEND 18/23] pm8001: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-07-27 Thread Jack Wang
Hi Alex, Looks Ok for me. Please feel free to add my: Reviewed-by: Jack Wang xjtu...@gmail.com Thanks, Jack 2014-07-26 10:33 GMT+02:00 Alexander Gordeev agord...@redhat.com: On Wed, Jul 16, 2014 at 08:05:22PM +0200, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-07-27 Thread Christoph Hellwig
On Sun, Jul 27, 2014 at 12:11:11PM +0300, Boaz Harrosh wrote: If you have a tree that you want me to test I will be glad too. From this thread I'm confused as to what patches you want me to test? please point me to a tree you need testing. You can bug me any time, any tree. I will be happy to

[PATCH] scsi: qla4xxx: ql4_mbx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-27 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And in some cases modified to copy one character less than the overall length, as the entire area is already zeroed. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

Re: [PATCH 4/5] [SCSI] Do not use platform_bus as a parent

2014-07-27 Thread Greg Kroah-Hartman
On Sun, Jul 27, 2014 at 07:52:57AM +0400, James Bottomley wrote: On Sat, 2014-07-26 at 13:11 -0700, Greg Kroah-Hartman wrote: On Fri, Jul 25, 2014 at 07:46:56AM -0700, James Bottomley wrote: On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote: The host devices without a parent were

[PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-27 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And use the sizeof on the to string rather than strlen on the from string. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/scsi/3w-9xxx.c |3 ++- 1 file changed, 2 insertions(+),

[PATCH] scsi: bfa: bfa_fcbuild.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-27 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And use the sizeof on the to string rather than strlen on the from string. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/scsi/bfa/bfa_fcbuild.c |8 1 file changed, 4

Re: [RFC] hpsa: work in progress lockless monster patches

2014-07-27 Thread Hannes Reinecke
On 07/25/2014 09:28 PM, scame...@beardog.cce.hp.com wrote: hpsa: Work In Progress: lockless monster patches To be clear, I am not suggesting that these patches be merged at this time. This patchset is vs. Christoph Hellwig's scsi-mq.4 branch which may be found here:

Re: [PATCH] scsi: break from queue depth adjusting loops when device found

2014-07-27 Thread Hannes Reinecke
On 07/26/2014 06:17 PM, Christoph Hellwig wrote: On Sat, Jul 26, 2014 at 11:14:35AM -0500, Stephen Cameron wrote: Hmm, I forgot that that patch was in there, I wasn't trying to keep pushing it along. From the previous discussion, I got the impression I was simply wrong, and that this patch

[PATCH] scsi: bfa: bfa_fcs_lport.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-27 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. In some cases modified to copy one character less than the overall length, as the entire area is already zeroed. And replacing strncat with strlcat because of incorrect use. Signed-off-by: Rickard Strandqvist

[PATCH] scsi: bfa: bfa_fcs.c: Cleaning up missing null-terminate in conjunction with strncpy strncat

2014-07-27 Thread Rickard Strandqvist
Replacing strncp with strlcpy to avoid strings that lacks null terminate. And strncat with strlcat because of incorrect use, removed same the duplicated code. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/scsi/bfa/bfa_fcs.c | 80

Re: [PATCH] usb-storage/SCSI: Add broken_fua blacklist flag

2014-07-27 Thread Laszlo T.
2014-07-27 3:50 GMT+02:00 Alan Stern st...@rowland.harvard.edu: On Sat, 26 Jul 2014, Laszlo T. wrote: Hello, First of all I've just subscribed the linux-scsi thread. I hope you get my email the right way. I have also problems with Jmicron JMS567 mobile rack. I tried on different kernels:

Re: [Xen-devel] [PATCH V2 3/4] Introduce XEN scsiback module

2014-07-27 Thread Jürgen Groß
On 07/26/2014 05:23 PM, Christoph Hellwig wrote: Just a quick glance: a) this should move to drivers/target with the other target code I don't mind. I just followed the example of drivers/vhost/vhost.c and thought the similar xen module should be located under drivers/xen. b) you're