Re: [PATCH V5] Save command pool address of Scsi_Host

2014-08-13 Thread Hannes Reinecke
On 08/04/2014 01:30 PM, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool() isn't saving the pool

Re: [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-13 Thread Juergen Gross
On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance to review this code. Comments are inline below.. Thank you very much for your review! On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Introduces the

Re: [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information

2014-08-13 Thread Sagi Grimberg
On 8/6/2014 4:25 PM, Boaz Harrosh wrote: On 08/06/2014 03:43 PM, Sagi Grimberg wrote: Hi Boaz, I hate that you introduced this new transfer_length variable. It does not exist. In BIDI supporting driver there is out_len and in_len just as original code. Effectively, out_len and in_len are

RE: [PATCH] scsi: ufs: fix Command Type issue according to UFS 2.0 spec

2014-08-13 Thread Dong, Chuanxiao
Any comment to this patch? Thanks Chuanxiao -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Chuanxiao Dong Sent: Friday, August 01, 2014 4:01 PM To: linux-scsi@vger.kernel.org Cc: jbottom...@parallels.com;

Re: [PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed

2014-08-13 Thread scameron
On Wed, Jul 16, 2014 at 08:05:12PM +0200, Alexander Gordeev wrote: Currently the driver falls back to INTx mode when MSI-X initialization failed. This is a suboptimal behaviour for chips that also support MSI. This update changes that behaviour and falls back to MSI mode in case MSI-X mode

Re: [PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed

2014-08-13 Thread Alexander Gordeev
On Wed, Aug 13, 2014 at 11:04:54AM -0500, scame...@beardog.cce.hp.com wrote: On Wed, Jul 16, 2014 at 08:05:12PM +0200, Alexander Gordeev wrote: Currently the driver falls back to INTx mode when MSI-X initialization failed. This is a suboptimal behaviour for chips that also support MSI. This

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-13 Thread Oleg Nesterov
On 08/12, Luis R. Rodriguez wrote: +/* To be used by modules which can take over 30 seconds at probe */ Probably the comment should explain that this hack should only be used if the driver is buggy and is wating for real fix. +#define module_long_probe_init(initfn)

Re: [PATCH v2 RESEND 10/23] hpsa: Use pci_enable_msix_range() instead of pci_enable_msix()

2014-08-13 Thread scameron
On Mon, Apr 14, 2014 at 10:05:34AM +0200, Alexander Gordeev wrote: As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact()

Re: [PATCH] hpsa: refine the pci enble/disable handling]

2014-08-13 Thread scameron
Let me try again, this time not from gmail. On Thu, Jun 12, 2014 at 10:29 AM, Tomas Henzl the...@redhat.com wrote: When a second(kdump) kernel starts and the hard reset method is used the driver calls pci_disable_device without previously enabling it, so the kernel shows a warning - [

RE: [PATCH v3 2/3] cxgb4: use module_long_probe_init()

2014-08-13 Thread Anish Bhatt
Adding Casey who's actually incharge of this code and missing from the CC list -Anish -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 RESEND 04/23] bfa: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-08-13 Thread Anil Gurumurthy
Hi Alexander, I believe I acked the series already, if not, I am acking all the bfa patches in this series. Thanks, Anil -Original Message- From: Alexander Gordeev [mailto:agord...@redhat.com] Sent: 12 August 2014 16:20 To: Anil Gurumurthy Cc: linux-kernel; Anil Gurumurthy; Vijaya

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-13 Thread Juergen Gross
On 08/13/2014 09:02 AM, Juergen Gross wrote: On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance to review this code. Comments are inline below.. +static struct se_node_acl * +scsiback_alloc_fabric_acl(struct se_portal_group *se_tpg) +{ +struct