Re: [PATCH 00/15] qla2xxx: Bug Fixes and updates for target.

Hi Bart, On 2/3/17, 8:26 AM, "Bart Van Assche" wrote: >On Thu, 2017-02-02 at 11:42 -0800, Himanshu Madhani wrote: >> Please consider this series for inclusion in target-pending. > >Hello Himanshu, > >What tree have these patches been generated against? Not all

Re: [PATCH v2 00/14] qla2xxx: Bug Fixes and updates for target.

Hi Bart, On 2/8/17, 7:02 AM, "Bart Van Assche" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> Please consider this series for inclusion in target-pending. > >Hello Himanshu, > >I gave this patch series a try on a system equipped with two

Re: [PATCH v2 02/14] qla2xxx: Allow relogin to proceed if remote login did not finish

On 2/8/17, 10:42 AM, "Bart Van Assche" wrote: >The above code occurs two times in this patch. We try to avoid duplicating >code in the Linux kernel, especially code that contains hardcoded constants. >Have you considered to change the name of plogi_nack_done_jiff

Re: [PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete.

On 2/8/17, 5:03 AM, "Christoph Hellwig" wrote: >On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote: >> -spin_lock_irqsave(>vport_slock, flags); >> -while (atomic_read(>vref_count)) { >> -spin_unlock_irqrestore(>vport_slock, flags); >> - >> +

Re: [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

Hi Nic, On 2/7/17, 8:13 PM, "Nicholas A. Bellinger" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> Add routines to support T10 DIF tag. >> >> Signed-off-by: Quinn Tran >>

Re: [PATCH v2 06/14] qla2xxx: Improve T10-DIF/PI handling in driver.

Hi Bart, On 2/8/17, 10:57 AM, "Bart Van Assche" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> +/* Response code and sense key */ >> +((uint32_t *)ctio->u.status1.sense_data)[0] = >> +cpu_to_le32((0x70 << 24) | (sense_key <<

Re: [PATCH v2 04/14] qla2xxx: Use IOCB interface to submit non-critical MBX.

On 2/8/17, 10:48 AM, "Bart Van Assche" wrote: >On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c >> index db6bd92..4225256 100644 >> --- a/drivers/scsi/qla2xxx/qla_mbx.c >> +++

Re: [PATCH v4 00/12] qla2xxx: Feature updates for target.

On 1/24/17, 9:24 AM, "Bart Van Assche" wrote: >On 01/19/2017 10:29 PM, Himanshu Madhani wrote: >> Please consider this updated series for inclusion in target-pending. >> >> Changes from v3 --> v4 >> >> o Fixed warnings reported by smatch tool. >> o Fixed

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

On 1/24/17, 6:59 AM, "Mauricio Faria de Oliveira" wrote: >Hi Bart, > >First of all, sorry for the new bug; I didn't realize the pointer could >be NULL at this scenario. > >On 01/23/2017 02:34 PM, Bart Van Assche wrote: >> @@ -1624,7 +1627,8 @@

RE: [PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, February 23, 2017 2:57 AM > To: qla2xxx-upstr...@qlogic.com; James E . J . Bottomley > ; Martin K . Petersen > ; linux-scsi@vger.kernel.org >

Re: [PATCH 0/3] qla2xxx: Bug fixes and cleanup for the driver.

Hi Martin, On 2/20/17, 7:16 PM, "Martin K. Petersen" wrote: > "Himanshu" == Himanshu Madhani writes: Hi Himanshu, Himanshu> This series contains small cleanup + fix for regression that Himanshu> was introduced by

Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak

On 1/23/17, 8:34 AM, "Bart Van Assche" wrote: >qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map >so IRQs must be freed even if rsp_q_map allocation did not occur. >This was detected by kmemleak. > >Fixes: 4fa183455988 ("scsi: qla2xxx: Utilize

Re: [PATCH 2/2] qla2xxx: Avoid that issuing a LIP triggers a kernel crash

On 1/23/17, 8:34 AM, "Bart Van Assche" wrote: >Avoid that issuing a LIP as follows: > > find /sys -name 'issue_lip'|while read f; do echo 1 > $f; done > >triggers the following: > >BUG: unable to handle kernel NULL pointer dereference at (null) >Call Trace: >

Re: [PATCH v2 00/12] qla2xxx: Feature updates for target.

Hi Bart, On 1/17/17, 8:56 AM, "Bart Van Assche" wrote: >On Mon, 2017-01-16 at 12:35 -0800, Himanshu Madhani wrote: >> Please consider this updated series for inclusion in target-pending. > >Hello Himanshu, > >What kernel have these patches been generated against?

Re: [PATCH v2 08/12] qla2xxx: Add framework for Async fabric discovery.

On 1/17/17, 2:27 PM, "Bart Van Assche" wrote: >%phC Yes. It looks like typo in the message. Will update this patch with other sparse warnings fixes. Thanks, Himanshu >

RE: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

> n...@linux-iscsi.org > Cc: Malavali, Giridhar <giridhar.malav...@cavium.com>; linux- > s...@vger.kernel.org; Madhani, Himanshu > <himanshu.madh...@cavium.com> > Subject: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target. > > Hi Nic, > > Please c

RE: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Tuesday, February 28, 2017 2:10 PM > To: Madhani, Himanshu <himanshu.madh...@cavium.com>; target- > de...@vger.kernel.org; n...@linux-iscsi.org > Cc: linux-scsi@vger.kernel

Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O

On 11/7/16, 11:53 AM, "Mauricio Faria de Oliveira" wrote: >This patchset addresses a couple of errors that might happen during >PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), which prevent >the successful removal and re-addition of the adapter to the

Re: [PATCH 3/4] qla2xxx: Add Block Multi Queue functionality.

Hi Ewan, On 11/7/16, 8:43 AM, "Ewan D. Milne" wrote: >On Fri, 2016-11-04 at 09:33 -0700, himanshu.madh...@cavium.com wrote: >> From: Michael Hernandez >> >> Tell the SCSI layer how many hardware queues we have based on the >> number of max

Re: [PATCH 2/4] qla2xxx: Fix mailbox command timeout due to starvation

Hi Ewan, On 11/7/16, 7:53 AM, "Ewan D. Milne" wrote: >On Fri, 2016-11-04 at 09:33 -0700, himanshu.madh...@cavium.com wrote: >... >> @@ -2349,6 +2349,17 @@ uint32_t qla2x00_isp_reg_stat(struct qla_hw_data *ha) >> return atomic_read(>loop_state) == LOOP_READY; >> } >>

Re: [PATCH 3/4] qla2xxx: Add Block Multi Queue functionality.

Hi Christoph, On 11/4/16, 4:00 PM, "Christoph Hellwig" wrote: >On Fri, Nov 04, 2016 at 09:33:32AM -0700, himanshu.madh...@cavium.com wrote: >> From: Michael Hernandez >> >> Tell the SCSI layer how many hardware queues we have based on the

Re: [PATCH v4 4/6] qla2xxx: Add multiple queue pair functionality.

Hi Christoph, On 12/7/16, 11:05 AM, "Christoph Hellwig" wrote: >On Tue, Dec 06, 2016 at 11:07:44AM -0800, Himanshu Madhani wrote: >> From: Michael Hernandez >> >> Replaced existing multiple queue functionality with framework >> that allows

Re: [PATCH v4 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

Hi Christoph, On 12/7/16, 11:03 AM, "Christoph Hellwig" wrote: >> static int >> qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp) >> { >> #define MIN_MSIX_COUNT 2 >> #define ATIO_VECTOR 2 >> int i, ret; >> struct qla_msix_entry *qentry;

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

Hi Mike/Bart, On 12/8/16, 8:17 AM, "virtualization-boun...@lists.linux-foundation.org on behalf of Michael S. Tsirkin" wrote: >On Thu, Dec 08, 2016 at 06:38:11AM +, Bart Van Assche wrote: >> On

Re: [PATCH 00/22] qla2xxx: Target code enhancemets and feature update

Hi Nic, On 12/6/16, 12:30 PM, "Himanshu Madhani" wrote: >Hi Nic, > >Please consider this series for target-pending. This series is based on >scsi-misc series that was submitted earlier today. > >Here's link for that series >

Re: [PATCH 03/22] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version.

On 12/14/16, 1:12 PM, "Christoph Hellwig" wrote: >Please just remove TCM_QLA2XXX_VERSION entirely and use QLA2XXX_VERSION >directly instead. Ack. Will update patch and resubmit. >

Re: [PATCH 14/22] qla2xxx: Add interrupt polling mechanism

Hi Bart, Christoph, On 12/15/16, 1:27 AM, "Bart Van Assche" wrote: >On 12/14/2016 10:06 PM, Christoph Hellwig wrote: >> On Tue, Dec 06, 2016 at 12:30:43PM -0800, Himanshu Madhani wrote: >>> From: Quinn Tran >>> >>> This patch adds capability

Re: [PATCH 15/22] qla2xxx: Rename qlini_mode parameter

On 12/14/16, 1:07 PM, "Christoph Hellwig" wrote: >On Tue, Dec 06, 2016 at 12:30:44PM -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> Qlogic's adapter is able to behave in multiple modes: >> initiator, target, exclusive/either, and dual/both.

Re: [PATCH 01/22] qla2xxx: Fix wrong IOCB type assumption.

On 12/14/16, 1:09 PM, "Christoph Hellwig" wrote: >On Tue, Dec 06, 2016 at 12:30:30PM -0800, Himanshu Madhani wrote: >> +uint32_t unpacked_lun = 0; > >Please remove the unpacked_lun variable as well, and just directly >pass 0 to qlt_issue_task_mgmt. Ack, will update and

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

Hi Christoph, On 12/14/16, 1:18 PM, "Christoph Hellwig" wrote: > - the new qla2x00_free_fcport is entirely pointless, please drop > that part of the patch (and even if it wasn't pointless it should > have been a patch on it's own) > - please use struct names and not

Re: [PATCH 05/22] qla2xxx: Add DebugFS node of irq vector cpuid

Hi Christoph, On 12/14/16, 1:13 PM, "Christoph Hellwig" wrote: >Doesn't make sense - an interrupt can be assigned to multiple >CPUIDs, and you can see the assignment based on the irq count >in /proc/interrupts > We Added this for our debug purpose. We’ll drop this patch

Re: [PATCH 00/22] qla2xxx: Target code enhancemets and feature update

Hi Bart, On 12/12/16, 3:10 PM, "Madhani, Himanshu" <himanshu.madh...@cavium.com> wrote: >Hi Nic, > > > >On 12/6/16, 12:30 PM, "Himanshu Madhani" <himanshu.madh...@cavium.com> wrote: > >>Hi Nic, >> >>Please consider this s

Re: [PATCH 16/22] qla2xxx: Improve RSCN handling in driver

Hi Hannes, On 12/7/16, 3:32 AM, "Hannes Reinecke" wrote: >This is a bit odd. >If you already have code for fixing the to-do, why is the to-do there? >And if the code doesn't work, what's the point of including it here? > >I would suggest removing the code; the comment should

Re: [PATCH v4 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/9/16, 5:10 AM, "Christoph Hellwig" wrote: >Ok. We'll still need to use PCI_IRQ_AFFINITY here after it's removed >i nthe previous patch, but with pci_irq_alloc_vectors_affinity so that >we can get the separate non-assignment vector right as in the previous >discussion.

Re: [PATCH] scsi/qla2xxx: label endian-ness for many fields

On 12/9/16, 12:45 PM, "Michael S. Tsirkin" wrote: >This adds endian-ness labels for lots of qla structs. >Doing this cuts down number of sparse warnings from ~1700 to ~1400. >Will help find and resolve some of real issues down the road. > >Signed-off-by: Michael S. Tsirkin

Re: [PATCH v4 4/6] qla2xxx: Add multiple queue pair functionality.

Hi Martin, On 12/9/16, 11:39 AM, "Madhani, Himanshu" <himanshu.madh...@cavium.com> wrote: > >On 12/9/16, 5:10 AM, "Christoph Hellwig" <h...@infradead.org> wrote: > >>Ok. We'll still need to use PCI_IRQ_AFFINITY

Re: [PATCH 08/11] qla2xxx: Add framework for Async fabric discovery.

On 1/11/17, 12:08 PM, "Bart Van Assche" wrote: >On 12/23/2016 08:23 PM, Himanshu Madhani wrote: >> +sess->logout_completed = 0; >> +be_sid[0] = sess->d_id.b.domain; >> +be_sid[1] = sess->d_id.b.area; >> +be_sid[2] = sess->d_id.b.al_pa; > >Hello

Re: [PATCH 09/11] qla2xxx: Add Dual mode support in the driver

On 1/11/17, 11:51 AM, "Bart Van Assche" wrote: >On 12/23/2016 08:23 PM, Himanshu Madhani wrote: >> -#define QLA_TGT_MODE_ENABLED() (ql2x_ini_mode != QLA2XXX_INI_MODE_ENABLED) >> +#define QLA_TGT_MODE_ENABLED() \ >> +((ql2x_ini_mode != QLA2XXX_INI_MODE_ENABLED)

Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer

On 12/29/16, 2:20 PM, "Colin King" wrote: >From: Colin Ian King > >Rename the vendor_indentifer and hba_indentifer fields to correct spelling. > >Signed-off-by: Colin Ian King >--- > drivers/scsi/qla2xxx/qla_def.h |

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

On 1/11/17, 12:47 PM, "Bart Van Assche" wrote: >On Fri, 2016-12-23 at 20:23 -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> This patch does not change any functionality. > >Please also mention in the patch description what the

Re: [PATCH 04/11] qla2xxx: Cleanup SRR code.

Hi Christoph, On 1/9/17, 5:13 AM, "Christoph Hellwig" wrote: >s/Cleanup/Remove/ ? > >Maybe add a little blurb on why we even had this huge pile of dead code >despite not using selective retransmissions, and why you don't plan to >use it any time soon. > >Otherwise looks

Re: [PATCH 02/11] qla2xxx: Cleanup TMF code translation from qla_target.

On 1/11/17, 12:05 PM, "Bart Van Assche" wrote: >On 12/23/2016 08:23 PM, Himanshu Madhani wrote: >> static int tcm_qla2xxx_handle_tmr(struct qla_tgt_mgmt_cmd *mcmd, uint32_t >> lun, >> -uint8_t tmr_func, uint32_t tag) >> +uint16_t tmr_func, uint32_t tag) >>

Re: [PATCH 2/2] qla2xxx: remove irq_affinity_notifier

On 1/11/17, 8:55 AM, "Christoph Hellwig" wrote: >Now that qla2xxx uses the IRQ layer affinity assignment affinity >won't change over the life time of a device and the notifiers are >useless. > >Signed-off-by: Christoph Hellwig >--- > drivers/scsi/qla2xxx/qla_def.h |

Re: [PATCH 02/11] qla2xxx: Cleanup TMF code translation from qla_target.

On 1/11/17, 1:08 PM, "Bart Van Assche" wrote: >On 12/23/2016 08:23 PM, Himanshu Madhani wrote: >> From: Quinn Tran >> >> Move code code which converts Task Mgmt Command flags for >> ATIO to TCM #defines, from qla2xxx driver to tcm_qla2xxx >>

Re: [PATCH 1/2] qla2xxx: fix MSI-X vector affinity

On 1/11/17, 8:55 AM, "Christoph Hellwig" wrote: >The first two or three vectors in qla2xxx adapter are global and >not associated with a specific queue. They should not have IRQ >affinity assigned. > >Signed-off-by: Christoph Hellwig >--- >

Re: [PATCH v2 2/5] qla2xxx: Fix mailbox command timeout due to starvation

On 11/30/16, 11:58 PM, "Hannes Reinecke" wrote: >On 11/30/2016 09:24 PM, Himanshu Madhani wrote: >> From: Samy >> >> Signed-off-by: Samy >> Signed-off-by: Himanshu Madhani >> --- >>

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/4/16, 11:38 PM, "Hannes Reinecke" wrote: >On 12/02/2016 10:44 PM, Himanshu Madhani wrote: >> From: Michael Hernandez >> >> Replaced existing multiple queue functionality with framework >> that allows for the creation of pairs of request and

Re: [PATCH v3 6/6] qla2xxx: Fix Target mode handling with Multiqueue changes.

On 12/4/16, 11:42 PM, "Hannes Reinecke" wrote: >On 12/02/2016 10:44 PM, Himanshu Madhani wrote: >> From: Quinn Tran >> >> - Fix race condition between dpc_thread accessing Multiqueue resources >> and qla2x00_remove_one thread trying to free resource. >>

Re: [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls.

On 12/5/16, 4:55 AM, "Christoph Hellwig" wrote: >>+ void *handle; > >Just curious: why do you need this new handle field instead of just >passing the rsp as the old code did? We wanted to make it more generic pointer with new Q-pair frameworks. So just renamed it.

Re: [PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET.

On 12/5/16, 8:01 AM, "Christoph Hellwig" wrote: >Can you describe the changes in the body a bit more? Why do you >only want these commands to be sent? Why is the warning added >when it takes longer than nessecary? Otherwise this patch >looks fine to me. This patch is

Re: [PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation

On 12/5/16, 8:03 AM, "Christoph Hellwig" wrote: >On Fri, Dec 02, 2016 at 01:44:53PM -0800, Himanshu Madhani wrote: >> From: Samy >> >> This patch helps resolve some of the mailbox timeout issue discovered >> during large SAN emulation testing where

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/5/16, 8:20 AM, "Christoph Hellwig" wrote: >> create mode 100644 drivers/scsi/qla2xxx/qla_bottom.c >> create mode 100644 drivers/scsi/qla2xxx/qla_mq.c >> create mode 100644 drivers/scsi/qla2xxx/qla_top.c > >What's the point of three new fairly small files, two of

Re: [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality.

On 12/5/16, 12:43 PM, "linux-scsi-ow...@vger.kernel.org on behalf of Madhani, Himanshu" <linux-scsi-ow...@vger.kernel.org on behalf of himanshu.madh...@cavium.com> wrote: > >We need to have the spinlock because currently our NPIV implementation does >not utilizes

Re: [PATCH v2 3/5] qla2xxx: Add multiple queue pair functionality.

Hi Hannes, On 12/1/16, 12:39 AM, "Hannes Reinecke" wrote: >On 11/30/2016 09:24 PM, Himanshu Madhani wrote: >> From: Michael Hernandez >> >> Replaced existing multiple queue functionality with framework >> that allows for the creation of pairs of

Re: [PATCH v2 4/5] qla2xxx: Add Block Multi Queue functionality.

On 12/1/16, 2:25 AM, "Christoph Hellwig" wrote: >> -pci_disable_msix(ha->pdev); >> +pci_free_irq_vectors(ha->pdev); > >Please make the switch to pci_alloc_irq_vectors / pci_free_irq_vectors >a se[arate patch. Ack. We’ll split up patch. > >> +ret =

Re: [PATCH] qla2xxx: Get mutex lock before checking optrom_state

Hi Milan, On 12/24/16, 8:32 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Milan P. Gandhi" wrote: >Hello, > >There is a race condition with qla2xxx optrom functions where >one thread might modify optrom buffer,

Re: [PATCH 03/11] qla2xxx: Make trace flags more readable.

On 1/9/17, 5:11 AM, "Christoph Hellwig" wrote: >On Fri, Dec 23, 2016 at 08:23:31PM -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> This patch does not change any functionality. > >... >> +++ b/drivers/scsi/qla2xxx/qla_target.c >> @@ -3294,7

Re: [PATCH 05/11] qla2xxx: Fix wrong argument in sp done callback.

On 1/9/17, 5:17 AM, "Christoph Hellwig" wrote: >On Fri, Dec 23, 2016 at 08:23:33PM -0800, Himanshu Madhani wrote: >> From: Quinn Tran >> >> Callback for sp->done expects scsi_qla_host is passed in as argument, >> Instead qla_hw_data is passed in. >

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >qla24xx_enable_msix() calls scnprintf() with a non-literal format >string. This makes clang report -Wformat-security warnings when >compiling this function: > >drivers/scsi/qla2xxx/qla_isr.c:3083:7: error: format

Re: [PATCH 2/2] scsi: qla2xxx: make msix_entries const

On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >msix_entries and qla82xx_msix_entries arrays are never modified in >drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data. > >Signed-off-by: Nicolas Iooss >--- >

Re: [PATCH v2 06/10] qla2xxx: Fix crash due to null pointer access.

On 12/23/16, 12:47 AM, "Bart Van Assche" wrote: >This patch needs a more detailed description. There are many changes in this >patch. What changes are the changes that prevent the NULL pointer dereference? >What changes (if any) were made as the result of code

Re: [PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0.

On 12/23/16, 12:37 AM, "Bart Van Assche" wrote: >Please use cpu_to_le32() in new code instead of __constant_cpu_to_le32(). >gcc generates the same code for both conversion functions but the former >function makes source code easier to read. Ack. Will update the

Re: [PATCH v2 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode

On 12/23/16, 12:32 AM, "Bart Van Assche" wrote: >Sparse reports this because the atio_q_in pointer is declared as uint32_t >__iomem*. >Does this perhaps mean that a readl() call is missing? Ack. Will fix in revised series.

Re: [PATCH v2 07/10] qla2xxx: Terminate exchange if corrputed.

On 12/23/16, 1:01 AM, "Bart Van Assche" wrote: >On Wed, 2016-12-21 at 13:57 -0800, Himanshu Madhani wrote: >> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h >> index f7df01b..b14455e 100644 >> --- a/drivers/scsi/qla2xxx/qla_def.h >> +++

Re: [PATCH v2 00/10] qla2xxx: Bug fixes for driver.

On 12/22/16, 1:25 AM, "Christoph Hellwig" wrote: >The whole series looks fine: > >Reviewed-by: Christoph Hellwig > >(not sure why you dropped my Reviewed-by: tags for all the previously >reviewed patches, though) Thanks for the review. Looks like oversight

Re: [PATCH v2 00/10] qla2xxx: Bug fixes for driver.

Hi Bart, On 12/22/16, 9:02 AM, "Bart Van Assche" <bart.vanass...@sandisk.com> wrote: >On Thu, 2016-12-22 at 16:44 +, Madhani, Himanshu wrote: >> Do you want me to send series updating Reviewed-by Tag or would you be able >> to update >> while apply

Re: [RFC 1/2] scsi: Provide mechanism for SCSI layer to poll for LLDD.

Hi Bart, > On Mar 16, 2017, at 3:27 PM, Bart Van Assche > wrote: > > On Thu, 2017-03-16 at 14:40 -0700, Himanshu Madhani wrote: >> +static int >> +scsi_poll(struct blk_mq_hw_ctx *hctx, unsigned int tag) >> + >> +{ >> +struct Scsi_Host *shost =

Re: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

> > Sent: Monday, March 13, 2017 12:39:03 PM > > > Subject: RE: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based > > > 8Gb) with BAR 3 error, work fine on 4.9 > > > > > > Hi Laurence, > > > > > > > -Or

Re: [RFC 1/2] scsi: Provide mechanism for SCSI layer to poll for LLDD.

> On Mar 16, 2017, at 3:27 PM, Bart Van Assche > wrote: > > On Thu, 2017-03-16 at 14:40 -0700, Himanshu Madhani wrote: >> +static int >> +scsi_poll(struct blk_mq_hw_ctx *hctx, unsigned int tag) >> + >> +{ >> +struct Scsi_Host *shost = hctx->driver_data; >> +

RE: [PATCH] qla2xxx: Fix crash in qla2xxx_eh_abort on bad ptr

> -Original Message- > From: Bill Kuzeja [mailto:william.kuz...@stratus.com] > Sent: Thursday, March 09, 2017 8:47 AM > To: linux-scsi@vger.kernel.org > Cc: qla2xxx-upstr...@qlogic.com; Bill Kuzeja > Subject: [PATCH] qla2xxx: Fix crash in qla2xxx_eh_abort on

RE: [PATCH] qla2xxx: Fix ql_dump_buffer

> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, March 2, 2017 5:15 PM > To: qla2xxx-upstr...@qlogic.com > Cc: James E.J. Bottomley ; Martin K. Petersen > ; linux-scsi@vger.kernel.org; linux- >

RE: 4.10+ qla2xxx driver wont load for qla2xxx (ISP2532-based 8Gb) with BAR 3 error, work fine on 4.9

Hi Laurence, > -Original Message- > From: Laurence Oberman [mailto:lober...@redhat.com] > Sent: Sunday, March 12, 2017 11:31 AM > To: Dupuis, Chad <chad.dup...@cavium.com>; Madhani, Himanshu > <himanshu.madh...@cavium.com> > Cc: Linux SCSI List <linux-sc

RE: [PATCH v3 00/14] qla2xxx: Bug Fixes and updates for target.

> -Original Message- > From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] > Sent: Sunday, March 5, 2017 4:43 PM > To: Madhani, Himanshu <himanshu.madh...@cavium.com>; target- > de...@vger.kernel.org; n...@linux-iscsi.org > Cc: linux-scsi@vger.kernel

Re: [PATCH v2 01/15] qla2xxx: Combine Active command arrays.

Hi Bart, > On Jul 11, 2017, at 5:39 PM, Nicholas A. Bellinger > wrote: > > On Tue, 2017-07-11 at 23:43 +, Bart Van Assche wrote: >> On Tue, 2017-06-13 at 20:47 -0700, Himanshu Madhani wrote: >>> typedef struct srb { >>> + /* >>> +* Do not move cmd_type field, it

Re: [PATCH 3/7] qla2xxx: Add command completion wq for error path

Hi Bart, > On Jul 19, 2017, at 1:46 PM, Bart Van Assche wrote: > > On Wed, 2017-07-19 at 11:51 -0700, Himanshu Madhani wrote: >> From: Duane Grigsby > > Hello Himanshu and Duane, > > Too many drivers create workqueues for all kinds of

Re: [PATCH 4/7] qla2xxx: Added change to enable ZIO for FC-NVMe devices

> On Jul 20, 2017, at 12:00 AM, Johannes Thumshirn wrote: > > On Wed, Jul 19, 2017 at 11:51:48AM -0700, Himanshu Madhani wrote: >> +mcp->out_mb = MBX_2|MBX_1|MBX_0; >> +mcp->in_mb = MBX_2|MBX_0; > > Please add spaces around the '|'. Checkpatch should've warned you

Re: [PATCH v2 0/6] qla2xxx: Bug fixes for driver

Hi Martin, > On Jul 27, 2017, at 5:49 AM, Martin K. Petersen > wrote: > > > Himanshu, > >> I am okay with 4.14 for the whole series > > Applied patches 1-5 to 4.14/scsi-queue. Please address Bart's and > Johannes' nitpicks on patch 6. > > Thank you! > > -- >

Re: [PATCH v2 0/6] qla2xxx: Bug fixes for driver

Hi Martin, > On Jul 26, 2017, at 6:58 PM, Martin K. Petersen > wrote: > > > Himanshu, > >> This series addresses review comments for previously submitted series for >> target multiqueue and FC-NVMe support in 4.13.0-rc1 >> >> Patches 1,2 addresses review

Re: [PATCH 1/7] qla2xxx: Cleanup NVMe code.

Hi Bart, > On Jul 19, 2017, at 1:44 PM, Bart Van Assche wrote: > > On Wed, 2017-07-19 at 11:51 -0700, Himanshu Madhani wrote: >> This patch cleaned up code to make it more readable > > Hello Himanshu, > > "cleaned up code" is a very vague description. Please be more

Re: [PATCH 5/7] qla2xxx: Simpify unregistration of FC-NVMe local/remote ports

Hi Johannes, > On Jul 20, 2017, at 12:03 AM, Johannes Thumshirn wrote: > > On Wed, Jul 19, 2017 at 11:51:49AM -0700, Himanshu Madhani wrote: >> -static void qla_nvme_abort_all(fc_port_t *fcport) >> -{ >> -int que, cnt; >> -unsigned long flags; >> -srb_t *sp; >>

Re: [PATCH v2 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

Hi James, > On Jun 28, 2017, at 2:15 PM, James Bottomley > <james.bottom...@hansenpartnership.com> wrote: > > On Wed, 2017-06-21 at 13:48 -0700, Madhani, Himanshu wrote: >> From: Duane Grigsby <duane.grig...@cavium.com> >> >> Added logic to chan

Re: [PATCH] qla2xxx: Fix compile warning

> On Jun 28, 2017, at 3:12 PM, James Bottomley > wrote: > > On Wed, 2017-06-28 at 15:00 -0700, Himanshu Madhani wrote: >> Fixes following warning >> >> drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq': >>

Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap

> On Jun 30, 2017, at 9:41 AM, James Bottomley wrote: > > On Fri, 2017-06-30 at 18:10 +0200, Arnd Bergmann wrote: >> cont_pkt->entry_type is an 8-bit field, so doing a 32-bit byteswap >> on it will store incorrect data: >> >> drivers/scsi/qla2xxx/qla_nvme.c: In

Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning

> On Jun 30, 2017, at 9:10 AM, Arnd Bergmann wrote: > > When NVMe support is disabled, we get a couple of harmless warnings: > > drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: > 'qla_nvme_unregister_remote_port' defined but not used > [-Werror=unused-function] >

Re: [PATCH][scsi-next] scsi: qla2xxx: fix a bunch of typos and spelling mistakes

> On Jun 30, 2017, at 6:47 AM, Colin King wrote: > > From: Colin Ian King > > Fix the following typos/spelling mistakes: > > "attribure" -> "attribute" > "suppored" -> "supported" > "Symobilic" -> "Symbolic" > "iteself" -> "itself" >

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

Hi Martin, On 6/27/17, 6:32 PM, "Martin K. Petersen" wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

> On Jun 23, 2017, at 12:10 AM, Johannes Thumshirn wrote: > > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to

Re: scsi: qla2xxx: use dma_mapping_error to check map errors

> On Aug 8, 2017, at 6:55 AM, Pan Bian wrote: > > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its > return value is checked against NULL, which could result in failures. > >

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

> On Jun 19, 2017, at 1:26 PM, James Smart wrote: > > On 6/16/2017 3:47 PM, Himanshu Madhani wrote: >>/* FCP-4 types */ >> #define FC4_TYPE_FCP_SCSI 0x08 >> +#define FC4_TYPE_NVME 0x28 >> #define FC4_TYPE_OTHER 0x0 >> #define

Re: [PATCH 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

> On Jun 19, 2017, at 2:22 PM, James Smart wrote: > > On 6/16/2017 3:47 PM, Himanshu Madhani wrote: >> From: Duane Grigsby >> >> This code provides the interfaces to register remote and local ports >> of FC4 type 0x28 with the FC-NVMe

Re: [PATCH 2/6] qla2xxx: Add FC-NVMe command handling

> On Jun 19, 2017, at 2:01 PM, James Smart wrote: > > On 6/16/2017 3:47 PM, Himanshu Madhani wrote: >> @@ -615,8 +620,25 @@ struct sts_entry_24xx { >> uint32_t rsp_residual_count;/* FCP RSP residual count. */ >> uint32_t sense_len; /* FCP

Re: [PATCH 2/6] qla2xxx: Add FC-NVMe command handling

> On Jun 19, 2017, at 1:20 AM, Johannes Thumshirn wrote: > > On Fri, Jun 16, 2017 at 03:47:40PM -0700, Himanshu Madhani wrote: >> From: Duane Grigsby >> >> Signed-off-by: Darren Trapp >> Signed-off-by: Duane Grigsby

Re: [PATCH 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

> On Jun 19, 2017, at 1:09 AM, Johannes Thumshirn wrote: > > On Fri, Jun 16, 2017 at 03:47:39PM -0700, Himanshu Madhani wrote: >> From: Duane Grigsby >> >> Signed-off-by: Darren Trapp >> Signed-off-by: Duane Grigsby

Re: [PATCH 4/6] qla2xxx: Send FC4 type NVMe to the management server

Hi Johannes, > On Jun 19, 2017, at 3:06 AM, Johannes Thumshirn wrote: > > On Fri, Jun 16, 2017 at 03:47:42PM -0700, Himanshu Madhani wrote: >> From: Duane Grigsby >> >> This patch adds switch command support for FC-4 type of FC-NVMe (0x28) >> for

[PATCH v2 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

From: Duane Grigsby Added logic to change the login process into an optional PRIL step for FC-NVMe ports as a separate operation, such that we can change type to 0x28 (NVMe). Currently, the driver performs the PLOGI/PRLI together as one operation, but if the discovered

[PATCH v2 2/6] qla2xxx: Add FC-NVMe command handling

From: Duane Grigsby This patch adds logic to handle the completion of FC-NVMe commands and creates a sub-command in the SRB command structure to manage NVMe commands. Signed-off-by: Darren Trapp Signed-off-by: Duane Grigsby

[PATCH v2 3/6] qla2xxx: Add FC-NVMe F/W initialization and transport registration

From: Duane Grigsby This code provides the interfaces to register remote and local ports of FC4 type 0x28 with the FC-NVMe transport and transports the requests (FC-NVMe FC link services and FC-NVMe commands IUs) to the fabric. It also provides the support for

[PATCH v2 4/6] qla2xxx: Send FC4 type NVMe to the management server

From: Duane Grigsby This patch adds switch command support for FC-4 type of FC-NVMe (0x28) for resgistering HBA port to the management server. RFT_ID command is used to register FC-4 type of 0x28 and RFF_ID is used to register FC-4 features bits for FC-NVMe port.

[PATCH v2 5/6] qla2xxx: Use FC-NMVe FC4 type for FDMI registration

From: Duane Grigsby Signed-off-by: Duane Grigsby Signed-off-by: Darren Trapp Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by:

[PATCH v2 0/6] qla2xxx: Add NVMe FC Fabric support in driver

From: Himanshu Madhani Hi Martin, This patch series adds NVMe FC fabric support for qla2xxx initiator mode driver. This series depends on the target multiqueue series that was sent out on June 13,2017. (https://www.spinics.net/lists/linux-scsi/msg109827.html)

  1   2   3   >