[PATCH V2 6/6] usb: mv_usb: remove clock name from pdata

2013-03-25 Thread Chao Xie
Using pdata to pass clock name is not correct. Directly get clock from usb drivers. Signed-off-by: Chao Xie chao@marvell.com --- include/linux/platform_data/mv_usb.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/linux/platform_data/mv_usb.h

[PATCH V2 3/6] usb: ehci: mv_ehci: remove unused clock

2013-03-25 Thread Chao Xie
The origianl understanding of clock is wrong. The EHCI controller only have one clock input. Passing clock name by pdata is wrong. The clock is defined by device iteself. Signed-off-by: Chao Xie chao@marvell.com --- drivers/usb/host/ehci-mv.c | 35 ++- 1

[PATCH V2 4/6] arm: mmp: remove clock from usb pdata for aspenite

2013-03-25 Thread Chao Xie
The clock name will directly get by driver. Removing the name from pdata. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/aspenite.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-mmp/aspenite.c b/arch/arm/mach-mmp/aspenite.c index

[PATCH V2 0/6] remove the clock name from pdata

2013-03-25 Thread Chao Xie
The clock is defined by device, so the driver knows how many clocks needed by the device. The orignal way that passing the clock name by pdata is not correct. The following patches fix it. V2-V1: typo fix rebased on latest usb-next Chao Xie (6): usb: gadget: mv_udc_core: remove unused

[PATCH V2 5/6] arm: mmp: remove clock name from usb pdata for ttc

2013-03-25 Thread Chao Xie
The clock name will directly get by driver. Removing the name from pdata. Signed-off-by: Chao Xie chao@marvell.com --- arch/arm/mach-mmp/ttc_dkb.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index

[PATCH] usb: dwc3: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-25 Thread Jingoo Han
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. drivers/usb/dwc3/core.c:682:12: warning: 'dwc3_suspend'

Re: [PATCH] usb: dwc3: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-25 Thread Felipe Balbi
Hi, On Mon, Mar 25, 2013 at 07:48:25AM +, Jingoo Han wrote: Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP

[PATCH v2 0/8] Towards configfs - usb OBEX and phonet functions conversion to the new interface

2013-03-25 Thread Andrzej Pietrasiewicz
This is a follow-up to this thread: http://www.spinics.net/lists/linux-usb/msg82418.html which is a prerequisite for applying the patches being sent here. I am creating a separate series because the above mentioned thread becomes very long. The prerequisite for providing the configfs interface

[PATCH v2 5/8] usb/gadget: phonet: move global dev variable to its user

2013-03-25 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_phonet.c | 20 +++- drivers/usb/gadget/nokia.c| 14 +- drivers/usb/gadget/u_phonet.h |6 +++--- 3 files changed, 23

[PATCH v2 6/8] usb/gadget: f_phonet: convert to new function interface with backward compatibility

2013-03-25 Thread Andrzej Pietrasiewicz
Converting f_phonet to the new function interface requires converting the f_phonet's function code and its users. This patch converts the f_phonet.c to the new function interface. The file is now compiled into a separate usb_f_phonet.ko module. The old function interface is provided by means of

[PATCH v2 8/8] usb/gadget: f_phonet: remove compatibility layer

2013-03-25 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/f_phonet.c | 63 ++-- 1 files

[PATCH v2 7/8] usb/gadget: nokia: convert to new interface of f_phonet

2013-03-25 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/nokia.c | 51 +-- 2 files changed, 35 insertions(+), 17 deletions(-) diff --git

RE: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-25 Thread Kukjin Kim
Doug Anderson wrote: The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Kukjin Kim

[PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-25 Thread Kishon Vijay Abraham I
From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip. It handles the various USB OTG events that can be generated by cable insertion/removal. Signed-off-by: Graeme Gregory g...@slimlogic.co.uk Signed-off-by: Moiz Sonasath

RE: [PATCH] usb: phy: samsung: fix sparse warning

2013-03-25 Thread Kukjin Kim
Felipe Balbi wrote: Fix the following sparse warning: drivers/usb/phy/phy-samsung-usb2.c:50:26: sparse: incorrect type in argument 1 (different address spaces) drivers/usb/phy/phy-samsung-usb2.c:50:26:expected void const volatile [noderef] asn:2*addr

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-25 Thread Laxman Dewangan
On Monday 25 March 2013 03:02 PM, Kishon Vijay Abraham I wrote: From: Graeme Gregory g...@slimlogic.co.uk This is the driver for the OTG transceiver built into the Palmas chip. It handles the various USB OTG events that can be generated by cable insertion/removal. Signed-off-by: Graeme Gregory

Re: [PATCH v2] usb: dwc3: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-25 Thread Felipe Balbi
On Mon, Mar 25, 2013 at 08:53:39AM +, Jingoo Han wrote: Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP is

Re: [PATCH] usb: phy: samsung: fix sparse warning

2013-03-25 Thread Felipe Balbi
Hi, On Mon, Mar 25, 2013 at 06:41:25PM +0900, Kukjin Kim wrote: Felipe Balbi wrote: Fix the following sparse warning: drivers/usb/phy/phy-samsung-usb2.c:50:26: sparse: incorrect type in argument 1 (different address spaces) drivers/usb/phy/phy-samsung-usb2.c:50:26:expected void

Re: [PATCH 0/6] mfd: omap-usb-host: Device tree support for 3.10

2013-03-25 Thread Roger Quadros
Hi Samuel, I've rebased this now on top of 3.9-rc4. Please pull this into your next branch when appropriate. Thanks. The following changes since commit 8bb9660418e05bb1845ac1a2428444d78e322cc7: Linux 3.9-rc4 (2013-03-23 16:52:44 -0700) are available in the git repository at:

[PATCH] USB: hub: Avoid NULL pointer dereference when hub doesn't have any ports

2013-03-25 Thread David Linares
Return an error if hub-descriptor-bNbrPorts==0. Without this additional check, we can end up doing a hub-ports = kzalloc(0, GFP_KERNEL). This hub-ports pointer will therefore be non-NULL and will be used. Example of dmesg: INIT: usb 1-1: New USB device found, idVendor=0424, idProduct=2512

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-25 Thread Fabio Estevam
Hi Alexander, On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: Peter Chen peter.c...@freescale.com writes: On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Grzeschik wrote: Nearly every SoC from Freescale has this non-core usb registers. This

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-25 Thread Alan Stern
On Sun, 24 Mar 2013, Jenya Y wrote: Alan, thank you very much for your effort! The updated second patch did resolve all the remaining errors. In case you have any questions or need assistance or anything of this sort, feel free to contact me, I'll be happy to help. Remember I mentioned

Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-25 Thread David Linares
Hi all, I am currently working on an open-source project using linux 3.5.4 on an i.MX25 board manufactured by Voipac. I have been experiencing all sorts of USB issues that I have logged here: http://pastebin.com/Ry6fdne5 As you will see, it varies from detecting a hub with 0 ports,

Re: PROBLEM: USB device registered on OHCI instead of EHCI at boot

2013-03-25 Thread Alan Stern
On Mon, 25 Mar 2013, Huang Rui wrote: Hi Alan, Thank you to take a look at this issue. Sorry to disturb you again. The PORT ENABLE(PORT_PE) bit in PORTSC register is not set when the port reset, in other words, host controller and device might not do alternating sequence of Chirp Ks and

RE: USB port power-off and system suspend

2013-03-25 Thread Alan Stern
On Sat, 23 Mar 2013, Lan, Tianyu wrote: On 2013/3/23 1:35, Alan Stern wrote: Tianyu: Did you ever test the port power-off mechanism with system suspend? Right now it doesn't seem like it would work, because it relies on runtime PM to turn off the port power, and runtime PM doesn't

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-25 Thread Alan Stern
On Mon, 25 Mar 2013, David Linares wrote: Hi all, I am currently working on an open-source project using linux 3.5.4 on an i.MX25 board manufactured by Voipac. I have been experiencing all sorts of USB issues that I have logged here: http://pastebin.com/Ry6fdne5 As you will see,

[PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
This lets us use the ehci-generic driver on platforms without special requirements for their ehci controllers. In particular, this is true for the vt8500/wm8x50 platforms, which currently have a separate driver that causes problems with multiplatform configurations. Cc: Tony Prisk

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Felipe Balbi
Hi, On Mon, Mar 25, 2013 at 04:20:42PM +, Arnd Bergmann wrote: This lets us use the ehci-generic driver on platforms without special requirements for their ehci controllers. In particular, this is true for the vt8500/wm8x50 platforms, which currently have a separate driver that causes

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-25 Thread David Linares
On 25 March 2013 14:44, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 25 Mar 2013, David Linares wrote: Hi all, I am currently working on an open-source project using linux 3.5.4 on an i.MX25 board manufactured by Voipac. I have been experiencing all sorts of USB issues that I have

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-25 Thread Greg KH
On Mon, Mar 25, 2013 at 05:29:31PM +0100, Michael Grzeschik wrote: Hi Alexander, Fabio, Greg, On Mon, Mar 25, 2013 at 10:11:15AM -0300, Fabio Estevam wrote: Hi Alexander, On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: Peter Chen

Re: [PATCH] USB: hub: Avoid NULL pointer dereference when hub doesn't have any ports

2013-03-25 Thread Greg Kroah-Hartman
On Mon, Mar 25, 2013 at 10:50:27AM +, David Linares wrote: Return an error if hub-descriptor-bNbrPorts==0. Without this additional check, we can end up doing a hub-ports = kzalloc(0, GFP_KERNEL). This hub-ports pointer will therefore be non-NULL and will be used. Example of dmesg:

Re: [PATCH] USB: hub: Avoid NULL pointer dereference when hub doesn't have any ports

2013-03-25 Thread David Linares
On 25 March 2013 17:31, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Mar 25, 2013 at 10:50:27AM +, David Linares wrote: Return an error if hub-descriptor-bNbrPorts==0. Without this additional check, we can end up doing a hub-ports = kzalloc(0, GFP_KERNEL). This hub-ports

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Alan Stern
On Mon, 25 Mar 2013, Felipe Balbi wrote: @@ -62,22 +64,26 @@ static const struct ehci_driver_overrides platform_overrides __initdata = { .reset =ehci_platform_reset, }; +static struct usb_ehci_pdata ehci_platform_defaults; this ehci_platform_defaults is quite a

Re: [PATCH] usb: Add usb port system pm support

2013-03-25 Thread Sarah Sharp
You forgot to Cc the linux-usb mailing list. On Mon, Mar 25, 2013 at 04:21:42PM +0800, Lan Tianyu wrote: This patch is to add usb port system pm support. Add usb port's system suspend/resume callbacks and call usb_port_runtime_resume/suspend() to power off these ports whose pm qos

Re: Linux USB file storage gadget with new UDC

2013-03-25 Thread Alan Stern
On Tue, 26 Mar 2013, victor yeo wrote: I thought Halt feature is optional. I will add code to instruct hardware to set the halt feature. I suppose the driver needs to handle usb_ep_clear_halt() too. Thanks. g_file_storage gadget: SCSI command: READ(10); Dc=10, Di=4096; Hc=10, Hi=4096

Re: Help with USB issues at boot-up on i.MX25 (linux 3.5.4)

2013-03-25 Thread Alan Stern
On Mon, 25 Mar 2013, David Linares wrote: Start with usbmon (see Documentation/usb/usbmon.txt). Thanks Alan. I have just compiled my kernel with debugfs and usbmon. I can now easily capture raw text traces after boot-up. But I am interested in capturing these traces at boot time because

Re: xhci page fault panic on Ubuntu kernel with HP desktop hardware

2013-03-25 Thread Sarah Sharp
On Mon, Mar 25, 2013 at 05:43:40PM +0100, Yann Sionneau wrote: Hello Sarah, Hi Yann! I am a friend of Florian Fainelli, we met at 2010 RMLL at Bordeaux (France) :) I hope you are doing well and are still enjoying working on the Linux kernel USB 3.0 stack at Intel! Yep, I'm still plugging

Re: [PATCH] staging: dwc2: always release host channel after dequeueing

2013-03-25 Thread Greg KH
On Sat, Mar 23, 2013 at 08:35:40PM +0200, Felipe Balbi wrote: On Fri, Mar 22, 2013 at 05:47:53PM -0700, Paul Zimmerman wrote: Previously, when an active urb was dequeued, its host channel would not always be released. There is some special handling for this in dwc2_hc_chhltd_intr_dma, but

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Tony Prisk
On Mon, 2013-03-25 at 16:20 +, Arnd Bergmann wrote: This lets us use the ehci-generic driver on platforms without special requirements for their ehci controllers. In particular, this is true for the vt8500/wm8x50 platforms, which currently have a separate driver that causes problems with

[PATCH] staging: dwc2: always release host channel after dequeueing

2013-03-25 Thread Paul Zimmerman
From: Matthijs Kooijman matth...@stdin.nl Previously, when an active urb was dequeued, its host channel would not always be released. There is some special handling for this in dwc2_hc_chhltd_intr_dma, but when it was the last urb/qtd in its qh, a safeguard in dwc2_hc_n_intr would short-circuit

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
On Monday 25 March 2013, Tony Prisk wrote: I'll take a look at this and get back to you before Easter. Great, thanks a lot! Arnd -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Felipe Balbi
On Mon, Mar 25, 2013 at 01:47:19PM -0400, Alan Stern wrote: On Mon, 25 Mar 2013, Felipe Balbi wrote: @@ -62,22 +64,26 @@ static const struct ehci_driver_overrides platform_overrides __initdata = { .reset =ehci_platform_reset, }; +static struct usb_ehci_pdata

RE: [PATCH] staging: dwc2: always release host channel after dequeueing

2013-03-25 Thread Paul Zimmerman
From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Monday, March 25, 2013 11:14 AM On Sat, Mar 23, 2013 at 08:35:40PM +0200, Felipe Balbi wrote: On Fri, Mar 22, 2013 at 05:47:53PM -0700, Paul Zimmerman wrote: Previously, when an active urb was dequeued, its host channel would not

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
On Monday 25 March 2013, Alan Stern wrote: On Mon, 25 Mar 2013, Felipe Balbi wrote: this ehci_platform_defaults is quite a hack. Would be much better to see a proper re-factoring of the code so that it actually learns about DT and platform_data. So, if dev-dev.platform_data is NULL,

Re: [PATCH v3 00/94] USB: serial: disconnect-related patches for 3.10

2013-03-25 Thread Greg Kroah-Hartman
On Thu, Mar 21, 2013 at 12:36:17PM +0100, Johan Hovold wrote: This is v3 of the USB-disconnect series rebased on Linus tree of last week (c41b3810c09) and the recently submitted fixes-series: USB: fixes for 3.9-final I retained Alan's ACK on the urb-poison patch. This series

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Alan Stern
On Mon, 25 Mar 2013, Arnd Bergmann wrote: This lets us use the ehci-generic driver on platforms without special requirements for their ehci controllers. In particular, this is true for the vt8500/wm8x50 platforms, which currently have a separate driver that causes problems with multiplatform

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-25 Thread Sarah Sharp
Alan, Is there a way to disable runtime PM for a PCI host controller, but still allow the system to suspend/hibernate? Sarah Sharp On Fri, Mar 22, 2013 at 06:33:26PM +, Cortes, Alexis wrote: Hi Tony, Well, considering the circumstances, the only issue I see here is that the system

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-25 Thread Rafael J. Wysocki
On Monday, March 25, 2013 02:35:37 PM Sarah Sharp wrote: Alan, Is there a way to disable runtime PM for a PCI host controller, but still allow the system to suspend/hibernate? It should be. Just write on to the controller's power/control file in sysfs. Thanks, Rafael On Fri, Mar 22,

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
On Monday 25 March 2013, Alan Stern wrote: + if (!dev-dev.platform_data) { + dev-dev.platform_data = ehci_platform_defaults; + dev-dev.dma_mask = dev-dev.coherent_dma_mask; + dev-dev.coherent_dma_mask = DMA_BIT_MASK(32); In view of Felipe's

Re: [PATCH v4] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-03-25 Thread Sarah Sharp
On Mon, Mar 25, 2013 at 11:14:15PM +0100, Rafael J. Wysocki wrote: On Monday, March 25, 2013 02:35:37 PM Sarah Sharp wrote: Alan, Is there a way to disable runtime PM for a PCI host controller, but still allow the system to suspend/hibernate? It should be. Just write on to the

[PATCH v2 1/2] staging: dwc2: remove unneeded arguments from two functions

2013-03-25 Thread Paul Zimmerman
Remove the unneeded struct device *dev argument from dwc2_hcd_init() and dwc2_hcd_remove(), and pass in the value through the hsotg-dev member instead Signed-off-by: Paul Zimmerman pa...@synopsys.com --- drivers/staging/dwc2/hcd.c | 19 +-- drivers/staging/dwc2/hcd.h | 6 +++---

[PATCH v2 2/2] staging: dwc2: fix wrong setting of DMA masks

2013-03-25 Thread Paul Zimmerman
We were setting the DMA masks in dwc2_driver_probe(), but that is before the driver parameters have been set to their default values. That meant the DMA masks could be set wrong. Fix it by moving the DMA mask setting into dwc2_hcd_init(), after the driver parameters have been set. Reported-by:

[PATCH v3] usb: dwc3: add CONFIG_PM_SLEEP to suspend/resume functions

2013-03-25 Thread Jingoo Han
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. Unnecessary CONFIG_PM ifdefs are removed.

[PATCH] USB: serial: fix hang when opening port

2013-03-25 Thread Ming Lei
Johan's 'fix use-after-free in TIOCMIWAIT' patchset[1] introduces one bug which can cause kernel hang when opening port. This patch initialized the 'port-delta_msr_wait' waitqueue head to fix the bug which is introduced in 3.9-rc4. [1], http://marc.info/?l=linux-usbm=136368139627876w=2 Cc:

Re: [PATCH 01/12] usb: chipidea: udc: use {read,write}l to handle mapped data

2013-03-25 Thread Peter Chen
On Fri, Mar 22, 2013 at 02:20:23PM +0100, Michael Grzeschik wrote: The udc uses an shared dma memory space between hard and software. This memory layout is described in ci13xxx_qh and ci13xxx_td which are marked with the attribute ((packed)). The packed attribute leads the compiler to

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Tony Prisk
On Mon, 2013-03-25 at 22:23 +, Arnd Bergmann wrote: On Monday 25 March 2013, Alan Stern wrote: + if (!dev-dev.platform_data) { + dev-dev.platform_data = ehci_platform_defaults; + dev-dev.dma_mask = dev-dev.coherent_dma_mask; +

Re: PROBLEM: USB device registered on OHCI instead of EHCI at boot

2013-03-25 Thread Huang Rui
Hi Alan, On Mon, Mar 25, 2013 at 10:28:04PM +0800, Alan Stern wrote: On Mon, 25 Mar 2013, Huang Rui wrote: Hi Alan, Thank you to take a look at this issue. Sorry to disturb you again. The PORT ENABLE(PORT_PE) bit in PORTSC register is not set when the port reset, in other words,

Re: [PATCH 02/12] usb: chipidea: udc: only clear active and halted bits in qhead

2013-03-25 Thread Peter Chen
On Fri, Mar 22, 2013 at 02:20:24PM +0100, Michael Grzeschik wrote: The datasheet of the synopsys core describes only to overwrite the active and halted bits in the qhead before priming any endpoint. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de --- drivers/usb/chipidea/udc.c