Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file

On Tue, Nov 15, 2016 at 07:58:16AM +0100, Greg KH wrote: > On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > > This can fix below dump when the lock is accessed at host > > mode due to it is not initialized. > > > > [ 46.119638] INFO: trying to register non-static key. > > [

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On Mon, Nov 14, 2016 at 12:46:50PM -0800, Guenter Roeck wrote: > On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > Hi Greg, > > > > On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > > > On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote: > > > > The

Re: [GIT PULL] USB: chipidea fixes for v4.9

On Tue, Nov 15, 2016 at 07:59:51AM +0100, Greg KH wrote: > On Tue, Nov 15, 2016 at 02:05:49PM +0800, Peter Chen wrote: > > On Mon, Nov 14, 2016 at 12:48:45PM +0100, Greg KH wrote: > > > On Mon, Nov 14, 2016 at 10:01:53AM +0800, Peter Chen wrote: > > > > The following changes since commit > > > >

Re: [GIT PULL] USB: chipidea fixes for v4.9

On Tue, Nov 15, 2016 at 02:05:49PM +0800, Peter Chen wrote: > On Mon, Nov 14, 2016 at 12:48:45PM +0100, Greg KH wrote: > > On Mon, Nov 14, 2016 at 10:01:53AM +0800, Peter Chen wrote: > > > The following changes since commit > > > 18266403f3fe507f0246faa1d5432333a2f139ca: > > > > > > USB:

Re: [PATCH v2 1/1] usb: chipidea: move the lock initialization to core file

On Tue, Nov 15, 2016 at 02:02:47PM +0800, Peter Chen wrote: > This can fix below dump when the lock is accessed at host > mode due to it is not initialized. > > [ 46.119638] INFO: trying to register non-static key. > [ 46.124643] the code is fine but needs lockdep annotation. > [ 46.130144]

[PATCH v2 1/1] usb: chipidea: move the lock initialization to core file

This can fix below dump when the lock is accessed at host mode due to it is not initialized. [ 46.119638] INFO: trying to register non-static key. [ 46.124643] the code is fine but needs lockdep annotation. [ 46.130144] turning off the locking correctness validator. [ 46.135659] CPU: 0

Re: [GIT PULL] USB: chipidea fixes for v4.9

On Mon, Nov 14, 2016 at 12:48:45PM +0100, Greg KH wrote: > On Mon, Nov 14, 2016 at 10:01:53AM +0800, Peter Chen wrote: > > The following changes since commit 18266403f3fe507f0246faa1d5432333a2f139ca: > > > > USB: cdc-acm: fix TIOCMIWAIT (2016-11-10 13:12:59 +0100) > > > > are available in the

[PATCH v5 0/4] usb: early: add support for early printk through USB3 debug port

xHCI debug capability (DbC) is an optional but standalone functionality provided by an xHCI host controller. With DbC hardware initialized, the system will present a debug device through the USB3 debug port (normally the first USB3 port). The debug device is fully compliant with the USB framework

[PATCH v5 1/4] usb: dbc: early driver for xhci debug capability

xHCI debug capability (DbC) is an optional but standalone functionality provided by an xHCI host controller. Software learns this capability by walking through the extended capability list of the host. xHCI specification describes DbC in section 7.6. This patch introduces the code to probe and

[PATCH v5 2/4] x86: add support for earlyprintk via USB3 debug port

Add support for early printk by writing debug messages to the USB3 debug port. Users can use this type of early printk by specifying kernel parameter of "earlyprintk=xdbc". This gives users a chance of providing debug output. The hardware for USB3 debug port requires DMA memory blocks. This

[PATCH v5 3/4] usb: serial: usb_debug: add support for dbc debug device

This patch add dbc debug device support in usb_debug driver. Signed-off-by: Lu Baolu Acked-by: Johan Hovold --- drivers/usb/serial/usb_debug.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: > On Mon, Nov 14 2016, Mark Brown wrote: > > > On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > >> On Thu, Nov 10 2016, Baolin Wang wrote: > > > >> > Fourth, we need integrate all charger plugin/out > >> > event in one

Re: [PATCH 0/2] Two cpp41 pm runtime found when testing with usb

* Vinod Koul [161114 19:20]: > On Mon, Nov 14, 2016 at 06:49:12AM -0800, Tony Lindgren wrote: > > * Vinod Koul [161113 21:19]: > > > On Wed, Nov 09, 2016 at 09:47:57AM -0700, Tony Lindgren wrote: > > > > Hi, > > > > > > > > I found two pm runtime

Re: [PATCH 0/2] Two cpp41 pm runtime found when testing with usb

On Mon, Nov 14, 2016 at 06:49:12AM -0800, Tony Lindgren wrote: > * Vinod Koul [161113 21:19]: > > On Wed, Nov 09, 2016 at 09:47:57AM -0700, Tony Lindgren wrote: > > > Hi, > > > > > > I found two pm runtime issues when testing with usb on beaglebone. > > > > > > In the

[PATCH v3 16/17] usb: dwc2: gadget: Program ep0_mps for LS

From: Vardan Mikayelyan When device is enumerated in LS we should program ep0_mps accordingly. USB2 spec says that in LS mode, control ep mps must be 8. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn ---

[PATCH v3 15/17] usb: dwc2: gadget: Add IOT device IDs, configure core accordingly

From: Vardan Mikayelyan Add new device IDs for IOT gadget. Done changes in probe to configure core accordingly depending on device ID value. Signed-off-by: Vardan Mikayelyan Signed-off-by: John Youn ---

[PATCH v3 13/17] usb: dwc2: gadget: Disable enabled HW endpoint in dwc2_hsotg_ep_disable

From: Vahram Aharonyan Check if endpoint is enabled during dwc2_hsotg_ep_disable() function processing and call dwc2_hsotg_ep_stop_xfr() to disable it and flush associated FIFO. Move dwc2_hsotg_ep_stop_xfr() and dwc2_hsotg_wait_bit_set() functions upper before

[PATCH v3 17/17] usb: dwc2: gadget: Add new core parameter for low speed

From: Vardan Mikayelyan Added new core param for low speed, which can be used only when SNPSID is equal to DWC2_CORE_FS_IOT. When LS mode is enabled, we are restricting ep types and providing to upper layer only INTR and CTRL endpoints. Signed-off-by: Vardan Mikayelyan

[PATCH v3 11/17] usb: dwc2: gadget: For DDMA parse setup only after SetUp interrupt

From: Vahram Aharonyan Tests with various hosts show that depend on time difference between host sending SETUP packet and IN/OUT token SW could get Xfercomplete interrupt without SetUp interrupt. On the other hand, SW should parse received SETUP packet only after ensuring

[PATCH v3 12/17] usb: dwc2: gadget: Correct dwc2_hsotg_ep_stop_xfr() function

From: Vahram Aharonyan Correct dwc2_hsotg_ep_stop_xfr() function to follow dwc2 programming guide for setting NAK on specific endpoint, disabling it and flushing corresponding FIFO. Current code does not take into account whether core acts in shared or dedicated FIFO mode,

[PATCH v3 02/17] usb: dwc2: gadget: DDMA transfer start and complete

From: Vahram Aharonyan Update transfer starting dwc2_hsotg_start_req() routine with call of function dwc2_gadget_config_nonisoc_xfer_ddma() to fill descriptor chain. Add call of dwc2_gadget_get_xfersize_ddma() in dwc2_hsotg_handle_outdone() and dwc2_hsotg_complete_in()

[PATCH v3 05/17] usb: dwc2: gadget: Enable descriptor DMA mode

From: Vahram Aharonyan Add DCFG register field macro for descriptor DMA mode and update core initialization routine to set that bit accordingly. Signed-off-by: Vahram Aharonyan Signed-off-by: John Youn ---

[PATCH v3 04/17] usb: dwc2: gadget: Start DDMA IN status phase in StsPhseRcvd handler

From: Vahram Aharonyan In DDMA mode of operation IN status phase of control write transfer should start after getting StsPhseRcvd interrupt. This interrupt is issued by HW once host starts to send IN tokens after data stage. Signed-off-by: Vahram Aharonyan

[PATCH v3 09/17] usb: dwc2: gadget: Enable the BNA interrupt

From: Vahram Aharonyan Enable the BNA (Buffer Not Available) interrupt in descriptor DMA mode. Signed-off-by: Vahram Aharonyan Signed-off-by: John Youn --- drivers/usb/dwc2/gadget.c | 4 drivers/usb/dwc2/hw.h | 1 +

[PATCH v3 06/17] usb: dwc2: gadget: Add DDMA isoc related fields to dwc2_hsotg_ep

From: Vahram Aharonyan Preparing for isochronous transfers support adding in DDMA mode. In DDMA isochronous transfers are handled differently compared to Slave and BDMA modes. This is caused by fact that isoc requests contain data for one frame/microframe. HW descriptor

[PATCH v3 10/17] usb: dwc2: gadget: Adjust ISOC OUT request's actual len for DDMA

From: Vahram Aharonyan In DDMA mode if programmed ISOC OUT transfer length is not DWORD aligned, after closing descriptor HW leaves value of 4 - (ureq->length % 4) in the RX bytes. This is caused because DMA works using 4B chunks. Example: if length = 9 and all 9 bytes were

[PATCH v3 00/17] usb: dwc2: Gadget descriptor DMA and IOT

This series implements gadget-side descriptor DMA for the DWC_hsotg controller. It also includes support for DWC USB IOT controllers which use the descriptor DMA mode of operation exclusively. These are two new device-only USB controller IPs based on DWC_hsotg. Tested on HAPS platform with: *

[PATCH v3 08/17] usb: dwc2: gadget: Start and complete DDMA isoc transfers

From: Vahram Aharonyan For DDMA mode in case of isochronous transfers completion performed differently than other transfer types. This is because each usb request was mapped to one descriptor in the chain and SW gets xfercomplete interrupt on all descriptors. The endpoint

[PATCH v3 03/17] usb: dwc2: gadget: Fixes for StsPhseRcvd interrupt

From: Vahram Aharonyan The StsPhseRcvd interrupt should not be enabled in slave mode. Also move the StsPhsRcvd interrupt checking in the endpoint interrupt handler to the correct order according to the databook. The interrupt itself will be implemented in a later commit.

[PATCH v3 07/17] usb: dwc2: gadget: In DDMA keep incompISOOUT and incompISOIN masked

From: Vahram Aharonyan In DDMA mode incompISOOUT should be masked, similar as Bulk Out - XferCompl and BNA should be handled. incompISOIN is not valid in DDMA and is not getting asserted. Signed-off-by: Vahram Aharonyan Signed-off-by: John Youn

[PATCH v3 01/17] usb: dwc2: gadget: EP 0 specific DDMA programming

From: Vahram Aharonyan Add dwc2_gadget_set_ep0_desc_chain() function to switch between EP0 DDMA chains depend on the stage of control transfer. Include EP0 DDMA chain selection during ep_queue called from dwc2_hsotg_enqueue_setup() for setup stage. Selecting and filling

[PATCH 3/3] usb: dwc2: Remove reading in of invalid property

This property was mistakenly added, then removed, so don't read it in. Signed-off-by: John Youn --- drivers/usb/dwc2/params.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index

[PATCH 0/3] usb: dwc2: params revert and rework

Hi Felipe, This reverts and fixes a few commits that are queued on your testing/next, removing the previously added DT bindings, and the code that reads them in. The feedback was that IP validation is not reason enough to add these. So we'll leave them out for now. Regards, John John Youn

[PATCH 2/3] Revert "Documentation: devicetree: dwc2: Add host DMA binding"

This reverts commit 751089ecaab0 ("Documentation: devicetree: dwc2: Add host DMA binding"). Remove this binding as it is not needed by any hardware. Signed-off-by: John Youn --- Documentation/devicetree/bindings/usb/dwc2.txt | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 1/3] Revert "usb: dwc2: Add bindings to disable gadget DMA modes"

This reverts commit 9acc1ee2b723 ("usb: dwc2: Add bindings to disable gadget DMA modes"). Don't add bindings and don't read them in. These are not yet needed by any hardware. Signed-off-by: John Youn --- Documentation/devicetree/bindings/usb/dwc2.txt | 2 --

Re: [PATCH v2 05/30] usb: dwc2: Add bindings to disable gadget DMA modes

On 11/14/2016 5:11 PM, Rob Herring wrote: > On Wed, Nov 09, 2016 at 07:27:50PM -0800, John Youn wrote: >> Now that the gadget driver automatically detects DMA modes, we need to >> provide a way to disable them. Certain platforms may still have issues >> with DMA and require it to be disabled. It

Re: [PATCH v2 05/30] usb: dwc2: Add bindings to disable gadget DMA modes

On Wed, Nov 09, 2016 at 07:27:50PM -0800, John Youn wrote: > Now that the gadget driver automatically detects DMA modes, we need to > provide a way to disable them. Certain platforms may still have issues > with DMA and require it to be disabled. It is also needed for IP > validation purposes. I

Re: [PATCH net 2/2] r8152: rx descriptor check

Hayes Wang : > Francois Romieu [mailto:rom...@fr.zoreil.com] > > Sent: Friday, November 11, 2016 8:13 PM > [...] > > Invalid packet size corrupted receive descriptors in Realtek's device > > reminds of CVE-2009-4537. > > Do you mean that the driver would get a packet

Re: crash by cdc_acm driver in kernels 4.8-rc1/5

On Tue, Oct 18, 2016 at 02:18:43PM +0200, Oliver Neukum wrote: > It definitely does not crash and is probed and your .config is not > extremely unusual. Hmmm. > ... Something odd is going on. Whell, yes. The only thing that appears you'll have to do is unset 'CONFIG_SMP'. My machines didn't

Re: [PATCH v2 01/30] usb: dwc2: Deprecate g-use-dma binding

On Wed, Nov 09, 2016 at 07:27:40PM -0800, John Youn wrote: > This is not needed as the gadget now fully supports DMA and it can > autodetect it. This was initially added because gadget DMA mode was only > partially implemented so could not be automatically enabled. > > Signed-off-by: John Youn

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

On 11/11/2016 3:12 PM, Christian Lamparter wrote: > On Friday, November 11, 2016 2:20:42 PM CET John Youn wrote: >> On 11/11/2016 2:05 PM, Christian Lamparter wrote: >>> On Friday, November 11, 2016 1:22:16 PM CET John Youn wrote: On 11/11/2016 12:59 PM, Christian Lamparter wrote: > This

Re: [PATCH 2/2] usb: dwc2: fixes host_dma logic

On 11/11/2016 12:59 PM, Christian Lamparter wrote: > This patch moves the the host_dma initialization > before dwc2_set_param_dma_desc_enable and > dwc2_set_param_dma_desc_fs_enable. The reason being > that both function need it. > > Fixes: 1205489cee75bf39 ("usb: dwc2: Get host DMA device

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Mon, Nov 14 2016, Mark Brown wrote: > On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: >> On Thu, Nov 10 2016, Baolin Wang wrote: > >> > Fourth, we need integrate all charger plugin/out >> > event in one framework, not from extcon, maybe type-c in future. > >> Why not extcon? Given

Re: [PATCH 6/6] usb: musb: Drop pointless PM runtime code for dsps glue

* Johan Hovold [161114 07:59]: > On Fri, Nov 11, 2016 at 10:43:02AM -0800, Tony Lindgren wrote: > > This already gets done automatically by PM runtime and we have > > a separate autosuspend timeout in musb_core.c. > > > > Signed-off-by: Tony Lindgren > > >

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > > On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote: > > > The purpose of USB Type-C connector class is to provide > > > unified interface for

[PATCH v4 3/3] usb: dwc3: Workaround for irq mask issue

This is a workaround for STAR 9000961433 which affects only version 3.00a of the DWC_usb3 core. This prevents the controller interrupt from being masked while handling events. Enabling interrupt moderation allows us to work around this issue because once the GEVNTCOUNT.count is written the IRQ is

[PATCH v4 1/3] usb: dwc3: gadget: Write GEVNTCOUNT in interrupt

Currently GEVNTCOUNT is written in the threaded interrupt handler while processing each event. This commit moves the GEVNTCOUNT write to the hard IRQ. We then copy the events to a separate buffer for the event handler to read from. This change is in preparation of working around an issue in core

[PATCH v4 2/3] usb: dwc3: Implement interrupt moderation

Implement interrupt moderation which allows the interrupt rate to be throttled. To enable this feature the dwc->imod_interval must be set to 1 or greater. This value specifies the minimum inter-interrupt interval, in 250 ns increments. A value of 0 disables interrupt moderation. This applies for

[PATCH v4 0/3] usb: dwc3: Interrupt moderation

This patch series implements interrupt moderation and also uses it in implementing a workaround for STAR 9000961433. v4: * Rebased on testing/next * Always copy the entire cache and retain the accounting code in the event handler v3: * Cache the events between irq and bh v2: * Remove the

Re: [upstream-release] [PATCH 1/2] drivers: usb: phy: Add qoriq usb 3.0 phy driver support

On 11/13/2016 11:27 PM, Sriram Dash wrote: > diff --git a/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt > b/Documentation/devicetree/bindings/phy/phy-qoriq-usb3.txt > new file mode 100644 > index 000..d934c80 > --- /dev/null > +++

Re: [PATCH v5 3/4] usb: musb: Add a new argument to musb_platform_set_mode()

On 11/14/2016 06:36 PM, Bin Liu wrote: > Hi, > > On Mon, Nov 07, 2016 at 02:05:07PM +0100, Alexandre Bailon wrote: >> During the init, the driver will use musb_platform_set_mode() >> to configure the controller mode and the PHY mode. >> The PHY of DA8xx has some issues when the PHY is forced in

Re: [PATCH v5 3/4] usb: musb: Add a new argument to musb_platform_set_mode()

Hi, On Mon, Nov 07, 2016 at 02:05:07PM +0100, Alexandre Bailon wrote: > During the init, the driver will use musb_platform_set_mode() > to configure the controller mode and the PHY mode. > The PHY of DA8xx has some issues when the PHY is forced in host or device, > so we want to keep it in OTG

Re: [PATCH net 2/2] r8152: rx descriptor check

From: Hayes Wang Date: Mon, 14 Nov 2016 07:23:51 + > Mark Lord [mailto:ml...@pobox.com] >> Sent: Monday, November 14, 2016 4:34 AM > [...] >> Perhaps the driver >> is somehow accessing the buffer space again after doing usb_submit_urb()? >> That would certainly produce

Re: [PATCH 01/30] usb: dwc2: Deprecate g-use-dma binding

On Tue, Nov 08, 2016 at 09:48:03AM -0800, John Youn wrote: > On 11/8/2016 1:12 AM, Felipe Balbi wrote: > > > > Hi, > > > > John Youn writes: > >> Add a vendor prefix and make the name more consistent by renaming it to > >> "snps,gadget-dma-enable". > >> > >>

Re: [PATCH] usb: dwc2: add amcc,dwc-otg device tree definition

On Sun, Nov 06, 2016 at 01:56:08AM +0100, Christian Lamparter wrote: > This patch adds support for the "amcc,usb-otg" device > which is found in the PowerPC Canyonlands' dts. > > The device definition was added by: > commit c89b3458d8cc ("powerpc/44x: Add USB DWC DTS entry to Canyonlands >

Re: [PATCH 6/6] usb: musb: Drop pointless PM runtime code for dsps glue

On Fri, Nov 11, 2016 at 10:43:02AM -0800, Tony Lindgren wrote: > This already gets done automatically by PM runtime and we have > a separate autosuspend timeout in musb_core.c. > > Signed-off-by: Tony Lindgren > @@ -816,8 +801,6 @@ static int dsps_remove(struct platform_device

Re: [PATCH 5/6] usb: musb: Add missing pm_runtime_disable and drop 2430 PM timeout

On Fri, Nov 11, 2016 at 10:43:01AM -0800, Tony Lindgren wrote: > We are missing pm_runtime_disable() in 2430 glue layer. Further, > we only need to enable PM runtime and disable it on exit. With > musb_core.c doing PM, the glue layer as a parent will always be > active when musb_core.c is active.

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On Mon, Nov 14, 2016 at 04:39:10PM +0200, Heikki Krogerus wrote: > On Mon, Nov 14, 2016 at 03:11:23PM +0100, Greg KH wrote: > > On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > > > > +static void __exit typec_exit(void) > > > > > +{ > > > > > + class_unregister(_class); > >

Re: [PATCH] dma: cpp41: Fix handling of error path

* Johan Hovold [161114 06:59]: > On Mon, Nov 14, 2016 at 06:47:31AM -0800, Tony Lindgren wrote: > > Hi, > > > > * Johan Hovold [161114 06:35]: > > > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > > > If we return early on pm_runtime_get()

Re: [PATCH] dma: cpp41: Fix handling of error path

On Mon, Nov 14, 2016 at 06:47:31AM -0800, Tony Lindgren wrote: > Hi, > > * Johan Hovold [161114 06:35]: > > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > > If we return early on pm_runtime_get() error, we need to also call > > > pm_runtime_put_noidle() as

[PATCH v5 4/5] USB: ohci: da8xx: Add devicetree bindings

This patch documents the device tree bindings required for the ohci controller found in TI da8xx family of SoC's Cc: robh...@kernel.org Cc: mark.rutl...@arm.com Cc: devicet...@vger.kernel.org Signed-off-by: Axel Haslam --- .../devicetree/bindings/usb/ohci-da8xx.txt

Re: [PATCH 0/2] Two cpp41 pm runtime found when testing with usb

* Vinod Koul [161113 21:19]: > On Wed, Nov 09, 2016 at 09:47:57AM -0700, Tony Lindgren wrote: > > Hi, > > > > I found two pm runtime issues when testing with usb on beaglebone. > > > > In the am335x case cppi41 and two instances of musb controller share > > the same

Re: [PATCH] dma: cpp41: Fix handling of error path

Hi, * Johan Hovold [161114 06:35]: > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > If we return early on pm_runtime_get() error, we need to also call > > pm_runtime_put_noidle() as pointed out in a musb related thread > > by Johan Hovold .

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On Mon, Nov 14, 2016 at 03:11:23PM +0100, Greg KH wrote: > On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > > > +static void __exit typec_exit(void) > > > > +{ > > > > + class_unregister(_class); > > > > > > You forgot to clean up your idr :( > > > > Sorry, what idr?

Re: [PATCH] dma: cpp41: Fix handling of error path

On Mon, Nov 14, 2016 at 03:34:54PM +0100, Johan Hovold wrote: > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > If we return early on pm_runtime_get() error, we need to also call > > pm_runtime_put_noidle() as pointed out in a musb related thread > > by Johan Hovold

[PATCH v5 1/5] USB: ohci: da8xx: use ohci priv data instead of globals

Instead of global variables, use the extra_priv_size of the ohci driver. We cannot yet move the ocic mask because this is used on the interrupt handler which is registerded through platform data and does not have an hcd pointer. This will be moved on a later patch. Signed-off-by: Axel Haslam

[PATCH v5 2/5] USB: ohci: da8xx: Add wrappers for platform callbacks

In preparation to use a regulator instead of platform callbacks, move the platform callbacks into separate functions. This provides a well defined place to for the regulator API to coexist with the callbacks until all users are converted, and the callbacks can be removed. Signed-off-by: Axel

[PATCH v5 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS

Using a regulator to handle VBUS will eliminate the need for platform data and callbacks, and make the driver more generic allowing different types of regulators to handle VBUS. The regulator equivalents to the platform callbacks are: set_power -> regulator_enable/regulator_disable

[PATCH v5 5/5] USB: ohci: da8xx: Allow probing from DT

This adds the compatible string to the ohci driver to be able to probe from DT Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index

[PATCH v5 0/5] USB: ohci-da8xx: Add device tree support

When booting using device tree, we can not make use of platform callbacks to handle vbus and over current gpios. This series allows the ohci-da8xx driver to use a regulator instead of the platform callbacks to control vbus and adds the device tree bindings to be able to probe using DT. Once all

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On 11/14/2016 04:32 AM, Heikki Krogerus wrote: Hi Greg, On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote: The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and

Re: [PATCH] dma: cpp41: Fix handling of error path

On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > If we return early on pm_runtime_get() error, we need to also call > pm_runtime_put_noidle() as pointed out in a musb related thread > by Johan Hovold . This is to keep the PM runtime > use counts happy. > > Fixes:

Re: [PATCH 1/1] usb: chipidea: move the lock initialization to core file

On Mon, Oct 31, 2016 at 09:55:40AM +0800, Peter Chen wrote: > This can fix below dump when the lock is accessed at host > mode due to it is not initialized. > > root@imx6qdlsolo:~# cat /sys/kernel/debug/ci_hdrc.1/port_test > [ 929.904518] INFO: trying to register non-static key. > [ 929.909536]

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On Mon, Nov 14, 2016 at 02:32:35PM +0200, Heikki Krogerus wrote: > > > +static void __exit typec_exit(void) > > > +{ > > > + class_unregister(_class); > > > > You forgot to clean up your idr :( > > Sorry, what idr? The port ids get removed in typec_release(). You have a static idr structure in

Issue with Telit LE922 and cdc_mbim

Hi, I'm struggling with Telit LE922 modem that presents an MBIM device. The modem works fine in Windows, while in Linux (tested with 4.9 rc1) data connection is not functional: using ifconfig I can see wwp0s20u8i2 Link encap:Ethernet HWaddr e6:c0:3b:97:80:de inet addr:176.246.94.9

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On 14 November 2016 at 12:21, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > >> Hi >> >> On 8 November 2016 at 04:36, NeilBrown wrote: >>> On Mon, Nov 07 2016, Baolin Wang wrote: >>> On 3 November 2016 at 09:25, NeilBrown wrote:

Re: [PATHCv10 1/2] usb: USB Type-C connector class

Hi Greg, On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > > Fourth, we need integrate all charger plugin/out > > event in one framework, not from extcon, maybe type-c in future. > Why not extcon? Given that a charger is connected by an external >

Re: [GIT PULL] USB: chipidea fixes for v4.9

On Mon, Nov 14, 2016 at 10:01:53AM +0800, Peter Chen wrote: > The following changes since commit 18266403f3fe507f0246faa1d5432333a2f139ca: > > USB: cdc-acm: fix TIOCMIWAIT (2016-11-10 13:12:59 +0100) > > are available in the git repository at: > >

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

>From: Peter Chen [mailto:hzpeterc...@gmail.com] >On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote: >> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote: >> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc) void >> > > dwc3_host_exit(struct dwc3 *dwc) { >>

[PATCH] usb: dwc3: core: remove dwc3_soft_reset()

dwc3_soft_reset() is doing the same thing as dwc3_core_soft_reset(). Let's remove dwc3_soft_reset() since that's not needed anymore. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.c | 39 --- 1 file changed, 39

Re: [PATCH 00/23] xhci features for usb-next

On 14.11.2016 11:10, Greg KH wrote: On Mon, Nov 14, 2016 at 10:58:18AM +0200, Mathias Nyman wrote: On 14.11.2016 09:49, Greg KH wrote: On Fri, Nov 11, 2016 at 03:13:09PM +0200, Mathias Nyman wrote: Hi Greg In addition to all the xhci cleanups, refactoring, and features for xhci, there's a

Re: cdc_acm - fragmented notifications

On Thu, 2016-11-10 at 22:30 +0100, Tobias Herzog wrote: > Hi, > > I'm trying to build an usb device conforming to the CDC ACM device > class. The device uses an interrupt IN endpoint with a max packet size > of 8 bytes. > I tried to send a SERIAL_STATE notification to the host (to report > parity

Re: [PATCH 1/1] usb: phy: phy-generic: add the implementation of .set_suspend

On 14/11/16 10:56, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Peter Chen writes: Add clock operation at .set_suspend if the PHY has suspend requirement, it can be benefit of power saving for phy and the whole system (parent clock

Re: [PATHCv10 1/2] usb: USB Type-C connector class

On Mon, Sep 19, 2016 at 02:16:56PM +0300, Heikki Krogerus wrote: > The purpose of USB Type-C connector class is to provide > unified interface for the user space to get the status and > basic information about USB Type-C connectors on a system, > control over data role swapping, and when the port

RE: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Jon, Please help to double check if the USB host controller of your Terga platform had been powered OFF while running the ax88772_suspend() routine or not? --- Best regards, Allan Chou -Original Message- From: Jon Hunter [mailto:jonath...@nvidia.com] Sent: Monday, November 14,

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Allan, On 14/11/16 08:50, ASIX_Allan [Home] wrote: > It seems the AX88772x dongle had been unexpectedly removed while running the > ax88772_suspend() routine. If yes, you might see these error messages > because the hardware had been absent. In my case the hardware was never removed. The

Re: [PATCH] usb: core: urb make use of usb_endpoint_maxp_mult

Hi, Greg KH writes: > On Sun, Nov 13, 2016 at 01:31:16PM +0300, Mike Krinkin wrote: >> Since usb_endpoint_maxp now returns only lower 11 bits mult >> calculation here isn't correct anymore and that breaks webcam >> for me. Patch make use of usb_endpoint_maxp_mult

RE: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

Hi Jon, It seems the AX88772x dongle had been unexpectedly removed while running the ax88772_suspend() routine. If yes, you might see these error messages because the hardware had been absent. --- Best regards, Allan Chou -Original Message- From: Jon Hunter

Re: [PATCH] usb: core: urb make use of usb_endpoint_maxp_mult

On Sun, Nov 13, 2016 at 01:31:16PM +0300, Mike Krinkin wrote: > Since usb_endpoint_maxp now returns only lower 11 bits mult > calculation here isn't correct anymore and that breaks webcam > for me. Patch make use of usb_endpoint_maxp_mult instead of > direct calculation. > > Fixes: abb621844f6a

Re: [PATCH 00/23] xhci features for usb-next

On Mon, Nov 14, 2016 at 10:58:18AM +0200, Mathias Nyman wrote: > On 14.11.2016 09:49, Greg KH wrote: > > On Fri, Nov 11, 2016 at 03:13:09PM +0200, Mathias Nyman wrote: > > > Hi Greg > > > > > > In addition to all the xhci cleanups, refactoring, and features for > > > xhci, there's a patch for usb

Re: [PATCH 00/23] xhci features for usb-next

On 14.11.2016 09:49, Greg KH wrote: On Fri, Nov 11, 2016 at 03:13:09PM +0200, Mathias Nyman wrote: Hi Greg In addition to all the xhci cleanups, refactoring, and features for xhci, there's a patch for usb core hub driver that changes how usb3 devices are disabled. It fixes a automatic

Re: [PATCH 1/1] usb: phy: phy-generic: add the implementation of .set_suspend

Hi, Roger Quadros writes: >> Peter Chen writes: >>> Add clock operation at .set_suspend if the PHY has >>> suspend requirement, it can be benefit of power saving for >>> phy and the whole system (parent clock may also be disabled). >>> >>> Signed-off-by:

Re: [PATCH] usb: twl6030-usb: make driver DT only

Hi, Nicolae Rosia writes: > All users are DT-only and it makes no sense to keep > unused code > > Signed-off-by: Nicolae Rosia I need an Acked-by from either Tony, Roger or Bin > --- > drivers/usb/phy/Kconfig | 1 + >

RE: [PATCH v12 8/9] usbip: exporting devices: change to usbip_list.c

> there is no cover letter when the commits are merged, so please put it here > as well. OK. I will put in next version. Thank you for your help, nobuo.iwata // > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 10, 2016 9:11 PM > To: fx