From: Shu Wang
Found this issue by kmemleak.
xhci_run() did not check return val and free command for
xhci_queue_vendor_command()
unreferenced object 0x88011c0be500 (size 64):
comm "kworker/0:1", pid 58, jiffies 4294670908 (age 50.420s)
hex dump (first 32 bytes):
On Wed, Jul 19, 2017 at 02:17:37PM +0200, Greg Kroah-Hartman wrote:
> MODULE_VERSION is useless for in-kernel drivers, so remove the use of it
> in the chipidea CI13XXX driver.
>
> Cc: Peter Chen
> Signed-off-by: Greg Kroah-Hartman
> ---
>
On Wed, Jul 19, 2017 at 09:13:29PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Anand Moon writes:
> > Hi Krzysztof,
> >
> > Today I tried to compile the latest kernel for Odroid xu4.
> > using exynos_defconfig I build and loaded the kernel.
> > but to my surprise usb 3.0
V2 Changes:
- Add support for USB phys. We need to handle systems with either
a single phy or systems with both a USB2.0 and USB3.0 phy
- Fixes to the dt-bindings document based on feedback from
Rob Herring. Changes include changing the compatible base
name to "brcm,bdc" because
Add Device Tree binding document for Broadcom USB Device
Controller (BDC).
Signed-off-by: Al Cooper
---
Documentation/devicetree/bindings/usb/brcm,bdc.txt | 29 ++
1 file changed, 29 insertions(+)
create mode 100644
The BDC endpoint status registers 0-7 were originally each going
to be an array of regsiters. This was later changed to being a
single register. The register definitions are being changed from:
"#define BDC_EPSTS0(n) (0x60 + (n * 0x10))"
to
"#define BDC_EPSTS0 0x60"
to reflect this change and
Signed-off-by: Al Cooper
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c
b/drivers/usb/gadget/udc/bdc/bdc_core.c
index dda7b43..c2bfae2 100644
---
Newer SoC's have added a BDC clock to the Device Tree, so get
and enable it.
Signed-off-by: Al Cooper
Signed-off-by: Florian Fainelli
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
From: Florian Fainelli
Allows Device Tree probing
Signed-off-by: Florian Fainelli
Signed-off-by: Al Cooper
---
drivers/usb/gadget/udc/bdc/bdc.h | 4 ++--
drivers/usb/gadget/udc/bdc/bdc_core.c | 8
2 files changed,
This patch essentially clears the port status change bits at the
correct times. It is necessary because the driver was not handling
the change bits correctly for events during device
connection/disconnection and bus enumeration. So, one of them (PCC)
was left stuck sometimes causing the "xsf for
If a phy is specified in the device tree node, get it and use it.
This was based on a patch by:
"Srinath Mannam "
Signed-off-by: Al Cooper
---
drivers/usb/gadget/udc/bdc/bdc.h | 3 ++
drivers/usb/gadget/udc/bdc/bdc_core.c | 74
Based on a previous commit by Danesh Petigara
that added resume to solve the following problem:
"The BDC driver will fail after resuming from S3 suspend and this
will cause any upper layer gadget driver to fail."
This commit also adds support for suspend and manages the
Many ARM based Broadcom STB SoC's have a USB BDC controller so
enable this driver for these systems.
Signed-off-by: Al Cooper
---
drivers/usb/gadget/udc/bdc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc/bdc/Kconfig
Hi,
Anand Moon writes:
> Hi Krzysztof,
>
> Today I tried to compile the latest kernel for Odroid xu4.
> using exynos_defconfig I build and loaded the kernel.
> but to my surprise usb 3.0 device and missing.
>
> odroid login: root
> Password:
> Last login: Wed Jul 19
Quoting Peter Rosin (2017-07-19 00:15:38)
> On 2017-07-19 04:08, Stephen Boyd wrote:
> > Quoting Peter Rosin (2017-07-17 01:20:14)
> >> On 2017-07-14 23:40, Stephen Boyd wrote:
> >>> @@ -441,6 +447,8 @@ struct mux_control *mux_control_get(struct device
> >>> *dev, const char *mux_name)
> >>>
A set of patches to allow consumers to get and de/assert or trigger
a number of resets at the same time. A patch on top of Vivek's original
API extension is added to hide the reset_control_array behind a struct
reset_control so that the consumer doesn't have to care about the difference
between a
From: Vivek Gautam
Add support to get a list of resets available for the device.
These resets must be kept de-asserted until the device is
in use.
Cc: Felipe Balbi
Signed-off-by: Vivek Gautam
[p.za...@pengutronix.de:
From: Vivek Gautam
Move clock handling after of_platform_depopulate to achieve
a sequence that is reverse of the probe sequence.
Cc: Felipe Balbi
Signed-off-by: Vivek Gautam
---
No changes since v6.
---
From: Vivek Gautam
Many devices may want to request a bunch of resets and control them. So
it's better to manage them as an array. Add APIs to _get() an array of
reset_control, reusing the _assert(), _deassert(), and _reset() APIs for
single reset controls. Since
From: Vivek Gautam
Make use of of_reset_control_array_get_exclusive() to manage
an array of reset controllers available with the device.
Cc: Jon Hunter
Cc: Thierry Reding
Signed-off-by: Vivek Gautam
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
The current f_hid driver doesn't handle GET_PROCOTOL and
SET_PROCOTOL requests, which are required to operate HID
gadgets in BOOT mode. This patch implements this feature for
devices that have the same implementation for REPORT and BOOT mode
so that these devices are recognized by older BIOSes.
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
reset lines") started to transition the reset control request API calls
to explicitly state whether the driver needs exclusive or shared reset
control behavior. Convert all drivers requesting exclusive resets to the
explicit
On Wed, 19 Jul 2017 13:39:36 +
David Laight david.lai...@aculab.com wrote:
>From: Anatolij Gustschin
>> Sent: 19 July 2017 14:30
>...
>> >Stupid question, I know, but I cannot help thinking: If you have an
>> >EEPROM then why the h... don't you use an application specific device
>> >ID?
On Wed, 19 Jul 2017, Peter Chen wrote:
> The controller driver may be NULL if the controller device
> is the middle device between platform device and roothub.
> This middle device may not need a device driver due to all
> hardware control can be at platform device driver, this
> platform device
On Wed, 19 Jul 2017, Abdulhadi Mohamed wrote:
> Currently linux HID gadgets do not support remote wakeup (the ability
> to wake up a host from suspend). This is an important feature for
> gadgets that want to properly emulate the normal operation of a mouse
> and keyboard. Ultimately, This
Hi Krzysztof,
Today I tried to compile the latest kernel for Odroid xu4.
using exynos_defconfig I build and loaded the kernel.
but to my surprise usb 3.0 device and missing.
odroid login: root
Password:
Last login: Wed Jul 19 14:01:44 UTC 2017 on ttySAC2
Welcome to Ubuntu 16.04.2 LTS (GNU/Linux
On Wed, Jul 19, 2017 at 2:40 AM, Felipe Balbi wrote:
>
> Hi,
>
> Rob Herring writes:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for
On 07/19/2017 06:17 AM, Greg Kroah-Hartman wrote:
> MODULE_VERSION is useless for in-kernel drivers, so just remove all
> usage of it in the USB usbip drivers. Along with this, the
> USBIP_VERSION macros was removed as is was also pointless, as well as
> printing out the driver version to the
On Wed, Jul 19, 2017 at 02:41:56PM +0100, Abdulhadi Mohamed wrote:
> Currently linux HID gadgets do not support remote wakeup (the ability
> to wake up a host from suspend). This is an important feature for
> gadgets that want to properly emulate the normal operation of a mouse
> and keyboard.
On Tue, Jul 18, 2017 at 07:33:07PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 07/18/2017 06:13 PM, Bin Liu wrote:
>
> >Add helper function musb_ep_xfertype_string() to return the ep transfer
> >type string.
> >
> >Signed-off-by: Bin Liu
>
>Doesn't this belong to USB core?
Currently linux HID gadgets do not support remote wakeup (the ability
to wake up a host from suspend). This is an important feature for
gadgets that want to properly emulate the normal operation of a mouse
and keyboard. Ultimately, This feature has to be enabled/supported by
the underlying UDC
From: Anatolij Gustschin
> Sent: 19 July 2017 14:30
...
> >Stupid question, I know, but I cannot help thinking: If you have an
> >EEPROM then why the h... don't you use an application specific device
> >ID?
>
> It would make sense for adapter devices that you can buy and plug.
> In my particular
On Wed, 12 Jul 2017 11:11:46 +0200
Bjørn Mork bj...@mork.no wrote:
>Johan Hovold writes:
>> On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote:
>>
>>> For devices with connected EEPROM some modes (including UART) are
>>> configurable in the EEPROM. For devices
Hi Greg,
Thank you for the patch.
On Wednesday 19 Jul 2017 14:17:39 Greg Kroah-Hartman wrote:
> MODULE_VERSION is useless for in-kernel drivers, so just remove all
> usage of it in the USB gadget drivers. Along with this, some
> DRIVER_VERSION macros were removed as they are also pointless.
>
On Wed, 19 Jul 2017 10:59:34 +0200
Johan Hovold jo...@kernel.org wrote:
...
>> > +static const struct mfd_cell ftdi_cells[] = {
>> > + { .name = "ftdi-cbus-gpio", },
>> > + { .name = "ftdi-mpsse-i2c", },
>> > + { .name = "ftdi-mpsse-spi", },
>> > + { .name = "ftdi-fifo-fpp-mgr", },
>> > +};
On Wed, Jul 19, 2017 at 02:30:20PM +0200, Richard Leitner wrote:
> On 07/19/2017 02:17 PM, Greg Kroah-Hartman wrote:
> > MODULE_VERSION is useless for in-kernel drivers, so just remove all
> > usage of it in the USB misc drivers. Along with this, some
> > DRIVER_VERSION macros were removed as
On Wed, Jul 19, 2017 at 03:27:18PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Greg Kroah-Hartman writes:
> > MODULE_VERSION is useless for in-kernel drivers, so remove the
> > use of it in the marvel phy driver, along with the DRIVER_VERSION
> > define.
> >
> > Cc:
On Wed, Jul 19, 2017 at 03:26:22PM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Greg Kroah-Hartman writes:
> > MODULE_VERSION is useless for in-kernel drivers, so just remove all
> > usage of it in the USB gadget drivers. Along with this, some
> > DRIVER_VERSION macros
On 07/19/2017 02:17 PM, Greg Kroah-Hartman wrote:
> MODULE_VERSION is useless for in-kernel drivers, so just remove all
> usage of it in the USB misc drivers. Along with this, some
> DRIVER_VERSION macros were removed as they are also pointless.
...
> diff --git a/drivers/usb/misc/usb251xb.c
Hi,
Greg Kroah-Hartman writes:
> MODULE_VERSION is useless for in-kernel drivers, so remove the
> use of it in the marvel phy driver, along with the DRIVER_VERSION
> define.
>
> Cc: Felipe Balbi
> Signed-off-by: Greg Kroah-Hartman
Hi,
Greg Kroah-Hartman writes:
> MODULE_VERSION is useless for in-kernel drivers, so just remove all
> usage of it in the USB gadget drivers. Along with this, some
> DRIVER_VERSION macros were removed as they are also pointless.
>
> Cc: Laurent Pinchart
MODULE_VERSION is useless for in-kernel drivers, so just remove all
usage of it in the USB misc drivers. Along with this, some
DRIVER_VERSION macros were removed as they are also pointless.
Cc: Keith Packard
Cc: Juergen Stuber
Cc: Cesar Miquel
MODULE_VERSION is useless for in-kernel drivers, so remove the
use of it in the Realtek USB card reader driver.
Cc: Alan Stern
Signed-off-by: Greg Kroah-Hartman
---
drivers/usb/storage/realtek_cr.c | 1 -
1 file changed, 1 deletion(-)
MODULE_VERSION is useless for in-kernel drivers, so remove the
use of it in the marvel phy driver, along with the DRIVER_VERSION
define.
Cc: Felipe Balbi
Signed-off-by: Greg Kroah-Hartman
---
drivers/usb/phy/phy-mv-usb.c | 2 --
1 file changed, 2
No one uses the DRIVER_VERSION define in this driver, so just delete it.
Cc: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman
---
drivers/usb/image/microtek.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/image/microtek.c
No one uses the DRIVER_VERSION define in this driver, so just delete it.
Cc: Oliver Neukum
Cc: "Bjørn Mork"
Signed-off-by: Greg Kroah-Hartman
---
drivers/usb/class/cdc-wdm.c | 4
1 file changed, 4 deletions(-)
diff --git
MODULE_VERSION is useless for in-kernel drivers, so just remove all
usage of it in the USB ATM drivers. Along with this, some
DRIVER_VERSION macros were removed as they are also pointless.
Cc: Duncan Sands
Signed-off-by: Greg Kroah-Hartman
---
MODULE_VERSION is useless for in-kernel drivers, so just remove all
usage of it in the USB gadget drivers. Along with this, some
DRIVER_VERSION macros were removed as they are also pointless.
Cc: Laurent Pinchart
Cc: Felipe Balbi
MODULE_VERSION is useless for in-kernel drivers, so just remove all
usage of it in the USB usbip drivers. Along with this, the
USBIP_VERSION macros was removed as is was also pointless, as well as
printing out the driver version to the syslog at init time, which is not
necessary at all.
Cc:
MODULE_VERSION is useless for in-kernel drivers, so remove the use of it
in the chipidea CI13XXX driver.
Cc: Peter Chen
Signed-off-by: Greg Kroah-Hartman
---
drivers/usb/chipidea/ci_hdrc_pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git
When a driver is in the kernel tree, the use of MODULE_VERSION and
DRIVER_VERSION and the like is totally pointless and most often,
completly wrong. So here's a short series dropping all of the
MODULE_VERSION usage from drivers/usb/*
I'll be glad to take this in my tree unless others object...
On Mon, 10 Jul 2017 14:52:10 +0200
Johan Hovold jo...@kernel.org wrote:
>On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote:
>> Add USB part with common functions for USB-GPIO/I2C/SPI master
>> adapters. These allow communication with chip's control, transmit
>> and receive
On Fri, Jul 14, 2017 at 10:28:48AM +0200, Linus Lüssing wrote:
> On Fri, Jul 14, 2017 at 02:41:24PM +0700, Lars Melin wrote:
> > On 2017-07-14 13:58, Linus Lüssing wrote:
> >
> > >---
> > >$ dmesg
> > >[...]
> > >[166914.044029] usb 1-1.6.1: new full-speed USB device number 23 using
> > >dwc_otg
On Wednesday, July 19, 2017 10:56:00 AM Peter Chen wrote:
> On Tue, Jul 18, 2017 at 07:06:05PM +0200, Rafael J. Wysocki wrote:
> > On Tue, Jul 18, 2017 at 6:29 AM, Peter Chen wrote:
> > > On Mon, Jul 17, 2017 at 03:39:07PM +0200, Rafael J. Wysocki wrote:
> > >> > Sorry, I
The PIDs for Isochronous data transfers are incorrect
for high bandwidth IN endpoints when the request length
is less than EP wMaxPacketSize.
As per spec correct PIDs for ISOC data transfers are:
->For request length <= wMaxPacketSize
- DATA0,
->For wMaxPacketSize < length <= (2 *
On Wed, 19 Jul 2017 11:03:11 +0200
Johan Hovold jo...@kernel.org wrote:
>On Thu, Jul 13, 2017 at 06:25:25PM +0200, Anatolij Gustschin wrote:
>> On FT232H the interface mode can be configured in the EEPROM,
>> and the async UART mode is configured by default. The chip is
>> also in async UART mode
On Wed, Jul 19, 2017 at 01:57:26PM +0300, Felipe Balbi wrote:
>
> Hi Greg,
>
> here's my first set of fixes for the current -rc cycle. Let me know if
> you want anything to be changed.
>
> cheers
>
> The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877:
>
> Linux
Hi Greg,
here's my first set of fixes for the current -rc cycle. Let me know if
you want anything to be changed.
cheers
The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877:
Linux v4.13-rc1 (2017-07-15 15:22:10 -0700)
are available in the git repository at:
(No top-posting!)
"He, Bo" writes:
> The patch I submitted is based on the latest kernel,
> I checked the latest kernel has the same logic,
> so I send the patch to LKML.
but you haven't reproduced the bug on latest kernel, have you?
Can you send me tracepoint output of one
On Thu, Jul 13, 2017 at 06:25:25PM +0200, Anatolij Gustschin wrote:
> On FT232H the interface mode can be configured in the EEPROM,
> and the async UART mode is configured by default. The chip is
> also in async UART mode if no EEPROM is connected.
>
> Check the EEPROM configuration and do not
On Mon, Jul 10, 2017 at 02:52:10PM +0200, Johan Hovold wrote:
> On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote:
> > Add USB part with common functions for USB-GPIO/I2C/SPI master
> > adapters. These allow communication with chip's control, transmit
> > and receive endpoints and
The patch I submitted is based on the latest kernel,
I checked the latest kernel has the same logic,
so I send the patch to LKML.
Thanks for your comments.
-Original Message-
From: Felipe Balbi [mailto:ba...@kernel.org]
Sent: Wednesday, July 19, 2017 3:51 PM
To: He, Bo
Hi,
(please don't top-post and also break your lines at 80-columns ;-)
"He, Bo" writes:
> 1. the issue reproduced very rarely, we run reboot test
> reproduce the issue, it reproduced two times on two board after
> more than 1500 cycles reboot.
That's fine,
Hi,
Manu Gautam writes:
>> Manu Gautam writes:
Manu Gautam writes:
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index aea9a5b..b81547d 100644
> --- a/drivers/usb/dwc3/gadget.c
Hi,
Rob Herring writes:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring
> Cc: Greg
Both xhci_hub_control and xhci_disable_slot tries to hold spinlock, the
spinlock recursion occurs when enters USB2 test mode. Fix it by unlock
spinlock before calling xhci_disable_slot.
Cc:
Fixes: 0f1d832ed1fb ("usb: xhci: Add port test modes support for usb2")
A gadget driver will not disable eps immediately when ->disconnect()
is called. But, since this driver assumes all eps stop after
the ->disconnect(), unexpected behavior happens (especially in system
suspend).
So, this patch disables all eps in usbhsg_try_stop(). After disabling
eps by
This patch fixes an issue that some registers may be not initialized
after resume if the USBHSF_RUNTIME_PWCTRL is not set. Otherwise,
if a cable is not connected, the driver will not enable INTENB0.VBSE
after resume. And then, the driver cannot detect the VBUS.
Fixes: ca8a282a5373 ("usb: gadget:
This patch set is based on the latest Felipe's usb.git / testing/fixes branch
(the commit id = 781001ff9678e5df048cca3d4290c1638a28cafa).
Yoshihiro Shimoda (2):
usb: renesas_usbhs: fix usbhsc_resume() for !USBHSF_RUNTIME_PWCTRL
usb: renesas_usbhs: gadget: disable all eps when the driver stops
On 2017-07-19 04:08, Stephen Boyd wrote:
> Quoting Peter Rosin (2017-07-17 01:20:14)
>> On 2017-07-14 23:40, Stephen Boyd wrote:
>>> diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c
>>> index 90b8995f07cb..a0e5bf16f02f 100644
>>> --- a/drivers/mux/mux-core.c
>>> +++
The controller driver may be NULL if the controller device
is the middle device between platform device and roothub.
This middle device may not need a device driver due to all
hardware control can be at platform device driver, this
platform device is usually a dual-role USB controller device.
The
On Tue, Jul 18, 2017 at 09:49:35PM +0100, Abdulhadi Mohamed wrote:
> On Tue, Jul 18, 2017 at 10:17:24PM +0200, Greg KH wrote:
> > On Tue, Jul 18, 2017 at 08:47:58PM +0100, Abdulhadi Mohamed wrote:
> > > The current HID function driver doesn't support GET_PROCOTOL and
> > > SET_PROCOTOL commands,
Hi,
On 7/18/2017 4:27 PM, Felipe Balbi wrote:
> Hi,
>
> Manu Gautam writes:
>>> Manu Gautam writes:
>>> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index aea9a5b..b81547d 100644
--- a/drivers/usb/dwc3/gadget.c
79 matches
Mail list logo