>
> On Tue, May 14, 2019 at 4:39 AM Peter Chen wrote:
> >
> > Add imx7ulp support
>
> Since you are adding a new flag CI_HDRC_PMQOS, it would be nice to expand the
> commit log a bit to explain about it.
Ok, I will. Thanks.
Peter
unction is tested at imx7ulp-evk
board.
Thanks.
Peter Chen (8):
doc: dt-binding: mxs-usb-phy: add compatible for 7ulp
usb: phy: phy-mxs-usb: add imx7ulp support
doc: dt-binding: ci-hdrc-usb2: add compatible string for imx7ulp
doc: dt-binding: usbmisc-imx: add compatible string for imx7ulp
Add compatible for 7ulp USB PHY.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/phy/mxs-usb-phy.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
b/Documentation/devicetree/bindings/phy/mxs
At imx7ulp, the USB related analog register is located in PHY register
region too, so we need to control PLL at PHY driver directly.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 76 ++-
1 file changed, 75 insertions(+), 1 deletion
Enable USBOTG1 support for evk board, it is dual-role function
port.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp-evk.dts | 35 +++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts
b/arch/arm/boot/dts/imx7ulp-evk.dts
Since the chipidea common code support get the USB PHY phandle from
"phys", the glue layer is not mandatory to get the "fsl,usbphy" phandle
any more.
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Add imx7ulp USBOTG1 support.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp.dtsi | 31 +++
1 file changed, 31 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index fca6e50f37c8..60c9ea116d0a 100644
--- a/arch/arm
Add compatible string for imx7ulp
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
b/Documentation/devicetree/bindings/usb
Add imx7ulp support
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 28 +++-
drivers/usb/chipidea/usbmisc_imx.c | 4
include/linux/usb/chipidea.h | 1 +
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea
Add compatible string for imx7ulp.
Reviewed-by: Rob Herring
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb
> On 2019-05-13 11:00, Peter Chen wrote:
> >> On 2019-05-10 05:10, Peter Chen wrote:
> >>>> Marek Szyprowski writes:
> >>>>> Commit 69bec7259853 ("USB: core: let USB device know device node")
> >>>>> added support fo
>
> On 2019-05-10 05:10, Peter Chen wrote:
> >
> >> Marek Szyprowski writes:
> >>> Commit 69bec7259853 ("USB: core: let USB device know device node")
> >>> added support for attaching devicetree node for USB devices. The
> >>>
> > > > ++
> > > > 1 file changed, 30 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > > > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..e2944f98eac6
> > > > 100644
> > > > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > > > +++ b/arch/arm
> > ---
> > arch/arm/boot/dts/imx7ulp.dtsi | 30 ++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi
> > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..e2944f98eac6
> > 100644
> > --- a/arch/arm/boot/dts/imx7ulp.dtsi
> > +
Add imx7ulp support
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 28 +++-
drivers/usb/chipidea/usbmisc_imx.c | 4
include/linux/usb/chipidea.h | 1 +
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea
Enable USBOTG1 support for evk board, it is dual-role function
port.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp-evk.dts | 35 +++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp-evk.dts
b/arch/arm/boot/dts/imx7ulp-evk.dts
Add imx7ulp USBOTG1 support.
Signed-off-by: Peter Chen
---
arch/arm/boot/dts/imx7ulp.dtsi | 30 ++
1 file changed, 30 insertions(+)
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
index fca6e50f37c8..e2944f98eac6 100644
--- a/arch/arm
Add compatible string for imx7ulp
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
index
Add compatible string for imx7ulp.
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index
Add compatible for 7ulp USB PHY.
Signed-off-by: Peter Chen
---
Documentation/devicetree/bindings/phy/mxs-usb-phy.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
b/Documentation/devicetree/bindings/phy/mxs-usb-phy.txt
index
There is a dual-role USB controller at imx7ulp, we add support for it
in this patch set, and the dual-role function is tested at imx7ulp-evk
board.
Thanks.
Peter Chen (7):
doc: dt-binding: mxs-usb-phy: add compatible for 7ulp
usb: phy: phy-mxs-usb: add imx7ulp support
doc: dt-binding: ci
At imx7ulp, the USB related analog register is located in PHY register
region too, so we need to control PLL at PHY driver directly.
Signed-off-by: Peter Chen
---
drivers/usb/phy/phy-mxs-usb.c | 76 ++-
1 file changed, 75 insertions(+), 1 deletion
On Mon, Apr 15, 2019 at 5:40 PM Andrzej Pietrasiewicz
wrote:
>
> Hi Peter,
>
>
>
> >>
> >> Can you please describe your use case?
> >>
> >> Andrzej
> >
> > I would like to change parameters for function driver through configfs,
> > below is the example for ncm and f_sourcesink cases,
> > thanks.
> >
> >>>
> >>> Andrzej, would you tell us why you introduce refcnt for driver's
> >>> configfs opts? And why it is needed to judge for "store" operation?
> >>>
> >>
> >> The reason is that a function can be linked to more than one
> >> configuration. Imagine this sequence: you create a function,
> >
> > Andrzej, would you tell us why you introduce refcnt for driver's
> > configfs opts? And why it is needed to judge for "store" operation?
> >
>
> The reason is that a function can be linked to more than one configuration.
> Imagine
> this sequence: you create a function, set its paramete
>
> Peter Chen writes:
> > Hi Felipe,
> >
> > Do you know why? In that case, I can't change property, eg changing
> > qmult at NCM like below:
> >
> > mkdir functions/ncm.0
> > ln -s functions/ncm.0 configs/c.1
> > echo 10 >
mutex_unlock(&opts->lock); \
return ret; \
} \
\
CONFIGFS_ATTR(_f_##_opts_, qmul
BR,Peter Chen
On Thu, Mar 7, 2019 at 11:26 PM Greg KH wrote:
>
> On Thu, Mar 07, 2019 at 03:24:29PM +0100, rchmielarz wrote:
> > Hi,
> >
> > I'm trying to certify USB on our device that is running Linux 4.14.
> > For windows systems we were using https://www.u
> >
> > > >
> > > >
> > > > > drivers/usb/chipidea/core.c | 2 ++
> > > > > include/linux/usb/chipidea.h
> > > > > |
> > > > > 4
> > > > > 2 files changed, 6 insertions(+)
> > > > >
> > > > > diff --git a/drivers/usb/chipidea/core.c
> > > > > b/drivers/usb/chipidea/core.c index
> > > > > 7bf
> On 2/28/19 1:57 AM, Peter Chen wrote:
> >
> >>> Let me summary your observation:
> >>> - bind/unbind ci_hdrc device can recover connection
> >>> - Reset HUB can't recover, and will go the previous error state
> >>> after reset
>
> >
> >
> > > drivers/usb/chipidea/core.c | 2 ++ include/linux/usb/chipidea.h |
> > > 4
> > > 2 files changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/usb/chipidea/core.c
> > > b/drivers/usb/chipidea/core.c index
> > > 7bfcbb2..0bfa850 100644
> > > --- a/drivers/usb/chipidea/cor
> > Let me summary your observation:
> > - bind/unbind ci_hdrc device can recover connection
> > - Reset HUB can't recover, and will go the previous error state after
> > reset
> >
> > From the register, we do see something abnormal, and the RX is
> > waiting the SYNC Field. We need to see the d
> >> Chandler
> > From the above, we know the controller is at RX active status. But I
> > am sorry I got the imprecise instruction from IC guys. The reason we
> > do that is to know the RX status change during one packet, for your
> > example, there are ISOC packets, so, measure time is about 2
From: Jun Li
Those 2 headers files are not required now.
Signed-off-by: Jun Li
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index e81de9ca8729
ard compatibility if some users
were actually relying on this mechanism.
Signed-off-by: Paul Kocialkowski
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/core.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
obtained and the flow is easier to
understand and follow.
All error pointers (except for EPROBE_DEFER) are considered as PHY
not found.
Signed-off-by: Paul Kocialkowski
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/core.c | 49 +
1 file changed, 32
as gpio and driven by a regulator.
Also make use of of_property_read_bool.
Signed-off-by: Philipp Puschmann
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 4 ++--
drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
drivers/usb/chipidea/usbmisc_imx.c | 7 +++
3 files changed, 10
: Peter Chen
---
Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index adae82385dd6..a254386a91ad 100644
--- a/Documentation
Hi Greg,
Some small changes for chipidea drivers:
- New dts property for VBUS power polarity
- Improve USB PHY and Generic PHY handling
Thanks.
Jun Li (1):
usb: chipidea: imx: remove unused header files
Paul Kocialkowski (2):
usb: chipidea: Grab the (legacy) USB PHY by phandle first
usb:
> drivers/usb/chipidea/core.c | 2 ++
> include/linux/usb/chipidea.h | 4
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index
> 7bfcbb2..0bfa850 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
>
> > I suspect the controller is stuck at high speed. Chandler, would you please
> > supply
> below information:
> > - If there is SOFs on the bus (you need to measure by probe) when the issue
> occurs?
> > - If the SOF can't be observed at bus, it means the disconnection
> > can't be observed eith
> On 2/23/19 3:17 AM, Greg KH wrote:
> > On Fri, Feb 22, 2019 at 10:43:17AM -0500, Chandler Griscom wrote:
> >> Hello,
> >>
> >> I am encountering an issue where noise on USB devices is causing the
> >> host ci_hdrc driver to stall. The system contains an i.MX6 board
> >> (UDOO) connected to a U
atform_device *pdev)
> {
> struct tegra_udc *udc = platform_get_drvdata(pdev);
>
> + ci_hdrc_remove_device(udc->dev);
> usb_phy_set_suspend(udc->phy, 1);
> clk_disable_unprepare(udc->clk);
>
Acked-by: Peter Chen
Hi Greg, would you still accept the bug-fix for this release (v5.0)? Or I send
you later?
Peter
>
> Refactor the code in charge of looking up the USB PHY when no platdata is
> provided. Attempt to get a generic USB PHY first, then look for a legacy USB
> PHY
> through device-tree and finally get any registered PHY with the correct type.
>
> This way, only a single USB PHY is obtained and
> > Current code w/o your patch, it is possible both ci->phy and
> > ci->usb_phy are valid if the USB PHY is not at the device tree, but generic
> > PHY is
> at the device tree.
> > If you don't want to fix this issue with this patch, it is ok too. We could
> > fix it later.
>
> I'm not sure I
> > If there is a generic PHY node under USB controller, and there is a
> > USB PHY at other sides, both ci->phy and ci->usb_phy are valid, I
> > original thought it is the problem you met.
>
> Right, this is not the problem we are having. The problem is that legacy USB
> PHYs
> are not grabbed
>
> On Mon, 2019-02-18 at 03:04 +, Peter Chen wrote:
> > > According to the chipidea driver bindings, the USB PHY is specified via
> > > the
> "phys"
> > > phandle node. However, this only takes effect for USB PHYs that use
> > >
> According to the chipidea driver bindings, the USB PHY is specified via the
> "phys"
> phandle node. However, this only takes effect for USB PHYs that use the common
> PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY
> type is done instead.
>
> This does not play out w
you have any questions about this process, please let me know.
>
>
> From 0d1ec194721f844a6b20f7f4854332adcebc6fb9 Mon Sep 17 00:00:00 2001
> From: Peter Chen
> Date: Tue, 12 Feb 2019 08:57:27 +
> Subject: usb: misc: usbtest: add super-speed isoc support
>
> The calc
> >
> > Hi Rob,
> > >On Thu, Jan 31, 2019 at 11:52:28AM +, Pawel Laszczak wrote:
> > >> This patch aim at documenting USB related dt-bindings for the
> > >> Cadence USBSS-DRD controller.
> > >>
> > >> Signed-off-by: Pawel Laszczak
> > >> ---
> > >> .../devicetree/bindings/usb/cdns-usb3.txt
The calculation of packet number within microframe is different between
high-speed and super-speed endpoint, we add support for super-speed
in this patch.
Cc: Pawel Laszczak
Signed-off-by: Peter Chen
---
drivers/usb/misc/usbtest.c | 28
1 file changed, 24
reference to `otg_statemachine'
Cc: #v4.1+
Cc: Li Yang
Reported-by: Mark Brown
Signed-off-by: Peter Chen
---
drivers/usb/phy/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
index d7312eed6088..5444d2437475 100644
> Cc: Peter Chen ; Greg Kroah-Hartman
> ; Alexander Shiyan
> Subject: [PATCH] usb: chipidea: imx: Remove unused include
>
> Remove unused #include in drivers/usb/chipidea/ci_hdrc_imx.c
>
> Signed-off-by: Alexander Shiyan
> ---
> drivers/usb/chipidea/ci_hdrc_im
> Am 17.01.19 um 08:01 schrieb Peter Chen:
> >
> >>
> >> The i.MX6q/dl USB controller may drive the usb power line directly,
> >> but the polarity depends on the board. Reset state of the polarity is
> >> low-active so add this property to allow i
> On Thu, 2019-01-17 at 06:44 +0000, Peter Chen wrote:
> >
> > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> > > > Well prior to your code, there was already a possibility for both
> > > > ci->phy and ci->usb_phy to be val
>
> On Thu, Jan 17, 2019 at 09:24:20AM +, Peter Chen wrote:
> > During the static checker, "data->usbmisc_data" may be NULL.
>
> I can not quite parse this sentance. Do you mean that a static checker found
> this
> issue?
I think &qu
During the static checker, "data->usbmisc_data" may be NULL.
Fix it by adding this pointer judgement before using.
Reported-by: Dan Carpenter
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Peter Chen (1):
usb: chipidea: fix static checker warning for NULL pointer
drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.14.1
>
> The i.MX6q/dl USB controller may drive the usb power line directly, but the
> polarity
> depends on the board. Reset state of the polarity is low-active so add this
> property
> to allow it to be high-active.
>
As far as I know, most of i.mx USB controllers (except imx28/23, but they don
>
> On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> > Well prior to your code, there was already a possibility for both
> > ci->phy and ci->usb_phy to be valid. I don't think it's really useful
> > to avoid the fallback when a generic PHY has already been found, it's
> > confusing.
>
> When running an imx_defconfig on a imx6q-sabrelite, rmmod g_mass_storage lead
> to the following crash:
> [ 143.952834] Internal error: Oops: 817 [#1] SMP ARM
> [ 143.957639] Modules linked in: dmatest psmouse serport da9063_wdt wl12xx
> wl18xx wlcore wlcore_sdio brcmfmac brcmutil mwifiex_s
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 880009987460..813673eee815 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -250,6 +250,10 @@ static int ci_hdrc_msm_probe(struct platform_device
>
> >
> >@@ -299,6 +306,7 @@ int cdns3_drd_init(struct cdns3 *cdns)
> >cdns->version = CDNS3_CONTROLLER_V0;
> >cdns->otg_v1_regs = NULL;
> >cdns->otg_regs = regs;
> >+ writel(0x1, &cdns->otg_v0_regs->simulate);
> >dev_in
> Signed-off-by: Kangjie Lu
> ---
> drivers/usb/chipidea/ci_hdrc_msm.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 880009987460..b7f7acef72d4 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +
> Signed-off-by: Kangjie Lu
> ---
> drivers/usb/chipidea/ci_hdrc_msm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 880009987460..7dc987b4036a 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++
During the static checker, "data->usbmisc_data" may be NULL.
Fix it by this pointer judgement before using.
Reported-by: Dan Carpenter
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
the HSIC support for imx
Peter Chen (4):
usb: chipidea: add flag for imx hsic implementation
usb: chipidea: imx: add HSIC support
usb: chipidea: host: override ehci->hub_control
doc: usb: ci-hdrc-usb2:
On Wed, Dec 12, 2018 at 3:49 AM Pawel Laszczak wrote:
>
> Hi,
>
> >On 10/12/18 7:42 AM, Peter Chen wrote:
> >>>> +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget,
> >>>> +
On Tue, Dec 11, 2018 at 6:19 PM Roger Quadros wrote:
>
> Pawel,
>
> On 10/12/18 14:39, Pawel Laszczak wrote:
> > This patch aim at documenting USB related dt-bindings for the
> > Cadence USBSS-DRD controller.
> >
> > Signed-off-by: Pawel Laszczak
> > ---
> > .../devicetree/bindings/usb/cdns3-usb
> >
> > Felipe, I use Dynamic Debug for debugging, and show debug messages
> > with "dmesg" after testing/debugging. I see dwc3 using trace, any
> > benefits for switching to trace?
>
> The benefits I see are
>
Thanks, bin.
> - *by default*, the debug log doesn't have to go through uart cons
> >
> > Interrupt handler (hardirq context) at CPU0, and process at CPU1, eg
> > role switch, unload module, etc.
>
> the process at CPU1 would need to disable interrupts (spin_lock_irq() or
> spin_lock_irqsave()), not the hardirq on CPU0 as that already runs with
> interrrupts
> disabled.
>
>
> >> >> + USB_CMD_STMODE |
> >> >> +
> >> >> + USB_STS_TMODE_SEL(tmode - 1));
> >> >
> >> >I'm 90% sure this won't work. There's a reason why we only enter the
> >> >requested test mode from status stage. How have you tested this?
> >>
> >
> > What's the
> >> +tmode = le16_to_cpu(ctrl->wIndex);
> >> +
> >> +if (!set || (tmode & 0xff) != 0)
> >> +return -EINVAL;
> >> +
> >> +switch (tmode >> 8) {
> >> +case TEST_J:
> >> +case TEST_K:
> >> +case TEST_SE0_NAK:
The chipidea controller has some special requirements during
suspend/resume, override common ehci->hub_control to implement
it.
Reviewed-by: Frieder Schrempf
Tested-by: Frieder Schrempf
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/host.c |
needed
Reviewed-by: Frieder Schrempf
Tested-by: Frieder Schrempf
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 140 -
drivers/usb/chipidea/ci_hdrc_imx.h | 9 ++-
drivers/usb/chipidea/usbmisc_imx.c | 140
NXP (Freecale) imx HSIC design has some special requirements, add
some flags at host code to handle them.
Reviewed-by: Frieder Schrempf
Tested-by: Frieder Schrempf
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/host.c | 17 +
include/linux/usb/chipidea.h | 3 +++
2 files
For USB HSIC, the data and strobe pin needs to be pulled down
at default, we consider it as "idle" state. When the USB host
is ready to be used, the strobe pin needs to be pulled up,
we consider it as "active" state.
Signed-off-by: Peter Chen
---
.../devicetree/bindings/
for binding-doc, and add the dts example [Patch 4/4]
Changes for v2:
- Compile error reported by kbuild robot [Patch 2/4]
- Comment from Frieder Schrempf about code structure [Patch 2/4]
- Comment from Fabio about adding example for pinctrl [Patch 4/4]
Peter Chen (4):
usb: chipidea: add flag
>
> On Mon, Dec 10, 2018 at 6:09 AM Schrempf Frieder
> wrote:
>
> > With a separate example for HSIC, we should probably leave the
> > standard example unchanged (I think that was one of the reasons for
> > adding a separate example).
>
> Yes, I agree. That would make the binding doc clearer.
> > +static struct cdns3_endpoint *cdns3_find_available_ss_ep(struct
> > cdns3_device *priv_dev,
> > + struct
> > usb_endpoint_descriptor *desc)
>
> why is this function called ss_ep? This doesn't seem like only for superspeed
> endpoints.
>
For USB HSIC, the data and strobe pin needs to be pulled down
at default, we consider it as "idle" state. When the USB host
is ready to be used, the strobe pin needs to be pulled up,
we consider it as "active" state.
Signed-off-by: Peter Chen
---
.../devicetree/bindings/
needed
Reviewed-by: Frieder Schrempf
Tested-by: Frieder Schrempf
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/ci_hdrc_imx.c | 140 -
drivers/usb/chipidea/ci_hdrc_imx.h | 9 ++-
drivers/usb/chipidea/usbmisc_imx.c | 140
The chipidea controller has some special requirements during
suspend/resume, override common ehci->hub_control to implement
it.
Reviewed-by: Frieder Schrempf
Tested-by: Frieder Schrempf
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/host.c |
kbuild robot [Patch 2/4]
- Comment from Frieder Schrempf about code structure [Patch 2/4]
- Comment from Fabio about adding example for pinctrl [Patch 4/4]
Peter Chen (4):
usb: chipidea: add flag for imx hsic implementation
usb: chipidea: imx: add HSIC support
usb: chipidea: host: override
NXP (Freecale) imx HSIC design has some special requirements, add
some flags at host code to handle them.
Reviewed-by: Frieder Schrempf
Tested-by: Frieder Schrempf
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/host.c | 17 +
include/linux/usb/chipidea.h | 3 +++
2 files
On Wed, Dec 5, 2018 at 4:55 PM Alan Douglas wrote:
>
> Hi Peter,
>
> On 05 December 2018 07:20, Pawel Laszczak wrote:
> > Hi,
> >
> > >> >>
> > >> >> Patch adds core.c and core.h file that implements initialization
> > >> >> of platform driver and adds function responsible for selecting,
> > >> >>
>
>
>
> On 04/12/18 10:50, Peter Chen wrote:
> >>> + * Cadence USBSS DRD Driver.
> >>> + *
> >>> + * Copyright (C) 2018 Cadence.
> >>> + *
> >>> + * Author: Peter Chen
> >>> + * Pawel Laszczak
&
> > --- a/drivers/usb/cdns3/Makefile
> > +++ b/drivers/usb/cdns3/Makefile
> > @@ -2,4 +2,5 @@ obj-$(CONFIG_USB_CDNS3) += cdns3.o
> > obj-$(CONFIG_USB_CDNS3_PCI_WRAP) += cdns3-pci.o
> >
> > cdns3-y := core.o drd.o
> > +cdns3-$(CONFIG_U
> On 04.12.18 21:01, Fabio Estevam wrote:
> > Hi Frieder,
> >
> > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder
> > wrote:
> >
> >> There are many other optional properties for this driver and a lot of
> >> them are not in the given example. Maybe we should just keep the
> >> pinctrls for HSI
On Sun, Nov 18, 2018 at 6:13 PM Pawel Laszczak wrote:
>
> Patch adds supports for detecting Host/Device mode.
> Controller has additional OTG register that allow
> implement even whole OTG functionality.
> At this moment patch adds support only for detecting
> the appropriate mode based on strap p
:= core.o
> >> cdns3-pci-y := cdns3-pci-wrap.o
> >> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> >> new file mode 100644
> >> index ..f9055d4da67f
> >> --- /dev/null
>
> > + * Cadence USBSS DRD Driver.
> > + *
> > + * Copyright (C) 2018 Cadence.
> > + *
> > + * Author: Peter Chen
> > + * Pawel Laszczak
> > + */
> > +
> > +#include
> > +#include
> > +#include
> > +#include
&g
On Mon, Dec 3, 2018 at 4:34 AM Pawel Laszczak wrote:
>
> >>
> >> Patch adds core.c and core.h file that implements initialization
> >> of platform driver and adds function responsible for selecting,
> >> switching and running appropriate Device/Host mode.
> >>
> >> Signed-off-by: Pawel Laszczak
>
> Signed-off-by: Uwe Kleine-König
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c
> b/drivers/usb/chipidea/ci_hdrc_imx.c
> index 80b4e4ef9b68..3dcfd0d97f94 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.
>
> On Mon, Dec 03, 2018 at 03:13:01AM +, PETER CHEN wrote:
> > The current OC (Over Current) handling does not consider the default
> > and bootloader OC setting well, in this commit, we reset OC setting
> > according to dts value:
> > - If property "di
er control chips are low active for OC, we keep
"over-current-active-high" property unchanging to reduce users effort.
If this property is set, we set OC polarity as high explicitly;
otherwise, we set it as low explicitly.
Cc: stable
Cc: Peter Chen
Cc: Uwe Kleine-König
Cc: Matthew
>
> > -Original Message-
> > From: Matthew Starr
> > Sent: 2018年11月30日 23:09
> > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li
> >
> > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low
> >
> > > -Origin
index ..f9055d4da67f
> --- /dev/null
> +++ b/drivers/usb/cdns3/core.c
> @@ -0,0 +1,413 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Cadence USBSS DRD Driver.
> + *
> + * Copyright (C) 2018 Cadence.
> + *
Please add NXP copyright too.
> + *
> +
> +/*
> + * USBSS-DEV register interface.
> + * This corresponds to the USBSS Device Controller Interface */
> +/**
> + * struct xhci_cap_regs - xHCI Host Controller Capability Registers.
struct cdns3_usb_regs - device controller registers
> +struct cdns3_device;
> +
> +struct cdns3_endp
> Roger Quadros writes:
> >> +static void cdns3_gadget_config(struct cdns3_device *priv_dev) {
> >> + struct cdns3_usb_regs __iomem *regs = priv_dev->regs;
> >> +
> >> + cdns3_ep0_config(priv_dev);
> >> +
> >> + /* enable interrupts for endpoint 0 (in and out) */
> >> + writel(EP_IEN_EP_OUT0
101 - 200 of 3915 matches
Mail list logo
