Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-26 Thread Sascha Hauer
On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: > This binding allow to disable the internal 60Mhz clock for USB host2 or > host3. > > Signed-off-by: Fabien Lahoudere > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + >

[PATCH 2/2] usb: chipidea: otg: fix reading otgsc register

2016-09-19 Thread Sascha Hauer
since this function eventually patches the VBUS status read from extcon into the raw register value. To fix this inline the hw_wait_reg() code into its only user and use the correct function to read the OTGSC register. Since hw_wait_reg() is unused now remove it. Signed-off-by: Sascha Hauer <s

USB: chipidea: Fix VBUS valid polling when extcon is used

2016-09-19 Thread Sascha Hauer
. Sascha Sascha Hauer (2): usb: chipidea: otg: save indention level usb: chipidea: otg: fix reading otgsc register drivers/usb/chipidea/ci.h | 3 --- drivers/usb/chipidea/core.c | 32

[PATCH 1/2] usb: chipidea: otg: save indention level

2016-09-19 Thread Sascha Hauer
Return early from ci_handle_id_switch() to save an indention level. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> --- drivers/usb/chipidea/otg.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/ch

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-08 Thread Sascha Hauer
On Tue, Dec 08, 2015 at 05:26:56PM +0800, Peter Chen wrote: > On Tue, Dec 08, 2015 at 07:19:05AM +0100, Sascha Hauer wrote: > > > + hub_data = devm_kzalloc(dev, sizeof(*hub_data), GFP_KERNEL); > > > + if (!hub_data) > > > + return -ENOMEM; &g

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-07 Thread Sascha Hauer
On Tue, Dec 08, 2015 at 09:37:48AM +0800, Peter Chen wrote: > Current USB HUB driver lacks of platform interfaces to configure > external signal on HUB chip, eg, the PHY input clock and gpio reset > pin for HUB, these kinds of HUBs are usually soldered at the board, > and they are not hot-plug USB

Re: [PATCH 02/10] usb: chipidea: define stream mode disable for both roles

2015-07-29 Thread Sascha Hauer
On Wed, Jul 29, 2015 at 07:51:55AM +0200, Sascha Hauer wrote: Hi Peter, On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote: The system bus and chipidea IP have different limitations for both host and device mode. For example, with below errata, we need to enable SDIS(Stream

Re: [PATCH 02/10] usb: chipidea: define stream mode disable for both roles

2015-07-28 Thread Sascha Hauer
Hi Peter, On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote: The system bus and chipidea IP have different limitations for both host and device mode. For example, with below errata, we need to enable SDIS(Stream Disable Mode) at host mode. But we don't want it for device mode at the

Re: [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-07-14 Thread Sascha Hauer
On Tue, Jul 14, 2015 at 02:19:51PM +0800, chunfeng yun wrote: hi, On Fri, 2015-07-10 at 07:10 +0200, Sascha Hauer wrote: On Wed, Jul 08, 2015 at 05:41:03PM +0800, Chunfeng Yun wrote: add a DT binding documentation of usb3.0 phy for MT65xx SoCs from Mediatek. Signed-off

Re: [PATCH v2 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs

2015-07-10 Thread Sascha Hauer
On Wed, Jul 08, 2015 at 05:41:05PM +0800, Chunfeng Yun wrote: Signed-off-by: Chunfeng Yun chunfeng@mediatek.com --- drivers/usb/phy/Kconfig | 10 + drivers/usb/phy/Makefile | 1 + drivers/usb/phy/phy-mt65xx-usb3.c | 856 ++ 3

Re: [PATCH v2 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs

2015-07-09 Thread Sascha Hauer
On Wed, Jul 08, 2015 at 05:41:03PM +0800, Chunfeng Yun wrote: add a DT binding documentation of usb3.0 phy for MT65xx SoCs from Mediatek. Signed-off-by: Chunfeng Yun chunfeng@mediatek.com --- .../devicetree/bindings/usb/mt65xx-u3phy.txt | 34 ++ 1 file

Re: [PATCH] USB: ehci-mxc: i.MX35: add workaround for ENGcm11601

2015-03-12 Thread Sascha Hauer
On Wed, Mar 11, 2015 at 03:52:53PM +0100, Bas Vermeulen wrote: Hello, On Wed, March 11, 2015 2:51 pm, Sascha Hauer wrote: This driver normally is not used with device tree. Without additional kernel changes the chipidea driver is used instead. I'm just forward-porting a patch I made

Re: [PATCH] USB: ehci-mxc: i.MX35: add workaround for ENGcm11601

2015-03-11 Thread Sascha Hauer
On Wed, Mar 11, 2015 at 04:05:31PM +0100, Bas Vermeulen wrote: On Wed, March 11, 2015 4:01 pm, Sascha Hauer wrote: On Wed, Mar 11, 2015 at 03:52:53PM +0100, Bas Vermeulen wrote: Hello, On Wed, March 11, 2015 2:51 pm, Sascha Hauer wrote: This driver normally is not used with device

Re: [PATCH] USB: ehci-mxc: i.MX35: add workaround for ENGcm11601

2015-03-11 Thread Sascha Hauer
On Wed, Mar 11, 2015 at 01:42:42PM +0100, Bas Vermeulen wrote: i.MX35 has an issue that when USB DMA (SINGLE) transfers are interrupted, the usb core can hang. This patch implements the workaround described in ENGcm11601 by setting the AHB to use INCR transfers instead of SINGLE transfers.

Re: i.MX6 USB OTG support is broken on linux-next

2014-05-12 Thread Sascha Hauer
On Tue, May 13, 2014 at 12:33:30AM +, Peter Chen wrote: On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote: On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote: + Robin and David, diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig index

Re: i.MX6 USB OTG support is broken on linux-next

2014-05-11 Thread Sascha Hauer
On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote: On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote: + Robin and David, diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig index cb8e991..9081757 100644 --- a/drivers/usb/core/Kconfig +++

Re: [PATCH] ARM: i.MX6: clk: Remove usbphy clock hacks

2014-02-28 Thread Sascha Hauer
On Fri, Feb 28, 2014 at 08:40:51AM +0800, Peter Chen wrote: On Thu, Feb 27, 2014 at 03:47:45PM +0100, Sascha Hauer wrote: portsc = PORTSC_PTS(PTS_UTMI) | PORTSC_PTW; lpm = DEVLC_PTS(PTS_UTMI) | DEVLC_PTW; break; case USBPHY_INTERFACE_MODE_ULPI

Re: [PATCH] ARM-i.MX6Q-dts : Added USB_OTG Support

2014-01-24 Thread Sascha Hauer
Please add Phytec phyFLEX-i.MX6 to the subject. I assumed some SoC specific changes here. Sascha On Fri, Jan 24, 2014 at 02:58:44PM +0530, Ashutosh singh wrote: This patch adds support for USB_OTG on Phytec phyFLEX-i.MX6 Quad module. Signed-off-by: Ashutosh singh ashutos...@phytec.in ---

Re: [PATCH] USB: chipidea: fix error path

2013-12-20 Thread Sascha Hauer
On Thu, Dec 19, 2013 at 04:28:54PM +0800, Peter Chen wrote: On Thu, Dec 19, 2013 at 09:35:44AM +0100, Sascha Hauer wrote: devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha

[PATCH] USB: chipidea: fix error path

2013-12-19 Thread Sascha Hauer
devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Peter Chen peter.c...@freescale.com Cc: linux-usb@vger.kernel.org --- drivers/usb/chipidea

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: Hi, Peter Chen wrote: This commit adds runtime and system power management support for chipidea core. The runtime pm support is controlled by glue layer, it

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Sascha Hauer
On Mon, Oct 14, 2013 at 05:04:21PM +0800, Peter Chen wrote: On Mon, Oct 14, 2013 at 10:42:16AM +0200, Sascha Hauer wrote: On Mon, Oct 14, 2013 at 03:55:48PM +0800, Peter Chen wrote: On Mon, Oct 14, 2013 at 10:04:58AM +0200, Lothar Waßmann wrote: Hi, Peter Chen wrote

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: Deferred probing cannot be used with platform_driver_probe as by the time probing is retried either the driver has been unregistered or its probe function has been set to platform_drv_probe_fail. With commit e9354576 (gpiolib:

Re: [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe

2013-09-23 Thread Sascha Hauer
On Mon, Sep 23, 2013 at 05:20:18PM +0200, Johan Hovold wrote: On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote: On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote: Deferred probing cannot be used with platform_driver_probe as by the time probing is retried either

[PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-12 Thread Sascha Hauer
on the usbmisc_imx driver. Also instead of letting the usbmisc_imx driver call back into the ci_hdrc_imx driver, pass the needed data in the first place. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci_hdrc_imx.c | 71 +--- drivers/usb/chipidea/ci_hdrc_imx.h

[PATCH v2] USB chipidea i.MX: Fix module loading

2013-08-12 Thread Sascha Hauer
for i.MX23/28 as suggested by Peter Chen Sascha Hauer (2): USB: chipidea: i.MX: remove unused define USB: chipidea: i.MX: simplify usbmisc drivers/usb/chipidea/ci_hdrc_imx.c | 74 + drivers

[PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-12 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 14362c0..11ed423 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b

[PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-09 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 14362c0..11ed423 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b

[PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-09 Thread Sascha Hauer
on the usbmisc_imx driver. Also instead of letting the usbmisc_imx driver call back into the ci_hdrc_imx driver, pass the needed data in the first place. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci_hdrc_imx.c | 74 +++-- drivers/usb/chipidea/ci_hdrc_imx.h

[PATCH] USB chipidea i.MX: Fix module loading

2013-08-09 Thread Sascha Hauer
The Chipidea i.MX driver has some issues with module loading dependencies. This fixes this. It is an alternative approach to the one Peter Chen suggested that does without changing the dt binding. Sascha Sascha Hauer (2): USB

Re: [PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-09 Thread Sascha Hauer
On Fri, Aug 09, 2013 at 06:25:29PM +0800, Peter Chen wrote: -void usbmisc_unset_ops(const struct usbmisc_ops *ops) -{ - usbmisc_ops = NULL; -} -EXPORT_SYMBOL_GPL(usbmisc_unset_ops); - -int usbmisc_get_init_data(struct device *dev, struct usbmisc_usb_device *usbdev) +static

Re: [PATCH v2 5/5] arm: dts: imx: Delete usbmisc_imx

2013-08-08 Thread Sascha Hauer
On Thu, Aug 08, 2013 at 03:33:01PM +0800, Peter Chen wrote: Since ci_hdrc_imx and usbmisc_imx has relationship between each other, they can't be existed as two modules. We change the code, and make the usbmisc_imx has no longer a driver. Due to above reason, we introduce non core register

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: At former design, both ci_hdrc_imx and usbmisc_imx are individual module, ci_hdrc_imx is glue layer for imx usb driver. usbmisc_imx handles non-core registers which has different register layout for imx SoC serials, it usually

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 03:00:05PM +0800, Peter Chen wrote: On Wed, Aug 07, 2013 at 10:15:22AM +0200, Sascha Hauer wrote: On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: At former design, both ci_hdrc_imx and usbmisc_imx are individual module, ci_hdrc_imx is glue layer for imx

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: - - reg = usbmisc-base + MX25_USB_PHY_CTRL_OFFSET; - - if (usbdev-evdo) { - spin_lock_irqsave(usbmisc-lock, flags); - val = readl(reg); - writel(val | MX25_BM_EXTERNAL_VBUS_DIVIDER, reg);

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 03:54:06PM +0800, Peter Chen wrote: On Wed, Aug 07, 2013 at 11:08:45AM +0200, Sascha Hauer wrote: - Convert imx-usb-misc from a driver into something which is called directly - add aliases - change devicetree bindings (which causes pain and it's

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 01:34:37PM +0800, Peter Chen wrote: diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt index b4b5b79..13720a2 100644 --- a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt +++

Re: [PATCH 1/1] usb: chipidea: imx: include usbmisc_imx.c in ci_hdrc_imx.c

2013-08-07 Thread Sascha Hauer
On Wed, Aug 07, 2013 at 05:24:45PM +0800, Peter Chen wrote: On Wed, Aug 07, 2013 at 12:05:07PM +0200, Sascha Hauer wrote: We need to know controller number, like pdev-id in the past. The registers at non core register is messy, the specific bit is for specific controller

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sascha Hauer
On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you

Re: [PATCH v12 02/13] usb: chipidea: imx: remove vbus regulator operation

2013-07-11 Thread Sascha Hauer
On Thu, Jul 11, 2013 at 02:27:10PM +0800, Peter Chen wrote: Since we have added vbus reguatlor operation at common host file (chipidea/host.c), the glue layer vbus operation isn't needed any more. Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci_hdrc_imx.c |

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Sascha Hauer
On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This patch makes it possible to set the chipidea udc into full-speed only mode. It can be set by the oftree property force-full-speed. [...] +/* force full-speed operation

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Sascha Hauer
On Sat, Jun 01, 2013 at 10:19:32AM +0200, Michael Grzeschik wrote: On Sat, Jun 01, 2013 at 09:39:33AM +0200, Sascha Hauer wrote: On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This patch makes it possible to set

Re: About usbmisc_imx.c at chipidea driver

2013-05-15 Thread Sascha Hauer
On Wed, May 15, 2013 at 01:34:31PM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Hi Michael Marc, Recently, I have worked at i.mx USB loadable module support for chipidea driver, it needs to write non-core register during the ci13xxx_imx remove

Re: About usbmisc_imx.c at chipidea driver

2013-05-15 Thread Sascha Hauer
On Wed, May 15, 2013 at 01:59:39PM +0300, Alexander Shishkin wrote: Sascha Hauer s.ha...@pengutronix.de writes: On Wed, May 15, 2013 at 01:34:31PM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Hi Michael Marc, Recently, I have worked at i.mx USB

Re: [PATCH v10 6/8] usb: chipidea: imx: add internal vbus regulator control

2013-02-27 Thread Sascha Hauer
On Wed, Feb 27, 2013 at 09:55:10AM +0200, Felipe Balbi wrote: Hi, On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote: - For host, the vbus should always be on. - For otg, the vbus is off defaultly, the vbus needs to be turned on/off when usb role switches. Signed-off-by:

Re: [PATCH 2/9] USB: move bulk of otg/otg.c to phy/phy.c

2013-02-19 Thread Sascha Hauer
On Tue, Feb 19, 2013 at 11:30:19AM +0200, Felipe Balbi wrote: On Mon, Feb 04, 2013 at 02:24:28PM +0100, Sascha Hauer wrote: Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reported-by: Kishon

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-15 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 09:36:26PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 14, 2013 at 07:30:26PM +0100, Sascha Hauer wrote: yeah, this is why I said we should ignore dr_mode (or bail out) when !OTG. Ok, that's what the patch effectively does. We have

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 11:58:22AM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 14, 2013 at 10:49:44AM +0100, Marc Kleine-Budde wrote: diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c index d29503e..ad4d87d 100644 --- a/drivers/usb/usb-common.c +++

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 12:15:10PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 14, 2013 at 11:07:22AM +0100, Sascha Hauer wrote: @@ -32,4 +35,37 @@ const char *usb_speed_string(enum usb_device_speed speed) } EXPORT_SYMBOL_GPL(usb_speed_string); +#ifdef

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 03:10:15PM +0200, Felipe Balbi wrote: On Thu, Feb 14, 2013 at 12:24:49PM +0100, Sascha Hauer wrote: On Thu, Feb 14, 2013 at 12:15:10PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 14, 2013 at 11:07:22AM +0100, Sascha Hauer wrote: @@ -32,4 +35,37 @@ const

Re: [PATCH 1/2] USB mxs-phy: Register phy with framework

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 12:37:29PM +0200, Felipe Balbi wrote: Hi, On Thu, Jan 31, 2013 at 12:32:16PM +0100, Sascha Hauer wrote: We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Signed-off-by: Sascha Hauer s.ha

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-14 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 08:04:44PM +0200, Felipe Balbi wrote: Hi, On Thu, Feb 14, 2013 at 05:06:55PM +0100, Sascha Hauer wrote: Maybe we can ignore dr_mode in host-only and device-only builds and only look at it for DRD builds ? If something

Re: [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-12 Thread Sascha Hauer
On Thu, Feb 07, 2013 at 11:56:32AM +0100, Sascha Hauer wrote: Alexander, Did you have a chance to look at this series? Development of this driver has stalled for too long now, I don't want to miss the next merge window. Alexander, Any comments? Thanks Sascha Thanks Sascha On Mon

Re: [PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-07 Thread Sascha Hauer
Alexander, Did you have a chance to look at this series? Development of this driver has stalled for too long now, I don't want to miss the next merge window. Thanks Sascha On Mon, Feb 04, 2013 at 02:24:26PM +0100, Sascha Hauer wrote: 4th round of patches. Peter, I would be glad if you

Re: [PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-05 Thread Sascha Hauer
On Tue, Feb 05, 2013 at 03:45:12PM +0400, Sergei Shtylyov wrote: Hello. On 04-02-2013 17:24, Sascha Hauer wrote: Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_imx.c | 39 +--- 1 file changed, 18 insertions

[PATCH 6/9] USB chipidea: introduce dual role mode pdata flags

2013-02-04 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/core.c | 21

[PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-04 Thread Sascha Hauer
helpers for determining dr_mode and phy_type USB: chipidea: ci13xxx-imx: create dynamic platformdata USB: chipidea: add PTW and PTS handling Sascha Hauer (5): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea i.MX

[PATCH 4/9] USB: chipidea: ci13xxx-imx: create dynamic platformdata

2013-02-04 Thread Sascha Hauer
...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reviewed-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci13xxx_imx.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb

[PATCH 7/9] USB chipidea i.MX: introduce dr_mode property

2013-02-04 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reviewed-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb

[PATCH 5/9] USB: chipidea: add PTW and PTS handling

2013-02-04 Thread Sascha Hauer
m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h| 14 ++- drivers/usb/chipidea/ci13xxx_imx.c

[PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-04 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_imx.c | 39 +--- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index b598bb8f..136869b

[PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-04 Thread Sascha Hauer
m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/phy/Makefile |1 + drivers/usb/phy/of.c | 47 ++ drivers/usb/usb-common.c | 36 +++ include/linux/usb/of.h | 27

[PATCH 2/9] USB: move bulk of otg/otg.c to phy/phy.c

2013-02-04 Thread Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reported-by: Kishon Vijay Abraham I kis...@ti.com Cc: Felipe Balbi ba...@ti.com --- drivers/usb/otg/otg.c| 427

Re: [PATCH v3] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-01 Thread Sascha Hauer
Apparantly I was not fully awake while sending this series :( On Fri, Feb 01, 2013 at 08:52:03AM +0100, Sascha Hauer wrote: (resend because I got the linux-usb address wrong) Here's another round of the dr_mode/phy_type patches. I think they should be ready for merging now. Greg, will you

Re: [PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:30:36AM +0800, Peter Chen wrote: On Wed, Jan 30, 2013 at 04:29:38PM +0100, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type

[PATCH v2] Add USB of helpers and use them in the chipidea driver

2013-01-31 Thread Sascha Hauer
dynamic platformdata USB: chipidea: add PTW and PTS handling Sascha Hauer (3): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea i.MX: introduce dr_mode property .../devicetree/bindings/usb/ci13xxx-imx.txt|6

[PATCH 4/6] USB: chipidea: add PTW and PTS handling

2013-01-31 Thread Sascha Hauer
m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h| 14 ++- drivers/usb/chipidea/ci13xxx_imx.c

[PATCH 1/6] USB: move bulk of otg/otg.c to phy/phy.c

2013-01-31 Thread Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it to the phy directory. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reported-by: kishon kis...@ti.com Cc: Felipe Balbi ba...@ti.com --- drivers/usb/otg/otg.c| 423 - drivers

[PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/phy/Makefile |1 + drivers/usb/phy/phy.c| 10 ++ drivers/usb/usb-common.c | 36 include/linux/usb/of.h | 27 +++ include/linux

[PATCH 6/6] USB chipidea i.MX: introduce dr_mode property

2013-01-31 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- Documentation/devicetree/bindings/usb/ci13xxx-imx.txt |1 + drivers/usb/chipidea

[PATCH 5/6] USB chipidea: introduce dual role mode pdata flags

2013-01-31 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/core.c | 21

[PATCH 3/6] USB: chipidea: ci13xxx-imx: create dynamic platformdata

2013-01-31 Thread Sascha Hauer
...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_imx.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index 8c29122..69024e0 100644

Re: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:20:59AM +0100, Greg KH wrote: On Thu, Jan 31, 2013 at 10:01:09AM +0100, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type

Re: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 02:42:48PM +0530, kishon wrote: Hi, On Thursday 31 January 2013 02:31 PM, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:15:54AM +0100, Matthieu CASTET wrote: Why you don't implement it ? If you don't implement it, I believe you should add a warning in order to catch it when used with lpm devices. I'm against adding a warning because current users seem to go well without

Re: [PATCH 2/6] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 06:01:08PM +0800, Peter Chen wrote: On Thu, Jan 31, 2013 at 10:01:09AM +0100, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de + for (i = 0; i ARRAY_SIZE(usb_dr_modes); i++) + if (!strcmp(dr_mode, usb_dr_modes[i

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 10:05:44AM +0800, Peter Chen wrote: On Wed, Jan 30, 2013 at 03:00:15PM +0100, Sascha Hauer wrote: On Wed, Jan 30, 2013 at 10:06:28AM +0800, Peter Chen wrote: On Tue, Jan 29, 2013 at 01:55:04PM +0200, Alexander Shishkin wrote: Sascha Hauer s.ha...@pengutronix.de

[PATCH] USB chipidea i.MX: use framework phy handling

2013-01-31 Thread Sascha Hauer
Sascha Hauer (2): USB mxs-phy: Register phy with framework USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy drivers/usb/chipidea/ci13xxx_imx.c | 31 ++- drivers/usb/otg/mxs-phy.c

[PATCH 1/2] USB mxs-phy: Register phy with framework

2013-01-31 Thread Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/otg/mxs-phy.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b

[PATCH 2/2] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-01-31 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_imx.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index b598bb8f..1df4b41 100644

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
On Fri, Feb 01, 2013 at 09:11:54AM +0800, Peter Chen wrote: On Thu, Jan 31, 2013 at 11:29:13AM +0100, Sascha Hauer wrote: On Thu, Jan 31, 2013 at 10:05:44AM +0800, Peter Chen wrote: On Wed, Jan 30, 2013 at 03:00:15PM +0100, Sascha Hauer wrote: On Wed, Jan 30, 2013 at 10:06:28AM +0800

Re: [PATCH] USB chipidea i.MX: use framework phy handling

2013-01-31 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 12:32:15PM +0100, Sascha Hauer wrote: This series switches the mxs phy and the i.MX chipidea support from homegrew phy support to use usb_add_phy_dev/devm_usb_get_phy_by_phandle. Based on [PATCH v2] Add USB of helpers and use them in the chipidea driver But I

[PATCH 7/9] como fec wip

2013-01-31 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- Documentation/devicetree/bindings/net/fsl-fec.txt | 20 ++ drivers/net/ethernet/freescale/fec.c | 77 - drivers/net/ethernet/freescale/fec.h |1 + 3 files changed, 67 insertions(+), 31

[PATCH 5/9] USB chipidea: introduce dual role mode pdata flags

2013-01-31 Thread Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows to explicitly set the core to host/peripheral mode. Without these flags the driver falls back to the old behaviour. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/core.c | 21

[PATCH 3/9] USB: chipidea: ci13xxx-imx: create dynamic platformdata

2013-01-31 Thread Sascha Hauer
...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reviewed-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/ci13xxx_imx.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb

[PATCH 8/9] USB mxs-phy: Register phy with framework

2013-01-31 Thread Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/otg/mxs-phy.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/otg/mxs-phy.c b

[PATCH v3] USB: add devicetree helpers for determining dr_mode and phy_type

2013-01-31 Thread Sascha Hauer
for determining dr_mode and phy_type USB: chipidea: ci13xxx-imx: create dynamic platformdata USB: chipidea: add PTW and PTS handling Sascha Hauer (6): USB: move bulk of otg/otg.c to phy/phy.c USB chipidea: introduce dual role mode pdata flags USB chipidea i.MX: introduce

[PATCH 4/9] USB: chipidea: add PTW and PTS handling

2013-01-31 Thread Sascha Hauer
m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h| 14 ++- drivers/usb/chipidea/ci13xxx_imx.c

[PATCH 6/9] USB chipidea i.MX: introduce dr_mode property

2013-01-31 Thread Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the host/peripheral/otg mode. This is necessary for boards without proper ID pin handling. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Reviewed-by: Peter Chen peter.c...@freescale.com --- Documentation/devicetree/bindings/usb

[PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-01-31 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/usb/chipidea/ci13xxx_imx.c | 31 ++- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xxx_imx.c index b598bb8f..1df4b41 100644

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
On Wed, Jan 30, 2013 at 11:21:35AM +0530, kishon wrote: On Wednesday 30 January 2013 02:00 AM, Sascha Hauer wrote: On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote: Hi, On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
On Wed, Jan 30, 2013 at 10:06:28AM +0800, Peter Chen wrote: On Tue, Jan 29, 2013 at 01:55:04PM +0200, Alexander Shishkin wrote: Sascha Hauer s.ha...@pengutronix.de writes: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions

[PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Sascha Hauer
m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 +++ drivers/usb/chipidea/bits.h|7 drivers/usb/chipidea/ci13xxx_imx.c

[PATCH] Add USB of helpers and use them in the chipidea driver

2013-01-30 Thread Sascha Hauer
Michael Grzeschik (3): usb: add devicetree helpers for determining dr_mode and phy_type usb: chipidea: ci13xxx-imx: create dynamic platformdata usb: chipidea: add PTW and PTS handling Sascha Hauer (2): USB chipidea: introduce dual role mode pdata flags

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Sascha Hauer
On Wed, Jan 30, 2013 at 05:54:54PM +0100, Matthieu CASTET wrote: diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 57cae1f..dcb650f 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -67,6 +67,8 @@ #include linux/usb/gadget.h

Re: [PATCH 2/6] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-30 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 11:44:21AM +0530, kishon wrote: Hi, On Wednesday 30 January 2013 08:59 PM, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi

Re: [PATCH 4/6] usb: chipidea: add PTW and PTS handling

2013-01-30 Thread Sascha Hauer
On Thu, Jan 31, 2013 at 11:08:54AM +0800, Peter Chen wrote: On Wed, Jan 30, 2013 at 04:29:40PM +0100, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de +static void hw_phymode_configure(struct ci13xxx *ci) +{ + u32 portsc; + + /* +* The lpm version

[PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Sascha Hauer
From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from the devicetree. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Sascha Hauer
On Tue, Jan 29, 2013 at 07:14:51PM +0530, kishon wrote: Hi, On Tuesday 29 January 2013 04:52 PM, Sascha Hauer wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de This adds two little devicetree helper functions for determining the dr_mode (host, peripheral, otg) and phy_type (utmi

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Sascha Hauer
On Tue, Jan 22, 2013 at 03:38:55PM +, Arnd Bergmann wrote: On Tuesday 22 January 2013, Alan Stern wrote: In order to prevent this, you have to make sure that each glue driver depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround the Kconfig entries for those drivers with

  1   2   >