Re: 3.2.63-longterm: unloading vhci-hcd tries to free already-free IRQ 0

On Thu, 9 Oct 2014, Thomas Bork wrote: Hi @all, loading and unloading vhci-hcd in 3.2.63-longterm produces a warning in syslog (Trying to free already-free IRQ 0). I know vhci-hcd is staging but backporting as much as possible changes of usbip from 3.16.4 (without the switch to udev)

[PATCH 1/3] uwb: line length cleanup

Fix line length in uwb-internal.h Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/uwb-internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/uwb/uwb-internal.h b/drivers/uwb/uwb-internal.h index 9a103b1..6d1bed1 100644 --- a/drivers/uwb

[PATCH 3/3] uwb: remove UWB build dependency on PCI

UWB does not require PCI to be enabled so remove build dependency. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/uwb/Kconfig b/drivers/uwb/Kconfig index 2431eed..c204094 100644 --- a/drivers/uwb/Kconfig

[PATCH 2/3] uwb: update uwb device prints to be more useful

Print info about the radio controller device instead of the its parent when UWB devices connect and disconnect. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/lc-dev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/uwb/lc-dev.c b

[PATCH 0/3] uwb: minor cleanups

Some UWB cleanups for 3.18 Thomas Pugliese (3): uwb: line length cleanup uwb: update uwb device prints to be more useful uwb: remove UWB build dependency on PCI drivers/uwb/Kconfig| 1 - drivers/uwb/lc-dev.c | 8 drivers/uwb/uwb-internal.h | 3 ++- 3 files changed

[PATCH 1/2] uwb: create a uwb bus type and add in-range peer devices to it

bus type and adds UWB peer devices to it as they are discovered by the radio controller. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/driver.c | 11 +++ drivers/uwb/lc-dev.c | 11 +++ drivers/uwb/uwb-internal.h | 1 + 3 files changed, 19

[PATCH 2/2] uwb: doc: bring uwb documentation up to date

removed. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- Documentation/usb/WUSB-Design-overview.txt | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/Documentation/usb/WUSB-Design-overview.txt b/Documentation/usb/WUSB-Design-overview.txt index

[PATCH 0/2] uwb: add a bus for uwb devices

Create a system bus for UWB devices and add in-range UWB devices to it as they are detected. Prior to this change, UWB devices were added to the device tree, but since they did not exist on a bus, they would be enumerated by udev. Thomas Pugliese (2): uwb: create a uwb bus type and add

[PATCH 0/2] add an ASIE sysfs attribute to uwb_rc devices

Add an ASIE sysfs attribute to uwb_rc devices. This allows user mode to add and remove application specific information elements (ASIEs) to the beacon of a uwb_rc device. Thomas Pugliese (2): uwb: add an ASIE sysfs attribute to uwb_rc devices uwb: doc: add documentation for ASIE sysfs

[PATCH 2/2] uwb: doc: add documentation for ASIE sysfs attribute

Document the /sys/class/uwb_rc/uwbN/ASIE sysfs attribute Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- Documentation/ABI/testing/sysfs-class-uwb_rc | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-class-uwb_rc b/Documentation/ABI

[PATCH 1/2] uwb: add an ASIE sysfs attribute to uwb_rc devices

Allow user mode to add and remove application specific information elements (ASIEs) to the beacon of a uwb_rc device. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/lc-rc.c | 99 + 1 file changed, 99 insertions

[PATCH 2/3] usb: wusbcore: remove USB_WUSB build dependency on PCI

Wireless USB does not require PCI so remove USB_WUSB build dependency on PCI. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig index 0e17b96

[PATCH 3/3] usb: wusbcore: USB_WUSB_CBAF depends on USB

Add USB build dependency for USB_WUSB_CBAF. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig index f5c92f6..348de1d 100644 --- a/drivers/usb

[PATCH 1/3] usb: hwa: add USB build dependency for USB_HWA_HCD

An HWA is a USB device so it depends on USB. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 82800a7..64805d9 100644 --- a/drivers

[PATCH 0/3] wusb build dependency fixes

Fix build dependencies for WUSB devices. Thomas Pugliese (3): usb: hwa: add USB build dependency for USB_HWA_HCD usb: wusbcore: remove USB_WUSB build dependency on PCI usb: wusbcore: USB_WUSB_CBAF depends on USB drivers/usb/host/Kconfig | 2 +- drivers/usb/wusbcore/Kconfig | 2 +- 2

[PATCH] usb: wusbcore: skip done segs before completing aborted transfer

When completing an aborted transfer, skip done segs before calling wa_complete_remaining_xfer_segs to avoid a runtime warning. The warning is harmless in this case but avoiding it prevents false error reports. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore

Re: [PATCH 3/3] usb: wusbcore: fix below build warning

On Mon, 18 Aug 2014, Peter Chen wrote: linux-2.6/drivers/usb/wusbcore/wa-xfer.c: In function 'wa_buf_in_cb': linux-2.6/drivers/usb/wusbcore/wa-xfer.c:2590: warning: 'rpipe' may be used uninitialized in this function Signed-off-by: Peter Chen peter.c...@freescale.com ---

[PATCH] uwb: init beacon cache entry before registering uwb device

had a chance to set the beacon cache entry. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com Cc: sta...@vger.kernel.org --- drivers/uwb/lc-dev.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/uwb/lc-dev.c b/drivers/uwb/lc-dev.c index 80079b8

[PATCH 0/3] uwb: formatting and compile warning fixes

This set contains a few fixes for formatting issues and compile warnings in UWB. Some of the changes for lines over 80 chars required pulling deeply nested code into separate functions which makes that patch look more significant than it really is. Thomas Pugliese (3): uwb: whitespace

[PATCH 3/3] uwb: fix variable set but not used warnings

Fix variable set but not used warnings in UWB. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/beacon.c | 3 --- drivers/uwb/est.c| 2 -- drivers/uwb/ie-rcv.c | 2 -- 3 files changed, 7 deletions(-) diff --git a/drivers/uwb/beacon.c b/drivers/uwb/beacon.c index

[PATCH 2/3] uwb: comment typo fix

Comment typo fix. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/radio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/uwb/radio.c b/drivers/uwb/radio.c index fd23d98..2427e94 100644 --- a/drivers/uwb/radio.c +++ b/drivers/uwb/radio.c

[PATCH 1/3] uwb: whitespace and line length cleanups

Fix whitespace and line length issues reported by checkpatch. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/drp.c | 294 ++ 1 file changed, 166 insertions(+), 128 deletions(-) diff --git a/drivers/uwb/drp.c b/drivers

[PATCH 2/2] uwb: add error messages when reservation establish fails

Add better error messages during the channel change/reservation establish process. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/beacon.c | 4 +++- drivers/uwb/rsv.c| 14 -- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/uwb

[PATCH 0/2] fix channel change failure

Fix an intermittent failure when changing channels and report better errors during the channel change process. Thomas Pugliese (2): uwb: fix channel change failure uwb: add error messages when reservation establish fails drivers/uwb/beacon.c | 4 +++- drivers/uwb/rsv.c| 21

[PATCH] usb: wusbcore: fix panic in wusbhc_chid_set

If no valid CHID value has previously been set on an HWA, writing a value of all zeros will cause a kernel panic in uwb_radio_stop because wusbhc-uwb_rc has not been set. This patch skips the call to uwb_radio_stop if wusbhc-uwb_rc has not been initialized. Signed-off-by: Thomas Pugliese

[PATCH] usb: wusbcore: convert nested lock to use spin_lock instead of spin_lock_irq

Nesting a spin_lock_irq/unlock_irq inside a lock that has already disabled interrupts will enable interrupts before we are ready when spin_unlock_irq is called. This patch converts the inner lock to use spin_lock and spin_unlock instead. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com

Re: [PATCH] uvc: update uvc_endpoint_max_bpi to handle USB_SPEED_WIRELESS devices

On Thu, 17 Apr 2014, Laurent Pinchart wrote: Hi Thomas, On Wednesday 16 April 2014 12:29:22 Thomas Pugliese wrote: On Wed, 16 Apr 2014, Laurent Pinchart wrote: Hi Thomas, (CC'ing the linux-usb mailing list) On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote

Re: [PATCH] uvc: update uvc_endpoint_max_bpi to handle USB_SPEED_WIRELESS devices

On Wed, 16 Apr 2014, Laurent Pinchart wrote: Hi Thomas, (CC'ing the linux-usb mailing list) On Tuesday 15 April 2014 16:45:28 Thomas Pugliese wrote: On Tue, 15 Apr 2014, Laurent Pinchart wrote: Hi Thomas, Could you please send me a proper revert patch with the above

Re: [PATCH] staging: octeon-usb: prevent memory corruption

|= URB_ALIGNED_TEMP_BUFFER; + + return 0; +} + I don't think you need the temp_buffer in struct octeon_temp_buffer. Once you have temp in octeon_free_temp_buffer via container_of, just free temp. There is no need to look at temp_buffer to get its address. Thomas Pugliese -- To unsubscribe from

Re: [PATCH 2/3] usb: wusbcore: combine iso transfer result frame reads when possible

On Fri, 7 Mar 2014, Greg KH wrote: On Thu, Mar 06, 2014 at 12:53:38PM -0600, Thomas Pugliese wrote: When reading the transfer result data for an isochronous in request, if the current frame actual_length is contiguous with the next frame and actual_length is a multiple of the DTI

[PATCH v2 0/2] usb: wusbcore: HWA performance optimizations

This is a resend of two previously sent patches that failed to apply This series includes a set of performance optimizations for the HWA which improve webcam image quality and CPU utilization for isochronous read transfers. Thomas Pugliese (2): usb: wusbcore: combine iso transfer result

[PATCH v2 2/2] usb: wusbcore: use multiple urbs for HWA iso transfer result frame reads

-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-hc.c | 2 - drivers/usb/wusbcore/wa-hc.h | 15 +++- drivers/usb/wusbcore/wa-xfer.c | 191 ++--- 3 files changed, 134 insertions(+), 74 deletions(-) diff --git a/drivers/usb/wusbcore/wa

[PATCH 0/3] usb: wusbcore: HWA performance optimizations

transfers. Thomas Pugliese (3): usb: wusbcore: disable transfer notifications for Alereon HWAs usb: wusbcore: combine iso transfer result frame reads when possible usb: wusbcore: use multiple urbs for HWA iso transfer result frame reads drivers/usb/host/hwa-hc.c | 42 - drivers/usb

[PATCH 3/3] usb: wusbcore: use multiple urbs for HWA iso transfer result frame reads

-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-hc.c | 2 - drivers/usb/wusbcore/wa-hc.h | 15 +++- drivers/usb/wusbcore/wa-xfer.c | 191 ++--- 3 files changed, 134 insertions(+), 74 deletions(-) diff --git a/drivers/usb/wusbcore/wa

[PATCH 2/3] usb: wusbcore: combine iso transfer result frame reads when possible

of URBs that must be submitted in that case which increases performance and reduces CPU interrupt overhead. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 104 + 1 file changed, 75 insertions(+), 29 deletions

[PATCH 1/3] usb: wusbcore: disable transfer notifications for Alereon HWAs

is successful, the DTI system is started immediately since that would normally be started upon the first reception of a transfer notification which will no longer be sent. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/host/hwa-hc.c | 42 - drivers

[PATCH 1/2] usb: wusbcore: fix potential double list_del on urb dequeue

the rpipe seg_list twice leading to memory corruption. It also switches the spin_lock call to use the non-irqsave version since the xfer-lock is already held and irqs already disabled. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 8 ++-- 1 file

[PATCH 0/2] usb: wusbcore: additional urb dequeue cleanups

Fix two race conditions that could cause memory corruption when unlinking WUSB urbs. Thomas Pugliese (2): usb: wusbcore: fix potential double list_del on urb dequeue usb: wusbcore: don't mark WA_SEG_DTI_PENDING segs as done in urb_dequeue drivers/usb/wusbcore/wa-xfer.c | 19

[PATCH 2/2] usb: wusbcore: don't mark WA_SEG_DTI_PENDING segs as done in urb_dequeue

-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 1cd0f61..12b764e 100644 --- a/drivers/usb/wusbcore/wa-xfer.c +++ b/drivers

[PATCH 4/4] usb: wusbcore: add a convenience function for completing a transfer segment

. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 48 -- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 5e5343e..3d6b30d 100644

[PATCH 2/4] usb: wusbcore: fix stranded URB after HWA unplug

is unplugged while playing audio to a wireless audio device. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 56 ++ 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers

[PATCH 3/4] usb: wusbcore: prevent urb dequeue and giveback race

in urb_dequeue means that any other place where a submitted transfer segment is marked as done must complete the transfer if it is done. __wa_xfer_delayed_run was not checking this case so that check was added as well. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa

[PATCH 1/4] usb: wusbcore: fix kernel panic on HWA unplug

while data is being transferred to a wireless device. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 48 ++ 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers

[PATCH 0/4] usb: wusbcore: HWA unplug and URB dequeue fixes

This set of patches fixes some issues with the URB dequeue process in the HWA. In particular, problems that occur when unplugging the HWA dongle while transferring data to a device. The last patch in the set is just code cleanup to hopefully make this case a little less error prone. Thomas

[PATCH] usb: wusbcore: add info to HWA debug prints

This patch adds a debug print in the transfer dequeue case where a transfer result arrives for a transfer that has already been cleaned up. It also adds the transfer ID to some debug prints and prints error codes as signed integers in a couple of others. Signed-off-by: Thomas Pugliese

[PATCH] usb: wusbcore: read actual_length bytes isoc in segments

in the driver preventing module unload and clean shutdown. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 7c9887c..0636206

[PATCH] usb: wusbcore: adjust iterator correctly when searching for ep comp descriptor

but the remaining size value 'itr_size' is decremented by the bDescriptorType field which is incorrect. This patch fixes the loop to decrement itr_size by bLength as it should. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-rpipe.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: request for pointer to documentation on WUSB

On Fri, 28 Feb 2014, Oliver Neukum wrote: On Thu, 2014-02-27 at 11:51 -0600, Thomas Pugliese wrote: On Thu, 27 Feb 2014, Oliver Neukum wrote: On Thu, 2014-02-27 at 10:46 -0600, Thomas Pugliese wrote: I could be wrong about the chipset. If I recall correctly, IOGear has

[PATCH] usb: wusbcore: fix compile warnings

Fix pointer targets differ in signedness and variable set but not used warnings Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/devconnect.c | 4 +--- drivers/usb/wusbcore/wa-xfer.c| 6 ++ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git

Re: request for pointer to documentation on WUSB

On Thu, 27 Feb 2014, Oliver Neukum wrote: On Tue, 2014-02-25 at 14:26 -0600, Thomas Pugliese wrote: Hi Oliver, 1. Start the wireless channel by storing a CHID value to the host controller's wusb_chid sysfs attribute. That unfortunately fails: [66488.705043] usb 1-1.2: new high

Re: request for pointer to documentation on WUSB

On Thu, 27 Feb 2014, Oliver Neukum wrote: On Thu, 2014-02-27 at 08:05 -0600, Thomas Pugliese wrote: On Thu, 27 Feb 2014, Oliver Neukum wrote: I believe that device is based on an older Alereon chipset which along with most other HWAs uses the updated WHCI protocol for UWB

Re: request for pointer to documentation on WUSB

On Thu, 27 Feb 2014, Oliver Neukum wrote: On Thu, 2014-02-27 at 10:46 -0600, Thomas Pugliese wrote: I could be wrong about the chipset. If I recall correctly, IOGear has used multiple chipset vendors across different products. Do you have a link to the product page for the device

Re: request for pointer to documentation on WUSB

On Tue, 25 Feb 2014, Oliver Neukum wrote: Hi, does anybody have a pointer to documentation on how to setup a WUSB connection? Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

On Wed, 22 Jan 2014, Shuah Khan wrote: Add speed strings for usb wireless and 3.0 to speed_strings array. Signed-off-by: Shuah Khan shuah...@samsung.com --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

On Fri, 24 Jan 2014, Shuah Khan wrote: On 01/24/2014 10:08 AM, Thomas Pugliese wrote: On Wed, 22 Jan 2014, Shuah Khan wrote: Add speed strings for usb wireless and 3.0 to speed_strings array. Signed-off-by: Shuah Khan shuah...@samsung.com --- drivers/staging/usbip

[PATCH] usb: wusbcore: add debug prints to reservation and channel change

This patch adds debug prints to the reservation and channel change sequence to help with debugging channel change problems. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/pal.c |1 + drivers/usb/wusbcore/reservation.c |1 + 2 files changed, 2

[PATCH 3/3] uwb: use uwb_rsv_callback instead of calling rsv-callback directly

Use uwb_rsv_callback wrapper instead of calling rsv-callback directly. uwb_rsv_callback checks for NULL and is used by other callers of the callback routine. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/rsv.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 0/3] uwb: minor cleanups

This patch set adds some debug prints, cleans up whitespace and comments and modifies one location to use the proper wrapper for calling reservation callbacks. Thomas Pugliese (3): uwb: add debug prints during channel change and beacon actions uwb: whitespace and comment cleanups uwb: use

[PATCH 1/3] uwb: add debug prints during channel change and beacon actions

Add debug prints during channel change and beacon actions. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/uwb/beacon.c |3 ++- drivers/uwb/radio.c |4 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/uwb/beacon.c b/drivers/uwb/beacon.c

[PATCH] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

beaconing process which can result in a failure to establish a reservation. It is safe to not hold the mutex in the non-error case since the only other place rc-uwb_dev.beacon_slot is accessed is in the same worker thread that uwbd_evt_handle_rc_bp_slot_change executes in. Signed-off-by: Thomas

Re: [PATCH] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

On Fri, 20 Dec 2013, David Cohen wrote: On Fri, Dec 20, 2013 at 11:55:53AM -0600, Thomas Pugliese wrote: Only acquire rc-uwb_dev.mutex in the error case in uwbd_evt_handle_rc_bp_slot_change. This fixes a bug where establishing a reservation on a new channel will fail if we were unable

[PATCH v2] uwb: move mutex_lock to error case in uwbd_evt_handle_rc_bp_slot_change

beaconing process which can result in a failure to establish a reservation. It is safe to not hold the mutex in the non-error case since the only other place rc-uwb_dev.beacon_slot is accessed is in the same worker thread that uwbd_evt_handle_rc_bp_slot_change executes in. Signed-off-by: Thomas

RE: [PATCH] usb: wusbcore: fix short transfers

On Tue, 10 Dec 2013, David Laight wrote: From: Thomas Pugliese Sent: 09 December 2013 19:11 To: linux-usb@vger.kernel.org Cc: gre...@linuxfoundation.org; Thomas Pugliese Subject: [PATCH] usb: wusbcore: fix short transfers If a URB is broken up into multiple transfer segments

[PATCH] usb: wusbcore: add isochronous IN support to HWA

This patch adds support for isochronous IN transfers to the HWA driver. The changes include removing the checks that return errors for isoc IN URBs and adding functionality to read the isoc data returned from the HWA. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb

[PATCH] usb: wusbcore: fix short transfers

. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 128 +++- 1 file changed, 74 insertions(+), 54 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index a88b8c6..673ad80 100644

[PATCH] usb: wusbcore: use USB_CTRL_SET_TIMEOUT and USB_CTRL_GET_TIMEOUT

Use USB_CTRL_SET_TIMEOUT and USB_CTRL_GET_TIMEOUT for USB control messages instead of an arbitrary 1s timeout value. This is particularly useful for WUSB since in the worst case RF scanario, a WUSB device can be unresponsive for up to 4s and still be connected. Signed-off-by: Thomas Pugliese

[PATCH] usb: core: get config and string descriptors for unauthorized devices

the config and string descriptors earlier in enumeration which is needed for some WUSB devices to function properly on Android systems. It also reduces the amount of divergent code paths needed for WUSB devices. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/core/config.c

[PATCH] usb: core: allow isoc URBs for wireless devices with an interval 6

In usb_submit_urb, do not fail if an isoc URB for a wireless USB device has an interval 6. Per WUSB spec, isoc endpoints can support values from 1-16. Valid values for interrupt URBs for wireless USB devices are still 6-16. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers

[PATCH 2/2] usb: wusbcore: set packet count correctly on isoc transfers

This patch correctly sets the dwNumOfPackets field of the HWA transfer request for isochronous transfers with multiple segments. Previously all segments used the value that was set for the first segment which may not be correct. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com

[PATCH 1/2] usb: wusbcore: move isoc_frame_index from wa_xfer to wa_seg

If multiple segments belonging to an isoc transfer are submitted concurrently, the isoc_frame_index field in struct wa_xfer can get corrupted. This patch moves the isoc_frame_index field from struct wa_xfer to struct wa_seg to prevent this from happening. Signed-off-by: Thomas Pugliese

[PATCH 0/2] usb: wusbcore isoc transfer fixes

This set includes two fixes for problems that can occur when isochronous transfers are split into multiple transfer segments. Thomas Pugliese (2): usb: wusbcore: move isoc_frame_index from wa_xfer to wa_seg usb: wusbcore: set packet count correctly on multi-segment isoc transfers

[PATCH 0/3] usb: wusbcore: connect/disconnect fixes

This set of patches fixes various problems that can occur when connecting and disconnecting Wireless USB devices. Thomas Pugliese (3): usb: wusbcore: send keepalives to unauthenticated devices usb: wusbcore: do device lookup while holding the hc mutex usb: wusbcore: fix deadlock

[PATCH 2/3] usb: wusbcore: do device lookup while holding the hc mutex

handlers get the device ptr if they need to after they have taken the mutex. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/devconnect.c | 43 + 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/drivers/usb/wusbcore

[PATCH 3/3] usb: wusbcore: fix deadlock in wusbhc_gtk_rekey

a deadlock in wa_urb_enqueue when it calls a device lookup helper function that takes the same lock. This patch changes wusbhc_gtk_rekey to submit a work item to set the GTK so that the URB is submitted without holding wusbhc-mutex. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb

[PATCH 1/3] usb: wusbcore: send keepalives to unauthenticated devices

to expect. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/devconnect.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/wusbcore/devconnect.c b/drivers/usb/wusbcore/devconnect.c index e538b72..d1af4e8 100644 --- a/drivers

Re: [PATCH 0/3] usb: wusbcore: connect/disconnect fixes

On Mon, 2 Dec 2013, Greg KH wrote: On Mon, Dec 02, 2013 at 03:39:42PM -0600, Thomas Pugliese wrote: This set of patches fixes various problems that can occur when connecting and disconnecting Wireless USB devices. Thomas Pugliese (3): usb: wusbcore: send keepalives

[PATCH 1/3] usb: wusbcore: add calls to usb_hcd_link_urb_to_ep, usb_hcd_unlink_urb_from_ep, and

Add calls to usb_hcd_link_urb_to_ep, usb_hcd_unlink_urb_from_ep, and usb_hcd_check_unlink_urb in the appropriate locations. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/host/hwa-hc.c |2 +- drivers/usb/wusbcore/wa-hc.h |2 +- drivers/usb/wusbcore/wa

[PATCH 3/3] usb: wusbcore: return -ENOENT for unlinked URBs.

Return -ENOENT for unlinked URBs. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 3220c62..a88b8c6

[PATCH 2/3] usb: wusbcore: add more info to debug prints in urb_unlink path

Add more info to debug prints in urb_unlink path Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa

[PATCH 0/3] usb: wusbcore: URB unlink cleanup

if the URB was canceled before completing. These could be candidates for 3.13rc2 as well. Thomas Pugliese (3): usb: wusbcore: add calls to usb_hcd_link_urb_to_ep, usb_hcd_unlink_urb_from_ep, and usb_hcd_check_unlink_urb usb: wusbcore: add more info to debug prints in urb_unlink case usb

Re: [PATCH 4/4] usb: wusbcore: change WA_SEGS_MAX to a legal value

On Thu, 24 Oct 2013, Greg KH wrote: On Thu, Oct 24, 2013 at 10:04:08AM +0200, Oliver Neukum wrote: On Wed, 2013-10-23 at 14:44 -0500, Thomas Pugliese wrote: change WA_SEGS_MAX to a number that is legal according to the WUSB spec. Signed-off-by: Thomas Pugliese thomas.pugli

[PATCH] usb: wusbcore: change WA_SEGS_MAX to a legal value

Change WA_SEGS_MAX to a number that is legal according to the WUSB spec and correct the test for exceeding this value. This patch is against 3.11.6 and is intended for -stable. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com Cc: sta...@vger.kernel.org --- drivers/usb/wusbcore/wa

[PATCH] usb: wusbcore: remove unneccessary byte-swap when assigning RPIPE wMaxPacketSize

This patch removes an unneccessary byte-swap when assigning RPIPE wMaxPacketSize. Both sides of the assignment are __le16 members of a USB descriptor so no byte swap is needed. This patch is against 3.11.6 and is intended for -stable. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com Cc

[PATCH 0/4] usb: wusbcore: HWA isoc enhancements

This patch set contains a few enhancements to isochronous support in the HWA which improve audio quality for wireless USB audio devices. These have been sitting in my testing branch for a few weeks and look to be solid. Thomas Pugliese (4): usb: wusbcore: set the RPIPE wMaxPacketSize value

[PATCH 2/4] usb: wusbcore: combine multiple isoc frames in a single transfer request.

. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 366 1 file changed, 255 insertions(+), 111 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 2bc6c80..16918e9

[PATCH 4/4] usb: wusbcore: change WA_SEGS_MAX to a legal value

change WA_SEGS_MAX to a number that is legal according to the WUSB spec. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore

[PATCH 3/4] usb: wusbcore: add a quirk for Alereon HWA device isoc behavior

Add a quirk for Alereon HWA devices to concatenate the frames of isoc transfer requests. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/host/hwa-hc.c | 13 --- drivers/usb/wusbcore/wa-hc.c |4 +++- drivers/usb/wusbcore/wa-hc.h | 13

[PATCH 1/4] usb: wusbcore: set the RPIPE wMaxPacketSize value correctly

For isochronous endpoints, set the RPIPE wMaxPacketSize value using wOverTheAirPacketSize from the endpoint companion descriptor instead of wMaxPacketSize from the normal endpoint descriptor. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-rpipe.c |5

[PATCH] usb: wusbcore: preserve endianness of cached descriptors

Do not overwrite the multi-byte fields of usb_wa_descriptor with their cpu format values after reading the descriptor. Leave the values as __le16 and swap on use. This is more consistent with other uses of USB descriptors. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers

[PATCH] usb: wusbcore: serialize access to the HWA data out endpoint

the RPIPEs that are waiting. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-hc.h| 10 ++- drivers/usb/wusbcore/wa-rpipe.c |9 ++- drivers/usb/wusbcore/wa-xfer.c | 154 +++ 3 files changed, 152 insertions(+), 21

Re: [PATCH] usb: wusbcore: add support for isoc out transfers

On Sat, 5 Oct 2013, Greg KH wrote: On Fri, Oct 04, 2013 at 10:40:45AM -0500, Thomas Pugliese wrote: This patch adds support for isochronous out transfers to the HWA. The primary changes are: 1. Add a isoc_pack_desc_urb field to struct wa_seg. This urb is used to send

[PATCH] usb: wusbcore: fix string formatting warnings on 64-bit builds

This patch fixes compile warnings on 64-bit builds that were introduced by the recent isoc changes. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/wusbcore/wa

[PATCH] usb: wusbcore: add support for isoc out transfers

packet status message are used to set the iso_frame_desc status and actual_length fields in the original isoc URB. This feature required the addition of a some state tracking variables in struct wahc so the dti_urb knows what type of packet it expects to receive next. Signed-off-by: Thomas

Re: [PATCH] sound: usb: add support for wireless USB devices

On Wed, 2 Oct 2013, Daniel Mack wrote: On 01.10.2013 21:32, Thomas Pugliese wrote: This patch updates snd_usb_audio_create also support devices whose speed == USB_SPEED_WIRELESS. Interesting. What device are you testing this with? Daniel The device I am testing with is a C

Re: [PATCH] usb: wusbcore: fix build warning on 64-bit builds

On Mon, 30 Sep 2013, Greg KH wrote: On Mon, Sep 30, 2013 at 10:48:46PM -0500, Thomas Pugliese wrote: Fix a build warning found by the kbuild test robot in the most recent wusbcore patches. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com You forgot a Reported-by: line here

[PATCH] usb: wusbcore: avoid stack overflow in URB enqueue error path

. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 51 ++-- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/drivers/usb/wusbcore/wa-xfer.c b/drivers/usb/wusbcore/wa-xfer.c index 6327df0..7a78240 100644

[PATCH 2/3] usb: wusbcore: set the RPIPE bOverTheAirInterval for isoc endpoints

This patch sets the RPIPE bOverTheAirInterval field for RPIPES which refer to isochronous endpoints. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-rpipe.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/wusbcore/wa

[PATCH] sound: usb: support wireless devices in snd_usb_parse_datainterval

Hi, This patch adds support for dev speed USB_SPEED_WIRELESS in snd_usb_parse_datainterval which allows the usb sound core to create ISO urbs with the correct number and size of buffers. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- sound/usb/helper.c |1 + 1 file changed

[PATCH] sound: usb: add support for wireless USB devices

This patch updates snd_usb_audio_create also support devices whose speed == USB_SPEED_WIRELESS. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- sound/usb/card.c |1 + 1 file changed, 1 insertion(+) diff --git a/sound/usb/card.c b/sound/usb/card.c index 64952e2..ef76aa0 100644

[PATCH] usb: wusbcore: clean up urb dequeue process

is dequeued after the driver has received the transfer result but before the data is received. Signed-off-by: Thomas Pugliese thomas.pugli...@gmail.com --- drivers/usb/wusbcore/wa-xfer.c | 122 1 file changed, 87 insertions(+), 35 deletions(-) diff --git

  1   2   >