Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c

2013-08-06 Thread Wei Shuai
Flashloader looks good. I totally agree put all these kind of simple drivers into one 2013/8/5 Dan Williams d...@redhat.com: On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple

RE: About TRB_TO_EP_INDEX() macro using

2013-08-06 Thread Du, ChangbinX
On Mon, Aug 05, 2013 at 08:07:25AM +, Du, ChangbinX wrote: Recently when I check xHCI code, find that some functions try to get EP index from a Command Completion Event TRB via TRB_TO_EP_INDEX() macro. This is totally wrong. The macro definition is: #define

Re: About TRB_TO_EP_INDEX() macro using

2013-08-06 Thread 'gre...@linuxfoundation.org'
On Tue, Aug 06, 2013 at 08:59:32AM +, Du, ChangbinX wrote: On Mon, Aug 05, 2013 at 08:07:25AM +, Du, ChangbinX wrote: Recently when I check xHCI code, find that some functions try to get EP index from a Command Completion Event TRB via TRB_TO_EP_INDEX() macro. This is

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-06 Thread Rupesh Gujare
On 05/08/13 21:23, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 07:43:16PM +0100, Rupesh Gujare wrote: On 05/08/13 18:53, Dan Carpenter wrote: On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: This patch fixes crash issue when there is quick cycle of de-enumeration enumeration

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-06 Thread Dan Carpenter
On Tue, Aug 06, 2013 at 11:26:14AM +0100, Rupesh Gujare wrote: I will work on it, once this patch series is applied to staging tree. I am assuming that you have no objection for it, I will follow up with above style nits in follow on patches. Yes. That's fine. regards, dan carpenter --

[PATCH] pn533: fix stack being used as URB transfer_buffer

2013-08-06 Thread Jussi Kivilinna
Patch fixes incorrect stack usage in pn533_send_ack(). Function currently sets stack as transfer_buffer (stack may not be dma-able, must not be used for URB buffers) and returns (stack buffer is still in use after function call). Patch is only compile tested. Cc: sta...@vger.kernel.org

[PATCH] i2c-tiny-usb: do not use stack as URB transfer_buffer

2013-08-06 Thread Jussi Kivilinna
Patch fixes i2c-tiny-usb not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/i2c/busses/i2c-tiny-usb.c | 49

[PATCH] zd1201: do not use stack as URB transfer_buffer

2013-08-06 Thread Jussi Kivilinna
Patch fixes zd1201 not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/net/wireless/zd1201.c |4 +++- 1 file changed, 3

[PATCH] rndis_host: do not use stack as URB transfer_buffer

2013-08-06 Thread Jussi Kivilinna
Patch fixes rndis_host not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/net/usb/rndis_host.c |8 ++-- 1 file changed, 6

Re: [PATCH 1/7] usb: phy: omap: Add new PHY types and remove omap_control_usb3_phy_power()

2013-08-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: TYPE2 meaning has changed. It is now a USB2 phy with Power down bit in control_dev_conf register. Introduce TYPE3 and TYPE4 PHY. TYPE3 is USB3 phy with DPLL and individual TX/RX power control. TYPE4 is USB2 phy with power aux

Re: [PATCH 3/7] usb: phy: omap-usb3: Don't use omap_get_control_dev()

2013-08-06 Thread Kishon Vijay Abraham I
On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't

Re: [PATCH 4/7] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-06 Thread Kishon Vijay Abraham I
Hi, On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device.

Re: [PATCH 5/7] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-06 Thread Kishon Vijay Abraham I
On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: This function was preventing us from supporting multiple instances. Get rid of it. Since we support DT boots only, users can get the control device phandle from the DT node. Signed-off-by: Roger Quadros rog...@ti.com Tested-by: Kishon

[PATCH] 6fire: fix DMA issues with URB transfer_buffer usage

2013-08-06 Thread Jussi Kivilinna
Patch fixes 6fire not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Furthermore, transfer_buffer should not be allocated as part of larger device structure because DMA coherency issues and patch fixes this issue too. Patch is only compile tested. Cc:

Re: [PATCH 2/7] usb: phy: omap-usb2: Don't use omap_get_control_dev()

2013-08-06 Thread Kishon Vijay Abraham I
On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't

[RFC 0/2] DWC3 USB support for Qualcomm platform

2013-08-06 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Hi, These patches add basic support for USB3.0 controllers found on MSM platforms. First patch add 2 USB PHY drivers and second one add support for Qualcomm wrapper IP over DWC3 controller. Patches are just skeletons, no power management. DWC3 IP in

[RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- .../devicetree/bindings/usb/msm-ssusb.txt | 39 + drivers/usb/dwc3/Kconfig |8 + drivers/usb/dwc3/Makefile |1 +

[RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Ivan T. Ivanov
From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- .../devicetree/bindings/usb/msm-ssusb.txt | 49 +++ drivers/usb/phy/Kconfig| 11 + drivers/usb/phy/Makefile |2 +

[PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jussi Kivilinna
Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/mtd/nand/alauda.c | 74

Re: [PATCH v3 3/4] USBNET: support DMA SG

2013-08-06 Thread Oliver Neukum
On Tue, 2013-08-06 at 08:52 +0800, Ming Lei wrote: This patch introduces support of DMA SG if the USB host controller which usbnet device is attached to is capable of building packet from discontinuous buffers. The patch supports passing the skb fragment buffers to usb stack directly via

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Pawel Moll
On Tue, 2013-08-06 at 12:53 +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com The same comment as for the RFC 1/2 here... .../devicetree/bindings/usb/msm-ssusb.txt | 39 + drivers/usb/dwc3/Kconfig

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-06 Thread Eric Dumazet
On Tue, 2013-08-06 at 08:52 +0800, Ming Lei wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so TSO can be enabled and skb fragment buffers can be passed to usb stack via

[PATCH] cdc-wdm: fix race between interrupt handler and tasklet

2013-08-06 Thread oliver
From: Oliver Neukum oneu...@suse.de Both could want to submit the same URB. Some checks of the flag intended to prevent that were missing. Signed-off-by: Oliver Neukum oneu...@suse.de CC: sta...@vger.kernel.org --- drivers/usb/class/cdc-wdm.c | 13 + 1 file changed, 9 insertions(+),

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jussi Kivilinna
On 06.08.2013 15:26, Oliver Neukum wrote: On Tue, 2013-08-06 at 15:03 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. You better include GregKH in CC Ok. Each of the 6 patches I sent today are

Reg: USB: ehci-omap: Suspend the controller during idle.

2013-08-06 Thread Bharathraj Nagaraju
Dear All, We are working on omap4470 based device,kernel-3.0.31 is running on this. In our device modem is connected to OMAP4470 using USB EHCI. In our current kernel code, clocks are enabled when ports get connected and disabled during disconnect.Due to this current consumption is

Re: [PATCH 4/7] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-06 Thread Roger Quadros
On 08/06/2013 02:51 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use

Re: [PATCH 1/7] usb: phy: omap: Add new PHY types and remove omap_control_usb3_phy_power()

2013-08-06 Thread Roger Quadros
On 08/06/2013 02:45 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 01 August 2013 07:35 PM, Roger Quadros wrote: TYPE2 meaning has changed. It is now a USB2 phy with Power down bit in control_dev_conf register. Introduce TYPE3 and TYPE4 PHY. TYPE3 is USB3 phy with DPLL and individual

Re: [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-06 at 13:12 +0100, Pawel Moll wrote: On Tue, 2013-08-06 at 12:53 +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com I am sure that the information in the subject is more than enough for you, but

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
On Tue, 2013-08-06 at 13:21 +0100, Pawel Moll wrote: On Tue, 2013-08-06 at 12:53 +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com The same comment as for the RFC 1/2 here... Will fix this.

Re: Reg: USB: ehci-omap: Suspend the controller during idle.

2013-08-06 Thread Greg KH
On Tue, Aug 06, 2013 at 06:25:32PM +0530, Bharathraj Nagaraju wrote: Dear All, We are working on omap4470 based device,kernel-3.0.31 is running on this. Have you tried the 3.10 kernel for this? I think you might find that this already is resolved there, as lots of pm USB work has

Re: [PATCH v14 00/12] Add tested id switch and vbus connect detect support for Chipidea

2013-08-06 Thread Peter Chen
On Fri, Aug 02, 2013 at 04:33:53PM +0800, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix kinds of bugs found at chipidea drivers after enabling id and vbus detection. This patch are fully tested at

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 03:47:24PM +0300, Jussi Kivilinna wrote: On 06.08.2013 15:26, Oliver Neukum wrote: On Tue, 2013-08-06 at 15:03 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. You

Re: Linux 3.10.4 and Logitech HD Webcam C525/C310

2013-08-06 Thread Alan Stern
On Tue, 6 Aug 2013, [koi8-r] � �� wrote: Hi, I have Logitech HD Webcam 525 (046d:0826) but its mic works strange. The mic is turned off while video works fine. In dmesg I see the following messages [ 472.079738] cannot submit urb (err = -18) [ 472.079748] cannot submit urb

Re: [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Mark Rutland
On Tue, Aug 06, 2013 at 12:53:10PM +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- .../devicetree/bindings/usb/msm-ssusb.txt | 49 +++ drivers/usb/phy/Kconfig| 11 +

Re: [PATCH 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-08-06 Thread Alan Stern
On Tue, 6 Aug 2013, Peter Chen wrote: In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced module paramters.

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Mark Rutland
On Tue, Aug 06, 2013 at 12:53:11PM +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com What does the glue layer do? Is it an actual piece of hardware, or just some platform-specific code? Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com ---

Re: [RFC 0/2] USB port power off bug fixes

2013-08-06 Thread Alan Stern
On Mon, 5 Aug 2013, Sarah Sharp wrote: Please review these two bug fixes for the USB port power off mechanism. I especially need review for the second patch, since it involves issues with the runtime status of the USB port. These two patches were tested on a Haswell ULT Sawtooth Peak

Re: Reg: USB: ehci-omap: Suspend the controller during idle.

2013-08-06 Thread Roger Quadros
Hi, On 08/06/2013 03:55 PM, Bharathraj Nagaraju wrote: Dear All, We are working on omap4470 based device,kernel-3.0.31 is running on this. In our device modem is connected to OMAP4470 using USB EHCI. In our current kernel code, clocks are enabled when ports get connected and

Re: [RFC 1/2] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DWC3 core

2013-08-06 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-06 at 15:03 +0100, Mark Rutland wrote: On Tue, Aug 06, 2013 at 12:53:10PM +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com Signed-off-by: Ivan T. Ivanov iiva...@mm-sol.com --- .../devicetree/bindings/usb/msm-ssusb.txt | 49 +++

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
Hi, On Tue, 2013-08-06 at 15:07 +0100, Mark Rutland wrote: On Tue, Aug 06, 2013 at 12:53:11PM +0100, Ivan T. Ivanov wrote: From: Ivan T. Ivanov iiva...@mm-sol.com What does the glue layer do? Is it an actual piece of hardware, or just some platform-specific code? It is hardware layer

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-06 Thread Ming Lei
On Tue, Aug 6, 2013 at 8:22 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Tue, 2013-08-06 at 08:52 +0800, Ming Lei wrote: This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Pawel Moll
On Tue, 2013-08-06 at 14:46 +0100, Ivan T. Ivanov wrote: + reg = 0xf920 0xcd00; + interrupts = 0 131 0; + interrupt-names = irq; + usb-phy = dwc3_usb2, dwc3_usb3; + tx-fifo-resize; + };

[PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used

2013-08-06 Thread Mark Brown
From: Andy Green andy.gr...@linaro.org You might have CONFIG_PM, but you might not have CONFIG_SUSPEND, in which case these are unused. Signed-off-by: Andy Green andy.gr...@linaro.org Signed-off-by: Mark Brown broo...@linaro.org --- drivers/usb/dwc3/dwc3-pci.c | 2 +- 1 file changed, 1

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-06 Thread Huang Rui
On Mon, Aug 05, 2013 at 10:10:27AM -0400, Alan Stern wrote: On Mon, 5 Aug 2013, Huang Rui wrote: Hi Alan, On Thu, Jul 11, 2013 at 02:58:04PM -0400, Alan Stern wrote: The hub driver was recently changed to use global suspend for system suspend transitions on non-SuperSpeed buses.

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-06 Thread Alan Stern
On Wed, 7 Aug 2013, Huang Rui wrote: Could you explain that how can you make sure the root cause is unable to relay wakup requests from downstream port to upstream port if downstream port's suspend feature is not set? The OS is unable wakeup from S3 at that time. We can't fetch dmesg

[PATCH 1/2] ARM: omap2: fix musb usage for n8x0

2013-08-06 Thread Aaro Koskinen
From: Daniel Mack zon...@gmail.com Commit b7e2e75a8c (usb: gadget: drop unused USB_GADGET_MUSB_HDRC) dropped a config symbol that was unused by the musb core, but it turns out that board support code still had references to it. As the core now handles both dual role and host-only modes, we can

[PATCH 0/2] ARM: OMAP: fix USB regression on Nokia boards

2013-08-06 Thread Aaro Koskinen
Hi, USB subsystem changes broke the USB peripheral/gadget on N800, N810 and RX-51/N900 during the merge window. We need to fix this in board files. I tested all these with 3.11-rc4 + g_ether + ssh. Aaro Koskinen (1): ARM: OMAP: rx51: change musb mode to OTG Daniel Mack (1): ARM: omap2: fix

[PATCH 2/2] ARM: OMAP: rx51: change musb mode to OTG

2013-08-06 Thread Aaro Koskinen
Peripheral-only mode got broken in v3.11-rc1 because of unknown reasons. Change the mode to OTG, in practice that should work equally well even when/if the regression gets fixed. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/arm/mach-omap2/board-rx51.c | 2 +- 1 file changed, 1

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-06 Thread Grant Grundler
On Tue, Aug 6, 2013 at 5:22 AM, Eric Dumazet eric.duma...@gmail.com wrote: ... @@ -1310,6 +1318,10 @@ static int ax88179_reset(struct usbnet *dev) dev-net-hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_RXCSUM; + if (dev-can_dma_sg) { +

[PATCH v2 6/7] pl2303: also use the divisor based baud rate encoding method for baud rates 115200 with HX chips

2013-08-06 Thread Frank Schäfer
Now that the divisor based baud rate encoding method has been fixed and extended, it can also be used for baud rates 115200 baud with HX chips. This makes it possible to adjust the baud rate almost continuously instead of just beeing able to select between 16 fixed standard values. Tested with a

[PATCH v2 7/7] pl2303: add two comments concerning the supported baud rates with HX chips

2013-08-06 Thread Frank Schäfer
I've found some new datasheets which describe some additionally supported standard baud rates and I've verified them with my HX (rev. 3A) device. But adding support for individual (chip type specific) baud rates would add a good amount of extra code (especially when support for further chips will

[PATCH v2 1/7] pl2303: fix+improve the divsor based baud rate encoding method

2013-08-06 Thread Frank Schäfer
Based on the formula in the code description, Reinhard Max and me have investigated the devices behavior / functional principle of the divisor based baud rate encoding method. It turned out, that (although beeing a good starting point) the current code has some flaws. It doesn't work correctly

[PATCH v2 2/7] pl2303: do not round to the next nearest standard baud rate for the divisor based baud rate encoding method

2013-08-06 Thread Frank Schäfer
In opposition to the direct baud rate encoding method, the divisor based method is not limited to a fixed set of standard baud rates. Hence, there is no need to round to the next nearest standard value. Reported-by: Mastro Gippo gip...@gmail.com Signed-off-by: Frank Schäfer

[PATCH v2 3/7] pl2303: remove 500000 baud from the list of standard baud rates

2013-08-06 Thread Frank Schäfer
Commit 0c967e7e USB: serial: pl2303 works at 500kbps added 50 baud to the list of supported standard baud rates. But the reason why the driver works with this baud rate is, that since commit 8d48fdf6 USB: PL2303: correctly handle baudrates above 115200 a second (divisor based) baud rate

[PATCH v2 4/7] pl2303: move the two baud rate encoding methods to separate functions

2013-08-06 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/usb/serial/pl2303.c | 215 +++ 1 Datei geändert, 114 Zeilen hinzugefügt(+), 101 Zeilen entfernt(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index

[PATCH v2 0/7] pl2303: improve the baud rate support

2013-08-06 Thread Frank Schäfer
This patch series against usb-next improves the baud rate support of the pl2303 driver. Currently only a fixed set of 25 standard baud rates from 75 to 6M baud is supported. With this patch series applied, almost continuous baud rate adjustment is possible between 46 and 6.6M baud. Luca

[PATCH v2 5/7] pl2303: increase the allowed baud rate range for the divisor based encoding method

2013-08-06 Thread Frank Schäfer
Reinhard Max has done some tests with a PL2303HX (rev A) and a logic analyzer and it seems, that although the PL2303HX is specified for baud rates from 75 to 6M baud, the full divisor range can be used with the divisor based baud rate encoding method. This corresponds to baud rates from 46 to 24M

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-06 Thread Yacine Belkadi
On 08/06/2013 12:28 AM, Greg Kroah-Hartman wrote: On Mon, Aug 05, 2013 at 08:36:39PM +0200, Yacine Belkadi wrote: On 08/04/2013 11:29 PM, Greg Kroah-Hartman wrote: On Sun, Aug 04, 2013 at 10:05:36PM +0200, Yacine Belkadi wrote: On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: On Fri, Aug 02,

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-06 Thread Ivan T. Ivanov
On Tue, 2013-08-06 at 16:15 +0100, Pawel Moll wrote: On Tue, 2013-08-06 at 14:46 +0100, Ivan T. Ivanov wrote: + reg = 0xf920 0xcd00; + interrupts = 0 131 0; + interrupt-names = irq; +

Re: [PATCH 1/3] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-06 Thread Julius Werner
On Fri, Aug 2, 2013 at 12:51 AM, Felipe Balbi ba...@ti.com wrote: Hi, I need an Acked-by for the dtsi part. Ideally from Exynos 5 maintainer and at least one of the DT maintainers. -- balbi Okay, I think I forgot to update the DT bindings documentation anyway... so I will resubmit this and

[PATCH 1/3 v5] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-06 Thread Julius Werner
This patch simplifies the way the phy-samsung-usb code finds the correct power management register to enable PHY clock gating. Previously, the code would calculate the register address from a device tree supplied base address and add an offset based on the PHY type. Since every PHY has its own

[PATCH v2 5/6] usb: phy: tegra: Program new PHY parameters

2013-08-06 Thread Tuomas Tynkkynen
The Tegra30 TRM recommends configuration of certain PHY parameters for optimal quality. Program the following registers based on device tree parameters: - UTMIP_XCVR_HSSLEW: HS slew rate control. - UTMIP_HSSQUELCH_LEVEL: HS squelch detector level - UTMIP_HSDISCON_LEVEL: HS disconnect detector

[PATCH v2 3/6] usb: phy: tegra: Tegra30 support

2013-08-06 Thread Tuomas Tynkkynen
The Tegra30 USB PHY is a bit different than the Tegra20 PHY: - The EHCI controller supports the HOSTPC register extension, and some of the fields that the PHY needs to modify (PHCD and PTS) have moved to the new HOSTPC register. - Some of the UTMI PLL configuration registers have moved from

[PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Tuomas Tynkkynen
The Tegra30 EHCI controller is mostly compatible with the Tegra20 controller, except Tegra30 includes the HOSTPC register extension. The has_hostpc capability bit must be set in the ehci_hcd structure if the controller has such extensions. The new tegra_ehci_soc_config structure is added to

[PATCH v2 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-06 Thread Tuomas Tynkkynen
Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in host mode and cleared in device mode - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not

[PATCH v2 4/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-06 Thread Tuomas Tynkkynen
Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen ttynkky...@nvidia.com --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-06 Thread Tuomas Tynkkynen
Hi all, Here are the patches for the USB tree to enable USB Host support on Tegra30 and Tegra114. These are based on my and Mikko's cleanup patches that just got merged to Felipe's tree. The first one touches the core hub code to prevent certain (non-standard) clock disable features as our

[PATCH v2 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-06 Thread Tuomas Tynkkynen
The has_hostpc capability bit indicates that the host controller has the HOSTPC register extensions, but at the same time enables clock disabling power saving features with the PHY Low Power Clock Disable (PHCD) bit. However, some host controllers have the HOSTPC extensions but don't support the

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-06 Thread Huang Rui
On Wed, Aug 07, 2013 at 01:05:40AM +0800, Alan Stern wrote: On Wed, 7 Aug 2013, Huang Rui wrote: Could you explain that how can you make sure the root cause is unable to relay wakup requests from downstream port to upstream port if downstream port's suspend feature is not set? The

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jörn Engel
On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. I have tested the driver back when I wrote it. Not sure why it worked then, maybe

Re: [RFC 0/2] USB port power off bug fixes

2013-08-06 Thread Sarah Sharp
On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: On Mon, 5 Aug 2013, Sarah Sharp wrote: Please review these two bug fixes for the USB port power off mechanism. I especially need review for the second patch, since it involves issues with the runtime status of the USB port.

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-06 Thread Alan Stern
On Wed, 7 Aug 2013, Huang Rui wrote: Got it, but I'm still a little confused. For example, one mouse is attached at usb2.0 port of roothub, and it supports remote wakeup. But the wakeup attribute is disabled for mouse defaultly, am I right? So Yes. remote wakeup doesn't work

Re: [RFC 0/2] USB port power off bug fixes

2013-08-06 Thread Alan Stern
On Tue, 6 Aug 2013, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: On Mon, 5 Aug 2013, Sarah Sharp wrote: Please review these two bug fixes for the USB port power off mechanism. I especially need review for the second patch, since it involves issues

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Sergei Shtylyov
Hello. On 08/06/2013 10:08 PM, Tuomas Tynkkynen wrote: The Tegra30 EHCI controller is mostly compatible with the Tegra20 controller, except Tegra30 includes the HOSTPC register extension. The has_hostpc capability bit must be set in the ehci_hcd structure if the controller has such extensions.

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Tuomas Tynkkynen
On 08/06/2013 09:35 PM, Sergei Shtylyov wrote: Hello. [...] +match = of_match_device(tegra_ehci_of_match, pdev-dev); +if (!match) { +dev_err(pdev-dev, Error: No device match found\n); +return -ENODEV; +} +soc_config = (struct tegra_ehci_soc_config

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Sergei Shtylyov
Hello. On 08/06/2013 11:16 PM, Tuomas Tynkkynen wrote: [...] + match = of_match_device(tegra_ehci_of_match, pdev-dev); + if (!match) { + dev_err(pdev-dev, Error: No device match found\n); + return -ENODEV; + } + soc_config = (struct

Re: [PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-06 Thread Stephen Warren
On 08/06/2013 12:08 PM, Tuomas Tynkkynen wrote: Hi all, Here are the patches for the USB tree to enable USB Host support on Tegra30 and Tegra114. These are based on my and Mikko's cleanup patches that just got merged to Felipe's tree. The first one touches the core hub code to prevent

Re: [RFC 0/2] USB port power off bug fixes

2013-08-06 Thread Sarah Sharp
On Tue, Aug 06, 2013 at 02:48:57PM -0400, Alan Stern wrote: On Tue, 6 Aug 2013, Sarah Sharp wrote: On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: Patch 1 has been rendered out of date by intervening changes (commit 4fae6f0fa86f in Greg's usb-next tree). Greg,

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-06 Thread Tomasz Figa
On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-05 16:42:16) On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 11:13:55) On 08/06/13 03:06, Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-06 Thread Kukjin Kim
On 08/07/13 07:06, Tomasz Figa wrote: On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-05 16:42:16) On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim (2013-08-05 11:13:55) On 08/06/13 03:06, Mike Turquette wrote: Quoting

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-06 Thread Tomasz Figa
On Wednesday 07 of August 2013 07:11:40 Kukjin Kim wrote: On 08/07/13 07:06, Tomasz Figa wrote: On Tuesday 06 of August 2013 12:47:51 Mike Turquette wrote: Quoting Tomasz Figa (2013-08-05 16:42:16) On Monday 05 of August 2013 12:02:16 Mike Turquette wrote: Quoting Kukjin Kim

Re: [PATCH] USB: global suspend and remote wakeup don't mix

2013-08-06 Thread Peter Chen
On Tue, Aug 06, 2013 at 01:05:40PM -0400, Alan Stern wrote: On Wed, 7 Aug 2013, Huang Rui wrote: Could you explain that how can you make sure the root cause is unable to relay wakup requests from downstream port to upstream port if downstream port's suspend feature is not set? The

[PATCH v2 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-08-06 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined value. This change will no affect current behavior if the user does not use two introduced module paramters. Signed-off-by: Peter Chen

Re: 045e:0745 [HP TouchSmart tm2t-2200] No scancode for several keys of Microsoft Comfort Desktop 5000

2013-08-06 Thread Greg KH
On Tue, Aug 06, 2013 at 11:57:17AM -0700, Ari Fogel wrote: [1]. Summary: 045e:0745 [HP TouchSmart tm2t-2200] No scancode for several keys of Microsoft Comfort Desktop 5000 [2]. Link to original bug report in launchpad: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1168224 [2].

Re: [PATCH v3 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-06 Thread Ming Lei
On Wed, Aug 7, 2013 at 1:09 AM, Grant Grundler grund...@google.com wrote: On Tue, Aug 6, 2013 at 5:22 AM, Eric Dumazet eric.duma...@gmail.com wrote: ... @@ -1310,6 +1318,10 @@ static int ax88179_reset(struct usbnet *dev) dev-net-hw_features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM |

Re: I've now caught up on my pending USB patches

2013-08-06 Thread Ming Lei
Hi Greg, On Fri, Aug 2, 2013 at 9:19 AM, Ming Lei tom.leim...@gmail.com wrote: Hi Greg, On Sat, Jul 27, 2013 at 5:17 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, I've now caught up on all pending USB patches that were sent to me, with the exception of Ming's EHCI patches, which I

Re: [PATCH] usb: dwc3-pci: Ensure system sleep PM ops are defined only when used

2013-08-06 Thread Fabio Estevam
Hi Mark, On Tue, Aug 6, 2013 at 12:49 PM, Mark Brown broo...@kernel.org wrote: From: Andy Green andy.gr...@linaro.org You might have CONFIG_PM, but you might not have CONFIG_SUSPEND, in which case these are unused. Signed-off-by: Andy Green andy.gr...@linaro.org Signed-off-by: Mark Brown

Re: ar5523 Gigaset USB Adapter 108 issue

2013-08-06 Thread Sarah Sharp
Please recompile your kernel with CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING turned on, and email dmesg from when you first plug in the device, to when it fails. Thanks, Sarah Sharp On Thu, Aug 01, 2013 at 07:41:27PM +0200, Yannik Völker wrote: -BEGIN PGP SIGNED MESSAGE- Hash:

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-06 Thread Sarah Sharp
On Tue, Aug 06, 2013 at 06:04:36AM +0800, Greg Kroah-Hartman wrote: On Mon, Aug 05, 2013 at 09:46:46AM -0700, Sarah Sharp wrote: I wanted to test it for a kernel release to make sure it didn't cause any issues before sending it off to stable. I'm sure it fixes Julius' issues on his Intel

Re: I've now caught up on my pending USB patches

2013-08-06 Thread Greg KH
On Wed, Aug 07, 2013 at 08:44:49AM +0800, Ming Lei wrote: Hi Greg, On Fri, Aug 2, 2013 at 9:19 AM, Ming Lei tom.leim...@gmail.com wrote: Hi Greg, On Sat, Jul 27, 2013 at 5:17 AM, Greg KH gre...@linuxfoundation.org wrote: Hi all, I've now caught up on all pending USB patches that

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jussi Kivilinna
On 06.08.2013 19:49, Jörn Engel wrote: On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. I have tested the driver back when I wrote