Re: [RESEND PATCHv2 0/3] usb: dwc2/s3c-hsotg: Move the s3c-hsotg driver into dwc2

2014-03-04 Thread Jingoo Han
On Tuesday, March 04, 2014 12:06 PM, Dinh Nguyen wrote: From: Dinh Nguyen dingu...@altera.com Hi, Apologies for sending the wrong 1st patch of this series. --- This is a shortened version of the v1 patch to combine the dwc2/s3c-hsotg into a single dual-role driver. The series will

Re: [PATCH 02/12] phy: omap-control: Update DT binding information

2014-03-04 Thread Roger Quadros
Hi Tony, On 03/03/2014 09:02 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [140303 07:10]: Move omap-control binding information to the right location. Signed-off-by: Roger Quadros rog...@ti.com --- Documentation/devicetree/bindings/phy/ti-phy.txt | 25 ++

Re: [PATCH 06/12] phy: omap: Select OMAP_OCP2SCP bus driver

2014-03-04 Thread Roger Quadros
On 03/03/2014 08:52 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [140303 07:11]: The OMAP_USB2 and OMAP_PIP3 phy devices will not be detected if the OMAP_OCP2SCP driver is not present. So select it. Selecting drivers like this will easily lead into missing dependencies.

Re: [PATCH 01/12] phy: rename struct omap_control_usb to struct omap_control_phy

2014-03-04 Thread Kishon Vijay Abraham I
Roger, On Monday 03 March 2014 08:37 PM, Roger Quadros wrote: From: Kishon Vijay Abraham I kis...@ti.com Rename struct omap_control_usb to struct omap_control_phy since it can be used to control PHY of USB, SATA and PCIE. Also move the driver and include files under *phy* and made the

Re: [PATCH 03/12] phy: ti-pipe3: cleanup clock handling

2014-03-04 Thread Kishon Vijay Abraham I
Hi, On Monday 03 March 2014 08:37 PM, Roger Quadros wrote: As this driver is no longer USB specific, use generic clock names. - Fix PLL_SD_SHIFT from 9 to 10 - As optclk and wkupclk may not be always required, don't bail out if they aren't available. I think here too we face the same problem

Re: [PATCH 03/12] phy: ti-pipe3: cleanup clock handling

2014-03-04 Thread Roger Quadros
On 03/04/2014 11:29 AM, Kishon Vijay Abraham I wrote: Hi, On Monday 03 March 2014 08:37 PM, Roger Quadros wrote: As this driver is no longer USB specific, use generic clock names. - Fix PLL_SD_SHIFT from 9 to 10 - As optclk and wkupclk may not be always required, don't bail out if they

RE: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread David Laight
From: Sarah Sharp Greg, Dave, Freddy, question about cross-subsystem reverts below: On Fri, Feb 28, 2014 at 04:15:12PM -0500, Alan Stern wrote: On Fri, 28 Feb 2014, Sarah Sharp wrote: When testing 3.14-rc1 with a USB 3.0 Lexar flash drive, the drive fails to be mounted. I added a

Bug ID: 71261 modprobe xhci-hcd driver modules failed

2014-03-04 Thread shishir tiwari
Hi , When we try to modprode Xhci-hcd Driver with dmesg -n 6 command in background , xhci driver loading failed.But if we give dmesg -n 7/5 or any thing its work. When Extended Capability register is being read its given zero insted of 544 value . Here is the Step to reproduce: #dd if=/dev/mtd4

RE: some question about xhci TRB_INTR_TARGET

2014-03-04 Thread David Laight
From: vichy hi all: from xhci spec, Interrupter Target is the value between 0 and MaxIntrs-1. But why the parameter pass to TRB_INTR_TARGTRB_INTR_TARGET is always 0. Does that mean so far xhci host didn't support multi-interrupt as MSI-X suggested? AFAIK The Linux USB stack doesn't support

Re: [PATCH v3 1/1] xhci: Prevent runtime pm from autosuspending during initialization

2014-03-04 Thread Mathias Nyman
On 03/03/2014 08:37 PM, Greg KH wrote: On Mon, Mar 03, 2014 at 07:30:17PM +0200, Mathias Nyman wrote: xHCI driver has its own pci probe function that will call usb_hcd_pci_probe to register its usb-2 bus, and then continue to manually register the usb-3 bus. usb_hcd_pci_probe does a

[PATCH net-next 12/12] r8152: modify the tx timeout funcfion

2014-03-04 Thread Hayes Wang
Reset and reinitialize the device when the tx timeout occurs. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 41 +++-- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/drivers/net/usb/r8152.c

[PATCH net-next 10/12] r8152: reduce the numbers of the bulks

2014-03-04 Thread Hayes Wang
Reduce the numbers of tx and rx aggregation buffers. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 72cbab1..b60b3bc 100644 ---

[PATCH net-next 11/12] r8152: add additional parameter for non x86 platform

2014-03-04 Thread Hayes Wang
Add additional parameter for non x86 platform for better throughput. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index b60b3bc..e04fcbd

[PATCH net-next 09/12] r8152: support IPv6

2014-03-04 Thread Hayes Wang
Support hw IPv6 checksum for TCP and UDP packets. Note that the hw has the limitation of the range of the transport offset. Besides, the TCP Pseudo Header of the IPv6 TSO of the hw bases on the Microsoft document which excludes the packet length. Signed-off-by: Hayes Wang hayesw...@realtek.com

[PATCH net-next 06/12] r8152: up the priority of the transmission

2014-03-04 Thread Hayes Wang
move the tx_bottom() from delayed_work to tasklet. It makes the rx and tx balanced. If the device is in runtime suspend when getting the tx packet, wakeup the device before trasmitting. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 45

[PATCH net-next 05/12] r8152: check tx agg list before spin lock

2014-03-04 Thread Hayes Wang
Check tx agg list before spin lock to avoid doing spin lock every times. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 8ecb41b..00b3192 100644 ---

[PATCH net-next 07/12] r8152: support rx checksum

2014-03-04 Thread Hayes Wang
Support hw rx checksum for TCP and UDP packets. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 53 ++--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread Hayes Wang
Support scatter gather and TSO. Adjust the tx checksum function and set the max gso size to fix the size of the tx aggregation buffer. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 133 +--- 1 file changed, 103

[PATCH net-next 02/12] r8152: replace tp-netdev with netdev

2014-03-04 Thread Hayes Wang
Replace some tp-netdev with netdev. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index c8bad62..151398b 100644 ---

[PATCH net-next 04/12] r8152: replace spin_lock_irqsave and spin_unlock_irqrestore

2014-03-04 Thread Hayes Wang
Use spin_lock and spin_unlock in interrupt context. The ndo_start_xmit would not be called in interrupt context, so replace the relative spin_lock_irqsave and spin_unlock_irqrestore with spin_lock_bh and spin_unlock_bh. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c

[PATCH net-next 03/12] r8152: remove rtl8152_get_stats

2014-03-04 Thread Hayes Wang
The rtl8152_get_stats() returns the point address of the struct net_device_stats. This could be got from struct net_device directly. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff

[PATCH net-next 00/12] r8152: new features

2014-03-04 Thread Hayes Wang
Besides the adjustment of the code, support rx checksum, TCP large send, and IPv6. Hayes Wang (12): r8152: deal with the empty line and space r8152: replace tp-netdev with netdev r8152: remove rtl8152_get_stats r8152: replace spin_lock_irqsave and spin_unlock_irqrestore r8152: check tx

[PATCH net-next 01/12] r8152: deal with the empty line and space

2014-03-04 Thread Hayes Wang
Add or remove some empty lines. Replace the spaces with the tabs. Signed-off-by: Hayes Wang hayesw...@realtek.com --- drivers/net/usb/r8152.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 0654bd3..c8bad62

RE: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread David Laight
From: Hayes Wang Support scatter gather and TSO. Adjust the tx checksum function and set the max gso size to fix the size of the tx aggregation buffer. There is little point supporting TSO unless the usb host controller supports arbitrary aligned scatter-gather. All you do is require that a

Re: some question about xhci TRB_INTR_TARGET

2014-03-04 Thread vichy
hi David: 2014-03-04 19:40 GMT+08:00 David Laight david.lai...@aculab.com: From: vichy hi all: from xhci spec, Interrupter Target is the value between 0 and MaxIntrs-1. But why the parameter pass to TRB_INTR_TARGTRB_INTR_TARGET is always 0. Does that mean so far xhci host didn't support

[PATCH net] r8152: disable the ECM mode

2014-03-04 Thread Hayes Wang
There are known issues for switching the drivers between ECM mode and vendor mode. The interrup transfer may become abnormal. The hardware may have the opportunity to die if you change the configuration without unloading the current driver first, because all the control transfers of the current

RE: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread hayeswang
David Laight [mailto:david.lai...@aculab.com] Sent: Tuesday, March 04, 2014 8:12 PM To: 'Hayes Wang'; net...@vger.kernel.org Cc: nic_s...@realtek.com; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org Subject: RE: [PATCH net-next 08/12] r8152: support TSO From: Hayes Wang

Re: [PATCH v5 0/6] Make dwc3 use Generic PHY Framework

2014-03-04 Thread Kishon Vijay Abraham I
On Monday 03 March 2014 10:10 PM, Felipe Balbi wrote: Hi, On Mon, Mar 03, 2014 at 05:08:09PM +0530, Kishon Vijay Abraham I wrote: Added support for optional PHY in dwc3 as not all SoCs having PHYs for DWC3 should be programmed. While this can be considered as a temporary fix, a long term

RE: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread David Laight
From: hayeswang David Laight [mailto:david.lai...@aculab.com] Sent: Tuesday, March 04, 2014 8:12 PM To: 'Hayes Wang'; net...@vger.kernel.org Cc: nic_s...@realtek.com; linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org Subject: RE: [PATCH net-next 08/12] r8152: support TSO

RE: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Alan Stern
On Tue, 4 Mar 2014, David Laight wrote: Notice the request length: 1536. That's three 512-byte sectors. A little unusual, since most I/O is done in units of pages, which are 4096 bytes. Ok, we can't have SuperSpeed mass storage devices broken, so it looks like we'll have to revert

RE: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread Eric Dumazet
On Tue, 2014-03-04 at 14:35 +, David Laight wrote: Does that mean you are splitting the 64k 'ethernet packet' from TCP is software? I've looked at the ax88179 where the hardware can do it. Is there really a gain doing segmentation here if you have to do the extra data copy? There is no

Re: basics of runtime d3 for xhci.

2014-03-04 Thread Alan Stern
On Mon, 3 Mar 2014, Pratik Prajapati wrote: Can anyone please explain me, how runtime d3 works for xhci. It works the same way for all USB host controller drivers, including xhci-hcd. I am trying to understand generic code/control flow. When usb bus is ideal, how RTD3 (runtime d3) will be

RE: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread David Laight
From: Eric Dumazet On Tue, 2014-03-04 at 14:35 +, David Laight wrote: Does that mean you are splitting the 64k 'ethernet packet' from TCP is software? I've looked at the ax88179 where the hardware can do it. Is there really a gain doing segmentation here if you have to do the

Re: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Ming Lei
On Tue, Mar 4, 2014 at 10:56 PM, David Laight david.lai...@aculab.com wrote: From: Bjørn Mork If xHCI won't plan to support arbitrary-length scatter-gather any more, that is fine to revert the commit forever. Otherwise, it should be better to just clear no_sg_constraint in xhcd,

Re: [PATCH] usb: dwc2: Add function to calculate correct FIFO sizes

2014-03-04 Thread Felipe Balbi
On Mon, Mar 03, 2014 at 09:20:02PM -0600, Dinh Nguyen wrote: Hi Paul, On 3/3/14 9:14 PM, Paul Zimmerman wrote: From: dingu...@altera.com [mailto:dingu...@altera.com] Sent: Monday, March 03, 2014 2:20 PM From: Dinh Nguyen dingu...@altera.com The dwc2 IP on the SOCFPGA cannot use the

Re: [RESEND PATCHv2 1/3] usb: dwc2: Add defines to support the s3c-hsotg driver

2014-03-04 Thread Felipe Balbi
On Mon, Mar 03, 2014 at 09:06:13PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com In preparation of combining the dwc2/s3c-hsotg driver in a single DRD driver, the defines in dwc2/hw.h needs to get updated so that the s3c-hsotg driver can use them. Signed-off-by:

Re: [PATCHv2] usb: dwc2: Add function to calculate correct FIFO sizes

2014-03-04 Thread Felipe Balbi
On Mon, Mar 03, 2014 at 09:25:13PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com The dwc2 IP on the SOCFPGA cannot use the default HW configured FIFO sizes. The total FIFO depth as read from GHWCFG3 reports 0x1f80 or 8064 32-bit words. But the GRXFSIZ, GNPTXFSIZ,

Re: randconfig build error with next-20140304, in drivers/usb/dwc3/core.c

2014-03-04 Thread Felipe Balbi
Hi, On Tue, Mar 04, 2014 at 07:30:20AM -0700, Jim Davis wrote: Building with the attached random configuration file, warning: (USB_OTG_FSM FSL_USB2_OTG USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT USB PM_RUNTIME) warning: (USB_OTG_FSM FSL_USB2_OTG

Re: [RESEND PATCHv2 2/3] usb: s3c-hsotg: Move s3c-hsotg into dwc2 folder

2014-03-04 Thread Felipe Balbi
On Mon, Mar 03, 2014 at 09:06:14PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Moves the s3c-hsotg driver into the dwc2 folder and use the dwc2 defines in hw.h. The s3c-hostg driver will now be built with a kconfig option under the dwc2 kconfig. USB_DWC2_HOST and

[PATCH v7 0/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-04 Thread Kamil Debski
Hi, This is the seventh version of this patchset. First and most significant change is that this patchset includes only patches touching the Generic PHY Framework. Patches to the USB controllers were stripped as they require additional work. S5PV210 support is also omitted - it requires more

[PATCH v7 1/4] phy: core: Add an exported of_phy_get function

2014-03-04 Thread Kamil Debski
Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to _of_phy_get and was left for internal use. of_phy_get function was

[PATCH v7 2/4] phy: core: Add devm_of_phy_get to phy-core

2014-03-04 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed,

RE: ax88179_178a problems on AMD platform with ASMedia xhci controller

2014-03-04 Thread David Laight
From: renev...@internode.on.net Not only that though, I moved to a SandyBridge platform and... The nic stops working very quickly when using an onboard Etron controller. The nic also stops working quickly when using an addon card with Renesas controller. What I found was that the nic's

[PATCH v7 3/4] phy: Add new Exynos USB 2.0 PHY driver

2014-03-04 Thread Kamil Debski
Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4210 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt| 53

RE: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread David Laight
From: Alan Stern There are only two reasonable ways to fix this: Add appropriate TRB fragment handling into xhci-hcd, or use bounce buffers for non-aligned requests. In theory the block layer could be taught about the need for these bounce buffers, but that would be only a partial solution.

[PATCH v7 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

2014-03-04 Thread Kamil Debski
Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile

Re: Bug ID: 71261 modprobe xhci-hcd driver modules failed

2014-03-04 Thread Mathias Nyman
On 03/04/2014 12:21 PM, shishir tiwari wrote: Hi , When we try to modprode Xhci-hcd Driver with dmesg -n 6 command in background , xhci driver loading failed.But if we give dmesg -n 7/5 or any thing its work. When Extended Capability register is being read its given zero insted of 544 value .

Re: [PATCH v6 part1 4/8] usb: assign default peer ports for root hubs

2014-03-04 Thread Alan Stern
On Mon, 3 Mar 2014, Dan Williams wrote: In general I agree, and I like the compartmentalization of only needing to take the lock in hub.c. But I still think we have a hole with a scenario like the following (granted, this should never happen in current code...): CPU1

[PATCH] usb: dwc3: fix randconfig build errors

2014-03-04 Thread Felipe Balbi
commit 388e5c5 (usb: dwc3: remove dwc3 dependency on host AND gadget.) created the possibility for host-only and peripheral-only dwc3 builds but left a possible randconfig build error when host-only builds are selected. Cc: sta...@vger.kernel.org # v3.8+ Reported-by: Jim Davis jim.ep...@gmail.com

[PATCH] usb: dwc3: define more revisions

2014-03-04 Thread Felipe Balbi
few new revisions of the core have been released, add them to our list of revisions so we can apply workarounds if necessary. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/dwc3/core.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/core.h

Re: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Ming Lei
On Tue, Mar 4, 2014 at 11:21 PM, David Laight david.lai...@aculab.com wrote: Actually most of the block layer code could be taught to split requests into multiple URBs. Or even resubmit bounced requests split in two. Although splitting requests won't help the network code. It might not help

Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()

2014-03-04 Thread Sergei Shtylyov
Hello. On 03/04/2014 10:34 AM, Chuansheng Liu wrote: When the request length is aligned to maxpacketsize, sometimes the return length ret the user space requested len. At that time, we will use min_t(size_t, ret, len) to limit the size in case of user data buffer overflow. But we need

RE: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Alan Stern
On Tue, 4 Mar 2014, David Laight wrote: An alternative is to work around this particular problem by identifying the code that submits the 3-sector SG element, and changing it to use an even number of sectors. But obviously that doesn't solve the underlying issue. Actually most of the

Re: [PATCH v6 part1 4/8] usb: assign default peer ports for root hubs

2014-03-04 Thread Alan Stern
On Mon, 3 Mar 2014, Dan Williams wrote: Ok, so the root issue is that the peering code needs to see hcd-primary_hcd = NULL to know that there is no longer a peer. I update usb_remove_hcd() to clear out -shared_hcd and -primary_hcd under the peer lock before we allow the root hub to be freed.

Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()

2014-03-04 Thread Felipe Balbi
On Tue, Mar 04, 2014 at 08:01:15PM +0300, Sergei Shtylyov wrote: Hello. On 03/04/2014 10:34 AM, Chuansheng Liu wrote: When the request length is aligned to maxpacketsize, sometimes the return length ret the user space requested len. At that time, we will use min_t(size_t, ret, len) to

Re: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread Eric Dumazet
On Tue, 2014-03-04 at 20:01 +0800, Hayes Wang wrote: +static u32 r8152_xmit_frags(struct r8152 *tp, struct sk_buff *skb, u8 *data) +{ + struct skb_shared_info *info = skb_shinfo(skb); + unsigned int cur_frag; + u32 total = skb_headlen(skb); + + memcpy(data, skb-data,

Re: [PATCH v6 part1 6/8] usb: find internal hub tier mismatch via acpi

2014-03-04 Thread Alan Stern
On Mon, 3 Mar 2014, Dan Williams wrote: Subject: usb: find internal hub tier mismatch via acpi From: Dan Williams dan.j.willi...@intel.com ACPI identifies peer ports by setting their 'group_token' and 'group_position' _PLD data to the same value. If a platform has tier mismatch [1] ,

Re: [PATCH 02/12] phy: omap-control: Update DT binding information

2014-03-04 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [140304 01:17]: Hi Tony, On 03/03/2014 09:02 PM, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [140303 07:10]: Move omap-control binding information to the right location. Signed-off-by: Roger Quadros rog...@ti.com ---

Re: [PATCH net-next 08/12] r8152: support TSO

2014-03-04 Thread Eric Dumazet
On Tue, 2014-03-04 at 20:01 +0800, Hayes Wang wrote: Support scatter gather and TSO. - netdev-features |= NETIF_F_RXCSUM | NETIF_F_IP_CSUM; - netdev-hw_features = NETIF_F_RXCSUM | NETIF_F_IP_CSUM; + netdev-features |= NETIF_F_RXCSUM | NETIF_F_IP_CSUM | NETIF_F_SG | +

Re: [PATCH net-next 09/12] r8152: support IPv6

2014-03-04 Thread Eric Dumazet
On Tue, 2014-03-04 at 20:01 +0800, Hayes Wang wrote: Support hw IPv6 checksum for TCP and UDP packets. +/* + * r8152_csum_workaround() + * The hw limites the value the transport offset. When the offset is out of the + * range, calculate the checksum by sw. + */ +static void

Re: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Alan Stern
On Tue, 4 Mar 2014, Sarah Sharp wrote: Scatter-gather under xHCI seems to work fine on mass storage, but it fails with that particular ASIX device, because of how the xHCI driver sets up the buffers on the endpoint rings. We need to implement the TD fragment rules to avoid breaking this

RE: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread David Laight
From: Sarah Sharp ... The block layer may submit scatter-gather lists with entries that are multiples of 512-byte blocks. That's fine for USB 2.0 devices, where the bulk endpoint max packet size is 512 bytes. But USB 3.0 devices have bulk endpoints with a 1024 byte max packet size. That

Re: [PATCH v3 1/1] xhci: Prevent runtime pm from autosuspending during initialization

2014-03-04 Thread Greg KH
On Tue, Mar 04, 2014 at 01:50:55PM +0200, Mathias Nyman wrote: On 03/03/2014 08:37 PM, Greg KH wrote: On Mon, Mar 03, 2014 at 07:30:17PM +0200, Mathias Nyman wrote: xHCI driver has its own pci probe function that will call usb_hcd_pci_probe to register its usb-2 bus, and then continue to

[PATCH 1/4] usb: chipidea: switch over to endpoint feature flags

2014-03-04 Thread Felipe Balbi
switch over to endpoint feature flags so we can drop naming conventions. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/chipidea/udc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 80de2f8..e80dc82 100644 ---

[PATCH 3/4] usb: musb: gadget: switch over to endpoint feature flags

2014-03-04 Thread Felipe Balbi
switch over to endpoint feature flags so we can drop naming conventions. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/musb/musb_gadget.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c

[PATCH 1/2] usb: wusbcore: fix potential double list_del on urb dequeue

2014-03-04 Thread Thomas Pugliese
This patch locks rpipe-seg_lock around the entire transfer segment cleanup loop in wa_urb_dequeue instead of just one case of the switch statement. This fixes a race between __wa_xfer_delayed_run and wa_urb_dequeue where a transfer segment in the WA_SEG_DELAYED state could be removed from the

[PATCH 0/2] usb: wusbcore: additional urb dequeue cleanups

2014-03-04 Thread Thomas Pugliese
Fix two race conditions that could cause memory corruption when unlinking WUSB urbs. Thomas Pugliese (2): usb: wusbcore: fix potential double list_del on urb dequeue usb: wusbcore: don't mark WA_SEG_DTI_PENDING segs as done in urb_dequeue drivers/usb/wusbcore/wa-xfer.c | 19

[PATCH 2/2] usb: wusbcore: don't mark WA_SEG_DTI_PENDING segs as done in urb_dequeue

2014-03-04 Thread Thomas Pugliese
Data for transfer segments in the WA_SEG_DTI_PENDING state is actively being read by the driver. Let the buffer read callback handle the transfer cleanup since cleaning it up in wa_urb_dequeue will cause the read callback to access invalid memory if the transfer is completed. Signed-off-by:

Re: [PATCHv2] usb: dwc2: Add function to calculate correct FIFO sizes

2014-03-04 Thread Dinh Nguyen
On Tue, 2014-03-04 at 09:18 -0600, Felipe Balbi wrote: On Mon, Mar 03, 2014 at 09:25:13PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com The dwc2 IP on the SOCFPGA cannot use the default HW configured FIFO sizes. The total FIFO depth as read from GHWCFG3 reports

[PATCH 2/4] usb: renesas: switch over to endpoint feature flags

2014-03-04 Thread Felipe Balbi
switch over to endpoint feature flags so we can drop naming conventions. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/renesas_usbhs/mod_gadget.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c

Re: [PATCHv2] usb: dwc2: Add function to calculate correct FIFO sizes

2014-03-04 Thread Felipe Balbi
Hi, On Tue, Mar 04, 2014 at 11:34:26AM -0600, Dinh Nguyen wrote: On Tue, 2014-03-04 at 09:18 -0600, Felipe Balbi wrote: On Mon, Mar 03, 2014 at 09:25:13PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com The dwc2 IP on the SOCFPGA cannot use the default HW

Re: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Sarah Sharp
On Tue, Mar 04, 2014 at 10:00:16AM -0500, Alan Stern wrote: On Tue, 4 Mar 2014, David Laight wrote: Notice the request length: 1536. That's three 512-byte sectors. A little unusual, since most I/O is done in units of pages, which are 4096 bytes. Ok, we can't have SuperSpeed

Re: 3.13-rc1 regression: Scatter-gather list issues at SuperSpeed only

2014-03-04 Thread Alan Stern
On Tue, 4 Mar 2014, Sarah Sharp wrote: David is right; this problem can't be fixed simply by reverting patches. The real problem is that the block layer has handed the USB stack an SG list that xhci-hcd cannot handle at all, in its current form. We do not know if the driver not

Re: [PATCH 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests

2014-03-04 Thread Greg Kroah-Hartman
On Tue, Mar 04, 2014 at 10:53:06AM -0800, Julius Werner wrote: The DELAY_INIT quirk only reduces the frequency of enumeration failures with the Logitech HD Pro C920 and C930e webcams, but does not quite eliminate them. We have found that adding a delay of 100ms between the first and second Get

[PATCH 12/12] staging: usbip: userspace: update dependencies in README

2014-03-04 Thread Valentina Manea
Add libudev as dependency and remove libsysfs. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/usbip/userspace/README

[PATCH 06/12] staging: usbip: userspace: add new list API

2014-03-04 Thread Valentina Manea
Add a new list API from CCAN. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- .../staging/usbip/userspace/libsrc/build_assert.h | 40 ++ .../staging/usbip/userspace/libsrc/check_type.h| 64 +++

[PATCH 09/12] staging: usbip: userspace: remove class device infrastructure in vhci_driver

2014-03-04 Thread Valentina Manea
The class device lists were used only when being initialized, being populated and being destroyed. They had no real meaning and thus the code was useless. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/vhci_driver.c | 178 -

[PATCH 08/12] staging: usbip: userspace: migrate usbip_host_driver to libudev

2014-03-04 Thread Valentina Manea
This patch modifies usbip_host_driver to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/usbip_common.c | 74 ++ .../staging/usbip/userspace/libsrc/usbip_common.h | 5 +- .../usbip/userspace/libsrc/usbip_host_driver.c |

[PATCH 10/12] staging: usbip: userspace: migrate vhci_driver to libudev

2014-03-04 Thread Valentina Manea
This patch migrates vhci_driver to libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- .../staging/usbip/userspace/libsrc/usbip_common.h | 1 - .../staging/usbip/userspace/libsrc/vhci_driver.c | 154 ++--- .../staging/usbip/userspace/libsrc/vhci_driver.h

[PATCH 07/12] staging: usbip: userspace: move sysfs_utils to libsrc

2014-03-04 Thread Valentina Manea
Since it offers a API to both usbip tools and libusbip, it is more appropriate to be place in the library. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- .../staging/usbip/userspace/libsrc/sysfs_utils.c | 36

[PATCH 03/12] staging: usbip: userspace: migrate usbip_unbind to libudev

2014-03-04 Thread Valentina Manea
This patch modifies usbip_unbind to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_unbind.c | 92 +++--- 1 file changed, 29 insertions(+), 63 deletions(-) diff --git

[PATCH 02/12] staging: usbip: userspace: remove useless libsysfs includes

2014-03-04 Thread Valentina Manea
This patch removes useless libsysfs.h includes in various userspace files. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_attach.c | 1 - drivers/staging/usbip/userspace/src/usbip_detach.c | 2 --

[PATCH 05/12] staging: usbip: userspace: re-add interface information listing

2014-03-04 Thread Valentina Manea
This was deleted in the driver conversion patch. It didn't need to be deleted; showing more information is ok. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 20 +++- drivers/staging/usbip/userspace/src/usbipd.c

[PATCH 01/12] staging: usbip: userspace: migrate usbip_bind to libudev

2014-03-04 Thread Valentina Manea
This patch adds autoconf check for libudev and migrates usbip_bind to the new library. libsysfs will still be used until all userspace is modified. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 6 +

[PATCH 04/12] staging: usbip: userspace: migrate usbip_list to libudev

2014-03-04 Thread Valentina Manea
This patch modifies usbip_list to use libudev. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/src/usbip_list.c | 137 +-- 1 file changed, 51 insertions(+), 86 deletions(-) diff --git

[PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-04 Thread Valentina Manea
Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac b/drivers/staging/usbip/userspace/configure.ac index 25bf160..607d05c

Re: [PATCH] staging: usbip: userspace: increase version to 2.0

2014-03-04 Thread Greg KH
On Tue, Mar 04, 2014 at 09:16:39PM +0200, Valentina Manea wrote: Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/userspace/configure.ac

[PATCH] staging: usbip: let client choose device configuration

2014-03-04 Thread Valentina Manea
Since usbip-host is now a device driver and the client has full access to the shared device, it makes sense to let the client choose device configuration. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 10 +-

[PATCH] staging: usbip: trigger driver probing after unbinding from usbip-host

2014-03-04 Thread Valentina Manea
A sysfs attribute is used to announce kernel space that a new driver probing session should be triggered for the just unbinded device. In order to have the address of struct device associated to this USB device, a new member has been added to struct bus_id_priv. Signed-off-by: Valentina Manea

[PATCH] staging: usbip: claim ports used by shared devices

2014-03-04 Thread Valentina Manea
Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/stub_dev.c | 22 ++ drivers/usb/core/devio.c | 17 - drivers/usb/core/hub.c | 2 ++ drivers/usb/core/usb.h | 6 +- include/linux/usb.h

Re: [PATCH 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests

2014-03-04 Thread Julius Werner
What am I supposed to do with this line? :) Oh damn, sorry, forgot to take that out on the second one. We have this really annoying commit hook that adds them automatically. v2 incoming... -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to

[PATCH v2 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests

2014-03-04 Thread Julius Werner
The DELAY_INIT quirk only reduces the frequency of enumeration failures with the Logitech HD Pro C920 and C930e webcams, but does not quite eliminate them. We have found that adding a delay of 100ms between the first and second Get Configuration request makes the device enumerate perfectly

Re: [PATCH] Remove fifo sizes from dwc2 usb driver from socfpga.dtsi

2014-03-04 Thread Dinh Nguyen
On 03/03/2014 08:42 PM, Felipe Balbi wrote: Hi, On Mon, Mar 03, 2014 at 05:09:27PM -0600, dingu...@altera.com wrote: From: Dinh Nguyen dingu...@altera.com Remove reading the fifo sizes from dts in platform.c Add dwc2_calculate_dynamic_fifo Conflicts: arch/arm/boot/dts/socfpga.dtsi

[PATCH] staging: usbip: userspace: don't throw error when trying to read configuration specific attributes

2014-03-04 Thread Valentina Manea
When a device has just been bound to usbip-host but the client hasn't set a configuration on it, certain attributes will not exist. Don't treat this as an error. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 17

[PATCH] staging: usbip: userspace: add hwdata as optional dependency in README

2014-03-04 Thread Valentina Manea
This is an optional dependency since USB/IP can fully work without it. However, it is needed to display device information such as vendor. Signed-off-by: Valentina Manea valentina.mane...@gmail.com --- drivers/staging/usbip/userspace/README | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH] staging: usbip: claim ports used by shared devices

2014-03-04 Thread Alan Stern
On Tue, 4 Mar 2014, Valentina Manea wrote: diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 90e18f6..a91dc1f 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -62,23 +62,6 @@ /* Mutual exclusion for removal, open, and release */

Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()

2014-03-04 Thread Michal Nazarewicz
On 03/04/2014 10:34 AM, Chuansheng Liu wrote: @@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) * we may end up with more data then user space has * space for. */ -

Re: [PATCH v2] usb: gadget: return the right length in ffs_epfile_io()

2014-03-04 Thread Felipe Balbi
On Tue, Mar 04, 2014 at 08:53:40PM +0100, Michal Nazarewicz wrote: On 03/04/2014 10:34 AM, Chuansheng Liu wrote: @@ -845,12 +845,14 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) * we may end up with more data then user space

Re: [PATCH net-next 07/12] r8152: support rx checksum

2014-03-04 Thread David Miller
From: Hayes Wang hayesw...@realtek.com Date: Tue, 4 Mar 2014 20:00:59 +0800 @@ -1453,11 +1491,19 @@ static void rx_bottom(struct r8152 *tp) pkt_len -= CRC_SIZE; rx_data += sizeof(struct rx_desc); + checksum = r8152_rx_csum(tp,

Re: xhci-errors in combination with dm-crypt

2014-03-04 Thread Sarah Sharp
Comments below. On Mon, Mar 03, 2014 at 10:55:13PM +0100, Merlin Chlosta wrote: Hello everyone, I'd like to encrypt my external HDD using dm-crypt (luks) via USB 3.0. The crypto-container creation works, but writing to it doesn't: kernel: usb 4-2: reset SuperSpeed USB device number 2

  1   2   >