RE: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

> -Original Message- > From: Peter Chen [mailto:hzpeterc...@gmail.com] > Sent: Wednesday, May 25, 2016 10:44 AM > To: Roger Quadros > Cc: peter.c...@freescale.com; ba...@kernel.org; t...@atomide.com; > gre...@linuxfoundation.org; dan.j.willi...@intel.com; >

Re: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

On Tue, May 24, 2016 at 12:45:46PM +0300, Roger Quadros wrote: > Hi Peter, > > I have one question here. Please see below. > > On 13/05/16 13:03, Roger Quadros wrote: > > It provides APIs for the following tasks > > > > - Registering an OTG/dual-role capable controller > > - Registering Host

Re: [PATCH V3 RESEND] phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

Hi Rafal, some comments in line. On 16-05-22 03:09 PM, Rafał Miłecki wrote: > Northstar is a family of SoCs used in home routers. They have USB 2.0 > and 3.0 controllers with PHYs that need to be properly initialized. > This driver provides PHY init support in a generic way and can be bound >

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Thu, May 19, 2016 at 03:44:54PM +0300, Heikki Krogerus wrote: > The purpose of this class is to provide unified interface for user > space to get the status and basic information about USB Type-C > Connectors in the system, control data role swapping, and when USB PD > is available, also power

[PATCH] dwc3-exynos: Fix deferred probing storm.

dwc3-exynos has two problems during init if the regulators are slow to come up (for instance if the I2C bus driver is not on the initramfs) and return probe deferral. First, every time this happens, the driver leaks the USB phys created; they need to be deallocated on error. Second, since the phy

[PATCH] Re: Endless "supply vcc not found, using dummy regulator"

On Tue, May 24, 2016 at 05:53:34PM +0200, Krzysztof Kozlowski wrote: > exynos->clk = devm_clk_get(dev, "usbdrd30"); > if (IS_ERR(exynos->clk)) { > + // On each error path since here we need to > + // revert work done by dwc3_exynos_register_phys() >

Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver

Hi Neil, On Tuesday 24 May 2016 16:16:16 Neil Armstrong wrote: > Hi Felipe, Laurent, > > I submitted this driver for a Cadence IP library from a now abandoned > project. > > The driver was working on a SoC platform ported on a FPGA, but I do not have > access to this HW anymore. > > But I have

AW: ffs-test fails with warning (-19) No such device

> You shouldn't use epX where X != 0 until you get enable event. You may > refer to ffs-aio examples which have a suitable flag to wait for that event. I got the ffs-aio example (simple and multibuff) to work. I also used the ffs-aio example as a reference and tried to get the ffs-test example

Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver

Hi, (please break lines at 80-columns and don't top-post ;) Neil Armstrong writes: > [ Unknown signature status ] > Hi Felipe, Laurent, > > I submitted this driver for a Cadence IP library from a now abandoned > project. > > The driver was working on a SoC platform

Re: [PATCH] usb: core: add debugobjects support for urb object

On Tue, 24 May 2016 changbin...@intel.com wrote: > From: "Du, Changbin" > > Add debugobject support to track the life time of struct urb. > This feature help us detect violation of urb operations by > generating a warning message from debugobject core. I'm pretty sure

Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver

Hi Felipe, Laurent, I submitted this driver for a Cadence IP library from a now abandoned project. The driver was working on a SoC platform ported on a FPGA, but I do not have access to this HW anymore. But I have a fixed version... Now, I am looking for SoCs, vendors and even Cadence people

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On 05/19/2016 05:44 AM, Heikki Krogerus wrote: The purpose of this class is to provide unified interface for user space to get the status and basic information about USB Type-C Connectors in the system, control data role swapping, and when USB PD is available, also power role swapping and

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote: Hi, as this discussion seems to go in circles, I am starting anew at the top. > Like I've told some of you guys, I'm trying to implement a bus for > the Alternate Modes, but I'm still nowhere near finished with that > one, so let's just

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote: > Hi, > > On 23-05-16 19:36, James Bottomley wrote: > > On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: > > > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host > > > level") > > > removed the scsi_change_queue_depth()

Re: [PATCH v8 5/5] usb: dwc3: core: cleanup IRQ resources

On 24/05/16 12:35, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Implementations might use different IRQs for >> host, gadget and OTG so use named interrupt resources >> to allow Device tree to specify the 3 interrupts. >> >> Following are the interrupt names >> >>

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, May 24, 2016 at 12:18:38PM +0200, Oliver Neukum wrote: > On Tue, 2016-05-24 at 13:08 +0300, Heikki Krogerus wrote: > > Hi Guenter, > > > > On Mon, May 23, 2016 at 09:52:12AM -0700, Guenter Roeck wrote: > > > On Mon, May 23, 2016 at 05:55:04PM +0200, Oliver Neukum wrote: > > > > On Mon,

Re: xhci DWC3 flavor problem

Hi João, (please avoid top-posting ;) Joao Pinto writes: > Hi, > Just to give you an update. > All is working great, the cause was an FPGA configuration issue. > Thank you for your support. good to know :) -- balbi signature.asc Description: PGP signature

Re: xhci DWC3 flavor problem

Hi, Just to give you an update. All is working great, the cause was an FPGA configuration issue. Thank you for your support. Joao On 5/19/2016 4:42 PM, Joao Pinto wrote: > > After a few moments the schedule problem happen again: > > # INFO: task kworker/0:1:349 blocked for more than 120

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Tue, 2016-05-24 at 13:08 +0300, Heikki Krogerus wrote: > Hi Guenter, > > On Mon, May 23, 2016 at 09:52:12AM -0700, Guenter Roeck wrote: > > On Mon, May 23, 2016 at 05:55:04PM +0200, Oliver Neukum wrote: > > > On Mon, 2016-05-23 at 07:43 -0700, Guenter Roeck wrote: > > > > On 05/23/2016 06:58

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

Hi Guenter, On Mon, May 23, 2016 at 09:52:12AM -0700, Guenter Roeck wrote: > On Mon, May 23, 2016 at 05:55:04PM +0200, Oliver Neukum wrote: > > On Mon, 2016-05-23 at 07:43 -0700, Guenter Roeck wrote: > > > On 05/23/2016 06:58 AM, Oliver Neukum wrote: > > > > > > Now I am confused. Are you saying

Re: [PATCH v8 08/14] usb: otg: add OTG/dual-role core

Hi Peter, I have one question here. Please see below. On 13/05/16 13:03, Roger Quadros wrote: > It provides APIs for the following tasks > > - Registering an OTG/dual-role capable controller > - Registering Host and Gadget controllers to OTG core > - Providing inputs to and kicking the OTG

Re: [PATCH v8 5/5] usb: dwc3: core: cleanup IRQ resources

Hi, Roger Quadros writes: > Implementations might use different IRQs for > host, gadget and OTG so use named interrupt resources > to allow Device tree to specify the 3 interrupts. > > Following are the interrupt names > > Peripheral Interrupt - peripheral > HOST Interrupt - host

Re: [PATCH v2 5/5] usb: dwc3: rockchip: add devicetree bindings documentation

Hi, William Wu writes: > This patch documents the device tree documentation required for > Rockchip USB3.0 core wrapper consist of USB3.0 IP from Synopsys. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS, LS). > > Signed-off-by: William Wu

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Mon, May 23, 2016 at 01:25:19PM +0200, Oliver Neukum wrote: > So for Alternate Modes we need on a high level the following features > > 1. discovery of available Alternate Modes > 2. selection of an Alternate Mode > 3. notification about entering an Alternate Mode > 4. triggering a reset > 5.

Re: [uas/scsi] untagged commands?

Hi, On 24-05-16 10:18, Tom Yan wrote: In this commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb There is the following comment: 1 tag is reserved for untagged commands So my question is, what

Re: [RFC PATCHv2] usb: USB Type-C Connector Class

On Mon, 2016-05-23 at 10:09 -0700, Guenter Roeck wrote: > On Mon, May 23, 2016 at 01:25:19PM +0200, Oliver Neukum wrote: > > On Mon, 2016-05-23 at 12:57 +0300, Heikki Krogerus wrote: > > > > A reset is a generic function, so it does not belong to specific > > drivers. > > > A would expect the

[PATCH V3 2/2] usb: musb: Stop bulk endpoint while queue is rotated

Ensure that the endpoint is stopped by clearing REQPKT before clearing DATAERR_NAKTIMEOUT before rotating the queue on the dedicated bulk endpoint. This addresses an issue where a race could result in the endpoint receiving data before it was reprogrammed resulting in a warning about such data

[PATCH V3 1/2] usb: musb: Ensure rx reinit occurs for shared_fifo endpoints

shared_fifo endpoints would only get a previous tx state cleared out, the rx state was only cleared for non shared_fifo endpoints Change this so that the rx state is cleared for all endpoints. This addresses an issue that resulted in rx packets being dropped silently. Signed-off-by: Andrew

Re: [PATCH 5/5] usb: dwc3: Endianness issue on dwc3_log_ctrl

John Youn writes: > Sparse complains even though it looks ok. Probably it cannot detect that > the wValue, wIndex, and wLength are declared __le16 due to the macro > magic. should we fix sparse, instead? Oh well, doesn't hurt applying. > > Redeclare them as CPU endianness

[uas/scsi] untagged commands?

In this commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb There is the following comment: > 1 tag is reserved for untagged commands So my question is, what exactly are "untagged commands"? If we

[PATCH] usb: core: add debugobjects support for urb object

From: "Du, Changbin" Add debugobject support to track the life time of struct urb. This feature help us detect violation of urb operations by generating a warning message from debugobject core. And we fix the possible issues at runtime to avoid oops if we can. I have done

Re: [PATCH v2 1/1] uas: remove can_queue set in host template

Hi, On 23-05-16 21:28, tom.t...@gmail.com wrote: From: Tom Yan Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made qdepth limit set in host template (`.can_queue = MAX_CMNDS`) redundant. Removing it to avoid confusion. Signed-off-by: Tom Yan