[PATCH -next] usb: renesas_usbhs: gadget: fix return value check in usbhs_mod_gadget_probe()

2016-08-12 Thread Wei Yongjun
In case of error, the function usb_get_phy() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/usb/renesas_usbhs/mod_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v5 0/5] da8xx USB PHY platform devices and clocks (was "da8xx UBS clocks")

2016-08-12 Thread Kevin Hilman
On Wed, May 25, 2016 at 6:18 AM, Sekhar Nori wrote: > On Monday 23 May 2016 08:44 PM, David Lechner wrote: >> On 05/09/2016 06:46 PM, David Lechner wrote: >>> v5 changes: renamed "usbphy" to "usb_phy" or "usb-phy" as appropriate >>> [...] >> >> What should I be doing to keep

[PATCH 2/2] usb: gadget: f_ncm: add support for scatter/gather SKB to enable GSO

2016-08-12 Thread Jussi Kivilinna
Enabling SG allows enabling GSO (generic segmentation offload) feature of linux networking layer. This increases TCP throughput with NCM on Cortex-A15+USB3380 based device from 300 Mbit/s to 1.1 Gbit/s. Signed-off-by: Jussi Kivilinna --- drivers/usb/gadget/Kconfig

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-12 Thread Alan Stern
On Fri, 12 Aug 2016, Binyamin Sharet wrote: > Hi, > > I'm using GadgetFs for USB host fuzzing (using umap2), > and part of the fuzzing session is to send invalid descriptors at > various stages. > > However, some requests are not delegated to user-land (see gadgetfs_setup() > in

Re: Gadgetfs - adding support for delegation of setup requests

2016-08-12 Thread Greg KH
On Fri, Aug 12, 2016 at 09:44:17PM +0300, Binyamin Sharet wrote: > Hi, > > I'm using GadgetFs for USB host fuzzing (using umap2), > and part of the fuzzing session is to send invalid descriptors at > various stages. > > However, some requests are not delegated to user-land (see gadgetfs_setup()

[PATCH 2/2] usb: gadget: net2280: match interrupt endpoints to PIO endpoints and DMA to bulk

2016-08-12 Thread Jussi Kivilinna
With composite gadget (ACM + NCM), USB3380 to host TCP transfer speed dropped to 150 Mbit/s compared to 900 Mbit/s with NCM gadget. Problem seems to be that net2280/USB3380 has only four DMA channels and those DMA channels are allocated to first HW endpoints. Endpoint match function was mapping

Gadgetfs - adding support for delegation of setup requests

2016-08-12 Thread Binyamin Sharet
Hi, I'm using GadgetFs for USB host fuzzing (using umap2), and part of the fuzzing session is to send invalid descriptors at various stages. However, some requests are not delegated to user-land (see gadgetfs_setup() in gadget/legacy/inode.c), Specifically - GET_DESCRIPTOR (device/configuration)

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-12 Thread ayaka
On 08/13/2016 01:44 AM, Greg KH wrote: On Sat, Aug 13, 2016 at 12:38:46AM +0800, ayaka wrote: On 08/12/2016 03:40 PM, Greg KH wrote: On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote: Hello all: I recently add a support for customize am3358 board using the branch

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-12 Thread Greg KH
On Sat, Aug 13, 2016 at 12:38:46AM +0800, ayaka wrote: > > > On 08/12/2016 03:40 PM, Greg KH wrote: > > On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote: > > > Hello all: > > >I recently add a support for customize am3358 board using the branch > > > processor-sdk-linux-03.00.00 from Ti

Re: xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-12 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On Fri, 2016-08-12 at 11:48 -0400, Alan Stern wrote: > > These could indicate some sort of problem with the driver for the xHCI > controller.  However, I'm not an expert on xhci-hcd.  Mathias is the > maintainer for that driver. Okay! So I'll wait

[PATCH 1/2] usb: gadget: net2280: fix infinite loop in irq handler

2016-08-12 Thread Jussi Kivilinna
With SuperSpeed CDC NCM gadget, net2280 would get stuck in 'handle_ep_small' function. Triggering issue requires large TCP transfer from host to USB3380. Patch adds check for stuck condition and prevents hard lockup. Signed-off-by: Jussi Kivilinna ---

[PATCH 1/2] usb: gadget: f_ncm: add SuperSpeed descriptors for CDC NCM

2016-08-12 Thread Jussi Kivilinna
Patch enables SuperSpeed for NCM gadget. Tested with USB3380 and measured TCP throughput with two Intel PCs: udc to host: 920 Mbit/s host to udc: 550 Mbit/s Signed-off-by: Jussi Kivilinna --- drivers/usb/gadget/function/f_ncm.c | 82

[PATCH] xhci: really enqueue zero length TRBs.

2016-08-12 Thread Alban Browaeys
Enqueue the first TRB even if full_len is zero. Without this "adb install " freezes the system. Signed-off-by: Alban Browaeys Fixes: 86065c2719a5 ("xhci: don't rely on precalculated value of needed trbs in the enqueue loop") --- drivers/usb/host/xhci-ring.c | 3 ++- 1

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-12 Thread ayaka
On 08/12/2016 03:40 PM, Greg KH wrote: On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote: Hello all: I recently add a support for customize am3358 board using the branch processor-sdk-linux-03.00.00 from Ti git. But I meet a problem with musb at the peripheral mode. Then you are going

[balbi-usb:testing/next 29/34] drivers/usb/dwc3/gadget.c:1934:2: note: in expansion of macro 'list_for_each_entry_safe'

2016-08-12 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: d2382d0a64910749af50c8c3d46b96a64c85a9c5 commit: 3e37d7b8ce45e9503d9a189a087b7431a963344d [29/34] usb: dwc3: gadget: avoid while (1) loop on completion config: xtensa-allmodconfig (attached as .config)

xHCI problem? [was Re: Erratic USB device behavior and device loss]

2016-08-12 Thread Alan Stern
On Fri, 12 Aug 2016, Ritesh Raj Sarraf wrote: > So I booted into Windows 8.1 and tried to access an SDCard over the Card > Reader. > I was able to see the drive and read the content in it. > I did check for relevant messages in the Windows Event Log but couldn't find > anything relevant. > >

[balbi-usb:testing/next 29/34] drivers/usb/dwc3/gadget.c:1934:2: error: expected expression before '=' token

2016-08-12 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: d2382d0a64910749af50c8c3d46b96a64c85a9c5 commit: 3e37d7b8ce45e9503d9a189a087b7431a963344d [29/34] usb: dwc3: gadget: avoid while (1) loop on completion config: tile-allmodconfig (attached as .config)

Re: [PATCH RESEND v2 3/3] ehci-platform: add the max clock number to 4

2016-08-12 Thread Alan Stern
On Fri, 12 Aug 2016, Icenowy Zheng wrote: > Allwinner A64 EHCI requires 4 clocks to be enabled. > > Signed-off-by: Icenowy Zheng > --- > drivers/usb/host/ehci-platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-platform.c

Re: Slow writes with dd on Lexar JumpDrive P20 64GB flash drives connected via Intel USB 3.0 host controllers

2016-08-12 Thread Alan Stern
On Fri, 12 Aug 2016, Felipe Balbi wrote: > Alan Stern writes: > > > On Tue, 31 May 2016, Michael Schaller wrote: > > > >> Is there anything else I can do to debug this issue further? > >> Are there any quirks I could try? > >> > >> On Wed, May 18, 2016 at 3:41 PM,

Re: [PATCH 3/3] ARM: dts: imx6q-evi: Fix onboard hub reset line

2016-08-12 Thread Joshua Clayton
Hi Peter, On 08/11/2016 08:11 PM, Peter Chen wrote: > On Thu, Aug 11, 2016 at 09:40:32AM -0700, Joshua Clayton wrote: >> Previously the onboard hub was made to work by treating its >> reset gpio as a regulator enable. >> Get rid of that kludge now that pwseq has added reset gpio support >> Move

Re: [GIT PULL] USB-serial fixes for v4.8-rc2

2016-08-12 Thread Greg Kroah-Hartman
On Fri, Aug 12, 2016 at 10:00:21AM +0200, Johan Hovold wrote: > Hi Greg, > > Here's a first set of fixes and device ids for 4.8-rc. > > Thanks, > Johan > > > The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: > > Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) > > are

RE: [PATCH] usb: chipidea: udc: don't touch DP when controller is in host mode

2016-08-12 Thread Jun Li
Hi, > -Original Message- > From: Peter Chen [mailto:hzpeterc...@gmail.com] > Sent: Friday, August 12, 2016 4:48 PM > To: Jun Li > Cc: Peter Chen ; linux-usb@vger.kernel.org > Subject: Re: [PATCH] usb: chipidea: udc: don't touch DP when controller is >

Re: USB Networking

2016-08-12 Thread Patrick Doyle
On Fri, Aug 12, 2016 at 6:35 AM, Felipe Balbi wrote: > I'm guessing you need to ask for support from the people who gave you > this v3.10 kernel. IIRC, Edison has a support forum. In this mailing > list we can only help out if you're using the mainline kernel. > >

Re: Erratic USB device behavior and device loss

2016-08-12 Thread Ritesh Raj Sarraf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello Alan, On Thu, 2016-08-11 at 23:12 +0530, Ritesh Raj Sarraf wrote: > On Thu, 2016-08-11 at 13:01 -0400, Alan Stern wrote: > > > I guess so. I get frequent resets on my USB port for some of the hardware. > > >  > > > kernel: usb 2-1: reset

[PATCH -next] usbip: vhci_hcd: fix return value check in add_platform_device()

2016-08-12 Thread Wei Yongjun
In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/usb/usbip/vhci_hcd.c | 4 ++-- 1 file changed, 2

Re: [PATCH V4] phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-08-12 Thread Rafał Miłecki
On 12 August 2016 at 11:46, Kishon Vijay Abraham I wrote: > On Friday 12 August 2016 03:58 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> Northstar is a family of SoCs used in home routers. They have USB 2.0 >> and 3.0 controllers with PHYs that need to be

Re: USB Networking

2016-08-12 Thread Felipe Balbi
Hi, Patrick Doyle writes: > I have two embedded Linux devices connected via USB. Both show usb0 > devices. One shows the network as RUNNING: > > device1# ifconfig usb0 > usb0 Link encap:Ethernet HWaddr 96:2E:28:4C:23:7C > inet addr:192.168.186.2

Re: Slow writes with dd on Lexar JumpDrive P20 64GB flash drives connected via Intel USB 3.0 host controllers

2016-08-12 Thread Felipe Balbi
Alan Stern writes: > On Tue, 31 May 2016, Michael Schaller wrote: > >> Is there anything else I can do to debug this issue further? >> Are there any quirks I could try? >> >> On Wed, May 18, 2016 at 3:41 PM, Michael Schaller wrote: >> > [1.] One

Re: [PATCH v9 2/4] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-08-12 Thread Kishon Vijay Abraham I
Hi, On Friday 22 July 2016 12:30 PM, Frank Wang wrote: > The newer SoCs (rk3366, rk3399) take a different usb-phy IP block > than rk3288 and before, and most of phy-related registers are also > different from the past, so a new phy driver is required necessarily. > > Signed-off-by: Frank Wang

Re: [PATCH RESEND v2 1/3] dt: bindings: add bindings for Allwinner A64 usb phy

2016-08-12 Thread Kishon Vijay Abraham I
On Friday 12 August 2016 08:36 AM, Icenowy Zheng wrote: > Signed-off-by: Icenowy Zheng Added "Update sun4i usb phy dt binding documentation to include support for Allwinner A64 usb phy." and then merged this. Thanks Kishon > --- >

Re: [PATCH RESEND v2 2/3] phy: sun4i: add support for A64 usb phy

2016-08-12 Thread Kishon Vijay Abraham I
On Friday 12 August 2016 08:36 AM, Icenowy Zheng wrote: > There's something unknown in the pmu part that shared with H3. > It's renamed as PMU_UNK1 from PMU_UNK_H3. > > Signed-off-by: Icenowy Zheng Fixed the following checkpatch warning and merged this to linux-phy tree.

Re: [PATCH V4] phy: bcm-ns-usb3: new driver for USB 3.0 PHY on Northstar

2016-08-12 Thread Kishon Vijay Abraham I
Hi, On Friday 12 August 2016 03:58 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Northstar is a family of SoCs used in home routers. They have USB 2.0 > and 3.0 controllers with PHYs that need to be properly initialized. > This driver provides PHY init support in a

Re: [PATCH] usb: chipidea: udc: don't touch DP when controller is in host mode

2016-08-12 Thread Peter Chen
On Thu, Aug 11, 2016 at 06:52:45PM +0800, Li Jun wrote: > When the controller is configured to be dual role and it's in host mode, > if bind udc and gadgt driver, those gadget operations will do gadget > disconnect and finally pull down DP line, which will break host function. > > Signed-off-by:

Re: [PATCH resend 0/1] phy-sun4i-usb: Add support for peripheral-only mode

2016-08-12 Thread Kishon Vijay Abraham I
On Tuesday 09 August 2016 01:25 AM, Hans de Goede wrote: > Hi Kishon, > > As discussed before, here is a resend now that rc1 is out (and includes > the new of_usb_get_dr_mode_by_phy helper this patch needs). > > Please merge this for 4.9-rcX some of the musb-sunxi glue changes > already merged

Re: [PATCH RESEND v2 1/3] dt: bindings: add bindings for Allwinner A64 usb phy

2016-08-12 Thread Hans de Goede
Hi, On 12-08-16 05:06, Icenowy Zheng wrote: Signed-off-by: Icenowy Zheng Series is still: Reviewed-by: Hans de Goede Regards, Hans --- Documentation/devicetree/bindings/phy/sun4i-usb-phy.txt | 1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH v4 2/3] usbip: vhci extension: modifications to userspace

2016-08-12 Thread fx IWATA NOBUO
> Please resend the patches you wish to have applied, in the order in which > they need to be applied in. OK. I will resend them after fixing dynamically allocated sysfs attribute checking error when CONFIG_DEBUG_LOCK_ALLOC is set. Thank you, n.iwata // > -Original Message- > From:

[GIT PULL] USB-serial fixes for v4.8-rc2

2016-08-12 Thread Johan Hovold
Hi Greg, Here's a first set of fixes and device ids for 4.8-rc. Thanks, Johan The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at:

[PATCH] cdc-acm: fix wrong pipe type on rx interrupt xfers

2016-08-12 Thread gavinli
From: Gavin Li This fixes the "BOGUS urb xfer" warning logged by usb_submit_urb(). Signed-off-by: Gavin Li --- drivers/usb/class/cdc-acm.c | 5 ++--- drivers/usb/class/cdc-acm.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: musb: am3358: having problem with high-speed on usb1 at peripheral

2016-08-12 Thread Greg KH
On Fri, Aug 12, 2016 at 10:23:15AM +0800, ayaka wrote: > Hello all: > I recently add a support for customize am3358 board using the branch > processor-sdk-linux-03.00.00 from Ti git. But I meet a problem with musb > at the peripheral mode. Then you are going to have to get support from TI for