Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

Hi Kishon, On Thursday 03 November 2016 10:20 PM, Kishon Vijay Abraham I wrote: > > > On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: >> There is only one ohci on the da8xx series of chips, >> so remove the ".0" when creating the phy. Also add >> the "-da8xx" postfix to be consistent

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

On Thu, Nov 03, 2016 at 12:48:08PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> > Peter Chen writes: > >> > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> > >> From: Peter Chen > >> >

Re: [PATCH] usb: dwc2: gadget: Update for new usb_endpoint_maxp()

On 11/1/2016 4:14 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> From: Vardan Mikayelyan >> >> Update the dwc2 driver for the new behavior of the usb_endpoint_maxp() >> and also use the new usb_endpoint_maxp_mult() helper function. >> >>

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

On Thu, Nov 03, 2016 at 12:50:43PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Peter Chen writes: > >> >> Peter Chen

[PATCH v2 1/5] usb: dwc3: Add a check for the DWC_usb3 core

Add a helper function to check if we are running on a DWC_usb3 core. Signed-off-by: John Youn --- drivers/usb/dwc3/core.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 2322863..c22b38b 100644 ---

[PATCH v2 0/5] usb: dwc3: Interrupt moderation

This patch series implements interrupt moderation and also uses it in implementing a workaround for STAR 9000961433. v2: * Remove the devicetree binding John Youn (5): usb: dwc3: Add a check for the DWC_usb3 core usb: dwc3: Add a function to check properties usb: dwc3: gadget: Write the

[PATCH v2 5/5] usb: dwc3: Workaround for irq mask issue

This is a workaround for STAR 9000961433 which affects only version 3.00a of the DWC_usb3 core. This prevents the controller interrupt from being masked while handling events. Enabling interrupt moderation allows us to work around this issue because once the GEVNTCOUNT.count is written the IRQ is

[PATCH v2 3/5] usb: dwc3: gadget: Write the event count in interrupt

Since we are saving the event count and handling the events in the threaded interrupt handler, we can write and clear out the eventcount in the hard interrupt handler itself. This behavior will be required for IP 3.00a cores that need to use interrupt moderation as a workaround for an RTL issue

[PATCH v2 2/5] usb: dwc3: Add a function to check properties

Add a function to check properties and call it from probe. This will allow us to add check code without bloating the probe function. This needs to be done after dwc3_get_properties() and dwc3_core_init() so that all the properties and hardware configs are available. Signed-off-by: John Youn

[PATCH v2 4/5] usb: dwc3: Implement interrupt moderation

Implement interrupt moderation which allows the interrupt rate to be throttled. To enable this feature the dwc->imod_interval must be set to 1 or greater. This value specifies the minimum inter-interrupt interval, in 250 ns increments. A value of 0 disables interrupt moderation. This applies for

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

On Thu, Nov 03, 2016 at 12:42:11PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> Peter Chen writes: > >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> >> From: Peter Chen > >> >> Date:

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

On Thu, Nov 03, 2016 at 12:42:11PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> Peter Chen writes: > >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> >> From: Peter Chen > >> >> Date:

[PATCH v2 07/13] usb: dwc2: Remove unnecessary prototypes

Remove the unnecessary prototypes for all the parameter setting functions and declare those functions 'static' in the params.c file. Also remove the duplicate documentation that went along with them. They are already documented as part of the params structure definition. Then move the constants

[PATCH v2 05/13] usb: dwc2: Move parameter initialization into params.c

Consolidate and move all the parameter initialization code from the probe function to params.c. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 3 +++ drivers/usb/dwc2/params.c | 29 + drivers/usb/dwc2/platform.c | 27

[PATCH v2 11/13] Documentation: devicetree: dwc2: Add host DMA binding

Add the snps,host-dma-disable binding. This controls whether to disable DMA in host mode. Signed-off-by: John Youn --- Documentation/devicetree/bindings/usb/dwc2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/dwc2.txt

[PATCH v2 12/13] usb: dwc2: Get host DMA device properties

The driver will automatically enable host DMA and use it if available. This is consistent with the behavior of all existing platforms. Read in the "snps,host-dma-disable" device property to disable it. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 6 +-

[PATCH v2 10/13] usb: dwc2: Rename the dma_enable parameter to host_dma

Rename it so that it is more consistent with the gadget dma parameter. It only affects host-mode operation so prefix it with "host". Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 4 ++-- drivers/usb/dwc2/hcd.c | 54

[PATCH v2 08/13] usb: dwc2: Rename host_rx_fifo_size hardware parameter

This hardware parameter is not host specific. It also applies to device mode. Drop the "host" from the name to make that clear. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 2 +- drivers/usb/dwc2/params.c | 10 +- 2 files changed, 6 insertions(+), 6

[PATCH v2 06/13] usb: dwc2: Remove dwc2_set_all_params function

Replace this by statically defining a function with defaults, and just assigning it. This will allow us to use parameters of any type and any default value. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 2 -- drivers/usb/dwc2/params.c | 78

[PATCH v2 09/13] usb: dwc2: Move gadget settings into core_params

Move the gadget devicetree settings into the core_params structure and document them. Then set and check them in params.c, with the addition of some helper functions, and remove the equivalent code in gadget.c. Because these parameters came from the standalone s3c driver, they have a fixed

[PATCH v2 13/13] usb: dwc2: Add PCI properties

From: Vahram Aharonyan Add device parameters handling in dwc2-pci similar what is done in dwc3. Signed-off-by: Vahram Aharonyan Signed-off-by: John Youn --- drivers/usb/dwc2/pci.c | 19 +++ 1 file changed, 19

[PATCH v2 00/13] usb: dwc2: Fix up, consolidate, and simplify driver parameters

This patch series cleans up and simplifies the parameter handling in the dwc2 driver so that it is easier to set these parameters and easier to maintain the driver and support more platforms in the long run. The long-term goal is to remove all static and legacy parameters in favor of

[PATCH v2 01/13] usb: dwc2: Remove unnecessary kfree

This shouldn't be freed by the HCD as it is owned by the core and allocated with devm_kzalloc. Signed-off-by: John Youn --- drivers/usb/dwc2/hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index df5a065..1b6f5e1

[PATCH v2 02/13] usb: dwc2: Remove unused hardware parameter

The dma_desc_fs_enable does not correspond to any hardware parameter and is unused. Remove it. Signed-off-by: John Youn --- drivers/usb/dwc2/core.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h index 2a21a04..086bbdf

[PATCH v2 03/13] usb: dwc2: Add params.c file

Add a params.c file and move all driver parameter code there, including all the static parameter definitions. Signed-off-by: John Youn --- drivers/usb/dwc2/Makefile |1 + drivers/usb/dwc2/core.c | 918 +-- drivers/usb/dwc2/core.h

[PATCH v2 04/13] usb: dwc2: Declare the core params struct statically

This makes it consistent with the hw_params struct and simplifies the memory management for future refactoring. Fix up usage in all files. Signed-off-by: John Youn --- drivers/usb/dwc2/core.c | 12 +-- drivers/usb/dwc2/core.h | 2 +-

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

Hi, On 11/03/2016 07:36 PM, Mathias Nyman wrote: > On 03.11.2016 12:22, Sergei Shtylyov wrote: >> On 11/3/2016 9:48 AM, Lu Baolu wrote: >> >>> cmd_completion in struct xhci_virt_device is legacy. With command >>> strutcture and command queue introduced in xhci, cmd_completion is >> >>

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

On Thu, Nov 03, 2016 at 03:55:32PM -0700, Tony Lindgren wrote: > * Tony Lindgren [161103 13:59]: > > * Ladislav Michl [161101 14:14]: > > > > cacaaf80c3a6 ("usb: musb: Call pm_runtime from musb_gadget_queue") > > > > d8e5f0eca1e8 ("usb: musb: Fix

[PATCH] usb: gadget: f_fs: fix wrong parenthesis in ffs_func_req_match()

Properly check the return code of ffs_func_revmap_intf() and ffs_func_revmap_ep() for a non-negative value. Instead of checking the return code, the comparison was performed for the last parameter of the function calls, because of wrong parenthesis. This also fixes the following static checker

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

* Tony Lindgren [161103 13:59]: > * Ladislav Michl [161101 14:14]: > > > cacaaf80c3a6 ("usb: musb: Call pm_runtime from musb_gadget_queue") > > > d8e5f0eca1e8 ("usb: musb: Fix hardirq-safe hardirq-unsafe lock order > > > error") > > > > tested with

Re: musb RPM sleep-while-atomic in 4.9-rc1

On Thu, Nov 03, 2016 at 02:26:35PM -0700, Tony Lindgren wrote: [snip] > Here's the patch updated to use the existing finish_resume_work. > Is that along the lines you were thinking? > > Adding also Ladis to Cc too. Just gave it a try. Sure it wasn't supposed to fix "musb with hub" issue, but at

Re: musb RPM sleep-while-atomic in 4.9-rc1

* Johan Hovold [161031 04:50]: > On Fri, Oct 28, 2016 at 11:13:19AM -0700, Tony Lindgren wrote: > > * Johan Hovold [161028 02:45]: > > > On Thu, Oct 27, 2016 at 12:15:52PM -0700, Tony Lindgren wrote: > > > > * Johan Hovold [161027 11:46]: >

Re: Multiple chatty devices on Intel 5 Series/3400 USB2 EHCI controller act erratic

Hello guys! Did you have any progress on this? Do you still have the affected machine and devices? -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

* Ladislav Michl [161101 14:14]: > Hi, > > On Mon, Oct 24, 2016 at 11:07:08AM -0700, Tony Lindgren wrote: > > Hi, > > > > * Tony Lindgren [161021 00:18]: > > > * Ladislav Michl [161020 12:37]: > > > > [ 186.457519] musb-hdrc

Re: [BUG] cdc-acm: no data available after port open

On Thu, Nov 03, 2016 at 02:12:58PM +0100, Oliver Neukum wrote: [snip] > I think the way usbnet handles -EPIPE is the best. We are a bit on thin > ice because the CDC spec does not list under which conditions we should > see a stall, thus by implication: never. > But in general you cannot ignore a

Re: [PATCH] USB: phy: am335x-control: fix device and of_node leaks

On Thu, Nov 03, 2016 at 10:54:33AM +0200, Felipe Balbi wrote: > > Hi, > > Johan Hovold writes: > > Make sure to drop the references taken by of_parse_phandle() and > > bus_find_device() before returning from am335x_get_phy_control(). > > > > Note that there is no guarantee

Re: [PATCH] usbhid: add ATEN CS962 to list of quirky devices

On Thu, 3 Nov 2016, Oliver Neukum wrote: > Like many similar devices it needs a quirk to work. > Issuing the request gets the device into an irrecoverable state. Applied to hid.git#for-4.9/upstream-fixes. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error

On 03.11.2016 16:34, Felipe Balbi wrote: > > Hi, > > Alexey Khoroshilov writes: >> mv_u3d_req_to_trb() does not check for dma mapping errors. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> v2: split fix and clenup to separate patches. > > I'll

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

On 11/03/2016 12:33 PM, Alexandre Bailon wrote: On 11/03/2016 05:53 PM, David Lechner wrote: On 11/03/2016 10:26 AM, Alexandre Bailon wrote: The USB PHY is able to operate in OTG, host or peripheral. Some board may be wired to work act only as host or peripheral. In such case, the dr_mode

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

Hi, On Thursday 03 November 2016 10:56 PM, Alexandre Bailon wrote: > On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote: >>> The USB PHY is able to operate in OTG, host or peripheral. >>> Some board may be wired to work

Re: [PATCH v2 1/6] usb: separate out sysdev pointer from usb_bus

On 11/02/2016 12:38 AM, Sriram Dash wrote: > From: Arnd Bergmann > > For xhci-hcd platform device, all the DMA parameters are not > configured properly, notably dma ops for dwc3 devices. > > The idea here is that you pass in the parent of_node along with > the child device

Re: [PATCH v3 5/5] usb: musb: da8xx: Remove set_mode callback

On 11/03/2016 06:27 PM, Bin Liu wrote: > On Thu, Nov 03, 2016 at 12:18:53PM -0500, David Lechner wrote: >> On 11/03/2016 10:26 AM, Alexandre Bailon wrote: >>> The USB PHY is able to operate in OTG, host or peripheral. >>> Some board may be wired to work act only as host or peripheral. >>> In such

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

On 11/03/2016 05:53 PM, David Lechner wrote: > On 11/03/2016 10:26 AM, Alexandre Bailon wrote: >> The USB PHY is able to operate in OTG, host or peripheral. >> Some board may be wired to work act only as host or peripheral. >> In such case, the dr_mode property of controller must be set to >> host

Re: [PATCH v3 5/5] usb: musb: da8xx: Remove set_mode callback

On Thu, Nov 03, 2016 at 12:18:53PM -0500, David Lechner wrote: > On 11/03/2016 10:26 AM, Alexandre Bailon wrote: > >The USB PHY is able to operate in OTG, host or peripheral. > >Some board may be wired to work act only as host or peripheral. > >In such case, the dr_mode property of controller must

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote: >> The USB PHY is able to operate in OTG, host or peripheral. >> Some board may be wired to work act only as host or peripheral. >> In such case, the dr_mode property of

Re: [PATCH v3 5/5] usb: musb: da8xx: Remove set_mode callback

On 11/03/2016 10:26 AM, Alexandre Bailon wrote: The USB PHY is able to operate in OTG, host or peripheral. Some board may be wired to work act only as host or peripheral. In such case, the dr_mode property of controller must be set to host or peripheral. But doing that will also configure the

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

From: Felipe Balbi Date: Thu, 03 Nov 2016 09:04:54 +0200 > What Dave Miller is saying is that it's ALWAYS a bug to delay > completion of SKBs. The only thing you're doing with chipidea is > delaying interrupt by up to 125us; which is still a bug from the > point of

Re: [PATCH v3 2/5] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

On 11/03/2016 10:26 AM, Alexandre Bailon wrote: If we configure the da8xx OTG phy in OTG mode, neither device or host mode will work. That is because the PHY is not able to detect and notify the driver that value of ID pin changed. To work despite this hardware limitation, the da8xx glue

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

On 11/03/2016 10:26 AM, Alexandre Bailon wrote: The USB PHY is able to operate in OTG, host or peripheral. Some board may be wired to work act only as host or peripheral. In such case, the dr_mode property of controller must be set to host or peripheral. But doing that will also configure the

Re: [PATCH 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: > There is only one ohci on the da8xx series of chips, > so remove the ".0" when creating the phy. Also add > the "-da8xx" postfix to be consistent across davinci > usb drivers. > > Signed-off-by: Axel Haslam

Re: [PATCH v2 0/3] davinci: ohci: fix usb ohci device name

On 11/03/2016 11:03 AM, Axel Haslam wrote: The usb ohci clock match is not working because the usb clock is registered as "ohci" instead of "ohci.0" But since there is only a single ohci instance, lets pass -1 to the platform data id parameter and avoid the extra ".0" matching. while we are

Re: [PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

Hi, On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote: > The USB PHY is able to operate in OTG, host or peripheral. > Some board may be wired to work act only as host or peripheral. > In such case, the dr_mode property of controller must be set to > host or peripheral. But doing that

[PATCH v2 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

The davinci ohci driver name (currently "ohci") is too generic. To be consistent with other usb dirvers, append the "-da8xx" postfix to the name. Signed-off-by: Axel Haslam --- drivers/usb/host/ohci-da8xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 2/3] phy: da8xx-usb: rename the ohci device to ohci-da8xx

The ohci device name has changed in the board configuraion files, hence, change the phy lookup table to match the new name. Signed-off-by: Axel Haslam --- drivers/phy/phy-da8xx-usb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/3] ARM: davinci: da8xx: Fix ohci device name

While the clk lookup table is making reference to "ohci" other subsystems (such as phy) are trying to match "ohci.0" Since there is a single ohci instance, instead of changing the clk name, change the dev id to -1, and add the "-da8xx" postfix to match the driver name that will also be changed in

[PATCH v2 0/3] davinci: ohci: fix usb ohci device name

The usb ohci clock match is not working because the usb clock is registered as "ohci" instead of "ohci.0" But since there is only a single ohci instance, lets pass -1 to the platform data id parameter and avoid the extra ".0" matching. while we are fixing this, rename the driver from "ohci" to

[PATCH v4 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon Tested-by: David Lechner --- drivers/usb/musb/da8xx.c | 46

[PATCH v4 1/4] dt/bindings: Add binding for the DA8xx MUSB driver

From: Petr Kulhavy DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon Acked-by: Rob Herring --- .../devicetree/bindings/usb/da8xx-usb.txt

[PATCH v4 2/4] usb: musb: core: added helper function for parsing DT

From: Petr Kulhavy This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Alexandre Bailon Tested-by: David Lechner

[PATCH v4 4/4] ARM: dts: da850: Add the usb otg device node

This adds the device tree node for the usb otg controller present in the da850 family of SoC's. This also enables the otg usb controller for the lcdk board. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850-lcdk.dts | 8 arch/arm/boot/dts/da850.dtsi

[PATCH v4 0/4] Add DT support for DA8xx

Changes in v2: * Remove unrelated changes in patch 3 * Rename the device node in patch 4 Changes in v3: * Fix few mistakes in DT binding sample * Only build the device table if DT is enabled Change in v4: * Fix a nit Alexandre Bailon (1): ARM: dts: da850: Add the usb otg device node Petr

Re: [PATCH] usb: musb: da8xx: Don't print phy error on -EPROBE_DEFER

On Wed, Nov 02, 2016 at 10:45:59PM +0100, Ladislav Michl wrote: > Hi, > > On Tue, Oct 25, 2016 at 02:02:50PM -0500, David Lechner wrote: > > This suppresses printing the error message "failed to get phy" in the > > kernel log when the error is -EPROBE_DEFER. This prevents usless noise > > in the

Re: [BUG] cdc-acm: no data available after port open

Hi, On Thu, Nov 03, 2016 at 02:12:58PM +0100, Oliver Neukum wrote: > On Thu, 2016-11-03 at 13:44 +0100, Ladislav Michl wrote: > > On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote: > > Hi, > > > > now I'm really confused. Just looked at drivers/usb/serial/generic.c > > > which just

[PATCH v3 2/5] phy: da8xx-usb: Configure CFGCHIP2 to support OTG workaround

If we configure the da8xx OTG phy in OTG mode, neither device or host mode will work. That is because the PHY is not able to detect and notify the driver that value of ID pin changed. To work despite this hardware limitation, the da8xx glue implement a workaround. But to work, the workaround

[PATCH v3 4/5] phy: da8xx-usb: Use usb20_force_mode property to configure the phy mode

The USB PHY is able to operate in OTG, host or peripheral. Some board may be wired to work act only as host or peripheral. In such case, the dr_mode property of controller must be set to host or peripheral. But doing that will also configure the PHY in host or peripheral mode whereas OTG is able

[PATCH v3 5/5] usb: musb: da8xx: Remove set_mode callback

The USB PHY is able to operate in OTG, host or peripheral. Some board may be wired to work act only as host or peripheral. In such case, the dr_mode property of controller must be set to host or peripheral. But doing that will also configure the PHY in host or peripheral mode whereas OTG is able

[PATCH v3 3/5] dt/bindings: Add a new property to DA8xx USB PHY

The USB PHY is able to operate in OTG, host or peripheral. Some board may be wired to work act only as host or peripheral. In such case, the dr_mode property of controller must be set to host or peripheral. But doing that will also configure the PHY in host or peripheral mode whereas OTG is able

[PATCH v3 1/5] usb: musb: da8xx: Call earlier clk_prepare_enable()

The first attempt to read a register may fail because the clock may not be enabled, and then the probe of musb driver will fail. Call clk_prepare_enable() before the first register read. Signed-off-by: Alexandre Bailon --- drivers/usb/musb/da8xx.c | 17 - 1

[PATCH v3 0/5] usb: musb: da8xx: Fix few issues

Currently, the USB OTG of the da8xx doesn't work. This series intend to fix them. Change in v2: * Fix the error path da8xx_musb_init() Changes in v3: * Remove the host workaround that was not working on every platform * Add a property to the devicetree node of phy to force the phy in a specific

Re: [PATCH 0/3] fix ohci phy name

On Thu, Nov 3, 2016 at 1:00 PM, Sekhar Nori wrote: > On Thursday 03 November 2016 01:54 PM, Axel Haslam wrote: >> Hi Sekhar, David, >> >> It might make sense to have this patch series, >> squashed into a single patch, would you agree, >> or do you prefer it as is:

Re: [PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error

Hi, Alexey Khoroshilov writes: > mv_u3d_req_to_trb() does not check for dma mapping errors. > > Found by Linux Driver Verification project (linuxtesting.org). > > v2: split fix and clenup to separate patches. I'll fix this time when applying, but keep in mind we don't

[PATCH 2/2] usb: dwc3: trace: purge dwc3_trace()

Finally get rid of dwc3_trace() hack. If any other message is truly needed, we should add proper tracepoints for them instead of hacking around with dwc3_trace() or similar. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/Makefile | 2 +- drivers/usb/dwc3/core.c

[PATCH 1/2] usb: dwc3: trace: add a tracepoint for ep enable/disable

instead of using a simple trace_printk() wrapper, let's add an actual tracepoint and print further details about the endpoint being operated upon. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 10 ++ drivers/usb/dwc3/trace.h | 51

Re: [BUG] cdc-acm: no data available after port open

On Thu, 2016-11-03 at 13:44 +0100, Ladislav Michl wrote: > On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote: Hi, > > now I'm really confused. Just looked at drivers/usb/serial/generic.c > > which just stops submitting urbs on -EPIPE. On contrary > >

[PATCH v2 2/2] usb: gadget: mv_u3d: mv_u3d_start_queue() refactoring

The patch improves readability of mv_u3d_start_queue() by rearranging its code with two semantic modifications: - assignment zero to ep->processing if usb_gadget_map_request() fails; - propagation of error code from mv_u3d_req_to_trb() instead of hardcoded -ENOMEM. Signed-off-by: Alexey

[PATCH v2 1/2] usb: gadget: mv_u3d: add check for dma mapping error

mv_u3d_req_to_trb() does not check for dma mapping errors. Found by Linux Driver Verification project (linuxtesting.org). v2: split fix and clenup to separate patches. Signed-off-by: Alexey Khoroshilov --- drivers/usb/gadget/udc/mv_u3d_core.c | 6 ++ 1 file changed,

Re: [BUG] cdc-acm: no data available after port open

On Thu, Nov 03, 2016 at 01:03:56PM +0100, Ladislav Michl wrote: > On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote: > > On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote: > > > Hi Oliver, > > > > > Device operates normally after reconnect. So it seems you were right, > > >

Re: [PATCH 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

Hi Sekhar, The baseline used was the branch usb-next, in Greg's tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git Linux next is missing this patch[1] which was applied last week, but not yet pulled into linux-next. it will be there soon. Sorry, i did not mention it, i thought

Re: [BUG] cdc-acm: no data available after port open

On Thu, Nov 03, 2016 at 12:44:20PM +0100, Oliver Neukum wrote: > On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote: > > Hi Oliver, > > > Device operates normally after reconnect. So it seems you were right, > > there's no handling for EPIPE and EPROTO errors reported to > >

Re: [PATCH 0/3] fix ohci phy name

On Thursday 03 November 2016 01:54 PM, Axel Haslam wrote: > Hi Sekhar, David, > > It might make sense to have this patch series, > squashed into a single patch, would you agree, > or do you prefer it as is: one-per-subsystem? Patches in the current form are okay. Some coordination is required in

Re: [PATCH 3/3] usb: ohci-da8xx: rename driver to ohci-da8xx

On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote: > To be consistent on the usb driver for the davinci > platform follow the example of musb, and add the > "-da8xx" postfix to the driver name. > > Signed-off-by: Axel Haslam > --- > drivers/usb/host/ohci-da8xx.c |

Re: [BUG] cdc-acm: no data available after port open

On Thu, 2016-11-03 at 11:34 +0100, Ladislav Michl wrote: > Hi Oliver, > Device operates normally after reconnect. So it seems you were right, > there's no handling for EPIPE and EPROTO errors reported to > acm_read_bulk_callback. > Following patch fixes it for me, if it looks okay for you, I'll

[PATCH] usbhid: add ATEN CS962 to list of quirky devices

Like many similar devices it needs a quirk to work. Issuing the request gets the device into an irrecoverable state. Signed-off-by: Oliver Neukum CC: sta...@vger.kernel.org --- drivers/hid/hid-ids.h | 1 + drivers/hid/usbhid/hid-quirks.c | 1 + 2 files changed, 2

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

On 03.11.2016 12:22, Sergei Shtylyov wrote: On 11/3/2016 9:48 AM, Lu Baolu wrote: cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is Structure. I'll fix that while applying the patch, no need to resend

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

On 03.11.2016 08:48, Lu Baolu wrote: cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is not used any more. This patch removes it. Signed-off-by: Lu Baolu ---

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

Hi, Peter Chen writes: > On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote: >> >> Hi, >> >> Peter Chen writes: >> >> Peter Chen writes: >> >> > For isoc endpoint descriptor, the wMaxPacketSize is not real max

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

Hi, Peter Chen writes: >> > Peter Chen writes: >> > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: >> > >> From: Peter Chen >> > >> Date: Wed, 2 Nov 2016 14:02:02 +0800 >> > >> >> > >> > Felipe, it may

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

Hi, Peter Chen writes: >> Peter Chen writes: >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: >> >> From: Peter Chen >> >> Date: Wed, 2 Nov 2016 14:02:02 +0800 >> >> >> >> > Felipe, it may increase cpu

Re: [BUG] cdc-acm: no data available after port open

Hi Oliver, finally got device which stops responding after while on my table... On Mon, Jun 13, 2016 at 11:02:19AM +0200, Oliver Neukum wrote: > On Mon, 2016-06-13 at 00:37 +0200, Ladislav Michl wrote: > > On Sun, Jun 12, 2016 at 11:03:45PM +0200, Ladislav Michl wrote: > > > Once ttyACM0 starts

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

On 11/3/2016 9:48 AM, Lu Baolu wrote: cmd_completion in struct xhci_virt_device is legacy. With command strutcture and command queue introduced in xhci, cmd_completion is Structure. not used any more. This patch removes it. Signed-off-by: Lu Baolu [...] MBR,

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

On Thu, Nov 03, 2016 at 05:03:10PM +0800, Peter Chen wrote: > On Thu, Nov 03, 2016 at 09:04:54AM +0200, Felipe Balbi wrote: > > > > Hi, > > > > Peter Chen writes: > > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > > >> From: Peter Chen

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> Peter Chen writes: > >> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet > >> > size (see Table 9-13. Standard Endpoint

[PATCH] usb: gadget: f_hid add super speed support

Add super speed descriptors to f_hid. Signed-off-by: Janusz Dziedzic --- drivers/usb/gadget/function/f_hid.c | 67 - 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_hid.c

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

Hi, Peter Chen writes: >> Peter Chen writes: >> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet >> > size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 specifcation), >> > it may contain the number of packet, so the

Re: [PATCH 1/1] usb: gadget: f_uac2: fix error handling at afunc_bind

On Thu, Nov 03, 2016 at 10:50:23AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > The current error handling flow uses incorrect goto label, fix it > > > > Cc: > > Fixes: d12a8727171c ("usb: gadget: function: Remove > > redundant

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

On Thu, Nov 03, 2016 at 10:47:58AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet > > size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 specifcation), > > it may contain the

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

On Thu, Nov 03, 2016 at 09:04:54AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> From: Peter Chen > >> Date: Wed, 2 Nov 2016 14:02:02 +0800 > >> > >> > Felipe, it

Re: [PATCH] USB: phy: am335x-control: fix device and of_node leaks

Hi, Johan Hovold writes: > Make sure to drop the references taken by of_parse_phandle() and > bus_find_device() before returning from am335x_get_phy_control(). > > Note that there is no guarantee that the devres-managed struct > phy_control will be valid for the lifetime of

Re: [PATCH 1/1] usb: phy: phy-generic: add the implementation of .set_suspend

Hi, Peter Chen writes: > Add clock operation at .set_suspend if the PHY has > suspend requirement, it can be benefit of power saving for > phy and the whole system (parent clock may also be disabled). > > Signed-off-by: Peter Chen > --- >

Re: [PATCH] usb: gadget: mv_u3d: add check for dma mapping error

Hi, Alexey Khoroshilov writes: > mv_u3d_req_to_trb() does not check for dma mapping errors. > > By the way, the patch improves readability of mv_u3d_start_queue() > by rearranging its code with two semantic modifications: > - assignment zero to ep->processing if

  1   2   >