Re: [PATCH V2 1/2] dt-bindings: leds: document new led-triggers property

Hi Rafał, On 01/20/2017 10:56 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Some LEDs can be related to particular devices described in DT. This > property allows specifying such relations. E.g. USB LED should usually > be used to indicate some USB port(s) state. > >

[PATCH V2 2/2] usb: core: read USB ports from DT in the usbport LED trigger driver

From: Rafał Miłecki This adds support for using description of relation between LEDs and USB ports from device tree. If DT has properly described LEDs, trigger will know when to turn them on. Signed-off-by: Rafał Miłecki --- V2: Update to use "led-triggers"

[PATCH V2 1/2] dt-bindings: leds: document new led-triggers property

From: Rafał Miłecki Some LEDs can be related to particular devices described in DT. This property allows specifying such relations. E.g. USB LED should usually be used to indicate some USB port(s) state. Signed-off-by: Rafał Miłecki --- V2: Replace

[EXAMPLE V2 3/2] ARM: BCM53573: Specify ports for USB LED for Tenda AC9

From: Rafał Miłecki Signed-off-by: Rafał Miłecki --- This patch *should not* be applied. It's only an EXAMPLE and that's why it uses weird 3/2 number. It's a proof of concept, it was tested & will be submitted through ARM tree if previous patches get

Re: [PATCH 4/4] usb: gadget: f_hid: fix: Move IN request allocation to set_alt()

On 01/19/2017 11:55 AM, Krzysztof Opasiak wrote: Since commit ba1582f22231 ("usb: gadget: f_hid: use alloc_ep_req()") we cannot allocate any requests in bind() as we check if we should align request buffer based on endpoint descriptor which is assigned in set_alt(). Allocating request in bind()

Re: [PATCH] usb: phy: Implement am335x advisory 1.0.34

On Fri, Jan 20, 2017 at 12:01:04PM -0800, Tony Lindgren wrote: > I noticed in sprz360i.pdf there's "Advisory 1.0.34 USB2PHY: Register > Accesses After a USB Subsystem Soft Reset May Lock Up the Entire System" > that seems to affect am335x revisions 1.0, 2.0 and 2.1: > > "The synchronization

Re: [PATCHv4 3/2] dmaengine: cppi41: Clean up pointless warnings

* Bin Liu [170120 13:08]: > On Fri, Jan 20, 2017 at 12:07:53PM -0800, Tony Lindgren wrote: > > With patches "dmaengine: cppi41: Fix runtime PM timeouts with USB mass > > storage", and "dmaengine: cppi41: Fix oops in cppi41_runtime_resume", > > the pm_runtime_get/put() in

Re: [PATCH] usb: phy: Implement am335x advisory 1.0.34

* Bin Liu [170120 12:32]: > On Fri, Jan 20, 2017 at 12:01:04PM -0800, Tony Lindgren wrote: > > I noticed in sprz360i.pdf there's "Advisory 1.0.34 USB2PHY: Register > > Accesses After a USB Subsystem Soft Reset May Lock Up the Entire System" > > that seems to affect am335x revisions

Re: [PATCHv4 3/2] dmaengine: cppi41: Clean up pointless warnings

On Fri, Jan 20, 2017 at 12:07:53PM -0800, Tony Lindgren wrote: > With patches "dmaengine: cppi41: Fix runtime PM timeouts with USB mass > storage", and "dmaengine: cppi41: Fix oops in cppi41_runtime_resume", > the pm_runtime_get/put() in cppi41_irq() is no longer needed. We now > guarantee that

Re: [PATCH v3 3/3] usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in dsps

On Thu, Jan 19, 2017 at 11:06:59AM +0100, Alexandre Bailon wrote: > Despite the CPPI 4.1 is a generic DMA, it is tied to USB. > On the dsps, CPPI 4.1 interrupt's registers are in USBSS (the MUSB glue). > Currently, to enable / disable and clear interrupts, the CPPI 4.1 driver > maps and accesses

[PATCHv4 3/2] dmaengine: cppi41: Clean up pointless warnings

With patches "dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage", and "dmaengine: cppi41: Fix oops in cppi41_runtime_resume", the pm_runtime_get/put() in cppi41_irq() is no longer needed. We now guarantee that cppi41 is enabled when dma is in use. We can still get pointless error

[PATCH] usb: phy: Implement am335x advisory 1.0.34

I noticed in sprz360i.pdf there's "Advisory 1.0.34 USB2PHY: Register Accesses After a USB Subsystem Soft Reset May Lock Up the Entire System" that seems to affect am335x revisions 1.0, 2.0 and 2.1: "The synchronization bridge connecting the USB2PHY register interface to the L3S interconnect may

Re: [PATCH v3 1/3] usb: musb: dma: Add a DMA completion platform callback

On Thu, Jan 19, 2017 at 11:06:57AM +0100, Alexandre Bailon wrote: > Currently, the CPPI 4.1 driver is not completely generic and > only work on dsps. This is because of IRQ management. > Add a callback to dma_controller that could be invoked on DMA completion > to acknodlege the IRQ. > >

[PATCH] usb: musb: Fix external abort on non-linefetch for musb_irq_work()

While testing musb host mode cable plugging on a BeagleBone, I came across this error: Unhandled fault: external abort on non-linefetch (0x1008) at 0xd1dcfc60 ... [] (musb_default_readb [musb_hdrc]) from [] (musb_irq_work+0x1c/0x180 [musb_hdrc]) [] (musb_irq_work [musb_hdrc]) from []

Re: [PATCH 1/2] usb: musb: Fix host mode error -71 regression

On Wed, Jan 18, 2017 at 06:29:58PM -0800, Tony Lindgren wrote: > Commit 467d5c980709 ("usb: musb: Implement session bit based runtime PM for > musb-core") started implementing musb generic runtime PM support by > introducing devctl register session bit based state control. > > This caused a

[PATCH v7 1/5] phy: Add support for Qualcomm's USB HSIC phy

The HSIC USB controller on qcom SoCs has an integrated all digital phy controlled via the ULPI viewport. Acked-by: Rob Herring Cc: Signed-off-by: Stephen Boyd --- No changes.

[PATCH v7 0/5] Support qcom's HSIC USB and rewrite USB2 HS support

This patch series continues the usb chipidea rewrite for Qualcommm platforms. I've dropped the patches that were applied to Peter's tree for chipidea. Now the phy drivers are left, along with a new hook to set the vbus in the phy and changes to chipidea to call the new hook. I've left the HSIC

[PATCH v7 2/5] usb: chipidea: msm: Configure phy for appropriate mode

When the qcom chipidea controller is used with an extcon, we need to signal device mode or host mode to the phy so it can configure itself for the correct mode. This should be done after the phy is powered up, so that the register writes work correctly. Add in the appropriate phy_set_mode() call

[PATCH v7 4/5] usb: chipidea: Signal vbus state to phy

Some USB PHYs need to be told about vbus changing state explicitly. For example the qcom USB HS PHY needs to toggle a bit when vbus goes from low to high (VBUSVLDEXT) to cause the "session valid" signal to toggle. This signal will pull up D+ when the phy starts running. Add the appropriate

[PATCH v7 5/5] phy: Add support for Qualcomm's USB HS phy

The high-speed phy on qcom SoCs is controlled via the ULPI viewport. Cc: Acked-by: Rob Herring Signed-off-by: Stephen Boyd --- phy_set_mode() hook split up to toggle two bits independently with new set_vbus() hook.

[PATCH v7 3/5] phy: Add set_vbus callback

Some USB PHYs need to be told about vbus changing state explicitly. For example the qcom USB HS PHY needs to toggle a bit when vbus goes from low to high (VBUSVLDEXT) to cause the "session valid" signal to toggle. This signal will pull up D+ when the phy starts running. If the vbus signal isn't

Re: [PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

* Bin Liu [170120 09:24]: > On Thu, Jan 19, 2017 at 08:56:46AM -0800, Tony Lindgren wrote: > > * Alexandre Bailon [170119 06:09]: > > > The DMA may hung up if a teardown is initiated while an endpoint is still > > > active (Advisory 2.3.27 of DA8xx errata). >

Re: [PATCH 26/37] xhci: use the trb_to_noop() helper for command trbs

Mathias Nyman writes: > Remove duplicate code by using trb_to_noop() when > handling Aborted commads > > Signed-off-by: Mathias Nyman https://marc.info/?i=20161229110109.26372-25-felipe.ba...@linux.intel.com ? -- balbi -- To

Re: [PATCH 26/37] xhci: use the trb_to_noop() helper for command trbs

Mathias Nyman writes: > Remove duplicate code by using trb_to_noop() when > handling Aborted commads > > Signed-off-by: Mathias Nyman isn't this just [1]

Re: [PATCH 25/37] xhci: Introduce helper to turn one TRB into a no-op

Mathias Nyman writes: > Useful for turning both transfer and command trbs > into no-ops > > Signed-off-by: Mathias Nyman isn't this just [1] [1] https://marc.info/?i=20161229110109.26372-24-felipe.ba...@linux.intel.com --

RE: unable to handle EVENT RING FULL error in xhci

Hi Mathias, > -Original Message- > From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] > Sent: Friday, January 20, 2017 10:38 PM > To: gre...@linuxfoundation.org; Anurag Kumar Vulisha > > Cc: linux-usb@vger.kernel.org; mathias.ny...@intel.com; Punnaiah >

Re: [PATCHv4 0/2] cppi41 dma fixes for v4.10-rc cycle

On Fri, Jan 20, 2017 at 10:50:03PM +0530, Vinod Koul wrote: > On Thu, Jan 19, 2017 at 08:49:06AM -0800, Tony Lindgren wrote: > > Hi all, > > > > I'm using v4 naming here as the earlier patch "dmaengine: cppi41: Add dma > > support to da8xx" has been separated from the error -115 issue. We've > >

Re: [PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

On Thu, Jan 19, 2017 at 08:56:46AM -0800, Tony Lindgren wrote: > * Alexandre Bailon [170119 06:09]: > > The DMA may hung up if a teardown is initiated while an endpoint is still > > active (Advisory 2.3.27 of DA8xx errata). > > To workaround this issue, add a delay before to

Re: [PATCHv4 0/2] cppi41 dma fixes for v4.10-rc cycle

On Thu, Jan 19, 2017 at 08:49:06AM -0800, Tony Lindgren wrote: > Hi all, > > I'm using v4 naming here as the earlier patch "dmaengine: cppi41: Add dma > support to da8xx" has been separated from the error -115 issue. We've > identified so far three musb and cppi41 regressions: Hi, Can we get

Re: unable to handle EVENT RING FULL error in xhci

On 20.01.2017 10:41, gre...@linuxfoundation.org wrote: On Fri, Jan 20, 2017 at 07:59:48AM +, Anurag Kumar Vulisha wrote: Hi, Hi! Minor nit, vger.kernel.org rejects html emails, so this didn't make it through to that list. Now it should with my response :) I have a usecase where I want

Re: [PATCH 25/37] xhci: Introduce helper to turn one TRB into a no-op

On 01/20/2017 05:47 PM, Mathias Nyman wrote: Useful for turning both transfer and command trbs into no-ops Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 32 1 file changed, 20 insertions(+), 12 deletions(-)

Re: [PATCH 32/37] usb: host: xhci: remove newline from tracer

Hello! On 01/20/2017 05:47 PM, Mathias Nyman wrote: From: Felipe Balbi If we add that newline, the output will like like the following: Look like. :-) kworker/2:1-42[002] 169.811435: xhci_address_ctx: ctx_64=0, ctx_type=2,

Re: [PATCH net] r8152: fix rtl8152_post_reset function

From: Hayes Wang Date: Fri, 20 Jan 2017 14:33:55 +0800 > The rtl8152_post_reset() should sumbit rx urb and interrupt transfer, > otherwise the rx wouldn't work and the linking change couldn't be > detected. > > Signed-off-by: Hayes Wang Applied,

Re: XHCI regression on v4.10-rc1

On 20.01.2017 16:49, Patrice CHOTARD wrote: On 01/13/2017 05:12 PM, Patrice Chotard wrote: On 01/12/2017 06:17 PM, Mathias Nyman wrote: On 09.01.2017 18:42, Mathias Nyman wrote: On 09.01.2017 16:23, Patrice Chotard wrote: On 01/09/2017 01:30 PM, Mathias Nyman wrote: On 09.01.2017 11:51,

[PATCH linux-next 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

From: Cristian Birsan Update atmel udc driver with a new enpoint allocation scheme. The data sheet requires that all endpoints are allocated in order. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/Kconfig | 14

[PATCH linux-next 0/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

From: Cristian Birsan Hi, This patch updates the usb endpoint allocation scheme for atmel usba driver to make sure all endpoints are allocated in order. This requirement comes from the datasheet of the controller. The allocation scheme is decided by fifo_mode

Re: [PATCH v3 4/5] usb: musb: musb_cppi41: Workaround DMA stall issue during teardown

On 01/19/2017 05:56 PM, Tony Lindgren wrote: > * Alexandre Bailon [170119 06:09]: >> The DMA may hung up if a teardown is initiated while an endpoint is still >> active (Advisory 2.3.27 of DA8xx errata). >> To workaround this issue, add a delay before to initiate the

[PATCH 35/37] xhci: Rename variables related to transfer descritpors

urb_priv structure has a count on how many TDs the URB contains, and how many of those TD's we have handled. rename: length -> num_tds td_cnt -> num_tds_done No functional changes Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 10 +-

[PATCH 36/37] xhci: simplify how we store TDs in urb private data

Instead of storing a zero length array of td pointers, and then allocate memory both for the td pointer array and the td's, just use a zero length array of actual td's in urb private data. old: struct urb_priv { struct xhci_td *td[0] } new: struct urb_priv { struct xhci_td td[0]

[PATCH 32/37] usb: host: xhci: remove newline from tracer

From: Felipe Balbi If we add that newline, the output will like like the following: kworker/2:1-42[002] 169.811435: xhci_address_ctx: ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_va=@880153fbd000 We would rather have that in a single line.

[PATCH 31/37] usb: host: xhci: convert several if() to a single switch statement

From: Felipe Balbi when getting endpoint type, a switch statement looks better than a series of if () branches. There are no functional changes with this patch, cleanup only. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman

[PATCH 37/37] xhci: refactor xhci_urb_enqueue

Use switch instead of several if statements Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 93 - 1 file changed, 37 insertions(+), 56 deletions(-) diff --git a/drivers/usb/host/xhci.c

[PATCH 28/37] usb: host: xhci: combine event TRB completion debugging messages

From: Felipe Balbi If we just provide a helper to convert completion code to string, we can combine all debugging messages into a single print. [keep the old debug messages, for warn and grep -Mathias] Signed-off-by: Felipe Balbi

[PATCH 33/37] usb: host: xhci: add xhci_virt_device tracer

From: Felipe Balbi Let's start tracing at least part of an xhci_virt_device lifetime. We might want to extend this tracepoint class later, but for now it already exposes quite a bit of valuable information. Signed-off-by: Felipe Balbi

[PATCH 34/37] xhci: rename size variable to num_tds

No functinal changes. num_tds describes the number of transfer descriptor better than "size" Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xhci.c

[PATCH 20/37] usb: host: xhci: reorder variable definitions

From: Felipe Balbi no functional changes. Simple cleanup to make sure variables are ordered in a 'reverse christmas tree' fashion. While at that, also remove an obsolete comment which doesn't apply anymore. Signed-off-by: Felipe Balbi

[PATCH 15/37] usb: host: xhci: print HCIVERSION on debug

From: Felipe Balbi When calling xhci_dbg_regs() we actually _do_ want to know XHCI's version. This might help figure out why certain problems only happen in some cases. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman

[PATCH 26/37] xhci: use the trb_to_noop() helper for command trbs

Remove duplicate code by using trb_to_noop() when handling Aborted commads Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 25/37] xhci: Introduce helper to turn one TRB into a no-op

Useful for turning both transfer and command trbs into no-ops Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c

[PATCH 19/37] usb: host: xhci: use slightly better list helpers

From: Felipe Balbi Replace list_entry() with list_first_entry() and list_for_each() with list_for_each_entry(). This makes the code slightly more readable. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman

[PATCH 03/37] xhci: detect stop endpoint race using pending timer instead of counter.

A counter was used to find out if the stop endpoint completion raced with the stop endpoint timeout timer. This was needed in case the stop ep completion failed to delete the timer as it was running on anoter cpu. The EP_STOP_CMD_PENDING flag was not enough as a new stop endpoint command may be

[PATCH 22/37] usb: host: xhci: remove bogus __releases()/__acquires() annotation

From: Felipe Balbi handle_tx_event() is not releasing xhci->lock nor reacquiring it, remove the bogus annotation. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman ---

[PATCH 23/37] usb: host: xhci: check for a valid ring when unmapping bounce buffer

From: Felipe Balbi This way we can remove checks for valid ring from call sites of xhci_unmap_td_bounce_buffer() Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman ---

[PATCH 09/37] usb: host: xhci-plat: enable BROKEN_PED quirk if platform requested

From: Felipe Balbi In case 'quirk-broken-port-ped' property is passed in via device property, we should enable the corresponding BROKEN_PED quirk flag for XHCI core. [rog...@ti.com] Updated code from platform data to device property and added DT binding. Signed-off-by: Felipe

[PATCH 00/37] xhci features for usb-next 4.11

Hi Greg A lot of xhci cleanups, refactoring and changes for 4.11 Including major tracing rework by Felipe -Mathias Alexander Stein (1): xhci: Put warning message on a single line Baolin Wang (1): usb: host: xhci: Remove unused 'addr_64' variable in xhci_hcd structure Felipe Balbi

[PATCH 13/37] usb: xhci: remove unnecessary return in xhci_pci_setup()

From: Lu Baolu Remove the unnecessary return line in xhci_pci_setup(). Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-pci.c | 6 +- 1 file changed, 1 insertion(+), 5

[PATCH 07/37] xhci: Put warning message on a single line

From: Alexander Stein This allows someone to grep for the complete warning message as in; xhci-hcd xhci-hcd.0.auto: USB core suspending device not in U0/U1/U2. Signed-off-by: Alexander Stein Signed-off-by: Mathias

[PATCH 11/37] usb: xhci: avoid unnecessary calculation

From: Lu Baolu No need to calculate remainder and length_field, if there is no data phase of a control transfer. Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 20

[PATCH 02/37] xhci: rename EP_HALT_PENDING to EP_STOP_CMD_PENDING

We don't want to confuse halted and stalled endpoint states with a flag indicating we are waiting for a stop endpoint command to finish or timeout Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 6 +++--- drivers/usb/host/xhci.c | 6 +++---

[PATCH 10/37] usb: xhci: remove unnecessary assignment

From: Lu Baolu Drop an unnecessary assignment in prepare_transfer(). Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 21/37] usb: host: xhci: introduce xhci_td_cleanup()

From: Felipe Balbi By extracting xhci_td_cleanup() from finish_td(), code before clearer and easier to follow. There are no functional changes with this patch. It's merely a cleanup. Signed-off-by: Felipe Balbi Signed-off-by: Mathias

[PATCH 08/37] usb: xhci: add quirk flag for broken PED bits

From: Felipe Balbi Some devices from Texas Instruments [1] suffer from a silicon bug where Port Enabled/Disabled bit should not be used to silence an erroneous device. The bug is so that if port is disabled with PED bit, an IRQ for device removal (or attachment) will never fire.

[PATCH 24/37] usb: host: xhci: unconditionally call xhci_unmap_td_bounce_buffer()

From: Felipe Balbi xhci_unmap_td_bounce_buffer() already checks for a valid td->bounce_seg and bails out early if that's invalid. There's no need to check for this twice. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman

[PATCH 12/37] usb: xhci: use list_is_singular for cmd_list

From: Lu Baolu Use list_is_singular() to check if cmd_list has only one entry. [use list_empty() in queue command instead -Mathias] Signed-off-by: Lu Baolu Signed-off-by: Mathias Nyman ---

[PATCH 01/37] xhci: simplify if statement to make it more readable

No functional change, De Morgan !(A && B) = (!A || !B) Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

Re: XHCI regression on v4.10-rc1

On 01/13/2017 05:12 PM, Patrice Chotard wrote: > On 01/12/2017 06:17 PM, Mathias Nyman wrote: >> On 09.01.2017 18:42, Mathias Nyman wrote: >>> On 09.01.2017 16:23, Patrice Chotard wrote: On 01/09/2017 01:30 PM, Mathias Nyman wrote: > > On 09.01.2017 11:51, Patrice Chotard wrote:

[PATCH 06/37] usb: host: xhci: Remove unused 'addr_64' variable in xhci_hcd structure

From: Baolin Wang Since the 'addr_64' variable as legacy is unused now, then remove it from xhci_hcd structure. Signed-off-by: Baolin Wang Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci.h | 1 - 1 file

[PATCH 05/37] usb: xhci: remove unnecessary second abort try

From: Lu Baolu The second try was a workaround for (what we thought was) command ring failing to stop in the first place. But this turns out to be due to the race that we have fixed(see "xhci: Fix race related to abort operation"). With that fix, it is time to remove

[PATCH 04/37] xhci: remove unnecessary check for pending timer

Checking if the command timeout timer is pending when queueing the first command to the command ring is not really useful, remove it. Suggested-by: Lu Baolu Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c | 3 +-- 1 file

[PATCH 17/37] usb: host: xhci: simplify irq handler return

From: Felipe Balbi Instead of having several return points, let's use a local variable and a single place to return. This makes the code slightly easier to read. [set ret = IRQ_HANDLED in default working case -Mathias] Signed-off-by: Felipe Balbi

[PATCH 27/37] usb: host: xhci: convert to list_for_each_entry_safe()

From: Felipe Balbi instead of using while(!list_empty()) followed by list_first_entry(), we can actually use list_for_each_entry_safe(). Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman ---

[PATCH 14/37] usb: host: xhci: change pre-increments to post-increments

From: Felipe Balbi This is a cleanup patch only, no functional changes. The idea is just to make sure for loops look the same all over the driver. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman

[PATCH 16/37] usb: host: xhci: rename completion codes to match spec

From: Felipe Balbi Cleanup only. This patch is a mechaninal rename to make sure our macros for TRB completion codes match what the specification uses to refer to such errors. The idea behind this is that it makes it far easier to grep the specification and match it

[PATCH 29/37] usb: host: xhci: make a generic TRB tracer

From: Felipe Balbi instead of having a tracer that can only trace command completions, let's promote this tracer so it can trace and decode any TRB. With that, it will be easier to extrapolate the lifetime of any TRB which might help debugging certain issues.

[PATCH 18/37] usb: host: xhci: remove unneded semicolon

From: Felipe Balbi it does no good, let's remove it. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ext-caps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 30/37] usb: host: xhci: add urb_enqueue/dequeue/giveback tracers

From: Felipe Balbi These three new tracers will help us tie TRBs into URBs by *also* looking into URB lifetime. Signed-off-by: Felipe Balbi Signed-off-by: Mathias Nyman --- drivers/usb/host/xhci-ring.c

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 20/01/17 12:10, Felipe Balbi wrote: >>> And unfortunately, whether this is set or not is not visible to the >>> software so it will require a quirk. >> >> but arrived at this conclusion because I couldn't think of a reasonable >> guess value for IN/OUT endpoint numbers that would work if >>

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

On Thu, Jan 19, 2017 at 4:56 PM, Florian Fainelli wrote: > On 01/19/2017 02:36 PM, Scott Branden wrote: > The driver stands alone from the SoC and does not need compatibility > strings per SoC. New SoCs will use the exact same block. Even if you

Re: [PATCH 1/1] xhci: remove WARN_ON if dma mask is not set for platform devices

changes this late in > the rc-cycle. > 100% reproducible on Intel Edison BEFORE # uname -a Linux buildroot 4.10.0-rc4-next-20170120+ #245 SMP Fri Jan 20 15:49:08 EET 2017 x86_64 GNU/Linux # dmesg | grep WARN [ 19.25] WARNING: CPU: 0 PID: 1 at /home/andy/prj/linux-topic-mfld/drivers

[PATCH 0/1] xhci fix for usb-linus

Hi Greg Here's the patch that removes the scary WARN_ON in 4.10 xhci platform driver -Mathias Mathias Nyman (1): xhci: remove WARN_ON if dma mask is not set for platform devices drivers/usb/host/xhci-plat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe

[PATCH 1/1] xhci: remove WARN_ON if dma mask is not set for platform devices

The warn on is a bit too much, we will anyway set the dma mask if not set previously. The main reason for this fix is that 4.10-rc1 has a dwc3 change that pass a parent sysdev dev pointer instead of setting the dma mask of its xhci platform device. xhci platform driver can then get more

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

Hi, Greg KH writes: >> >> > > > > This series by Arnd Bergmann was originally six patches, but last >> >> > > > > two of >> >> > > > > them were already taken to 4.10. Without the rest of them there >> >> > > > > will >> >> > > > > be a regression in 4.10. >> >> >

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On Fri, Jan 20, 2017 at 02:08:50PM +0200, Felipe Balbi wrote: > > Hi, > > Greg KH writes: > > On Fri, Jan 20, 2017 at 01:35:39PM +0200, Mathias Nyman wrote: > >> On 20.01.2017 12:22, Greg KH wrote: > >> > On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote:

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

Hi, Bryan O'Donoghue writes: > On 19/01/17 22:49, John Youn wrote: > >> So it is valid to have say, DWC_USB3_NUM_EPS=8 and >> DWC_USB3_NUM_IN_EPS=8. Even though it is not possible to use all 8 EPs >> as IN since you need at least one of them to be a control OUT. So

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

Hi, Greg KH writes: > On Fri, Jan 20, 2017 at 01:35:39PM +0200, Mathias Nyman wrote: >> On 20.01.2017 12:22, Greg KH wrote: >> > On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote: >> > > On 19.01.2017 20:48, Greg KH wrote: >> > > > On Thu, Jan 19, 2017 at

Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver

Hi Rob, On Thu, Jan 19, 2017 at 11:06 PM, Rob Herring wrote: > On Tue, Jan 17, 2017 at 01:35:07PM +0530, Raviteja Garimella wrote: >> This patch adds device tree bindings documentation for Synopsys >> USB device controller platform driver. > > Bindings describe h/w, not drivers.

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On Fri, Jan 20, 2017 at 01:35:39PM +0200, Mathias Nyman wrote: > On 20.01.2017 12:22, Greg KH wrote: > > On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote: > > > On 19.01.2017 20:48, Greg KH wrote: > > > > On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > > > > > Hi Greg

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

On 01/20/2017 02:00 PM, Roger Quadros wrote: Vivek, On 19/01/17 17:15, vivek.gau...@codeaurora.org wrote: Hi Roger, On 2017-01-19 17:45, Roger Quadros wrote: Vivek, On 19/01/17 13:56, Vivek Gautam wrote: Hi, On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: Luckily

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On 20.01.2017 12:22, Greg KH wrote: On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote: On 19.01.2017 20:48, Greg KH wrote: On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: Hi Greg This series by Arnd Bergmann was originally six patches, but last two of them were

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On Fri, Jan 20, 2017 at 11:23:36AM +0200, Mathias Nyman wrote: > On 19.01.2017 20:48, Greg KH wrote: > > On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: > > > Hi Greg > > > > > > This series by Arnd Bergmann was originally six patches, but last two of > > > them were already taken

Re: [PATCH v11 2/8] power: add power sequence library

On Fri, Jan 20, 2017 at 8:52 AM, Peter Chen wrote: > On Tue, Jan 10, 2017 at 03:02:41PM +0800, Peter Chen wrote: >> On Sat, Jan 07, 2017 at 10:54:56AM +0200, Krzysztof Kozlowski wrote: >> > On Thu, Jan 05, 2017 at 02:01:53PM +0800, Peter Chen wrote: >> > > We have an

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

On 01/20/2017 10:24 AM, Sekhar Nori wrote: > On Thursday 19 January 2017 11:01 PM, Alexandre Bailon wrote: >> On 01/19/2017 05:49 PM, Grygorii Strashko wrote: >>> On 01/19/2017 09:08 AM, Alexandre Bailon wrote: On 01/19/2017 03:48 PM, Sekhar Nori wrote: > On Thursday 19 January 2017 07:39

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 19/01/17 22:49, John Youn wrote: > So it is valid to have say, DWC_USB3_NUM_EPS=8 and > DWC_USB3_NUM_IN_EPS=8. Even though it is not possible to use all 8 EPs > as IN since you need at least one of them to be a control OUT. So you > could have a configuration of EP0 IN and OUT plus 6 IN EPs

Re: [PATCH] arm: davinci: Make the usb20 clock available to PM runtime

On Thursday 19 January 2017 11:01 PM, Alexandre Bailon wrote: > On 01/19/2017 05:49 PM, Grygorii Strashko wrote: >> On 01/19/2017 09:08 AM, Alexandre Bailon wrote: >>> On 01/19/2017 03:48 PM, Sekhar Nori wrote: On Thursday 19 January 2017 07:39 PM, Alexandre Bailon wrote: > Add usb20 to

Re: [PATCH resend v5 0/4] xhci fixes for usb-linus

On 19.01.2017 20:48, Greg KH wrote: On Thu, Jan 19, 2017 at 02:21:26PM +0200, Mathias Nyman wrote: Hi Greg This series by Arnd Bergmann was originally six patches, but last two of them were already taken to 4.10. Without the rest of them there will be a regression in 4.10. Is it really a

Re: [PATCH v11 08/14] usb: otg: add OTG/dual-role core

Vivek, On 19/01/17 17:15, vivek.gau...@codeaurora.org wrote: > Hi Roger, > > On 2017-01-19 17:45, Roger Quadros wrote: >> Vivek, >> >> On 19/01/17 13:56, Vivek Gautam wrote: >>> Hi, >>> >>> >>> On Wed, Jun 22, 2016 at 2:00 PM, Roger Quadros wrote: >>> >>> Luckily hit this thread

Re: unable to handle EVENT RING FULL error in xhci

On Fri, Jan 20, 2017 at 07:59:48AM +, Anurag Kumar Vulisha wrote: > Hi, Hi! Minor nit, vger.kernel.org rejects html emails, so this didn't make it through to that list. Now it should with my response :) > I have a usecase where I want to stream a stereo video from the ZED Stereo > Camera

[PATCH v2, 4/6] arm64: dts: mt8173: split usb SuperSpeed port into two ports

split the old SuperSpeed port node into a HighSpeed one and a new SuperSpeed one. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH v2, 2/6] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

the reference clock of HighSpeed port is 48M which comes from PLL; the reference clock of SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs are not, add it for compatibility, and put them into port node for flexibility. Signed-off-by: Chunfeng Yun

[PATCH v2, 3/6] phy: phy-mt65xx-usb3: add support for new version phy

There are some variations from mt2701 to mt2712: 1. banks shared by multiple ports are put back into each port, such as SPLLC and U2FREQ; 2. add a new bank MISC for u2port, and CHIP for u3port; 3. bank's offset in each port are also rearranged; Signed-off-by: Chunfeng Yun

  1   2   >