Re: [PATCH 1/2] usb: gadget: core: introduce ->udc_set_speed() method

2017-06-06 Thread Felipe Balbi
Hi, Alan Stern writes: >> Alan Stern writes: >> > On Tue, 6 Jun 2017, Felipe Balbi wrote: >> > >> >> Sometimes, the gadget driver we want to run has max_speed lower than >> >> what the UDC supports. In such situations, UDC might want to

[PATCH 2/2] HID: usbhid: Add HID_QUIRK_NO_INIT_REPORTS for Oculus Rift CV1

2017-06-06 Thread Philipp Zabel
When plugging in an Oculus Rift CV1 HMD, it takes a long time until the hidraw devices appear, specifically two control transfers time out querying the HID report descriptors: $ echo 1 > /sys/module/hid/parameters/debug usb 1-3.1: new full-speed USB device number 11 using xhci_hcd

[PATCH 1/2] HID: Add Oculus Rift CV1 id

2017-06-06 Thread Philipp Zabel
Add VID/PID for Oculus Rift CV1. Signed-off-by: Philipp Zabel --- drivers/hid/hid-ids.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 8ca1e8ce0af2..2953d53a8cc9 100644 --- a/drivers/hid/hid-ids.h +++

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-06 Thread Peter Chen
On Tue, Jun 06, 2017 at 05:56:56PM +0530, lingareddy praneethreddy wrote: > I am using Chipidea HDRC on imx6sl platform. On connecting USB stick > (sometimes) and Android/ Apple phone (frequent) to ci-hdrc multiple > time it is seen that hub (ehci_hub_control()) reports continuous >

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-06 Thread Peter Chen
On Tue, Jun 06, 2017 at 07:36:10PM +0200, Fabien Lahoudere wrote: > Hi Peter, > > On Tue, 2017-06-06 at 09:55 +0800, Peter Chen wrote: > > On Mon, Jun 05, 2017 at 11:52:26AM +0200, Fabien Lahoudere wrote: > > > On Mon, 2017-06-05 at 17:43 +0800, Peter Chen wrote: > > > > On Mon, Jun 05, 2017 at

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

2017-06-06 Thread Ruslan Bilovol
On Tue, Jun 6, 2017 at 12:41 PM, Felipe Balbi wrote: > > Hi, > > Greg KH writes: >>> > I'm OK with dropping legacy f_uac1 implementation. >>> > >>> > Another idea I was thinking about is to implement simple in-kernel >>> > driver which will do the

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

2017-06-06 Thread Thinh Nguyen
Hi Felipe, On 6/4/2017 11:08 PM, Felipe Balbi wrote: > Paul Zimmerman writes: >> Forgot to CC linux-usb, doing that now >> >> On Fri, 2 Jun 2017 16:27:56 -0700, Paul Zimmerman wrote: >> >>> Felipe Balbi writes: Thinh Nguyen

Re: [PATCH] usb: dwc2: add support for the DWC2 controller on Meson8 SoCs

2017-06-06 Thread Martin Blumenstingl
Hi John, On Tue, Jun 6, 2017 at 3:48 AM, John Youn wrote: > On 5/25/2017 10:39 AM, Martin Blumenstingl wrote: >> Hi John, >> >> On Sat, May 6, 2017 at 7:37 PM, Martin Blumenstingl >> wrote: >>> USB support in the Meson8 SoCs is

Re: [PATCH 1/2] usb: gadget: core: introduce ->udc_set_speed() method

2017-06-06 Thread Alan Stern
On Tue, 6 Jun 2017, Felipe Balbi wrote: > Hi, > > Alan Stern writes: > > On Tue, 6 Jun 2017, Felipe Balbi wrote: > > > >> Sometimes, the gadget driver we want to run has max_speed lower than > >> what the UDC supports. In such situations, UDC might want to make sure >

Re: [PATCH 1/2] usb: gadget: core: introduce ->udc_set_speed() method

2017-06-06 Thread Felipe Balbi
Hi, Alan Stern writes: > On Tue, 6 Jun 2017, Felipe Balbi wrote: > >> Sometimes, the gadget driver we want to run has max_speed lower than >> what the UDC supports. In such situations, UDC might want to make sure >> we don't try to connect on speeds not supported by

Re: [RFC] usb-phy-generic: Add support to SMSC USB3315

2017-06-06 Thread Fabien Lahoudere
Hi Peter, On Tue, 2017-06-06 at 09:55 +0800, Peter Chen wrote: > On Mon, Jun 05, 2017 at 11:52:26AM +0200, Fabien Lahoudere wrote: > > On Mon, 2017-06-05 at 17:43 +0800, Peter Chen wrote: > > > On Mon, Jun 05, 2017 at 10:57:00AM +0200, Fabien Lahoudere wrote: > > > > On Fri, 2017-06-02 at 15:00

Re: Please Add A Quectel EC25-E Device To A Proper Driver

2017-06-06 Thread T A F Thorne
> Judging from the product name and ids you provide above, this modem > should already be supported by the option driver since v4.11 and support > has also been backported to the stable trees (e.g. 4.4.58). > > So simply updating your kernel should do the trick here. > > Johan Fantastic news. I

Re: [PATCH v2 9/9] usbip: vhci-hcd: Clean up the code by adding a new macro

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > Each vhci has 2*VHCI_HC_PORTS ports, in which VHCI_HC_PORTS > ports are HighSpeed (or below), and VHCI_HC_PORTS are SuperSpeed. > This new macro VHCI_PORTS reflects this configuration. > > Signed-off-by: Yuyang

Re: [PATCH v2 8/9] usbip: vhci-hcd: Add USB3 port status bits

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > As USB3 has (slightly) different bit meanings in the port > status. Add a new status bit array for USB3. > > Signed-off-by: Yuyang Du Acked-by: Shuah Khan

Re: [PATCH v2 7/9] usbip: Add USB_SPEED_SUPER as valid arg

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > With this patch, USB_SPEED_SUPER is a valid speed when attaching > a USB3 SuperSpeed device. > > Signed-off-by: Yuyang Du Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2 6/9] usbip: vhci-hcd: Add USB3 SuperSpeed support

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > This patch adds a USB3 HCD to an existing USB2 HCD and provides > the support of SuperSpeed, in case the device can only be enumerated > with SuperSpeed. > > The bulk of the added code in usb3_bos_desc and

[PATCH v2 5/7] USB: of: fix root-hub device-tree node handling

2017-06-06 Thread Johan Hovold
In an attempt to work around a pinmux over-allocation issue in driver core, commit dc5878abf49c ("usb: core: move root hub's device node assignment after it is added to bus") moved the device-tree node assignment until after the root hub had been registered. This not only makes the device-tree

[PATCH v2 7/7] thermal: max77620: fix pinmux conflict on reprobe

2017-06-06 Thread Johan Hovold
Use the new helper for reusing a device-tree node of another device instead of managing the node references explicitly. This also makes sure that the new of_node_reuse flag is set if the device is ever reprobed, something which specifically now avoids driver core from attempting to claim any

[PATCH v2 0/7] driver core/USB/thermal: fix device-tree node reuse

2017-06-06 Thread Johan Hovold
This series fixes a few issues related to device-tree node reuse. It is fairly common for drivers to reuse the device-tree node of a parent (or other ancestor) device when creating class or bus devices (e.g. gpio chips, i2c adapters, iio chips, spi masters, serdev, phys, usb root hubs). But

[PATCH v2 6/7] thermal: max77620: fix device-node reference imbalance

2017-06-06 Thread Johan Hovold
The thermal child device reuses the parent MFD-device device-tree node when registering a thermal zone, but did not take a reference to the node. This leads to a reference imbalance, and potential use-after-free, when the node reference is dropped by the platform-bus device destructor (once for

[PATCH v2 3/7] driver core: add helper to reuse a device-tree node

2017-06-06 Thread Johan Hovold
Add a helper function to be used when reusing the device-tree node of another device. It is fairly common for drivers to reuse the device-tree node of a parent (or other ancestor) device when creating class or bus devices (e.g. gpio chips, i2c adapters, iio chips, spi masters, serdev, phys, usb

[PATCH v2 4/7] driver core: fix automatic pinctrl management

2017-06-06 Thread Johan Hovold
Commit ab78029ecc34 ("drivers/pinctrl: grab default handles from device core") added automatic pin-control management to driver core by looking up and setting any default pinctrl state found in device tree while a device is being probed. This obviously runs into problems as soon as device-tree

[PATCH v2 2/7] USB: of: document reference taken by child-lookup helper

2017-06-06 Thread Johan Hovold
Document that the child-node lookup helper takes a reference to the device-tree node which needs to be dropped after use. Signed-off-by: Johan Hovold --- drivers/usb/core/of.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/of.c

[PATCH v2 1/7] USB: core: fix device node leak

2017-06-06 Thread Johan Hovold
Make sure to release any OF device-node reference taken when creating the USB device. Note that we currently do not hold a reference to the root hub device-tree node (i.e. the parent controller node). Fixes: 69bec7259853 ("USB: core: let USB device know device node") Cc: stable

Re: [PATCH v2 5/9] usbip: vhci-hcd: Set the vhci structure up to work

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > This patch enables the new vhci structure. Its lock protects > both the USB2 hub and the shared USB3 hub. > > Signed-off-by: Yuyang Du Acked-by: Shuah Khan

Re: [PATCH v2 4/9] usbip: vhci-hcd: Rework vhci_hcd_init

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > A vhci struct is added as the platform-specific data to the vhci > platform device, in order to get the vhci by its platform device. > This is done in vhci_hcd_init(). > > Signed-off-by: Yuyang Du

Re: [PATCH v2 3/9] usbip: vhci-hcd: Move VHCI platform device into vhci struct

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > Every VHCI is a platform device, so move the platform_device struct > into the VHCI struct. > > Signed-off-by: Yuyang Du Acked-by: Shuah Khan thanks, -- Shuah >

Re: [PATCH v2 2/9] usbip: vhci-hcd: Add vhci struct

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > In order to support SuperSpeed devices, a USB3 HCD is added to > share the USB2 HCD. As a result, a VHCI is composed of two > vhci_hcds associated with the two HCDs respectively. So we add > another level of

Re: [PATCH v2 1/9] usbip: vhci-hcd: Rename function names to reflect their struct names

2017-06-06 Thread Shuah Khan
On 05/18/2017 04:08 AM, Yuyang Du wrote: > From: Yuyang Du > > These helper function names are renamed to have their full struct > names to avoid confusion: > > - hcd_to_vhci() -> hcd_to_vhci_hcd() > - vhci_to_hcd() -> vhci_hcd_to_hcd() > - vdev_to_vhci() ->

Re: [PATCH 5/7] USB: of: fix root-hub device-tree node handling

2017-06-06 Thread Johan Hovold
On Mon, Jun 05, 2017 at 12:51:04PM +0800, Peter Chen wrote: > On Tue, May 30, 2017 at 06:25:52PM +0200, Johan Hovold wrote: > > In an attempt to work around a pinmux over-allocation issue in driver > > core, commit dc5878abf49c ("usb: core: move root hub's device node > > assignment after it is

Re: [PATCH v5 4/4] usb: usbip tool: Fix parse_status()

2017-06-06 Thread Shuah Khan
On 05/22/2017 04:20 AM, Yuyang Du wrote: > From: Yuyang Du > > In parse_status(), all nports number of idev's are initiated to > 0 by memset(), it is simply wrong, because parse_status() reads > the status sys file one by one, therefore, it can only update the > according

Re: [PATCH v5 3/4] usb: usbip tool: Fix refresh_imported_device_list()

2017-06-06 Thread Shuah Khan
On 05/22/2017 04:20 AM, Yuyang Du wrote: > From: Yuyang Du > > The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications > to vhci driver") introduced multiple controllers, but the status > of the ports are only extracted from the first status file, fix it. > >

Re: [PATCH 2/7] USB: of: document reference taken by child-lookup helper

2017-06-06 Thread Johan Hovold
On Tue, May 30, 2017 at 03:40:03PM -0700, Tyrel Datwyler wrote: > On 05/30/2017 09:25 AM, Johan Hovold wrote: > > Document that the child-node lookup helper takes a reference to the > > device-tree node which needs to be dropped after use. > > > > Signed-off-by: Johan Hovold >

Re: [PATCH v5 2/4] usb: usbip tool: Add ncontrollers in vhci_driver structure

2017-06-06 Thread Shuah Khan
On 05/22/2017 04:20 AM, Yuyang Du wrote: > From: Yuyang Du > > A new field ncontrollers is added to the vhci_driver structure. > And this field is stored by scanning the vhci_hcd* dirs in the > platform udev. > > Suggested-and-reviewed-by: Krzysztof Opasiak

Re: [PATCH v5 1/4] usb: usbip tool: Check the return of get_nports()

2017-06-06 Thread Shuah Khan
On 05/22/2017 04:20 AM, Yuyang Du wrote: > From: Yuyang Du > > If we get nonpositive number of ports, there is no sense to > continue, then fail gracefully. > > In addition, the commit 0775a9cbc694e8c72 ("usbip: vhci extension: > modifications to vhci driver") introduced

Re: [PATCH v4] usb: usbip: set buffer pointers to NULL after free

2017-06-06 Thread Shuah Khan
On 05/22/2017 05:02 AM, Michael Grzeschik wrote: > The usbip stack dynamically allocates the transfer_buffer and > setup_packet of each urb that got generated by the tcp to usb stub code. > As these pointers are always used only once we will set them to NULL > after use. This is done likewise to

Re: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID

2017-06-06 Thread Alan Robertson
On Tue, Jun 6, 2017 at 3:03 PM, Alan Stern wrote: > On Mon, 5 Jun 2017, Alan Robertson wrote: > >> >> >> USBSTOR\DISK_LINUX_FILE-STOR_GADGET_0404\123456789012&0 >> > >> > It looks like Windows is remembering an earlier version of your gadget >> > and matching it with

Re: Please Add A Quectel EC25-E Device To A Proper Driver

2017-06-06 Thread Johan Hovold
On Tue, Jun 06, 2017 at 03:16:25PM +0100, T A F Thorne wrote: > Good afternoon, > > I am seeing a message in my syslog that instructs me to "Tell > Linux-usb@vger.kernel.org to add your device to a proper driver.". This > is me delivering the message as instructed. > > I have just plugged in a

Please Add A Quectel EC25-E Device To A Proper Driver

2017-06-06 Thread T A F Thorne
Good afternoon, I am seeing a message in my syslog that instructs me to "Tell Linux-usb@vger.kernel.org to add your device to a proper driver.". This is me delivering the message as instructed. I have just plugged in a Quectel EC25-E LTE Module, mounted on a Micro-PCIe to USB adaptor board.

RE: Please Add A Quectel EC25-E Device To A Proper Driver

2017-06-06 Thread Thomas Thorne
Good point. I shall try again with a reduced sign off... or better yet a non-corporate account once cleared to do so. All obvious it is my own statements then. Thomas A. F. Thorne Software Engineer Net2Edge -Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf

Re: Please Add A Quectel EC25-E Device To A Proper Driver

2017-06-06 Thread Johan Hovold
On Tue, Jun 06, 2017 at 12:49:12PM +0100, Thomas A. F. Thorne MEng AUS MIET wrote: > Net2Edge Limited is a company registered in England & Wales (Company No. > 2438435, VAT No. GB 537553821) Kulite House, Stroudley Road, Basingstoke > RG24 8UG. This email transmission is confidential and

Re: Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-06 Thread Alan Stern
On Tue, 6 Jun 2017, lingareddy praneethreddy wrote: > I am using Chipidea HDRC on imx6sl platform. On connecting USB stick > (sometimes) and Android/ Apple phone (frequent) to ci-hdrc multiple > time it is seen that hub (ehci_hub_control()) reports continuous > USB_PORT_FEAT_C_RESET

Re: g_mass_storage emulation of flash drive - difficulties with passing vendor/product ID

2017-06-06 Thread Alan Stern
On Mon, 5 Jun 2017, Alan Robertson wrote: > >> >> USBSTOR\DISK_LINUX_FILE-STOR_GADGET_0404\123456789012&0 > > > > It looks like Windows is remembering an earlier version of your gadget > > and matching it with the current version based on the serial number > > string. > > I've changed the SN and

Re: [PATCH 1/2] usb: gadget: core: introduce ->udc_set_speed() method

2017-06-06 Thread Alan Stern
On Tue, 6 Jun 2017, Felipe Balbi wrote: > Sometimes, the gadget driver we want to run has max_speed lower than > what the UDC supports. In such situations, UDC might want to make sure > we don't try to connect on speeds not supported by the gadget > driver (e.g. super-speed capable dwc3 with

Re: [PATCH] HID: Add quirk for Dell PIXART OEM mouse

2017-06-06 Thread Jiri Kosina
On Tue, 6 Jun 2017, Sebastian Parschauer wrote: > >> This mouse is also known under other IDs. > > > > Do you know (some of the) other IDs? > > I mean the IDs from other vendors like the HP PixArt OEM mouse. AFAIK, > Dell MS116 is the only PixArt OEM mouse provided by Dell. Ah, so you didn't

Re: [PATCH] HID: Add quirk for Dell PIXART OEM mouse

2017-06-06 Thread Sebastian Parschauer
On 06.06.2017 14:06, Jiri Kosina wrote: > On Tue, 6 Jun 2017, Sebastian Parschauer wrote: > >> This mouse is also known under other IDs. > > Do you know (some of the) other IDs? I mean the IDs from other vendors like the HP PixArt OEM mouse. AFAIK, Dell MS116 is the only PixArt OEM mouse

[PATCH 2/2] usb: dwc3: gadget: implement ->udc_set_speed()

2017-06-06 Thread Felipe Balbi
Use this method to make sure we don't try to connect on speeds not supported by the gadget driver. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 101 ++ 1 file changed, 58 insertions(+), 43 deletions(-)

[PATCH 1/2] usb: gadget: core: introduce ->udc_set_speed() method

2017-06-06 Thread Felipe Balbi
Sometimes, the gadget driver we want to run has max_speed lower than what the UDC supports. In such situations, UDC might want to make sure we don't try to connect on speeds not supported by the gadget driver (e.g. super-speed capable dwc3 with high-speed capable g_midi) because that will just

Re: [PATCH] usb: Fix microtek driver compilation errors

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 02:18:10PM +0200, Mariusz Skamra wrote: > This fixes compilation errors due to missing scsi_cmnd.h include. > > usb/image/microtek.c: In function ‘mts_slave_alloc’: > usb/image/microtek.c:326:3: error: dereferencing pointer to incomplete type > s->inquiry_len = 0x24; >

FW: Unable to perform remote wakeup of host with USB HID Composite Device

2017-06-06 Thread Abdulhadi Mohamed
Hi I apologize in advance for this is my first email using this mailing list but I could really use some help. I have connected a composite USB device running the 4.0 Linux kernel to a PC running Ubuntu. One of its functions is to act as a HID device for mouse and keyboard to control the

Continuous, infinite warm reset attempts in Chipidea HDRC on multiple connect-disconects

2017-06-06 Thread lingareddy praneethreddy
I am using Chipidea HDRC on imx6sl platform. On connecting USB stick (sometimes) and Android/ Apple phone (frequent) to ci-hdrc multiple time it is seen that hub (ehci_hub_control()) reports continuous USB_PORT_FEAT_C_RESET (infinitely) before a disconnect-connect caused

[PATCH] usb: Fix microtek driver compilation errors

2017-06-06 Thread Mariusz Skamra
This fixes compilation errors due to missing scsi_cmnd.h include. usb/image/microtek.c: In function ‘mts_slave_alloc’: usb/image/microtek.c:326:3: error: dereferencing pointer to incomplete type s->inquiry_len = 0x24; ^ usb/image/microtek.c: In function ‘mts_slave_configure’:

Re: [PATCH] HID: Add quirk for Dell PIXART OEM mouse

2017-06-06 Thread Jiri Kosina
On Tue, 6 Jun 2017, Sebastian Parschauer wrote: > This mouse is also known under other IDs. Do you know (some of the) other IDs? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org

[PATCH] HID: Add quirk for Dell PIXART OEM mouse

2017-06-06 Thread Sebastian Parschauer
This mouse is also known under other IDs. It needs the quirk ALWAYS_POLL or will disconnect in runlevel 1 or 3. Signed-off-by: Sebastian Parschauer CC: sta...@vger.kernel.org --- drivers/hid/hid-ids.h | 3 +++ drivers/hid/usbhid/hid-quirks.c | 1 + 2 files

[PATCH] usb: gadget: composite: make sure to reactivate function on unbind

2017-06-06 Thread Felipe Balbi
If a function sets bind_deactivated flag, upon removal we will be left with an unbalanced deactivation. Let's make sure that we conditionally call usb_function_activate() from usb_remove_function() and make sure usb_remove_function() is called from remove_config(). Signed-off-by: Felipe Balbi

Please Add A Quectel EC25-E Device To A Proper Driver

2017-06-06 Thread Thomas A. F. Thorne MEng AUS MIET
Good afternoon, I am seeing a message in my syslog that instructs me to "Tell Linux-usb@vger.kernel.org to add your device to a proper driver.". This is me delivering the message as instructed. I have just plugged in a Quectel EC25-E LTE Module, mounted on a Micro-PCIe to USB adaptor board.

Re: [PATCH 0/9] tty: drop broken alt-speed handling

2017-06-06 Thread Alan Cox
On Tue, 6 Jun 2017 12:54:32 +0200 Johan Hovold wrote: > Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated > since v2.1.69 and has been broken for all tty drivers but serial-core > since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting >

Re: [PATCH v4] usb: usbip: set buffer pointers to NULL after free

2017-06-06 Thread Greg KH
On Tue, Jun 06, 2017 at 11:36:03AM +0200, Michael Grzeschik wrote: > Gentle Ping. I'm waiting for a usbip maintainer to review it :) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH 0/5] usb: gadget: udc: renesas_usb3: add DMAC support

2017-06-06 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi > Sent: Tuesday, June 6, 2017 6:40 PM > > Hi, > > Yoshihiro Shimoda writes: > > Hi, > > > >> From: Felipe Balbi > >> Sent: Friday, June 2, 2017 6:49 PM > >> > >> Hi, > >> > >> Yoshihiro Shimoda

Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-06 Thread Alan Cox
On Tue, 6 Jun 2017 12:54:40 +0200 Johan Hovold wrote: > Remove three ifdefed and broken implementations of TIOCSSERIAL and > TIOCGICOUNT, and parity handling in set_termios which had suffered > severe bit rot. I would be amazed if the IRDA code still works. It's not been

[PATCH v2] usb: gadget: udc: renesas_usb3: add support for dedicated DMAC

2017-06-06 Thread Yoshihiro Shimoda
The USB3.0 peripheral controller on R-Car SoCs has a dedicated DMAC. The DMAC needs a "PRD table" in system memory and the DMAC can have four PRD tables. This patch adds support for the DMAC. Signed-off-by: Yoshihiro Shimoda --- This patch based on the latest

Re: [PATCH] USB: qcserial: expose methods for modem control

2017-06-06 Thread Johan Hovold
On Tue, May 23, 2017 at 10:58:43PM -0700, Magnus Lynch wrote: > The qcserial driver fails to expose the .tiocmget and .tiocmset methods > available from usb_wwan. These methods are required by ioctl commands > dealing with the modem control signals DTR, RTS, etc. > > With these methods not set

Re: [PATCH] USB: serial: mos7840: add support for setting custom baud rate

2017-06-06 Thread Johan Hovold
On Thu, May 11, 2017 at 09:12:48PM +0300, Peter Mamonov wrote: > The patch implements TIOCSSERIAL ioctl call. The following fields of the > `struct serial_struct` are processed: > > - flags: ASYNC_SPD_MASK bits are processed. > > - baud_base: allow a user to specify arbitrary value less or equal

[PATCH 6/9] tty: cyclades: drop broken alt-speed support

2017-06-06 Thread Johan Hovold
Setting an alt_speed using the ASYNC_SPD flags has been deprecated since v2.1.69, and has been broken since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting speed via SPD_*") without anyone noticing. Drop the broken alt-speed handling altogether, and add a ratelimited warning about

[PATCH 0/9] tty: drop broken alt-speed handling

2017-06-06 Thread Johan Hovold
Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated since v2.1.69 and has been broken for all tty drivers but serial-core since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting speed via SPD_*") without anyone noticing (for four years). Instead of reverting the

[PATCH 1/9] serial: rate limit custom-speed deprecation notice

2017-06-06 Thread Johan Hovold
Contrary to what a comment claimed, the ASYNC_SPD flags and custom divisor can be set by a non-privileged user so rate limit the deprecation notice as was intended. Signed-off-by: Johan Hovold --- drivers/tty/serial/serial_core.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 9/9] tty: drop unused alt_speed from tty_struct

2017-06-06 Thread Johan Hovold
Drop the now unused alt_speed field from struct tty_struct. Setting an alt_speed using the ASYNC_SPD flags has been deprecated since v2.1.69, and has been broken for all tty drivers but serial-core since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting speed via SPD_*") without

[PATCH 2/9] USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic

2017-06-06 Thread Johan Hovold
Simplify TIOCSSERIAL flag logic somewhat. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index

[PATCH 8/9] tty: ircomm: remove dead and broken ioctl code

2017-06-06 Thread Johan Hovold
Remove three ifdefed and broken implementations of TIOCSSERIAL and TIOCGICOUNT, and parity handling in set_termios which had suffered severe bit rot. Signed-off-by: Johan Hovold --- net/irda/ircomm/ircomm_tty_ioctl.c | 107 + 1 file changed,

[PATCH 3/9] USB: serial: ftdi_sio: remove broken alt-speed handling

2017-06-06 Thread Johan Hovold
Remove the broken alt_speed code, and warn when trying to set the line speed using TIOCSSERIAL and SPD flags. The use of SPD flags to set the line speed has been deprecated since v2.1.69 and support for alt_speed (e.g. "warp") has even been removed from TTY core in v3.10 by commit 6865ff222cca

[PATCH 5/9] tty: amiserial: drop broken alt-speed support

2017-06-06 Thread Johan Hovold
Setting an alt_speed using the ASYNC_SPD flags has been deprecated since v2.1.69, and has been broken since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting speed via SPD_*") without anyone noticing. Drop the broken alt-speed handling altogether, and add a ratelimited warning about

[PATCH 7/9] tty: rocket: drop broken alt-speed support

2017-06-06 Thread Johan Hovold
Setting an alt_speed using the ROCKET_SPD flags has been deprecated since v2.1.69, and has been broken since commit 6865ff222cca ("TTY: do not warn about setting speed via SPD_*") without anyone noticing. To make things worse commit 6df3526b6649 ("rocket: first pass at termios reporting") in

[PATCH 4/9] tty: simserial: drop unused alt_speed handling

2017-06-06 Thread Johan Hovold
This driver was setting the deprecated and broken alt_speed based on port flags, but never provided a means to change the flags or to actually change the speed. Signed-off-by: Johan Hovold --- arch/ia64/hp/sim/simserial.c | 13 - 1 file changed, 13 deletions(-)

RE: [PATCH v3] xhci: AMD Promontory USB disable port support

2017-06-06 Thread 張家豪
> -Original Message- > From: Mathias Nyman [mailto:mathias.ny...@linux.intel.com] > Sent: Monday, June 05, 2017 5:40 PM > To: Jiahau Chang; linux-usb@vger.kernel.org; mathias.ny...@intel.com; > g...@kroah.com > Cc: kent@canonical.com; Justin_CY Chen(陳志勇); Yd Tseng(曾裕達); >

Re: [PATCH v2] usb: xhci: Issue stop EP command only when the EP state is running

2017-06-06 Thread Shyam Sundar S K
On 6/2/2017 8:21 PM, Alan Stern wrote: > On Fri, 2 Jun 2017, Shyam Sundar S K wrote: > >> on AMD platforms with SNPS 3.1 USB controller if stop endpoint command is >> issued the controller does not respond, when the EP is not in running >> state. HW completes the command execution and reports >>

[PATCH v4] xhci: AMD Promontory USB disable port support

2017-06-06 Thread Jiahau Chang
v4: Remove the patch code in case USB_PORT_FEAT_REMOTE_WAKE_MASK For AMD Promontory xHCI host, although you can disable USB 2.0 ports in BIOS settings, those ports will be enabled anyway after you remove a device on that port and re-plug it in again. It's a known limitation of the chip. As a

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

2017-06-06 Thread Felipe Balbi
Hi, Greg KH writes: >> > I'm OK with dropping legacy f_uac1 implementation. >> > >> > Another idea I was thinking about is to implement simple in-kernel >> > driver which will do the same as existing alsaloop tool userspace >> > tool does (so legacy users will need

RE: [PATCH 0/5] usb: gadget: udc: renesas_usb3: add DMAC support

2017-06-06 Thread Felipe Balbi
Hi, Yoshihiro Shimoda writes: > Hi, > >> From: Felipe Balbi >> Sent: Friday, June 2, 2017 6:49 PM >> >> Hi, >> >> Yoshihiro Shimoda writes: >> > Hi Felipe, >> > >> >> -Original Message- >> >> From: Yoshihiro Shimoda

Re: [PATCH v4] usb: usbip: set buffer pointers to NULL after free

2017-06-06 Thread Michael Grzeschik
Gentle Ping. To verify this patch just test usbip with some USB Ethernet devices. On Mon, May 22, 2017 at 01:02:44PM +0200, Michael Grzeschik wrote: > The usbip stack dynamically allocates the transfer_buffer and > setup_packet of each urb that got generated by the tcp to usb stub code. > As

Re: [PATCH v6 0/6] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support

2017-06-06 Thread Andy Shevchenko
On Mon, Jun 5, 2017 at 10:08 PM, wrote: > From: Kuppuswamy Sathyanarayanan > > Following patch set adds chained IRQ support to WCOVE PMIC driver. Assuming it has been tested, Reviewed-by: Andy Shevchenko

Re: [PATCH v6 5/6] mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips

2017-06-06 Thread Heikki Krogerus
On Mon, Jun 05, 2017 at 12:08:05PM -0700, sathyanarayanan.kuppusw...@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > Whishkey cove PMIC has support to mask/unmask interrupts at two levels. > At first level we can mask/unmask interrupt

RE: [PATCH 0/5] usb: gadget: udc: renesas_usb3: add DMAC support

2017-06-06 Thread Yoshihiro Shimoda
Hi, > From: Felipe Balbi > Sent: Friday, June 2, 2017 6:49 PM > > Hi, > > Yoshihiro Shimoda writes: > > Hi Felipe, > > > >> -Original Message- > >> From: Yoshihiro Shimoda > >> Sent: Wednesday, April 26, 2017 8:50 PM > >> > >> This patch set is based

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

2017-06-06 Thread Greg KH
On Mon, Jun 05, 2017 at 12:22:13PM +0300, Felipe Balbi wrote: > > Hi, > > Ruslan Bilovol writes: > >> Ruslan Bilovol writes: > >>> I came to this patch series when wanted to do two things: > >>> - use UAC1 as virtual ALSA sound card on

[PATCH v1 1/1] usb:xhci: update condition to select bus->sysdev from parent device

2017-06-06 Thread Thang Q. Nguyen
For commit 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA configuration"), sysdev points to devices known to the system firmware or hardware for DMA parameters. However, the parent of the system firmware/hardware device checking logic does not work in ACPI boot mode. This patch updates the

Re: [v2 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

2017-06-06 Thread Thang Q. Nguyen
On Mon, Jun 5, 2017 at 9:33 PM, Mathias Nyman wrote: > On 05.06.2017 15:57, Thang Q. Nguyen wrote: >> >> On Mon, Jun 5, 2017 at 6:14 PM, Mathias Nyman >> wrote: >>> >>> On 20.05.2017 10:24, Thang Q. Nguyen wrote: XHCI