Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Wei Wang
Hi John, Is it possible to try the attached patch? I am not sure if it actually fixes the issue. But I think it is worth a try. Also, could you get me all the ipv6 routes when you plug in the usb using "ip -6 route show"? (If you have multiple routing tables configured, could you dump them all?)

[RFC][PATCH] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

2017-08-09 Thread John Stultz
We've found that while in host mode on HiKey using Android, if one runs the command: stop adbd The existing usb devices being utilized in host mode are disconnected. This is most visible with usb networking devices. This seems to be due to adbd closing the file: /dev/usb-ffs/adb/ep0 Which

Re: [PATCH] usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

2017-08-09 Thread Gustavo A. R. Silva
Hi Yoshihiro, On 08/09/2017 06:44 AM, Yoshihiro Shimoda wrote: Hi Gustavo, Thank you for the patch! I'm glad to help :) -Original Message- From: Gustavo A. R. Silva Sent: Wednesday, August 9, 2017 7:35 AM platform_get_irq() returns an error code, but the renesas_usb3 driver

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Wei Wang
On Wed, Aug 9, 2017 at 6:26 PM, John Stultz wrote: > On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: >> On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote: >>> On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread John Stultz
On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: > On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote: >> On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: >>> (Cc'ing Wei whose commit was blamed) >>> >>> On Mon, Aug 7, 2017 at

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread John Stultz
On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: > > Does your USB adapter get an IPv6 address? Yes, it does. > If you see the problem starts to happen on commit > 9514528d92d4cbe086499322370155ed69f5d06c, could you try reverting all > the following commits: > (from new to

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Wei Wang
On Wed, Aug 9, 2017 at 4:44 PM, John Stultz wrote: > On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: >> (Cc'ing Wei whose commit was blamed) >> >> On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: >>> On Mon, Aug 7,

Re: [PATCH v2 1/5] usb: xhci: Disable slot even virt-dev is null

2017-08-09 Thread Lu Baolu
Hi, On 08/09/2017 03:58 PM, Mathias Nyman wrote: > On 27.07.2017 05:21, Lu Baolu wrote: >> xhci_disable_slot() is a helper for disabling a slot when a device >> goes away or recovers from error situations. Currently, it checks >> the corespoding virt-dev pointer and returns directly (w/o issuing

Re: [PATCH v2 4/5] usb: gadget: udc: Replace the deprecated extcon API

2017-08-09 Thread Chanwoo Choi
Ping. Hi Felipe, I sent the first patch[1] more than three weeks ago. But I didn't receive the any review. [1] https://lkml.org/lkml/2017/7/16/523 This patch is very simple. After finishing the review I'll remove the deprecated extcon API and then send the immutable branch to both phy and usb

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread John Stultz
On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang wrote: > (Cc'ing Wei whose commit was blamed) > > On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: >> On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote: >>> So, with recent

Re: [PATCH] usb: gadget: core: unmap request from DMA only if previously mapped

2017-08-09 Thread Jack Pham
Hi Felipe, Do you have any comments on this? Thanks, Jack On Tue, Aug 01, 2017 at 02:00:56AM -0700, Jack Pham wrote: > In the SG case this is already handled since a non-zero > request->num_mapped_sgs is a clear indicator that dma_map_sg() > had been called. While it would be nice to do the

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

2017-08-09 Thread Cong Wang
(Cc'ing Wei whose commit was blamed) On Mon, Aug 7, 2017 at 2:15 PM, John Stultz wrote: > On Mon, Aug 7, 2017 at 2:05 PM, John Stultz wrote: >> So, with recent testing with my HiKey board, I've been noticing some >> quirky behavior with my USB eth

Re: [PATCH v2 1/1] usbip: auto retry for concurrent attach

2017-08-09 Thread Shuah Khan
On 08/08/2017 03:11 AM, fx IWATA NOBUO wrote: > Hello, > >> -Original Message- >> From: Shuah Khan [mailto:sh...@kernel.org] >> Sent: Thursday, August 03, 2017 2:27 AM >> To: fx IWATA NOBUO ; >> valentina.mane...@gmail.com; gre...@linuxfoundation.org; >>

[PATCH 0/2] constify hid usb_device_id and fix space before '[' error

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Arvind Yadav (2): [PATCH 1/2] HID:

[PATCH 1/2] HID: usbkbd: constify usb_device_id and fix space before '[' error.

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav

[PATCH 2/2] HID: usbmouse: constify usb_device_id and fix space before '[' error

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav

[PATCH] mmc: vub300: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/mmc/host/vub300.c | 2 +- 1 file changed, 1

[PATCH 0/3] constify usb usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Arvind Yadav (3): [PATCH 1/3] usb: speedtch: constify usb_device_id [PATCH 2/3] usb: hwa-hc: constify usb_device_id

[PATCH 2/3] usb: hwa-hc: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/usb/host/hwa-hc.c | 2 +- 1 file changed, 1

[PATCH 1/3] usb: speedtch: constify usb_device_id

2017-08-09 Thread Arvind Yadav
usb_device_id are not supposed to change at runtime. All functions working with usb_device_id provided by work with const usb_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/usb/atm/speedtch.c | 2 +- 1 file changed, 1

Re: [PATCH] USB: serial: pl2303: add new ATEN device id

2017-08-09 Thread Greg KH
On Wed, Aug 09, 2017 at 10:28:00AM +0200, Johan Hovold wrote: > On Tue, Aug 08, 2017 at 12:58:51PM -0700, Greg Kroah-Hartman wrote: > > This adds a new ATEN device id for a new pl2303-based device. > > > > Reported-by: Peter Kuo > > Cc: stable > >

Re: f_hid.c conversion to the new function interface and crash due to race

2017-08-09 Thread Variksla
> On Aug 9, 2017, at 2:56 AM, Felipe Balbi wrote: Thanks for replying. > > > Hi, > > noman pouigt writes: >> Hello, >> >> I am currently using 3.18 linux kernel and getting below > > return -EKERNELTOOOLD; > > Sorry, you're on your own.

Re: [PATCH] usb: ehci-omap: fix error return code in ehci_hcd_omap_probe()

2017-08-09 Thread Alan Stern
On Tue, 8 Aug 2017, Gustavo A. R. Silva wrote: > platform_get_irq() returns an error code, but the ehci-omap driver > ignores it and always returns -ENODEV. This is not correct and, > prevents -EPROBE_DEFER from being propagated properly. > > Also, notice that platform_get_irq() no longer

Re: new usb LTE modem device

2017-08-09 Thread Dan Williams
On Wed, 2017-08-09 at 11:19 +0700, Lars Melin wrote: > On 8/9/2017 02:33, Bjørn Mork wrote: > > > > The qmi_wwan part looks fine to me. But you > > will need to split it in two patches since the two > > drivers are parts of different subsystems. > > > > The option driver use interface blacklists

[PATCH v5 2/8] usb: chipidea: udc: Support SKB alignment quirk

2017-08-09 Thread Dmitry Osipenko
NVIDIA Tegra20 UDC can't cope with unaligned DMA and require a USB gadget quirk that avoids SKB buffer alignment to be set in order to make Ethernet Gadget working. Later Tegra generations do not require that quirk. Let's add a new platform data flag that allows to enable USB gadget quirk for

[PATCH v5 1/8] usb: gadget: f_ecm/f_eem/f_rndis: Setup quirk_avoids_skb_reserve

2017-08-09 Thread Dmitry Osipenko
This quirk is required to make USB Ethernet gadget working with HW that can't cope with unaligned DMA. For some reason only f_ncm handles that quirk, let's handle it in the rest of the network models. All models have been tested with a ChipIdea UDC driver on NVIDIA Tegra20 SoC that require DMA to

[PATCH v5 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding All of these Tegra SoC generations have a ChipIdea UDC IP block that can be used for device mode communication with a host. Implement rudimentary support that doesn't allow switching between host and device modes. Tested-by: Michał Mirosław

[PATCH v5 4/8] ARM: defconfig: tegra: Enable ChipIdea UDC driver

2017-08-09 Thread Dmitry Osipenko
Since NVIDIA Tegra is supported now by the ChipIdea USB driver, let's enable this driver in tegra_defconfig. Signed-off-by: Dmitry Osipenko --- arch/arm/configs/tegra_defconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v5 6/8] ARM: tegra: Enable UDC on Dalmore

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra114-dalmore.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v5 8/8] ARM: tegra: Enable UDC on AC100

2017-08-09 Thread Dmitry Osipenko
Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Dmitry Osipenko Tested-by: Marc Dietrich Acked-by: Stephen Warren --- arch/arm/boot/dts/tegra20-paz00.dts | 2 ++ 1 file changed, 2

[PATCH v5 5/8] ARM: tegra: Enable UDC on Beaver

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding Acked-by: Stephen Warren --- arch/arm/boot/dts/tegra30-beaver.dts | 10 ++ 1 file changed,

[PATCH v5 7/8] ARM: tegra: Enable UDC on Jetson TK1

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding Tested-by: Nicolas Chauvet Acked-by: Stephen Warren ---

[PATCH v5 0/8] Support UDC on Tegra 20/30/114/124

2017-08-09 Thread Dmitry Osipenko
Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 (Tegra20), Nicolas

Re: BUG/PATCH: cp210x.c - reenable support for chips which don't report a partnum

2017-08-09 Thread Sebastian Frei
Make cp210x not abort if part number could not be read from device. Signed-off-by: Sebastian Frei --- diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index f64e914a8985..d6afa823d6f0 100644 --- a/drivers/usb/serial/cp210x.c +++

Re: [PATCH v4 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-08-09 Thread Dmitry Osipenko
On 09.08.2017 14:49, Dmitry Osipenko wrote: > From: Thierry Reding > > All of these Tegra SoC generations have a ChipIdea UDC IP block that can > be used for device mode communication with a host. Implement rudimentary > support that doesn't allow switching between host and

[PATCH v4 1/8] usb: gadget: f_ecm/f_eem/f_rndis: Setup quirk_avoids_skb_reserve

2017-08-09 Thread Dmitry Osipenko
This quirk is required to make USB Ethernet gadget working with HW that can't cope with unaligned DMA. For some reason only f_ncm handles that quirk, let's handle it in the rest of the network models. All models have been tested with a ChipIdea UDC driver on NVIDIA Tegra20 SoC that require DMA to

[PATCH v4 8/8] ARM: tegra: Enable UDC on AC100

2017-08-09 Thread Dmitry Osipenko
Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Dmitry Osipenko Tested-by: Marc Dietrich Acked-by: Stephen Warren --- arch/arm/boot/dts/tegra20-paz00.dts | 2 ++ 1 file changed, 2

[PATCH v4 5/8] ARM: tegra: Enable UDC on Beaver

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding Acked-by: Stephen Warren --- arch/arm/boot/dts/tegra30-beaver.dts | 10 ++ 1 file changed,

[PATCH v4 4/8] ARM: defconfig: tegra: Enable ChipIdea UDC driver

2017-08-09 Thread Dmitry Osipenko
Since NVIDIA Tegra is supported now by the ChipIdea USB driver, let's enable this driver in tegra_defconfig. Signed-off-by: Dmitry Osipenko --- arch/arm/configs/tegra_defconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v4 6/8] ARM: tegra: Enable UDC on Dalmore

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding --- arch/arm/boot/dts/tegra114-dalmore.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v4 7/8] ARM: tegra: Enable UDC on Jetson TK1

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding Override the compatible string of the first USB controller to enable device mode. Signed-off-by: Thierry Reding Tested-by: Nicolas Chauvet Acked-by: Stephen Warren ---

[PATCH v4 3/8] usb: chipidea: Add support for Tegra20/30/114/124

2017-08-09 Thread Dmitry Osipenko
From: Thierry Reding All of these Tegra SoC generations have a ChipIdea UDC IP block that can be used for device mode communication with a host. Implement rudimentary support that doesn't allow switching between host and device modes. Tested-by: Michał Mirosław

[PATCH v4 2/8] usb: chipidea: udc: Support SKB alignment quirk

2017-08-09 Thread Dmitry Osipenko
NVIDIA Tegra20 UDC can't cope with unaligned DMA and require a USB gadget quirk that avoids SKB buffer alignment to be set in order to make Ethernet Gadget working. Later Tegra generations do not require that quirk. Let's add a new platform data flag that allows to enable USB gadget quirk for

[PATCH v4 0/8] Support UDC on Tegra 20/30/114/124

2017-08-09 Thread Dmitry Osipenko
Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 (Tegra20), Nicolas

RE: [PATCH] usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

2017-08-09 Thread Yoshihiro Shimoda
Hi Gustavo, Thank you for the patch! > -Original Message- > From: Gustavo A. R. Silva > Sent: Wednesday, August 9, 2017 7:35 AM > > platform_get_irq() returns an error code, but the renesas_usb3 driver > ignores it and always returns -ENODEV. This is not correct and, > prevents

Re: [PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-09 Thread Felipe Balbi
Hi, Sandeep Singh writes: > On 8/4/2017 4:44 PM, Felipe Balbi wrote: >> >> Hi, >> >> Sandeep Singh writes: >>> From: Sandeep Singh >>> >>> Certain HP keyboards would keep inputting a character automatically which >>> is the

Re: [PATCH v3] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

2017-08-09 Thread Sandeep Singh
On 8/4/2017 4:44 PM, Felipe Balbi wrote: > > Hi, > > Sandeep Singh writes: >> From: Sandeep Singh >> >> Certain HP keyboards would keep inputting a character automatically which >> is the wake-up key after S3 resume >> >> On some AMD platforms

[PATCH] usb: renesas_usbhs: gadget: fix spin_lock_init() for >lock

2017-08-09 Thread Yoshihiro Shimoda
This patch fixes an issue that the spin_lock_init() is not called for almost all pipes. Otherwise, the lockdep output the following message when we connect a usb cable using g_ncm: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking

Re: [PATCH v2 2/5] usb: xhci: Fix potential memory leak in xhci_disable_slot()

2017-08-09 Thread Mathias Nyman
On 27.07.2017 05:21, Lu Baolu wrote: xhci_disable_slot() allows the invoker to pass a command pointer as paramenter. Otherwise, it will allocate one. This will cause memory leak when a command structure was allocated inside of this function while queuing command trb fails. Another problem comes

Re: f_hid.c conversion to the new function interface and crash due to race

2017-08-09 Thread Felipe Balbi
Hi, noman pouigt writes: > Hello, > > I am currently using 3.18 linux kernel and getting below return -EKERNELTOOOLD; Sorry, you're on your own. You should ask for support from whoever forces you to use 3.18 kernel. -- balbi signature.asc Description: PGP signature

[PATCH] USB: atm: make atmdev_ops const

2017-08-09 Thread Bhumika Goyal
Make these const as they are only passed to the function atm_dev_register and the corresponding argument is of type const. Done using Coccinelle. Signed-off-by: Bhumika Goyal --- drivers/usb/atm/usbatm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

f_hid.c conversion to the new function interface and crash due to race

2017-08-09 Thread noman pouigt
Hello, I am currently using 3.18 linux kernel and getting below spinlock crashe in f_hid.c driver (https://goo.gl/3mdAr1). Crash is happening due to race condition between hidg_unbind and f_hidg_poll function. This is still a problem with latest kernel though as cdev_del(>cdev) is racing with

Re: [PATCH] USB: serial: pl2303: add new ATEN device id

2017-08-09 Thread Johan Hovold
On Tue, Aug 08, 2017 at 12:58:51PM -0700, Greg Kroah-Hartman wrote: > This adds a new ATEN device id for a new pl2303-based device. > > Reported-by: Peter Kuo > Cc: stable > Signed-off-by: Greg Kroah-Hartman > > --- >

Re: [PATCH v2 1/5] usb: xhci: Disable slot even virt-dev is null

2017-08-09 Thread Mathias Nyman
On 27.07.2017 05:21, Lu Baolu wrote: xhci_disable_slot() is a helper for disabling a slot when a device goes away or recovers from error situations. Currently, it checks the corespoding virt-dev pointer and returns directly (w/o issuing disable slot command) if it's null. This is unnecessary

[PATCH] usb: gadget: f_uac2: constify snd_pcm_ops structures

2017-08-09 Thread Arvind Yadav
snd_pcm_ops are not supposed to change at runtime. All functions working with snd_pcm_ops provided by work with const snd_pcm_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/usb/gadget/function/u_audio.c | 2 +- 1 file changed, 1

AW: AW: new usb LTE modem device

2017-08-09 Thread Giuseppe Lippolis
> sendsetup is to prevent the driver from sending a specific USB control > message for setting up serial parameters, which some devices ignore and > cause the driver to stall. > > reserved is what you're looking for. This one tells option not to bind to the > given USB interfaces. > > So for