Re: [PATCH] xhci:Fix NULL pointer in xhci debugfs

2018-01-18 Thread Mathias Nyman
On 19.01.2018 04:13, Zhengjun Xing wrote: Commit dde634057da7 ("xhci: Fix use-after-free in xhci debugfs") causes a null pointer dereference while fixing xhci-debugfs usage of ring pointers that were freed during hibernate. The fix passed addresses to ring pointers instead, but forgot to do

RE: [RFC V2 PATCH 3/3] usb: chipidea: usbmisc: small clean up

2018-01-18 Thread Peter Chen
> > Signed-off-by: Michael Trimarchi > --- > Changes v1->v2: > - None > --- > drivers/usb/chipidea/usbmisc_imx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/chipidea/usbmisc_imx.c >

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-18 Thread 李書帆
Hi Jun, For now, RT1711H is not fully compatible with TCPCI. So the existing tcpci.c may not work for it. Best Regards, * Shu-Fan Lee Richtek Technology Corporation TEL: +886-3-5526789 #2359 FAX: +886-3-5526612 * -Original

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-18 Thread Jun Li
Hi > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of ShuFanLee > Sent: Wednesday, January 10, 2018 2:59 PM > To: heikki.kroge...@linux.intel.com > Cc: cy_hu...@richtek.com; shufan_...@richtek.com; linux- >

[PATCH] xhci:Fix NULL pointer in xhci debugfs

2018-01-18 Thread Zhengjun Xing
Commit dde634057da7 ("xhci: Fix use-after-free in xhci debugfs") causes a null pointer dereference while fixing xhci-debugfs usage of ring pointers that were freed during hibernate. The fix passed addresses to ring pointers instead, but forgot to do this change for the xhci_ring_trb_show

[PATCH] usbip: vhci_hcd: update 'status' file header and format

2018-01-18 Thread Shuah Khan
Commit 2f2d0088eb93 ("usbip: prevent vhci_hcd driver from leaking a socket pointer address") in the /sys/devices/platform/vhci_hcd/status. Fix the header and field alignment to reflect the changes and make it easier to read. Signed-off-by: Shuah Khan ---

[PATCH] usb: gadget: compress return logic into one line

2018-01-18 Thread Gustavo A. R. Silva
Simplify return logic and avoid unnecessary variable assignment. Signed-off-by: Gustavo A. R. Silva --- drivers/usb/gadget/legacy/ncm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/legacy/ncm.c

[PATCH v4] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

2018-01-18 Thread Ladislav Michl
Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren Acked-by: Roger Quadros Acked-by: Alan Stern --- Changes: - v2:

Re: [PATCH] dts-bindings: usb-uhci: Document newly added properties

2018-01-18 Thread Joel Stanley
On Mon, Jan 15, 2018 at 6:06 PM, Benjamin Herrenschmidt wrote: > Commit 4642d34a439f80e16af0d56ed6258a33abae257a > "usb/uhci: Add support for Aspeed BMC SoCs" added > support for a new #ports property, along with > Aspeed specific compatible strings. This adds >

Re: [PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

2018-01-18 Thread Alan Stern
On Thu, 18 Jan 2018, Ladislav Michl wrote: > On Thu, Jan 18, 2018 at 10:18:41AM -0500, Alan Stern wrote: > > On Thu, 18 Jan 2018, Ladislav Michl wrote: > > > > > Don't complain on -EPROBE_DEFER when no PHY found, the driver > > > probe will be retried later. > > > > > > Signed-off-by: Ladislav

[RFC V2 PATCH 3/3] usb: chipidea: usbmisc: small clean up

2018-01-18 Thread Michael Trimarchi
The register write can be done outside the if and else condition Signed-off-by: Michael Trimarchi --- Changes v1->v2: - None --- drivers/usb/chipidea/usbmisc_imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[RFC V2 PATCH 2/3] usb: chipidea: usbmisc: evdo can be set e/o reset

2018-01-18 Thread Michael Trimarchi
evdo bit can be set or reset. We can not trust evdo bit status after bootloader stage Signed-off-by: Michael Trimarchi --- Changes v1->v2: - None --- drivers/usb/chipidea/usbmisc_imx.c | 20 1 file changed, 12 insertions(+), 8

[RFC V2 PATCH 1/3] usb: chipidea: usbmisc: evdo is only specific to OTG port

2018-01-18 Thread Michael Trimarchi
The USB_PHY_CTRL_FUNC is used specific for OTG port as described in user manual. EVDO need to be set only for index 0 that correspond to OTG port Signed-off-by: Michael Trimarchi --- Changes v1->v2 - %s/corrispond/correspond/ ---

RE: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, January 18, 2018 10:57 AM > To: David Miller > Cc: Hayes Wang ; gre...@linuxfoundation.org; linux- > u...@vger.kernel.org; net...@vger.kernel.org;

Re: [PATCH v6 00/99] XArray version 6

2018-01-18 Thread Matthew Wilcox
On Thu, Jan 18, 2018 at 05:56:12PM +0100, David Sterba wrote: > On Thu, Jan 18, 2018 at 08:48:43AM -0800, Matthew Wilcox wrote: > > Thank you! I shall attempt to debug. Was this with a btrfs root > > filesystem? I'm most suspicious of those patches right now, since they've > > received next to

Re: [PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

2018-01-18 Thread Ladislav Michl
On Thu, Jan 18, 2018 at 10:18:41AM -0500, Alan Stern wrote: > On Thu, 18 Jan 2018, Ladislav Michl wrote: > > > Don't complain on -EPROBE_DEFER when no PHY found, the driver > > probe will be retried later. > > > > Signed-off-by: Ladislav Michl > > Acked-by: Tony Lindgren

Re: [PATCH v6 00/99] XArray version 6

2018-01-18 Thread David Sterba
On Thu, Jan 18, 2018 at 08:48:43AM -0800, Matthew Wilcox wrote: > Thank you! I shall attempt to debug. Was this with a btrfs root > filesystem? I'm most suspicious of those patches right now, since they've > received next to no testing. I'm going to put together a smaller patchset > which just

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread Kai Heng Feng
> On 18 Jan 2018, at 10:50 PM, David Miller wrote: > > From: Hayes Wang > Date: Thu, 18 Jan 2018 03:04:08 + > >> [...] r8153 on Dell TB15/16 dock corrupts rx packets. This change is suggested by Realtek. They guess that the XHCI

Re: [PATCH] usb: dwc3: core: power on PHYs before initializing core

2018-01-18 Thread Enric Balletbo Serra
2018-01-17 22:46 GMT+01:00 Brian Norris : > On Fri, Jan 12, 2018 at 12:00:16PM +0800, William Wu wrote: >> The dwc3_core_init() gets the PHYs and initializes the PHYs with >> the usb_phy_init() and phy_init() functions before initializing >> core, and power on the PHYs

Re: [PATCH v6 00/99] XArray version 6

2018-01-18 Thread Matthew Wilcox
On Thu, Jan 18, 2018 at 05:07:50PM +0100, David Sterba wrote: > On Wed, Jan 17, 2018 at 12:20:24PM -0800, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > This version of the XArray has no known bugs. > > I've booted this patchset on 2 boxes, both had random

Re: [PATCH v6 00/99] XArray version 6

2018-01-18 Thread David Sterba
On Wed, Jan 17, 2018 at 12:20:24PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > This version of the XArray has no known bugs. I've booted this patchset on 2 boxes, both had random problems during boot. On one I was not able to diagnose what went wrong. On the

Re: Not enough bandwidth with Magewell XI100DUSB-HDMI

2018-01-18 Thread Mathias Nyman
On 17.01.2018 18:46, Michael Tretter wrote: Hello, I am using a Magewell XI100DUSB-HDMI frame grabber which by itself works fine. However, I get a "Not enough bandwidth for new device state." error for any other USB device that is plugged after the frame grabber. This error is caused by the xHC

[BUG] usbfs "did not claim interface before use"

2018-01-18 Thread Matthew Wilcox
My laptop just died horribly and I'm picking through the pieces. I'm running Debian testing, and it was kernel 4.13.0-1-amd64 #1 Debian 4.13.13-1 although now I've rebooted to 4.14.0-2-amd64 #1 SMP Debian 4.14.7-1 It seems that the original cause of the problem was usbfs going mad and spraying

Re: [PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

2018-01-18 Thread Alan Stern
On Thu, 18 Jan 2018, Ladislav Michl wrote: > Don't complain on -EPROBE_DEFER when no PHY found, the driver > probe will be retried later. > > Signed-off-by: Ladislav Michl > Acked-by: Tony Lindgren > Acked-by: Roger Quadros > --- >

Re: [PATCH v1 1/1] usb: xhci: do not create and register shared_hcd when USB3.0 is disabled

2018-01-18 Thread Mathias Nyman
On 18.01.2018 09:27, Tung Vuong Nguyen wrote: On Tue, Jan 16, 2018 at 9:50 PM, Mathias Nyman wrote: Hi, Sorry about the delay On 04.01.2018 07:17, Thang Q. Nguyen wrote: Hi, On Sat, Dec 16, 2017 at 10:45 AM, Thang Q. Nguyen wrote: From:

Re: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread David Miller
From: Hayes Wang Date: Thu, 18 Jan 2018 03:04:08 + > [...] >> > r8153 on Dell TB15/16 dock corrupts rx packets. >> > >> > This change is suggested by Realtek. They guess that the XHCI >> > controller doesn't have enough buffer, and their guesswork is correct, >> > once

Re: [PATCH v6 85/99] btrfs: Remove unused spinlock

2018-01-18 Thread David Sterba
On Wed, Jan 17, 2018 at 12:21:49PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The reada_lock in struct btrfs_device was only initialised, and not > actually used. That's good because there's another lock also called > reada_lock in the btrfs_fs_info that was

RE: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver

2018-01-18 Thread 李書帆
Dear Gerg, Many thanks to your comment. I've checked all of them and here are some questions need your help. > +Example: > +rt1711h@4e { > +status = "ok"; > +compatible = "richtek,typec_rt1711h"; > +reg = <0x4e>; > +rt,intr_gpio = < 0 0x0>; > +rt,name = "rt1711h"; > +rt,port_type = <2>; /*

Re: [PATCH v2] usb: dwc3: core: Power-off core/PHYs on system_suspend in host mode

2018-01-18 Thread Roger Quadros
On 18/01/18 13:24, Manu Gautam wrote: > Commit 689bf72c6e0d ("usb: dwc3: Don't reinitialize core during > host bus-suspend/resume") updated suspend/resume routines to not > power_off and reinit PHYs/core for host mode. > It broke platforms that rely on DWC3 core to power_off PHYs to > enter low

[PATCH v2] usb: dwc3: core: Power-off core/PHYs on system_suspend in host mode

2018-01-18 Thread Manu Gautam
Commit 689bf72c6e0d ("usb: dwc3: Don't reinitialize core during host bus-suspend/resume") updated suspend/resume routines to not power_off and reinit PHYs/core for host mode. It broke platforms that rely on DWC3 core to power_off PHYs to enter low power state on system suspend. Perform

Re: [PATCH] usb: dwc3: core: Power-off core/PHYs on system_suspend in host mode

2018-01-18 Thread Manu Gautam
Hi Roger, On 1/17/2018 4:16 PM, Roger Quadros wrote: > Manu, > > On 16/01/18 08:26, Manu Gautam wrote: > [snip] > After these changes applied, I could get suspend/resume working properly on > dra7x-evm > for host, device and dual-role cases. > Thanks Roger. I will incorporate these changes

[PATCH] CDC-ACM: apply quirk for card reader

2018-01-18 Thread Oliver Neukum
This devices drops random bytes from messages if you talk to it too fast. Signed-off-by: CC: sta...@vger.kernel.org --- drivers/usb/class/cdc-acm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index

Questions about "usb usb8-port1: cannot disable (err = -32)"

2018-01-18 Thread Yoshihiro Shimoda
Hi, My environment (R-Car H3) outputs the following error when I disconnected a usb 3.0 SSD device from the xhci host controller. [ 267.755777] xhci-hcd ee00.usb: Cannot set link state. [ 267.761188] usb usb8-port1: cannot disable (err = -32) [ 267.772166] usb 8-1: USB disconnect, device

[PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found

2018-01-18 Thread Ladislav Michl
Don't complain on -EPROBE_DEFER when no PHY found, the driver probe will be retried later. Signed-off-by: Ladislav Michl Acked-by: Tony Lindgren Acked-by: Roger Quadros --- Changes: - v2: None, just added Tony's ack - v3: Fixed commit