Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-16 Thread Tushar Nimkar
On 2018-04-16 20:03, Oliver Neukum wrote: Am Montag, den 16.04.2018, 10:23 -0400 schrieb Alan Stern: > > > > [57246.701096] sd 1:0:0:0: tag#0 uas_eh_abort_handler 0 uas-tag 1 > > > > inflight: CMD IN > > > > [57246.701130] sd 1:0:0:0: tag#0 CDB: opcode=0x1a 1a 00 3f 00 04 00 > > URB is canceled,

[PATCH RFC] usb: typec: tcpm: remove operating_snk_mw for rdo

2018-04-16 Thread Li Jun
This patch is a further update for rdo based on [1], which removed max_snk_ma/mv/mw but kept operating_snk_mw. operating_snk_mw is only used to judge capability mismatch, per PD spec, we can achieve this via compare the selected source PDO and matching sink PDO, also after patch [1], we don't limit

[PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error

2018-04-16 Thread Randy Dunlap
From: Randy Dunlap The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB Makefile does not currently build drivers/usb/common/ (where USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify the USB Makefile to always descend into drivers/usb/common/ to build its configured targets.

Re: [PATCH v2 1/3] dt-bindings: usb: Update documentation for Qualcomm DWC3 driver

2018-04-16 Thread Manu Gautam
Hi Rob, On 4/17/2018 2:08 AM, Rob Herring wrote: > On Fri, Apr 13, 2018 at 10:21:22PM +0530, Manu Gautam wrote: >> Existing documentation has lot of incorrect information as it >> was originally added for a driver that no longer exists. >> >> Signed-off-by: Manu Gautam >> --- >> .../devicetree/

refine xhci-plat-Fix-xhci_plat-shutdown-sequence

2018-04-16 Thread leiwan
xhci-plat Shutdown callback should check HCD_FLAG_HW_ACCESSIBLE before accessing any register. This should avoid hung with access controllers which support runtime suspend This can fix for issue of https://patchwork.kernel.org/patch/10339317/ corresponding upload in CAF: https://source.codeauror

ConfigFS, FunctionFS, and MS XInput

2018-04-16 Thread Daniel Hefti
Hey guys, I've been banging my head against the wall for a couple of days trying to get a Raspberry Pi 0W to talk to Windows (8.1/10) as an XInput game controller using ConfigFS and FunctionFS, having little success. I've tried to build both a generic XInput device and one that attempts to e

[PATCH 1/3] usb: gadget: f_fs: Only return delayed status when len is 0

2018-04-16 Thread Jerry Zhang
Commit 1b9ba000 ("Allow function drivers to pause control transfers") states that USB_GADGET_DELAYED_STATUS is only supported if data phase is 0 bytes. It seems that when the length is not 0 bytes, there is no need to explicitly delay the data stage since the transfer is not completed until the us

[PATCH 3/3] Documentation: usb: Add docs for configfs control requests

2018-04-16 Thread Jerry Zhang
Signed-off-by: Jerry Zhang --- Documentation/usb/gadget_configfs.txt | 32 +++ 1 file changed, 32 insertions(+) diff --git a/Documentation/usb/gadget_configfs.txt b/Documentation/usb/gadget_configfs.txt index 635e57493709..a50f16c8a4bb 100644 --- a/Documentation/usb/gadg

[PATCH 2/3] usb: gadget: configfs: Create control_config group

2018-04-16 Thread Jerry Zhang
Control_config is a group under gadget that acts as a normal config group, except it does not appear in cdev->configs. Functions can be linked into the config as normal, and those functions are bound and unbound with the rest of the gadget. Create configfs_setup(), which will first attempt composi

[PATCH 0/3] Handle custom control requests in userspace

2018-04-16 Thread Jerry Zhang
Here is the patch set I proposed in https://www.spinics.net/lists/linux-usb/msg167533.html. Vendor specific control requests are a significant category of USB communications. With the current framework, it is difficult for a composite gadget to handle these requests since any function could be ac

Proposal

2018-04-16 Thread MS Zeliha Omer Faruk
Hello Greeetings to you please did you get my previous email regarding my investment proposal last week friday ? MS.Zeliha ömer faruk zeliha.omer.fa...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 1/3] dt-bindings: usb: Update documentation for Qualcomm DWC3 driver

2018-04-16 Thread Rob Herring
On Fri, Apr 13, 2018 at 10:21:22PM +0530, Manu Gautam wrote: > Existing documentation has lot of incorrect information as it > was originally added for a driver that no longer exists. > > Signed-off-by: Manu Gautam > --- > .../devicetree/bindings/usb/qcom,dwc3.txt | 78 > ++

Re: [PATCH 3/3] USB: musb: dsps: propagate device-tree node

2018-04-16 Thread Bin Liu
Johan, On Fri, Apr 13, 2018 at 05:15:05PM +0200, Johan Hovold wrote: > To be able to use DSPS-based controllers with device-tree descriptions > of the USB topology, we need to associate the glue device's device-tree > node with the child controller device. > > Note that this can also be used to e

Re: [PATCH 4/4] dt-bindings: Document the DT bindings for lan78xx

2018-04-16 Thread Rob Herring
On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote: > The Microchip LAN78XX family of devices are Ethernet controllers with > a USB interface. Despite being discoverable devices it can be useful to > be able to configure them from Device Tree, particularly in low-cost > applications withou

[PATCH 04/11] usb: musb: remove some register access wrapper functions

2018-04-16 Thread Bin Liu
The following wrappers were defined because of Blackfin support. Now Blackfin support is removed, these wrappers are no longer needed, so remove them. musb_write_txfifosz musb_write_txfifoadd musb_write_rxfifosz musb_write_rxfifoadd musb_write_ulpi_buscontro

[PATCH 10/11] usb: musb: remove references to default_a of struct usb_otg

2018-04-16 Thread Bin Liu
musb drivers do not use the otg fsm framework, so referencing to otg->default_a doesn't have any effect, so remove the references. But tusb6010 glue driver uses it locally to control the vbus power, so keep the references in tusb6010 only. Signed-off-by: Bin Liu --- drivers/usb/musb/am35x.c

[PATCH 09/11] usb: musb: break the huge isr musb_stage0_irq() into small functions

2018-04-16 Thread Bin Liu
musb_stage0_irq() is 400+ lines long. Break its interrupt events handling into each individual functions to make it easy to read. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 730 +++ 1 file changed, 384 insertions(+), 346 deletions(-) diff -

[PATCH 11/11] usb: musb: disable otg protocol support

2018-04-16 Thread Bin Liu
As decided in the discussion [1] we are deleting the otg protocol support from the musb drivers. First this patch disables the flags for enabling the otg protocols. We will later gradually delete the otg protocol code from the musb drivers. [1] https://www.spinics.net/lists/linux-usb/msg167003.ht

[PATCH 05/11] usb: musb: remove duplicated quirks flag

2018-04-16 Thread Bin Liu
Both musb_io and musb_platform_ops in struct musb define a quirks flag for the same purpose. Let's remove the one in struct musb_io, and use that in struct musb_platform_ops instead. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 10 -- drivers/usb/musb/musb_cppi41.c | 4 +

[PATCH 07/11] usb: musb: remove duplicated port mode enum

2018-04-16 Thread Bin Liu
include/linux/usb/musb.h already defines enum for musb port mode, so remove the duplicate in musb_core.h and use the definition in musb.h. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c| 8 drivers/usb/musb/musb_core.h| 8 +--- drivers/usb/musb/musb_dsps.c| 6 ++

[PATCH 08/11] usb: musb: remove unused members in struct musb_hdrc_config

2018-04-16 Thread Bin Liu
The following members in struct musb_hdrc_config are not used, so remove them. soft_con utm_16 big_endian mult_bulk_tx mult_bulk_rx high_iso_tx high_iso_rx dma dma_channels dyn_fifo_size vendor_ctrl vendor_stat vendor_req dma_req_chan musb_hdrc_eps_bits Signed-off-by: Bin Liu --- drivers/usb/mu

[PATCH 06/11] usb: musb: dsps: remove duplicated get_musb_port_mode()

2018-04-16 Thread Bin Liu
musb_core already has musb_get_mode(), so remove the duplicate from musb_dsps.c. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_dsps.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 05a

[PATCH 00/11] usb: musb: cleanup

2018-04-16 Thread Bin Liu
Hi, Blackfin arch support is removed in v4.17-rc1, now some code in musb drivers, which was used for Blackfin handling, can be cleaned up. This series also removes some duplicated or dead code in musb drivers, and disables OTG protocol support as well per discussion in [1]. [1] https://www.spini

[PATCH 02/11] usb: musb: remove readl/writel from struct musb_platform_ops

2018-04-16 Thread Bin Liu
Now Blackfin support is removed, we no longer need function pointers for musb_readl() and musb_writel(). Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.c | 34 -- drivers/usb/musb/musb_core.h | 4 drivers/usb/musb/musb_io.h | 4 ++-- 3 files change

[PATCH 03/11] usb: musb: remove adjust_channel_params() callback from musb_platform_ops

2018-04-16 Thread Bin Liu
Now Blackfin support is removed, nobody uses adjust_channel_params() any more, so remove it from struct musb_platform_ops. Signed-off-by: Bin Liu --- drivers/usb/musb/musb_core.h | 4 drivers/usb/musb/musbhsdma.c | 8 2 files changed, 12 deletions(-) diff --git a/drivers/usb/musb/

[PATCH 01/11] usb: musb: merge musbhsdma.h into musbhsdma.c

2018-04-16 Thread Bin Liu
Now Blackfin support is removed, header musbhsdma.h is only included in musbhsdma.c. So let's merge the content in musbhsdma.h to musbhsdma.c and delete musbhsdma.h. Signed-off-by: Bin Liu --- drivers/usb/musb/musbhsdma.c | 66 +++- drivers/usb/musb/musbhsdma.

Re: [PATCH v1 1/1] usb: core: Add quirk for HP v222w 16GB Mini

2018-04-16 Thread sathyanarayanan kuppuswamy
Hi Segei, On 04/14/2018 01:35 AM, Sergei Shtylyov wrote: Please indent with tabs (as above and below), not spaces. Thanks for the comments. I will fix it in v2. -- Sathyanarayanan Kuppuswamy Linux kernel developer -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: Add udev-md-raid-safe-timeouts.rules

2018-04-16 Thread Alan Stern
On Mon, 16 Apr 2018, Chris Murphy wrote: > Adding linux-usb@ and linux-scsi@ > (This email does contain the thread initiating email, but some replies > are on the other lists.) > > On Mon, Apr 16, 2018 at 5:43 AM, Austin S. Hemmelgarn > wrote: > > On 2018-04-15 21:04, Chris Murphy wrote: > >> >

Re: Add udev-md-raid-safe-timeouts.rules

2018-04-16 Thread Chris Murphy
Adding linux-usb@ and linux-scsi@ (This email does contain the thread initiating email, but some replies are on the other lists.) On Mon, Apr 16, 2018 at 5:43 AM, Austin S. Hemmelgarn wrote: > On 2018-04-15 21:04, Chris Murphy wrote: >> >> I just ran into this: >> >> https://github.com/neilbrown/

dwc2 ff540000.usb: dwc2_hc_chhltd_intr_dma: Channel 11 - ChHltd set, but reason is unknown

2018-04-16 Thread Rodrigo Stuffs
Hi there Minas / linux-usb ; I have a good ole APC Back-UPS ES 600N that from time to time resolves that it should stop talking to my SBCs. This issue happened in my Raspberry Pi, and when it stopped I had the following printk: Apr 11 14:10:15 localhost kernel: [9416331.806123] hid-generic 0003:

Re: [PATCH] usb: mon: Change return type to vm_fault_t

2018-04-16 Thread Greg KH
On Mon, Apr 16, 2018 at 05:18:35PM +0530, Souptick Joarder wrote: > On Mon, Apr 16, 2018 at 1:17 PM, Greg KH wrote: > > On Sun, Apr 15, 2018 at 04:10:08AM -0700, Matthew Wilcox wrote: > >> On Sun, Apr 15, 2018 at 07:49:16AM +0200, Greg KH wrote: > >> > On Sun, Apr 15, 2018 at 12:36:02AM +0530, Sou

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-16 Thread Oliver Neukum
Am Montag, den 16.04.2018, 10:23 -0400 schrieb Alan Stern: > > > > > [57246.701096] sd 1:0:0:0: tag#0 uas_eh_abort_handler 0 uas-tag 1 > > > > > inflight: CMD IN > > > > > [57246.701130] sd 1:0:0:0: tag#0 CDB: opcode=0x1a 1a 00 3f 00 04 00 > > > > URB is canceled, maybe that URB never finished? >

[PATCH v2] usb: mon: Change return type to vm_fault_t

2018-04-16 Thread Souptick Joarder
Use new return type vm_fault_t for the fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. Reference commit id-> 1c8f422059ae5da07d

Re: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

2018-04-16 Thread Rob Herring
On Mon, Apr 16, 2018 at 6:54 AM, Jun Li wrote: > Hi >> -Original Message- >> From: Rob Herring [mailto:r...@kernel.org] >> Sent: 2018年4月10日 4:04 >> To: Jun Li >> Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; >> li...@roeck-us.net; a.ha...@samsung.com; shufan_...@richtek

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-16 Thread Alan Stern
On Mon, 16 Apr 2018, Mathias Nyman wrote: > On 16.04.2018 13:20, Tushar Nimkar wrote: > > On 2018-04-05 11:31, Felipe Balbi wrote: > >> Hi, > >> > >> it would help if you would Cc XHCI's maintainer :-) > >> > >> tnim...@codeaurora.org writes: > >> > >>> On 2018-04-04 19:28, Greg KH wrote: > O

Re: [RFC PATCH] usb: hcd: complete URBs in threaded-IRQ context instead of tasklet

2018-04-16 Thread Sebastian Andrzej Siewior
On 2018-03-08 10:57:39 [+0100], To Mauro Carvalho Chehab wrote: > On 2018-02-27 14:39:34 [-0300], Mauro Carvalho Chehab wrote: > > Hi Sebastian, > Hi Mauro, > > > Sorry for taking some time to test it, has been busy those days... > :) > > > Anyway, I tested it today. Didn't work. It keep losing d

Re: [PATCH] usb: mon: Change return type to vm_fault_t

2018-04-16 Thread Matthew Wilcox
On Mon, Apr 16, 2018 at 05:18:35PM +0530, Souptick Joarder wrote: > On Mon, Apr 16, 2018 at 1:17 PM, Greg KH wrote: > > When a maintainer gets a patch with no context at all, the first > > reaction is to just reject it (especially as many of these patches were > > sent privately and did not go on

Re: [PATCH 02/20] usb: host: xhci: check DYING state earlier

2018-04-16 Thread Mathias Nyman
On 16.04.2018 15:29, Felipe Balbi wrote: Instead of allocating urb priv and, maybe, bail out due to xhci being in DYING state, we can move the check earlier and avoid the memory allocation altogether. This also moves checking for DYING outside the lock. Most cases set DYING with lock held, so

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-16 Thread Mathias Nyman
On 16.04.2018 13:20, Tushar Nimkar wrote: On 2018-04-05 11:31, Felipe Balbi wrote: Hi, it would help if you would Cc XHCI's maintainer :-) tnim...@codeaurora.org writes: On 2018-04-04 19:28, Greg KH wrote: On Wed, Apr 04, 2018 at 06:41:41PM +0530, tnim...@codeaurora.org wrote: On 2018-04-0

[PATCH] usb: dwc2: WA for Full speed ISOC IN in DDMA mode.

2018-04-16 Thread Artur Petrosyan
By clearing NAK status of EP, core will send ZLP to IN token and assert NAK interrupt relying on TxFIFO status only. The WA applies only to core versions from 2.72a to 4.00a (including both). Also for FS_IOT_1.00a and HS_IOT_1.00a. Signed-off-by: Artur Petrosyan Signed-off-by: Minas Harutyunyan

[PATCH 01/20] usb: host: xhci: rename queue_bulk_tx() to queue_bulk_intr_tx()

2018-04-16 Thread Felipe Balbi
That function is used for both Bulk and Interrupt transfer types, let's make it clear on the function name and provide one extra helper for queueing bulk transfers. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 23 +-- drivers/usb/host/xhci.c | 6 --

[PATCH 17/20] usb: host: xhci: reorder variable declaration

2018-04-16 Thread Felipe Balbi
no functional changes. Cleanup only Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 4c2bc9d1678e..cd5b6bf4c867 100644 --- a/drivers/usb/host/xhci.c +++ b

[PATCH 20/20] usb: host: xhci: free priv outside of locked region

2018-04-16 Thread Felipe Balbi
In case we have any errors, we can free_priv with locks released and interrupts enabled. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 0fab051f06fc..32aef7c9a67

[PATCH 18/20] usb: host: xhci: make ep_state a value, not a reference

2018-04-16 Thread Felipe Balbi
This is now the single use of ep_state inside urb_enqueue(). We don't need it to be a pointer anymore. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index cd5b6bf

[PATCH 19/20] usb: host: xhci: check CLEAR_TOGGLE earlier

2018-04-16 Thread Felipe Balbi
There's not need to delay check for CLEAR_TOGGLE until after we have allocated urbpriv. Let's move it earlier and, finally, remove the free_priv goto label. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/d

[PATCH 05/20] usb: host: xhci: introduce xhci_num_tds_for_urb() helper

2018-04-16 Thread Felipe Balbi
This helper computes the number of TDs for a given urb. Cleanup only, no functional changes. Note that while at that we've replaced an alignment check with the IS_ALIGNED() macro which makes the code slightly clearer about its intention. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c |

[PATCH 04/20] usb: host: xhci: check HCD_HW_ACCESSIBLE earlier

2018-04-16 Thread Felipe Balbi
This is the last check that can be done earlier. No functional changes. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 284dc6c10189..dba4c61f5cf6 1006

[PATCH 15/20] usb: host: xhci: rename xhci_queue_isoc_tx_prepare()

2018-04-16 Thread Felipe Balbi
cleanup only, no functional changes. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 6 +++--- drivers/usb/host/xhci.c | 2 +- drivers/usb/host/xhci.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/x

[PATCH 06/20] usb: host: xhci: reorder variable declarations

2018-04-16 Thread Felipe Balbi
Cleanup only, no functional changes. While at that, remove the initialization of ret which is now unnecessary. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c inde

[PATCH 03/20] usb: host: xhci: check full speed MPS change earlier

2018-04-16 Thread Felipe Balbi
By moving Full Speed max packet size change earlier, the code becomes a little more straight forward to read. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/xhci.c b/driver

[PATCH 16/20] usb: host: xhci: remove unnecessary NULL check

2018-04-16 Thread Felipe Balbi
xhci_urb_free_priv() is a simple wrapper around kfree() and kfree() is safe against NULL pointers. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index eefb748c2cb9..4

[PATCH 13/20] usb: host: xhci: extract xhci_maybe_stop_endpoint()

2018-04-16 Thread Felipe Balbi
This new helper is only here to aid readability. It handles the details about only queueing stop endpoint on the first URB cancellation. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff

[PATCH 14/20] usb: host: xhci: extract xhci_cancel_td()

2018-04-16 Thread Felipe Balbi
This little helper is here for readability. It handles the details about how to cancel a TD due to an urb being dequeued. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci.c b/driv

[PATCH 08/20] usb: host: xhci: convert add_timer() to mod_timer() calls

2018-04-16 Thread Felipe Balbi
Instead of initializing t->expires and calling add_timer(t) right after, we can rely on mod_timer(t, expires) to handle the details for us. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci

[PATCH 12/20] usb: host: xhci: remove pointless trace message

2018-04-16 Thread Felipe Balbi
That message doesn't bring a lot of extra information. What it prints can be understood from the existing tracepoints. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/h

[PATCH 10/20] usb: host: xhci: check DYING state earlier

2018-04-16 Thread Felipe Balbi
in case where xHCI dies, we can bail out a little earlier. Not really a functional change, just making the code follow a more straight-forward order. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 09/20] usb: host: xhci: reorder variable declarations

2018-04-16 Thread Felipe Balbi
cleanup only, no functional changes Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 64eb50115fac..3b19444aa1f3 100644 --- a/drivers/usb/host/xhci.

[PATCH 11/20] usb: host: xhci: extract xhci_manually_free_td() helper

2018-04-16 Thread Felipe Balbi
Cleanup only, no functional changes. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 6be3eb721157..5d2c24f58b34 100644 --- a/drive

[PATCH 02/20] usb: host: xhci: check DYING state earlier

2018-04-16 Thread Felipe Balbi
Instead of allocating urb priv and, maybe, bail out due to xhci being in DYING state, we can move the check earlier and avoid the memory allocation altogether. While at that, also remove an unnecessary empty line. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 13 ++--- 1 fil

[PATCH 07/20] usb: host: xhci: use msecs_to_jiffies() instead of HZ

2018-04-16 Thread Felipe Balbi
HZ can change based on CPUFreq. We should use msecs_to_jiffies() instead. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci.c | 3 +-- drivers/usb/host/xhci.h | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index ee

RE: [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI)

2018-04-16 Thread Jun Li
Hi > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: 2018年4月10日 4:04 > To: Jun Li > Cc: gre...@linuxfoundation.org; heikki.kroge...@linux.intel.com; > li...@roeck-us.net; a.ha...@samsung.com; shufan_...@richtek.com; Peter > Chen ; devicet...@vger.kernel.org; > linux

Re: Since Linux 4.13 tlp or powertop usage cause "xHCI host controller not responding, assume dead" on Dell 5855

2018-04-16 Thread Mathias Nyman
On 10.04.2018 12:15, russianneuroman...@ya.ru wrote: Hello! On Dell Venue 8 Pro 5855 tablet installing tlp or running "powertop -- auto-tune" cause "xHCI host controller not responding, assume dead" error, when error happen two integrated USB devices (Bluetooth adapter and LTE modem) disappear u

Re: [PATCH] usb: mon: Change return type to vm_fault_t

2018-04-16 Thread Souptick Joarder
On Mon, Apr 16, 2018 at 1:17 PM, Greg KH wrote: > On Sun, Apr 15, 2018 at 04:10:08AM -0700, Matthew Wilcox wrote: >> On Sun, Apr 15, 2018 at 07:49:16AM +0200, Greg KH wrote: >> > On Sun, Apr 15, 2018 at 12:36:02AM +0530, Souptick Joarder wrote: >> > > Use new return type vm_fault_t for fault handl

Re: [PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include

2018-04-16 Thread Ludovic Desroches
On Mon, Apr 16, 2018 at 11:34:04AM +0200, Romain Izard wrote: > The include defines the private platform_data structure used with AVR > platforms. It has no user since 7c55984e191f. Remove it. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches > --- > drivers/usb/gadget/udc/atmel_usba_

Re: [PATCH 3/3] usb: gadget: udc: atmel: Fix indenting

2018-04-16 Thread Ludovic Desroches
On Mon, Apr 16, 2018 at 11:34:05AM +0200, Romain Izard wrote: > Fix the fallout of the conversion to GPIO descriptors in 3df034081021. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches > --- > drivers/usb/gadget/udc/atmel_usba_udc.c | 18 +- > 1 file changed, 9 inserti

Re: [PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

2018-04-16 Thread Ludovic Desroches
On Mon, Apr 16, 2018 at 11:34:03AM +0200, Romain Izard wrote: > When converting to GPIO descriptors, gpiod_get_value automatically > handles the line inversion flags from the device tree. Thanks, I totally missed it. Regards > > Do not invert the line twice. > > Fixes: 3df034081021fa4b6967ce33

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-16 Thread Tushar Nimkar
On 2018-04-05 11:31, Felipe Balbi wrote: Hi, it would help if you would Cc XHCI's maintainer :-) tnim...@codeaurora.org writes: On 2018-04-04 19:28, Greg KH wrote: On Wed, Apr 04, 2018 at 06:41:41PM +0530, tnim...@codeaurora.org wrote: On 2018-04-04 18:07, Greg KH wrote: > On Wed, Apr 04, 2

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

2018-04-16 Thread Tushar Nimkar
On 2018-04-05 12:39, Felipe Balbi wrote: Hi, tnim...@codeaurora.org writes: On 2018-04-05 11:24, Felipe Balbi wrote: Hi, Greg KH writes: On Wed, Apr 04, 2018 at 05:14:50PM +0530, tnim...@codeaurora.org wrote: Hi Oliver/Greg, I am able to duplicated the UAS issue on 4.16 as well. The behav

[PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

2018-04-16 Thread Grigor Tovmasyan
In dwc2_gadget_init() we allocate EP0 request via dwc2_hsotg_ep_alloc_request(). After that there are usb_add_gadget_udc() call and if it failed, then ctrl_req will not be freed and will cause memory leak. Reordered function calls in gadget_init: moved up usb_add_gadget_udc() before dwc2_hsotg_ep_

[PATCH 1/3] usb: gadget: udc: atmel: GPIO inversion is handled by gpiod

2018-04-16 Thread Romain Izard
When converting to GPIO descriptors, gpiod_get_value automatically handles the line inversion flags from the device tree. Do not invert the line twice. Fixes: 3df034081021fa4b6967ce3364bc7d867ec1c870 Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 3 +-- drivers/usb/g

[PATCH 3/3] usb: gadget: udc: atmel: Fix indenting

2018-04-16 Thread Romain Izard
Fix the fallout of the conversion to GPIO descriptors in 3df034081021. Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/

[PATCH 2/3] usb: gadget: udc: atmel: Remove obsolete include

2018-04-16 Thread Romain Izard
The include defines the private platform_data structure used with AVR platforms. It has no user since 7c55984e191f. Remove it. Signed-off-by: Romain Izard --- drivers/usb/gadget/udc/atmel_usba_udc.c | 1 - include/linux/usb/atmel_usba_udc.h | 24 2 files changed, 2

[PATCH 0/3] Fix an Atmel USBA UDC issue introducted in 4.17-rc1

2018-04-16 Thread Romain Izard
The use of GPIO descriptors takes care of inversion flags declared in the device tree. The conversion of the Atmel USBA UDC driver introduced in 4.17-rc1 missed it, and as a result the inversion will not work. In addition, cleanup the code to remove an include left behind after the suppression of

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-04-16 Thread Minas Harutyunyan
On 4/10/2018 2:21 PM, Grigor Tovmasyan wrote: > Here are two little fixes for LPM feature. > > First one is coverity warning fix. > > The Second one was asserted by Stefan Wahren. > > Changes from version 0: > > 1/2: > - Instead of converting parameter in the CHECK_RANGE macro > to in

Re: [PATCH] usb: mon: Change return type to vm_fault_t

2018-04-16 Thread Greg KH
On Sun, Apr 15, 2018 at 04:10:08AM -0700, Matthew Wilcox wrote: > On Sun, Apr 15, 2018 at 07:49:16AM +0200, Greg KH wrote: > > On Sun, Apr 15, 2018 at 12:36:02AM +0530, Souptick Joarder wrote: > > > Use new return type vm_fault_t for fault handler > > > in struct vm_operations_struct. > > > > Why?

Re: [PATCH] USB: ftdi_sio: Use jtag quirk for Arrow USB Blaster

2018-04-16 Thread Johan Hovold
On Wed, Apr 11, 2018 at 05:05:13PM +0300, Vasyl Vavrychuk wrote: > Arrow USB Blaster integrated on MAX1000 board uses the same vendor ID > (0x0403) and product ID (0x6010) as the "original" FTDI device. > > This patch avoids picking up by ftdi_sio of the first interface of this > USB device. After

Re: [PATCH] USB: serial: cp210x: Add ID for NI USB serial console

2018-04-16 Thread Johan Hovold
On Mon, Apr 09, 2018 at 10:23:55AM -0500, Kyle Roeschley wrote: > Added the USB VID and PID for the USB serial console on some National > Instruments devices. > > Signed-off-by: Kyle Roeschley Now applied, thanks. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

Re: [PATCH] USB: serial: simple: add libtransistor console

2018-04-16 Thread Johan Hovold
On Sat, Apr 07, 2018 at 02:32:48PM -0700, Collin May wrote: > Add simple driver for libtransistor USB console. > This device is implemented in software: > https://github.com/reswitched/libtransistor/blob/development/lib/usb_serial.c > > Signed-off-by: Collin May > Tested-by: Collin May No need

[PATCH v5 3/5] dt-bindings: usb: fusb302: remove max-sink-* properties

2018-04-16 Thread Li Jun
Remove max-sink-* properties since they are deprecated. Reviewed-by: Rob Herring Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/fcs,fusb302.txt | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302

[PATCH v5 1/5] usb: typec: tcpm: pdo matching optimization

2018-04-16 Thread Li Jun
This patch is a combination of commit 57e6f0d7b804 ("typec: tcpm: Only request matching pdos") and source pdo selection optimization based on it, instead of only compare between the same pdo type of sink and source, we should check source pdo voltage range is within the voltage range of one sink pd

[PATCH v5 5/5] usb: typec: tcpm: remove max_snk_mv/ma/mw

2018-04-16 Thread Li Jun
Since there is no user of max_snk_*, so we can remove them from tcpm. Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- drivers/usb/typec/tcpm.c | 12 include/linux/usb/tcpm.h | 9 - 2 files changed, 21 deletions(-) diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/t

[PATCH v5 2/5] usb: typec: fusb302: remove max_snk_* for sink config

2018-04-16 Thread Li Jun
Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- drivers/usb/typec/fusb302/fusb302.c | 42 - 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a

[PATCH v5 4/5] usb: typec: wcove: remove max_snk_* for sink config

2018-04-16 Thread Li Jun
Since max_snk_* is to be deprecated, so remove max_snk_* by adding a variable PDO for sink config. Reviewed-by: Hans de Goede Signed-off-by: Li Jun --- drivers/usb/typec/typec_wcove.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/typec/typec_wcove.c b/driver

[PATCH v5 0/5] usb: typec: remove max_snk_mv/ma/mw

2018-04-16 Thread Li Jun
This patch set is to remove max_snk_mv/ma/mw configs, as we should define the sink capability by sink PDOs, the first patch update the source PDO match policy by compare the voltage range between source and sink PDOs no matter what type they are, the following patchs remove those 3 variables from 2