Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-24 Thread Arnd Bergmann
On Tuesday 23 July 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: Where would you want to have those phy_address arrays stored? There are no board files when booting with DT. Not even saying that you don't need to

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Arnd Bergmann
On Thursday 25 July 2013, Kishon Vijay Abraham I wrote: On Thursday 25 July 2013 12:02 AM, Arnd Bergmann wrote: On Tuesday 23 July 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: Where would you want to have those

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Arnd Bergmann
On Thursday 25 July 2013, Laurent Pinchart wrote: On Wednesday 24 July 2013 20:32:03 Arnd Bergmann wrote: On Tuesday 23 July 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: Where would you want to have those

Re: [RFC PATCH 1/7] drivers: usb: phy: add a new driver for usb part of control module

2013-01-15 Thread Arnd Bergmann
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: +OMAP CONTROL USB + +Required properties: + - compatible: Should be ti,omap-control-usb + - reg : Address and length of the register set for the device. It contains + the address of control_dev_conf and otghs_control. + -

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread Arnd Bergmann
On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB has to act in host mode or in device mode. Writing to control module

Re: [RFC PATCH 1/7] drivers: usb: phy: add a new driver for usb part of control module

2013-01-15 Thread Arnd Bergmann
On Tuesday 15 January 2013, kishon wrote: Good point :-). Currently, none of the OMAP platforms have multiple control modules and it doesn't seem to be in the future (AFAIK). While it might be simpler to support multiple control devices with phandle, it might face the same complications as

[PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
/host/ehci-hcd.c:1255:0: note: this is the location of the previous definition In file included from drivers/usb/host/ehci-hcd.c:1254:0: drivers/usb/host/ehci-mxc.c:280:31: warning: 'ehci_mxc_driver' defined but not used Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Alan Stern st

[PATCH 00/15] ARM build regressions in v3.8

2013-01-21 Thread Arnd Bergmann
be much too late for that. At least the drivers don't seem to be too essential, as they are only built in allyesconfig but not in any of the defconfigs. Arnd Arnd Bergmann (15): ARM: compressed/head.S: work around new binutils warning ARM: mvebu: build coherency_ll.S for arch=armv7-a ARM

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Felipe Balbi wrote: On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: Manjunath Goudar is already working on a patch to convert both the imx and the mvebu glue drivers (along with all the other ARM specific ones) to the new probing method

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. Ok, great! Thanks a lot,

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Alan Stern wrote: On Mon, 21 Jan 2013, Felipe Balbi wrote: On Mon, Jan 21, 2013 at 05:16:06PM +, Arnd Bergmann wrote: In linux-3.8-rc1 it became possible to build the imx and mvebu platforms together in a single kernel, which clashes in the ehci driver

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-21 Thread Arnd Bergmann
On Monday 21 January 2013, Alan Stern wrote: Is Manjunath aware of the first patch attached to this email message? http://marc.info/?l=linux-usbamp;m=135843902916416amp;w=2 I would not expect so. Manjunath is still learning about the open source processes, but he has also done a

Re: [PATCH 13/15] USB: ehci: make orion and mxc bus glues coexist

2013-01-22 Thread Arnd Bergmann
On Tuesday 22 January 2013, Alan Stern wrote: In order to prevent this, you have to make sure that each glue driver depends on USB_ARCH_HAS_EHCI. A simple way to do this is to surround the Kconfig entries for those drivers with if USB USB_ARCH_HAS_EHCI ... endif. I was actually thinking we

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Arnd Bergmann
On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Arnd Bergmann
On Tuesday 05 February 2013, Felipe Balbi wrote: [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o /dev/null

Re: [PATCH] usb: gadget: imx_udc: make it depend on BROKEN

2013-02-06 Thread Arnd Bergmann
it depend on BROKEN. Reported-by: Arnd Bergmann a...@arndb.de Signed-off-by: Felipe Balbi ba...@ti.com Acked-by: Arnd Bergmann a...@arndb.de Thanks for taking care of this! -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord

Re: [PATCH 04/10] USB: EHCI: make ehci-orion a separate driver

2013-02-07 Thread Arnd Bergmann
On Thursday 07 February 2013, manjunath.gou...@linaro.org wrote: @@ -155,7 +155,7 @@ static inline unsigned ehci_read_frame_index(struct ehci_hcd *ehci) * before driver shutdown. But it also seems to be caused by bugs in cardbus * bridge shutdown: shutting down the bridge before the

Re: [PATCH V2] usb: ehci: more bus glues as separate modules

2013-02-11 Thread Arnd Bergmann
On Monday 11 February 2013, manjunath.gou...@linaro.org wrote: From: Manjunath Goudar manjunath.gou...@linaro.org Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module Hi Manjunath, Please include in your next version of this a more verbose

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Arnd Bergmann
-by: Arnd Bergmann a...@arndb.de' for each patch. Alan, Greg: I realize that it's too late to take the entire series for 3.9, but with the move of more ARM platforms to CONFIG_ARCH_MULTIPLATFORM, it is now possible to enable OMAP, VT8500 and ORION concurrently, along with the ones that are already

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Arnd Bergmann
On Friday 15 February 2013, Greg KH wrote: Alan, Greg: I realize that it's too late to take the entire series for 3.9, but with the move of more ARM platforms to CONFIG_ARCH_MULTIPLATFORM, it is now possible to enable OMAP, VT8500 and ORION concurrently, along with the ones that are

[PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-15 Thread Arnd Bergmann
Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Jason Cooper ja...@lakedaemon.net Cc: Andrew Lunn and...@lunn.ch --- drivers/usb/host/Kconfig | 8 drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-hcd.c | 6 +-- drivers/usb/host/ehci-orion.c

[PATCH 1/2] USB: EHCI: make ehci-vt8500 a separate driver

2013-02-15 Thread Arnd Bergmann
...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Tony Prisk li...@prisktech.co.nz Cc: Alexey Charkov alch...@gmail.com --- drivers/usb/host/Kconfig | 8 + drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-hcd.c| 6 +--- drivers/usb/host/ehci-vt8500.c | 73

[PATCH] USB: update host controller Kconfig entries

2013-02-16 Thread Arnd Bergmann
mistakes in the Kconfig help text for the new options. Let's fix those and the other entries that have become stale over time. Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers

Re: [V2 2/8] USB: EHCI: make ehci-atmel a separate driver

2013-02-18 Thread Arnd Bergmann
On Monday 18 February 2013, Bo Shen wrote: - .name = atmel-ehci, + .name = hcd_name, This change will cause atmel ehci won't work with the none device tree kernel. it can be fixed with replace other places using atmel-ehci with hcd_name, that means replace

Re: [PATCH v2 0/5] Generic PHY Framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Manjunath Goudar wrote: This is not necessary; ehci_setup is the default value anyway. This structure can be omitted. ehci_init_driver function we are passing orion_overrides,if we are removing above struct initialization, what should we need to pass in the

Re: [PATCH v2 0/5] Generic PHY Framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, kishon wrote: On Tuesday 19 February 2013 04:14 PM, Arnd Bergmann wrote: On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: +static struct class *phy_class; +static LIST_HEAD(phy_list); +static DEFINE_MUTEX(phy_list_mutex); +static LIST_HEAD(phy_bind_list); Hmm, so you actually do have a 'class'. There is a GregKH mandated ban on new classes, meaning that

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, kishon wrote: + + devname = dev_name(dev); + device_initialize(phy-dev); + phy-desc = desc; + phy-dev.class = phy_class; + phy-dev.parent = dev; + phy-dev.bus = desc-bus; + ret = dev_set_name(phy-dev, %s, devname); Passing a bus_type

Re: [PATCH v2 0/5] Generic PHY Framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Felipe Balbi wrote: On Tue, Feb 19, 2013 at 12:33:54PM +, Arnd Bergmann wrote: Currently drivers/phy and drivers/net/phy are independent and are not related to each other. There are some fundamental differences on how these frameworks work. IIUC

Re: [PATCH v2 0/5] Generic PHY Framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Felipe Balbi wrote: On Tue, Feb 19, 2013 at 02:34:40PM +, Arnd Bergmann wrote: On Tuesday 19 February 2013, Felipe Balbi wrote: On Tue, Feb 19, 2013 at 12:33:54PM +, Arnd Bergmann wrote: It's a fine line, but I think a phy is something that resembles

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Arnd Bergmann
On Wednesday 20 February 2013, Alan Stern wrote: Currently there is no Kconfig option to control specifically whether the ehci-orion driver gets built; it always gets built whenever CONFIG_PLAT_ORION and CONFIG_USB_EHCI_HCD are both enabled. Do you think it is a good idea to add an option

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-20 Thread Arnd Bergmann
On Wednesday 20 February 2013, Greg KH wrote: On Tue, Feb 19, 2013 at 08:24:38AM +0100, Andrew Lunn wrote: GregKH: Please can you drop this patch from usb-next. It breaks more than it fixes. I've now reverted both of these, and the follow-on patch that Arnd sent in. Arnd, sorry, but

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Arnd Bergmann
On Friday 08 March 2013, Stephen Warren wrote: Yes, I think it should instead work like: ARCH_TEGRA* selects nothing in particular related to USB. The Tegra EHCI controller Kconfig depends on ARCH_TEGRA so it doesn't show up for other builds. Yes, that's fine. I hope it's OK for the

Re: [PATCH 00/10] usb: phy: cleanups to Kconfig and directories

2013-03-08 Thread Arnd Bergmann
On Friday 08 March 2013, Stephen Warren wrote: config USB_ULPI_VIEWPORT def_bool y depends on USB_EHCI_TEGRA If USB_ULPI_VIEWPORT has any other dependencies, the best solution in the above scenario is to make USB_EHCI_TEGRA depend on those. USB_ULPI_VIEWPORT is, AFAIK,

[RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
will be able to do this correctly and turn all ARM bus glues into separate modules, ripping out the code that this patch changes. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Alan Stern st...@rowland.harvard.edu Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Roger Quadros rog...@ti.com Cc

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Arnd Bergmann wrote: @@ -1409,10 +1409,20 @@ static int __init ehci_hcd_init(void) if (retval 0) goto clean4; #endif + +#ifdef OMAP_PLATFORM_DRIVER + retval = platform_driver_register(OMAP_PLATFORM_DRIVER); + if (retval 0

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Alan Stern wrote: On Fri, 15 Mar 2013, Arnd Bergmann wrote: @@ -89,12 +90,17 @@ static int ehci_platform_probe(struct platform_device *dev) return -ENXIO; } - if (pdata-power_on) { + if (pdata pdata-power_on) { err

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Alan Stern wrote: I just got an automated message from Greg: -- This is a note to let you know that I've just added the patch titled USB: EHCI: split ehci-omap out to a separate driver

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Sergei Shtylyov wrote: a) Apply Roger's patch for 3.9, and add my USB: EHCI: DT support for generic bus glue patch on top after it has been tested Arnd, sorry, where can I find this patch? Archive search doesn't turn up anything... It's in this email

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-15 Thread Arnd Bergmann
On Friday 15 March 2013, Greg Kroah-Hartman wrote: Unless something is changed, this patch won't get into 3.9-final. Do you want Greg to move it to his usb-linus branch? It's a bit too big for 3.9-final, sorry. Would you consider the hot fix at the start of this thread for 3.9 then? I

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Arnd Bergmann
On Saturday 16 March 2013, Greg Kroah-Hartman wrote: On Fri, Mar 15, 2013 at 09:13:52PM +, Arnd Bergmann wrote: On Friday 15 March 2013, Greg Kroah-Hartman wrote: Unless something is changed, this patch won't get into 3.9-final. Do you want Greg to move it to his usb-linus branch

[PATCH v2] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Arnd Bergmann
will be able to do this correctly and turn all ARM bus glues into separate modules, ripping out the code that this patch changes. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Alan Stern st...@rowland.harvard.edu Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Roger Quadros rog...@ti.com Cc

Re: [RFC] USB: EHCI: hot-fix OMAP and Orion multiplatform config

2013-03-18 Thread Arnd Bergmann
On Monday 18 March 2013, Arnaud Patard wrote: Arnd Bergmann a...@arndb.de writes: Sure, it's your decision. I just don't want to be accused of abandoning the issue that I caused. It's not strictly a regression because no configuration that was working in 3.8 is broken in 3.9, and embedded

USB: simplify clock lookup for mv ehci/otg/udc

2013-03-19 Thread Arnd Bergmann
that is a valid operation on a NULL clk pointer if the platform has not attacked a clk to the device. Signed-off-by: Arnd Bergmann a...@arndb.de --- Haojian, does this look reasonable to you? arch/arm/mach-mmp/aspenite.c | 5 - arch/arm/mach-mmp/clock-pxa168.c | 2 +- arch/arm/mach

Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-21 Thread Arnd Bergmann
On Thursday 21 March 2013, Jason Cooper wrote: On Thu, Mar 21, 2013 at 06:04:59PM +0100, Soeren Moch wrote: Now I found out what is going on here: In itd_urb_transaction() we allocate 9 iTDs for each URB with number_of_packets == 64 in my case. The iTDs are added to sched-td_list.

[PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
...@prisktech.co.nz Cc: Alexey Charkov alch...@gmail.com Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Arnd Bergmann a...@arndb.de --- Tony, Alexey et al: could one of you test if this works for you? drivers/usb/host/ehci-hcd.c | 5 -- drivers/usb/host/ehci-platform.c | 28

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
On Monday 25 March 2013, Tony Prisk wrote: I'll take a look at this and get back to you before Easter. Great, thanks a lot! Arnd -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
On Monday 25 March 2013, Alan Stern wrote: On Mon, 25 Mar 2013, Felipe Balbi wrote: this ehci_platform_defaults is quite a hack. Would be much better to see a proper re-factoring of the code so that it actually learns about DT and platform_data. So, if dev-dev.platform_data is NULL,

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-25 Thread Arnd Bergmann
On Monday 25 March 2013, Alan Stern wrote: + if (!dev-dev.platform_data) { + dev-dev.platform_data = ehci_platform_defaults; + dev-dev.dma_mask = dev-dev.coherent_dma_mask; + dev-dev.coherent_dma_mask = DMA_BIT_MASK(32); In view of Felipe's

Re: [PATCH] USB: EHCI: DT support for generic bus glue

2013-03-26 Thread Arnd Bergmann
On Tuesday 26 March 2013, Alan Stern wrote: That's up to platform guys. I wasn't aware of any common practice whereby drivers would fill in a missing dma_mask, except in the DT case. I don't think we are consistent in any way. PowerPC sets up a 32 bit DMA mask for all devices during DT

Re: [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol

2013-03-26 Thread Arnd Bergmann
On Tuesday 26 March 2013, Florian Fainelli wrote: Just like the OHCI counter part we just can remove the architecture specific symbols which prevent these configuration symbols from being selected by platforms/architectures requiring it. The original implementation did not scale at all since

[PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
...@prisktech.co.nz Tested-by: Peter Vasil peterva...@gmail.com Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Arnd Bergmann a...@arndb.de --- v3: always set dma_mask and coherent_dma_mask when not already set, rather than overriding them for any device without platform data v2: reset

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
On Wednesday 27 March 2013, Peter Vasil wrote: Hi, unfortunately I still can't apply it on 3.9-rc4 :-( $ git apply --check ehci-dt-bus-glue.patch error: removal patch leaves file contents error: drivers/usb/host/ehci-vt8500.c: patch does not apply Looks git really doesn't like

[PATCH v4] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
...@prisktech.co.nz Tested-by: Peter Vasil peterva...@gmail.com Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Arnd Bergmann a...@arndb.de --- v4: fix the name of the driver in the changelog submit the patch with the full file deletion. v3: always set dma_mask and coherent_dma_mask

Re: [PATCH v3] USB: EHCI: DT support for generic bus glue

2013-03-27 Thread Arnd Bergmann
On Wednesday 27 March 2013, Peter Vasil wrote: Hm, no idea what the latest versions are :-) I use archlinux, with latest updates installed. Here are my git and patch versions: $ git --version git version 1.8.2 $ patch --version GNU patch 2.7.1 Btw. my git understands format-patch -D,

[PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
when it is not needed. Signed-off-by: Arnd Bergmann a...@arndb.de --- diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c index 7562d76..d34b399 100644 --- a/drivers/usb/host/ehci-q.c +++ b/drivers/usb/host/ehci-q.c @@ -1293,9 +1293,8 @@ static void unlink_empty_async(struct ehci_hcd

Re: [PATCH] usb: ehci: mark unlink_empty_async_suspended() as __maybe_unused

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Arnd Bergmann wrote: Patch 4d053fdac3 usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM tried to hide the unlink_empty_async_suspended function inside of an #ifdef to work around an unused function warning. Hi Greg, Apparently the warning is now

[PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-28 Thread Arnd Bergmann
Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Viresh Kumar viresh.li...@gmail.com Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Shiraz Hashim shiraz.has...@st.com Cc: linux-usb@vger.kernel.org Cc: spear-de...@list.st.com

[PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers

2013-03-28 Thread Arnd Bergmann
code size and cleanliness after this patch, not for correctness. While we're here, this fixes the incorrectly sorted error path for the OMAP1 and OMAP3 backends to ensure we always unregister the exact set of drivers that were registered before erroring out. Signed-off-by: Arnd Bergmann

[PATCH v3 5/7] USB: EHCI: make ehci-atmel a separate driver

2013-03-28 Thread Arnd Bergmann
: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig | 8 drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-atmel.c | 85 --- drivers/usb/host/ehci-hcd.c | 6

[PATCH v3 0/7] USB EHCI multiplatform series again

2013-03-28 Thread Arnd Bergmann
, or if we should drop them for now and let you pick them up when you get around to adding multiplatform support for your SoCs. The at91 patch requires USB: EHCI: export ehci_shutdown, which will also be needed for the upcoming Tegra patch. Arnd Arnd Bergmann (2): USB: EHCI: export

[PATCH v3 4/7] USB: EHCI: export ehci_shutdown

2013-03-28 Thread Arnd Bergmann
The ehci_shutdown function is used by the platform specific ehci backends for at91, tegra and ps3. In order to turn any of these into separate modules, we need to make this function globally visible and export it. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan

[PATCH v3 1/7] USB: EHCI: make ehci-orion a separate driver

2013-03-28 Thread Arnd Bergmann
Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Jason Cooper ja...@lakedaemon.net Tested-by: Andrew Lunn and...@lunn.ch Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm-ker

[PATCH v3 3/7] USB: EHCI: make ehci-s5p a separate driver

2013-03-28 Thread Arnd Bergmann
: Kyungmin Park kyungmin.p...@samsung.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com Cc: linux-usb@vger.kernel.org Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig| 5 +- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci

[PATCH v3 6/7] USB: EHCI: make ehci-msm a separate driver

2013-03-28 Thread Arnd Bergmann
.com Cc: Bryan Huntsman bry...@codeaurora.org Cc: Brian Swetland swetl...@google.com Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig| 2 +- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-hcd.c | 6

Re: [PATCH v3 1/7] USB: EHCI: make ehci-orion a separate driver

2013-03-30 Thread Arnd Bergmann
On Friday 29 March 2013, Alan Stern wrote: I don't know about this last phrase. When someone is running make menuconfig, for example, what shows up is the symbol's description, not the symbol's name. That person would see EHCI support for Marvell on-chip controller, not USB_EHCI_MV. In

Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-30 Thread Arnd Bergmann
On Friday 29 March 2013, Alan Stern wrote: On Thu, 28 Mar 2013, Arnd Bergmann wrote: From: Manjunath Goudar manjunath.gou...@linaro.org Separate the SPEAr host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling

Re: [PATCH v3 3/7] USB: EHCI: make ehci-s5p a separate driver

2013-03-30 Thread Arnd Bergmann
On Friday 29 March 2013, Alan Stern wrote: On Thu, 28 Mar 2013, Arnd Bergmann wrote: Personally, I would have left these two functions the way they were and relied on the compiler to inline them when appropriate. Eliminating them just makes the code more complicated. Yes, makes sense

Re: [PATCH v3 5/7] USB: EHCI: make ehci-atmel a separate driver

2013-03-30 Thread Arnd Bergmann
On Friday 29 March 2013, Alan Stern wrote: While not absolutely necessary, it would be nice to have the #include files in alphabetical order. + +#include ehci.h + +#define DRIVER_DESC EHCI atmel driver atmel should have a capital 'A'. Ok, added these changes for v4 along with

Re: [PATCH v3 6/7] USB: EHCI: make ehci-msm a separate driver

2013-03-30 Thread Arnd Bergmann
On Friday 29 March 2013, Alan Stern wrote: On Thu, 28 Mar 2013, Arnd Bergmann wrote: This patch is good. However the ehci-msm driver itself is not. While checking through the code, I was struck by the fact that it never calls usb_add_hcd() or usb_remove_hcd(). Obviously the driver cannot

Re: [PATCH v3 7/7] USB: OHCI: avoid conflicting platform drivers

2013-03-30 Thread Arnd Bergmann
On Friday 29 March 2013, Alan Stern wrote: I have not checked the details of all the changes; however, the basic idea is okay as a stop-gap measure. Ok, thanks. I guess this means the onus is now on me to split up ohci-hcd into a central library and separate bus drivers, like ehci-hcd...

[PATCH v4 1/6] USB: EHCI: make ehci-orion a separate driver

2013-03-30 Thread Arnd Bergmann
ehci_orion_overrides is removed. In V2: Tegra patch related changes removed from this patch. Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Jason Cooper ja...@lakedaemon.net Tested-by: Andrew Lunn and...@lunn.ch Cc: Greg KH g...@kroah.com Cc

[PATCH v4 3/6] USB: EHCI: make ehci-s5p a separate driver

2013-03-30 Thread Arnd Bergmann
: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Kukjin Kim kgene@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com Cc: linux-usb@vger.kernel.org Signed-off-by: Arnd Bergmann

[PATCH v4 5/6] USB: EHCI: make ehci-msm a separate driver

2013-03-30 Thread Arnd Bergmann
.com Cc: Bryan Huntsman bry...@codeaurora.org Cc: Brian Swetland swetl...@google.com Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig| 2 +- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-hcd.c | 6

[PATCH v4 2/6] USB: EHCI: make ehci-spear a separate driver

2013-03-30 Thread Arnd Bergmann
. - to_spear_ehci() macro modified for spear_ehci. In V2: - Replaced spear as SPEAr everywhere, leaving functions/variables/config options. Signed-off-by: Deepak Saxena dsax...@linaro.org Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de

[PATCH v4 0/6] USB EHCI multiplatform conversion

2013-03-30 Thread Arnd Bergmann
Hi Alan, This is a quick update to v3, addressing all issues you pointed in yesterday's review. Thanks for taking a thorough look on short notice on a public holiday! Arnd Arnd Bergmann (1): USB: OHCI: avoid conflicting platform drivers Manjunath Goudar (5): USB: EHCI: make ehci

[PATCH v4 4/6] USB: EHCI: make ehci-atmel a separate driver

2013-03-30 Thread Arnd Bergmann
Victor li...@maxim.org.za Cc: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig | 8 drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci

[PATCH v4 6/6] USB: OHCI: avoid conflicting platform drivers

2013-03-30 Thread Arnd Bergmann
code size and cleanliness after this patch, not for correctness. While we're here, this fixes the incorrectly sorted error path for the OMAP1 and OMAP3 backends to ensure we always unregister the exact set of drivers that were registered before erroring out. Signed-off-by: Arnd Bergmann

Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-31 Thread Arnd Bergmann
On Saturday 30 March 2013, Arnd Bergmann wrote: In V3: -Detailed commit message added here about why this patch is required. -Eliminated ehci_spear_setup routine beacuse hcd registers directly setting in spear_ehci_hcd_drv_probe function. Fix the grammar, please. Done. I

[PATCH V5 5/6] USB: EHCI: make ehci-msm a separate driver

2013-04-02 Thread Arnd Bergmann
-by: David Brown dav...@codeaurora.org Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig| 2 +- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-hcd.c | 6 +-- drivers/usb/host/ehci-msm.c | 89 + 4 files changed, 44

[PATCH V5 0/6] USB: EHCI multiplatform for 3.10

2013-04-02 Thread Arnd Bergmann
was incomplete. Arnd Arnd Bergmann (1): USB: OHCI: avoid conflicting platform drivers Manjunath Goudar (5): USB: EHCI: make ehci-orion a separate driver USB: EHCI: make ehci-spear a separate driver USB: EHCI: make ehci-s5p a separate driver USB: EHCI: make ehci-atmel a separate driver

[PATCH V5 3/6] USB: EHCI: make ehci-s5p a separate driver

2013-04-02 Thread Arnd Bergmann
jg1@samsung.com Acked-by: Alan Stern st...@rowland.harvard.edu Cc: Kukjin Kim kgene@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig| 5 +- drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-hcd.c

[PATCH V5 6/6] USB: OHCI: avoid conflicting platform drivers

2013-04-02 Thread Arnd Bergmann
code size and cleanliness after this patch, not for correctness. While we're here, this fixes the incorrectly sorted error path for the OMAP1 and OMAP3 backends to ensure we always unregister the exact set of drivers that were registered before erroring out. Signed-off-by: Arnd Bergmann

[PATCH V5 2/6] USB: EHCI: make ehci-spear a separate driver

2013-04-02 Thread Arnd Bergmann
. - to_spear_ehci() macro modified for spear_ehci. In V2: - Replaced spear as SPEAr everywhere, leaving functions/variables/config options. Signed-off-by: Deepak Saxena dsax...@linaro.org Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de

[PATCH V5 1/6] USB: EHCI: make ehci-orion a separate driver

2013-04-02 Thread Arnd Bergmann
of ehci_orion_overrides because ehci_orion_overrides is removed. In V2: - Tegra patch related changes removed from this patch. Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Jason Cooper ja...@lakedaemon.net Tested-by: Andrew Lunn

[PATCH V5 4/6] USB: EHCI: make ehci-atmel a separate driver

2013-04-02 Thread Arnd Bergmann
nicolas.fe...@atmel.com Cc: Andrew Victor li...@maxim.org.za Cc: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Signed-off-by: Arnd Bergmann a...@arndb.de --- drivers/usb/host/Kconfig | 8 drivers/usb/host/Makefile | 1 + drivers/usb/host/ehci-atmel.c | 88

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Arnd Bergmann
On Wednesday 03 April 2013, Felipe Balbi wrote: const ? Maybe provide a: #define DEFINE_PHY_OPS(name)\ const struct phy_ops #name_phy_ops = { macro ? This will force people to add the const keyword :-) Forcing people to use const structures is good, but I think it would be better

Re: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block

2013-04-04 Thread Arnd Bergmann
On Thursday 04 April 2013, Felipe Balbi wrote: On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote: diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig index 30ea7ca..0d03a52 100644 --- a/drivers/usb/misc/sisusbvga/Kconfig +++

Re: [PATCH V5 0/6] USB: EHCI multiplatform for 3.10

2013-04-08 Thread Arnd Bergmann
On Monday 08 April 2013, Greg KH wrote: On Tue, Apr 02, 2013 at 06:23:58PM +0200, Arnd Bergmann wrote: Hi Greg, Here are the EHCI patches that I think are good for inclusion in 3.10, I hope you are willing to include them after the debacle over these patches in 3.9. The patches

[PATCH 00/30] ARM: exynos multiplatform support

2013-04-10 Thread Arnd Bergmann
subsystem maintainers: feel free to directly apply the patches for your subsystem, there should be no dependencies between any of them, aside from the last patch requiring all of the earlier ones to be applied first. Getting an Ack is also fine so we can put the patches into arm-soc. Arnd Arnd

[PATCH 10/30] usb: exynos: do not include plat/usb-phy.h

2013-04-10 Thread Arnd Bergmann
The definitions have moved to include/linux/usb/samsung-usb-phy.h, and plat/usb-phy.h is unavailable from drivers in a multiplatform configuration. Also fix up the plat/usb-phy.h header file to use the definitions from the new header instead of providing a separate copy. Signed-off-by: Arnd

[PATCH v3] usb: exynos: do not include plat/usb-phy.h

2013-04-11 Thread Arnd Bergmann
The definitions have moved to include/linux/usb/samsung-usb-phy.h, and plat/usb-phy.h is unavailable from drivers in a multiplatform configuration. Also fix up the plat/usb-phy.h header file to use the definitions from the new header instead of providing a separate copy. Signed-off-by: Arnd

Re: [RFC PATCH 1/2] USB: OHCI: prepare to make ohci-hcd a library module

2013-04-17 Thread Arnd Bergmann
-by: Manjunath Goudar manjunath.gou...@linaro.org Cc: Arnd Bergmann a...@arndb.de Cc: Greg KH g...@kroah.com Cc: Alan Stern st...@rowland.harvard.edu Cc: linux-usb@vger.kernel.org Hi Manjunath, This looks nice I think, but let's see what Alan has to say about it. I did not see any information

Re: [RFC PATCH 2/2] USB: OHCI: make ohci-pci a separate driver

2013-04-17 Thread Arnd Bergmann
On Tuesday 16 April 2013, manjunath.gou...@linaro.org wrote: - /* * On architectures with edge-triggered interrupts we must never return * IRQ_NONE. @@ -585,7 +574,6 @@ int ohci_init(struct ohci_hcd *ohci) return ret; } EXPORT_SYMBOL_GPL(ohci_init); -

Re: [PATCH 0/5] of_platform_driver and OF_DEVICE removal

2013-04-22 Thread Arnd Bergmann
tested on powerpc and sparc. Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

2013-04-23 Thread Arnd Bergmann
On Tuesday 23 April 2013, Lee Jones wrote: +Required properties: + - compatible : Should be stericsson,db8500-musb + - reg: Offset and length of registers + - interrupts : Interrupt; mode, number and trigger + - mode : One of; host, otg, or peripheral I think we don't have any

Re: [PATCH 06/10] usb: musb: ux500: add device tree probing support

2013-04-23 Thread Arnd Bergmann
On Tuesday 23 April 2013, Felipe Balbi wrote: On Tue, Apr 23, 2013 at 05:14:06PM +0200, Arnd Bergmann wrote: On Tuesday 23 April 2013, Lee Jones wrote: +Required properties: + - compatible : Should be stericsson,db8500-musb + - reg: Offset and length of registers

[PATCH] ARM: allmodconfig regressions in linux-next

2013-04-23 Thread Arnd Bergmann
Hi everyone, These are a couple of simple patches to fix bugs that break allyesconfig and that are only present in linux-next at the moment. Please apply to the appropriate trees or provide feedback! Arnd Bergmann (5): mfd: ab8500: remove broken ab8500_debug_register_interrupt logic usb: phy

[PATCH] usb: phy: phy core cannot yet be a module

2013-04-23 Thread Arnd Bergmann
reference to `usb_put_phy' Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-usb@vger.kernel.org --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy

  1   2   3   4   5   6   >