[PATCH] MAINTAINERS: Update maintainer for dwc2

Update to show Minas Harutyunyan as the new maintainer for dwc2. Signed-off-by: John Youn <johny...@synopsys.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 93a12af4f180..fc23eb016198 100644 --- a/MAINTAINERS

DWC2 maintainership change

Hi Felipe, Greg, I won't be able to continue maintainership of dwc2. Minas Harutyunyan, has been doing most of the communication on linux-usb lately and much of the maintenance and development work. He has excellent knowledge of the controller, having worked with it since its inception many

Re: [PATCH 11/11] usb: dwc2: Enable LPM

On 03/09/2018 12:06 AM, Felipe Balbi wrote: Hi, Grigor Tovmasyan <grigor.tovmas...@synopsys.com> writes: From: John Youn <johny...@synopsys.com> Set 'lpm_capable' flag in the gadget structure so indicating that LPM is supported. Signed-off-by: Sevak Arakelyan <sev...@synop

Re: [PATCH 3/7] usb: dwc3: pci: Store device properties dynamically

On 03/01/2018 12:25 AM, Felipe Balbi wrote: Hi, John Youn <john.y...@synopsys.com> writes: On 02/22/2018 07:20 AM, Andy Shevchenko wrote: On Thu, Feb 22, 2018 at 1:57 AM, Thinh Nguyen <thinh.ngu...@synopsys.com> wrote: On 2/21/2018 6:46 AM, Andy Shevchenko wrote: On Tue, Feb 20

Re: [PATCH 3/7] usb: dwc3: pci: Store device properties dynamically

On 02/22/2018 07:20 AM, Andy Shevchenko wrote: On Thu, Feb 22, 2018 at 1:57 AM, Thinh Nguyen wrote: On 2/21/2018 6:46 AM, Andy Shevchenko wrote: On Tue, Feb 20, 2018 at 11:12 PM, Thinh Nguyen wrote: On 2/17/2018 7:29 AM, Andy Shevchenko

Re: [PATCH 00/17] usb: dwc2: improvements

-- drivers/usb/dwc2/hcd.c| 136 +- drivers/usb/dwc2/hcd.h| 56 --- drivers/usb/dwc2/params.c | 2 +- drivers/usb/dwc2/pci.c| 27 + 7 files changed, 189 insertions(+), 293 deletions(-) For this

Re: [PATCH 0/6] usb: dwc2: minor fixes

drivers/usb/dwc2/hw.h | 1 + drivers/usb/dwc2/params.c | 23 ++--- drivers/usb/dwc2/platform.c | 11 ++-- 7 files changed, 61 insertions(+), 87 deletions(-) For this series: Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscribe from this lis

Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values

hs_ep->frame_overrun = 0; + hs_ep->frame_overrun = false; } } +Felipe Acked-by: John Youn <johny...@synopsys.com> Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to m

Re: [PATCH] usb: dwc2: add optional usb ecc reset bit

ce *dev) > dwc2_lowlevel_hw_disable(hsotg); > > reset_control_assert(hsotg->reset); > + reset_control_assert(hsotg->reset_ecc); > > return 0; > } > Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: dwc2: Fix TxFIFOn sizes and total TxFIFO size issues

HWCFG4_NUM_DEV_PERIO_IN_EP_SHIFT; > + hw->num_dev_in_eps = (hwcfg4 & GHWCFG4_NUM_IN_EPS_MASK) >> > + GHWCFG4_NUM_IN_EPS_SHIFT; > hw->dma_desc_enable = !!(hwcfg4 & GHWCFG4_DESC_DMA); > hw->power_optimized = !!(hwcfg4 & GHWCFG4_POWER_OPTIMIZ); >

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

- Sent to Felipe Balbi as candiate to land this. >> - Add Cc for stable (it's always been broken so go as far is as easy) >> >> Changes in v2: >> - Address >> https://urldefense.proofpoint.com/v2/url?u=http-3A__crosreview.com_737520=DwICaQ=DPL6_X_6JkXFx7AXWqB0tg=U3o8uKoKhWme5_V9D-eeCkB11BFwt4KvWztBgd

Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS

ice_id dwc2_of_match_table[] = { >> { .compatible = "st,stm32f4x9-fsotg", >>.data = dwc2_set_stm32f4x9_fsotg_params }, >> { .compatible = "st,stm32f4x9-hsotg" }, >> +{ .compatible = "st,stm32f7-hsotg", >> +

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

get some feedback on the patches and consideration > to be merged upstream. > > thanks > -john > > Cc: Wei Xu <xuw...@hisilicon.com> > Cc: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: YongQin Liu <yongqin@linaro.org

Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero

->regs + DCFG, DCFG_DEVADDR_MASK); > + > if (usb_status & GOTGCTL_BSESVLD && connected) > dwc2_hsotg_core_init_disconnected(hsotg, true); > } > Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscribe from th

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

On 6/21/2017 3:38 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: > > > >>>> I haven't checked, but Thinh looked and couldn't find anything >>>> relating to the macOS issue. Which is why we want more information

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

On 6/13/2017 3:31 PM, Paul Zimmerman wrote: > On Tue, 13 Jun 2017 21:57:42 +0000, John Youn <john.y...@synopsys.com> wrote: > >> On 6/13/2017 2:39 PM, Paul Zimmerman wrote: >>> On Tue, 13 Jun 2017 18:33:09 +, John Youn <john.y...@synopsys.com> >>> wro

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

On 6/13/2017 2:39 PM, Paul Zimmerman wrote: > On Tue, 13 Jun 2017 18:33:09 +0000, John Youn <john.y...@synopsys.com> wrote: > >> On 6/13/2017 12:32 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Thinh Nguyen <thinh.ngu...@synopsys.com>

Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt

On 6/13/2017 12:32 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: this could be, I don't remember if I checked this or not :-) Really, the best way here, IMHO, would be to re-verify what's going on

Re: [PATCH] usb: dwc2: add support for the DWC2 controller on Meson8 SoCs

;, .data = dwc2_set_ltq_params }, >> { .compatible = "snps,dwc2" }, >> { .compatible = "samsung,s3c6400-hsotg" }, >> + { .compatible = "amlogic,meson8-usb", >> + .data = dwc2_set_amlogic_params }, >> { .compatible = "amlogic,meson8b-usb", >> .data = dwc2_set_amlogic_params }, >> { .compatible = "amlogic,meson-gxbb-usb", >> -- >> 2.12.2 >> > Adding Felipe Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/18/2017 05:47 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >>> (Thinh, for whatever I didn't receive your email via the list, replying >>> to myself) >> >> Could it be because of the attached file? >> >>> >>> Felipe Balbi writes:

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/11/2017 11:14 PM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>>> John Youn <john.y...@synopsys.com> writes: >>>>>> Thinh Nguyen <thinh.ngu...@synopsys.com> writes: >>>>>>> The

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/11/2017 09:31 AM, John Youn wrote: > On 04/11/2017 12:45 AM, Felipe Balbi wrote: >> >> Hi, >> >> John Youn <john.y...@synopsys.com> writes: >>>> Thinh Nguyen <thinh.ngu...@synopsys.com> writes: >>>>> The dwc3 driver can o

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/11/2017 12:45 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>> Thinh Nguyen <thinh.ngu...@synopsys.com> writes: >>>> The dwc3 driver can overwite its previous events if its top half IRQ >>>>

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/10/2017 11:58 PM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>>> Yes it will re-assert. The interrupt line will remain asserted as long >>>> events remain in the buffer and it is not masked. So when we >>>&g

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/10/2017 11:17 PM, Janusz Dziedzic wrote: > On 10 April 2017 at 20:43, John Youn <john.y...@synopsys.com> wrote: >> On 04/08/2017 12:38 PM, Janusz Dziedzic wrote: >>> 2017-04-08 1:57 GMT+02:00 Thinh Nguyen <thinh.ngu...@synopsys.com>: >>>> The dw

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/09/2017 11:59 PM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> The dwc3 driver can overwite its previous events if its top half IRQ >> handler gets invoked again before processing the events in the cache. We > > interrupts are masked, why would top half

Re: [PATCH 1/3] usb: dwc3: gadget: Prevent losing events in event cache

On 04/08/2017 12:38 PM, Janusz Dziedzic wrote: > 2017-04-08 1:57 GMT+02:00 Thinh Nguyen : >> The dwc3 driver can overwite its previous events if its top half IRQ >> handler gets invoked again before processing the events in the cache. We >> see this as a hang in the file

Re: [PATCH] usb: dwc3: gadget: skip Set/Clear Halt when invalid

On 04/04/2017 01:09 AM, Felipe Balbi wrote: > > Hi John, > > Felipe Balbi writes: >> At least macOS seems to be sending >> ClearFeature(ENDPOINT_HALT) to endpoints which >> aren't Halted. This makes DWC3's CLEARSTALL command >> time out which causes several issues

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

On 03/30/2017 02:27 AM, Felipe Balbi wrote: > > Hi > > Roger Quadros writes: > For something that simple, we wouldn't even need to use OTG FSM layer > because that brings no benefit for such a simple requirement. no no. I think you got it wrong. I'm not using the

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On 03/31/2017 04:04 PM, John Stultz wrote: > On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: >> Hey John, >> We've noticed that when using usb ethernet adapters on HiKey, we >> occasionally see errors like: >> >> dwc2 f72c.usb: dwc2_hc_chhltd_intr_dma: Channel 0

Re: [PATCH v2] usb: dwc2: Make sure we disconnect the gadget state

Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...@synopsys.com> > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Chen Yu <cheny...@huawei.com> >

Re: bug? dwc2: insufficient fifo memory

+linux-usb On 2/24/2017 2:46 PM, John Stultz wrote: > Hey John, > So after the USB tree landed in 4.11-rc, I've been seeing the > following warning at bootup. > > It seems the fifo_mem/total_fifo_size value on hikey is 1920, but I'm > seeing the addresses zip upward quickly as the txfsz values

Re: [RESEND PATCH v2 0/2] add multiple clock handling for dwc2 driver

On 2/21/2017 5:30 PM, Frank Wang wrote: > Hi John and Greg, > > Friendly ping... :-) > Hi Frank, We'll take a look at this and get back to you soon. Regards, John > On 2017/2/10 11:06, Frank Wang wrote: >> Resend this series to involve device tree maintainer and add 'Reviewed-by' >> tag for

Re: [PATCH 15/15] usb: dwc2: Replace msleep with mdelay in dwc2_clear_force_mode()

On 2/21/2017 5:16 AM, David Laight wrote: > From: Vardan Mikayelyan >> Sent: 20 February 2017 15:15 >> dwc2_clear_force_mode() can be called in hibernation exit flow which >> can occur in interrupt context. >> >> Signed-off-by: Vardan Mikayelyan >> --- >>

Re: [RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state

reatly appreciated! > It looks good to me. Acked-by: John Youn <johny...@synopsys.com> Regards, John > thanks > -john > > > I had seen some odd behavior with HiKey's usb-gadget interface > that I finally seemed to have chased down. Basically every other > time I pl

Re: [RESEND PATCH 1/1] usb: dwc2: add multiple clock handling

On 2/6/2017 7:18 PM, Frank Wang wrote: > Hi Heiko, John and Greg, > > On 2017/2/7 8:06, Heiko Stuebner wrote: >> Hi Frank, >> >> Am Sonntag, 5. Februar 2017, 10:51:01 CET schrieb Frank Wang: >>> Originally, dwc2 just handle one clock named otg, however, it may have >>> two or more clock need to

Re: [PATCH v5 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

gned-off-by: Bruno Herrera <bruherr...@gmail.com> Acked-by: John Youn <johny...@synopsys.com> Regards, John > --- > drivers/usb/dwc2/core.h | 5 + > drivers/usb/dwc2/hcd.c| 15 ++- > drivers/usb/dwc2/hw.h | 2 ++ > drivers/usb/dwc2/params.

Re: [PATCH v4 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

On 1/28/2017 6:21 PM, Bruno Herrera wrote: > This patch introduces a new parameter to activate USB OTG HS/FS core embedded > phy transceiver. The STM32F4x9 SoC uses the GGPIO register to enable the > transceiver. > Also add the dwc2_core_params structure for stm32f4 otg fs. > > Signed-off-by:

Re: [PATCH] usb: dwc2: remove deprecated comment in definition of struct dwc2_core_params

On 1/31/2017 10:55 AM, John Youn wrote: > On 1/28/2017 1:42 PM, Heiner Kallweit wrote: >> Since commit 0a7d0d7fa820 "usb: dwc2: Remove dwc2_set_all_params function" >> this comment isn't applicable any longer. >> >> Signed-off-by: Heiner Kallweit <hkallwe..

Re: [PATCH] usb: dwc2: remove deprecated comment in definition of struct dwc2_core_params

default described above. > */ > struct dwc2_core_params { > - /* > - * Don't add any non-int members here, this will break > - * dwc2_set_all_params! > - */ > int otg_cap; > #define DWC2_CAP_PARAM_HNP_SRP_CAPABLE 0 > #define DWC2_CAP_PARAM

Re: [PATCH] usb: dwc2: introduce config parameter to ignore supplies vusb_a and vusb_d

On 1/30/2017 11:13 PM, Heiner Kallweit wrote: > Am 31.01.2017 um 03:32 schrieb John Youn: >> On 1/28/2017 2:06 PM, Heiner Kallweit wrote: >>> Supplies for vusb_a and vusb_d are needed only on a minority of systems >>> supported by the dwc2 driver (AFAIK systems with Sa

Re: [PATCH v4 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

On 1/28/2017 6:21 PM, Bruno Herrera wrote: > This patch introduces a new parameter to activate USB OTG HS/FS core embedded > phy transceiver. The STM32F4x9 SoC uses the GGPIO register to enable the > transceiver. > Also add the dwc2_core_params structure for stm32f4 otg fs. > Could you fix the

Re: [PATCH] usb: dwc2: introduce config parameter to ignore supplies vusb_a and vusb_d

On 1/28/2017 2:06 PM, Heiner Kallweit wrote: > Supplies for vusb_a and vusb_d are needed only on a minority of systems > supported by the dwc2 driver (AFAIK systems with Samsung SoCs). > > On all other systems this results in these harmless but annoying > warnings: > > c900.usb supply vusb_d

Re: XHCI regression on v4.10-rc1

On 1/27/2017 6:53 AM, Felipe Balbi wrote: > > Hi, > > Patrice CHOTARD writes: I am working on ARM STi platform, since v4.10-rc1, when booting B2260 or B2120 STi boards platform with nothing plugged on USB3 connector, i observed the

[PATCH] usb: dwc3: gadget: Fix starting microframe for ISOC

Fix so that it always adds just one interval or at least 4 microframes. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc3/gadget.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 4db97ecae885..

Re: [GIT PULL] USB for v4.11

On 1/26/2017 6:40 AM, Greg Kroah-Hartman wrote: > On Thu, Jan 26, 2017 at 04:23:00PM +0200, Felipe Balbi wrote: >> >> Hi Greg, >> >> here's my pull request for v4.11. Patches tested with Intel Joule, SKL >> and KBL. >> >> Let me know if you want anything to be changed. >> >> cheers >> >> The

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/24/2017 3:14 PM, Bryan O'Donoghue wrote: > > > On 24/01/17 19:25, John Youn wrote: >> On 1/24/2017 3:05 AM, Bryan O'Donoghue wrote: >>> On 23/01/17 22:34, John Youn wrote: >>>> On 1/23/2017 2:10 PM, Alan Stern wrote: >>>>> On Mon, 23 Jan 20

Re: [PATCH v2] usb: dwc2: fix "iomem 0x00000000" message

g, int irq) > > hcd->has_tt = 1; > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + hcd->rsrc_start = res->start; > + hcd->rsrc_len = resource_size(res); > + > ((struct wrapper_priv_data *)>hcd_priv)->hsotg = hsotg; >

Re: [PATCH] usb: dwc2: eliminate irq parameter from dwc2_hcd_init

wc2/platform.c > @@ -445,7 +445,7 @@ static int dwc2_driver_probe(struct platform_device *dev) > } > > if (hsotg->dr_mode != USB_DR_MODE_PERIPHERAL) { > - retval = dwc2_hcd_init(hsotg, hsotg->irq); > + retval = dwc2_hcd_init(hsotg); > i

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

On 1/15/2017 12:37 PM, Heiner Kallweit wrote: > Set the iomem parameters in the usb_hcd to fix this misleading > message during driver load: > dwc2 c910.usb: irq 22, io mem 0x > > Signed-off-by: Heiner Kallweit > --- > drivers/usb/dwc2/core.h | 3 ++- >

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

On 1/25/2017 12:37 PM, Heiner Kallweit wrote: > Am 24.01.2017 um 09:46 schrieb Felipe Balbi: >> >> Hi, >> >> John Youn <john.y...@synopsys.com> writes: >>>> John Youn <john.y...@synopsys.com> writes: >>>>>>>>> @@ -1229

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/24/2017 11:39 AM, Felipe Balbi wrote: > Hi, > > (sorry if formatting sucks, using web interface) > > On Tue, Jan 24, 2017 at 9:21 PM John Youn <john.y...@synopsys.com > <mailto:john.y...@synopsys.com>> wrote: > > On 1/24/2017 12:53 AM, Fe

Re: [PATCH v3 00/24] usb: dwc2: Rework params, FIFO, and other changes

On 1/23/2017 2:52 PM, John Youn wrote: > Hi Felipe, > > This is a consolidation, rebase, and resend of several dwc2 patch > series that were submitted to this list in the past month or so. See > v2 [1] of this series for a summary. > > This latest revision is rebased to

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/24/2017 3:05 AM, Bryan O'Donoghue wrote: > On 23/01/17 22:34, John Youn wrote: >> On 1/23/2017 2:10 PM, Alan Stern wrote: >>> On Mon, 23 Jan 2017, John Youn wrote: >>> >>>> On 1/22/2017 5:29 PM, Bryan O'Donoghue wrote: >>>>> - D

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/24/2017 12:53 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>>> Bryan O'Donoghue <pure.lo...@nexus-software.ie> writes: >>>>> - DWC_USB3_NUM indicates the number of Device mode single directional

Re: [PATCH v3 24/24] usb: dwc2: gadget: Add checking for g-tx-fifo-size parameter

On 1/24/2017 10:40 AM, Stefan Wahren wrote: > Hi John, > > could you please push this series to the github synopsys-usb repo? > > I didn't have the chance to test combination of your last series. > > Stefan > Updated. Regards, John -- To unsubscribe from this list: send the line "unsubscribe

[PATCH v3 24/24] usb: dwc2: gadget: Add checking for g-tx-fifo-size parameter

..@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 016fff0cb887..2990c347289f 100644 --- a/drivers

[PATCH v3 22/24] usb: dwc2: host: Correct snpsid checking for GDFIFOCFG

From: Sevak Arakelyan <sev...@synopsys.com> GDFIFOCFG is available from IP version 2.91a. Fix the code to reflect this. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2

[PATCH v3 23/24] usb: dwc2: gadget: Set TX FIFO depths to calculated defaults

ration mode and device operation mode are taken into consideration during the calculation. Cc: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 16 ++

[PATCH v3 21/24] usb: dwc2: host: use msleep() for long delay

g/lkml/2017/1/11/377 Fixes: commit 2938fc63e0c2 ("usb: dwc2: Properly account for the force mode delays") Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 19/24] usb: dwc2: Force port resume on switching to device mode

Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com

[PATCH v3 20/24] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

op the usb speed when low/full-speed are attached, and bump back to high speed when they are removed. Cc: Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny..

[PATCH v3 18/24] usb: dwc2: Workaround case where GOTGCTL state is wrong

is isn't the best solution, but it seems to work well for me. Feedback would be greatly appreciated! Cc: Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny...@syno

[PATCH v3 17/24] usb: dwc2: Avoid sleeping while holding hsotg->lock

_range() while the hstog->lock spinlock is held, since we take that before calling dwc2_hsotg_core_init_disconnected(). This patch avoids the issue by adding an extra argument to dwc2_core_reset(), as suggested by John Youn, which allows us to skip the waiting, which should be unnecessary when cal

[PATCH v3 12/24] usb: dwc2: Fix usage of bool params

Check these parameters only for true or false. There is no need to check for greater or less than 0. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 4 +- drivers/usb/dwc2/core.h | 5 -- drivers/usb/dwc2/core_intr.c | 2 +- drivers/usb/dwc2/ga

[PATCH v3 16/24] usb: dwc2: Show dr_mode via debugfs

Show the value of dr_mode via a debufs file. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debugfs.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index 57747b0df595..794b95

[PATCH v3 15/24] usb: dwc2: Remove debug prints in params.c

Remove debugging prints to show params. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 56 --- 1 file changed, 56 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 0e7f0f

[PATCH v3 14/24] usb: dwc2: Add debugfs file to show params

Show the core params and hardware params. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debugfs.c | 127 + 1 file changed, 127 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c

[PATCH v3 13/24] usb: dwc2: Remove unnecessary parameters

Further reduce the set of parameters set by platforms. Many of them are unnecessary as they should be reported by hardware. They should only need to be overridden if there is a problem. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 11 ---

[PATCH v3 11/24] usb: dwc2: Remove platform static params

Remove the platform-specific static param structs and set only those params that are necessary for each platform. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 262 +++--- 1 file changed, 108 insertions(+), 154 del

[PATCH v3 09/24] usb: dwc2: Rearrange param structure members

Group the members by global, host, and gadget params. Formatting and organizational change only. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 51 ++--- 1 file changed, 23 insertions(+), 28 deletions(-) diff

[PATCH v3 10/24] usb: dwc2: Check core parameters

Check that core parameters have valid values and adjust them if they aren't. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 185 ++ 1 file changed, 185 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/d

[PATCH v3 07/24] usb: dwc2: Get device properties

After setting the default core parameter values, read in the device properties and modify core parameter values if needed. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH v3 08/24] usb: dwc2: Update parameter types

Update the param types to appropriately sized ints and bools. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/usb/dwc2/core.h b/drive

[PATCH v3 06/24] usb: dwc2: Set core parameters to default values

ter commit. This allows us to change only those parameters that won't work with default settings. It also allows us to use non-int parameters. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 4 - drivers/usb/dwc2/params.c | 990 ---

[PATCH v3 04/24] Revert "usb: dwc2: pci: Add AHB burst property for HAPS"

This reverts commit e0beae49474c ("usb: dwc2: pci: Add AHB burst property for HAPS"). This commit was inadvertently applied. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/pci.c b/

[PATCH v3 05/24] usb: dwc2: Remove unused otg_ver parameter

The otg_ver parameter only controls the SRP pulsing method and defaults to the 1.3 behavior. It is unused and can be removed. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 5 - drivers/usb/dwc2/core.h | 9 - drivers/usb/dwc2/hcd.c

[PATCH v3 03/24] Revert "usb: dwc2: Use the ahb_burst param"

This reverts commit 70033c5ec15b ("usb: dwc2: Use the ahb_burst param"). This commit was inadvertently applied. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 2 +- drivers/usb/dwc2/hcd.c| 8 +--- drivers/usb/dwc2/params.c | 10 +++

[PATCH v3 00/24] usb: dwc2: Rework params, FIFO, and other changes

): usb: dwc2: Force port resume on switching to device mode usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220 John Stultz (2): usb: dwc2: Avoid sleeping while holding hsotg->lock usb: dwc2: Workaround case where GOTGCTL state is wrong John Youn (16): Rev

[PATCH v3 02/24] Revert "usb: dwc2: Read in the AHB burst property"

This reverts commit 605f91f9f5a6 ("usb: dwc2: Read in the AHB burst property"). This commit was inadvertently applied. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 9 --- drivers/usb/dwc2/params.c | 69 --

[PATCH v3 01/24] Revert "Documentation: devictree: dwc2: Add AHB burst binding"

This reverts commit d067dad79548 ("Documentation: devictree: dwc2: Add AHB burst binding"). This commit was inadvertently applied. Signed-off-by: John Youn <johny...@synopsys.com> --- Documentation/devicetree/bindings/usb/dwc2.txt | 2 -- 1 file changed, 2 deletion

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/23/2017 2:10 PM, Alan Stern wrote: > On Mon, 23 Jan 2017, John Youn wrote: > >> On 1/22/2017 5:29 PM, Bryan O'Donoghue wrote: >>> - DWC_USB3_NUM indicates the number of Device mode single directional >>> endpoints, including OUT and IN endpoint 0. >>&

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/22/2017 5:29 PM, Bryan O'Donoghue wrote: > - DWC_USB3_NUM indicates the number of Device mode single directional > endpoints, including OUT and IN endpoint 0. > > - DWC_USB3_NUM_IN_EPS indicates the maximum number of Device mode IN > endpoints active at any time, including control

Re: [PATCH v2] usb: dwc3: handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/23/2017 5:34 AM, Bryan O'Donoghue wrote: > On 23/01/17 12:08, Felipe Balbi wrote: >> >> Hi, >> >> Bryan O'Donoghue writes: >>> - DWC_USB3_NUM indicates the number of Device mode single directional >>> endpoints, including OUT and IN endpoint 0. >>> >>> -

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

On 1/23/2017 3:50 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>>>>> @@ -1229,7 +1229,8 @@ static inline void dwc2_hcd_connect(struct >>>>>> dwc2_hsotg *hsotg) {} >>>>>> static inli

Re: [PATCH v2 10/28] usb: dwc2: Remove unused otg_ver parameter

On 1/23/2017 3:41 AM, Felipe Balbi wrote: > John Youn <john.y...@synopsys.com> writes: > >> The otg_ver parameter only controls the SRP pulsing method and defaults >> to the 1.3 behavior. It is unused and can be removed. >> >> Signed-off-by: John Youn <john

Re: [PATCH v3 1/5] usb: dwc2: Add support for STM32F429/439/469 USB OTG HS/FS in FS mode (internal PHY)

On 1/17/2017 8:13 AM, Bruno Herrera wrote: > This patch introduces a new parameter to activate USB OTG HS/FS core embedded > phy transceiver. The STM32F4x9 SoC uses the GGPIO register to enable the > transceiver. > Also add the dwc2_core_params structure for stm32f4 otg fs. > > Signed-off-by:

Re: [PATCH] usb: dwc3: add quirk to handle DWC_USB3_NUM == DWC_USB3_NUM_IN_EPS

On 1/19/2017 12:17 PM, Felipe Balbi wrote: > > Hi, > > Bryan O'Donoghue writes: >> - DWC_USB3_NUM indicates the number of Device mode single directional >> endpoints, including OUT and IN endpoint 0. >> >> - DWC_USB3_NUM_IN_EPS indicates the maximum number of

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/18/2017 7:12 PM, Baolin Wang wrote: > Hi John, > > On 19 January 2017 at 09:33, John Youn <john.y...@synopsys.com> wrote: >> On 1/16/2017 2:38 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> John Youn <john.y...@synopsys.co

[PATCH 4/4] usb: dwc2: gadget: Add checking for g-tx-fifo-size parameter

..@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 016fff0cb887..2990c347289f 100644 --- a/drivers

[PATCH 3/4] usb: dwc2: gadget: Set TX FIFO depths to calculated defaults

ration mode and device operation mode are taken into consideration during the calculation. Cc: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 16 ++

[PATCH 1/4] usb: dwc2: gadget: Set GDFIFOCFG

From: Sevak Arakelyan <sev...@synopsys.com> Add programming of GDFIFOCFG register in device mode. It must contain start address for EP Info block and total FIFO depth. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> ---

[PATCH 0/4] usb: dwc2: FIFO configuration

This series addresses a couple of FIFO issues in dwc2. The first it properly configures the GDIFIFOCFG registers in host/gadget mode. Next it configures the TX FIFOs to default values in gadget mode. These values should work for all cores. The old constant values were incorrect in some cases

[PATCH 2/4] usb: dwc2: host: Correct snpsid checking for GDFIFOCFG

From: Sevak Arakelyan <sev...@synopsys.com> GDFIFOCFG is available from IP version 2.91a. Fix the code to reflect this. Signed-off-by: Sevak Arakelyan <sev...@synopsys.com> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/16/2017 2:38 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>> Baolin Wang <baolin.w...@linaro.org> writes: >>>>> Baolin Wang <baolin.w...@linaro.org> writes: >>>>>> When dwc3 controll

Re: [PATCH] usb: dwc2: remove dead function dwc2_pci_quirks

On 1/17/2017 12:51 PM, Heiner Kallweit wrote: > Commit 9962b62f1be9 "Deprecate g-use-dma binding" removed the only > property in dwc2_pci_quirks. This function is dead code now. > > Maybe it was kept intentionally to be prepared for the case that > another quirk-related property needs to be added

Re: [PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

On 1/17/2017 10:58 PM, Stefan Wahren wrote: > Hi John, > > is there a public git repo where this series is already applied? > > Stefan > Hi Stefan, Yes, here: https://github.com/synopsys-usb/linux.git I know you're still waiting for the FIFO stuff. We'll send out a first version of that

[PATCH v2 22/28] usb: dwc2: Avoid sleeping while holding hsotg->lock

_range() while the hstog->lock spinlock is held, since we take that before calling dwc2_hsotg_core_init_disconnected(). This patch avoids the issue by adding an extra argument to dwc2_core_reset(), as suggested by John Youn, which allows us to skip the waiting, which should be unnecessary when cal

[PATCH v2 00/28] usb: dwc2: Rework params, checkpatch, and other changes

o apply this series cleanly. Regards, John Chen Yu (2): usb: dwc2: Force port resume on switching to device mode usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220 John Stultz (2): usb: dwc2: Avoid sleeping while holding hsotg->lock usb: dwc2: Workaround cas

[PATCH v2 05/28] usb: dwc2: Fix brace usage

* Remove braces for one-line statements * Add missing braces where another arm in if-statement uses braces Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 10 -- drivers/usb/dwc2/platform.c | 12 ++-- 2 files changed, 10 insertions(

  1   2   3   4   5   6   7   8   9   10   >