RE: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

> On 04.12.18 21:01, Fabio Estevam wrote: > > Hi Frieder, > > > > On Tue, Dec 4, 2018 at 12:31 PM Schrempf Frieder > > wrote: > > > >> There are many other optional properties for this driver and a lot of > >> them are not in the given example. Maybe we should just keep the > >> pinctrls for

RE: [PATCH v2 2/3] usb: chipidea: imx: Warn if oc polarity isn't specified

> Signed-off-by: Uwe Kleine-König > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > b/drivers/usb/chipidea/ci_hdrc_imx.c > index 80b4e4ef9b68..3dcfd0d97f94 100644 > ---

RE: [PATCH 1/1] usb: chipidea: imx: improve the over current handling

> > On Mon, Dec 03, 2018 at 03:13:01AM +, PETER CHEN wrote: > > The current OC (Over Current) handling does not consider the default > > and bootloader OC setting well, in this commit, we reset OC setting > > according to dts value: > > - If property &qu

[PATCH 1/1] usb: chipidea: imx: improve the over current handling

er control chips are low active for OC, we keep "over-current-active-high" property unchanging to reduce users effort. If this property is set, we set OC polarity as high explicitly; otherwise, we set it as low explicitly. Cc: stable Cc: Peter Chen Cc: Uwe Kleine-König Cc: Matth

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

> > > -Original Message- > > From: Matthew Starr > > Sent: 2018年11月30日 23:09 > > To: PETER CHEN ; linux-usb@vger.kernel.org; Jun Li > > > > Subject: RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low > > > > > -Origin

RE: [PATCH] usb: chipidea: imx: Allow OC polarity active low

> > The implementation for setting the over current polarity has always been the > over- > current-active-high property. The problem with this is there is no way to > enable > over current active low polarity since the default state of the register bit > that controls > the over current

RE: [PATCH v3 3/4] usb: chipidea: host: override ehci->hub_control

> On 27.11.18 10:30, PETER CHEN wrote: > > The chipidea controller has some special requirements during > > suspend/resume, override common ehci->hub_control to implement it. > > > > Signed-off-by: Peter Chen > > Tested on i.MX6S with Microchip LAN9730 US

RE: [PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

> > On Tue, Nov 27, 2018 at 7:31 AM PETER CHEN wrote: > > > > For USB HSIC, the data and strobe pin needs to be pulled down at > > default, we consider it as "idle" state. When the USB host is ready to > > be used, the strobe pin needs to be pulled

[PATCH v3 1/4] usb: chipidea: add flag for imx hsic implementation

NXP (Freecale) imx HSIC design has some special requirements, add some flags at host code to handle them. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 17 + include/linux/usb/chipidea.h | 3 +++ 2 files changed, 20 insertions(+) diff --git a/drivers/usb

[PATCH v3 2/4] usb: chipidea: imx: add HSIC support

is needed Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 140 - drivers/usb/chipidea/ci_hdrc_imx.h | 9 ++- drivers/usb/chipidea/usbmisc_imx.c | 140 + 3 files changed, 270 insertions(+), 19 deletions

[PATCH v3 0/4] usb: chipidea: imx: add HSIC support

[Patch 2/4] - Comment from Frieder Schrempf about code structure [Patch 2/4] - Comment from Fabio about adding example for pinctrl [Patch 4/4] Peter Chen (4): usb: chipidea: add flag for imx hsic implementation usb: chipidea: imx: add HSIC support usb: chipidea: host: override ehci->hub_cont

[PATCH v3 3/4] usb: chipidea: host: override ehci->hub_control

The chipidea controller has some special requirements during suspend/resume, override common ehci->hub_control to implement it. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 76 + 1 file changed, 76 insertions(+) diff --git a/driv

[PATCH v3 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

For USB HSIC, the data and strobe pin needs to be pulled down at default, we consider it as "idle" state. When the USB host is ready to be used, the strobe pin needs to be pulled up, we consider it as "active" state. Signed-off-by: Peter Chen --- Documentation/devicetree/

RE: [PATCH v2 0/4] usb: chipidea: imx: add HSIC support

> > > > On 23.10.18 08:33, Peter Chen wrote: > >>> As I already posted when I was testing v1 last week, there is a > >>> problem with auto suspend with my LAN9730 chip. I thought it was a > >>> problem with the smsc95xx/usbnet driver, but I'm no

RE: [PATCH v2 2/4] usb: chipidea: imx: add HSIC support

> > + } > > + > > + if (data->hsic_pad_regulator) { > > + ret = regulator_enable(data->hsic_pad_regulator); > > + if (ret) { > > + dev_err(dev, > > + "Fail to enable HSIC pad

RE: [PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation

> > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c > > index d858a82c4f44..d74a13d7c21c 100644 > > --- a/drivers/usb/chipidea/host.c > > +++ b/drivers/usb/chipidea/host.c > > @@ -28,6 +28,20 @@ struct ehci_ci_priv { > > struct regulator *reg_vbus; > > }; > > > > +/*

RE: [PATCH v2 0/4] usb: chipidea: imx: add HSIC support

> As I already posted when I was testing v1 last week, there is a problem with > auto > suspend with my LAN9730 chip. I thought it was a problem with the > smsc95xx/usbnet driver, but I'm not so sure anymore. > > So I'd like to figure out if it has something to do with the HSIC patches. I >

RE: [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

> On Mon, Oct 22, 2018 at 11:55 AM Schrempf Frieder > wrote: > > > I think you forgot to improve this description. Maybe something like this: > > > > pinctrl-names: Names for optional pin modes for "default", "host" or > > "device". In case of HSIC-mode "idle" and "active" pin

[PATCH v2 2/4] usb: chipidea: imx: add HSIC support

is needed Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 140 - drivers/usb/chipidea/ci_hdrc_imx.h | 9 ++- drivers/usb/chipidea/usbmisc_imx.c | 130 ++ 3 files changed, 260 insertions(+), 19 deletions(-) diff

[PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

For USB HSIC, the data and strobe pin needs to be pulled down at default, we consider it as "idle" state. When the USB host is ready to be used, the strobe pin needs to be pulled up, we consider it as "active" state. Signed-off-by: Peter Chen --- Documentation/devicetree/

[PATCH v2 1/4] usb: chipidea: add flag for imx hsic implementation

NXP (Freecale) imx HSIC design has some special requirements, add some flags at host code to handle them. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 24 include/linux/usb/chipidea.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/usb

[PATCH v2 3/4] usb: chipidea: host: override ehci->hub_control

The chipidea controller has some special requirements during suspend/resume, override common ehci->hub_control to implement it. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 74 + 1 file changed, 74 insertions(+) diff --git a/driv

[PATCH v2 0/4] usb: chipidea: imx: add HSIC support

adding example for pinctrl [Patch 4/4] Peter Chen (4): usb: chipidea: add flag for imx hsic implementation usb: chipidea: imx: add HSIC support usb: chipidea: host: override ehci->hub_control doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups .../devicetree/bindings/

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

> >> My board is currently off-tree so I can't send any patch for the > >> pinmux settings in devicetree. But I will send a patch with the > >> changes that should go to imx6qdl.dtsi, imx6sl.dtsi and imx6sx.dtsi. > >> Though I > only tested on i.MX6S. > >> > > > > No, the changes are board

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

> > > > Thanks, Frieder, no more tests are needed. > > You could send me your dts changes as patches, I will append it at my v2 > > patch > series. > > My board is currently off-tree so I can't send any patch for the pinmux > settings in > devicetree. But I will send a patch with the changes

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

> >>> - System suspend/resume > >>> 1. Enable USB wakeup > >>> for i in $(find /sys -name wakeup | grep usb);do echo enabled  > > >>> $i;echo "echo enabled > $i";done; 2. Let the system enter suspend > >>> using below command echo mem > /sys/power/state 3. And see if there > >>> is a wakeup

RE: [PATCH 2/4] usb: chipidea: imx: add HSIC support

> > +static int ci_hdrc_imx_notify_event(struct ci_hdrc *ci, unsigned int > > +event) { > > + struct device *dev = ci->dev->parent; > > + struct ci_hdrc_imx_data *data = dev_get_drvdata(dev); > > + int ret = 0; > > + > > + switch (event) { > > + case CI_HDRC_IMX_HSIC_ACTIVE_EVENT: >

RE: [PATCH 0/4] usb: chipidea: imx: add HSIC support

> On 16.10.18 07:01, Peter Chen wrote: > > Most of NXP (Freescale) i.mx USB part has HSIC support, in this > > series, we add support for them, it should cover all imx6 and imx7d. I > > have no HSIC interface board which is supported by upstream kernel, so > > this p

RE: [PATCH 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

> On Tue, Oct 16, 2018 at 2:02 AM Peter Chen wrote: > > > > For USB HSIC, the data and strobe pin needs to be pulled down at > > default, we consider it as "idle" state. When the USB host is ready to > > be used, the strobe pin needs to be pulled up,

RE: [PATCH 2/4] usb: chipidea: imx: add HSIC support

> Hi Peter, > > I love your patch! Yet something to improve: > > [auto build test ERROR on peter.chen-usb/ci-for-usb-next] [also build test > ERROR > on v4.19-rc8 next-20181012] [if your patch is applied to the wrong git tree, > please > drop us a note to help improve the system] > > url: >

[PATCH 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups

For USB HSIC, the data and strobe pin needs to be pulled down at default, we consider it as "idle" state. When the USB host is ready to be used, the strobe pin needs to be pulled up, we consider it as "active" state. Signed-off-by: Peter Chen --- Documentation/devicetree/

[PATCH 3/4] usb: chipidea: host: override ehci->hub_control

The chipidea controller has some special requirements during suspend/resume, override common ehci->hub_control to implement it. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 74 + 1 file changed, 74 insertions(+) diff --git a/driv

[PATCH 2/4] usb: chipidea: imx: add HSIC support

is needed Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 153 + drivers/usb/chipidea/ci_hdrc_imx.h | 9 ++- drivers/usb/chipidea/usbmisc_imx.c | 131 +++ 3 files changed, 274 insertions(+), 19 deletions(-) diff

[PATCH 1/4] usb: chipidea: add flag for imx hsic implementation

NXP (Freecale) imx HSIC design has some special requirements, add some flags at host code to handle them. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 24 include/linux/usb/chipidea.h | 3 +++ 2 files changed, 27 insertions(+) diff --git a/drivers/usb

[PATCH 0/4] usb: chipidea: imx: add HSIC support

it on your board? Thanks. Peter Chen (4): usb: chipidea: add flag for imx hsic implementation usb: chipidea: imx: add HSIC support usb: chipidea: host: override ehci->hub_control doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups .../devicetree/bindings/usb/ci-hdrc-usb2.

[GIT PULL] usb: chipidea: changes for v4.20-rc1

| 6 ++ 9 files changed, 63 insertions(+), 17 deletions(-) Best regards, Peter Chen

RE: [RFT PATCH 1/2] xhci: Fix leaking USB3 shared_hcd at xhci removal

); > > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index > 0420eef..c928dbb > 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -719,8 +719,6 @@ static void xhci_stop(struct usb_hcd *hcd) > > /* Only halt host and free memory after both hcds are removed */ > if (!usb_hcd_is_primary_hcd(hcd)) { > - /* usb core will free this hcd shortly, unset pointer */ > - xhci->shared_hcd = NULL; > mutex_unlock(>mutex); > return; > } > -- > 2.7.4 Tested-by: Peter Chen Since it can't apply to v4.14 directly, I did change manually. Peter

RE: [RFT PATCH 2/2] xhci: handle port status events for removed USB3 hcd

> > Cc: > > Reported-by: Peter Chen > > Signed-off-by: Mathias Nyman > > --- > > drivers/usb/host/xhci-ring.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/usb/host/xhci-ring.c > > b/driv

RE: [PATCH 1/3] usb: host: xhci: fix oops when removing hcd

> Hi Peter, > > On Fri, Sep 21, 2018 at 09:48:43AM +0800, Peter Chen wrote: > > Type-C-to-A cable, and the USB3 HCD has already been NULL at that time. > > The oops log like below: > > > > [681.782288] xhci-hcd xhci-hcd.1.auto: remove, state 1 [681.787490] >

[PATCH 2/3] usb: host: xhci: return -ESHUTDOWN when removing hcd

endpoint command [74.018737] xhci-hcd xhci-hcd.1.auto: USB bus 4 deregistered [74.024446] xhci-hcd xhci-hcd.1.auto: remove, state 1 [74.029594] usb usb3: USB disconnect, device number 1 [74.062310] xhci-hcd xhci-hcd.1.auto: USB bus 3 deregistered Signed-off-by: Peter Chen --- drivers/usb/host

[PATCH 3/3] usb: host: xhci: return early for xhci_urb_dequeue when removing hcd

-hcd.1.auto: USB bus 3 deregistered Signed-off-by: Peter Chen --- drivers/usb/host/xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index 3113938063fd..1bcf27a9737d 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb

[PATCH 1/3] usb: host: xhci: fix oops when removing hcd

res: 0x080200c [681.824303] Memory Limit: none [682.518113] ---[ end Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Peter Chen --- drivers/usb/host/xhci-ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/h

[PATCH 0/3] usb: host: xhci: fix oops and timeout when removing hcd

. Peter Chen (3): usb: host: xhci: fix oops when removing hcd usb: host: xhci: return -ESHUTDOWN when removing hcd usb: host: xhci: return early for xhci_urb_dequeue when removing hcd drivers/usb/host/xhci-ring.c | 3 ++- drivers/usb/host/xhci.c | 6 -- 2 files changed, 6 insertions

Re: [PATCH 1/1] usb: host: xhci-plat: add platform TPL support

On Wed, Jul 18, 2018 at 2:45 PM Peter Chen wrote: > > The TPL support is used to identify targeted devices during > EH2.0 and EH3.0 certification test, the user can add "tpl-support" > at dts to enable this feature. > > Signed-off-by: Peter Chen > --- > drivers

Re: [PATCH] usb: chipidea: imx: enable OTG overcurrent in case USB subsystem is already started

On Tue, Sep 11, 2018 at 5:39 PM Nicolas Adell wrote: > > On Thursday 30 Aug 2018 à 16:44:01 (+0800), Peter Chen wrote: > > On Wed, Aug 29, 2018 at 8:22 PM Nicolas Adell > > wrote: > > > > > On Wednesday 29 Aug 2018 ą 17:37:19 (+0800), Peter Chen wrote: > &g

RE: [PATCH v3 4/6] usb: chipidea: Fix otg event handler

> v2: v3: no change > > drivers/usb/chipidea/otg.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/chipidea/otg.c b/drivers/usb/chipidea/otg.c index > db4ceff..f25d482 100644 > --- a/drivers/usb/chipidea/otg.c > +++ b/drivers/usb/chipidea/otg.c >

RE: [PATCH v2 2/7] doc: usb: ci-hdrc-usb2: Add pinctrl properties definition

> USB role (host/device), this can be an update of the pins routing or a simple > GPIO > value change. > > This patch introduces new optional "host" and "device" pinctrls. > If these pinctrls are defined by the device, they are respectively selected on > host/device role start. > >

RE: [PATCH v2 3/7] usb: chipidea: Support generic usb extcon

> Add compatibility for extcon-usb-gpio which can handle more than one cable per > instance, allowing coherency of USB cable states (USB/USB-HOST). These states > can be generated from ID or/and VBUS pins. > > In case only one extcon device is associated to the USB device, and this > device >

[GIT PULL] usb: chipidea: changes for v4.19-rc1

The following changes since commit dc748b66dbfbbfa187044f007d42d9cc01e5ab11: dt-bindings: usb: new ehci-npcm7xx dt (2018-06-25 21:59:15 +0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.19-rc1 for you to fetch

RE: Requesting for Guidance | Mohammad Ali

> My name is Mohammad Ali. I'm very curious to learn USB DEVICE DRIVER. But I > Just have knowledge of > C-Programming and the Linux operating system very basic knowledge of Device > driver(theory knowledge) i.e; how to > insert a module, check the module, writer simple device driver. can you

[PATCH 1/1] usb: host: xhci-plat: add platform TPL support

The TPL support is used to identify targeted devices during EH2.0 and EH3.0 certification test, the user can add "tpl-support" at dts to enable this feature. Signed-off-by: Peter Chen --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb

[GIT PULL] usb: chipidea: fixes for usb-linus

The following changes since commit 90f26cc6bb90b35040f4da0347f480ea9df6e2fc: usb: chipidea: host: fix disconnection detect issue (2018-06-26 09:59:34 +0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git/ tags/usb-ci-v4.18-rc4 for

RE: [PATCH v2] usb: chipidea: Always build ULPI code

> > void ci_ulpi_exit(struct ci_hdrc *ci) > { > + if (ci->platdata->phy_mode != USBPHY_INTERFACE_MODE_ULPI) > + return; > + Only above line is duplicated, others are ok, I will apply tomorrow, no need to send v3. Peter > if (ci->ulpi) { >

RE: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

> On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo wrote: > > > We can have the options in defconfig, but they can still be turned off > > for whatever reason and we get the hang. Really, missing a user > > selectable option in defconfig shouldn't result in a system hang. > > Yes, 100% agree and

RE: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

> > On Mon, Jun 25, 2018 at 7:24 AM Fabio Estevam wrote: > > > > From: Fabio Estevam > > > > Since commit 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51") > > the kernel hangs on a imx51-babbage board, when using the ULPI > > interface with the CONFIG_USB_CHIPIDEA_ULPI option

RE: [PATCH v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected

> > Fixes: 03e6275ae381087bd8 ("usb: chipidea: Fix ULPI on imx51") > Suggested-by: Lucas Stach > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Only propagate the error when CONFIG_USB_CHIPIDEA_ULPI is unselected > > drivers/usb/chipidea/core.c | 11 +++ > 1 file

[GIT PULL] usb: chipidea: fixes for v4.18-rc

the disconnection can't be detected. Peter Chen (1): usb: chipidea: host: fix disconnection detect issue drivers/usb/chipidea/host.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Best regards, Peter Chen

[PATCH 1/1] usb: typec: tcpm: fix logbuffer index is wrong if _tcpm_log is re-entered

ady updated by the 1st process, so it will get NULL pointer for updated logbuffer, the error message like below: tcpci 0-0050: Log buffer index 6 is NULL Cc: Heikki Krogerus Cc: Guenter Roeck Cc: Jun Li Signed-off-by: Peter Chen --- drivers/usb/typec/tcpm.c | 7 --- 1 file changed

RE: Can Only Enable 2 Classes Using Gadget ConfigFS

> > The attached script works only when 2 of the 3 given classes are enabled. The > failure is that UDC is not writeable. Is there a limit I am reaching? I did > not think I > would get to 32 endpoints, so is there a limitation due to my device's > construction? > > I can not find any good

RE: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

> > Admittedly without really understanding everything that is going on, I put > back the > deleted lines from this patch chunk and it started working again: > > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index > 19d60ed..af45aa32 100644 > ---

[PATCH 1/1] usb: chipidea: host: fix disconnection detect issue

t be detected by hardware. Fixes: 4e88d4c08301 ("usb: add a flag to skip PHY initialization to struct usb_hcd") Cc: Martin Blumenstingl Reported-by: Mats Karrman Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) d

RE: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

> >>> > >> And this is what the "decompiled" device tree entry for the USB > >> controller and phy look like: > >> > >>             usb@2184200 { > >>               compatible = "fsl,imx6q-usb", "fsl,imx27-usb"; > >>                 reg = <0x2184200 0x200>; > >>                

RE: Regression caused by: usb: add a flag to skip PHY initialization to struct usb_hcd

> >>> causes a regression for me on my SolidRun Hummingboard (NXP i.MX6 DL > >>> SoC with chipidea controller). > >>> > >>> Example: > >>> -- Cold boot of system. > >>> -- Plug in USB memory stick --> Attached OK. > >>> -- Mount disk --> OK, "ls" works > >>> -- Unmount disk --> OK > >>> --

RE: [PATCH 13/22] USB: chipidea: no need to check return value of debugfs_create functions

> > When calling debugfs functions, there is no need to ever check the return > value. The > function can work or not, but the code logic should never do something > different > based on this. > > Cc: Peter Chen > Signed-off-by: Greg Kroah-Hartman Tested

RE: [PATCH v5 12/14] staging: typec: tcpci: keep the not connecting cc line open

> > While set polarity, we should keep the not connecting cc line to be open. > keep the disconnected cc line open? Peter > Signed-off-by: Li Jun > --- > drivers/staging/typec/tcpci.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff

RE: [PATCH v5 01/14] dt-bindings: connector: add properties for typec

> Add bingdings supported by current typec driver, so user can pass all those > properties via dt. > %s/bingdings/bindings Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH resend] usb: chipidea: Don't select EXTCON

> > > > > > The patch doesn't remove extcon support from chipidea driver. > > > I just want to not select EXTCON unconditionally, but let the users > > > choose. If the users need extcon, they could enable EXTCON > > > themselves > > > > > > I just searched all the dts in arch/arm/boot/dts and >

RE: [PATCH resend] usb: chipidea: Don't select EXTCON

> > > > Sorry to reply late, are you really care 2KB code side? Since many > > users use EXTCON to handle vbus and id, it is hard just delete it. I > > could accept patch for your specific platforms, like: > > > > + select EXTCON if !ARCH_ > > The patch doesn't remove extcon support from

RE: [PATCH v2] usb: chipidea: Hook into mux framework to toggle usb switch

> >> @@ -3,6 +3,8 @@ config USB_CHIPIDEA > >>depends on ((USB_EHCI_HCD && USB_GADGET) || (USB_EHCI_HCD && > >> !USB_GADGET) || (!USB_EHCI_HCD && USB_GADGET)) && HAS_DMA > >>select EXTCON > >>select RESET_CONTROLLER > >> + select MULTIPLEXER > >> + select MUX_GPIO > > > > The above

RE: [PATCH v2] usb: chipidea: Hook into mux framework to toggle usb switch

> --- a/drivers/usb/chipidea/Kconfig > +++ b/drivers/usb/chipidea/Kconfig > @@ -3,6 +3,8 @@ config USB_CHIPIDEA > depends on ((USB_EHCI_HCD && USB_GADGET) || (USB_EHCI_HCD > && !USB_GADGET) || (!USB_EHCI_HCD && USB_GADGET)) && HAS_DMA > select EXTCON > select RESET_CONTROLLER

RE: [PATCH resend] usb: chipidea: Don't select EXTCON

> drivers/usb/chipidea/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig index > 785f0ed037f7..97509172d536 100644 > --- a/drivers/usb/chipidea/Kconfig > +++ b/drivers/usb/chipidea/Kconfig > @@ -1,7 +1,6 @@ > config

RE: About patchwork for linux-usb

> > > > > > At some situations, we may need to save reviewing patches from > > > > > > web, but I can't find linux-usb at > > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F > > > > > %2Fp > > > > > atchwork.k > > > > > > > > >

[PATCH 5/5] usb: chipidea: imx: Fix ULPI on imx53

m code and disables phy power management from the core. Signed-off-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/chipidea/ci_hdrc_imx.c |

[PATCH 4/5] usb: chipidea: imx: Cleanup ci_hdrc_imx_platform_flag

From: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Some trivial cleanups, that do not change functionality. Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +

[PATCH 1/5] usb: chipidea: usbmisc: evdo is only specific to OTG port

From: Michael Trimarchi <mich...@amarulasolutions.com> The USB_PHY_CTRL_FUNC is used specific for OTG port as described in user manual. EVDO need to be set only for index 0 that correspond to OTG port Signed-off-by: Michael Trimarchi <mich...@amarulasolutions.com> Signed-off-by

[PATCH 0/5] usb: chipidea: updates for v4.17-rc1

Hi Greg, This series including the bug fix for imx53 and some cleanups. Due to network problem during nxp and qualcomm merge, I can't do ssh for kernel.org currently, I am sorry I can't upload my code, then can't send pull request either. I hope ssh access can be recovered soon. Thanks. Michael

[PATCH 2/5] usb: chipidea: usbmisc: evdo can be set e/o reset

From: Michael Trimarchi <mich...@amarulasolutions.com> evdo bit can be set or reset. We can not trust evdo bit status after bootloader stage Signed-off-by: Michael Trimarchi <mich...@amarulasolutions.com> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/chipidea/

[PATCH 3/5] usb: chipidea: usbmisc: small clean up

From: Michael Trimarchi <mich...@amarulasolutions.com> The register write can be done outside the if and else condition Signed-off-by: Michael Trimarchi <mich...@amarulasolutions.com> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/chipidea/usbmisc_imx.c | 3 +

RE: About patchwork for linux-usb

> > > > At some situations, we may need to save reviewing patches from > > > > web, but I can't find linux-usb at > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fp > > > atchwork.k > > > > ernel.org%2F=02%7C01%7Cpeter.chen%40nxp.com%7Cbef6ada7885641ed5 > > > >

RE: About patchwork for linux-usb

> > > > At some situations, we may need to save reviewing patches from web, > > but I can't find linux-usb at > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.k > ernel.org%2F=02%7C01%7Cpeter.chen%40nxp.com%7Cbef6ada7885641ed5 >

RE: [PATCH] usb: chipidea: move extcon initial state read

cable->connected = false; > + } > + > + cable = >platdata->id_extcon; > + if (!IS_ERR(cable->edev)) { > + ret = extcon_get_state(cable->edev, EXTCON_USB_HOST); > + if (ret) > + cable->connected = true; &g

About patchwork for linux-usb

Hi Greg, At some situations, we may need to save reviewing patches from web, but I can't find linux-usb at https://patchwork.kernel.org/, any there any patchworks for linux-usb mailist at Internet? Thanks. Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in

[PATCH 1/1] usb: host: xhci: do not return error status for URB

completion interrupt for SETUP packet is needed for USB EH2.0 SINGLE_STEP_SET_FEATURE Test. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/host/xhci-ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-

RE: Continuous USB resets on NXP i.MX 6ULL device

> >> > > For non-core registers, i.mx6ull can use i.mx6q as its base setting, > > the bits you mentioned may also be reserved at imx6qdl RM. > > > just for my understanding: MX6_BM_NON_BURST_SETTING is a no-op on > i.MX6ULL or not properly documented in reference manual? Not properly documented

Re: Continuous USB resets on NXP i.MX 6ULL device

s its base setting, the bits you mentioned may also be reserved at imx6qdl RM. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH usb-next v10 2/8] usb: add a flag to skip PHY initialization to struct usb_hcd

de/linux/usb/hcd.h b/include/linux/usb/hcd.h > index 176900528822..693502c84c04 100644 > --- a/include/linux/usb/hcd.h > +++ b/include/linux/usb/hcd.h > @@ -151,6 +151,12 @@ struct usb_hcd { > unsignedmsix_enabled:1; /* driver has MSI-X enabled? */ > unsig

Re: Continuous USB resets on NXP i.MX 6ULL device

and PHY register before HUB connected. You can open disable runtime pm to test first, if it can reproduce, then just compare directly; if it can't reproduce, you need to open AHB clock for USB at CCM first. for i in $(find /sys -name control | grep usb);do echo on > $i;echo "echo on

RE: Bugged initial state with Chipidea driver

> Subject: Bugged initial state with Chipidea driver > > Hi, > > In the Chipidea driver the extcon state is read early in the initialization > and > notifications for extcon events are only enabled at the end of the > initialization. If the > extcon state changes in between the driver will

Re: WARN: Success on ctrl setup TRB without IOC set??

On Fri, Feb 09, 2018 at 11:39:28AM +0200, Mathias Nyman wrote: > On 09.02.2018 04:03, Peter Chen wrote: > >On Fri, Feb 09, 2018 at 09:59:46AM +0800, Peter Chen wrote: > >>On Wed, Feb 07, 2018 at 03:43:23PM +0200, Mathias Nyman wrote: > >>>On 07.02.2018 11:45, Pete

Re: WARN: Success on ctrl setup TRB without IOC set??

On Fri, Feb 09, 2018 at 09:59:46AM +0800, Peter Chen wrote: > On Wed, Feb 07, 2018 at 03:43:23PM +0200, Mathias Nyman wrote: > > On 07.02.2018 11:45, Peter Chen wrote: > > >Hi Mathias, > > > > > >I am implementing USB2 EHSET SINGLE_STEP_SET_F

Re: WARN: Success on ctrl setup TRB without IOC set??

On Wed, Feb 07, 2018 at 03:43:23PM +0200, Mathias Nyman wrote: > On 07.02.2018 11:45, Peter Chen wrote: > >Hi Mathias, > > > >I am implementing USB2 EHSET SINGLE_STEP_SET_FEATURE Test for XHCI port, > >(see ehset_single_step_set_feature for EHCI), it needs to

WARN: Success on ctrl setup TRB without IOC set??

, and returns -ESHUTDOWN for URB. Any reasons why we don't allow completion interrupt for SETUP stage? Thanks. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 2/2] usb: chipidea: imx: Fix ULPI on imx53

On Tue, Feb 06, 2018 at 04:50:41PM +0100, Sebastian Reichel wrote: > Hi Peter, > > On Mon, Jan 29, 2018 at 11:33:15AM +0800, Peter Chen wrote: > > On Wed, Jan 24, 2018 at 06:14:39PM +0100, Sebastian Reichel wrote: > > > Traditionally, PORTSC should be set befor

RE: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

> > Martin, you design has no problem for most of cases, but some hardware > > needs special sequence for phy control. I will give an example below. > great to hear that this should work for most devices! > > >> it would be great if you could explain the issue behind this (and > >> thereby

[PATCH v2 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

completion, then the qtd completion can be notified by hardware interrupt. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- Changes for v2: - Add flag "QTD_IOC" in parameter for qtd_fill drivers/usb/host/ehci-q.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff

Re: [PATCH 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

On Thu, Feb 01, 2018 at 02:24:29PM -0500, Alan Stern wrote: > On Thu, 1 Feb 2018, Peter Chen wrote: > > > At former code, the SETUP stage does not enable interrupt > > for qtd completion, it relies on IAA watchdog to complete > > interrupt, then the transcation wou

[PATCH 1/1] usb: host: ehci: use correct device pointer for dma ops

t sysdev pointer from usb_bus") Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/host/ehci-hub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index facafdf..d7641cb 100644 --- a/drivers/usb/h

[PATCH 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

completion, then the qtd completion can be notified by hardware interrupt. Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/host/ehci-q.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-q.c b/drivers/usb/host/ehci-q.c index 8815832..4

Re: [PATCH 2/2] usb: chipidea: imx: Fix ULPI on imx53

pm_runtime_put_noidle(>dev); > } > ci_hdrc_remove_device(data->ci_pdev); > + if (data->override_phy_control) > + usb_phy_shutdown(data->phy); > imx_disable_unprepare_clks(>dev); > Sebastian, I have a question, do you have any USB

RE: [RFC/RFT usb-next v1 5/6] usb: chipidea: do not set the "phy" field in struct usb_hcd

> > > >> > >> Now that usb_add_hcd parses all generic PHYs anyways the code which > >> skips initialization of a single PHY will go away. > >> Remove the code which sets struct usb_hcd's phy field from the > >> chipidea driver as this field will go away soon. > >> > >> Signed-off-by: Martin

  1   2   3   4   5   6   7   8   9   10   >