Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-06 Thread Tony Lindgren
* Tony Lindgren [181206 07:48]: > * Johan Hovold [181206 06:00]: > > How do switch modes by the way? > > The flash mode gets enabled with the control GPIOs. I just > did a quick test patch for phy-mapphone-mdm6600 using module > param for that. Then additiona

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-06 Thread Tony Lindgren
Hi, * Johan Hovold [181206 06:00]: > On Wed, Dec 05, 2018 at 05:54:07PM -0800, Tony Lindgren wrote: ... > > idVendor 0x22b8 > > idProduct 0x4281 > > This PID is not included in your patch however. Oops sorry did a cat on wrong two trimmed

Re: [PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-05 Thread Tony Lindgren
Hi, * Johan Hovold [181205 06:17]: > On Sun, Dec 02, 2018 at 05:34:24PM -0800, Tony Lindgren wrote: > > On Motorola Mapphone devices such as Droid 4 there are five USB ports > > that do not use the same layout as Gobi 1K/2K/etc devices listed in > > qcserial.c. So

[PATCH] USB: qcaux: Add Motorola modem UARTs

2018-12-02 Thread Tony Lindgren
On Motorola Mapphone devices such as Droid 4 there are five USB ports that do not use the same layout as Gobi 1K/2K/etc devices listed in qcserial.c. So we should use qcaux.c or option.c as noted by Dan Williams . The ff/ff/ff interfaces seem to always be UARTs on Motorola devices. And we should

Re: [PATCH 0/3] Fix OMAP EHCI probe & assorted cleanups

2018-09-11 Thread Tony Lindgren
* Laurent Pinchart [180911 16:12]: > On Tuesday, 11 September 2018 18:16:41 EEST Tony Lindgren wrote: > > * Laurent Pinchart [180911 15:10]: > > > Hello, > > > > > > This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing >

Re: [PATCH 0/3] Fix OMAP EHCI probe & assorted cleanups

2018-09-11 Thread Tony Lindgren
* Tony Lindgren [180911 15:21]: > * Laurent Pinchart [180911 15:10]: > > Tony, as patch 1/3 fixes a problem introduced by one of your DT changes, > > could > > you please review it ? Out of curiosity, is ethernet on the Pandaboard not > > part of your regression

Re: [PATCH 1/3] mfd: omap-usb-host: Use regular platform device probe mechanism

2018-09-11 Thread Tony Lindgren
* Laurent Pinchart [180911 15:10]: > --- a/drivers/mfd/omap-usb-host.c > +++ b/drivers/mfd/omap-usb-host.c > @@ -855,31 +856,14 @@ static struct platform_driver usbhs_omap_driver = { > .pm = _dev_pm_ops, > .of_match_table = usbhs_omap_dt_ids, > }, > +

Re: [PATCH 0/3] Fix OMAP EHCI probe & assorted cleanups

2018-09-11 Thread Tony Lindgren
* Laurent Pinchart [180911 15:10]: > Hello, > > This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing to > probe (patch 1/3) and then moves on to cleaning up related code (patches 2/3 > and 3/3). > > The first patch is a regression fix and should thus be merged before

Re: [RFC 0/5] Migrate AM35xx MUSB glue to device tree and enable MUSB

2018-07-03 Thread Tony Lindgren
* Adam Ford [180624 17:15]: > > It currently doesnt' work, but I am looking for ideas on > what I may have missed or done incorrectly. Check the drivers/phy/ti driver part and make sure that works and has pins and clocks configured. The rest should be pretty much generic stuff for musb as

Re: [RFC 3/5] ARM: OMAP2+: Add AM3517 MUSB setup to pdata quirks.

2018-07-03 Thread Tony Lindgren
* Adam Ford [180625 00:15]: > The pin muxing and clock definitions for the MUSB controller are > not done through the same registers/pin mux options, so this > explicitly configures the registers and pin-mux options for MUSB > on AM3517-EVM > > Signed-off-by: Adam Ford > > diff --git

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-20 Thread Tony Lindgren
Hi, Adding Rafael and linux-pm to Cc as well. * Felipe Balbi [180619 01:23]: > This is a direct consequence of not paying attention to the order of > things. If driver were to assume that pm_domain->activate() would do the > right thing for the device -- meaning that probe would run with an >

Re: [PATCH] usb: dwc3: of-simple: fix use-after-free on remove

2018-06-19 Thread Tony Lindgren
* Tero Kristo [180619 12:13]: > > TI SoC arm64 PM is done via genpd attached to each domain, which in turn > passes control messages to the PM firmware when transitions happen. See > drivers/soc/ti_sci_pm_domains.c for details. > > Not quite sure about the discussion following later, but there

[PATCH] phy: mapphone-mdm6600: Add runtime PM support for n_gsm on USB suspend

2018-05-06 Thread Tony Lindgren
. Cc: Marcel Partap <mpar...@gmx.net> Cc: Merlijn Wajer <merl...@wizzup.org> Cc: Michael Scott <hashcod...@gmail.com> Cc: NeKit <nekit1...@gmail.com> Cc: Pavel Machek <pa...@ucw.cz> Cc: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t...@at

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-26 Thread Tony Lindgren
* Dan Williams <d...@redhat.com> [180326 15:18]: > On Sun, 2018-03-25 at 13:52 -0700, Tony Lindgren wrote: > > Anyways, looks like qmi_wwan needs to be loaded before > > qcserial module, otherwise we get nine ttyUSB instances > > and ModemManager can't find any modems.

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [180326 00:24]: > Looks like on /dev/ttyUSB4 doing AT+COPS? or AT+CREG? won't work > while on /dev/gsmtty1 they work. So /dev/ttyUSB4 seems to a subset of > what's available over n_gsm on ch1. Anyways, good to hear that > /dev/ttyUSB4 can be u

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Pavel Machek [180325 22:57]: > Hi! > > > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > > > > to react to AT commands, and in particular reacts to ADT123; (; is > > > > > important). > > > > > > > > Is that to dial a voice call? > > > > > > Yes.

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Pavel Machek [180325 19:00]: > Hi! > > > > Hmm. Interesting. Anyway, for me ttyUSB4 is interesting, as it seems > > > to react to AT commands, and in particular reacts to ADT123; (; is > > > important). > > > > Is that to dial a voice call? > > Yes. And it is ATD123; not ATD.

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-25 Thread Tony Lindgren
* Pavel Machek <pa...@ucw.cz> [180324 20:03]: > On Sat 2018-03-24 07:25:17, Tony Lindgren wrote: > > * Dan Williams <d...@redhat.com> [180324 14:00]: > > > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > > > Does ofonod work

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-24 Thread Tony Lindgren
* Dan Williams [180324 14:00]: > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > Does ofonod work for you? I could not get that one to work... > > Because it's looking for a Gobi modem but the MDM6600 isn't one and > doesn't expose that layout (and doesn't really need

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-22 Thread Tony Lindgren
* Pavel Machek [180322 13:57]: > Hi! > > > idle lcd offphy-mapphone-mdm6600ohci-platform > > 153mW 284mW 344mW > > > > So it seems that MDM6600 is currently not yet idling even with it's > > radio turned off, but that's something that is

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-09 Thread Tony Lindgren
* Pavel Machek [180309 09:45]: > Hi! > > > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > > It is used on some Motorola Mapphone series of phones and tablets such > > as Droid 4. > ... > > So it seems that MDM6600 is currently not yet idling even with

[PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-08 Thread Tony Lindgren
<mark.rutl...@arm.com> Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Changes since v3: - Dropped unneede

Re: [PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-08 Thread Tony Lindgren
* Kishon Vijay Abraham I <kis...@ti.com> [180308 08:23]: > On Wednesday 07 March 2018 08:26 PM, Tony Lindgren wrote: > > +config PHY_MAPPHONE_MDM6600 > > + tristate "Motorola Mapphone MDM6600 modem USB PHY driver" > > + depends on OF && USB_SUPP

[PATCHv3] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-07 Thread Tony Lindgren
<mark.rutl...@arm.com> Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Changes since v2: - Dropped OTG

Re: [PATCHv2] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-02 Thread Tony Lindgren
* Kishon Vijay Abraham I <kis...@ti.com> [180302 08:04]: > Hi Tony, > > On Thursday 01 March 2018 09:20 AM, Tony Lindgren wrote: > > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > > It is used on some Motorola Mapphone series of phones and

[PATCHv2] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-02-28 Thread Tony Lindgren
<mark.rutl...@arm.com> Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Changes since v1: - Fixed up issues n

Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-02-28 Thread Tony Lindgren
* kbuild test robot [180219 07:47]: > > 354if (reset_gpio >= 0) >355gpiod_set_value_cansleep(reset_gpio, 1); Thanks this test can be just dropped. Will send out an updated version shortly. Regards, Tony -- To unsubscribe from this

Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-02-28 Thread Tony Lindgren
* Rob Herring <r...@kernel.org> [180219 20:41]: > On Sat, Feb 17, 2018 at 01:07:23PM -0800, Tony Lindgren wrote: > > The GPIOs controlling MDM6600 are used to power MDM660 on and off, to > > MDM660 a typo? Thanks fixing. > > +Required properties: > > +- c

Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

2018-02-28 Thread Tony Lindgren
fs_read+0x1c/0x118) > [] (__vfs_read) from [] (vfs_read+0x90/0x144) > [] (vfs_read) from [] (SyS_read+0x3c/0x74) > [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54) > > Solution was suggested by Tony Lindgren <t...@atomide.com>. > > Signed-off-by: Merlijn Wajer <mer

Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-02-18 Thread Tony Lindgren
* Sebastian Reichel <s...@kernel.org> [180218 00:32]: > On Sat, Feb 17, 2018 at 01:07:23PM -0800, Tony Lindgren wrote: > > For reference here is what I measured for total power consumption on > > an idle Droid 4 with and without USB related MDM6600 modules: > >

[PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-02-17 Thread Tony Lindgren
something that is beyond the control of this USB PHY driver. Cc: devicet...@vger.kernel.org Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: Sebastian Reichel <s...@ker

[PATCH] phy: dm816x-usb: Remove unused phy_data

2018-02-17 Thread Tony Lindgren
This is used by some TI USB PHY drivers but not this one, so we can just remove it. Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/phy/ti/phy-dm816x-usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/phy/ti/phy-dm816x-usb.c b/drivers/phy/ti/phy-dm816x

Re: [BUG] musb: broken isochronous transfer at TI AM335x platform

2018-02-16 Thread Tony Lindgren
* Matwey V. Kornilov [180215 17:55]: > [] 7.219456 d= 0.000997 [181.0 + 3.667] [ 3] IN : 4.5 > [T ] 7.219459 d= 0.03 [181.0 + 7.083] [800] DATA0: 53 da ... > [] 7.220456 d= 0.000997 [182 + 3.667] [ 3] IN : 4.5 > [

Re: [PATCH 4/4] ARM: dts: am43xx: Enable dual-role mode for USB1

2018-02-14 Thread Tony Lindgren
* Roger Quadros [180122 05:17]: > +Tony > > On 22/01/18 15:11, Roger Quadros wrote: > > USB1 port is micro-AB type and can function as peripheral > > as well as host. Enable dual-role mode for USB1. Looks like I don't have this one, please resend it separately when it's safe to

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Tony Lindgren
e for me from PM point of view: Tested-by: Tony Lindgren <t...@atomide.com> Unrelated to this patch, I also noticed that we now somehow higher idle power consumption initially when musb modules are loaded. It used to idle after that but now to get things to idle I had to plug and unplug a USB de

Re: power management problems in ehci-omap

2018-02-06 Thread Tony Lindgren
* Andreas Kemnade <andr...@kemnade.info> [180206 18:04]: > On Tue, 6 Feb 2018 09:17:37 -0800 > Tony Lindgren <t...@atomide.com> wrote: > > uarts=$(find /sys/class/tty/tty[SO]*/power/ -type d 2>/dev/null) > > for uart in $uarts; do > > echo enabled > $

Re: power management problems in ehci-omap

2018-02-06 Thread Tony Lindgren
* Andreas Kemnade <andr...@kemnade.info> [180206 16:56]: > On Tue, 6 Feb 2018 08:04:52 -0800 > Tony Lindgren <t...@atomide.com> wrote: > > > * Andreas Kemnade <andr...@kemnade.info> [180206 06:42]: > > > rechecked with a board with really no

Re: power management problems in ehci-omap

2018-02-06 Thread Tony Lindgren
* Andreas Kemnade [180206 06:42]: > rechecked with a board with really nothing connected there > Same behaviour I've just verified that my test board power consumption goes back to normal after rmmod ehci-omap with v4.15. For ehci PM, it might be a bit easier to do

Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

2017-12-11 Thread Tony Lindgren
* Felipe Balbi [171204 11:43]: > Roger Quadros writes: > > > The metastability workaround causes Erratic errors [1] > > on the HighSpeed USB PHY which can cause upto 2 seconds > > delay in enumerating to a USB host while in Gadget mode. > > > > Disable the

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Tony Lindgren
* Ladislav Michl <la...@linux-mips.org> [171128 17:01]: > On Tue, Nov 28, 2017 at 06:39:13AM -0800, Tony Lindgren wrote: > > Limiting things to C1 with cpuidle is probably what you need > > for having USB also working. > > With echo 1 > /sys/devices/system/cpu/c

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Tony Lindgren
* Ladislav Michl <la...@linux-mips.org> [171128 14:31]: > On Tue, Nov 28, 2017 at 06:11:31AM -0800, Tony Lindgren wrote: > > * Ladislav Michl <la...@linux-mips.org> [171128 09:42]: > > > On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > > >

Re: EHCI and MUSB do not discover devices without CONFIG_PM

2017-11-28 Thread Tony Lindgren
* Ladislav Michl [171128 09:42]: > On Tue, Nov 28, 2017 at 10:30:54AM +0100, Greg KH wrote: > > bit-banging an ir decoder, ugh, you are in for a world of hurt. Can't > > you put a chip on the device that does this for you in hardware? > > OMAP has DM timer which can be

Re: USB regression in next-20171108 with hub spamming

2017-11-09 Thread Tony Lindgren
* Felipe Balbi [171109 11:01]: > Felipe Balbi writes: > > Okay, found it. Testing a patch. > > Here's the patch, I'll send it formally shortly. Thanks yeah that fixes the issue for me, replied to your formal patch with a tested by.

Re: [PATCH] usb: core: message: remember to reset 'ret' to 0 when necessary

2017-11-09 Thread Tony Lindgren
Tested-by: Tony Lindgren <t...@atomide.com> > Fixes: 2e43f0fe379c ("usb: core: add a 'type' parameter to usb_get_status()") > Reported-by: Tony Lindgren <t...@atomide.com> > Signed-off-by: Felipe Balbi <felipe.ba...@linux.intel.com> > --- > drivers

Re: MUSB Error Handling

2017-11-02 Thread Tony Lindgren
* Bin Liu [171031 18:35]: > Hi, > > On Tue, Oct 31, 2017 at 12:56:40PM -0500, Adam Ford wrote: > > We have a situation where occasionally the USB glitches where the D- > > glitches low at or near an end of frame (EOF) or end of packet (EOP). > > We're using the TWL4030 with MUSB on

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

2017-10-05 Thread Tony Lindgren
686fef928bba ("timer: Prepare to change timer > callback argument type") in v4.14-rc3, but should be otherwise > stand-alone. Acked-by: Tony Lindgren <t...@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/2] USB: musb: PM fixes

2017-10-05 Thread Tony Lindgren
ete interrupt"). > > > > 3. In host mode, if a device is disconnected while the system is suspended, > > this will keep the controller runtime active after resume as the session > > bit is always set. > > Bin and Tony, any comments to this series? Oops so

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-08-14 Thread Tony Lindgren
hough, that I can try a second round to get the acks. As long as it's been compile tested with omap2plus_defconfig: Acked-by: Tony Lindgren <t...@atomide.com> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm

2017-08-14 Thread Tony Lindgren
.c | 2 +- > > > > > > > > For my own reference: > > > > Acked-for-MFD-by: Lee Jones <lee.jo...@linaro.org> > > > > > > Same here: ok for 4.14 or something needed? > > > > Can this patch be applied on its own, or do

Re: [linux-next][PATCH] usb: dwc3: omap: remove IRQ_NOAUTOEN used with shared irq

2017-06-29 Thread Tony Lindgren
* Vignesh R [170628 21:21]: > > > On Thursday 29 June 2017 05:01 AM, Strashko, Grygorii wrote: > > IRQ_NOAUTOEN can't be used with shared IRQs and Kernel now will triggers > > warning if it happns, since commit 04c848d39879 ("genirq: Warn when > > IRQ_NOAUTOEN is used with

Re: usb-related linux-next boot failures

2017-06-28 Thread Tony Lindgren
Felipe Balbi [170628 01:32]: > Greg KH writes: > > On Tue, Jun 27, 2017 at 02:28:56PM -0400, Carlos Hernandez wrote: > >> Still seeing AM57xx/DRA72/DRA7x usb-related boot failures on linux-next... > > > > Is this a regression? If so,

[PATCH] phy: cpcap-usb: Fix missing return statement

2017-06-12 Thread Tony Lindgren
("phy: cpcap-usb: Add CPCAP PMIC USB support") Reported-by: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/phy/motorola/phy-cpcap-usb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/motorola/phy-cpcap-u

[PATCHv3 0/3] Make ohci-platform usable for omap3/4/5

2017-05-25 Thread Tony Lindgren
- Just remove ohci-omap3 as it needs LS/FS USB PHY not available on most hardware Tony Lindgren (3): usb: host: ohci-platform: Add basic runtime PM support usb: host: ohci-platform: Add support for omap3 and later usb: host: ohci-omap3

[PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

2017-05-25 Thread Tony Lindgren
> Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/host/ohci-platform.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/hos

[PATCH 3/3] usb: host: ohci-omap3: Remove driver in favor of ohci-platform

2017-05-25 Thread Tony Lindgren
uadros <rog...@ti.com> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/host/Kconfig | 6 +- drivers/usb/host/Makefile | 1 - drivers/usb/host/ohci-omap3.c | 211 -

[PATCH 2/3] usb: host: ohci-platform: Add support for omap3 and later

2017-05-25 Thread Tony Lindgren
Sebastian Reichel <sebastian.reic...@collabora.co.uk> Acked-by: Alan Stern <st...@rowland.harvard.edu> Acked-by: Roger Quadros <rog...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 1 + drivers/usb/host/ohci-platf

Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

2017-05-23 Thread Tony Lindgren
* Alan Stern <st...@rowland.harvard.edu> [170523 09:57]: > On Mon, 22 May 2017, Tony Lindgren wrote: > > Alan, do you have some better ideas for the ohci_platform_remove() > > path below? ... > > --- a/drivers/usb/host/ohci-platform.c > > +++ b/drivers/usb/h

Re: [PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

2017-05-23 Thread Tony Lindgren
* Roger Quadros <rog...@ti.com> [170523 00:14]: > On 22/05/17 19:00, Tony Lindgren wrote: > > --- a/drivers/usb/host/ohci-platform.c > > +++ b/drivers/usb/host/ohci-platform.c > > @@ -290,7 +294,14 @@ static int ohci_platform_remove(struct platform_device > >

[PATCHv4] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-05-22 Thread Tony Lindgren
are done using cpcap-adc IIO ADC driver. Cc: devicet...@vger.kernel.org Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Acked-by: Rob Herring <r...@kernel.org> Tested-by: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t..

Re: [PATCH 2/3] usb: host: ohci-platform: Add support for omap3 and later

2017-05-22 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [170522 09:03]: > With the runtime PM implemented for ohci-platform driver, we can > now support omap3 and later OHCI by adding one device tree > property. And the related dts patch from v1 series I can queue separately when people are happy

[PATCHv2 0/3] Make ohci-platform usable for omap3/4/5

2017-05-22 Thread Tony Lindgren
Hi, Here's v2 of this series. Regards, Tony Changes since v1: - Update runtime PM support for ohci based on Alan's comments and more testing - Just remove ohci-omap3 as it needs LS/FS USB PHY not available on most hardware Tony Lindgren (3): usb: host: ohci-platform: Add basic runtime

[PATCH 1/3] usb: host: ohci-platform: Add basic runtime PM support

2017-05-22 Thread Tony Lindgren
> Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk> Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Alan, do you have some better ideas for the ohci_platform_remove() path below? --- drivers/usb/host/ohci-

[PATCH 2/3] usb: host: ohci-platform: Add support for omap3 and later

2017-05-22 Thread Tony Lindgren
Sebastian Reichel <sebastian.reic...@collabora.co.uk> Acked-by: Alan Stern <st...@rowland.harvard.edu> Acked-by: Roger Quadros <rog...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 1 + drivers/usb/host/ohci-platf

[PATCH 3/3] usb: host: ohci-omap3: Remove driver in favor of ohci-platform

2017-05-22 Thread Tony Lindgren
tian.reic...@collabora.co.uk> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/host/Kconfig | 6 +- drivers/usb/host/Makefile | 1 - drivers/usb/host/ohci-omap3.c | 211 -- 3 files changed, 5 insertions(+), 213 deletio

Re: [PATCH 1/4] usb: host: ohci-platform: Add basic runtime PM support

2017-05-19 Thread Tony Lindgren
* Alan Stern <st...@rowland.harvard.edu> [170518 10:24]: > On Wed, 17 May 2017, Tony Lindgren wrote: > > > This is needed in preparation of adding support for omap3 and > > later OHCI. The runtime PM will only do something on platforms > > that implement it. >

Re: [PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform

2017-05-19 Thread Tony Lindgren
* Sebastian Reichel <s...@kernel.org> [170518 10:25]: > Hi, > > On Thu, May 18, 2017 at 07:08:58AM -0700, Tony Lindgren wrote: > > * Sebastian Reichel <s...@kernel.org> [170518 02:18]: > > > On Wed, May 17, 2017 at 03:59:21PM -0700, Tony Lindgren wrote: >

Re: [PATCH 1/4] usb: host: ohci-platform: Add basic runtime PM support

2017-05-18 Thread Tony Lindgren
* Alan Stern <st...@rowland.harvard.edu> [170518 08:28]: > On Wed, 17 May 2017, Tony Lindgren wrote: > > > This is needed in preparation of adding support for omap3 and > > later OHCI. The runtime PM will only do something on platforms > > that implement it. >

Re: [PATCH 2/4] usb: host: ohci-platform: Add support for omap3 and later

2017-05-18 Thread Tony Lindgren
* Alan Stern <st...@rowland.harvard.edu> [170518 08:41]: > On Wed, 17 May 2017, Tony Lindgren wrote: > > > With the runtime PM implemented for ohci-platform driver, we can > > now support omap3 and later OHCI by adding one device tree > > property. ... > >

Re: [PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform

2017-05-18 Thread Tony Lindgren
* Sebastian Reichel <s...@kernel.org> [170518 02:18]: > On Wed, May 17, 2017 at 03:59:21PM -0700, Tony Lindgren wrote: > > We can't just remove ohci-omap3 as that could make some people's > > systems unusable for keyboard and mouse. Let's print a warning for > > now,

[PATCH 0/4] Make ohci-platform usable for omap3/4/5

2017-05-17 Thread Tony Lindgren
instead. Regards, Tony Tony Lindgren (4): usb: host: ohci-platform: Add basic runtime PM support usb: host: ohci-platform: Add support for omap3 and later usb: host: ohci-omap3: Print warning to get people to use ohci-platform ARM: dts: Add remote-wakeup-connected for omap OHCI

[PATCH 1/4] usb: host: ohci-platform: Add basic runtime PM support

2017-05-17 Thread Tony Lindgren
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/host/ohci-platform.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c --- a/dr

[PATCH 4/4] ARM: dts: Add remote-wakeup-connected for omap OHCI

2017-05-17 Thread Tony Lindgren
nesas.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- arch/arm/boot/dts/omap3.dtsi | 1 + arch/arm/boot/dts/omap4.dtsi | 1 + arch/arm/boot/dts/omap5.dtsi | 1 + 3 files changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi --- a/arch/arm/boot

[PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform

2017-05-17 Thread Tony Lindgren
g...@ti.com> Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/host/ohci-omap3.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/ohci-omap3.c b/drivers/usb/host/ohci-omap3.c --- a/drivers/usb/h

[PATCH 2/4] usb: host: ohci-platform: Add support for omap3 and later

2017-05-17 Thread Tony Lindgren
himoda...@renesas.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 1 + drivers/usb/host/ohci-platform.c | 5 + 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/usb-ohci.t

Re: [PATCH] usb: ohci: Allow ohci on omap5 also

2017-05-16 Thread Tony Lindgren
Hi, * Tony Lindgren <t...@atomide.com> [160913 15:48]: > * Alan Stern <st...@rowland.harvard.edu> [160910 19:27]: > > On Fri, 9 Sep 2016, Alan Stern wrote: > > > > > On Fri, 9 Sep 2016, Tony Lindgren wrote: > > > > > > > * Alan Stern <

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170512 10:43]: > On Fri, May 12, 2017 at 10:21:35AM -0700, Tony Lindgren wrote: > > * Bin Liu <b-...@ti.com> [170512 08:24]: > > > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: > > > > OK. No better ideas except

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170512 08:24]: > On Fri, May 12, 2017 at 07:58:49AM -0700, Tony Lindgren wrote: > > OK. No better ideas except I think we should probably have a separate > > timer for keeping VBUS on after state changes eventually. > > Currently with the patc

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-12 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170512 06:43]: > On Thu, May 11, 2017 at 02:06:28PM -0700, Tony Lindgren wrote: > > > > Well maybe the minimal fix for now is just pretty much back to > > square one of this thread. This should keep VBUS always on. > > Then we can figure

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-11 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170511 13:47]: > On Thu, May 11, 2017 at 01:23:06PM -0700, Tony Lindgren wrote: > > > > Maybe try something like below, compile tested only. I don't > > think I have any USB modem here to test with. > > The patch below doesn't h

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-11 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [170511 13:26]: > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > --- a/drivers/usb/musb/musb_dsps.c > +++ b/drivers/usb/musb/musb_dsps.c > @@ -270,6 +270,10 @@ static int dsps_check_status(struct musb *mus

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-11 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170511 13:05]: > On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > > > > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON > > solves this issue? > > We don't cut VBUS intentionally for host mode (when

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-11 Thread Tony Lindgren
* Bin Liu [170511 12:23]: > On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: > [...] > > > > > The otg state machine implementation in the musb drivers are kind of > > > > > strange. > > > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device > > > > >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-05-11 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170511 11:53]: > On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote: > > * Bin Liu <b-...@ti.com> [170327 10:17]: > > > On Mon, Mar 27, 2017 at 09:59:47AM -0700, Tony Lindgren wrote: > > > > * Moreno Bartalucci <

Re: [PATCH v2 00/10] usb: musb: tusb6010_omap: Convert to DMAengine

2017-05-10 Thread Tony Lindgren
1]. > After the first 9 patch the legacy DMA mode is going to be stable with g_ncm, > it > boots to prompt, and survives the stress test [1]. Best to merge that as a separate fix. I already replied with acks to few patches, and for the entire series please feel free to add: Tested-by: T

Re: [PATCH v2 09/10] ARM: OMAP2+: DMA: Add slave map entries for 24xx external request lines

2017-05-10 Thread Tony Lindgren
MA request numbers for DT booted case on omap24xx since the tusb6010 stack > is not yet supports DT boot. > > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> Best to merge this together with the series: Acked-by: Tony Lindgren <t...@atomide.com> -- To unsubscribe fro

Re: [PATCH v2 05/10] usb: musb: tusb6010_omap: Do not reset the other direction's packet size

2017-05-10 Thread Tony Lindgren
> To fix this issue, only modify the TX or RX part of the register. Oh this is a nice one. I think we've always had this. Bin, care to merge this one as a fix? This should have: Fixes: 550a7375fe72 ("USB: Add MUSB and TUSB support") Tested-by: Tony Lindgren <t...@atomide.com>

Re: [PATCH v2 01/10] dmaengine: omap-dma: port_window support correction for both direction

2017-05-10 Thread Tony Lindgren
) > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> > Cc: Russell King <li...@armlinux.org.uk> > Cc: dmaeng...@vger.kernel.org > Cc: dan.j.willi...@intel.com > Cc: vinod.k...@intel.com Tested-by: Tony Lindgren <t...@atomide.com> -- To unsubscribe from this

Re: [PATCHv3] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-05-08 Thread Tony Lindgren
* Kishon Vijay Abraham I <kis...@ti.com> [170507 23:23]: > Hi Tony, > > On Monday 10 April 2017 09:49 AM, Tony Lindgren wrote: > > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > > multiplexing USB PHY. > > > > This USB PHY can o

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

2017-05-08 Thread Tony Lindgren
* Peter Ujfalusi <peter.ujfal...@ti.com> [170508 08:15]: > Tony, > > On 2017-05-06 01:55, Tony Lindgren wrote: > > OK I verified that with the current mainline kernel using dma > > and g_ether and your patches 1 to 3 I can run the variable size > > ping test lo

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

2017-05-05 Thread Tony Lindgren
* Peter Ujfalusi <peter.ujfal...@ti.com> [170505 08:20]: > On 2017-05-05 16:37, Peter Ujfalusi wrote: > > On 2017-05-05 00:05, Tony Lindgren wrote: > > > And this sync gpmc issue seems to be timing related. Setting > > > DEBUG in tusb6010_omap.c makes it happen e

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

2017-05-04 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [170504 12:43]: > Hi, > > * Peter Ujfalusi <peter.ujfal...@ti.com> [170503 04:00]: > > With the port_window support in DMAengine and the sDMA driver we can > > convert the driver to DMAengine. > > Actually looks like thi

Re: [PATCH 4/4] usb: musb: tusb6010_omap: Convert to DMAengine API

2017-05-04 Thread Tony Lindgren
Hi, * Peter Ujfalusi [170503 04:00]: > With the port_window support in DMAengine and the sDMA driver we can > convert the driver to DMAengine. Actually looks like this patch still has some issues.. Pinging the n8x0 with for example ping -s1 causes things to stop working.

Re: [PATCH 0/4] usb: musb: tusb6010_omap: Convert to DMAengine

2017-05-04 Thread Tony Lindgren
river to DMAengine API. > > I have tested the set on top of next-20170503 on Nokia n810 with nfsroot using > CDC Ethernet (g_cdc) and copying files with scp to/form my host. Thanks for doing this! For this series: Acked-by: Tony Lindgren <t...@atomide.com> > To force that the

[PATCHv3] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-04-09 Thread Tony Lindgren
are done using cpcap-adc IIO ADC driver. Cc: devicet...@vger.kernel.org Cc: Marcel Partap <mpar...@gmx.net> Cc: Michael Scott <michael.sc...@linaro.org> Acked-by: Rob Herring <r...@kernel.org> Tested-by: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t..

[PATCH] usb: musb: Fix trying to suspend while active for OTG configurations

2017-04-07 Thread Tony Lindgren
t <laurent.pinch...@ideasonboard.com> Reported-by: Peter Ujfalusi <peter.ujfal...@ti.com> Tested-by: Peter Ujfalusi <peter.ujfal...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/usb/musb/musb_host.c | 9 + 1 file changed, 5 insertions(+), 4 delet

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-07 Thread Tony Lindgren
* Peter Ujfalusi <peter.ujfal...@ti.com> [170406 10:07]: > Tony, > > On 04/05/2017 06:29 PM, Tony Lindgren wrote: > > * Tony Lindgren <t...@atomide.com> [170405 06:53]: > > > * Peter Ujfalusi <peter.ujfal...@ti.com> [170405 00:15]: > > > > To

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-07 Thread Tony Lindgren
* Bin Liu <b-...@ti.com> [170406 12:09]: > On Wed, Apr 05, 2017 at 08:29:55AM -0700, Tony Lindgren wrote: > > If the the port is configured as OTG, we should not need to > > try to force any states during init. The change below will stop > > True, but the code has been

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-05 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [170405 06:53]: > * Peter Ujfalusi <peter.ujfal...@ti.com> [170405 00:15]: > > To be precise this is what I have tried: > > - boot w/o cable connected > > - boot w/ board connected to PC (device mode) > > - boot w/ OTG-A ca

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-05 Thread Tony Lindgren
* Peter Ujfalusi <peter.ujfal...@ti.com> [170405 00:15]: > Tony, > > On 2017-04-05 03:36, Tony Lindgren wrote: > > * Tony Lindgren <t...@atomide.com> [170404 07:06]: > > > * Bin Liu <b-...@ti.com> [170404 05:30]: > > > > On Tue,

Re: usb: musb: regression since 4.9 on omap4-panda-es (caused by d8e5f0eca1e8)

2017-04-04 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [170404 07:06]: > * Bin Liu <b-...@ti.com> [170404 05:30]: > > On Tue, Apr 04, 2017 at 10:09:50AM +0300, Peter Ujfalusi wrote: > > > Tony, > > > > > > since 4.9 (4.8 was fine) I can not boot omap4-panda-es if the

  1   2   3   4   5   6   7   >